Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Oct 2008 22:20:55 +0000] rev 330
Add underscore in two word div class names in templates (nick_name, short_name, partial_path).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 14 Oct 2008 21:39:57 +0000] rev 329
Add is_featured boolean property to the Work model, so that Works can be
designated as "featured" items in various places in the UI. This will be
used to allow Sponsors, Programs, and Organizations to select Documents that
should be included in their sidebar menus.
Perhaps featured "site" Documents, such as site-wide Terms of Service,
should probably be listed below the "User (sign-out)" menu, since the User
will have to read and agree to these before being allowed to use the site.
A collapsable Javascript sidebar is probably going to be needed soon...
Patch by: Todd Larsen
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Oct 2008 21:33:57 +0000] rev 328
Add missing blank lines, clean up the doc string and remove white spaces at the end of the lines in reflistprop.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Oct 2008 21:06:23 +0000] rev 327
Move <div id='notice'> into notice block in base.html template. Change formatting of notice block to make it much easier to "parse" visually. This patch is based on comments to r722.
http://code.google.com/p/soc/source/detail?r=722
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 14 Oct 2008 21:02:28 +0000] rev 326
Add a third-party ReferenceListProperty class. This is going to be used to
contain the references to Questions that make up a Quiz.
Patch by: Todd Larsen
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Oct 2008 20:33:20 +0000] rev 325
Fix some defects for lookup user view. More information about the patch can be found under the link below.
http://groups.google.com/group/melange-soc-dev/browse_thread/thread/5d378c8d3679945f/d1e7cc3a53adda4e
Patch by: Chen Lunpeng
Review by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Oct 2008 16:10:07 +0000] rev 324
Add missing import in soc/views/site/sponsor/list.py which caused exception when app was deployed and first site you visited was "List Site Sponsors". Update files according to recent django update and django backwards incompatibility (for example newforms is changed to forms).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Oct 2008 16:00:59 +0000] rev 323
Load ../vendor/django into trunk/app/django.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Oct 2008 12:36:55 +0000] rev 322
Fixed imports sorting based on comments for r751.
http://code.google.com/p/soc/source/detail?r=751
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Oct 2008 12:02:42 +0000] rev 321
Some indentations fixes. Changed all the email=id function arguments to email=id.email().
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 13 Oct 2008 22:32:09 +0000] rev 320
Some indentations fixes and ugettext_lazy() wrap up for DEF_DEV_LOGOUT_LOGIN_MSG_FMT in access.py.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 13 Oct 2008 22:22:16 +0000] rev 319
Rename soc/logic/models/settings.py to model site_settings.py and apply import name change to soc/views/site/home.py
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 13 Oct 2008 22:18:54 +0000] rev 318
Fix typos in doc string in sponsor.py and settings.py
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 13 Oct 2008 22:04:42 +0000] rev 317
Remove spaces between dict key name and colon. Fix some typos based on comments http://code.google.com/p/soc/source/detail?r=739.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 13 Oct 2008 21:54:51 +0000] rev 316
Add missing blank lines between imports and sort all of the imports.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 13 Oct 2008 21:34:07 +0000] rev 315
Add missing blank lines between imports in access.py module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 13 Oct 2008 17:41:20 +0000] rev 314
Rearrange imports in home.py so they apply to new discussed format (separate "from ..." and "import ..." blocks). Add Delete Document functionality.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 13 Oct 2008 06:19:43 +0000] rev 313
Bugfixes to the latest revision
Some pages did not work due to missing imports, or wrongly
imported modules.
Patch by: Chen Lunpeng
Reviewd by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 13 Oct 2008 04:34:14 +0000] rev 312
Added missing models/__init__.py and removed empty logic/model directory
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 18:40:32 +0000] rev 311
Dictionaries need String values for keys
The cleanup patch earlier mistakenly used raw names as keys
to the dictionary (such as one would do in a function call).
This fixes that mistake.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 18:32:43 +0000] rev 310
Removed now-obsolete code from model.py and __init__.py
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 18:30:37 +0000] rev 309
Made the existing code use the new soc.logic.models
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 18:11:20 +0000] rev 308
Added invididual model logic files
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 16:50:28 +0000] rev 307
Also removed helper directory
Which somehow did not get removed with the last commit
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 16:47:39 +0000] rev 306
Removed obsolete logic directories and added one for model
The model/ directory will contain the Base logic classes.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 15:52:19 +0000] rev 305
Minor style and import fixes
Incorperated changes as suggested by Todd and Pawel.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 15:05:50 +0000] rev 304
Missing changes to soc.views.helper.access
Due to having to manually do the 'svn mv' of logic to helper,
the changes to access.py got lost, this commit fixes that.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 14:58:47 +0000] rev 303
Moved soc/logic/helper/access to soc/views/helper/access
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 12 Oct 2008 08:46:05 +0000] rev 302
Fix not working delete Sponsor functionality after recent commit. Add delete() method to Base class. Make soc.views.site.sponsor.delete() request handler use this method.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 12 Oct 2008 08:43:41 +0000] rev 301
Fix not working isIdDeveloper() function after recent commit. There is still confusion within getFormFields method (email is not id), but this change doesn't address that problem.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 12 Oct 2008 01:08:41 +0000] rev 300
Changed location of the svn command in svn_load_dirs.pl script from '/usr/bin/svn' to 'svn'. That makes the script more universal and it should work on Linux, Windows and Mac OS X if the svn is in the PATH.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 00:12:53 +0000] rev 299
Refactor nearly all the soc.logic code to use the Base class
Instead of having a lot of duplicate code, this patch aims
to reduce this duplication by introducing a Base abstraction.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 00:08:54 +0000] rev 298
Replace almost all occurences of linkname with link_name
In an attempt to have some atomicness in these commits
this patch does a rename for the sake of consistency.
Not all were changed, but the next commit will address that.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 10 Oct 2008 13:14:24 +0000] rev 297
Load /Users/solydzajs/Downloads/google_appengine/ into
trunk/thirdparty/google_appengine.
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 10 Oct 2008 06:56:56 +0000] rev 296
Add missing __init__.py to soc/logic/helper folder (Caused home page not to work).
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 09 Oct 2008 23:50:00 +0000] rev 295
Removed now-obsolete getAltResponse* methods from simple.py
The getAltResponse* methods have been replaced by the check*
methods in soc.logic.helper.access.
Patch by: Sverre Rabbelier
Reviewed by: Pawel Solyga, Augie Fackler, Todd Larsen
Reviewed at: http://codereviews.googleopensourceprograms.com/1601
Review id: 1601
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 09 Oct 2008 23:48:20 +0000] rev 294
Refactor existing code to use the new access module
Instead of ending up with many different ways to do
access control, we end up having only one centralized
place wher access control is done.
Patch by: Sverre Rabbelier
Reviewed by: Pawel Solyga, Augie Fackler, Todd Larsen
Reviewed at: http://codereviews.googleopensourceprograms.com/1601
Review id: 1601
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 09 Oct 2008 23:38:27 +0000] rev 293
Add an access control module
The module's purpose is to check access requirements,
(such as being logged in), and raise an exception
containing a authentication request when the requirement
is not met.
Patch by: Sverre Rabbelier
Reviewed by: Pawel Solyga, Augie Fackler, Todd Larsen
Reviewed at: http://codereviews.googleopensourceprograms.com/1601
Review id: 1601
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 18:11:37 +0000] rev 292
Enable recently commited delete Sponsor request handler (added to map.py) and Delete button in Sponsor edit view. Still missing "Are you sure ?" question box.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 18:06:50 +0000] rev 291
Create a submit_buttons blocks in all edit view templates and put submit buttons in separate html table (not as part of the fields table anymore).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 15:10:51 +0000] rev 290
Create a submit_buttons block in group edit profile template so that submit buttons can be customized. Replace submit_message usage with new notice block (still work in progress in Lookup User views). Add customized edit profile template for Sponsor with delete button (not used yet, upcoming commit). Add delete Sponsor request handler.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 13:56:42 +0000] rev 289
Add notification bar block in base.html template.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 13:50:44 +0000] rev 288
Add #notice class declaration in soc.css for upcoming notification bar.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 13:49:41 +0000] rev 287
Update indexes in index.yaml file.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 08 Oct 2008 21:22:50 +0000] rev 286
Fix typo in getSponsorFromLinkName (key_name variable name instead of sponsor_key_name). Add deleteSponsor function for deleting Sponsor entities from datastore.
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 05 Oct 2008 13:27:49 +0000] rev 285
Style fix, as requested by Todd to dict usage
Use "dict['key'] = value" instead of "dict.update({'key' : 'value'})"
when updating only one key.
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 07:22:43 +0000] rev 284
Call soc.logic.site.map.getDjangoUrlPatterns() to construct the urlpatterns
from the site map, rather than explicitly listing them in app/urls.py.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 07:20:48 +0000] rev 283
Update soc/logic/site/sidebar.py to use parts of the "site map" in
soc/logic/site/map.py to generate portions of the sidebar menu.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 07:17:00 +0000] rev 282
A site layout ("site map") of the web application, including URL regular
expression patterns, Django views, and metadata for constructing sidebar menus
and (eventually) breadcrumbs.
One function, soc.logic.site.map.getDjangoUrlPatterns(), converts these details
into urlpatterns for use by Django.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 07:14:11 +0000] rev 281
Url and Page classes used to encapsulate the "site map" information (URL
regular expressions, Django views, menu item names, etc.) and the relation
between pages in the site map.
There are still lots of TODOs in this first pass.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 06:25:07 +0000] rev 280
urllib.quote() is needed by the soc/logic/site/map.py work, so import it from
the Python 2.5.2 sources. The entire urllib.py is not supported by Google
App Engine (yet?), since it relies on 'import socket' (App Engine provides a
separate urlfetch module instead).
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 05:00:13 +0000] rev 279
Remove now-empty soc/views/helpers (everything has moved to soc/views/helper).
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 04:51:43 +0000] rev 278
Add create() wrapper views that simply call the existing edit() views, to
produce unique view names in preparation for the soc/logic/site/map.py code.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 04:42:37 +0000] rev 277
Speed up average case by appending remainder of original choices list unchanged
(avoiding remaining str -> int type conversions) once the insertion point is
found.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 04:34:16 +0000] rev 276
Move helpers/html_menu.py to helper/html_menu.py, to clear out
soc/views/helpers for deletion.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 04:32:28 +0000] rev 275
A specialized SortedDict used by soc/logic/site/page.py.
Patch by: Todd Larsen
Review by: to-be-reviewed