Sverre Rabbelier <srabbelier@gmail.com> [Sat, 14 Feb 2009 21:32:25 +0000] rev 1330
Remove private data from club and org public templates
Also re-use the club/public.html template in organization's template.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 14 Feb 2009 21:31:33 +0000] rev 1329
Skip a field when it's value is not set
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 14 Feb 2009 21:18:12 +0000] rev 1328
Added bulk acceptance and progress bar in review org applications view.
In the list of organization applications for reviewing, if you click the button "click here" the whole first text line will fade out and the progress bar will fade in while starting to contact the server for the list of orgs to accept and then make synchronous calls for acceptance, while updating the progress bar, the name of the organization currently accepting and the number of orgs already accepted against the total.
Inside the script, what's inside the parenthesis is converted due to regexp (in this case (link_id)) and then read the json_object.applications[index].link_id. By doing this with an eval(), you can use other names as well and the script will be reading for example json_object.applications[index].attribute_name if you insert "(attribute_name)" inside the link returned by {{ bulk_accept_link }}.
Notes by Lennard:
-Put Done outside the for-loop so that it also shows when there are 0 pre-accepted organizations.
-Made some minor style fixes
Patch by: Mario Ferraro
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 14 Feb 2009 20:26:27 +0000] rev 1327
Now using the correct path to the loading animation in jquery-thickbox.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 14 Feb 2009 20:23:43 +0000] rev 1326
Minor style fix
dicts.merge already takes care of the case where target is None.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 14 Feb 2009 20:23:18 +0000] rev 1325
Add a list_public view to organization
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 14 Feb 2009 20:22:50 +0000] rev 1324
Factor out the 'key fields without link_id' logic from document
Also make sure the to-be-removed is present before removing it when
doing the field reordening.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 14 Feb 2009 20:22:17 +0000] rev 1323
Add a getListRedirect and getListPublicRedirect function
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 14 Feb 2009 20:21:51 +0000] rev 1322
Add an idea list (url) property to organization
Also include this url in the organisation list.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 14 Feb 2009 19:03:38 +0000] rev 1321
Fixed missing parameters in program view due to change in _getTimeDependentEntries in r1943.
Also the sidebar once more shows "Apply to become an Organization" even if you are not logged in.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 14 Feb 2009 16:44:14 +0000] rev 1320
Include scope_path as django_args
Otherwise users cannot create documents in their own prefix.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 14 Feb 2009 16:43:53 +0000] rev 1319
Disable the raw create and list link for documents
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 14 Feb 2009 16:43:20 +0000] rev 1318
Add custom access check for document listing
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 14 Feb 2009 15:57:53 +0000] rev 1317
Add a 'list documents' link everywhere
Also disable the Documents sidebar menu, since it does not provide
anything useful anymore.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 14 Feb 2009 15:57:14 +0000] rev 1316
Allow documents to be filtered by prefix and scope
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 14 Feb 2009 15:56:46 +0000] rev 1315
Developers have all roles
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 14 Feb 2009 15:56:22 +0000] rev 1314
Organization prefix was renamed to 'org'
The reference to it in the logic/rights.py module was not updated.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 14 Feb 2009 15:16:02 +0000] rev 1313
Force-check the 'agreed to admin agreement' field if applicable
If the current user is the applicant of the relevant organization,
they already agreed to the agreement once. As such the box should be
pre-checked.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 14 Feb 2009 15:15:38 +0000] rev 1312
Fix a bug in group_app
If context is not set, kwargs['context'] will raise an exception.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 14 Feb 2009 14:11:45 +0000] rev 1311
Add cleaning methods for document ACL
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 14 Feb 2009 14:11:18 +0000] rev 1310
Make document ACL's a constant
This makes it possible to refer to it in other modules.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 14 Feb 2009 14:10:56 +0000] rev 1309
Fix a bug if you have no roles at all
This could not happen currently, but might happen later on if a group
is defined that does not have an 'anybody' membership.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 13 Feb 2009 23:18:39 +0000] rev 1308
Partially reverted "Update the copyright notice for 2009."
This partially reverts commit r1933. Only the files that were created
in 2008 were reverted.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 13 Feb 2009 22:36:45 +0000] rev 1307
Update the copyright notice for 2009.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 13 Feb 2009 21:54:35 +0000] rev 1306
Fix ToS link
s/Terms/Google App Engine Terms/
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 13 Feb 2009 21:54:10 +0000] rev 1305
Do access checks on the pick url for documents
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 13 Feb 2009 21:53:42 +0000] rev 1304
Convert the QueryDict to a regular dictionary
This way we support a query with multiple args specified.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 13 Feb 2009 21:53:15 +0000] rev 1303
Add prefix filtering and refactored program field generation
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 13 Feb 2009 21:52:38 +0000] rev 1302
We generate the select url ourselves, so it's safe
This prevented urls with an & in it to be correctly generated.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 13 Feb 2009 21:52:10 +0000] rev 1301
Added a filter_fields parameter to the ReferenceField widget
This paramater makes it possible to do 'hard coded' filtering.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 13 Feb 2009 21:51:41 +0000] rev 1300
Factor out the hasMembership method from checkMembership
This makes it possible for the document picker to reuse it.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 13 Feb 2009 21:51:16 +0000] rev 1299
Add a getMemberships method to logic/rights.py
This will be used by the document picker ACL checks.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 13 Feb 2009 19:22:34 +0000] rev 1298
Fixes as requested by Leslie on behalf of the Legal team
Upped the copyright statement from 2008 to 2009, and link to the GAE
Terms of Service instead of any custom ToS.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 13 Feb 2009 17:34:29 +0000] rev 1297
Added number of applications and their type to the bulkaccept JSON object.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 13 Feb 2009 16:40:02 +0000] rev 1296
Implemented the 2nd part of bulk acceptance.
The context of the _list call can now be set by using the kwarg context. This will be merged with the universalcontext.
Added a TODO to create the organziation accepted email template.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 13 Feb 2009 13:35:31 +0000] rev 1295
Document prefix in params now defaults to url_name.
This is because the short name does not have to be url friendly.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 13 Feb 2009 13:33:31 +0000] rev 1294
Added bulk_accept view which returns a JSON object.
This is going to be used to bulk accept org applications.
Also added a new unfinished template so Merio can test his JS.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 13 Feb 2009 11:46:06 +0000] rev 1293
Only a club admin should see resign as club admin in the sidebar.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 12 Feb 2009 23:35:44 +0000] rev 1292
Fixed a bug in club and org logic.
This bug would give an error when no backup was set.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 12 Feb 2009 23:26:23 +0000] rev 1291
Fixed a bug in group_app templates.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 12 Feb 2009 23:14:07 +0000] rev 1290
Brown Paper Bag Fix: L2R Appspot error logs.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 12 Feb 2009 23:12:09 +0000] rev 1289
Fixed a bug in group_app view.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 12 Feb 2009 23:06:14 +0000] rev 1288
Returning None instead of the empty to fix a bug on melange-demo instance.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 12 Feb 2009 22:52:16 +0000] rev 1287
Added check_field_is_empty decorator to cleaning.py.
This makes sure the cleaning checks are skipped when a field is empty. Note that Djanog will raise it's own ValidationError when a required field is empty before attempting to clean it.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 12 Feb 2009 22:20:13 +0000] rev 1286
Org App review page now shows accept and pre-accept button.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 12 Feb 2009 21:25:00 +0000] rev 1285
Fixed comment and typo in cleaning.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 12 Feb 2009 20:15:20 +0000] rev 1284
Add ToS agreement to mentor application related forms.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 12 Feb 2009 20:14:51 +0000] rev 1283
Add ToS agreement to org_admin application related forms.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 12 Feb 2009 20:14:17 +0000] rev 1282
Do not attempt to render a field if it is disabled
This is required to make it possible to disable fields dynamically.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 12 Feb 2009 20:13:51 +0000] rev 1281
Program requires the filter to be set to __scoped__
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 12 Feb 2009 20:13:27 +0000] rev 1280
Disable clubs for now
Disabling the clubs in this way is a lot easier than adding a switch
for it in Site Settings, and probably safer too (as the urls are no
longer valid).
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 12 Feb 2009 12:58:26 +0000] rev 1279
App Engine 1.1.9 update breaks django 1.0. Monkey patch django to only check for SVN revision number when not running using dev_appserver. On deployed version this doesn't apply since we use django from zipped file.
This issue was discussed here:
http://groups.google.com/group/codereview-discuss/browse_thread/thread/a7ab6ceb39c09ce6
http://groups.google.com/group/google-appengine/browse_thread/thread/bbdebf8617b57512
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 12 Feb 2009 12:30:36 +0000] rev 1278
Load /Users/solydzajs/Downloads/google_appengine into
trunk/thirdparty/google_appengine.
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 12 Feb 2009 10:24:37 +0000] rev 1277
Removed unused argument in program.py
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 12 Feb 2009 00:04:32 +0000] rev 1276
Initial implementation of a ToS requirement in org_app
If the _editContext method can be made generic enough, it should be
easy to add ToSes to other forms. This solution should also be
applied to user_self, as the current implementation is not very clean
to say the least.
Patch By: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 12 Feb 2009 00:02:06 +0000] rev 1275
Added an AgreementField widget
Displays an Agreement Document in a scrolling text field. The text of
the document can be set by modifying the 'text' property.
Patch by: Sverre Rabbelier