Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 17:35:05 +0000] rev 630
Add missing import, remove unused import and add missing parameters to methods in soc.views.models.user_self module.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 17:06:32 +0000] rev 629
Add missing dots and fix too long line in soc.views.helper.dynaform module. Remove unused imports in soc.views.models.document module. Fix too long lines. Add missing docstring for Meta classes.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 16:46:32 +0000] rev 628
Add module docstring and license for soc, soc.models, soc.views.helper.templatetags.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 16:44:27 +0000] rev 627
Remove python-graph from thirdparty, remove check_includes script and graph folder from scripts. This functionality is (cyclic imports check) is supported by pylint automatically so we don't need that any more.
Patch by: Pawel Solyga
Review by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 16:39:18 +0000] rev 626
Fix too long lines in soc.views.models.request, remove unused imports and change pending requests list description. Remove unused imports from soc.logic.path_link_name module.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 16:36:17 +0000] rev 625
Add missing dots in soc.logic.lists module. Change method names to comply with Style Guide. Make class variable protected by adding "_" to the name of variable. Update lists templates respectively (methods name change).
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 16:32:23 +0000] rev 624
Remove unused imports in soc.views.models role, host and site modules. Add missing parameter in getDjangoURLPatters method.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 16:29:48 +0000] rev 623
Remove unused imports in soc.views.models.user and soc.views.models.sponsor modules.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 15:25:31 +0000] rev 622
Remove unused import in soc.models.task.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 15:25:07 +0000] rev 621
Fix too long lines in soc.model.work.
Patch by: Pawel Solyga
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 29 Nov 2008 23:51:24 +0000] rev 620
Put the redirects in the views/helper/redirects.py module.
Changed the getCreateRequestRedirect to comply with the new signature. Also changed it's docstring to a more suitable one.
Fixed a useless merge in views/models/role.py in the process.
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 22:48:15 +0000] rev 619
Style fixes for previous commit
We also need to run pylint.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 29 Nov 2008 22:36:51 +0000] rev 618
Added invitation received message upon creating a new invite.
Moved the inviteAcceptedRedirect into the logic code. Added a TODO for further user notification upon creating a request.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 21:58:34 +0000] rev 617
Now invited users can create a new Host profile
Before the invited user had to be a developer for this to
work. Now, instead the default checkIsDeveloper check for
the 'edit Host', a custom checkIsInvite check is used.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 21:21:04 +0000] rev 616
Fixed requests not working anymore
We really need a test suite.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 21:04:09 +0000] rev 615
Fixed a bug in latest commit
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 19:45:19 +0000] rev 614
Moved getSidebarLinks to sitemap.sidebar
This is the fourth, and final patch, that attempts to
improve the cohesion in the base.View class.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 19:44:48 +0000] rev 613
Moved getDjangoURLPatterns to sitemap.sitemap
Third commit in a series that aims to improve the cohesion
in the base.View class.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 19:00:03 +0000] rev 612
Moved checkAccess and getCleanedFields into access and forms
A second patch in an effort to increase the cohesion in the
base.View class.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 18:30:58 +0000] rev 611
Move parameter construction into a seperate module
This is part of an effort to make base.py less bloated
and have it's methods be more cohesive.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 17:20:52 +0000] rev 610
Documented params usage in soc/views/models/base.py
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 29 Nov 2008 14:41:43 +0000] rev 609
Fixed AUTHORS to comply with the specified format
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 29 Nov 2008 13:44:02 +0000] rev 608
Added _onCreate _onUpdate and _onDelete methods to logic/models/base.py.
These methods can be overwritten by other logic/models/ modules to serve as a way to for instance send out an update message.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 29 Nov 2008 11:26:04 +0000] rev 607
Fixed typo in docstring.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 00:12:47 +0000] rev 606
Make forms generic
Currently only Sponsor uses the new generic forms, as such this
makes the form code more complex. The other forms, however, can
be converted in a similar way, which will result in a lot of
code reduction.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 00:12:16 +0000] rev 605
Made _logic a param
The _logic parameter is added in base.py to make this as small and
non-intrustive change.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 28 Nov 2008 23:08:14 +0000] rev 604
Added Lennard to the AUTHORS file
Long overdue patch, perhaps we should add a test to the test suite
to check if all authors are propertly credited in AUTHORS...
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 28 Nov 2008 22:49:26 +0000] rev 603
Make Sponsor use the new DynaForm module
Currently only a slight reduction in code, but hopefully some
(or all?) of the form's definition can move up into base.View.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 28 Nov 2008 22:49:03 +0000] rev 602
Added a DynaForm module
This allows GAE forms to be defined 'semi' dymamically, rather than
by having to explicitly create the new class.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 28 Nov 2008 22:48:41 +0000] rev 601
Added a cleaning module
This module is the start of a (hopefully more generic) set of
cleaning functions that can be used in the GAE forms.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 28 Nov 2008 08:24:57 +0000] rev 600
Apache license and __author__ added. Also added a todo for the __doc__ string.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 27 Nov 2008 23:41:08 +0000] rev 599
Moved check_includes and graph from app to scripts
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 27 Nov 2008 23:40:30 +0000] rev 598
Change command parsing and do file walking manually
Also print warnings to stderr
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 27 Nov 2008 21:57:24 +0000] rev 597
Proper working implementation of a cycle detection algorithm, that
returns the cycles (rather than printing them) by constructing the
path between the two nodes that were found to be cyclic.
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 27 Nov 2008 17:22:39 +0000] rev 596
Fix some typo in logic.models.base.
Patch by: Pawel Solyga
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 26 Nov 2008 23:56:35 +0000] rev 595
Added rudementry include checker
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 26 Nov 2008 23:56:19 +0000] rev 594
Added the python-graph module
http://code.google.com/p/python-graph/
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 26 Nov 2008 23:55:10 +0000] rev 593
Removed cruft from the tests directory
The current tests were outdated (they tested code that no longer
exists), and were causing the test suite (insofar as it deserves
that name) to fail for no reason.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 26 Nov 2008 23:54:40 +0000] rev 592
Fixed an outstanding TODO for tlarsen
A nice side-effect is that accounts now does not depend on
out_of_band, sadly that does not fix the cyclic dependency, but it is
a nice side-effect nonetheless.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 26 Nov 2008 21:34:11 +0000] rev 591
Lists now use plural_name instead of name in the description.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 26 Nov 2008 20:50:56 +0000] rev 590
Created a seperate module for editSelf things
This improves the coherency in the user module, while at the same
time making it easier to set proper access control for the editSelf
related pages.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 26 Nov 2008 16:33:36 +0000] rev 589
Fixes empty spaces appearing in the menu if a person is not allowed to see this menu or if no menu is defined.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 26 Nov 2008 15:52:38 +0000] rev 588
Fixes an error that occurs when moving the document by setting another link ID or Scope path. This is due to the fact that author is a required property in the Work model.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 25 Nov 2008 23:16:32 +0000] rev 587
Fixed some access related bugs
These were not obvious previously, but with the sidebar not showing
up when one does not have access, they stood out.
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 25 Nov 2008 17:19:37 +0000] rev 586
Make the sidebar dynamic depending on the user's rights
This is done by doing the usual access checks that are also called
when the user actually visits the page.
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 25 Nov 2008 17:18:57 +0000] rev 585
Have the sidebar be rebuilt on every request with callbacks
This makes is possible for the sidebar constructing to take
into account the current users privilidges etc.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 24 Nov 2008 22:34:56 +0000] rev 584
Adds and uses a modified_by property in models/work.py
This property is used to display the user who last edited the work in the document viewer.
Fixes author being set on every edit.
Also edited the style-sheet to fix issue i128.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 24 Nov 2008 18:31:46 +0000] rev 583
Fills in the Founded By box in edit sponsor with the user's public name
Fixes Founded By being overwritten on edit by another user.
Patch by: Lennard de Rijk
Todd Larsen <tlarsen@google.com> [Sun, 23 Nov 2008 18:48:28 +0000] rev 582
Set trunk RELEASE_TAG back to None after creation of 0.0a20081123rc release
candidate branch.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Sun, 23 Nov 2008 18:45:04 +0000] rev 581
Attempt number two at a release process, with correct usage of /tags/ this
time around.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Sun, 23 Nov 2008 07:38:00 +0000] rev 580
Reset the RELEASE_TAG to None (unreleased) now that the 0.0a20081123 release
tag has been created. Add some release instructions to the soc/release.py
__doc__ string.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Sun, 23 Nov 2008 07:25:31 +0000] rev 579
Display '(unreleased)' as a link to trunk/ when RELEASE_TAG is false.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Sun, 23 Nov 2008 07:15:13 +0000] rev 578
Add release tag string, Melange "badge" image, and Google App Engine version
to base.html template.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Sun, 23 Nov 2008 06:34:22 +0000] rev 577
Provide a simple method in the Role Model class that aliases the existing
'display_name' Property to 'name'.
Patch by: Todd Larsen
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 23 Nov 2008 00:44:13 +0000] rev 576
Fixed spurious 'Invite Host' button in 'create host'
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 23 Nov 2008 00:38:35 +0000] rev 575
Fix Host invites
This fixes the UI for Host invites by hiding the fields that
are not used, and by auto-filling in the user and scope fields
based on link_id and scope_path.