Fix too long lines, remove unused imports and variables, rename too short variables, add missing docstring and fix style in soc.views.helper.templatetags.forms_helpers module.
authorPawel Solyga <Pawel.Solyga@gmail.com>
Wed, 04 Mar 2009 21:27:11 +0000
changeset 1665 9d623ebfff0d
parent 1664 07c536240838
child 1666 cdb7e5581694
Fix too long lines, remove unused imports and variables, rename too short variables, add missing docstring and fix style in soc.views.helper.templatetags.forms_helpers module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed
app/soc/views/helper/templatetags/forms_helpers.py
--- a/app/soc/views/helper/templatetags/forms_helpers.py	Wed Mar 04 21:25:08 2009 +0000
+++ b/app/soc/views/helper/templatetags/forms_helpers.py	Wed Mar 04 21:27:11 2009 +0000
@@ -24,11 +24,8 @@
   ]
 
 
-import operator
 import re
 
-from google.appengine.ext import db
-
 from django import template
 from django.forms import forms as forms_in
 from django.utils.encoding import force_unicode
@@ -103,7 +100,8 @@
           'field_value': field_value}
 
 
-@register.inclusion_tag('soc/templatetags/_readonly_field_as_twoline_table_row.html')
+@register.inclusion_tag(
+    'soc/templatetags/_readonly_field_as_twoline_table_row.html')
 def readonly_field_as_twoline_table_row(field_label, field_value):
   """See readonly_field_as_table_row().
   """
@@ -111,7 +109,8 @@
           'field_value': field_value}
 
 
-@register.inclusion_tag('soc/templatetags/_readonly_url_field_as_table_row.html')
+@register.inclusion_tag(
+    'soc/templatetags/_readonly_url_field_as_table_row.html')
 def readonly_url_field_as_table_row(field_label, field_value):
   """See readonly_field_as_table_row().
   """
@@ -128,7 +127,8 @@
           'field_value': field_value}
 
 
-@register.inclusion_tag('soc/templatetags/_readonly_safe_field_as_table_row.html')
+@register.inclusion_tag(
+    'soc/templatetags/_readonly_safe_field_as_table_row.html')
 def readonly_safe_field_as_table_row(field_label, field_value):
   """See readonly_field_as_table_row().
   """
@@ -184,10 +184,14 @@
 
 
 def as_table_helper(context, form):
+  """See as_table().
+  """
+  
   fields = []
   hidden_fields = []
   hidden_fields_errors = []
-  entity = context['entity']
+  
+  # entity = context['entity']
 
   # Iterate over all fields and prepare it for adding 
   for name, field in form.fields.items():
@@ -223,13 +227,13 @@
     else:
       hidden_fields.append(unicode(bf))
 
-      for e in bf.errors:
-        item = (name, force_unicode(e))
+      for error in bf.errors:
+        item = (name, force_unicode(error))
         hidden_fields_errors.append(item)
 
   grouped = dicts.groupby(fields, 'group')
   rexp = re.compile(r"\d+. ")
-  fields = [(rexp.sub('',key), grouped[key]) for key in sorted(grouped)]
+  fields = [(rexp.sub('', key), grouped[key]) for key in sorted(grouped)]
 
   context.update({
       'top_errors': form.non_field_errors() or '',