Sun, 21 Sep 2008 08:50:42 +0000 Remove Author model (use Person instead). Update models after removing Author. Add new Sponsor, Organization models.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 21 Sep 2008 08:50:42 +0000] rev 181
Remove Author model (use Person instead). Update models after removing Author. Add new Sponsor, Organization models. Patch by: Pawel Solyga Reviewed by: Todd Larsen Review issue: 801 Review URL: http://codereviews.googleopensourceprograms.com/801
Sun, 21 Sep 2008 02:16:00 +0000 Two changes to ease CI:
Augie Fackler <durin42@gmail.com> [Sun, 21 Sep 2008 02:16:00 +0000] rev 180
Two changes to ease CI: 1) If pysvn is missing, the tests for svn_helper don't run and pollute the output 2) svn_helper no longer depends on being located at trunk/scripts/ Patch by: Augie Fackler Review by: Todd Larsen Review Issue: 802 Reviewed URL: http://codereviews.googleopensourceprograms.com/802
Sat, 20 Sep 2008 19:04:43 +0000 Add custom 404 error message with link to "Create a New User" which is displayed when linkname in User Profile Developer view URL (/site/user/profile/<linkname>) doesn't exist. Add default value (None) to new_suffix parameter of template_helpers replaceSuffix and redirectToChangedSuffix functions.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 20 Sep 2008 19:04:43 +0000] rev 179
Add custom 404 error message with link to "Create a New User" which is displayed when linkname in User Profile Developer view URL (/site/user/profile/<linkname>) doesn't exist. Add default value (None) to new_suffix parameter of template_helpers replaceSuffix and redirectToChangedSuffix functions.
Sat, 20 Sep 2008 17:39:07 +0000 Testing buildbot. Sorry about the noise. (Last one for now, I've got most of the kinks figured out I think)
Augie Fackler <durin42@gmail.com> [Sat, 20 Sep 2008 17:39:07 +0000] rev 178
Testing buildbot. Sorry about the noise. (Last one for now, I've got most of the kinks figured out I think)
Sat, 20 Sep 2008 16:50:20 +0000 Testing buildbot. Sorry about the noise.
Augie Fackler <durin42@gmail.com> [Sat, 20 Sep 2008 16:50:20 +0000] rev 177
Testing buildbot. Sorry about the noise.
Sat, 20 Sep 2008 16:47:09 +0000 Testing buildbot. Sorry about the noise.
Augie Fackler <durin42@gmail.com> [Sat, 20 Sep 2008 16:47:09 +0000] rev 176
Testing buildbot. Sorry about the noise.
Fri, 19 Sep 2008 21:11:39 +0000 Make django.zip in release/, instead of in app/ with a symlink in release/.
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 21:11:39 +0000] rev 175
Make django.zip in release/, instead of in app/ with a symlink in release/. This allows debugging into app/django source code, which the presence of app/django.zip was blocking. Tested with both: dev_appserver.py release and dev_appserver.py app
Fri, 19 Sep 2008 18:02:37 +0000 A rough draft of the Group Model, to be merged with Pawel's current effort in
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 18:02:37 +0000] rev 174
A rough draft of the Group Model, to be merged with Pawel's current effort in his working copy. This is *very* incomplete...
Fri, 19 Sep 2008 17:51:33 +0000 First pass (from some old code notes) of a School Model (a form of Group).
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 17:51:33 +0000] rev 173
First pass (from some old code notes) of a School Model (a form of Group).
Fri, 19 Sep 2008 17:47:21 +0000 First pass (from some old code notes) of a Club Model (a form of Group).
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 17:47:21 +0000] rev 172
First pass (from some old code notes) of a Club Model (a form of Group).
Fri, 19 Sep 2008 12:45:13 +0000 Bug fixes to revision r596. User Account field in Developer User Profile view needs to be an email not a login name. Header title of User Profile Developer view, when form validation failes is now showing correct value ("Modify existing ..." instead of "Create new user ...").
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 19 Sep 2008 12:45:13 +0000] rev 171
Bug fixes to revision r596. User Account field in Developer User Profile view needs to be an email not a login name. Header title of User Profile Developer view, when form validation failes is now showing correct value ("Modify existing ..." instead of "Create new user ...").
Fri, 19 Sep 2008 05:15:20 +0000 Add /site/user/profile Developer view for editing arbitrary User entities.
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 05:15:20 +0000] rev 170
Add /site/user/profile Developer view for editing arbitrary User entities. Update /user/profile edit() view to fix TODO about updating the URL when a POST of the form changes the link_name of the User. Add a Create New User link to the base.html sidebar mock-up.
Fri, 19 Sep 2008 05:12:35 +0000 Fix off-by-one corner case discovered during testing of /user/profile.
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 05:12:35 +0000] rev 169
Fix off-by-one corner case discovered during testing of /user/profile.
Fri, 19 Sep 2008 04:50:42 +0000 Added getSingleIndexedParamValue() that retrieves an index into a list of
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 04:50:42 +0000] rev 168
Added getSingleIndexedParamValue() that retrieves an index into a list of values from the named query parameter, and then indexes into the supplied list of values to return the corresponding value from the list. Used to convert numeric index query parameters passed by POST to the GET redirect target, so that the GET code can display messages, etc. (without passing the message itself as a query argument and having to escape it or have silly people pass in their own...).
Fri, 19 Sep 2008 04:28:17 +0000 Added replaceSuffix(), isReferrerSelf(), and redirectToChangedSuffix() to
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 04:28:17 +0000] rev 167
Added replaceSuffix(), isReferrerSelf(), and redirectToChangedSuffix() to implement the TODO in the User profile views where the link name portion of the URL needs to change when the link_name Property is updated by the form.
Thu, 18 Sep 2008 23:07:06 +0000 Fixed too long lines and deleted unused imports in id_user.py.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 18 Sep 2008 23:07:06 +0000] rev 166
Fixed too long lines and deleted unused imports in id_user.py.
Thu, 18 Sep 2008 22:14:06 +0000 New default values for page title, header title and body of site home page.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 18 Sep 2008 22:14:06 +0000] rev 165
New default values for page title, header title and body of site home page.
Thu, 18 Sep 2008 22:11:56 +0000 Documentation updates and one typo fix.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 18 Sep 2008 22:11:56 +0000] rev 164
Documentation updates and one typo fix.
Thu, 18 Sep 2008 17:33:20 +0000 Add a td.formfielderrorlabel style, to highlight field labels that have errors.
Todd Larsen <tlarsen@google.com> [Thu, 18 Sep 2008 17:33:20 +0000] rev 163
Add a td.formfielderrorlabel style, to highlight field labels that have errors.
Thu, 18 Sep 2008 17:32:28 +0000 Swap field value and "required" columns to make more columns for field errors.
Todd Larsen <tlarsen@google.com> [Thu, 18 Sep 2008 17:32:28 +0000] rev 162
Swap field value and "required" columns to make more columns for field errors.
Thu, 18 Sep 2008 17:31:01 +0000 Add a verbose_name and help_text to the User.id Property.
Todd Larsen <tlarsen@google.com> [Thu, 18 Sep 2008 17:31:01 +0000] rev 161
Add a verbose_name and help_text to the User.id Property.
Tue, 16 Sep 2008 18:02:09 +0000 Explain why pushd and popd are needed when making tiny_mce.zip.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 18:02:09 +0000] rev 160
Explain why pushd and popd are needed when making tiny_mce.zip.
Tue, 16 Sep 2008 18:00:55 +0000 Use zip to compress tiny_mce, and use zipserve to serve it in Google App
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 18:00:55 +0000] rev 159
Use zip to compress tiny_mce, and use zipserve to serve it in Google App Engine.
Tue, 16 Sep 2008 17:38:09 +0000 Updated make_release.sh docs and added way for person invoking the script to override script variables such as RELEASE using something like "RELEASE=../testing_release ./make_release.sh".
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 16 Sep 2008 17:38:09 +0000] rev 158
Updated make_release.sh docs and added way for person invoking the script to override script variables such as RELEASE using something like "RELEASE=../testing_release ./make_release.sh".
Tue, 16 Sep 2008 17:07:58 +0000 Add recently-moved feedparser and tiny_mce to APP_DIRS.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 17:07:58 +0000] rev 157
Add recently-moved feedparser and tiny_mce to APP_DIRS.
Tue, 16 Sep 2008 17:05:43 +0000 Oops, this should have been part of the r580 commit.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 17:05:43 +0000] rev 156
Oops, this should have been part of the r580 commit.
Tue, 16 Sep 2008 17:05:07 +0000 Oops, this should have been part of the r577 commit.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 17:05:07 +0000] rev 155
Oops, this should have been part of the r577 commit.
Tue, 16 Sep 2008 16:49:25 +0000 Move third-party TinyMCE out of soc/content/js and into the application image
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 16:49:25 +0000] rev 154
Move third-party TinyMCE out of soc/content/js and into the application image root, like other third-party code. Update the app.yaml.template to add /tiny_mce as a source of static content.
Tue, 16 Sep 2008 16:42:55 +0000 Add README files to explain how third-party code is maintained in these
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 16:42:55 +0000] rev 153
Add README files to explain how third-party code is maintained in these directories.
Tue, 16 Sep 2008 16:24:18 +0000 Discourage third-party code from being embedded in the soc framework.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 16:24:18 +0000] rev 152
Discourage third-party code from being embedded in the soc framework.
Tue, 16 Sep 2008 16:22:49 +0000 Move third-party feedparser.py out of the soc framework package into its own
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 16:22:49 +0000] rev 151
Move third-party feedparser.py out of the soc framework package into its own package (similar to django).
Tue, 16 Sep 2008 15:56:15 +0000 Changed ZIPFILE variable to DJANGO_ZIPFILE in make_release.sh script and added 'cd $APP_FOLDER' before we zip django.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 16 Sep 2008 15:56:15 +0000] rev 150
Changed ZIPFILE variable to DJANGO_ZIPFILE in make_release.sh script and added 'cd $APP_FOLDER' before we zip django.
Tue, 16 Sep 2008 02:28:33 +0000 Load ../google_appengine into trunk/thirdparty/google_appengine.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 02:28:33 +0000] rev 149
Load ../google_appengine into trunk/thirdparty/google_appengine.
Tue, 16 Sep 2008 01:18:49 +0000 upload.py customized to work with codereviews.googleopensourceprograms.com.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 01:18:49 +0000] rev 148
upload.py customized to work with codereviews.googleopensourceprograms.com.
Tue, 16 Sep 2008 01:18:15 +0000 Pristine initial commit of upload.py script from
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 01:18:15 +0000] rev 147
Pristine initial commit of upload.py script from http://code.google.com/p/rietveld (r310).
Tue, 16 Sep 2008 01:15:00 +0000 gcl.py customized to work with codereviews.googleopensourceprograms.com and the
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 01:15:00 +0000] rev 146
gcl.py customized to work with codereviews.googleopensourceprograms.com and the melange-soc-dev@googlegroups.com mailing list.
Tue, 16 Sep 2008 01:14:18 +0000 Pristine initial commit of gcl.py script from chromium.org.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 01:14:18 +0000] rev 145
Pristine initial commit of gcl.py script from chromium.org.
Sun, 14 Sep 2008 20:32:32 +0000 Release shell script and associated changes. Set svn:ignore property on /app/django.zip file and /release folder.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 14 Sep 2008 20:32:32 +0000] rev 144
Release shell script and associated changes. Set svn:ignore property on /app/django.zip file and /release folder. Patch by: Pawel Solyga, Augie Fackler Review by: Todd Larsen, review-after-commit Review issue: 363 Review URL: http://codereviews.googleopensourceprograms.com/363
Sun, 14 Sep 2008 00:23:49 +0000 FIxed documentation in soc/logic/document.py for getDocumentFromPath function
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 14 Sep 2008 00:23:49 +0000] rev 143
FIxed documentation in soc/logic/document.py for getDocumentFromPath function Patch by: Christian López Espínol Reviewed by: Pawel Solyga Reviewed via: discussion on melange-soc-dev group
Sat, 13 Sep 2008 22:53:07 +0000 Forgot to change widgets to custom_widgets import in home.py after changing the name of soc/views/helpers/widgets.py file.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 13 Sep 2008 22:53:07 +0000] rev 142
Forgot to change widgets to custom_widgets import in home.py after changing the name of soc/views/helpers/widgets.py file.
Sat, 13 Sep 2008 22:00:51 +0000 Added Melange front page edit view where you can change title, content, feed url. Created SiteSettings and Document models and some logic for them. Added isFeedURLValid function in soc/logic/feed.py. Created some functions for handling datastore updates of different kinds of Models (soc/logic/model.py). Fixed some typos and too long lines of code.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 13 Sep 2008 22:00:51 +0000] rev 141
Added Melange front page edit view where you can change title, content, feed url. Created SiteSettings and Document models and some logic for them. Added isFeedURLValid function in soc/logic/feed.py. Created some functions for handling datastore updates of different kinds of Models (soc/logic/model.py). Fixed some typos and too long lines of code. Patch by: Pawel Solyga Review by: to-be-reviewed
Sat, 13 Sep 2008 21:27:17 +0000 Added feedparser to soc/utils and modified svn:externals for vendor to include feedparser svn
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 13 Sep 2008 21:27:17 +0000] rev 140
Added feedparser to soc/utils and modified svn:externals for vendor to include feedparser svn Patch by: Pawel Solyga Review by: to-be-reviewed
Fri, 12 Sep 2008 21:54:37 +0000 Add getAltResponseIfNotLoggedIn() and getAltResponseIfNotDeveloper() simple
Todd Larsen <tlarsen@google.com> [Fri, 12 Sep 2008 21:54:37 +0000] rev 139
Add getAltResponseIfNotLoggedIn() and getAltResponseIfNotDeveloper() simple view helpers. These cannot go into response_helpers.py because they create a circular reference with simple.py, and Django view import fails. Review URL: http://codereviews.googleopensourceprograms.com/602
Fri, 12 Sep 2008 20:36:17 +0000 Improve the __doc__ string of isIdDeveloper() to explain better how it now
Todd Larsen <tlarsen@google.com> [Fri, 12 Sep 2008 20:36:17 +0000] rev 138
Improve the __doc__ string of isIdDeveloper() to explain better how it now functions.
Fri, 12 Sep 2008 20:31:56 +0000 Make isIdDeveloper() also able to check an is_developer Boolean property in
Todd Larsen <tlarsen@google.com> [Fri, 12 Sep 2008 20:31:56 +0000] rev 137
Make isIdDeveloper() also able to check an is_developer Boolean property in User entities. Review URL: http://codereviews.googleopensourceprograms.com/601
Fri, 12 Sep 2008 19:01:44 +0000 Replace checkLinkNameForId() with isLinkNameAvailableForId(), and implement
Todd Larsen <tlarsen@google.com> [Fri, 12 Sep 2008 19:01:44 +0000] rev 136
Replace checkLinkNameForId() with isLinkNameAvailableForId(), and implement that new function in terms of only the existing doesLinkNameExist() and doesLinkNameBelongToId(). Patch by: Todd Larsen Review by: Pawel Solyga Review via: discussion of patches on melange-soc-dev mailing list
Fri, 12 Sep 2008 16:33:04 +0000 Fixed one typo in response_helpers which caused is_admin context variable not to work correctly.
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 12 Sep 2008 16:33:04 +0000] rev 135
Fixed one typo in response_helpers which caused is_admin context variable not to work correctly. Created new checkLinkNameForId function that checks if link_name is correct when creating new user and modifying existing one. This is now used for validation instead of doesLinkNameBelongToId in UserForm clean_link_name function. The previous validation function didn't allow to create new users and modify linkname of existing ones. Additionally I created new doesLinkNameExist helper function.
Fri, 12 Sep 2008 10:56:21 +0000 Fixed wrong user variable in lookup.html template for edit link (was user should be found_user).
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 12 Sep 2008 10:56:21 +0000] rev 134
Fixed wrong user variable in lookup.html template for edit link (was user should be found_user). There is no DeveloperForm in site/user/profile.py changed that to LookupForm.
Fri, 12 Sep 2008 02:46:21 +0000 gcl.py committed this file, when it should not have even existed.
Todd Larsen <tlarsen@google.com> [Fri, 12 Sep 2008 02:46:21 +0000] rev 133
gcl.py committed this file, when it should not have even existed.
Fri, 12 Sep 2008 02:37:15 +0000 Add a /site/user/lookup view that provides Developers with a form to look up
Todd Larsen <tlarsen@google.com> [Fri, 12 Sep 2008 02:37:15 +0000] rev 132
Add a /site/user/lookup view that provides Developers with a form to look up User entities given email addresses or link names.
Fri, 12 Sep 2008 02:12:38 +0000 ...
Todd Larsen <tlarsen@google.com> [Fri, 12 Sep 2008 02:12:38 +0000] rev 131
...
Thu, 11 Sep 2008 21:30:08 +0000 Updated the script to:
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 11 Sep 2008 21:30:08 +0000] rev 130
Updated the script to: * Include a comment describing what it does * Use variables for anything non-standard * Use the --parse-only flag of epydoc * Exclude all 'django' modules through --exclude= * Run on '../app' by default, no more arguments needed * Clean up the output directory before running
Thu, 11 Sep 2008 20:50:58 +0000 Bugfix, invalid syntax noticed by epydoc.
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 11 Sep 2008 20:50:58 +0000] rev 129
Bugfix, invalid syntax noticed by epydoc.
Thu, 11 Sep 2008 12:06:57 +0000 Updated docs in response_helpers.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 11 Sep 2008 12:06:57 +0000] rev 128
Updated docs in response_helpers. Patch by: Pawel Solyga Review by: to-be-reviewed
Thu, 11 Sep 2008 12:01:20 +0000 Created custom_widgets.py and added TinyMCE django widget that can be later used for particular form fields.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 11 Sep 2008 12:01:20 +0000] rev 127
Created custom_widgets.py and added TinyMCE django widget that can be later used for particular form fields. Patch by: Pawel Solyga Review by: to-be-reviewed
Thu, 11 Sep 2008 11:56:24 +0000 Added TinyMCE to Melange in soc/content/js
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 11 Sep 2008 11:56:24 +0000] rev 126
Added TinyMCE to Melange in soc/content/js Patch by: Pawel Solyga Review by: to-be-reviewed
Sat, 30 Aug 2008 02:54:22 +0000 An emerging pattern with makeSiblingTemplatesList() is that views calling that
Todd Larsen <tlarsen@google.com> [Sat, 30 Aug 2008 02:54:22 +0000] rev 125
An emerging pattern with makeSiblingTemplatesList() is that views calling that function then append a known, default template "just in case". This change adds a default_template parameter to makeSiblingTemplatesList() to eliminate the extra "append a known default to the end" step for the caller. Patch by: Todd Larsen Review by: to-be-reviewed
Fri, 29 Aug 2008 04:24:31 +0000 Refactor soc/views/user/profile.py to make use of several of the new views
Todd Larsen <tlarsen@google.com> [Fri, 29 Aug 2008 04:24:31 +0000] rev 124
Refactor soc/views/user/profile.py to make use of several of the new views available in soc/views/simple.py. Patch by: Todd Larsen Review by: to-be-reviewed
Fri, 29 Aug 2008 02:59:59 +0000 Fix an overlooked cut-and-paste error.
Todd Larsen <tlarsen@google.com> [Fri, 29 Aug 2008 02:59:59 +0000] rev 123
Fix an overlooked cut-and-paste error. Patch by: Todd Larsen Review by: to-be-reviewed
Fri, 29 Aug 2008 02:52:02 +0000 Add a public() convenience wrapper around templateWithLinkName() for the common
Todd Larsen <tlarsen@google.com> [Fri, 29 Aug 2008 02:52:02 +0000] rev 122
Add a public() convenience wrapper around templateWithLinkName() for the common public.html case. Add a requestLogin() view. Patch by: Todd Larsen Review by: to-be-reviewed
(0) -100 -60 +60 +100 +300 +1000 tip