Sat, 15 Nov 2008 03:12:33 +0000 Attempt to rename User.id to User.account, in preparation for making User be
Todd Larsen <tlarsen@google.com> [Sat, 15 Nov 2008 03:12:33 +0000] rev 481
Attempt to rename User.id to User.account, in preparation for making User be derived from Linkable, which will have a property named 'id'. Patch by: Todd Larsen
Fri, 14 Nov 2008 06:36:42 +0000 For those times when sed isn't enough, but awk is too much, there's munge.py...
Todd Larsen <tlarsen@google.com> [Fri, 14 Nov 2008 06:36:42 +0000] rev 480
For those times when sed isn't enough, but awk is too much, there's munge.py... Patch by: Todd Larsen
Thu, 13 Nov 2008 20:46:41 +0000 Make sure the user edit form has the complete mail adress in the user account field when opened. Replace confusing id field in form with email field. Editing the email adress of an existing user will still result in an error but that should be fixed soon.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 13 Nov 2008 20:46:41 +0000] rev 479
Make sure the user edit form has the complete mail adress in the user account field when opened. Replace confusing id field in form with email field. Editing the email adress of an existing user will still result in an error but that should be fixed soon. Patch by: Lennard de Rijk Review by: Pawel Solyga
Thu, 13 Nov 2008 19:41:16 +0000 upload.py (customized for use with codereviews.googleopensourceprograms.com)
Todd Larsen <tlarsen@google.com> [Thu, 13 Nov 2008 19:41:16 +0000] rev 478
upload.py (customized for use with codereviews.googleopensourceprograms.com) updated from latest Rietveld release. Patch by: Todd Larsen
Thu, 13 Nov 2008 16:40:05 +0000 Moved from docs -> document
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 13 Nov 2008 16:40:05 +0000] rev 477
Moved from docs -> document
Wed, 12 Nov 2008 21:43:15 +0000 Fixed typo in docstring
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 12 Nov 2008 21:43:15 +0000] rev 476
Fixed typo in docstring
Wed, 12 Nov 2008 07:28:12 +0000 Copy the link_name regex patterns into linkable.py, in preparation for
Todd Larsen <tlarsen@google.com> [Wed, 12 Nov 2008 07:28:12 +0000] rev 475
Copy the link_name regex patterns into linkable.py, in preparation for removing them from path_link_name.py (eventually). Patch by: Todd Larsen
Tue, 11 Nov 2008 21:07:38 +0000 Move all the properties from Person model to Role model. Update all the comments and docs according to the changes. Remove Person model.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 11 Nov 2008 21:07:38 +0000] rev 474
Move all the properties from Person model to Role model. Update all the comments and docs according to the changes. Remove Person model. Patch by: Pawel Solyga
Tue, 11 Nov 2008 19:49:00 +0000 Fix broken User link name (it was possible to change link name to one that was already used, validation was not working correctly).
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 11 Nov 2008 19:49:00 +0000] rev 473
Fix broken User link name (it was possible to change link name to one that was already used, validation was not working correctly). Patch by: Pawel Solyga
Tue, 11 Nov 2008 01:02:56 +0000 Move "(required)" text to third column instead of second column in templatetags, it's much more user friendly that way. Add new version of as_table that support our current error messages format, information about required fields and tooltips.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 11 Nov 2008 01:02:56 +0000] rev 472
Move "(required)" text to third column instead of second column in templatetags, it's much more user friendly that way. Add new version of as_table that support our current error messages format, information about required fields and tooltips. Patch by: Pawel Solyga
Mon, 10 Nov 2008 23:18:06 +0000 Remove stop parameter from home_settings and site_settings views. This is something Sverre didn't mean to commit :-) Add missing params description to the models Base class docs.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 10 Nov 2008 23:18:06 +0000] rev 471
Remove stop parameter from home_settings and site_settings views. This is something Sverre didn't mean to commit :-) Add missing params description to the models Base class docs. Patch by: Pawel Solyga
Mon, 10 Nov 2008 22:50:27 +0000 In soc.views.models.user module fix too long line. Delete unused email variable, add missing doc and rename self method and global variable to editSelf and edit_self so it's not confused with "self" used in classes and there is no outerscope variable name overwriting anymore.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 10 Nov 2008 22:50:27 +0000] rev 470
In soc.views.models.user module fix too long line. Delete unused email variable, add missing doc and rename self method and global variable to editSelf and edit_self so it's not confused with "self" used in classes and there is no outerscope variable name overwriting anymore. Patch by: Pawel Solyga
Mon, 10 Nov 2008 22:45:17 +0000 Some name changes in soc.logic.site.map module for User self edit view.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 10 Nov 2008 22:45:17 +0000] rev 469
Some name changes in soc.logic.site.map module for User self edit view. Patch by: Pawel Solyga
Mon, 10 Nov 2008 22:38:20 +0000 Fix typo in linkable model and add some missing comments.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 10 Nov 2008 22:38:20 +0000] rev 468
Fix typo in linkable model and add some missing comments. Patch by: Pawel Solyga
Mon, 10 Nov 2008 18:00:47 +0000 Initial thoughts on a Linkable Model class. Please comment.
Todd Larsen <tlarsen@google.com> [Mon, 10 Nov 2008 18:00:47 +0000] rev 467
Initial thoughts on a Linkable Model class. Please comment. Patch by: Todd Larsen
Mon, 10 Nov 2008 17:25:05 +0000 Fix names typos in home_settings and site_settings modules.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 10 Nov 2008 17:25:05 +0000] rev 466
Fix names typos in home_settings and site_settings modules. Patch by: Pawel Solyga
Mon, 10 Nov 2008 16:46:16 +0000 Change Google Maps property name from gm_api_key to gmaps_api_key.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 10 Nov 2008 16:46:16 +0000] rev 465
Change Google Maps property name from gm_api_key to gmaps_api_key. Patch by: Pawel Solyga
Mon, 10 Nov 2008 16:40:51 +0000 Change partial path and link name verbose names in home_settings.py. Some comments fixes in site_settings.py.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 10 Nov 2008 16:40:51 +0000] rev 464
Change partial path and link name verbose names in home_settings.py. Some comments fixes in site_settings.py. Patch by: Pawel Solyga
Mon, 10 Nov 2008 16:07:18 +0000 Add jquery folder to make_release.sh script to fix not working jquery on deployed app.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 10 Nov 2008 16:07:18 +0000] rev 463
Add jquery folder to make_release.sh script to fix not working jquery on deployed app. Patch by: Pawel Solyga
Mon, 10 Nov 2008 14:40:16 +0000 Adds a check to logic/valididate.py that checks the partial path format using a regexp. This regexp has been added to logic/path_link_name.py, therefore changing PATH_LINKNAME_REGEX to use the PARTIAL_PATH in building this regexp. Plus views/models/docs.py now uses the validation functions in the clean_ methods.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 10 Nov 2008 14:40:16 +0000] rev 462
Adds a check to logic/valididate.py that checks the partial path format using a regexp. This regexp has been added to logic/path_link_name.py, therefore changing PATH_LINKNAME_REGEX to use the PARTIAL_PATH in building this regexp. Plus views/models/docs.py now uses the validation functions in the clean_ methods. Patch by: Lennard de Rijk Review by: Pawel Solyga
Mon, 10 Nov 2008 00:42:41 +0000 Partially use the new user code
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 10 Nov 2008 00:42:41 +0000] rev 461
Partially use the new user code The 'edit self' is not working fully yet, the 'lookup' code is not working at all, as such, only 'create', 'edit', 'list', and 'delete' make use of the generic code.
Mon, 10 Nov 2008 00:42:18 +0000 Added a generic user page
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 10 Nov 2008 00:42:18 +0000] rev 460
Added a generic user page
Mon, 10 Nov 2008 00:41:54 +0000 Preparation for generic user views
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 10 Nov 2008 00:41:54 +0000] rev 459
Preparation for generic user views Added a getSuffixValues method that is meant to allow for having a non-public field as key_name. Also added support for a key-name field being embeded in the form so that if the key-fields change the old key_name is not lost.
Mon, 10 Nov 2008 00:41:01 +0000 Added support for providing a custom params dict
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 10 Nov 2008 00:41:01 +0000] rev 458
Added support for providing a custom params dict This has been a long outstanding feature request for tlarsen, luckily it turned out to be very easy to implement with the dict.merge utility method. To have custom _rights one should instead to the required access checks before calling the view method.
Mon, 10 Nov 2008 00:40:39 +0000 Fixed a typo in id_user
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 10 Nov 2008 00:40:39 +0000] rev 457
Fixed a typo in id_user
Mon, 10 Nov 2008 00:40:15 +0000 Fix create redirect
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 10 Nov 2008 00:40:15 +0000] rev 456
Fix create redirect
Mon, 10 Nov 2008 00:39:50 +0000 Added support for providing a custom params dict
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 10 Nov 2008 00:39:50 +0000] rev 455
Added support for providing a custom params dict This has been a long outstanding feature request for tlarsen, luckily it turned out to be very easy to implement with the dict.merge utility method. To have custom _rights one should instead to the required access checks before calling the view method.
Mon, 10 Nov 2008 00:39:26 +0000 Minor fix to sponsor missing from the site restructure
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 10 Nov 2008 00:39:26 +0000] rev 454
Minor fix to sponsor missing from the site restructure
Sun, 09 Nov 2008 21:40:28 +0000 Add a Google Maps property to Site Settings
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 09 Nov 2008 21:40:28 +0000] rev 453
Add a Google Maps property to Site Settings Patch by: Lennard de Rijk <ljvderijk@gmail.com> Reviewed by: Sverre Rabbelier
Sun, 09 Nov 2008 21:24:49 +0000 Fixes to {Site,Home}Settings
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 09 Nov 2008 21:24:49 +0000] rev 452
Fixes to {Site,Home}Settings Also improved help text on HomeSettings partial_path and link_name.
Sat, 08 Nov 2008 18:35:46 +0000 Fixing the string for the default home page
Dmitri Gaskin <dmitrig01@gmail.com> [Sat, 08 Nov 2008 18:35:46 +0000] rev 451
Fixing the string for the default home page
Sat, 08 Nov 2008 17:40:12 +0000 Making the docs template prettier
Dmitri Gaskin <dmitrig01@gmail.com> [Sat, 08 Nov 2008 17:40:12 +0000] rev 450
Making the docs template prettier
Sat, 08 Nov 2008 17:06:35 +0000 Allowing + and - to be clicked in the menu
Dmitri Gaskin <dmitrig01@gmail.com> [Sat, 08 Nov 2008 17:06:35 +0000] rev 449
Allowing + and - to be clicked in the menu
Fri, 07 Nov 2008 22:24:01 +0000 Fix not working former_ids. Add support for "Invalid accounts". Now when id from former_ids tries to create a profile "This account is invalid." error message is displayed. Compare emails in lower cases to prevent changing User email to the same email with different character casing (needs some more testing).
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 07 Nov 2008 22:24:01 +0000] rev 448
Fix not working former_ids. Add support for "Invalid accounts". Now when id from former_ids tries to create a profile "This account is invalid." error message is displayed. Compare emails in lower cases to prevent changing User email to the same email with different character casing (needs some more testing). Patch by: Pawel Solyga
Fri, 07 Nov 2008 22:13:20 +0000 Some indention fixes and remove not needed variable in soc.logic.models.base module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 07 Nov 2008 22:13:20 +0000] rev 447
Some indention fixes and remove not needed variable in soc.logic.models.base module. Patch by: Pawel Solyga
Wed, 05 Nov 2008 23:38:00 +0000 Refactoring of {site/home}_settings to make them use base.View
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 05 Nov 2008 23:38:00 +0000] rev 446
Refactoring of {site/home}_settings to make them use base.View This makes the way for deleting the key_name.py module
Wed, 05 Nov 2008 23:36:28 +0000 Major site restructuring, also deleting of many unused or obsolete documents
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 05 Nov 2008 23:36:28 +0000] rev 445
Major site restructuring, also deleting of many unused or obsolete documents The new structure is as follows: <entity>/list - list all <entitie>s <entity>/create - create a new <entity> <entity>/show/<key fields> - public page for <entity> <entity>/edit/<key fields> - edit a <entity> <entity>/delete/key fields> - delete a specific entity
Wed, 05 Nov 2008 23:33:22 +0000 Fix sponsor key field extraction
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 05 Nov 2008 23:33:22 +0000] rev 444
Fix sponsor key field extraction When extracting key field there is no sponsor or user object, instead only their link names are known.
Wed, 05 Nov 2008 23:32:59 +0000 Implements base.Logic functions in home_settings, site_settings and work
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 05 Nov 2008 23:32:59 +0000] rev 443
Implements base.Logic functions in home_settings, site_settings and work This patch implements the base.Logic funtions needed for making logic/key_name.py obsolete. This patch defines the needed functions in home_settings, site_settings and work. All modules in logic/models now have these functions defined. logic/models/site_settings.py now inherits from logic/models/home_settings.py because of their similar connection in the corresponding models. Please note that the self._keyName for these two modules still points to logic/key_name.py since entity_type is still used in views/home.py. A partial_path and link_name were added to HomeSettings as requested by SRabbelier.
Tue, 04 Nov 2008 20:06:36 +0000 Fix wrong redirect when changing partial path or link name. Remove an unnecessary assignment in logic/models/base.py that would generate an error when an entity did not exist.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 04 Nov 2008 20:06:36 +0000] rev 442
Fix wrong redirect when changing partial path or link name. Remove an unnecessary assignment in logic/models/base.py that would generate an error when an entity did not exist. Patch by: Lennard de Rijk Review by: Pawel Solyga
Tue, 04 Nov 2008 14:09:37 +0000 Fix not working former ids feature of User Profile Developer Edit view. Add missing Error exception class to soc.logic.models.base module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 04 Nov 2008 14:09:37 +0000] rev 441
Fix not working former ids feature of User Profile Developer Edit view. Add missing Error exception class to soc.logic.models.base module. Patch by: Pawel Solyga
Tue, 04 Nov 2008 02:50:55 +0000 Third-party Javascript that should have been part of r891. Same license as
Todd Larsen <tlarsen@google.com> [Tue, 04 Nov 2008 02:50:55 +0000] rev 440
Third-party Javascript that should have been part of r891. Same license as JQuery. Patch by: Todd Larsen
Mon, 03 Nov 2008 19:47:02 +0000 Minor fixes needed for generic key name
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 03 Nov 2008 19:47:02 +0000] rev 439
Minor fixes needed for generic key name We no longer try to retreive an entity when there are unset fields. This sort of makes 'getIfFields' obsolete, since we check if fields now anyway. This is needed because getKeyFieldsFromDict expects the fields to be set. Also a minor fix in a Django template so that the generic 'edit' page has a working delete button again.
Mon, 03 Nov 2008 19:04:04 +0000 Quick fix to fix user profile creation
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 03 Nov 2008 19:04:04 +0000] rev 438
Quick fix to fix user profile creation This change will be obsolete when User refactoring is finished, but it will fix the build untill then.
Mon, 03 Nov 2008 18:20:53 +0000 Django Fix according to code.djangoproject.com/attachement/ticket/9115/check_for_unlink_in_temp.patch
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 03 Nov 2008 18:20:53 +0000] rev 437
Django Fix according to code.djangoproject.com/attachement/ticket/9115/check_for_unlink_in_temp.patch
Mon, 03 Nov 2008 15:03:09 +0000 Add missing TODOs to soc.logic.models classes. Fix comments format in base.Logic class. Changes based on comments to r972.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 03 Nov 2008 15:03:09 +0000] rev 436
Add missing TODOs to soc.logic.models classes. Fix comments format in base.Logic class. Changes based on comments to r972. http://code.google.com/p/soc/source/detail?r=972 Patch by: Pawel Solyga
Sun, 02 Nov 2008 22:57:46 +0000 Refactor out the abundance of dictionary (un)packing
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 02 Nov 2008 22:57:46 +0000] rev 435
Refactor out the abundance of dictionary (un)packing Instead, keep the dict packed once packed, and only unpack it when needed.
Sun, 02 Nov 2008 22:56:52 +0000 Added key field definitions to the User logic
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 02 Nov 2008 22:56:52 +0000] rev 434
Added key field definitions to the User logic This is the first part of making the User views generic.
Sun, 02 Nov 2008 22:56:28 +0000 Add a getForFields method
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 02 Nov 2008 22:56:28 +0000] rev 433
Add a getForFields method It allows for generic queries with restrictions specified in a dictionary.
Sun, 02 Nov 2008 22:50:22 +0000 Add a generic method for getting a Keyname
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 02 Nov 2008 22:50:22 +0000] rev 432
Add a generic method for getting a Keyname This patch will make logic/key_name.py obsolete in the future when everything is compliant with base.logic. This also makes the naming of already compliant logic modules generic and also fixes the _name field to be consistent with the naming in key_name.py. Note: This does not use Group/Sponsor, Group/School, Group/Organisation or Group/Club. Patch by: "Lennard de Rijk" <rijk0214@gmail.com> Reviewed by: Sverre Rabbelier
Sun, 02 Nov 2008 18:25:07 +0000 Added a missing 'pass' statement
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 02 Nov 2008 18:25:07 +0000] rev 431
Added a missing 'pass' statement
Sun, 02 Nov 2008 18:10:30 +0000 Create a Site Settings sub-menu
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 02 Nov 2008 18:10:30 +0000] rev 430
Create a Site Settings sub-menu
Sun, 02 Nov 2008 17:26:06 +0000 Fixed typo in e-mail address
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 02 Nov 2008 17:26:06 +0000] rev 429
Fixed typo in e-mail address Instead of 'sverre@rabbelier.nl' everything read 'sverer@rabbelier.nl'
Sun, 02 Nov 2008 17:25:10 +0000 Fixed typo in access check
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 02 Nov 2008 17:25:10 +0000] rev 428
Fixed typo in access check Instead of checking for 'public' the rights for 'edit' were checked.
Mon, 27 Oct 2008 19:31:51 +0000 The pretty blue triangles from Google Code!
Todd Larsen <tlarsen@google.com> [Mon, 27 Oct 2008 19:31:51 +0000] rev 427
The pretty blue triangles from Google Code! Patch by: Todd Larsen
Mon, 27 Oct 2008 19:19:44 +0000 Add tooltips style display of help_text, instead of widening the form with
Todd Larsen <tlarsen@google.com> [Mon, 27 Oct 2008 19:19:44 +0000] rev 426
Add tooltips style display of help_text, instead of widening the form with another (often ridiculously large) column. Also, version the .css and .js files so that browsers won't display the wrong cached one when we change something. Patch by: Dmitri Gaskin, Todd Larsen Review by: Todd Larsen
Mon, 27 Oct 2008 18:54:53 +0000 Change Site and User sub-menus so that the "header" entry for those sub-menus
Todd Larsen <tlarsen@google.com> [Mon, 27 Oct 2008 18:54:53 +0000] rev 425
Change Site and User sub-menus so that the "header" entry for those sub-menus is not a clickable link, but instead just a placeholder. Patch by: Todd Larsen
Mon, 27 Oct 2008 18:36:19 +0000 Use nice "plus" and "minus" symbols from Google Code, instead of current
Todd Larsen <tlarsen@google.com> [Mon, 27 Oct 2008 18:36:19 +0000] rev 424
Use nice "plus" and "minus" symbols from Google Code, instead of current triangles, for sidebar menu. Patch by: Todd Larsen
Sun, 26 Oct 2008 21:36:29 +0000 Add javascript expandable menus.
Augie Fackler <durin42@gmail.com> [Sun, 26 Oct 2008 21:36:29 +0000] rev 423
Add javascript expandable menus. Patch by: Dmitri Gaskin Review by: Augie Fackler
Sun, 26 Oct 2008 21:26:35 +0000 Add jQuery.
Augie Fackler <durin42@gmail.com> [Sun, 26 Oct 2008 21:26:35 +0000] rev 422
Add jQuery. Patch by: Dmitri Gaskin Review by: Augie Fackler
(0) -300 -100 -60 +60 +100 +300 +1000 tip