getDefaultMailSender now returns a tuple (name, email adress). Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Removed updateEntityProperties's transactionality entity.put() is already transactional, and all other methods called do not need transactionality (even so, it is hurtfull that they are run within a transaction). Patch by: Sverre Rabbelier

Denormalize accounts before trying to send e-mail Otherwise accounts that are in the auth domain are not a valid e-mail address. Patch by: Sverre Rabbelier

Added a denormalizeAccount Updated the existing testcases to make sure it works. Patch by: Sverre Rabbelier

Using getDefaultMailSender for welcome and notification messages. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added getDefaultMailSender method to mail_dispatcher. Will be used to determine from which mail address we should send an email. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed typo in soc/models/group_app. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Inform the user that the link_id cannot be changed Hide the extended help text once the user has created a profile, since the link_id can no longer be changed. Also moved the link_id to the top of the screen, to make it look better when the extended help text is not shown. Patch by: Sverre Rabbelier

Made the ToS field higher Patch by: Sverre Rabbelier

Removed double description field Patch by: Sverre Rabbelier

Revert "Make the input values 100% width." This reverts r2173, see r2101 for details. Patch by: SVerre Rabbelier

Make the input values 100% width.

Changed access checks for group applications to allow reviewing of rejected applications. Just in case the user made a mistake :). Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added bulk reject to org_app view. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Redone the review_overview template to show bulk reject button. Added a TODO to make both buttons dissapear. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Renamed org-accept.js to bulk-review.js Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Brown paper bag fix Patch by: Sverre Rabbelier

Fix for Issue 218. Basically just an update of the soc/gorup/messages/accepted.html template. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added a missing import Patch by: Sverre Rabbelier

Fix alignment of twoline readonly table rows Also removed an unused template tag. Patch by: Sverre Rabbelier

Added some tests for user logic Patch by: Sverre Rabbelier

Fixed a bug in student access check Patch by: Sverre Rabbelier

Allow to do 'checkHasActiveRole' checks for document access This is used for documents in the site prefix. Patch by: Sverre Rabbelier

Simplify the account retrieval logic Patch by: Sverre Rabbelier

Convert everything to use the new access methods Patch by: Sverre Rabbelier

Remove direct uses of checkIsActive, replace with helper methods This makes _checkIsActive a lot easier to understand, and makes the access checkers involved a lot more explicit. Patch by: Sverre Rabbelier

Make django_args optional where appropriate and whitespace fixes Access methods that do not use django_args should make it optional. Patch by: Sverre Rabbelier

Added an isDeveloper method to user logic Patch by: Sverre Rabbelier

Always normalize accounts, before even storing them Patch by: Sverre Rabbelier

Factor out the getForAccount logic in user Also normalize the account before retrieving it. Patch by: Sverre Rabbelier

Add a normalizeAccount to logic.accounts Patch by: Sverre Rabbelier

Remove unused isAccountAvailable function Patch by: Sverre Rabbelier

Add a _createField hook Patch by: Sverre Rabbelier

Pass _updateField the entity_properties dict instead of just the value This enables _updateField to change the value in entity_properties if desired. Patch by: Sverre Rabbelier

Do not update newly created model properties There is no real reason to favor old behavior over the current, plus the new behavior saves an extra disk write (which are expensive). Patch by: Sverre Rabbelier

Move the hooks in base.Logic to the bottom of the class This more closely follows 'important methods first'. Patch by: Sverre Rabbelier

Minor cleanups in base.Logic Patch by: Sverre Rabbelier

Add argument validation to base.Logic Patch by: Sverre Rabbelier

Remove updateOrCreateFromFields and it's uses All uses of updateOrCreateFromFields were replaced with updateOrCreateFromKeyname. This way the logic API is not as cluttered with a bunch of helper methods. Patch by: Sverre Rabbelier

Fix some whitespace damadge and a style fix Patch by: Sverre Rabbelier

Remove _silentUpdateEntityProperties Instead, pass a silent flag to updateEtitytProperties. Patch by: Sverre Rabbelier

Style fix in role.py Patch b: Sverre Rabbelier

Added todo for Lennard Patch by: Sverre Rabbelier

Make it more explicit which argument is the key_fields Patch by: Sverre Rabbelier

Solved the JSON caching problem for bulk acceptance. This is done in the same way as it is done in AJAX calls by appending the current time as a GET argument. Patch by: Mario Ferraro, Lennard de Rijk Reviewed by: Lennard de Rijk

Edited checkCanReviewGroupApp to cope with the new pre-rejected status. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Add the ability to put GroupApplications into the pre-rejected state. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added pre-rejected choice to GroupApplication. This will be used to bulk reject organizations. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Remove the release.py module and just use the field in app.yaml.template. This is a DRY fix, to have the release /branches/ and /tags/ use a release version that is compatible with the app.yaml file "version:" field. Also, the steps for creating a release were simplified (with several steps removed), and the release procedure moved to app/README, since app/soc/release.py is now deleted. Patch by: Todd Larsen Review by: to-be-reviewed

Make validate.isURLValid more robust Also make the control flow more explicit while at it. Patch by: Sverre Rabbelier

Fixed broken 'Edit <entity name> Settings' for orgs Patch by: Sverre Rabbelier

Fix the delete button submitting the form Patch by: Sverre Rabbelier

Added proposal withdrawal for students. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Pass the seed to _constructResponse This way _editContext has access to it; this will be used by the commenting system. Patch by: Sverre Rabbelier

Allow the document lookup to be done by key name This will be used by the commenting logic. Patch by: Sverre Rabbelier

Removed double home page link in group public view Patch by: Sverre Rabbelier

Reset the RELEASE_TAG to None (unreleased) now that the 0.4-20090224 release candidate branch has been created. Patch by: Pawel Solyga

Set RELEASE_TAG to 0.4-20090224rc for release candidate. Patch by: Pawel Solyga

Textual change in program menu due to comment on r2113. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Style fixes in student_proposal and organization view. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Textual changes in organization and program view. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added view for organizations to list all proposals. Currently this redirects to the public view of a proposal. Also added extra whitespace for clarification in _getExtraMenuItems. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Brown paper bag fix Patch by: Sverre Rabbelier

Added list proposals redirect. This is used to list student proposals directed to one organization. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added a checkHasAny method A simple 'OR' for checkers. Patch by: Sverre Rabbelier

Added redirect for the student proposal view. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed the method and variable name in student_proposal to match the access type. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added link in program menu to the new list_orgs view. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added view which lists all orgs a student can propose to. The redirect takes the student to the create proposal page. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Add missing comment to checkIsMyEntity Patch by: Sverre Rabbelier

Make all default URLS customizable Patch by: SVerre Rabbelier

Fix the user editing Noticed by: Lennard de Rijk Patch by: Sverre Rabbelier

Moved google analytics to after the footer block as commented on r866. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Update the test suite to match the new signature of the cache methods Patch by: Sverre Rabbelier

Be more lenient in what we accept in cache.get() and cache.put() This makes testing easier. Patch by: Sverre Rabbelier

Make timeline a Linkable Patch by: Sverre Rabbelier, Lennard de Rijk

Set proper scope_logic for program and timeline Patch by: Sverre Rabbelier, Lennard de Rijk

Changed the message displayed when no homepage is set to show the correct settings name. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Textual change in cleaing.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Temp IE7 style fix for forms. A percentage-based layout does not seem to work in IE7, the fields show up as large as the initial text that is in them. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added list my Student Proposals link to the program menu. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added listing of your own student proposals. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Base view list method can now use kwargs. This is needed for listing your own student proposals. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed the access checks in student_proposal view to use the newly created checks. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added several access checks for student proposals. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Updated student proposal templates. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed params used for list_action and list_description in user_self roles overview. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Remove superfluous 'Org' in links Patch by: Sverre Rabbelier

Fix datetimepicker so that it doesn't add trailing whitespaces. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Convert student and org_admin to dynafield Patch by: Sverre Rabbelier

Don't show empty lists in /user/roles Patch by: Sverre Rabbelier

Make it possible not to generate empty lists Patch by: Sverre Rabbelier

Make it possible to display a message when there are no lists Patch by: Sverre Rabbelier

Make use of site_name where possible Patch by: Sverre Rabbelier

Specify example_text for backup admin link id Patch by: Sverre Rabbelier

Added a link to "Site Settings" for the GMaps API Key missing msg Patch by: Sverre Rabbelier

Add some missing useJavaScript calls Patch by: Sverre Rabbelier

Flush cache after seeding or clearing the datastore Patch by: Sverre Rabbelier

Style fixes in jquery-ui.datetimepicker.js file. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Add generic datepicker support Any date(time) field now automatically has a picker widget. Patch by: "Haoyu Bai" <baihaoyu@gmail.com> Rebased by: Sverre Rabbelier Reviewed by: To-Be-Reviewed

Use site name and noreply address when sending emails Patch by: Sverre Rabbelier

Fixed whitespace damadge and missing EOL Patch by: Sverre Rabbelier

Added an 'are you sure' message to the delete button Patch by: Sverre Rabbelier

Added a 'site name' property to site Patch by: Sverre Rabbelier

Use feedparser to sanitize HTML content for documents Patch by: Sverre Rabbelier

Forgotten import Patch by: Sverre Rabbelier

Make use of the new checkHasDocumentAccess method Patch by: Sverre Rabbelier

Added a checkHasDocumentAccess method Uses the SCOPE_DEPTH to determine how far to walk up the scope so that the correct value for scope_path is set. Patch by: Sverre Rabbelier

Specify how to walk the scope up to another scope This will be used by document ACL later. Patch by: Sverre Rabbelier

Make use of default value field_name is not modified and as such it is possible to properly use the default value system (rather than just specifying None). Patch by: Sverre Rabbelier

Also pass the prefix in the document cleaning method The prefix is needed to determine how far to walk up the scope. Patch by: Sverre Rabbelier

Add a "Developer" tag in the top sidebar if appropriate Patch by: Sverre Rabbelier

Updated comments in access.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added several menu items to the program menu. For example, non-students now see a Apply as a mentor link that takes them to the list of all active organizations. This only happens when the organizations announced deadline has passed. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fix access bug in organization Patch by: Sverre Rabbelier

Added support for having a format string as scope_path filter Patch by: Sverre Rabbelier

Fixed a bug in seed_db The mentor and org for Melange were created with wrong scope and key. Patch by: Sverre Rabbelier

Convert mentor.py to use DynaFields as an example Patch by: Sverre Rabbelier

Hook up dynafields in params.py The helper method getDynaFields converts a list with dynafield dicts to a dictionary with dynaproperties and is used to update the create- and edit_dynaproperties dicts. Patch by: Sverre Rabbelier

Added DynaFields to the dynaform module DynaFields work similar to DynaForms, in that they allow a regular field to be created by supplying a dictionary. The main advantage is that any property can be added, even if the base class doesn't have support for it. Patch by: Sverre Rabbelier

Rename dynafields to dynaproperties This is to prepare for true dynafields. Patch by: Sverre Rabbelier

Update seed_db as WTFPL is no longer an allowed license Patch by: Sverre Rabbelier

Added student_proposals to the sitemap. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Scope is already set to entity.scope, so no need to overwrite in base._editPost(). Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added student_proposal view. Note that the access checks still need to be done and other functionality like ranking/scoring and withdrawal of the application are not in yet. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added new cleaning method to validate a student proposal. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Since scope does not change we do not need to call getFromKeyName every time. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added student proposal view templates. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added student_proposal logic. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Made some changes to StudentProposal. Abstract is now required and content field has been added. New is now the default status. This will be used to easily distinguish between applications that didn't have their initial ranking/scoring yet. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed name method in soc/models/role.py Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Add caching to the homepage Homepage is flushed when the home document is changed. Patch by: Sverre Rabbelier

Compute the memcache_key only in get() This will be used by the homepage caching later on. Patch by: Sverre Rabbelier

Set and unset the home_for property if appropriate Patch by: Sverre Rabbelier

Add an home_for reference property This field will be set to whatever presence is using the document as home document. Patch by: Sverre Rabbelier

Added a document in the test user's user space This makes it easier to test editing documents. Patch by: Sverre Rabbelier

Redone form field filling via request.GET to work on multiple fields. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Removed obsolete import from sitemap/build.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

First go at the student proposal model. The scope will be set to the student role and the link_id will be time-based. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Footer of melange now resizes properly. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Fixed grouping and updated help text Patch by: Sverre Rabbelier

Make the heading line up with the input fields Patch by: Sverre Rabbelier

Deleted stale comment Patch by: Sverre Rabbelier

Fixed copy/paste fail Patch by: Sverre Rabbelier

List public view for organizations should be program limited. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added apply as a mentor view which lists all orgs for a given program. The check if someone can actually request to become a mentor is done after the user has selected an organization from this view. This is not bad because a student would never see the link to this page in the program menu. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added a link to the official OSI licenses list Patch by: Sverre Rabbelier

Make org_app use the new licenses set Patch by: Sverre Rabbelier

Added OSI approved licenses Patch by: Sverre Rabbelier

Wording nitpick fix Patch by: Sverre Rabbelier

Rebased my double work on top of Todd recent commit Patch by: Sverre Rabbelier

Make it easier to support other extensions per-Model (such as .csv, etc.). Patch by: Todd Larsen Review by: to-be-reviewed

Force browser to ask to save an Export, and provide a filename extension. See: http://code.google.com/p/soc/issues/detail?id=192 Patch by: Todd Larsen Review by: to-be-reviewed

Fixed blog on home view For some reason the script does not work if it resides in it's own file, perhaps some JS guru can enlighten? Patch by: Sverre Rabbelier

Clean the e-mail field Patch by: Sverre Rabbelier

Add a regular 'empty field cleaner' Regular, as opposed to a decorator. Patch by: Sverre Rabbelier

Bugfix in student view. This got triggered when a student agreement was set and the create student button was clicked. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Reset the RELEASE_TAG to None (unreleased) now that the 0.3-20090219 release candidate branch has been created. Patch by: Pawel Solyga

Set RELEASE_TAG to 0.3-20090219rc for release candidate. Patch by: Pawel Solyga

Added a missing cleaner to org idea list Patch by: Sverre Rabbelier

Fixed a missing property in seed_db Patch by: Sverre Rabbelier

Add noreply email property to Site model. Still missing cleaner method and changes in notifications module. Patch by: Pawel Solyga Reviewed by: to-be- reviewed

Use the new program property in mentor and role for an access check. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added required program property to org_admin and mentor. This can be used to simplify checks. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Org admins can now send out invitations and users can now request to become a mentor. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Accidently left one addrole in student.py during my quest to refactor it into params. It has now been removed. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Role overview membership is now determined by setting show_in_roles_overview param to true in the view. Also added student roles to the list. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Students now have a reference to school again. This reference property is not required for now since the system for choosing your own school isn't implemented yet. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Students can now only get a student role during the student signup period. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed style error. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added students to sidebar. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added student view and accompanying templates. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added new redirect to redirects helper. In preparation for student view. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Students can not become a mentor or org_admin in the same program. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Parameterized the role view manage redirect. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added new access methods. This is used to prevent students from becoming mentors/org_admins and vica versa. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Redone student model and added student logic. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixes the problem of <Entity> Saved not being shown whenever a new entity is created. Patch by: Madhusudan C.S. Reviewed by: Lennard de Rijk

Fixed twoline style broken by recent 'form prettification' commit Patch by: Sverre Rabbelier

Implemented simple group sorted using numerical ordering See role.py for some example usages. Note that the reason ToS does not appear seperately is due to the fact that it is defined as a regular field which does not take the group field from the one defined in the model. Patch by: Sverre Rabbelier

Add a groupby method to dicts This function behaves similar to Django's groupby filter. Patch by: Sverre Rabbelier

Make the web forms look a little nicer.

Typo fix in seed_db module which caused loaded organization applications not to work correctly (wrong keyname). Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Style fixes in org-accept.js file. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Remove extra space from soc.views.helper.access module. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix a bug in group_app.py (not defined context was used). Patch by: Pawel Solyga Review by: to-be-reviewed

Update org bulk accept script. The script now: 1) leaves correctly control to the browser to update the GUI of the progress bar during ajax communication. 2) Displays an error if something went wrong (I've tried in my box stopping the server while doing the requests), and show a retry button to fetch again the list of the applications that are still not accepted and iterate over them again (seems to recover correctly restarting the server after the error in my box) 3) doesn't display any text at the beginning, and the button has the correct CSS class assigned 4) Check if there are applications to accept, if not displays a message stating that there are no orgs to accept. Patch by: Mario Ferraro Reviewed by: Lennard de Rijk

Add GHOP as program and put 'Melange' under it This makes it easier to verify that filtering by program works in the slot allocation view. Patch by: Sverre Rabbelier

Seed in some orgs This is to facilitate testing of a 'slot allocation' ui. Patch by: SVerre Rabbelier

Fixed a copy/paste bug in group.py Patch by: Sverre Rabbbelier

Added grouping support to all forms, converted role as example Any field that has the 'group' property set be placed in the specified group. If no such proprty is set, the 'General' group will be used instead. Patch by: Sverre Rabbelier

Refactor various django templates to reuse other templates where possible Patch by: Sverre Rabbelier

Be modular when loading the various JS modules Patch by: Sverre Rabbelier

Prepare all views for a new modular approach to JS loading Patch by: Sverre Rabbelier

Make various JS methods into their own file This facilitates re-use of these files. Patch by: Sverre Rabbelier

Add a Home document to the seeded entities Patch by: Sverre Rabbelier

Fix import sorting in soc.logic.cleaning module. Patch by: Pawel Solyga Review by: to-be-reviewed

Add missing blank line in soc.logic.rights module. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix import sorting in soc.views.models.program module and rename any "Org" in link names to "Organization". Patch by: Pawel Solyga Review by: to-be-reviewed

Change the message shown when org admin already agreed to agreement when creating org application. Patch by: Pawel Solyga Review by: to-be-reviewed

Add missing dots in messages in soc.views.helper.access module. Patch by: Pawel Solyga Review by: to-be-reviewed

Hopefully fix json caching issues in IE7. Will wait for Lennie to confirm if it works correctly now. Patch by: Pawel Solyga Review by: to-be-reviewed

Seed more roles and factor out common properties Patch by: Sverre Rabbelier

Rename current 'roles' view to 'request' and add a real roles view Patch by: Sverre Rabbelier

Keep a global list of all known Roles This is to facilitate a view with a list of a user's roles. Patch by: Sverre Rabbelier

Fixed a bug in admin_form generation The edit_form was also being modified. Patch by: Sverre Rabbelier

Redirect to the admin view in listPublic Patch by: Sverre Rabbelier

Hook up the admin view everywhere Patch by: Sverre Rabbelier

Add an admin view Makes use of the new admin form and the as_readonly_table tag. Patch by: Sverre Rabbelier

Add an as_readonly_table filter Results in a very plain table, with no error messages etc. Intended use is in combination with PTW's. Patch by: Sverre Rabbelier

Add an admin redirect Patch by: Sverre Rabbelier

Make _constructResponsoe take an optional template Patch by: Sverre Rabbelier

Add an AdminForm that renders all fields as PTW's Patch by: Sverre Rabbelier

Add a PlainTextWidget Patch by: Sverre Rabbelier

Use entity.key.name instead of key_suffix Patch by: Sverre Rabbelier

Added melange as org. Also added license text and author. Patch by: Sverre Rabbelier

Fixed a bug in access.py where a non-existing variable would have been called. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added clean_user_is_current to cleaning and fixed some indentation. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Add a script to (re)seed the datastore For obvious reasons enabled only when running in debug mode. Patch by: Sverre Rabbelier

Added no-cache headers to pick and bulk-accept views. Also added a TODO since IE7 seems to ignore the headers. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Remove private data from club and org public templates Also re-use the club/public.html template in organization's template. Patch by: Sverre Rabbelier

Skip a field when it's value is not set Patch by: Sverre Rabbelier

Added bulk acceptance and progress bar in review org applications view. In the list of organization applications for reviewing, if you click the button "click here" the whole first text line will fade out and the progress bar will fade in while starting to contact the server for the list of orgs to accept and then make synchronous calls for acceptance, while updating the progress bar, the name of the organization currently accepting and the number of orgs already accepted against the total. Inside the script, what's inside the parenthesis is converted due to regexp (in this case (link_id)) and then read the json_object.applications[index].link_id. By doing this with an eval(), you can use other names as well and the script will be reading for example json_object.applications[index].attribute_name if you insert "(attribute_name)" inside the link returned by {{ bulk_accept_link }}. Notes by Lennard: -Put Done outside the for-loop so that it also shows when there are 0 pre-accepted organizations. -Made some minor style fixes Patch by: Mario Ferraro Reviewed by: Lennard de Rijk

Now using the correct path to the loading animation in jquery-thickbox. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Minor style fix dicts.merge already takes care of the case where target is None. Patch by: Sverre Rabbelier

Add a list_public view to organization Patch by: Sverre Rabbelier

Factor out the 'key fields without link_id' logic from document Also make sure the to-be-removed is present before removing it when doing the field reordening. Patch by: Sverre Rabbelier

Add a getListRedirect and getListPublicRedirect function Patch by: Sverre Rabbelier

Add an idea list (url) property to organization Also include this url in the organisation list. Patch by: Sverre Rabbelier

Fixed missing parameters in program view due to change in _getTimeDependentEntries in r1943. Also the sidebar once more shows "Apply to become an Organization" even if you are not logged in. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Include scope_path as django_args Otherwise users cannot create documents in their own prefix. Patch by: Sverre Rabbelier

Disable the raw create and list link for documents Patch by: Sverre Rabbelier

Add custom access check for document listing Patch by: Sverre Rabbelier

Add a 'list documents' link everywhere Also disable the Documents sidebar menu, since it does not provide anything useful anymore. Patch by: Sverre Rabbelier

Allow documents to be filtered by prefix and scope Patch by: Sverre Rabbelier

Developers have all roles Patch by: Sverre Rabbelier

Organization prefix was renamed to 'org' The reference to it in the logic/rights.py module was not updated. Patch by: Sverre Rabbelier

Force-check the 'agreed to admin agreement' field if applicable If the current user is the applicant of the relevant organization, they already agreed to the agreement once. As such the box should be pre-checked. Patch by: Sverre Rabbelier

Fix a bug in group_app If context is not set, kwargs['context'] will raise an exception. Patch by: Sverre Rabbelier

Add cleaning methods for document ACL Patch by: Sverre Rabbelier

Make document ACL's a constant This makes it possible to refer to it in other modules. Patch by: Sverre Rabbelier

Fix a bug if you have no roles at all This could not happen currently, but might happen later on if a group is defined that does not have an 'anybody' membership. Patch by: Sverre Rabbelier

Partially reverted "Update the copyright notice for 2009." This partially reverts commit r1933. Only the files that were created in 2008 were reverted. Patch by: Sverre Rabbelier

Update the copyright notice for 2009. Patch by: Sverre Rabbelier

Fix ToS link s/Terms/Google App Engine Terms/ Patch by: Sverre Rabbelier

Do access checks on the pick url for documents Patch by: Sverre Rabbelier

Convert the QueryDict to a regular dictionary This way we support a query with multiple args specified. Patch by: Sverre Rabbelier

Add prefix filtering and refactored program field generation Patch by: Sverre Rabbelier

We generate the select url ourselves, so it's safe This prevented urls with an & in it to be correctly generated. Patch by: Sverre Rabbelier

Added a filter_fields parameter to the ReferenceField widget This paramater makes it possible to do 'hard coded' filtering. Patch by: Sverre Rabbelier

Factor out the hasMembership method from checkMembership This makes it possible for the document picker to reuse it. Patch by: Sverre Rabbelier

Add a getMemberships method to logic/rights.py This will be used by the document picker ACL checks. Patch by: Sverre Rabbelier

Fixes as requested by Leslie on behalf of the Legal team Upped the copyright statement from 2008 to 2009, and link to the GAE Terms of Service instead of any custom ToS. Patch by: Sverre Rabbelier

Added number of applications and their type to the bulkaccept JSON object. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Implemented the 2nd part of bulk acceptance. The context of the _list call can now be set by using the kwarg context. This will be merged with the universalcontext. Added a TODO to create the organziation accepted email template. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Document prefix in params now defaults to url_name. This is because the short name does not have to be url friendly. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added bulk_accept view which returns a JSON object. This is going to be used to bulk accept org applications. Also added a new unfinished template so Merio can test his JS. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Only a club admin should see resign as club admin in the sidebar. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed a bug in club and org logic. This bug would give an error when no backup was set. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed a bug in group_app templates. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Brown Paper Bag Fix: L2R Appspot error logs. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed a bug in group_app view. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Returning None instead of the empty to fix a bug on melange-demo instance. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added check_field_is_empty decorator to cleaning.py. This makes sure the cleaning checks are skipped when a field is empty. Note that Djanog will raise it's own ValidationError when a required field is empty before attempting to clean it. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed.

Org App review page now shows accept and pre-accept button. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed comment and typo in cleaning.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Add ToS agreement to mentor application related forms. Patch by: Sverre Rabbelier

Add ToS agreement to org_admin application related forms. Patch by: Sverre Rabbelier

Do not attempt to render a field if it is disabled This is required to make it possible to disable fields dynamically. Patch by: Sverre Rabbelier

Program requires the filter to be set to __scoped__ Patch by: Sverre Rabbelier

Disable clubs for now Disabling the clubs in this way is a lot easier than adding a switch for it in Site Settings, and probably safer too (as the urls are no longer valid). Patch by: Sverre Rabbelier

App Engine 1.1.9 update breaks django 1.0. Monkey patch django to only check for SVN revision number when not running using dev_appserver. On deployed version this doesn't apply since we use django from zipped file. This issue was discussed here: http://groups.google.com/group/codereview-discuss/browse_thread/thread/a7ab6ceb39c09ce6 http://groups.google.com/group/google-appengine/browse_thread/thread/bbdebf8617b57512 Patch by: Pawel Solyga Review by: to-be-reviewed

Load /Users/solydzajs/Downloads/google_appengine into trunk/thirdparty/google_appengine.

Removed unused argument in program.py Patch by: Sverre Rabbelier

Initial implementation of a ToS requirement in org_app If the _editContext method can be made generic enough, it should be easy to add ToSes to other forms. This solution should also be applied to user_self, as the current implementation is not very clean to say the least. Patch By: Sverre Rabbelier

Added an AgreementField widget Displays an Agreement Document in a scrolling text field. The text of the document can be set by modifying the 'text' property. Patch by: Sverre Rabbelier

Rename TinyMCE to FullTinyMCE and add TinyMCE widget The FullTinyMCE (irony intended) is the full-fledged editor, usefull in editing documents etc. The regular TinyMCE widget can be used for smaller tasks that allow HTML input (such as the description field). Patch by: Sverre Rabbelier

Use the newly added __scoped__ and references for program's ToSes This fixes the ToSes autocompletion and 'enables' them. Patch by: Sverre Rabbelier

Added an agreed_to_admin_agreement property Patch by: Sverre Rabbelier

Add '__scoped__' as a special filter It sets the scope_path to the entity's key().value(). Patch by: Sverre Rabbelier

Fields are always safe, as we generate them ourselves This will be used by a future widget. Patch by: Sverre Rabbelier

Add an _editContext hook Usefull when one wants to have a hook that will always be called. Patch by: Sverre Rabbelier

Resolve references if they are specified All views sould make use of this instead of doing it manually in _editGet and _editPost. Patch by: Sverre Rabbelier

Make it possible to put fields at the end of the form This is usefull for Terms of Service etc. Patch by: Sverre Rabbelier

Changed the access checks for organization. This should allow normal users to use organizations as well. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added allowsidebar to checkIsDocumentReadable. Note that this means that documents you can't actually read might show up in the sidebar. A todo has been added to fix this. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added organization entity sidebar entries. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed a bug in access.py that made it impossible to show featured documents in the sidebar. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed document to also filter on the prefix when getting the documents for a scope. For this to work the organization prefix is now org. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed a typo in org_admin model. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added Agreement properties to Program Model. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Reset the RELEASE_TAG to None (unreleased) now that the 0.2-20090209 release candidate branch has been created. Patch by: Pawel Solyga

Set RELEASE_TAG to 0.2-20090209rc for release candidate. Patch by: Pawel Solyga

Added a button to list all your org applications to a speficic program menu. The entry only shows up when orgs can apply. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Put the tos extra_dynaexclude in presence_with_tos.py where it belongs. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Redone the listing in group_app.py. There is now a list_self that only shows the group application of the current user in the given a scope. The redirects point to edit or applicant when necessary. Review_overview will show all the group applications that can be reviewed in the given scope, the redirect points to review for all statusses. And list will just show all the group applications and redirect you to edit. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added new redirect for the new list views for group_app's. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fix bug in group_app Patch by: Sverre Rabbelier

Temp bug fix This should be fixed properly at some point. Patch by: Sverre Rabbelier

Add myself to authors since I was missing. (Also, a test commit for buildbot) Patch By: Augie Fackler <durin42@gmail.com> Review By: TBR

Fixed access checkers for orgs Patch by: Sverre Rabbelier, Lennard de Rijk

Remove unneeded stylesheet and js and fix notification area Patch by: Sverre Rabbelier

Rename checkHasActiveRole to checkHasActiveRoleForScope This is to prepare for a checker that checks if the user has any such role, regardless of scope. Patch by: Sverre Rabbelier

If there is no user account, don't show New Document link under Site Patch by: Sverre Rabbelier

Fixing r1855 that was bugged by Tortoise ^_^. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed broken autocomplete due to wrongly named file This should have been in r1852. Patch by: Sverre Rabbelier

Should be part of r1855. FOSDEM got the best of me :). Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Use short_name for the header title in a presence's home page Patch by: Sverre Rabbelier

Handle GAE account normalization Also forbid users from going back to a former account. Patch by: Sverre Rabbelier

Pimp TinyMCE widget. Patch by: Sverre Rabbelier

Always return a site singleton and fix Edit Site Settings Patch by: Sverre Rabbelier

Stylefixes in access.py and removal of self.deny calls The result of self.deny() is not very helpfull to the user, as such we should not use it if we can provide a more sensible message. Also made the document access checks use getForKeyFieldsOr404 to prevent an error page when the specified document doesn't exist. Patch by: Sverre Rabbelier

Added scoped group_app listing. Also moved the review program applications menuentry to the specific program menu. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added missing comment in access.py and removed excessive whitespace. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Hide all *.pyc files in trunk/. r1850 was supposed to be a recursive property change, but was not. Patch by: Todd Larsen Review by: to-be-reviewed

Name .js and .css files more consistently with those previously present. Patch by: Todd Larsen Review by: to-be-reviewed

Add image that appears to be missing from the original thickbox patches. Patch by: Todd Larsen Review by: to-be-reviewed

Hide *.pyc files in trunk/ from 'svn status' output. Patch by: Todd Larsen Review by: to-be-reviewed

Added pre-accpeted status to group_app. This can be used when we want to accept all org's at once. Instead of one by one. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added some help_text and clarifications to org_app model fields. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Cleanup in org_app and replace ReferenceProperty with LinkProperty Using LinkProperty allows the org to host their idea's list on Melange through the Document system, and then specify the URL of that document. This also makes it possible for the orgs to specify a document that is not hosted on Melange. Patch by: Sverre Rabbelier

Refactored the picker so that it is more generic The picker now also works in the case the scope_path of the entity should not be filtered on. Also, it is now easier to add new functionality due to the fact that there is a seperate Field type to handle it now. Patch by: Sverre Rabbelier

Added a ReferenceField widget Also removed the unused ReadOnlyBool widget (as we now have a properlyworking ReadOnly widget). Patch by: Sverre Rabbelier

Make picker work generically Also removed some unused params from the JSON object. Deleted the now unused checkHasPickGetArgs method. Patch by: Sverre Rabbelier

Fix broken document access checks The 'normalized checker' syntax was used to specify the access checkers, but the normalization never happened. Patch by: Sverre Rabbelier

Org applications can now only be made by a user when a program allows it. To do this a new access_type has been added called apply. This ensures that users can only used the seeded version of create. Also the review_overview now has his own access type to ensure the separability of hosts for different sponsors in case of org app reviews. Note that the access checks for hosts are broken and only give access to developers at the moment. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added a new redirect for apply accesstype. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added new access checks to deal with timeline for programs. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Updated docstrings and used keyfields where necessary in soc/logic/models/base.py Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Remove extra whitespaces in soc.views.models.organization module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Add missing blank line to soc.logic.helper.timeline module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Fix import sorting in soc.views.models.sponsor module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Cleaned up getKeyNameFromFields in Logic base. You can now pass it a dictionary that can contain other fields next to the keyfields. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Reverted r1819 and making an application will now reserve the link_id indefinitely. This is to make sure our statistics dont get messed up. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Make the ToS text in-line and hook up thick-box in the help-text. This way the user can see the ToS in scrollable form between the link_id and the 'agree to tos' checkbox. Also, when clicking on the link to the 'side-wide terms of service' a thickbox will pop up and display the Terms of Service in an overlay. Patch by: "Mario Ferraro" <fadinlight@gmail.com>

Hook up the new jquery plugins in base.html and _as_table_row.html A very important todo here is to make loading these plugins only when needed, as to not waste bandwith. This should be trivial to do later on though, so leaving as-is now. Patch by: "Mario Ferraro" <fadinlight@gmail.com> Reviewed by: Sverre Rabbelier

Include the field_id in the context of _as_table_helper This makes it possible to refer to the field that is being edited by it's ID (in for example Javascript). Patch by: "Mario Ferraro" <fadinlight@gmail.com>

Make toDict "dereference" the 'name' property if it is present This makes it possible to turn 'name' into a consistent alias that can be used to represent an entity. Patch by: Sverre Rabbelier

Added jquery thickbox, ajaxQueue, autocomplete and bgiframe Also added the soc-specific stylesheets for jquery and thickbox. Patch by: "Mario Ferraro" <fadinlight@gmail.com>

Now calling block.super in timeline/edit.html template. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Added timezone clarification to the timeline edit form. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Specific program menu's now show a "Apply to become an Organization" entry when the program's timeline states that it's open. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added new helper module for timelines. This helps to determine wether a given event or period has begun/isactive/ended. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added missing table header for org_apps. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Refactored the application review template into group_app. Patch by: Madhusudan C.S Reviewed by: Lennard de Rijk

Added validate_new_group to cleaning and removed clean_new_club_link_id. This new cleaning method is a general purpose method for cleaning the form of a new group or group_app. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed an error in group_app view that didnt let you create a new application. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Renamed checkHasRole to checkHasActiveRole. We need this distinction to later allow another check to grant access upon a role that also might be inactive. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added removal of an existing group application when someone else is applying. This makes sure that the fields we do not collect via the form also get wiped when a rejected application is being redone by someone else. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added checkCanReviewGroupApp to acces.py. To make this work allowSidebar decorator was added as well. This will make sure that the Review buttons show up in the sidebar. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added checkCanEditGroupApp to access.py. Group Applications can now only be edited if they are either rejected or still in need of review. Also fixed a bug in checkIsMyEntity. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed whitespace in /soc/models/group_app.py Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added some extra isUser checks to make sure that you have to accept the ToS before you can do anything concerning requests. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixes a bug where notifications can't be deleted. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Only do the update routine when the status changes for group_app's and role requests. This helps prevent spamming multiple notifications. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed a bug where a GMAP error message would be displayed when the form was not valid. The wrong params were used, so the wrong template was used to display the form. This also caused the instruction_text to dissapear. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

The simplejson in Django is now used, so do not create a symlink in build.sh. Patch by: Todd Larsen Review by: to-be-reviewed

Fixed a typo in getForCurrentAccount comment. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Adds the possibility to exclude the user from the website. getForCurrentAccount now only returns a user entity when it is valid. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed default value for write_access in Document model. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Probably fixed a bug on the live instance. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

More access related fixes Also make it possible to do access checks for 'create'. Patch by: Sverre Rabbelier

Reset the RELEASE_TAG to None (unreleased) now that the 0.2-20090202 release candidate branch has been created. Patch by: Pawel Solyga

Set RELEASE_TAG to 0.2-20090202rc for release candidate 02/02/2009. Patch by: Pawel Solyga

Fixed EOL errors. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Create org_application now shows select program view. Also fixed the menu heading. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Use .logic in checkIsAllowedToManageRole at the caller This is to be consistent with the rest of the module. Patch by: Sverre Rabbelier

Make getForFields work with no filter Patch by: Sverre Rabbelier

Fixed EOL damage in org_app and access checks Patch by: Sverre Rabbelier

Calling getForCurrentAccount where necessary. Also fixed whitespace error in soc/views/models/user_self.py Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed club_app The user could not edit their own club app due to a buggy check. Patch by: Sverre Rabbelier

Rewrite getForFields to use GQL instead of the Query API Apparently the Query API does not support the IN statement. Patch by: Sverre Rabbelier

Removed work flow field from the check in getExtraMenus for program. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

More access related fixes Patch by: Sverre Rabbelier

Fixed access related bugs Patch by: Sverre Rabbelier

Make longitude and latitude hidden fields not required in soc.views.models.role module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Fix broken Roles public templates. By mistake we used entity.user.public_name instead of entity.user.name. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Changes in club_app and org_app public templates. Don't show email address in public template. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Style fixes in soc.views.models.user module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Style fixes in soc.logic.models modules. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Fix missing indention in css file. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Set the right field type in user_self to overcome confusion. Also reverted a template change. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Adding a hidden agreed_to_tos field when the user has signed the ToS. This a more cleaner solution then r1774. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fix the JS but mentioned in the previous commit Patch by: Sverre Rabbelier Reviewed by: Pawel Solyga

Fix get args construction when there are multiple lists on the page It is now possible to go back and forward through the liast, and specify the limit (both offset and limit can be done per list). The JS driving the list boxes is buggy, if visiting an url like: http://localhost:8080/notification/list?limit_0=10 And then change the limit in the second checkbox, it directs to: http://localhost:8080/notification/list?limit_1=25 Whereas it should redirect to: http://localhost:8080/notification/list?limit_0=10&limit_1=25 The logic _does_ work properly when the limit of the changed list is already present in the url. Patch by: Sverre Rabbelier

Unify 'getForFields' and 'getForLimitAndOffset' This also fixes the broken list views for filtered lists. Patch by: Sverre Rabbelier

User profile now shows the time on which you signed the ToS. Note that this solution is temporary and a hidden_field_as_table_row will be made by Pawel soon. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Cleaned up access.py Removed a lot of duplicate code and added more generic checkers in their place. Patch by: Sverre Rabbelier

Do not return empty menu's in program. Patch by: Sverre Rabbelier

This patch prohibits changing of agreed_to_tos and agreed_to_tos_on by the Logic module. This is used so that legally the agreed_to_tos fields can never change in the User model once set. Patch by: Haoyu Bai Reviewed by: Lennard de Rijk

Add publish_location boolean property to Role model. This field indicates whether the User has agreed to publish his location. It is not supported yet in any logic, views or templates but we won't want to change models later so it's being added now. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Fixes an error occurring when editing a User as Developer when the ToS have been signed. By disabling the input of the field Django will not attempt to wrongly parse it as a DateTime instance. Patch by: Haoyu Bai Reviewed by: Lennard de Rijk

ReadOnlyInput widget now shows text instead of a greyed-out input box. Patch by: Haoyu Bai Reviewed by: Lennard de Rijk

Added status property to the user model. This is to accommodate the ability to exclude users from using the website. Note that since the access modules is currently undergoing some reconstruction changing the status will not actually effect the User yet. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed EOL and whitespace in org_app templates Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Update error message that shows when Google Maps API key is missing. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Implement the last step in the org application process. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Refactored applicant from club view to group view. This is to accommodate the OrgApplication Process. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Add Google Maps integration for Role profiles create/edit views. Now when editing/creating your Role Profile page Google Maps widget will show up at the bottom of the form as "Location" field. When you type in your Street, City, Country or State it will automatically update the map with the location based on your address. The zoom level depends on the address information you provided. So for example if you just select Country it will be different then when you select both Country and City. The longitude and latitude fields are hidden and are updated with the coordinates from the address you provided. Also if the map is not accurate enough you can adjust your location by dragging the red market, which will change your location and save new coordinates into hidden fields. This patch also includes some style fixes in soc.views.models.role module. Patch by: Mario Ferraro & Pawel Solyga Reviewed by: Pawel Solyga

Added org_app view and templates. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed club_app review template to use key.name. This will ensure that if we ever decide to change it to a scoped entity the review template will not break. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed some errors in the org_app model. The backup_admin property has been removed because it's present in the group_app model. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added org_app logic. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed group_app to use scope_logic in constructor. This is so org_app logic can use a scope_logic. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed getApplicantRedirect to use the key_name instead of just a link_id. This is to make it work with OrgApplication. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fix import sorting in soc.views.models.document module to comply with our style guide. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Rename 'Create a new document' links to 'Create a New Document', also rename 'Create a new Program' to 'Create a New Program' in soc.views.models modules. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Fix missing dots and blank lines to soc.logic modules. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Fix missing dot and wrong import sorting in soc.views.helper.access module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Style fixes in soc.models.document module (adding of missing whitespaces). Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Style fixes in soc.logic.models modules (basically removing of extra whitespaces). Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Changed the url regexpr for review and added 2 missing imports. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Refactored review and reviewoverview out of club_app.py This is to help accomodate the upcoming OrgApplication. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added view for mentors. This one is for real. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added two forgotten comments in rights.Checker Patch by: Sverre Rabbelier

Hook up the ACL system for documents. Org access checks are left unimplemented as they are not done yet. Patch by: Sverre Rabbelier

Final changes to the document model With a seperate set of read and write permissions it is possible to very accurately specify the ACL of the document. Patch by: Sverre Rabbelier

Added a rights module The purpose of this module is to translate from document prefix and status to a set of access checks. Patch by: Sverre Rabbelier

Replace name_on_certificates property with name_on_documents, since mentors, club admins, hosts and org admins don't get certificates it's better to name it 'Name on documents' which can indicate any kind of documents including awards certificates. Also don't show name_on_documents in public Role profiles, instead show user public name in that place. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Changed display_name to name_on_certificates in models/role.py. This is to make the intention of this property more clear as to display_name which would remind people of for instance nicknames or a replacement for their public name for this role. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added view and templates for mentors. Mentors can be invited or send a request to become a mentor for a specific org. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed a bug in soc/views/models/role.py. This bug allowed the creation of only invalid requests opposed to valid requests. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added a view and templates for the organization admin. This means that org admins can now be created/invited. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed two small errors. Removed an unnecessary edit_extra field in club.py. And made group.py call getForCurrentAccount where necessary. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added organization view and templates. Also added TODO's so it's clear what still needs to be done to make this work. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Removed obsolete _editPost and _editGet in soc/views/models/club.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Reverting a change from r1732 for reasons stated in soc/logic/models/group.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed scope_logic for requests to linkable_logic. This makes the scope_path for a requests of a variable length which is needed for reuse. Patch by: Sverre Rabbelier and Lennard de Rijk Reviewed by: to-be-reviewed

Removed workflow type as keyfield from program. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added mentor and org_admin logic. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Add an 'unread' style and add 'new document' link for user Patch by: Sverre Rabbelier

Fixed a string formatting bug in soc/views/models/role.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

When moving stuff please make sure that all your belongings are safely secured. Brown Paper Bag fix. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed a bug in role.py that made it call the wrong superclass. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Moved create_extra_dynafields from club_admin and member to role. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Cleanups in base.Logic * Use regular kwargs instead of **kwargs * Fold getKeyNameFromFields into _keyName * Fold getIfFields into getFromFieldsOr404 * Rename getKeyValues to getKeyValuesFromEntity * Rename getKeyFieldsFromDict to getKeyFieldsFromFields * Rename getFromFieldsOr404 to getFromKeyFieldsOr404 * Rename getKeyValues to getKeyValuesFromEntity Patch by: Sverre Rabbelier

Add checkIsProgramActive to the rights flushing Patch by: Sverre Rabbelier

Small changes in Mentor model (we don't inherit from Reviewer anymore since model inheritance is not supported in datastore). Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Add Organization Administrator model. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Remove not used Administrator model that is replaced by Host model. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

soc/views/models/club.py now uses getForCurrentAccount where necessary. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Edited the access check for show in site settings. Not everyone should see our keys :). And also moved the template to site folder and changed presence back to the way it should be. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added rights to soc/views/models/timeline.py. Only a developer or a host for the program this timeline is for can edit it now. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added status to program. Also added a new access_check and changed the program edit template to the basic one without edit timeline button. Changed the program menu to show more helpful links like Edit Timeline. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Flush sidebar when creating a new entity Patch by: Sverre Rabbelier

Update site/home.html to match the new document structure Patch by: Sverre Rabbelier

Added a Create a New Program link to the Program Owners's menu. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Flush sidebar when creating site entity Patch by: Sverre Rabbelier

Brown paper bag fix We can only add the create link if there is a site entity. Patch by: Sverre Rabbelier

Made presence document retrievel specify prefix Patch by: Sverre Rabbelier

Added a 'create new document' link to site Patch by: Sverre Rabbelier

Remove simplejson module from our repository since it's a duplicate of django.utils.simplejson. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Use django.utils.simplejson in soc.views.models.base pick method instead of our standalone simplejson module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Add a 'Create new document' link for clubs, sponsors and programs Patch by: Sverre Rabbelier

Added a getCreateDocumentRedirect Patch by: Sverre Rabbelier

Add access control to document model and view The access checks are not yet written, but at least the model is stable from now on. Also converted the document view to dynaform while at it. Patch by: Sverre Rabbelier

Factor out the getPattern logic from params This is to facilitate it's use by the document view later on. Patch by: Sverre Rabbelier

Made the /create/<scope> url conditional The 'no_create_with_scope' parameter can be used to disable it. Patch by: Sverre Rabbelier

Removed unused key_fields_prefix variable Patch by: Sverre Rabbelier

Moved is_featured property to Document Only Documents can be featured in the sidebar, as such it makes sense to have this property in the Document model. Patch by: Sverre Rabbelier

Added missing dot. Patch by: Sverre Rabbelier

Copy the default django patterns rather than modifying them This prevents an ever-growing list of urls in the case that getDjangoURLPatterns is called multiple times. Patch by: Sverre Rabbelier

Added a clean_scope_path to cleaning Patch by: Sverre Rabbelier

Fix the notification bar messages that show up when you click 'Save Changes' button. It only works on Edit views right now. Patch by: Madhusudan C.S Reviewed by: Pawel Solyga

^_^, fixed header in templates/soc/request/list/heading.html. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Renamed state to status where appropriate. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Requests can now not be created when you already have a similar request or already have the role the request is for. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Moved clean_club_app_link_id to cleaning. This method is now also used by the club create_form. Which means that you cannot create a new club with an already reserved link_id until the club application has been rejected. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed group_app logic to support scope_path. Moved link_id only as keyvalues to club_app. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added a cleaning method to club_app view. This ensures that you can't create a application for an already taken Link ID. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed status in group app model to state. Also changed it wherever needed to increase consistency. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed clean_link_id to be in a wrapper form as well. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Deleted soc/models/member.py since it's the equivalent of club_member. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

docstring fix in soc/models/student.py. Patch by: Haoyu Bai Reviewed by: Lennard de Rijk

Added agreed_to_tos_on field in user and role model. Also the user and user_self view no properly handle this new field. The ToS will be shown on-screen (not in a nice way) only if it is in effect and a user has not signed it yet. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Cleaned up overly enthousiastic comments From the styleguide: On the other hand, never describe the code. Assume the person reading the code knows Python (though not what you're trying to do) better than you do. Patch by: Sverre Rabbelier

Properly check if a program is active Also cleaned up checkIsHost, which got merge-mangled when refactoring the access module. Patch by: Sverre Rabbelier

Factor out the allowIfCheckPasses logic Keep allowDeveloper around as convenience method though. Patch by: Sverre Rabbelier

Fix EOL damage and add link to first row item for notifcations Patch by: Sverre Rabbelier

Added menu entries for a specific Sponsor Entity. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed