Increased bottom margin on comments for better grouping. Reviewed by: Lennard de Rijk

Changed the filter for getting a SurveyRecord for a ProjectSurvey ProjectSurveyRecords are characterized by the Survey and a Project entity. The user property is just there to state who last submitted the Survey.

Added tag v0-5-20090705p1 for changeset c7726e3ab173

Set new Melange version number to 0-5-20090705p1 in app.yaml.template.

Ensure that accessViolations for Survey menu items get captured. (Also ensure that you think before committing something you broke yourself :()

Added tag v0-5-20090705 for changeset 8f3a8e066111

Set new Melange version number to 0-5-20090705 in app.yaml.template.

Added Menu items for all three kinds of Surveys to the program menu. The menu items turn red when the user has not taken the Survey yet. Patch by: James Levy, Lennard de Rijk Reviewed by: to-be-reviewed

POST data always overwrites survey_record data when used to populate form. It also fixes validation errors on takeGet. Patch by: Daniel Diniz, Lennard de Rijk Reviewed by: to-be-reviewed

Fixes bug when option name contains double quotes.

Several style fixes due to code reviews.

Ensure that long questions and comments are stored as db.Text. This is done by adding the setCleaners methods which sets the appropriate cleaners for dynamic fields. Reviewed by: Lennard de Rijk

Style fix in access module.

Returned ProjectSurvey create to checkIsUser. The access protection is properly done by the form validator.

Added access checks for taking a Project(Grading)Survey.

Brown paper bag fix for using non-existing logic in ProjectSurvey views.

Fixed basic Survey access check. Also enabled this check for all relevant Views. However ProjectSurveys and subclasses still need an additional check. A stub for this has been added to the access module.

Fixed broken selection questions from refactoring SurveyForm. Reviewed by: Lennard de Rijk

Fixed showing the correct list of projects for taking a Grading Project Survey. Note that when a user is a mentor for a lot of Organizations the amount of subqueries might exceed the allowed amount. A TODO has been added to fix this issue. However this will hopefully not be a problem that pops up soon. Also some minor docstring addition to Project Survey view.

Refactored filter construction to _constructFilterForProjectSelection. This allows Grading Project Survey to overwrite this method and create its own filter.

Make sure that radio button questions validate correctly and allow only one choice. Reviewed by: Lennard de Rijk

Added Daniel Diniz and Zachary Voase to the AUTHORS file.

Added Daniel Diniz to authors for Grading Project Survey View.

Add a grade field to the Grading Project Survey form. This also takes care of validating and transforming the data into True(pass) or False(fail). GradingProjectSurveys are hereby working for developers. Reviewed by: Lennard de Rijk

Survey editing/taking Javascript and CSS fixes. This patch adds some cosmetic changes and functional fixes: - UI now removes all of the field content when a field is deleted, - CSS tweaks, and jQuery hack to specialize comment CSS, - fixed JS path in take.html. Reviewed by: Pawel Solyga (with some small changes)

Remove public role type from SURVEY_TAKING_ACCESS in Survey model.

try to fix the surveys-have-no-scope issue to-be-reviewed: also untested

addressed comments to previous version to-be-reviewed: still untested

return found entity for activity checks

survey access: stylefix and remove public role type

Style fixes in Survey helper.

Added _getSurveyTakeForm to the Survey view. Subclasses can overwrite this method to create their own form. ProjectGradingSurvey will likely be an example for this.

Only initialize a SurveyTakeForm in take instead of in takeGet and takePost. This will allow for other subclassed views to easily replace the form the view is using. Also small style fix in Survey helper.

Split SurveyForm into SurveyTakeForm and SurveyEditForm. This allows for a more cleaner implementation of the Form code. And this will make it easier to break free from the getFields method in the future. Also the getRoleSpecifcFields method and the this_user and project variables have been removed. They are deemed obsolete. Reviewed by: Lennard de Rijk

Do not call takeGet when SurveyForm ValidationError occurs. Problems occured when a SurveyRecord was specified in the SurveyForm. The SurveyRecord data reset the erroneous POST data. Further code reduction might be possible soonish.

Several stylefixes due to received reviews.

Style fixes in Access module.

Style fixes to the GradingProjectSurvey View module.

Sub_merge params for GradingProjectSurvey View.

Added rudimentary grade field to GradingProjectSurvey take View. Patch by: James Levy, Lennard de Rijk Reviewed by: to-be-reviewed

Ensure that the params from subclasses get merged properly with ProjectSurvey view.

Corrected the links to Grading Project Surveys in Program menu.

Added missing import to ProjectSurvey View.

Fix pick_multi only returning one answer as maximum. Reviewed by: Lennard de Rijk

Removed getSurveyResponseFromPost from Surveys helper. We will use the power of Django Forms instead of getting our own properties. This fits better into the rest of Melange which also uses this approach.

Renamed survey-edit-090627.js due to recent changes.

Form errors when taking a Survey now have the correct context.

Fixed Survey Form error giving 505. I failed when changing the system to work with collectCleanedFields.

Surveys can now have required questions and comments can be turned on/off. Storing comments is now working. However some issues arise when form errors occur, like missing context and the errors also trigger before a form has been submitted. Reviewed by: Lennard de Rijk

Added Survey From Field validation. Also added the COMMENT_PREFIX in Survey model to ensure that comments are stored in the same way everwhere. Reviewed by: Lennard de Rijk

Style fixes and a forgotten parameter in Survey(Record) logic. Reviewed by: Lennard de Rijk

Removed unnecessary variable in ProjectSurvey take method.

Overwrite _getSurveyRecordFor in ProjectSurvey view to take StudentProject into account.

Added _getSurveyRecordFor method to Survey View. This method is used by the Take view to get the right SurveyRecord for the current request. Subclassed Views that want to fetch their records in another way can override this method.

Added default Survey list templates for ProjectSurvey and GradingProjectSurvey.

Enable the ProjectSurvey and GradingProjectSurvey views in the core. Also add menu items to the program menu for easy access to these options. Reviewed by: Lennard de Rijk

Implemented taking ProjectSurveys. The user will first be served a list of all eligble StudentProjects for which the ProjectSurvey can be taken. After clicking on the list the key_name of the project is attached as a GET param and the code uses the normal take view with the hooks to let everything run smoothly. An extra access check method is required which checks if the Project mentioned in the GET param is a valid project for the current user. This check will run together with the isSurveyTakable checker.

Edit SurveyRecord model to not make use of different Survey property for each subclass. This does mean that a simple query needs to be constructed by hand whenever you want to query for every SurveyRecord for a specific Survey. However the naming is now the same over each SurveyRecord and it fits well into the rest of the design of Melange.

Made the CSV exporter for Survey not rely on the BackReferenceProperty in Survey.

Added getTakeProjectSurveyRedirect. This redirect is used when taking a ProjectSurvey.

Added the possibility to change the action of the form on the Survey take page.

Small style fix in Surveys helper.

Set required is True for StudentProject reference in ProjectSurveyRecord.

Removed obsolete if tag form take template.

Added hook methods to takeGet and takePost.

Fixed typo in title of Survey Take page.

Add a base implementation of takePost. Normal Surveys can now be taken, however comments are not stored yet.

Added getSurveyResponseFromPost method to Surveys Helper. This method will be used to read the POST dictionary from a request. And will transform it into the fields that need to be set in a SurveyRecord for the questions specified by the given Survey. A TODO has been added to handle the naming/handling of the comment fields.

Added updateOrCreateFromFields method to SurveyRecordLogic. The reading of the fields from the POST request will not happen in this Logic anymore.

Added base class logic for Expando based models.

Removed two obsolete/outdated methods in Survey Logic. The updateSurveyRecord can be found in the SurveyRecord logic.

Removed obsolote method call in Program View.

Clean up and other fixes for Survey modules. Reviewed by: Lennard de Rijk

Implemented the takeGet view for Surveys.

Fixed multiple typos in Survey tooltips strings.

Added skeleton for the take view and its template. Also fixed the sorting of imports of the Survey View.

Move getMenusForScope to the end of the View class. Adhering to our principle that we the methods we use for generating our menus can be usually found at the bottom of the View class.

Changed the Survey public view to give a preview of the Survey. Also changed the access rights for deleting a Survey because of the possible invalid references problem. Added two TODO's to the _public method. The first one involves enabling the SurveyForm to generate a form without passing along the Logic since it is only used to retrieve the Survey entity which we already have available. The second one involves a brief discussion about the getFields method's functionality and name.

Removed activate grade URL pattern from Survey View. The remaining methods will be ported over in a patch from Ajaksu.

Brown paper bag "without tea" morning typo fix in Survey View.

Style fix in Survey views helper.

Returned access checks in Survey View to the right state. This got bugged in James's commt.

Fixed too long line in Surveys helper.

Solved some merging problems and use the getRecordLogic where needed.

Reverted some changes in SurveyLogic. SurveyRecord logic is defined in its own module.

Use an existing logic for showing Survey Results.

Merge params from inheriting Survey views so functionality can be reused.

Add more flexibility to the Survey helper for use with the new Survey types. This includes using the new SurveyLogic methods from an earlier commit. And passing on the Logic from the view where necessary.

Added getRecordLogic method to SurveyLogic. This is used to retrieve the SurveyRecordLogic that belongs to a certain SurveyLogic.

Removed setting of the scope in the ProjectSurvey init. This is because it is not possible to query for another entity outside your entity group in the __init__ fucntion.

Added getSurveyForContent method to SurveyLogic. This method returns a Survey for a given content. The backreferenceproperty will not work because of inheritance.

Calling the correct super in Project and Grading Survey Logic.

merged upstream

Add paver script that will replace our current build.sh from scripts folder. Until I update the wiki to describe how this new paver build script works I'm leaving the old one in the repository. Reviewed by: Pawel Solyga

Add checkHasSurveyAccess access check To-be-reviewed, untested code

fixed critical errors related to survey subclassing and renaming of deadline and opening properties, and surveys in sidebar are now marked as such and have a red color if untaken

Removed survey_kind from Survey model. The inheritance structure should make this obsolete.

Set the correct base_model and scope_logic for extended Survey logic.

Added two missing imports to the Project and Grading Surveys views.

Added SurveyContentSchema to improve readability for the survey helper. Reviewed by: Lennard de Rijk

Added tag v0-5-20090629 for changeset 0dee663d6582

et new Melange version number to 0-5-20090629 in app.yaml.template.

Added skeleton view for ProjectSurvey and GradingProjectSurvey.

Prepared Survey access controls to deal with multiple logics. Also added a TODO to move a method to another view.

Extracted the ProjectSurvey and ProjectGradingSurvey records to a new module.

Removed unused import from Survey model.

Separated two survey types out of the main survey model. These models are ProjectSurvey and GradingProjectSurvey.

Seperated Logic for ProjectSurvey and GradingProject surveys. These changes also include their respective records.

Start on adding ProjectSurvey and GradingProjectSurvey. New classes still need to be made for logic and views so the appropriate methods can be overwritten. Reviewed by: Lennard de Rijk

Added .settings to hgignore. Eclipse IDE uses this map to store some settings. Since this is widely used I decided to add it to the ignore list.

Renamed opening to survey_start and deadline to survey_end. Symmetry seems to be both pleasing and helpful when understanding the code.

Put ResultsLogic in its own Logic module named survey_record.

Removed non-existing import in Survey Logic. James don't get ahead of yourself :D.

Added Survey menu items to the Program menu. Patch by: Daniel Diniz Reviewed by: Lennard de Rijk

Added Surveys to the sitemap. Patch by: Daniel Diniz Reviewed by: Lennard de Rijk

Added View for Surveys. Patch by: James Levy, Daniel Diniz Reviewed by: to-be-reviewed

Added redirect for use in Surveys. Also some minor style changes. Patch by: Daniel Diniz Reviewed by: Lennard de Rijk

Added Access checks for Surveys. Patch by: Daniel Diniz, James Levy Reviewed by: Lennard de Rijk

Added Survey Views Helper for rendering several widgets. Patch by: James Levy, Daniel Diniz, Lennard de Rijk Reviewed by: Lennard de Rijk

Added logic for Survey and SurveyRecord. The logic for the SurveyRecord will be seperated within the upcoming days. Patch by: James Levy, Daniel Diniz, Lennard de Rijk Reviewed by: Lennard de Rijk

Added SurveyRecordGroup for the use in evaluation surveys. Patch by: James Levy, Daniel Diniz Reviewed by: Lennard de Rijk

Added SurveyRecordModel. Lennard: On top of the orginial patch I've added several comments to the fields and two TODO's for further subclassing. Patch by: James Levy, Daniel Diniz, Lennard de Rijk Reviewed by: Lennard de Rijk

Added Survey and SurveyContent model. They are currently located in a single file this can be undone later on. Patch by: James Levy, Daniel Diniz, Lennard de Rijk Reviewed by: Lennard de Rijk

Fixed docstring in Document Logic.

Renamed css due to previous changes in previous commit.

Edited stylesheet for use in Surveys. Patch by: Daniel Diniz, James Levy Reviewed by: Mario Ferraro

Renamed JavaScript files in templates to match the correct files using prefixes.

Adding JS files for use in Surveys. Patch by: Daniel Diniz, James Levy Reviewed by: Mario Ferraro

Added templates considering Surveys. Patch by: Daniel Diniz, James Levy Reviewed by: Lennard de Rijk

Renamed jquery.growfield.js to jquery-growfield.js. Reviewed by: Lennard de Rijk

Patch that adds the JS and CSS files for surveys. The only update is in app/jquery/jquery-ui.core.js, from a non-release (added by Paweł for the date picker) to a slightly updated released version. Reviewed by: Lennard de Rijk, Mario Ferraro Patch by: Daniel Diniz, James Levy

Patch that touches 'upstream' templates, for use in surveys. Consists out of three changes. 1 - Move the </head> placement in base.hmtl to after the closing of scripts_block, so templates that extend base.html can add scripts to the <head>. 2 - Add tooltips for checkboxes inside fieldsets. 3 - Comment out an empty table row in templatetags/_as_table.html, which probably has an arcane reason to stay empty :) Reviewed by: Lennard de Rijk, Pawel Solyga Patch by: Daniel Diniz, James Levy

Fixes an issue where the organization home page would throw a 505 when no projects where accepted. This only happens after the project announced deadline because only then would the project list be constructed.

Added tag v0-5-20090621 for changeset 96ff51144dca

Set new Melange version number to 0-5-20090621 in app.yaml.template

jQuery Spin plugin updated to version 1.1.1 Former version had a bug if max was not specified

Use build-in django 1.0.x on deployed version of Melange. Using SDK (Development server) right now we are still using django.zip when running from build folder and django folder when running from app folder. django.zip file is still uploaded when deploying the app but it's not used. We might totally get rid of django folder and django.zip soon (discussion needed).

Update GAE to 1.2.3 in thirdparty folder.

Added tag v0-5-20090608 for changeset 19e9fdde919e

Set new Melange version number to 0-5-20090604 in app.yaml.template

Temporary fix for Issue 636 by turning off the caching of the page's entities. This also means that pagination is turned back on because querying all 1000 projects every time will take too long.

fix copy/paste fail in homepage caching

Added group attribute to each GHOPProgram property so it is grouped on edit/create forms. Added 3 new groups, "Contest Rules" group, "Prize Information" group and "Task Settings" group to organize the properties in a useful manner on the edit/create forms. Reviewed by: Lennard de Rijk

Changed GHOP module imports to be consistent with rest of Melange code. The imports used the from <module-path> import <module> as <local_module_name> syntax. These kinds of imports are changed to import <module_path.module_name> syntax to be consistent with the Melange code base. Reviewed by: Lennard de Rijk

Changed the property that holds the minimum age required for Students to participate in a GHOP based program. Added a new property student_min_age_as_of to hold the DateTime from when the minimum age should be reached. Changed student_min_age property to now store the student minimum age as an integer. This all feel more user friendly then letting the program admin calculate the required DateTime. Storing the two properties is then still needed in this case since information might be lost otherwise when the program admin brings up the edit view. Reviewed by: Lennard de Rijk

Remove now unneeded getCallback from ghop.__init__

Remove getCallback indirection in modules Instead, assume that the imported module contains the Callback class that was previously returned by getCallback. This is done to prevent a circular import (caused by the __init__ importing a submodule).

Removed authors from 'empty' __init__.py files.

Add HTTP_HOST to environ variables mocked. Also add license headers to run.py.

Added logic for every GHOP specific model. Defined logic for every model defined for GHOP. These logics do nothing special now. They are just inherited from their parent classes. Necessary GHOP specific logic will be added later as necessary. Reviewed by: Lennard de Rijk

Added licenses and fixed the authors of __init__.py for the GHOP module.

Changed imports in models to comply with recent GHOP code move. Reviewed by: Lennard de Rijk

Removed unused import.

Moved the GHOP module into the modules package. This also includes moving the templates and content into their respective place inside the Soc folder. This is to avoid adding every folder to the app.yaml file. Patch by: Madhusudan C.S. and Lennard de Rijk Reviewed by: Lennard de Rijk

also rename batch_size in cron.py

Added tag v0-5-20090604 for changeset 1dc8d7f9458e

Set new Melange version number to 0-5-20090604 in app.yaml.template

Display caught errors on the page itself Similar to the previous commit, show directly rather than redirect.

Make the maintenance page a hardcoded response Show the maintenance message on the requested page, instead of redirecting to a specific url which then displays a page with the maintenance notice.

Merge with Pawel's tip.

Partial fix for displaying mentors and students on Organization home page. Connections between mentors and students are not yet displayed and also there is some probably with displaying markers in Safari for some reason, everything works fine in FF.

Comment out GMaps support in Organization home page template.

Small indentation fix.

Add missing if statement in organization list row template.

Fixed an issue where some access checks would fail due to missing arguments. This happens when an org document is being checked for write access when trying to show the edit link on the document's show page.

Introduced 'module_package' key in params dict to support modules in melange

Now showing link to edit the home page document on the home page. This will only show up if you have the right to edit the document. Update issue 271 Now also working for home pages.

Temporary turn off GMaps support on Organization home pages until it's fixed. Currently not all markers and polyline connections between students and mentors show up.

Added link to edit the Document on the Document's public page. This link will only show if the user is allowed to edit the document. Fixes issue 271. Update issue 271 Owner: ljvderijk

Rename soc-090421.css and update base.html template.

Clarified docstring for document read/write access check.

Small changes in #extra_left, #extra_right tags in css file. Google Maps and Student Project List on Organization home page now doesn't lay on page footer if too high.

Added a link to the website where the user has registered to the welcome email. Fixes Issue 630.

Add taggable-mixin and gviz to build script.

Extend taggable-mixin to support different Tag models. Usage is pretty simple. Tag model is default in Taggable constructor but you can call it with different model like GHOPTaskType that inherits from Tag model. Both Taggable and Tag models have been updated and they don't use hardcoded Tag model anymore and instead use cls of class methods or self.__class__. In case of Taggable it's self.__tag_model.

Make taggable-mixin tests working by updating GAE path.

Merge with Pawel's head.

Add google-visualization-python project to Melange repository. This python module will be used with our Statistics module to leverage Google Visualization API and python as a data source.

Removed unecessary use of %.

Changed University Student expected graduation date to be a dynamic dropdown. The range of choices is dynamically made by taking the current_year-1 to the current_year+20. It does not start at the current year because a Student might need to change it's profile during a Program that runs across multiple years.

Added GHOP specific Mentor and Org Admin Models.

Add missing __init__.py file in taggable-mixin module.

Add taggable-mixin to Melange repository.

Add some missing docstrings to Seeder classes in seed_db.py

Style fixes and pylint: disable-msg comments in different modules.

Add pylint: disable-msg= where needed in Melange modules.

Rename bathSize variable to batch_size in soc.logic.models.base module.

Style fixes and wrong function call fix in soc.views.helper.lists module.

Remove unused variable from soc.view.models.cron module.

Some more pylint fixes in different Melange modules.

Style and pylint fixes in Melange modules.

Style and variable names fixes in soc.modules.core module.

Remove unused imports in Melange modules.

Remove unused imports from main.py.

Some small fixes to unique_user_id_adder module.

Fixed typo in org_prize_assignment model.

remove accidental head

Fixed the notification list to show a properly formatted date and time column.

Link id and key name fixes for Organization And OrgApplication in seed_db.

Add Organization Application seeding. Fix the seeding in seed_db so that a consistent linkid for organization applications is used. Use the last entry in the split array instead of the 2nd.

Make user_id property in User model not required.

Merged with Sverre

Fixed model name and comment typo's in task model. Also changed the corresponding reference properties.

Added several models related to the GHOP workflow. These models will form the base of the GHOP infrastructure together with the already commited task model. Reviewed by: Lennard de Rijk

Do not die on NeedIndexErrors

Add helper functions, model update and jobs for unique user ids.

Add missing django.template import to shell.py.

Revert "Add a supplemantal block to the edit form" This reverts commit f50455c4cdcb.

Revert "Add an EditForm id to the edit form" This reverts commit f835e39b4dbc.

Add a supplemantal block to the edit form

Add an EditForm id to the edit form

Remove executable bit from datatimepicker

Added GHOP Task model. Reviewed by: Lennard de Rijk

Added __init__.py to ghop folder.

Merge with Sverre's recent module architecture commit.

Add web based python shell to Melange. It is accessible via http://host/admin/shell url and requires developer rights. Shell project is part of google-app-engine-samples. This commit moves django configuration from main.py to separate gae_django.py module. Shell project has been modified in order to work correctly with django 1.0+. Build script has been updated and includes shell folder and gae_django.py file. http://code.google.com/p/google-app-engine-samples/source/browse/trunk/shell/

Comment style fix in soc.views.models.organization module.

First step in the module design The new module design allows modules to be registered by adding them to settings.MODULES. Currently modules cannot do a lot (they can register with the sidebar and the sitemap), but the structure is in place.

Add comment regarding Student Project sorting on Organization home page.

Add sorting of student projects on organization home page. List of student projects on organization home page is now sorted in alphabetical order by student name. Fixes issue 613.

Now clicking cancel button returns user to previous page. Fixes issue 569. If you don't want that behaviour you can define cancel_redirect and user will be redirected to given url on "Cancel" button click instead of redirecting to previous page. Patch by: Daniel Hans & Pawel Solyga

Add comment to clean_html_content function and update __authors__.

Invoke pylint from build script. Using --skip-pylint build script command line parameter you can skip pylint invocation.

Replace usage of feedparser for sanitizing html with new HtmlSanitizer module. HtmlSanitizer prevents from XSS attacks (Fixes issue 606).

Add htmlsanitizer folder to build script.

Add missing __init__.py file to htmlsanitizer folder.

Add HtmlSanitizer python module to Melange repository.

Add BeautifulSoup Python HTML/XML parser to Melange repository.

Add acceptedStudentsCSVExport function to stats.py script. This funtion is used to generate CSV with all accepted students. It still needs some work and I left TODOs there. I also added helper function for saving data to CSV, which can be reused for other kinds of reports.

Remove accidentaly committed file.

Merge with Sverre's accidental head.

Do not rely on notifiction module being imported This has worked so far mostly by accident, but it turned out to be brittle while writing tests. This makes sure that the notification module is always imported before use.

Style fixes in test_functional.py.

Add some example function tests that use gaeftest

Use key_name instead of link_id Some entities do not have a link_id, but all entities are guaranteed to have a key_name (or an id).

Use key_name instead of link_id Some entities do not have a link_id, but all entities are guaranteed to have a key_name (or an id).

Include required antl3 library and check if datastore is available The datastore is checked for availability before requesting it to be cleared. This is because gaeftest uses its own method for ensuring no leakage of data by providing a temporary file as the backend. Reviewed by: Sverre Rabbelier

Use offset_linkid instead of offset to scan >1000 entities. this is a first-cut. It works in all the ways I could make earlier versions fail. It passes link_id as URL parameters. It also has a new class LinkCreator which makes the main body of getListContents even easier to write. I wasn't sure if link_id's could have non alphanumeric characters; if so, they need to be URL encoded/decoded. I also need to go and remove any mention of raw offsets now, because we don't use them. I believe I've talked about this approach with a few of you and it sounded reasonable. Feel free to roll-back/fix/amend/comment-for-me-to-fix. This is my first big-logic-change to Melange. Patch by: Dan Bentley

Revert not finished 1000 limitation fix commit (ef7222d484). We are going to put this into separate branch until it's finished.

Add vcs-load-dirs project to thirdparty directory. vcs-load-dirs project contains load-dir scripts for different version control sysystems including git, hg, darcs, bazaar. More information about the project: http://software.complete.org/software/wiki/vcs-load-dirs/ http://software.complete.org/static/vcs-load-dirs/doc//hg_load_dirs.1.html

Add .DS_Store Mac OS X specific files to .hgignore.

Update Google App Engine to 1.2.2 in thirdparty folder.

added foo

Fix ordering of names in AUTHORS file.

Add .gitignore to .hgignore We're all ignoring one another, pretending the other doesn't exist at all, how rude!

Add .git to the .hgignore file

Remove __init__.py from project root as well This is in line with the earlier patch to remove the __init__.py file from the app/ directory. --- 0 files changed, 0 insertions(+), 0 deletions(-) delete mode 100644 __init__.py

[PATCH] Remove __init__.py from app, as app is not a module From 6916391964ed3b48021351d3a9ea7a7bc836a373 Mon Sep 17 00:00:00 2001 Date: Sat, 9 May 2009 15:19:04 +0200 --- scripts/build.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) delete mode 100644 app/__init__.py

Renamed duplicate slots because of recent changes.

Fixes Issue 625 where the Duplicate calculation would hang if no assigned slots where available. Reviewed by: Lennard de Rijk

Fixed Issue 627 where multiple Purr boxes would show when using calendar widget.

Add Marcelo to AUTHORS file and fix typo

Add coverage support to the test suite This requires nose 0.11 to run.

Added coverage output files to .hgignore Patch by: Sverre Rabbelier

Fixed typo in docstring as to comments on r3012 (svn repo). Also now importing logic and using keyword arguments as to comply with the codebase standards Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Replace BeautyTips tooltips with purr info box for all form fields with help text. Patch by: Mario Ferraro Reviewed by: Pawel Solyga

Use python2.5 in our unit tests Patch by: Sverre Rabbelier

Ignore .project and .pydevproject files Patch by: Sverre Rabbelier

Add full list of accepted students Patch by: Daniel Hans

Ignore backup files (*~) Patch by: Sverre Rabbelier

Ignore zip files and build directory Patch by: Sverre Rabbelier

Merged revert

Backed out changeset 571f2de51138 Test commit that was not meant to be committed. Patch by: Sverre Rabbelier

Make dev_appserver error out when python version >2.5 is used Patch by: Sverre Rabbelier

Added file 'foo.txt'

Fixed StudentProposal apply view that broke during split of Create/Edit view. Also included whitespace fixes. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fix Issue 389 (Clicking list entry will not open new tab/window). Patch by: Daniel Hans Reviewed by: Pawel Solyga

Fix too long line in soc.view.models.organization module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Remove E1103 and E1101 errors from ignore list in pylintrc file. We are going to use "# pylint disable-msg=E1103" comments in the source file itself to ignore false-positives. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Style fixes in app.soc.views.models.student_project module. Too long line and missing whitespace. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Show all Co-Mentors on the Student Project public page. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed Additional Mentors to Co-Mentors in the manage view. Due to a conversation with Pawel. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added functionality to set additional mentors for a Student Project. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed missing value in context when a form with a different name then form was used. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fix broken tests by renaming default app id from "your_app_id" to "test-app-run". This fix is required due to changes in GAE 1.2.1. Patch by: Pawel Solyga

Add .hgignore to repository and ignore all .pyc files and app.yaml file. Patch by: Pawel Solyga

Add getStudentsProjects to context in stats.py script. Patch by: Pawel Solyga

Load /Users/solydzajs/Desktop/google_appengine into trunk/thirdparty/google_appengine.

Renamed .css file due to recent changes. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added map of accepted student proposals to mentors to the org home page. Patch by: Madhusudan C.S Reviewed by: Lennard de Rijk

Fix missing dot in stats.py docstring. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Fixing the build now that emails have been tested. Patch by: Augie Fackler

Intentionally breaking the build so that we can verify BuildBot will send email. Patch by: Augie Fackler

Fixing the build now that emails have been tested. Patch by: Augie Fackler

Intentionally breaking the build so that we can verify BuildBot will send email. Patch by: Augie Fackler

Added reviveJobs and deidleJobs to stats.py These can be used to mark jobs as 'waiting' (meaning they will be executed again). Patch by: Sverre Rabbelier

Email address is actually private, not public, make this obvios Patch by: Sverre Rabbelier

Set the last_modified_on date to last change Patch by: Sverre Rabbelier

Set batch size to 10 Patch by: Sverre Rabbelier

Added index needed to convert proposals Patch by: Sverre Rabbelier

Some minor style fixes. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed the accepted and rejected list to redirect to the review page in ListProposals view. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Allowing student project review page to be viewed in read-only mode after the deadline has passed. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed typo in access module naming. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Set new Melange version number to 0-5-20090420 in app.yaml.template. Patch by: Pawel Solyga

Some minor style fixes. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added listing of accepted and rejected proposals to the organization proposal page. The link will redirect to the public page where comments can still be placed. Patch by: Madhusudan.C.S Reviewed by: Lennard de Rijk

Added org_home_gmap function to the map JS for displaying the mentor-student map. Patch by: Madhusudan.C.S and Merio Ferraro Reviewed by: Lennard de Rijk

Added mentor-marker.png to content\images. This is for use on the organization home pages having the map displayed. Patch by: Madhusudan.C.S Reviewed by: Lennard de Rijk

Renamed map JS to facilitate upcoming changes. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added the gathering of data required to display a map on the org home page. Patch by: Madhusudan.C.S Reviewed by: Lennard de Rijk

Added ccTld property to role to retrieve the ccTld of the country of residence for a specific role entity. Patch by: Madhusudan.C.S Reviewed by: Lennard de Rijk

Added dictionary mapping country names to their CCTLD in countries model. Patch by: Madhusudan.C.S Reviewed by: Lennard de Rijk

Don't run in a transaction if not needed Patch by: Sverre Rabbelier

Tweak the 'load balancing' algorithm In order to reduce contention we randomly skipped jobs, but this caused many jobs to end up stopping early. Now instead we keep on going until we time out (also increased the chance of doing work). Patch by: Sverre Rabbelier

Added deleteEntities methods to stats.py Patch by: Sverre Rabbelier

Fixed typo in cron.job module's timeOutJob docstring. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Use status codes in job.py The previous behavior of being able go do 'if not handler.handle' is still valid as the status code for 'timed out' is 0. Patch by: Sverre Rabbelier

getDefaultMailSender now properly handles users who are logged in but not registered. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Allow anyone to see student projects The required rights['show'] exception was already made, but the any_access check was preventing it from being effictive. Patch by: Sverre Rabbelier

Changed the type of Error occurring when no valid sender could be found to a FatalJobError in student_proposal_mailer. This means that the job will be immediately aborted. This patch is due to comments on r3000 by SRabbelier. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Students can not list their own projects before the accepted students announced deadline. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Student Proposal Mailer is now sending out real emails. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed a comment typo and possible bug in mail_dispatcher. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added email templates for accepted and rejected students in a GSoC like program. These templates are specifically for GSoC2009 as per request in Issue 379. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Major brown paper bag fix Filter was set to empty dict while it was passed in as a possibly empty param. Patch by: Sverre Rabbelier

Add a startSpam method to stats This method creates the job responsible for sending out emails to students. Patch by: Sverre Rabbelier

Add job to the index Patch by: Sverre Rabbelier

Add a random chance to ignore a job to reduce contention This should probably be solved better (perhaps with a binary exponential backoff). Patch by: Sverre Rabbelier

Do not fetch all jobs with each poke Patch by: Sverre Rabbelier

Add entityIterator to base Logic Patch by: Sverre Rabbelier

Store how many times a job has timed out and abort if needed Patch by: Sverre Rabblier

Wrong usage of twoline_table_row caused weird layout in project Patch by: Sverre Rabbelier

Add cron.yaml to the build script Patch by: Sverre Rabbelier, Lennard de Rijk

Instead of text_data use key_data property to check for uniqueness. Brown paper bag fix, querying for TextProperty is not smart ^_^. Patch by: Lennard de Rijk, Sverre Rabbelier Reviewed by: to-be-reviewed

Style fix in Job model. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Hook up the Student Proposal Mailer in the cron/jobs module. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added Student Proposal Mailer module for mailing students who are accepted/rejected into the program. TODO has been added to actually sent out the emails. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Various improvements to convertProposals It should now be ready to convert proposals to projects and reject all proposals that were not accepted. Patch by: Sverre Rabbelier

Add a silent option to updateOrCreateFromFields Patch by: Sverre Rabbelier

Fixed wrong import for list proposals view. This seems to be working in the p3 release though. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed typo and added myself to authors in the cron/job module. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Add a script to convert proposals. Patch by: Sverre Rabbelier

Added FatalJobError to the cron/job module. This Error will lead to abortion of the raising job. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed typo in documentation of the Job Model. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed the response message in the cron poke view. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Remove debug url too This should have been part of the previous commit. Patch by: Sverre Rabbelier

Remove testing method and update docstring for cron system Patch by: Sverre Rabbelier

Removed unneeded imports and variables Patch by: Sverre Rabbelier

Add cron, the core of the job system Patch by: Sverre Rabbelier

Add priority groups and jobs to the sitemap Also add an entry in the Site menu to list them. Patch by: Sverre Rabbelier

Add jobs (model, logic, and view) Jobs are the core of the Job system, allowing distributed processing of taks in an interuptable manner. Patch by: Sverre Rabbelier

Add priority groups (model, logic, and view) Priority groups will be a key part of the Job system, allowing the site admin to give a higher priority to certain job types on the fly. Patch by: Sverre Rabbelier

The listing of accepted projects on the Organization's homepage is now timeline dependent. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

White space fix in list_info module. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fix user_self calling editGet with a wrong parameter Also fix wrong call to collectCleanedFields and stray seed argument in user_self. Patch by: Sverre Rabbelier, Lennard de Rijk

Split edit and create into different methods This makes removes unneeded responsibility from the edit view and makes it possible to more tightly restrict the usage of the edit and create views to only creating/editing. Patch by: Sverre Rabbelier

Add support for ID based entities This allows entities that do not have a key name to be created and edited without requiring the presence of a key_name. Patch by: Sverre Rabbelier

Use proposal key instead of raw proposal Patch by: Sverre Rabbelier, Lennard de Rijk

Show in green the proposals that would be accepted Patch by: Sverre Rabbelier, Lennard de Rijk

Add proper generation of Student entities and StudentProposal entities to seed_db module. Add link for generating 200 Students to seed_db.html template. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Rename that should have been part of r2953. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Renamed stepsize to step_size in Student Proposal Logic. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Moved the code to retrieve all Proposal which should be accepted for one Organization to the Proposal Logic module. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Style fixes in soc.views.helper.lists module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Style fixes in soc.views.models.organization module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Fix too long line in soc.views.models.program module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Comment out unused variables in soc.views.models.base module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Fix too long line in soc.views.helper.templatetags.forms_helpers module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Proposal CSV export for students. Patch by: Matthew Wilkes Reviewed by: Pawel Solyga

Readability fix in base logic Patch by: Sverre Rabbelier

Remove redundant if check site_logic.getSingleton() is guaranteed to return an entity. Patch by: Sverre Rabbelier

Comment out unused variables in soc.logic.allocations module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Fix too long line in soc.cache.logic module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Add missing responses import and replace usage of helper.responses with just responses in soc.views.models.student module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Fix too long line and redefining variable 'review' from outer scope in soc.views.models.student_proposal module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Step 2 of moving to new seeding model. Create Seeder class, which abstracts some seeding. Move user to Seeder class, and make new OrganizationSeeder class. If people like this, I'll finish the rest soon. Patch by: Dan Bentley

Added additional_mentors property to StudentProject. As per request by Issue 588. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Whitespace fix in sponsor model. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Place the getSingleton call in view decorator in the try This way timeouts on the getSingleton() call are also catched. Patch by: Sverre Rabbelier

Fix a bug in duplicate detection This is caused by AppEngine's inability to sort a query when the inequality or IN operator is used. See also [0]. [0] http://code.google.com/p/googleappengine/issues/detail?id=1100 Patch by: Sverre Rabbelier and Lennard de Rijk

Undid superfluas replacement of .name() with .name_or_id() Patch by: Sverre Rabbelier

Fixes access check for manage view. Added forgotten IsMyEntity check and fixed a bug introduced by a rename in r2816. Addresses Issue 584. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Do not rely on dicts.merge to change target Also make dicts.merge actually not touch target. This is much cleaner than modifying in place, especially since we assign the result of the dicts.merge call to target most of the time anyway. Patch by: Sverre Rabbelier

Use key().id_or_name() instead of key().name() These two cases were introduced after the previous refactoring was done and did not follow the new behavior. Patch by: Sverre Rabbelier

Fix a bug in seed_db Using %(num)d with an int as argument doesn't work. Patch by: Sverre Rabbelier

Added a warning message to alert the user that reviews are not editable. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added overview of private reviews to the Student Proposal review page. Addresses Issue 496. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Load /Users/solydzajs/Downloads/google_appengine into trunk/thirdparty/google_appengine.

Do not rely on a backup_admin being set Patch by: Sverre Rabbelier

Send out notifications and emails to admin and backup admin Patch by: Sverre Rabbelier

Allow the backup_admin to fill in the org application Patch by: Sverre Rabbelier

Use offset_linkid instead of offset to scan >1000 entities. this is a first-cut. It works in all the ways I could make earlier versions fail. It passes link_id as URL parameters. It also has a new class LinkCreator which makes the main body of getListContents even easier to write. I wasn't sure if link_id's could have non alphanumeric characters; if so, they need to be URL encoded/decoded. I also need to go and remove any mention of raw offsets now, because we don't use them. I believe I've talked about this approach with a few of you and it sounded reasonable. Feel free to roll-back/fix/amend/comment-for-me-to-fix. This is my first big-logic-change to Melange. Patch by: Dan Bentley

Respond to comments on r2769. Patch by: Dan Bentley

Last step of refactoring before adding support for > 1000 entities. Make helper functions. One extracts list parameters. One creates links more simply. This is cleaning up the large function body so I can move stuff around more radically. Patch by: Dan Bentley

Add (better) help_text to publish_location and school_name Patch by: Sverre Rabbelier

Brown paper bag fix Can't call .key() if there is no entity. Patch by: Sverre Rabbelier

Added Joel Sherrill to the AUTHORS file Patch by: Sverre Rabbelier

Lower ASCII fix

Remove getKeySuffix and it's usage We can use .key().id_or_name() everywhere now. Patch by: Sverre Rabbelier

Use key().id_or_name() instead of key().name() This is to allow for the usage of auto-id's. Patch by: Sverre Rabbelier

Use key.id_or_name in templates rather than key.name This is to allow for usage of auto-id's. Patch by: Sverre Rabbelier

Indentation fixes. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Indentation fixes. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added two menu items to the program menu. The first addition is a link to redirect to the Host's view for showing duplicates. The second addition is a link for Students to an overview of all their projects in the current program. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Removed obsolete white line in soc/models/views/models/organization.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added listing of Student Projects for Students themselves. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added three new redirect methods. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Brown paper bag fix for Student Project Manage and Edit access check. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Style fix in function names in stats.py Patch by: Sverre Rabbelier

When ranking, put them at or above the given rank Patch by: Sverre Rabbelier

Remove slots_allocation from program view Patch by: Sverre Rabbelier

Make it possible to save any value with saveValues Patch by: Sverre Rabbelier

Allow loading a previously saved slot allocation Patch by: Sverre Rabbelier

Added Manage Student Projects item to the organization menu. Only visible after the accepted students deadline has passed and the current user is an org admin. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed typo in checkStudentProjectHasStatus docstring. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Removed TODO that has been completed in r2876. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fix bug exposed in previous commit Patch by: Sverre Rabbelier

Add a test case to demonstrate a bug in the allocator Patch by: Sverre Rabbelier

Set new Melange version number to 0-5-20090410 in app.yaml.template. Patch by: Pawel Solyga

Add a new allocation algorithm and use it Patch by: Sverre Rabbelier

Change iterative to algorithm in slot allocator Also store the slots in program model instead of in each org. Patch by: Sverre Rabbelier

Store min and max slots in the program model Also add a field to store the current allocation. Patch by: Sverre Rabbelier

If nothing is assigned, return no assignments Before the popularity was returned instead. Patch by: Sverre Rabbelier

Add a submit method and button to slots view Patch by: Sverre Rabbelier

Make "Private Comment" first in the selection box on Student Proposal review page. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Add auto-completion for mentor field Patch by: Kai Blin

Make mentor pickable Patch by: Kai Blin

Make it possible to specify the key_order for pick Patch by: Kai Blin

Add a temporary hack to allow filtering on org.key().name() Patch by: Kai Blin

Drop the 'adjustement' part of slots allocation Also cap the max slots at slots_desired (and name it 'max' rather than 'mentors', which is a more accurate name anyway). Patch by: Sverre Rabbelier

Use slots allocated instead of adjustment in slots view Patch by: Sverre Rabbelier

Use the new self._getAcceptedOrgsList in slots view Patch by: Sverre Rabbelier

Factor out _getAcceptedOrgsList from acceptedOrgs Patch by: Sverre Rabbelier

Public page for StudentProjects now displays public info. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added public info as TinyMCE to the edit pages. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added public_info property to StudentProject model. This can be used to further elaborate about your project on it's public page. Also fixed some style and textual issues. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Student Project public page now shows feed entries. Patch by: Madhusudan C.S Reviewed by: Lennard de Rijk

Added feed_url to StudentProject. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added list of projects to the organization home page. Only projects that have not failed will be shown here. The list will link to each project public page which will contain the necessary info about the project. Addresses part of Issue 491. Patch by: Madhusudan C.S Reviewed by: Lennard de Rijk

Changed StudentProposal list to show the amount of pending mentors if none have been assigned. Addresses Issue 551. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Brown paper bag fix Patch by: Sverre Rabbelier

Set new Melange version number to 0-5-20090407 in app.yaml.template. Patch by: Pawel Solyga

Add missing imports, remove unsused imports, fix too long lines and some other style fixes in soc.views.models.student_project module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Add pylint: disable-msg=W0706 to soc.views.helper.access module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Major update to the views concerning StudentProjects. Organization admins can now reassign a Mentor for each of their active (meaning student has not failed or finished) projects. To facilitate this an overview has been added for the Organization Admins in which they can choose which Project to edit. Students can now edit the public information that is used in their projects. Several TODO's have been added to make it easier to navigate to these pages. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added new redirect method to be used for StudentProjects. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added two new templates for use in StudentProject views. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added 2 new access checks to deal with StudentProjects. In preparation for the view updates regarding StudentProject. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Student Project listing now includes mentor column. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Change the dropdown menu to state Comment Visible to Student. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Only show mentor name in the detailed list. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Properly handle exports when there are multiple lists If there are multiple lists whose index does not match their position in the contents, things weren't handled properly. Patch by: Sverre Rabbelier

Make slots view available to hosts Patch by: Sverre Rabbelier

Use the new nr_applications and nr_mentors This saves _a lot_ of computing time, making it possible to use the slot allocation view when there are a significant number of orgs. Patch by: Sverre Rabbelier

Add the amount of proposals and mentors to slots view Patch by: Sverre Rabbelier

Added Matthew Wilkes to the AUTHORS file Patch by: Sverre Rabbelier

Added key_order to student proposal to enable csv export We need to add it to organization.py rather than to student_proposal because otherwise students could see the score and status of their proposals by using the csv export functionality. Patch by: "Matthew Wilkes" <matthew@matthewwilkes.co.uk> Reviewed by: Sverre Rabbelier

Fixed wrong usage of twoline_field in proposal view The proposal view currently uses twoline_field to show the abstract and contents of a proposal, which causes unbalanced tables and most data shoved to the far right of the screen. Patch by: "Matthew Wilkes" <matthew@matthewwilkes.co.uk> Reviewed by: Sverre Rabbelier

Fixed bug introduced by fixing a pylint error Here first was very much intentionally set to None, as later on we check if it is none in an 'first if first else exception' statement. Patch by: Sverre Rabbelier

Added name column to all role lists. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added Mentor name column to StudentProposals list. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fix too long line in soc.views.models.student_proposal module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Added simple listing (no score, rank) for Student Proposals you are a mentor for. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed label and help_text for public review button on studentproposal review page. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Replace current favicon with the cleaned up one (smudges). Patch by: ajatsu Reviewed by: Pawel Solyga

Allow students to see and comment on withdrawn and ineligible proposals, hide withdraw button for those proposals. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Indention fix in soc.views.models.organization module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

When Student withdrew a proposal a public comment "Student withdrew proposal." is posted. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Make "Mark as Ineligible" reversable and make this feature available for mentors too. Now also with every click on "Mark as Ineligible" or "Mark as Eligible" button a private comment is posted with message "Marked Student Proposal as Ineligible/Eligible" which will help keep track of the changes made by mentors/org admins. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Add a script to subscribe someone to all updates Patch by: Sverre Rabbelier

Add the entities to the context too This makes it easier to quickly get specific entities from the datastore. Patch by: Sverre Rabbelier

Fix posting public comments as private in student proposals review.html template. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Brown paper bag fix, sort by last name in AUTHORS Patch by: Sverre Rabbelier

Added Dmitri to the AUTHORS file CLA signed with "Igor Gasowski for Dmitri Gaskin" since Dmitri is a minor (Igor Gasowski is his father). Patch by: Sverre Rabbelier

Use different colors for public/private comment widget Patch by: Dmitri Gaskin <dmitrig01@gmail.com>

Fixed a missing variable declaration This caused /org_app/list to be broken. Patch by: Sverre Rabbelier

Disable E1002 pylint error in soc.views.helper.dynaform module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Fixed a 'stylefix' in DynaField that wasn't a style issue The word 'base' was not chosen arbitarily but is a variable name, by changing it to object DynaFields were no longer a subclass of Field, so they were not included anymore. Patch by: Sverre Rabbelier

Fix wrong usage of helper requests module in soc.views.models.base after recent unused imports cleanup. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Also show 'List my student proposals' after signup closes Patch by: Sverre Rabbelier

Minor tweaks to orgStats Patch by: Sverre Rabbelier

Fix calling of super class __init__ method in out_of_band Error class (wrong number of parameters). Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Style fixes, add missing docstring, fix some wrong calls to super classes and removal of unused imports in soc.views.helper. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Style fixes and removal of unused imports in soc.views.models. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Call super class in __init__ in soc.views.out_of_band module Error class. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Fix too long lines, style and remove unused imports in soc.models modules. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Style fixes and removal of unused imports in soc.logic modules. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Style fixes and removal of unused imports in soc.logic.models modules. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Disable some messages in pylintrc and disable cyclic imports check in silent mode of do_pylint.sh. Patch by: Pawel Solyga Reviewed by: to-be-reviewed