Sverre Rabbelier <srabbelier@gmail.com> [Sat, 28 Feb 2009 14:29:23 +0000] rev 1561
Replaced 'Melange' with site_name where appropriate
Also fixed EOL damage in django templates.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 28 Feb 2009 14:28:28 +0000] rev 1560
Catch mail exceptions and use get_current_user
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 28 Feb 2009 13:06:04 +0000] rev 1559
Fixed issue 205.
Registered students can't apply to become an organization. If for some reason the org sign up period and student sign up period are run in parallel and a student has applied to become an org, the application will still go through the normal system. Although the student won't be able to become an org admin until he has been invalidated as a student.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 28 Feb 2009 12:59:34 +0000] rev 1558
Fixed a comment typo
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 28 Feb 2009 12:32:52 +0000] rev 1557
Properly fixed host access now
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 28 Feb 2009 12:11:20 +0000] rev 1556
Flush the receiver's sidebar when sending a notification
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 28 Feb 2009 12:10:49 +0000] rev 1555
Do not modify django_args directly
This broke document listing since it used kwargs as filter.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 28 Feb 2009 12:10:19 +0000] rev 1554
Fixed a brown paper bag bug in _checkHasActiveRoleFor
Also updated sponsor to not pass redundant arguments.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 28 Feb 2009 11:19:17 +0000] rev 1553
Added sending of an email upon Organization Application acceptance or rejection.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 28 Feb 2009 11:16:54 +0000] rev 1552
Added accepted and rejected organization application mail templates.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 28 Feb 2009 10:39:23 +0000] rev 1551
Fixed sending out email when no-reply is not set.
(Puts a brown paper bag on his head and runs!)
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 28 Feb 2009 10:25:41 +0000] rev 1550
getDefaultMailSender now returns a tuple (name, email adress).
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 28 Feb 2009 00:41:36 +0000] rev 1549
Removed updateEntityProperties's transactionality
entity.put() is already transactional, and all other methods called
do not need transactionality (even so, it is hurtfull that they are
run within a transaction).
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 28 Feb 2009 00:10:07 +0000] rev 1548
Denormalize accounts before trying to send e-mail
Otherwise accounts that are in the auth domain are not a valid e-mail
address.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 28 Feb 2009 00:09:34 +0000] rev 1547
Added a denormalizeAccount
Updated the existing testcases to make sure it works.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 27 Feb 2009 23:33:20 +0000] rev 1546
Using getDefaultMailSender for welcome and notification messages.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 27 Feb 2009 23:32:37 +0000] rev 1545
Added getDefaultMailSender method to mail_dispatcher.
Will be used to determine from which mail address we should send an email.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 27 Feb 2009 12:04:49 +0000] rev 1544
Fixed typo in soc/models/group_app.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 27 Feb 2009 11:48:12 +0000] rev 1543
Inform the user that the link_id cannot be changed
Hide the extended help text once the user has created a profile,
since the link_id can no longer be changed.
Also moved the link_id to the top of the screen, to make it look
better when the extended help text is not shown.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 27 Feb 2009 11:38:24 +0000] rev 1542
Made the ToS field higher
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 27 Feb 2009 11:30:20 +0000] rev 1541
Removed double description field
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 27 Feb 2009 10:52:28 +0000] rev 1540
Revert "Make the input values 100% width."
This reverts r2173, see r2101 for details.
Patch by: SVerre Rabbelier
Tim Ansell <mithro@gmail.com> [Fri, 27 Feb 2009 06:54:15 +0000] rev 1539
Make the input values 100% width.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 26 Feb 2009 20:29:09 +0000] rev 1538
Changed access checks for group applications to allow reviewing of rejected applications.
Just in case the user made a mistake :).
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 26 Feb 2009 20:28:19 +0000] rev 1537
Added bulk reject to org_app view.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 26 Feb 2009 20:27:28 +0000] rev 1536
Redone the review_overview template to show bulk reject button.
Added a TODO to make both buttons dissapear.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 26 Feb 2009 20:25:56 +0000] rev 1535
Renamed org-accept.js to bulk-review.js
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 20:23:21 +0000] rev 1534
Brown paper bag fix
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 26 Feb 2009 18:00:30 +0000] rev 1533
Fix for Issue 218.
Basically just an update of the soc/gorup/messages/accepted.html template.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 17:36:46 +0000] rev 1532
Added a missing import
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 17:06:17 +0000] rev 1531
Fix alignment of twoline readonly table rows
Also removed an unused template tag.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 17:00:34 +0000] rev 1530
Added some tests for user logic
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:59:57 +0000] rev 1529
Fixed a bug in student access check
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:59:24 +0000] rev 1528
Allow to do 'checkHasActiveRole' checks for document access
This is used for documents in the site prefix.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:58:45 +0000] rev 1527
Simplify the account retrieval logic
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:58:15 +0000] rev 1526
Convert everything to use the new access methods
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:57:13 +0000] rev 1525
Remove direct uses of checkIsActive, replace with helper methods
This makes _checkIsActive a lot easier to understand, and makes the
access checkers involved a lot more explicit.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:56:37 +0000] rev 1524
Make django_args optional where appropriate and whitespace fixes
Access methods that do not use django_args should make it optional.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:56:01 +0000] rev 1523
Added an isDeveloper method to user logic
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:55:23 +0000] rev 1522
Always normalize accounts, before even storing them
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:54:44 +0000] rev 1521
Factor out the getForAccount logic in user
Also normalize the account before retrieving it.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:54:08 +0000] rev 1520
Add a normalizeAccount to logic.accounts
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:53:36 +0000] rev 1519
Remove unused isAccountAvailable function
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:53:05 +0000] rev 1518
Add a _createField hook
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:52:29 +0000] rev 1517
Pass _updateField the entity_properties dict instead of just the value
This enables _updateField to change the value in entity_properties if
desired.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:51:35 +0000] rev 1516
Do not update newly created model properties
There is no real reason to favor old behavior over the current, plus
the new behavior saves an extra disk write (which are expensive).
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:50:59 +0000] rev 1515
Move the hooks in base.Logic to the bottom of the class
This more closely follows 'important methods first'.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:50:22 +0000] rev 1514
Minor cleanups in base.Logic
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:49:45 +0000] rev 1513
Add argument validation to base.Logic
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:49:06 +0000] rev 1512
Remove updateOrCreateFromFields and it's uses
All uses of updateOrCreateFromFields were replaced with
updateOrCreateFromKeyname. This way the logic API is not as cluttered
with a bunch of helper methods.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:48:02 +0000] rev 1511
Fix some whitespace damadge and a style fix
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:47:04 +0000] rev 1510
Remove _silentUpdateEntityProperties
Instead, pass a silent flag to updateEtitytProperties.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:46:29 +0000] rev 1509
Style fix in role.py
Patch b: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:45:53 +0000] rev 1508
Added todo for Lennard
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:45:18 +0000] rev 1507
Make it more explicit which argument is the key_fields
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 26 Feb 2009 09:02:51 +0000] rev 1506
Solved the JSON caching problem for bulk acceptance.
This is done in the same way as it is done in AJAX calls by appending the current time as a GET argument.
Patch by: Mario Ferraro, Lennard de Rijk
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 26 Feb 2009 08:48:02 +0000] rev 1505
Edited checkCanReviewGroupApp to cope with the new pre-rejected status.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 26 Feb 2009 08:47:21 +0000] rev 1504
Add the ability to put GroupApplications into the pre-rejected state.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 26 Feb 2009 08:38:09 +0000] rev 1503
Added pre-rejected choice to GroupApplication.
This will be used to bulk reject organizations.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 26 Feb 2009 04:29:56 +0000] rev 1502
Remove the release.py module and just use the field in app.yaml.template.
This is a DRY fix, to have the release /branches/ and /tags/ use a release
version that is compatible with the app.yaml file "version:" field.
Also, the steps for creating a release were simplified (with several steps
removed), and the release procedure moved to app/README, since
app/soc/release.py is now deleted.
Patch by: Todd Larsen
Review by: to-be-reviewed