Fix trailing whitespace and apply decorators Patch by: Sverre Rabbelier

Fix whitespace damage Patch by: Sverre Rabbelier

Make use of the new decorators in all applicable views Patch by: Sverre Rabbelier

Renamed showReviewOverview to review_overview and reviewOverview Patch by: Sverre Rabbelier

Fixed two trivial bugs A "kwargs=kwargs" instead of **kwargs Missing 'and entity' check Patch by: Sverre Rabbelier

Added a merge_params and check_access decorator The merge_params decorator is very simple and takes self._params and merges it with params. It's main purpose is to explicitly mark the views in which it is intended that self._params is merged raw. The check_access decorator factors out the access checking process and passes args and kwargs to the access checking methods. Patch by: Sverre Rabbelier

Prepare access to receive args and kwargs as argument Also use two "magic values" when the sidebar is doing the access checks, this might be useful later. Patch by: Sverre Rabbelier

Reverted r1457. Patch by: Lennard de Rijk

Changed link in club_app accepted notification. Patch by: Lennard de Rijk

Added a new view to help with application -> group process. The applicant view is available only when there is an accepted application present. This will be checked by the access checker in an upcoming patch. The view uses a special form so that certain fields cannot be edited by the user. These fields correspond to important fields filled in during the application process. Create access for a club has now been set to Host level. Patch by: Lennard de Rijk

onCreate for a Club now marks any application for the same club as completed and invites the admins. This is useful for when the club has been created without using the application. Patch by: Lennard de Rijk

Edited the method used to clean link_id in params.py. Removed the clean_new_link_id from the logic/cleaning.py module because this is not used anymore. This method should be replaced by a method that is used after all the fields have been cleaned so that the actual key_name of an entity can be constructed. Patch by: Lennard de Rijk

Fixed a typo in the comments of soc/views/helper/forms.py Patch by: Lennard de Rijk

Fix missing import identified by pylint. ************* Module app.soc.logic.models.user E0602: 99:Logic.agreesToSiteToS: Undefined variable 'db' Patch by: Todd Larsen Review by: to-be-reviewed

Fix missing import identified by pylint. ************* Module app.soc.logic.models.presence E0602: 56:Logic.getToS: Undefined variable 'db' Patch by: Todd Larsen Review by: to-be-reviewed

Fix missing import identified by pylint. ************* Module app.soc.views.helper.responses E0602:187:getToSLink: Undefined variable 'db' Patch by: Todd Larsen Review by: to-be-reviewed

Add agreesToSiteToS() logic method to indicate if User accepts site-wide ToS. Patch by: Todd Larsen Review by: to-be-reviewed

Give error messages more room in the existing form field "as_table" templates. Patch by: Todd Larsen Review by: to-be-reviewed

Add a clean_agrees_to_tos() validator that requires "Yes" if ToS exists. Also, more user_logic.logic => user_logic fixes. If you are going to import "as", you might as well make the renaming worthwhile. Maybe we need to add a section on "import ... from ... as ..." in the style guide? Patch by: Todd Larsen Review by: to-be-reviewed

Change "Show" to "Export" missed in r1446 commit. Patch by: Todd Larsen Review by: to-be-reviewed

Add an export() view, and implement it as text/text for Document. For every Model except Document, the public() view is displayed for any attempts to access the export() view. Currently, the permissions for export() are the same as for public(). This seems reasonable for Document, since anyone could extract the raw HTML from the page source anyway. The permissions should probably be different for other types of exports, such as vCard or iCard exports of profiles, CSV exports of lists, etc. Patch by: Todd Larsen Review by: to-be-reviewed

If a site-wide ToS exist, display the User profile "Agrees to ToS" checkbox. Patch by: Todd Larsen Review by: to-be-reviewed

Set agrees_to_tos example text to link to site-wide ToS (or a warning message). Also, since a renaming import statement is being used already, change user_logic.logic to just user_logic. Patch by: Todd Larsen Review by: to-be-reviewed

Do not crash on *every* page load if there is no ToS Document. 'tos' ReferenceProperty might be present, but still be None. Patch by: Todd Larsen Review by: to-be-reviewed

A better way to add site-wide ToS link to *all* pages on the site. getUniversalContext() already fetches a copy of the Site settings, so use that to see if the site-wide ToS exist and produce a link. Patch by: Todd Larsen Review by: to-be-reviewed

Linux /bin/sh (GNU) is not the same as OS X /bin/sh (BSD), so use /bin/bash. Fixes: scripts/pylint/do_pylint.sh: 27: Syntax error: "(" unexpected on Ubuntu (and possibly other Linux distros). Patch by: Todd Larsen Review by: to-be-reviewed

Replace css class 'notice' that is used in User profile template field help text with new 'fieldhelptext' class. Notice is part of CSS for notification bar and we want width limit just for field help text not for notification bar text. Patch by: Pawel Solyga Review by: to-be-reviewed

Add getSingleton() method to return the Site settings entity. There is always only one Site entity, referred to by DEF_SITE_LINK_ID. Patch by: Todd Larsen Review by: to-be-reviewed

Return the ToS Document of the supplied Presence entity, if there is one. Patch by: Todd Larsen Review by: to-be-reviewed

Support HTML tags in form field example_text column. Improve the Program Model example_text as an example. Patch by: Todd Larsen Review by: to-be-reviewed