Sverre Rabbelier <srabbelier@gmail.com> [Mon, 20 Oct 2008 23:23:53 +0000] rev 397
Remove the google search box and the google analytics page
These are left over from the mockups (removed because they
caused long wait times when no internet connection is
available).
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 20 Oct 2008 23:23:43 +0000] rev 396
Improve the error message for getIfFields
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Mon, 20 Oct 2008 22:18:32 +0000] rev 395
Add documentation in response to Pawel's comments:
http://code.google.com/p/soc/source/detail?r=832
Patch by: Todd Larsen
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 19 Oct 2008 21:12:08 +0000] rev 394
Add BaseForm class to soc.views.helper.forms module (work in progress). This changes the way as_table function displays the form (for more information have a look into doc string). BaseForm is going to be used for all forms in Melange in future. Right now it's still missing custom form errors labels and "required" text in 3rd column, but that's added as TODO and I'm working on it.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 19 Oct 2008 21:08:08 +0000] rev 393
Add colon after label in _field_as_table_row template for consistency reasons with form.as_table output.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 19 Oct 2008 18:00:14 +0000] rev 392
Add "View Sponsor Public Profile" to Sponsor Edit view template. Remove not needed <p> in home/public.html template. Add missing '$' at the end of some urls in site/map.py module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 19 Oct 2008 17:33:44 +0000] rev 391
Address comments to r844 and r845.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 19 Oct 2008 16:17:32 +0000] rev 390
Remove unused imports, fix too long lines and indentions.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 19 Oct 2008 13:14:40 +0000] rev 389
Fix identions, too long lines, unused imports and some other mistakes.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 19 Oct 2008 13:06:20 +0000] rev 388
Add pylint configuration file (pylintrc) and do_pylint.sh script which runs pylint checkers on Melange code using pylintrc file as config. do_pylint.sh as default shows additional information like reports, TODOs, code similarities and unused imports, but you can run it in silent mode (--silent) which disables all of that. The only problem with unused imports in pylint right now is that it doesn't work in the situation described in last example at http://code.google.com/p/soc/wiki/PythonStyleGuide#Packages, so sometimes we get unused import soc when we actually shouldn't. However this can be fixed by writing pylint plugins (our own checkers) in future.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 19 Oct 2008 00:34:33 +0000] rev 387
Addressed comments by Todd on r822
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 18 Oct 2008 21:55:38 +0000] rev 386
Fix identions in reflistprop module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 18 Oct 2008 21:54:13 +0000] rev 385
Remove not used imports in models. Fix missing spaces in models when operator not preceded by a space. Add missing ugettext_lazy import to Proposal model.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 18 Oct 2008 17:49:46 +0000] rev 384
Add missing ugettext_lazy for string in soc.views.user.profile module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 18 Oct 2008 17:27:53 +0000] rev 383
Fix missing keyword argument in soc.views.user.profile.create() function when calling edit().
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 18 Oct 2008 17:25:04 +0000] rev 382
Change Sponsor delete url from /site/sponsor/profile/<link_name>/delete to /site/sponsor/profile/delete/<link_name> to match convention used in Document delete url.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Chen Lunpeng <forever.clp@gmail.com> [Sat, 18 Oct 2008 05:59:04 +0000] rev 381
Fixed not working to edit a doc that selected from the docs list view. soc/templates/soc/docs/list/docs_row.html not full updated.
Patch by: Chen Lunpeng
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 18 Oct 2008 05:30:57 +0000] rev 380
Change the "Site home page Document is missing" default text to give
instructions similar to those in the Site Settings form.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 18 Oct 2008 05:26:53 +0000] rev 379
Remove another now-empty templates directory.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 18 Oct 2008 05:25:47 +0000] rev 378
Nothing left in this templates directory, so remove it.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 18 Oct 2008 05:11:37 +0000] rev 377
Refactor various site views into more generic locations, in preparation for
using access permissions to decide the fuctionality in the view, instead of
having lots of cut-and-paste copies of the same view functions.
site/home.py into more generic home.py
site/settings.py into more generic settings.py
site/docs/list.py into more generic docs/list.py
site/docs/edit.py into more generic docs/edit.py
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 18 Oct 2008 04:56:39 +0000] rev 376
Add a style that appears in form error lists produced by Django Forms and
make it match the style of the existing td.formfielderror used by the
field_as_table_row helper.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 18 Oct 2008 01:51:02 +0000] rev 375
Create package for soon-to-be-refactored group/home.py and group/settings.py
packages.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 18 Oct 2008 01:47:02 +0000] rev 374
Add the Page object to the context of each view. Update templates to make
use of the newly-available page.long_name and page.short_name.
Patch by: Todd Larsen
Review by: to-be-reviewed