Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 17 Oct 2008 13:04:51 +0000] rev 368
Move TODO about isDeletable Sponsor logic method to sponsor.py module and extend a little bit doc string.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 17 Oct 2008 12:52:02 +0000] rev 367
Remove not needed request argument in view decorator.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Chen Lunpeng <forever.clp@gmail.com> [Fri, 17 Oct 2008 02:43:39 +0000] rev 366
Fixed not working after click the "List Site Sponsors" in site menu bar. due to wrongly imported modules.
Patch by: Chen Lunpeng
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 23:31:57 +0000] rev 365
Create decorators module in view/helper and add view decorator that catches exceptions like DeadlineExceededError, MemoryError, AssertionError (this code is being moved from respond function). Add view decorator to all view functions. In addition remove not needed imports from all affected files and fix too long lines.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 16 Oct 2008 23:26:58 +0000] rev 364
Last commit missed the new __init__.py file
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 16 Oct 2008 23:23:16 +0000] rev 363
Add a framework for generic views
This commit does not enable the new code, as such there
should be no change in functionality. In order to use the
new code the maps.py file should be updated to point at the
new views/models/sponsor.py module.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 16 Oct 2008 18:08:35 +0000] rev 362
entity_type is not the same as entity_type_short
The previous commit wrongfully assumed this.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 17:34:10 +0000] rev 361
Make page argument required for errorResponse and requestLogin functions in simple.py and update affected files. Some keyword argument changes to in user/profile.py. All the changes are based on comments to r817.
http://code.google.com/p/soc/source/detail?r=817
Patch by: Pawel Solyga
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 16 Oct 2008 17:30:58 +0000] rev 360
Rename 'group' to 'entity' in the Django templates
This allows for generic use of these templates.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 16:05:08 +0000] rev 359
DeadlineExceededError in the recent version of AppEngine lives only in one place so there is no need to try import it from both runtime (deployed) and runtime.apiproxy_errors (dev server) modules anymore.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 15:22:41 +0000] rev 358
Add page=None parameter to all views. Information from page argument (which is soc.logic.site.page.Page object) is going to be used later in views code and for some context values. Fix some indentions in __doc__ strings. Add proper __doc__ string for all() function in sponsor/list.py module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 15:12:00 +0000] rev 357
Some indention fixes in access.py module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 13:18:59 +0000] rev 356
Change name of login_request variable in access.py module to login_response.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 13:16:46 +0000] rev 355
Change name of getUserFromLinkNameOrDie function to getUserFromLinkNameOr404 and apply changes to affected files.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 13:14:13 +0000] rev 354
Fix mistakes in docs and comments in logic/models/base.py.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Chen Lunpeng <forever.clp@gmail.com> [Thu, 16 Oct 2008 09:14:26 +0000] rev 353
Log Fix not working after click the "Site Settings" in home page. templete wasn't updated when soc/app/soc/logic/site/map.py was update.
Patch by: Chen Lunpeng
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 09:05:02 +0000] rev 352
Remove #docsummary class from css file as it is not used anymore. Add #createdby class in css file. Fix typo in docs/profile.html template. Put document content in <div class='content'>.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 16 Oct 2008 04:37:13 +0000] rev 351
Eliminate the Work.abstract property and move the Document.content property
to Work.content instead. Update affected views, and re-base some classes
that were deriving from Document just to get Document.content to now be
derived from Work instead.
The Document class now has a "pass" body with no additional properties. It
is debatable whether Work should become Document, since I am not sure that
we plan to be able to generically display, say, a Quiz or a Question (which
are Works) on the home page (which can only specifically display a Document,
or now, the basic Work entity...).
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 16 Oct 2008 04:30:26 +0000] rev 350
"new" is a little bit redundant in the short_name of sidebar menu items that
already begin with "Create...", since that implies the result will be something
new.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 16 Oct 2008 04:27:07 +0000] rev 349
A quick-and-dirty way to create non-link sub-menu dividers, plus a TODO on
how this should be formalizes to not be so hacky.
This change was inspired by the ever-growing "Site" sidebar menu.
Patch by: Todd larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 15 Oct 2008 21:31:36 +0000] rev 348
Should have been part of recent r806.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 15 Oct 2008 21:27:47 +0000] rev 347
First phase of making the / (site/home) view generic enough to use it for
Sponsor "home" page, Program "home" page, Organization "home" page, etc. when
combined with HomeSettings.
First phase of addressing this issue:
http://code.google.com/p/soc/issues/detail?id=64
by factoring "Site Settings" apart from the site/home stuff.
Patch by: Todd Larsen
Review by: Pawel Solyga
Review URL: http://codereviews.googleopensourceprograms.com/1405
Todd Larsen <tlarsen@google.com> [Wed, 15 Oct 2008 21:23:29 +0000] rev 346
Add the empty directory where site/home/edit.html is moving, to see if this
fixes a problem with gcl.py.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Oct 2008 20:27:40 +0000] rev 345
Update TinyMCE wiget code according to r783. I hope I did it correctly this time.
http://code.google.com/p/soc/source/detail?r=783
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Oct 2008 20:24:02 +0000] rev 344
Change verbose_name of founder property in Group model from "Created by" to "Founded by". Add GROUP_TYPE_SHORT and GROUP_TYPE_PLURAL for all models that inherit from Group and use that values in templates and contexts. Assume that group_type, group_type_short and group_type_plural are defined in context and remove not needed ifs in templates. Rename "Linkname" to "Link name" in list/group_heading.html template.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Oct 2008 20:10:07 +0000] rev 343
Remov "founder" text from the first line of edit.py, this is fix to r799 commit.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 15 Oct 2008 19:33:50 +0000] rev 342
Remove the proposed WorksAuthors many:many relation and promote the "founder"
property from Document up to Work. Update all subclasses of Work and any
affected views accordingly. This addresses review comments here:
http://code.google.com/p/soc/source/detail?r=786
Patch by: Todd Larsen
Review by: to-be-reviewed
Tim Ansell <mithro@gmail.com> [Wed, 15 Oct 2008 18:06:07 +0000] rev 341
Fixed the evil black logo.
Tim Ansell <mithro@gmail.com> [Wed, 15 Oct 2008 18:03:21 +0000] rev 340
Make this file excutable by default.
Todd Larsen <tlarsen@google.com> [Wed, 15 Oct 2008 17:10:27 +0000] rev 339
Define the Models for implementing Quizzes (collections of Questions) and their
Responses (collections of Answers to those Questions). These Models would
form the basis of storage for such items as:
Terms of Service (Quiz)
Question ("I agree...")
Response -> Answer (answer to "I agree..." confirmation)
solution ("Yes" Answer to the "I agree..." Question)
Mentor and Student surveys (Quiz)
Questions (including "Pay this student?")
Response -> Answers
solution ("Yes" Answer to the "Pay this student?" Question)
Organization applications
Student Proposal review, comment, and scoring system
GHOP task tracking (a specific task list item would be a Quiz)
Patch by: Todd Larsen
Review by: Pawel Solyga, Sverre Rabbelier, Chen Lunpeng
Review URL: http://codereviews.googleopensourceprograms.com/1403