Edited help text to be more clear when a Survey has been submitted.

Add setOrganizationInSurveyRecords function to stats.py script. setOrganizationInSurveyRecords will iterate thru all ProjectSurveyRecords and GradingProjectSurveyRecords and set the organization property in the record model.This will be useful later for showing Org admins their mentors and students surveys list and results.

Add Organization reference property to ProjectSurveyRecord. Also update ProjectSurvey view _takePost method to set this property everytime survey is taken.

Fix indention and add missing dot in docstring in survey models.

GradingSurveyGroup now uses DynaForm for its forms.

Indention fixes and adding "reference_class=" in ReferenceProperty params.

Start using buildout to bring in external dependencies. This makes running tests easier in situations where dependencies are not always available, such as buildbot. Thanks to Matthew Wilkes <matthew@matthewwilkes.co.uk> for help and moral support.

Added GradingSurveyGroup to the sitemap and sidebar.

Completed the Create and Edit view for GradingSurveyGroup. Note that I've added a TODO to redo _editPost to give us kwargs. Would also get rid of hidden fields elsewhere. Reviewed by: Lennard de Rijk

Fixed GradingRecord and GradingSurveyRecord Logic to load the correct Model.

Added denySidebar to several access checks.

Added Surveys to sidebar menu.

Changed title entry in GradingSurveyGroup's public template to name.

Added skeleton view and templates for GradingSurveyGroup.

Added name property to GradingSurveyGroup. This can be used (by humans :D) to easily identify different instances of this model.

Added missing blank line to GradingSurveyGroup logic.

Added logic for GradingRecord and GradingSurveyGroup.

Removed results list from Survey edit. Some changes to the Survey Result page have also been made, however the results viewer and the CSV export are not working properly in that View. Reviewd by: Lennard de Rijk

Extended tooltip timeout to 10 seconds for all fields. This is because the tooltip currently timesout to fast for people to read the whole stories they can contain. Especially because Surveys can have custom tooltips. Reviewed by: Lennard de Rijk

Minor stylefix to StudentProject model.

Changed the StudentProject model to handle a dynamic amount of GradeRecords. This allows for a dynamic amount of moments where a StudentProject can be evaluated. Also included in this patch are changes to the status property that will help to enable PA's to withdraw StudentProjects from the program without the need for a developer to step in.

Renamed several files due to recent changes.

Style fixing in GradeRecord model

Several Survey UI fixes. Fixes: Too narrow fieldsets in new question/option dialogs. Survey submit (on take view) and save/export/etc. buttons at weird places, instead of at bottom. Weird placement of radio buttons in Opera. Too narrow selects in IE. Broken images in edit view in IE and Opera. Reviewed by: Lennard de Rijk (Only on IE)

Fixed base template URL to tagged version of the deployed source code. The old link revered to SVN based projects. Reviewed by: Lennard de Rijk

Fixed imports for Survey logic.

Added skeleton models for GradingSurveyGroup and Records. SurveyRecordGroup has been renamed to GradingRecord. GradingSurveyGroup will hold which Surveys should be linked. While the acompanying GradingRecords (with their reference to a GradingSurveyGroup) will hold the Records for each StudentProject that can take these Surveys.

Added tag v0-5-20090706 for changeset c17b671e5657

Set new Melange version number to 0-5-20090706 in app.yaml.template.

Ensure that the Grade field data stays in clean_data. This prevents a bug that happens when you pick an invalid entry in the choice a grade field. If this bug was triggered the value of the survey_record.grade was used. Now however a proper ValidationError is raised.

Add missing import to Project Survey view. Reviewed by: Lennard de Rijk

Renamed several files due to recent changes.

Now properly escaping JS and converting new lines into br for Tooltips. Patch by: Mario Ferraro, Lennard de Rijk

Added ability to add custom tooltips and UI improvements. Reviewed by: Lennard de Rijk

Public Survey template now resembles the take template more closely.

Added the possiblitity to add a description to the top of the Survey. Thie uses the content property which has been inherited from the Work model.

Use CSS instead of JS for Survey layout. Reviewed by: Lennard de Rijk

Remove the custom propmpt inside textareas and input fields. This will hopefully be replaced with custom tooltips. Two reasons for this are that the tooltips will still be readable once your start typing and this way we avoid a bug that caused a textarea to go into prompt mode on some form validation errors. Reviewed by: Lennard de Rijk

Fix HtmlSanitizer to return cleaned string in proper encoding. This fix prevent HtmlSanitizer from throwing UnicodeDecodeError exception.

Added clear:right property to submit button in Survey take form. Reviewed by: Lennard de Rijk

Fix button layout on Safari 4.0 for Survey take page. Reviewed by: Lennard de Rijk

Fix comment indention in survey-take javascript file.

Renamed survey-take-090627.js to survey-take-090705.js.

Increased bottom margin on comments for better grouping. Reviewed by: Lennard de Rijk

Changed the filter for getting a SurveyRecord for a ProjectSurvey ProjectSurveyRecords are characterized by the Survey and a Project entity. The user property is just there to state who last submitted the Survey.

Added tag v0-5-20090705p1 for changeset c7726e3ab173

Set new Melange version number to 0-5-20090705p1 in app.yaml.template.

Ensure that accessViolations for Survey menu items get captured. (Also ensure that you think before committing something you broke yourself :()

Added tag v0-5-20090705 for changeset 8f3a8e066111

Set new Melange version number to 0-5-20090705 in app.yaml.template.

Added Menu items for all three kinds of Surveys to the program menu. The menu items turn red when the user has not taken the Survey yet. Patch by: James Levy, Lennard de Rijk Reviewed by: to-be-reviewed

POST data always overwrites survey_record data when used to populate form. It also fixes validation errors on takeGet. Patch by: Daniel Diniz, Lennard de Rijk Reviewed by: to-be-reviewed

Fixes bug when option name contains double quotes.

Several style fixes due to code reviews.

Ensure that long questions and comments are stored as db.Text. This is done by adding the setCleaners methods which sets the appropriate cleaners for dynamic fields. Reviewed by: Lennard de Rijk

Style fix in access module.

Returned ProjectSurvey create to checkIsUser. The access protection is properly done by the form validator.

Added access checks for taking a Project(Grading)Survey.

Brown paper bag fix for using non-existing logic in ProjectSurvey views.

Fixed basic Survey access check. Also enabled this check for all relevant Views. However ProjectSurveys and subclasses still need an additional check. A stub for this has been added to the access module.

Fixed broken selection questions from refactoring SurveyForm. Reviewed by: Lennard de Rijk

Fixed showing the correct list of projects for taking a Grading Project Survey. Note that when a user is a mentor for a lot of Organizations the amount of subqueries might exceed the allowed amount. A TODO has been added to fix this issue. However this will hopefully not be a problem that pops up soon. Also some minor docstring addition to Project Survey view.

Refactored filter construction to _constructFilterForProjectSelection. This allows Grading Project Survey to overwrite this method and create its own filter.

Make sure that radio button questions validate correctly and allow only one choice. Reviewed by: Lennard de Rijk

Added Daniel Diniz and Zachary Voase to the AUTHORS file.

Added Daniel Diniz to authors for Grading Project Survey View.

Add a grade field to the Grading Project Survey form. This also takes care of validating and transforming the data into True(pass) or False(fail). GradingProjectSurveys are hereby working for developers. Reviewed by: Lennard de Rijk

Survey editing/taking Javascript and CSS fixes. This patch adds some cosmetic changes and functional fixes: - UI now removes all of the field content when a field is deleted, - CSS tweaks, and jQuery hack to specialize comment CSS, - fixed JS path in take.html. Reviewed by: Pawel Solyga (with some small changes)

Remove public role type from SURVEY_TAKING_ACCESS in Survey model.

try to fix the surveys-have-no-scope issue to-be-reviewed: also untested

addressed comments to previous version to-be-reviewed: still untested

return found entity for activity checks

survey access: stylefix and remove public role type

Style fixes in Survey helper.

Added _getSurveyTakeForm to the Survey view. Subclasses can overwrite this method to create their own form. ProjectGradingSurvey will likely be an example for this.

Only initialize a SurveyTakeForm in take instead of in takeGet and takePost. This will allow for other subclassed views to easily replace the form the view is using. Also small style fix in Survey helper.

Split SurveyForm into SurveyTakeForm and SurveyEditForm. This allows for a more cleaner implementation of the Form code. And this will make it easier to break free from the getFields method in the future. Also the getRoleSpecifcFields method and the this_user and project variables have been removed. They are deemed obsolete. Reviewed by: Lennard de Rijk

Do not call takeGet when SurveyForm ValidationError occurs. Problems occured when a SurveyRecord was specified in the SurveyForm. The SurveyRecord data reset the erroneous POST data. Further code reduction might be possible soonish.

Several stylefixes due to received reviews.

Style fixes in Access module.

Style fixes to the GradingProjectSurvey View module.

Sub_merge params for GradingProjectSurvey View.

Added rudimentary grade field to GradingProjectSurvey take View. Patch by: James Levy, Lennard de Rijk Reviewed by: to-be-reviewed

Ensure that the params from subclasses get merged properly with ProjectSurvey view.

Corrected the links to Grading Project Surveys in Program menu.

Added missing import to ProjectSurvey View.

Fix pick_multi only returning one answer as maximum. Reviewed by: Lennard de Rijk

Removed getSurveyResponseFromPost from Surveys helper. We will use the power of Django Forms instead of getting our own properties. This fits better into the rest of Melange which also uses this approach.

Renamed survey-edit-090627.js due to recent changes.

Form errors when taking a Survey now have the correct context.

Fixed Survey Form error giving 505. I failed when changing the system to work with collectCleanedFields.

Surveys can now have required questions and comments can be turned on/off. Storing comments is now working. However some issues arise when form errors occur, like missing context and the errors also trigger before a form has been submitted. Reviewed by: Lennard de Rijk

Added Survey From Field validation. Also added the COMMENT_PREFIX in Survey model to ensure that comments are stored in the same way everwhere. Reviewed by: Lennard de Rijk

Style fixes and a forgotten parameter in Survey(Record) logic. Reviewed by: Lennard de Rijk

Removed unnecessary variable in ProjectSurvey take method.

Overwrite _getSurveyRecordFor in ProjectSurvey view to take StudentProject into account.

Added _getSurveyRecordFor method to Survey View. This method is used by the Take view to get the right SurveyRecord for the current request. Subclassed Views that want to fetch their records in another way can override this method.

Added default Survey list templates for ProjectSurvey and GradingProjectSurvey.

Enable the ProjectSurvey and GradingProjectSurvey views in the core. Also add menu items to the program menu for easy access to these options. Reviewed by: Lennard de Rijk

Implemented taking ProjectSurveys. The user will first be served a list of all eligble StudentProjects for which the ProjectSurvey can be taken. After clicking on the list the key_name of the project is attached as a GET param and the code uses the normal take view with the hooks to let everything run smoothly. An extra access check method is required which checks if the Project mentioned in the GET param is a valid project for the current user. This check will run together with the isSurveyTakable checker.

Edit SurveyRecord model to not make use of different Survey property for each subclass. This does mean that a simple query needs to be constructed by hand whenever you want to query for every SurveyRecord for a specific Survey. However the naming is now the same over each SurveyRecord and it fits well into the rest of the design of Melange.

Made the CSV exporter for Survey not rely on the BackReferenceProperty in Survey.

Added getTakeProjectSurveyRedirect. This redirect is used when taking a ProjectSurvey.

Added the possibility to change the action of the form on the Survey take page.

Small style fix in Surveys helper.

Set required is True for StudentProject reference in ProjectSurveyRecord.

Removed obsolete if tag form take template.

Added hook methods to takeGet and takePost.

Fixed typo in title of Survey Take page.

Add a base implementation of takePost. Normal Surveys can now be taken, however comments are not stored yet.

Added getSurveyResponseFromPost method to Surveys Helper. This method will be used to read the POST dictionary from a request. And will transform it into the fields that need to be set in a SurveyRecord for the questions specified by the given Survey. A TODO has been added to handle the naming/handling of the comment fields.

Added updateOrCreateFromFields method to SurveyRecordLogic. The reading of the fields from the POST request will not happen in this Logic anymore.

Added base class logic for Expando based models.

Removed two obsolete/outdated methods in Survey Logic. The updateSurveyRecord can be found in the SurveyRecord logic.

Removed obsolote method call in Program View.

Clean up and other fixes for Survey modules. Reviewed by: Lennard de Rijk

Implemented the takeGet view for Surveys.

Fixed multiple typos in Survey tooltips strings.

Added skeleton for the take view and its template. Also fixed the sorting of imports of the Survey View.

Move getMenusForScope to the end of the View class. Adhering to our principle that we the methods we use for generating our menus can be usually found at the bottom of the View class.