Take advantage of the Model inheritance provided by polymodel.PolyModel to have Club, School, Sponsor, and Organization actually inherit from the Group Model class, rather than being composed via ReferenceProperties. Patch by: Todd Larsen Review by: Pawel Solyga, Sverre Rabbelier, Augie Fackler Review URL: http://codereviews.googleopensourceprograms.com/606

Take advantage of the Model inheritance provided by polymodel.PolyModel to have create a class hierarchy rooted at Person. Also, add some missing Role classes, such as Role, (Organization) Mentor, (Club) Member, (School) Student. Make (Organization) Administrator be a Reviewer like Mentor is. Patch by: Todd Larsen Review by: Pawel Solyga, Sverre Rabbelier, Augie Fackler Review URL: http://codereviews.googleopensourceprograms.com/607

Make use of PolyModel for Works, Documents, etc. Add some (but not all) of the missing Models related to Documents. Refactor site settings to be useful for any "/home" page view. Make the resulting home settings store a reference to the Document, rather than looking up the Document by a hard-code key name. This is to set the stage for Document editing being generic, and then being able to select from some existing documents which one to use as the "/home" static content. This makes it possible to pre-edit several Documents, have them Reviewed, and then quickly change the "/home" page content as a setting, rather than editing the Document in the settings form (though settings forms might still embed the current document into their form for convenience). Patch by: Todd Larsen Review by: Pawel Solyga Review URL: http://codereviews.googleopensourceprograms.com/1001

Fixed not working "Create New User" view which was caused by adding key_name into User Edit Developer view. This commit divides edit() view function in soc.views.site.user.profile into edit() and create() request handlers. New create() request handler is used only in "Create New User" view and has specific form validation functions and uses updateOrCreateUserFromId() instead of updateUserForKeyName(). Patch by: Pawel Solyga Review by: to-be-reviewed

Add ModelWithFieldAttributes *before* PolyModel, so that everything does not become a "ModelWithFieldAttributes" in the Datastore. The way PolyModel works, each Model class hierarchy is stored in the Datastore as the class that directly inherited from PolyModel. So, we do not want to insert ModelWithFieldAttributes *after* PolyModel by inheriting *from* PolyModel, or everything would just be a ModelWithFieldAttributes in the Datastore, instead of Person, Work, Group, etc.

Add the third-party PolyModel class. This class supports inheritance in Google App Engine Datastore Model classes.

A key_name controller module to collect all of the name...() functions that compose Model entity key names, plus some minor changes to other controller modules to illustrate the proposed use. Patch by: Todd Larsen Review by: Pawel Solyga Review URL: http://codereviews.googleopensourceprograms.com/804 Review URL: http://codereviews.googleopensourceprograms.com/804

Fixed missing urlparse import in request_helpers which cause /user/profile and /site/user/profile not to work at all. Removed not used module imports in response_helpers.py.

Replace mock-up of sidebar with first draft of dynamic sidebar functionality.

Minor tweaks to Site menu item names to make them more descriptive.

Major refactoring, to switch from using inheritance from soc.logic.menu classes to an envelope-letter model instead.

Sidebar-building controller, with a TODO remaining to implement marking the current page as "selected".

Make views.helpers.html_menu MenuItem classes and logic.menu MenuItem classes more closely related. This is part of some refactoring in my working copy to keep soc/logic/site/sidebar.py from having to deal with html_menu classes (which is like having view code in the controller, which is bad).

Classes that wrap soc.logic.menu.Menu and soc.logic.menu.MenuItem to produce HTML renderings of such lists.

Change indentation level to 2 (from 4) and rename MCE_DEF_SETTINGS to DEF_MCE_SETTINGS to match the "default constant" naming convention elsewhere in the code.

Note 'groups' back-reference from 'founder' property in soc.models.group.Group.

Simple MenuItem and Menu classes for keeping track of ordered menus.

These changes should have been in r620, but somehow I did not save them, or saved over them with an old copy in the editor. Not sure...

Move isReferrerSelf() and replaceSuffix() into new request_helpers.py module, since they are (mainly) used to manipulate parts of an HTTP request.

Split out HTTP request manipulation functions from template_helpers.py, which is in danger of becoming a "misc" or "util" module unnecessarily.

Changes in TinyMCE widget in custom_widgets.py based on review comments. Patch by: Pawel Solyga Review url: http://code.google.com/p/soc/source/detail?r=550

Change user list view instruction. Don't show "Next >" disabled greyed text in the list pagination if there is only one page.

Add Users List Developer view which is available at /site/user/list. Add User list custom templates which are used with list_helpers. Add "Users List" link in base.html template. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Add list_helpers functions that are going to be used when rendering list views like (Users List, Sponsors List etc). Add list default templates and CSS classes. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Add support for changing User id (Google Account email) in User Profile Developer view. Now user profile developer edit view includes hidden key_name field. Fix typo in user/profile.py. Show former user ids in lookup and edit User Profile Developer views. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Small change to unescape function in template_helpers (move replace('&', '&') at the end).

Add rounded corners graphics. Add .notice class and rounded corners classes to soc.css file, those will be used to better visualize submit_message like "Profile saved.".

Remove Author model (use Person instead). Update models after removing Author. Add new Sponsor, Organization models. Patch by: Pawel Solyga Reviewed by: Todd Larsen Review issue: 801 Review URL: http://codereviews.googleopensourceprograms.com/801

Two changes to ease CI: 1) If pysvn is missing, the tests for svn_helper don't run and pollute the output 2) svn_helper no longer depends on being located at trunk/scripts/ Patch by: Augie Fackler Review by: Todd Larsen Review Issue: 802 Reviewed URL: http://codereviews.googleopensourceprograms.com/802

Add custom 404 error message with link to "Create a New User" which is displayed when linkname in User Profile Developer view URL (/site/user/profile/<linkname>) doesn't exist. Add default value (None) to new_suffix parameter of template_helpers replaceSuffix and redirectToChangedSuffix functions.

Testing buildbot. Sorry about the noise. (Last one for now, I've got most of the kinks figured out I think)

Testing buildbot. Sorry about the noise.

Testing buildbot. Sorry about the noise.

Make django.zip in release/, instead of in app/ with a symlink in release/. This allows debugging into app/django source code, which the presence of app/django.zip was blocking. Tested with both: dev_appserver.py release and dev_appserver.py app

A rough draft of the Group Model, to be merged with Pawel's current effort in his working copy. This is *very* incomplete...

First pass (from some old code notes) of a School Model (a form of Group).

First pass (from some old code notes) of a Club Model (a form of Group).

Bug fixes to revision r596. User Account field in Developer User Profile view needs to be an email not a login name. Header title of User Profile Developer view, when form validation failes is now showing correct value ("Modify existing ..." instead of "Create new user ...").

Add /site/user/profile Developer view for editing arbitrary User entities. Update /user/profile edit() view to fix TODO about updating the URL when a POST of the form changes the link_name of the User. Add a Create New User link to the base.html sidebar mock-up.

Fix off-by-one corner case discovered during testing of /user/profile.

Added getSingleIndexedParamValue() that retrieves an index into a list of values from the named query parameter, and then indexes into the supplied list of values to return the corresponding value from the list. Used to convert numeric index query parameters passed by POST to the GET redirect target, so that the GET code can display messages, etc. (without passing the message itself as a query argument and having to escape it or have silly people pass in their own...).

Added replaceSuffix(), isReferrerSelf(), and redirectToChangedSuffix() to implement the TODO in the User profile views where the link name portion of the URL needs to change when the link_name Property is updated by the form.

Fixed too long lines and deleted unused imports in id_user.py.

New default values for page title, header title and body of site home page.

Documentation updates and one typo fix.

Add a td.formfielderrorlabel style, to highlight field labels that have errors.

Swap field value and "required" columns to make more columns for field errors.

Add a verbose_name and help_text to the User.id Property.

Explain why pushd and popd are needed when making tiny_mce.zip.

Use zip to compress tiny_mce, and use zipserve to serve it in Google App Engine.

Updated make_release.sh docs and added way for person invoking the script to override script variables such as RELEASE using something like "RELEASE=../testing_release ./make_release.sh".

Add recently-moved feedparser and tiny_mce to APP_DIRS.

Oops, this should have been part of the r580 commit.

Oops, this should have been part of the r577 commit.

Move third-party TinyMCE out of soc/content/js and into the application image root, like other third-party code. Update the app.yaml.template to add /tiny_mce as a source of static content.

Add README files to explain how third-party code is maintained in these directories.

Discourage third-party code from being embedded in the soc framework.

Move third-party feedparser.py out of the soc framework package into its own package (similar to django).

Changed ZIPFILE variable to DJANGO_ZIPFILE in make_release.sh script and added 'cd $APP_FOLDER' before we zip django.

Load ../google_appengine into trunk/thirdparty/google_appengine.

upload.py customized to work with codereviews.googleopensourceprograms.com.

Pristine initial commit of upload.py script from http://code.google.com/p/rietveld (r310).

gcl.py customized to work with codereviews.googleopensourceprograms.com and the melange-soc-dev@googlegroups.com mailing list.

Pristine initial commit of gcl.py script from chromium.org.

Release shell script and associated changes. Set svn:ignore property on /app/django.zip file and /release folder. Patch by: Pawel Solyga, Augie Fackler Review by: Todd Larsen, review-after-commit Review issue: 363 Review URL: http://codereviews.googleopensourceprograms.com/363

FIxed documentation in soc/logic/document.py for getDocumentFromPath function Patch by: Christian López Espínol Reviewed by: Pawel Solyga Reviewed via: discussion on melange-soc-dev group

Forgot to change widgets to custom_widgets import in home.py after changing the name of soc/views/helpers/widgets.py file.

Added Melange front page edit view where you can change title, content, feed url. Created SiteSettings and Document models and some logic for them. Added isFeedURLValid function in soc/logic/feed.py. Created some functions for handling datastore updates of different kinds of Models (soc/logic/model.py). Fixed some typos and too long lines of code. Patch by: Pawel Solyga Review by: to-be-reviewed

Added feedparser to soc/utils and modified svn:externals for vendor to include feedparser svn Patch by: Pawel Solyga Review by: to-be-reviewed

Add getAltResponseIfNotLoggedIn() and getAltResponseIfNotDeveloper() simple view helpers. These cannot go into response_helpers.py because they create a circular reference with simple.py, and Django view import fails. Review URL: http://codereviews.googleopensourceprograms.com/602

Improve the __doc__ string of isIdDeveloper() to explain better how it now functions.

Make isIdDeveloper() also able to check an is_developer Boolean property in User entities. Review URL: http://codereviews.googleopensourceprograms.com/601

Replace checkLinkNameForId() with isLinkNameAvailableForId(), and implement that new function in terms of only the existing doesLinkNameExist() and doesLinkNameBelongToId(). Patch by: Todd Larsen Review by: Pawel Solyga Review via: discussion of patches on melange-soc-dev mailing list

Fixed one typo in response_helpers which caused is_admin context variable not to work correctly. Created new checkLinkNameForId function that checks if link_name is correct when creating new user and modifying existing one. This is now used for validation instead of doesLinkNameBelongToId in UserForm clean_link_name function. The previous validation function didn't allow to create new users and modify linkname of existing ones. Additionally I created new doesLinkNameExist helper function.

Fixed wrong user variable in lookup.html template for edit link (was user should be found_user). There is no DeveloperForm in site/user/profile.py changed that to LookupForm.

gcl.py committed this file, when it should not have even existed.

Add a /site/user/lookup view that provides Developers with a form to look up User entities given email addresses or link names.

...

Updated the script to: * Include a comment describing what it does * Use variables for anything non-standard * Use the --parse-only flag of epydoc * Exclude all 'django' modules through --exclude= * Run on '../app' by default, no more arguments needed * Clean up the output directory before running

Bugfix, invalid syntax noticed by epydoc.

Updated docs in response_helpers. Patch by: Pawel Solyga Review by: to-be-reviewed

Created custom_widgets.py and added TinyMCE django widget that can be later used for particular form fields. Patch by: Pawel Solyga Review by: to-be-reviewed

Added TinyMCE to Melange in soc/content/js Patch by: Pawel Solyga Review by: to-be-reviewed

An emerging pattern with makeSiblingTemplatesList() is that views calling that function then append a known, default template "just in case". This change adds a default_template parameter to makeSiblingTemplatesList() to eliminate the extra "append a known default to the end" step for the caller. Patch by: Todd Larsen Review by: to-be-reviewed

Refactor soc/views/user/profile.py to make use of several of the new views available in soc/views/simple.py. Patch by: Todd Larsen Review by: to-be-reviewed

Fix an overlooked cut-and-paste error. Patch by: Todd Larsen Review by: to-be-reviewed

Add a public() convenience wrapper around templateWithLinkName() for the common public.html case. Add a requestLogin() view. Patch by: Todd Larsen Review by: to-be-reviewed

This CSS change belonged with soc/templates/soc/error.html committed in r454. Patch by: Todd Larsen Review by: to-be-reviewed

A default error.html template to go with the simple.errorResponse() view. Patch by: Todd Larsen Review by: to-be-reviewed

Add soc.views.simple containing (initially) two simple template views. templateWithLinkName() is a view that can replace most public() read-only views. errorResponse() is a view that renders an error page for out_of_band.ErrorResponse exceptions. Also, change response_helpers.respond() to accept keyword arguments to pass to http.HttpResponse(). (errorResponse() makes use of this new respond() feature.) Patch by: Todd Larsen Review by: to-be-reviewed

Clean up User Model and User profile edit view now that soc.logic.site.id_user module exists. Change usage of "user" to be "id" the variable refers to a Google Account and not a User entity. Patch by: Todd Larsen Review by: to-be-reviewed

Pawel and I were working on the same thing, apparently. My template_helpers.py is more complete, so I am removing this one (that Pawel appears to not have used yet). Patch by: Todd Larsen Review by: to-be-reviewed

Factor out a getUniversalContext() function so that views that do not call response_helpers.response() can benefit from the code that constructs shared template context variables common to many templates. Patch by: Todd Larsen Review by: to-be-reviewed

Create a package for controller modules that interact with User entities. Patch by: Todd Larsen Review by: to-be-reviewed

A collection of functions for determining the characteristics of the "system" on which a Melange application is running. Currently, this consists of only a boolean isDebug() function. Patch by: Todd Larsen Review by: to-be-reviewed

Helpers for manipulating templates and template search paths. Patch by: Todd Larsen Review by: to-be-reviewed

Consolidate functions dealing with Google Accounts and look-up of User entities into a single site-wide controller module. Tests will be added in a subsequent commit as soon as Google App Engine tests using mocker are figured out. Patch by: Todd Larsen Review by: to-be-reviewed

Exception classes used by controller logic to request an "out-of-band" response be displayed by the view instead of what the view would normally display. Patch by: Todd Larsen Review by: to-be-reviewed

Base classes for all Datastore Models in Melange. Patch by: Todd Larsen Review by: to-be-reviewed

Load ../../google_appengine into trunk/thirdparty/google_appengine.

Create directories to load project into. * trunk/thirdparty/google_appengine: New directory.

Move third-party code that is not required to be part of trunk/app into a trunk/thirdparty "sandbox". Patch by: Todd Larsen Review by: to-be-reviewed

Move third-party code that is not required to be part of trunk/app into a trunk/thirdparty "sandbox". Patch by: Todd Larsen Review by: to-be-reviewed

Remove the obsolete scripts left over from when trunk/app did not contain the entire Google App Engine image. Patch by: Todd Larsen Review by: to-be-reviewed

Add mocker 0.10.1 to trunk/thirdparty, so that it can be used to create mocks for testing the Google App Engine app itself. See also: http://blog.appenginefan.com/2008/06/unit-tests-for-google-app-engine-apps.html Patch by: Todd Larsen Review by: to-be-reviewed

Move LICENSE.django closer to the actual trumk/app/django code we are importing (that exists in trunk/app to be part of the Google App Engine image). LICENSE.django cannot go in trunk/app/django itself, because that directory is maintained from the /vendor/django svn external using svn_load_dirs.pl (so putting all the way into trunk/app/django gets it repeatedly removed). Patch by: Todd Larsen Review by: to-be-reviewed

Third-party packages that do not need to be part of trunk/app (because they are not part of a Google App Engine image upload).

Since google_appengine isn't part of the uploaded trunk/app, there is no reason why it couldn't be in a thirdparty directory, alongside mocker.

Create directories to load project into. * trunk/google_appengine: New directory.

Added public view support (not using controller yet) Changed Google Account variable from user to id in views and templates (no more confusions with Melange user). Added templates_helpers for makeSimblingTemplate function. Addded new template tag readonly_field_as_table_row used in public views Fixed one typo in roles.py

User Profile view (without controller yet). Patch by: Pawel Solyga Review by: Todd Larsen Review issue: 386 Review URL: http://codereviews.googleopensourceprograms.com/386

Moved Proposal model from wiki to source code and updated ProposalModel wiki page. Patch by: Pawel Solyga Review by: Todd Larsen Review issue: 362 Review URL: http://codereviews.googleopensourceprograms.com/362

Moved td.formfieldlabel to FORM TABLE FIELDS section.

Move soc/control to soc/logic, so that tab-completion doesn't keep matching soc/content instead.

nickname was moved from Person to User recently.

Add Roles template directory that was missing from r426 commit.

Create package for up-coming Role views.

Minor indentation fix.

Create package for standard Melange controller modules.

Reduce the indent to two spaces per hierarchy level, comment some groups of tags that are related, move #header down by #footer.