Update comments in models/group.py (changed Optional to Required). Add verbose_name to founder property in Group model. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix bug that caused Lookup user by User Account not to work properly. Basically wrong parameter to models.user.logic.getFromFields(). Patch by: Pawel Solyga Review by: to-be-reviewed

Add deleted in r732 (don't know why) functionality that displays custom Error page when linkname in Developer User Profile url doesn't exist (/site/user/profile/<not_existing_linkname>). Patch by: Pawel Solyga Review by: to-be-reviewed

Add underscore in two word div class names in templates (nick_name, short_name, partial_path). Patch by: Pawel Solyga Review by: to-be-reviewed

Add is_featured boolean property to the Work model, so that Works can be designated as "featured" items in various places in the UI. This will be used to allow Sponsors, Programs, and Organizations to select Documents that should be included in their sidebar menus. Perhaps featured "site" Documents, such as site-wide Terms of Service, should probably be listed below the "User (sign-out)" menu, since the User will have to read and agree to these before being allowed to use the site. A collapsable Javascript sidebar is probably going to be needed soon... Patch by: Todd Larsen Review by: to-be-reviewed

Add missing blank lines, clean up the doc string and remove white spaces at the end of the lines in reflistprop. Patch by: Pawel Solyga Review by: to-be-reviewed

Move <div id='notice'> into notice block in base.html template. Change formatting of notice block to make it much easier to "parse" visually. This patch is based on comments to r722. http://code.google.com/p/soc/source/detail?r=722 Patch by: Pawel Solyga Review by: to-be-reviewed

Add a third-party ReferenceListProperty class. This is going to be used to contain the references to Questions that make up a Quiz. Patch by: Todd Larsen Review by: to-be-reviewed

Fix some defects for lookup user view. More information about the patch can be found under the link below. http://groups.google.com/group/melange-soc-dev/browse_thread/thread/5d378c8d3679945f/d1e7cc3a53adda4e Patch by: Chen Lunpeng Review by: Pawel Solyga

Add missing import in soc/views/site/sponsor/list.py which caused exception when app was deployed and first site you visited was "List Site Sponsors". Update files according to recent django update and django backwards incompatibility (for example newforms is changed to forms). Patch by: Pawel Solyga Review by: to-be-reviewed

Load ../vendor/django into trunk/app/django.

Fixed imports sorting based on comments for r751. http://code.google.com/p/soc/source/detail?r=751 Patch by: Pawel Solyga Review by: to-be-reviewed

Some indentations fixes. Changed all the email=id function arguments to email=id.email(). Patch by: Pawel Solyga Review by: to-be-reviewed

Some indentations fixes and ugettext_lazy() wrap up for DEF_DEV_LOGOUT_LOGIN_MSG_FMT in access.py. Patch by: Pawel Solyga Review by: to-be-reviewed

Rename soc/logic/models/settings.py to model site_settings.py and apply import name change to soc/views/site/home.py Patch by: Pawel Solyga Review by: to-be-reviewed

Fix typos in doc string in sponsor.py and settings.py Patch by: Pawel Solyga Review by: to-be-reviewed

Remove spaces between dict key name and colon. Fix some typos based on comments http://code.google.com/p/soc/source/detail?r=739. Patch by: Pawel Solyga Review by: to-be-reviewed

Add missing blank lines between imports and sort all of the imports. Patch by: Pawel Solyga Review by: to-be-reviewed

Add missing blank lines between imports in access.py module. Patch by: Pawel Solyga Review by: to-be-reviewed

Rearrange imports in home.py so they apply to new discussed format (separate "from ..." and "import ..." blocks). Add Delete Document functionality. Patch by: Pawel Solyga Review by: to-be-reviewed

Bugfixes to the latest revision Some pages did not work due to missing imports, or wrongly imported modules. Patch by: Chen Lunpeng Reviewd by: Sverre Rabbelier

Added missing models/__init__.py and removed empty logic/model directory Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Dictionaries need String values for keys The cleanup patch earlier mistakenly used raw names as keys to the dictionary (such as one would do in a function call). This fixes that mistake. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Removed now-obsolete code from model.py and __init__.py Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Made the existing code use the new soc.logic.models Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Added invididual model logic files Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Also removed helper directory Which somehow did not get removed with the last commit Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Removed obsolete logic directories and added one for model The model/ directory will contain the Base logic classes. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Minor style and import fixes Incorperated changes as suggested by Todd and Pawel. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Missing changes to soc.views.helper.access Due to having to manually do the 'svn mv' of logic to helper, the changes to access.py got lost, this commit fixes that. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Moved soc/logic/helper/access to soc/views/helper/access Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Fix not working delete Sponsor functionality after recent commit. Add delete() method to Base class. Make soc.views.site.sponsor.delete() request handler use this method. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix not working isIdDeveloper() function after recent commit. There is still confusion within getFormFields method (email is not id), but this change doesn't address that problem. Patch by: Pawel Solyga Review by: to-be-reviewed

Changed location of the svn command in svn_load_dirs.pl script from '/usr/bin/svn' to 'svn'. That makes the script more universal and it should work on Linux, Windows and Mac OS X if the svn is in the PATH. Patch by: Pawel Solyga Review by: to-be-reviewed

Refactor nearly all the soc.logic code to use the Base class Instead of having a lot of duplicate code, this patch aims to reduce this duplication by introducing a Base abstraction. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Replace almost all occurences of linkname with link_name In an attempt to have some atomicness in these commits this patch does a rename for the sake of consistency. Not all were changed, but the next commit will address that. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Load /Users/solydzajs/Downloads/google_appengine/ into trunk/thirdparty/google_appengine.

Add missing __init__.py to soc/logic/helper folder (Caused home page not to work).

Removed now-obsolete getAltResponse* methods from simple.py The getAltResponse* methods have been replaced by the check* methods in soc.logic.helper.access. Patch by: Sverre Rabbelier Reviewed by: Pawel Solyga, Augie Fackler, Todd Larsen Reviewed at: http://codereviews.googleopensourceprograms.com/1601 Review id: 1601

Refactor existing code to use the new access module Instead of ending up with many different ways to do access control, we end up having only one centralized place wher access control is done. Patch by: Sverre Rabbelier Reviewed by: Pawel Solyga, Augie Fackler, Todd Larsen Reviewed at: http://codereviews.googleopensourceprograms.com/1601 Review id: 1601

Add an access control module The module's purpose is to check access requirements, (such as being logged in), and raise an exception containing a authentication request when the requirement is not met. Patch by: Sverre Rabbelier Reviewed by: Pawel Solyga, Augie Fackler, Todd Larsen Reviewed at: http://codereviews.googleopensourceprograms.com/1601 Review id: 1601

Enable recently commited delete Sponsor request handler (added to map.py) and Delete button in Sponsor edit view. Still missing "Are you sure ?" question box. Patch by: Pawel Solyga Review by: to-be-reviewed

Create a submit_buttons blocks in all edit view templates and put submit buttons in separate html table (not as part of the fields table anymore). Patch by: Pawel Solyga Review by: to-be-reviewed

Create a submit_buttons block in group edit profile template so that submit buttons can be customized. Replace submit_message usage with new notice block (still work in progress in Lookup User views). Add customized edit profile template for Sponsor with delete button (not used yet, upcoming commit). Add delete Sponsor request handler. Patch by: Pawel Solyga Review by: to-be-reviewed

Add notification bar block in base.html template. Patch by: Pawel Solyga Review by: to-be-reviewed

Add #notice class declaration in soc.css for upcoming notification bar. Patch by: Pawel Solyga Review by: to-be-reviewed

Update indexes in index.yaml file. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix typo in getSponsorFromLinkName (key_name variable name instead of sponsor_key_name). Add deleteSponsor function for deleting Sponsor entities from datastore.

Style fix, as requested by Todd to dict usage Use "dict['key'] = value" instead of "dict.update({'key' : 'value'})" when updating only one key.

Call soc.logic.site.map.getDjangoUrlPatterns() to construct the urlpatterns from the site map, rather than explicitly listing them in app/urls.py. Patch by: Todd Larsen Review by: to-be-reviewed

Update soc/logic/site/sidebar.py to use parts of the "site map" in soc/logic/site/map.py to generate portions of the sidebar menu. Patch by: Todd Larsen Review by: to-be-reviewed

A site layout ("site map") of the web application, including URL regular expression patterns, Django views, and metadata for constructing sidebar menus and (eventually) breadcrumbs. One function, soc.logic.site.map.getDjangoUrlPatterns(), converts these details into urlpatterns for use by Django. Patch by: Todd Larsen Review by: to-be-reviewed

Url and Page classes used to encapsulate the "site map" information (URL regular expressions, Django views, menu item names, etc.) and the relation between pages in the site map. There are still lots of TODOs in this first pass. Patch by: Todd Larsen Review by: to-be-reviewed

urllib.quote() is needed by the soc/logic/site/map.py work, so import it from the Python 2.5.2 sources. The entire urllib.py is not supported by Google App Engine (yet?), since it relies on 'import socket' (App Engine provides a separate urlfetch module instead). Patch by: Todd Larsen Review by: to-be-reviewed

Remove now-empty soc/views/helpers (everything has moved to soc/views/helper). Patch by: Todd Larsen Review by: to-be-reviewed

Add create() wrapper views that simply call the existing edit() views, to produce unique view names in preparation for the soc/logic/site/map.py code. Patch by: Todd Larsen Review by: to-be-reviewed

Speed up average case by appending remainder of original choices list unchanged (avoiding remaining str -> int type conversions) once the insertion point is found. Patch by: Todd Larsen Review by: to-be-reviewed

Move helpers/html_menu.py to helper/html_menu.py, to clear out soc/views/helpers for deletion. Patch by: Todd Larsen Review by: to-be-reviewed

A specialized SortedDict used by soc/logic/site/page.py. Patch by: Todd Larsen Review by: to-be-reviewed

Move helpers/forms_helpers.py to helper/forms.py. Patch by: Todd Larsen Review by: to-be-reviewed

Move helpers/templatetags to helper/templatetags. Patch by: Todd Larsen Review by: to-be-reviewed

Move helpers/response_helpers.py to helper/responses.py. Patch by: Todd Larsen Review by: to-be-reviewed

Replace helpers/custom_widgets.py with helper/widgets.py. Patch by: Todd Larsen Review by: to-be-reviewed

Move helpers/template_helpers.py to helper/templates.py. Patch by: Todd Larsen Review by: to-be-reviewed

Move helpers/request.py to helper/requests.py to avoid conflict with common local variable name "request". Patch by: Todd Larsen Review by: to-be-reviewed

Move helpers/list.py to helper/lists.py to avoid conflict with built-in type name "list". Patch by: Todd Larsen Review by: to-be-reviewed

Replace soc/views/helpers/request_helpers with soc/views/helpers/request.py and replace uses of request_helpers. with helpers.request. instead. Patch by: Todd Larsen Review by: to-be-reviewed

Move soc/views/helpers/list_helpers.py to soc/views/helpers/list.py and change uses from list_helpers. to helpers.list. instead. Patch by: Todd Larsen Review by: to-be-reviewed

List views should have a selectable pagination "page" length: http://code.google.com/p/soc/issues/detail?id=59 Patch by: Chen Lunpeng and Todd Larsen Review by: Augie Fackler Review URL: http://codereviews.googleopensourceprograms.com/1201

Change to imports to follow the style guide: http://code.google.com/p/soc/wiki/PythonStyleGuide#Module_and_package_imports Specifically: "Use from x import y only when x is a package and y is a module."

Make findNearestUsers() code in soc/logic/site/id_user.py more generic and move it to soc/logic/model.py. Orginal findNearest...() functions in id_user.py are now convenience wrappers. Add typed-query string construction functions to model.py. Move getFulLClassName() from key_name.py model.py, since it has more to do with Model types than key names. Swap 'offset' and 'limit' and make 'limit' arguments non-optional. Also, stop adding 1 inside the ...ForLimitAndOffset() functions and make the callers do it (since it was being added for a very UI-specific reason of whether or not to display a "Next>" link). Patch by: Todd Larsen Review by: Pawel Solyga Review URL: http://codereviews.googleopensourceprograms.com/1401

Factor out an isIdAvailable() function from EditForm.clean_id() in soc/views/site/user/profile.py and add it to soc/logic/site/id_user.py. Addresses some comments on r614. Patch by: Todd Larsen Review by: Pawel Solyga Review URL: http://codereviews.googleopensourceprograms.com/1202

Add Allen (Chen Lunpeng) to trunk/AUTHORS, due to his several recent patches.

Fix typo in recent validate.py changes (r682). Patch by: Chen Lunpeng Review by: Todd Larsen

Add basic Sponsors List, Create New Sponsor, Sponsor Public Profile views. Change all properties in Group model as required for now. Remaining TODO: write validation functions for Sponsor edit and create form fields that need additional validation (like address, phone number format). Patch by: Pawel Solyga Review by: to-be-reviewed

Add Sponsor logic functions. Patch by: Pawel Solyga Review by: to-be-reviewed

Add group templates that can be used by Sponsor, Organization, School, Club views. Right now only upcoming commit of Sponsor views is using it. Patch by: Pawel Solyga Review by: to-be-reviewed

Remove excluded field inheritance_line, since the User model does not inherit from PolyModel (at this time).

Add colon at the of _readonly_field_as_table_row template tag label parameter. Replace hardcoded labels in User Public profile template with linkname_user.fields.<field_name>.label values.

Fix missing blank line to follow PythonStyleGuide in model.py.

Add links in sidebar for upcoming Sponsor views. Patch by: Pawel Solyga Review by: to-be-reviewed

Change key_name module usage to path_linkname module (fix to previous commit). Add comments about urls. Add Sponsor views urls for upcoming Sponsor views modules. Patch by: Pawel Solyga Review by: to-be-reviewed

Move path and link_name related functions and regex patterns to a new soc/logic/path_linkname.py module, and fix all dependencies. path/link_name functionality is becoming the generic way to identify entities in the Datastore in a URL-compatible way.

Make form field components use a smaller font, without shrinking the font of all text in the page body.

Replace common module with validate module. Move validation function from feed module to validate module and remove feed.py. Correct any usage of validation functions from common and feed modules into validate module. Patch by: Pawel Solyga Review by: to-be-reviewed

Add missing blank line to follow PythonStyleGuide in document.py

Fixed typo in DEF_CREATE_NEW_DOC_MSG.

Shrink the sidebar menu separately from the main body text.

Moved isLinkNameFormatValid function out of id_user module to new common module. This function is going to be used by other form validation functions that require to validate linkname (different kind of Groups, Programs etc). Patch by: Pawel Solyga Review by: to-be-reviewed

Fixed models based on output from graph.py script and comments on http://groups.google.com/group/melange-soc-dev/browse_thread/thread/fb532a7db1f19ea7

Tool to graph the data model.

Some TODOs on access control that I didn't want to forget.

Matching just /docs created a very small namespace, since any other path parts would match the Document path. So, append /show after /docs for the display view. This makes other views like /docs/edit possible later.

URL pattern changes that were missed by r671.

Some styles used by r671, the simplistic Document view.

A very simplistic Document viewer.

Implements a Site (Developer) generic Document editor form.

Changes to make breadcrumbs match page title. This is mostly to see how it looks, since the new soc/logic/site/map.py code is going to implement the breadcrumbs and page title contents in a similar way.

Start using "Site" instead of "Developer" in the UI.

Implement a Developer list view of all Documents. Patch by: Todd Larsen Review by: to-be-reviewed

Add missing all() __doc__ string comments: "Args:" and "Returns:" sections.

Fix some style guide issues: keyword arguments are supposed to always be supplied using the keyword argument name=value. http://code.google.com/p/soc/wiki/PythonStyleGuide#Default_Argument_Values

Directory for up-coming /site/docs/list and /site/docs/edit templates.

Fix typo in findNearestUsersOffset() __doc__ string missed in r661.

Show link to /site/user/list on /site/user/lookup when User is not found. http://code.google.com/p/soc/issues/detail?id=61 Patch by: Chen Lunpeng Review by: Todd Larsen (with modifications)

Add placeholder for future (to-be-implemented) getPreferredListPagination() function.

Remove a TODO that should have been removed for r658.

Update some of the URL patterns to get their link_name parsing from the new patterns in key_name.py. (Using it like this in urls.py is why key_name.py needs to not depend on other modules...)

Add functions to soc/logic/document.py for dealing with partial_paths combined with link_names. Add getWorksForOffsetAndLimit() to query for Documents for the /site/docs/list view.

Hide PolyModel inheritance_line bookkeeping property from the User Profile form.

Use the LINKNAME_PATTERN from its new home in key_name.py. Also, add some missing blank lines that are required by the style guide.

Add lots of new functions to key_name.py, including path/link_name processing. Copy various link_name related regex patterns to key_name.py and use them. Add error checking that raises a key_name.Error exception when name...() functions are given empty arguments. Hard-code class names, since they match what was typed into the module.class.__name__ to get the name anyway. This eliminates dependencies on any modules by key_name.py.

Add sidebar menu items for /site/docs/list and /site/docs/edit. They do not currently have view functions attached, but there are other links in the mock-up portion of the sidebar that don't currently work, either. The goal is to commit the /site/docs/list and /site/docs/edit changes in small bits that don't break anyone else.

Add partial_path property explicitly to the Work model.

Should have been part of the r650 commit.

Directory for upcoming /site/docs views.

Add "Last updated" footer to front page body text, using the modified Property from the Work entity.

Change _readonly_field_as_table_row <td> tag class names to match those used in _field_as_table_row. That should actually go into previous commit. Patch by: Pawel Solyga Review by: to-be-reviewed

Clean up too long lines in profile.py. Add ReadOnlyInput widget to custom_widgets module, it can be used to display read-only form fields. Display read-only "Id" field in LookUp view if user has been found and in User Edit Developer view. Patch by: Pawel Solyga Review by: to-be-reviewed

Add polymodel folder to DEFAULT_APP_DIRS variable in make_release.sh script.