Set new Melange version number to 0-5-20091102 in app.yaml.template.

Minor (mostly stylish and whitespace) fixes in GHOP access.py module. Also missing authors added to some files.

Multiple choice nonrequired questions now accept empty answers. The change is mostly concerned with issue 674, probably fixing it.

checkIsHostForProgram fixes: logic argument has default value and is actually used to look up for a program entity,

checkIsHostForProgram function takes a new 'logic' argument. It determines which logic should be used to look up for program entity. If the argument is not given, the standard program_logic will be used.

If checkCanOrgAdminOrMentorEdit function does not find a task, the user is redirected to 404 page.

Script to run JSLint over JS files to check JS code quality. This script will run JSLint over all files in app/soc/content/js directory and subdirectories to check JS code guidelines compliance.

JSON2 utilities now loaded by default. This library is needed for melange general JS utilities package to work properly and parse melangeContext and melangeConfig JSON attributes.

Module Conversion also changes the RankerRoots associated with an Organization.

Now showing the message contained in Requests on the correct pages. Note that facilities to edit your message, and to perhaps change the message when accepting a request still need to be provided. Fixes Issue 385.

Process invite page now shows the right Role name in the page name.

Request lists now show display name as well as the link id. Fixes Issue 375.

The work_submission model's update now reflected in views and logic. Model for work_submission was modified during GHOP code integration but was not reflected in views and logic. This commit fixes it. Fixes Issue 700. Reviewd by: Lennard de Rijk

Whitespace fix in settings.py and added missing authors to a few files.

Changed the access checks in the GSoC module to match the new checks.

Removed the now obsolete Request helper module.

Edited the necessary access checks for all the Role views in Core and GHOP. Also removed unneccessary use of _acceptInvitePost.

Made changes to the Role View to facilitate the use of the ID-based Requests.

Redone the access checks to work with the new Request model. Also includes some whitespace fixes to the access model.

Removed now unused method from Role Logic.

Redone the notifications to work with the new Request model. Note that it might be necessary to introduce a templatetag that translates a internal role_name to a real verbose name. However this will do fine for now.

Reworked the redirects to work with the new Request model. Also made use of the collection of Role Views in the Role View in combination with the role property in the Request model, to facilitate the redirects.

Redone the request View to work with the new model. Also added a TODO to fix editing your Request message.

Redone the request templates to work with the new ID-based request. Changes here also include upcoming View changes.

Made Request Logic ID-based and added some helper methods.

Redone the Request object to contain a message property and work on ID-basis.

Add a redirectLegacyRequest response

fix typo in reponses.py

GSoC Views

Script to run JSDocToolkit over our JS files. It creates a documentation directory under app/soc/content/js with the output for private and public docs, with or without undocumented functions.

JSDocToolkit 2.3.0 added to create documentation for JS files.

Integration of general Melange JS utilities in base template.

General JavaScript utilities for melange. This script is going to be the core of Melange JS. It provides a melange namespace and general utilies for logging, loading of google api, common errors, base class for templates that reads context from a script tag attribute. It also reads general options from its script tag.

Once a task has been approved it can no longer be unapproved. Patch by: Madhusudan C.S. and Lennard de Rijk

Fixes issue 697.

Use skipFields method in the expando base logic.

Minor typographical errors fixed.

Whitespaces fixed in task view.

When a task is edited, 'modified_by' field is not cleared any more. Fix for issue 692.

Changed checkCanMakeRequestToGroup to use Logic instance instead of module. This method now also directly queries for the keyname of the group. Also some whitespace fixes in the access module.

Update Google App Engine from 1.2.5 to 1.2.7 in thirdparty folder.

Disabled GHOP module. Oopsie in ra223fff4cc.

Added logic paramters to two access checks. This is necessary because the GHOP module needs the same checks with other logics.

Set the Mentors list to the user that is suggesting a Task.

Fixed access check and seed for Task Suggest page. Fixes Issue 694. Reviewed by: Lennard de Rijk

Removed query wether or not the current user was ever an org admin. This is because it makes no sense to not show the approve this task button if th is task was suggested by an org admin. The suggest page is there for a reason fo staging tasks anyway. Also added TODO to let the mentor's suggest page redirect to the normal edit pag e after a task has been suggested. This is more natural since the task lists als o redirects to this page for unapproved tasks and the normal edit page also has the capability to hide fields determined by the user's access.

Fixed the TimelineConversionUpdate to also update the GSoCProgram.

Use scope_path for updating Documents since scope was never properly set.

Renamed runGradingProjectSurveyRecordsUpdate to match style of module.

Fixed error in the runDocumentUpdate where the wrong keyname was used.

Added GradingSurveyGroup update to the Module Conversion.

Fixed bug in StudentProposal update when a StudentProposal had no Mentor.

Fixed module conversion imports.

Fix typographical error and changes in status messages for Task workflow. Reviewed by: Lennard de Rijk

Separated the publish and approve button on the Task list page for Org members. Also ensured that only tasks from the right org with the right status can be changed. And that we do not make unneccesary loops over values in the POST dict by grouping all the keys in the POST data under "task_id". The list entries also no longer redirect a user when clicking on the checkbox. Patch by: Madhusudan.C.S and Lennard de Rijk

Add function for CSV export of survey records for a given survey.

Add functions for CSV export of organizations and roles. Those CSV exports are used to create Google Code GSoC projects at the end of the program for students code submissions.

Add StudentProposal conversion update

Added tag v0-5-20091004 for changeset 51eeb0c4317e

Set new Melange version number to 0-5-20091004 in app.yaml.template.

Add Timeline conversion update

Add update for Documents

Added update for SurveyRecords Both ProjectSurveyRecords and GradingProjectSurveyRecords are converted to updated with their new GSoC references.

Added update for Surveys, ProjectSurveys and ProjectGradingSurveys.

Added StudentProject update to the Module Conversion updates.

Added Review module conversion update. In which we'll phase out the reviewer property from Review.

Removed obsolete value to unpack in the updateGHOPTask Task.

Also pass along the args when running an update.

GHOP Comments do not need to be created by a User. We also have "system" messages.

Fix the deadline counter to start counting only after Task claim is accepted. Deadline counter used to start when the task was claimed to be requested. This commit fixes that.

Only set new properties outside the "properties" loop for the ModuleConversion.

Add the Student to GSoCStudent conversion, Also fix the import sorting.

Only store all the entities once in the ModuleConversion, after the for loop.

Add OrgAdmin and Mentor to GSoCOrgadmin and GSoCMentor updates.

Added the Organization to GSoCOrganzation update.

Use the iterative task iterator for the ProgramConversion update.

Changed the working of the iterative_task decorator. The decorator now needs the logic for the model which it fetches. This is much nicer then "fetching" it using import. Also order has been removed since it has no use when iterating over all entities when key is involved. Fields to filter can now dynamically be set by the function that is wrapped. Note that it will merge the filter with the task_default kwarg and it will only use the start_key if their is no key present in the context. Also note that task_default gathers all kwargs. I tried to do it otherwise (with default kwargs) but I couldn't get it to work. Feel free to improve :).

Removed order property in the getBatchOfData. This ordering is not possible since you want to go over the entities in order oftheir key and ordering them would prohibit this from happening properly.

Removed the debug logging line from the Task decorator. Also make use of the next_start_key as name for the new starting key.

Made getBatchOfData use start_key instead of next_key.

Fixed use of wrong dictionary key in Task Decorators.

Moved the Tasks decorators to their own module.

Make batch size a param to getBatchOfData

Added tag v0-5-20090928 for changeset db28a7db5cc6

Set new Melange version number to 0-5-20090928 in app.yaml.template.

Merging test back in

Fixed whitespace in base model.

Move soc.logic.tasks to soc.tasks.responses

I hate how Hg handles unsynched remote changes

Add task and iterative_task decorator Also add getBatchOfData method to the base logic and tasks logic module. Reviewed-by: Sverre Rabbelier

Fixed Task public view to always call the update method. Also removed an obsolete value ws_entity that could not be unpacked (therefore causing 505's).

Add task and iterative_task decorator Also add getBatchOfData method to the base logic and tasks logic module. Reviewed-by: Sverre Rabbelier

Fixed GHOP Task Logic's updateEntityProperties. This method now properly calls the supermethod and also uses the right keyword argument (silent instead of siltent).

Fixes the problem of GHOP Task editing after it is created.

Style fix in soc.views.models.request module.

Add missing blank line in soc.modules.gsoc.logic.models.student module.

Add missing blank line in soc.models.survey_record module.

Fix whitespace in pylint disable-msg comment in soc.views.models.student_project module.

Added first version of the 1st step in the module conversion process.

Style fixes in seed_db module.

Style fix in soc.views.helper.redirects module.

Fix indentions in student_project view module.

Corrected an import in the student_school_type update module.

Prevent modification of key fields Only non-id-based entities are affected as id-based entities do not have any un-modificable fields.

Add a script to generate a kml file with all active GSoC participants Only the students, mentors, and organization admins that are 'active' are exported. Students that do not have a project are not exported. Reviewed-by: Sverre Rabbelier

Added tag v0-5-20090922 for changeset 06f4fe351977

Set new Melange version number to 0-5-20090922 in app.yaml.template.

Renamed timeline entry in GHOP Timeline to match style of the timeline.

Fixed a typo in getRightsChecker docstring

Throw an exception when registering an already registered right

Convert cleaning module to use the new checker in core

Use ',' instead of ':' in function call

Remove ghop related liens from soc_core callback

Fixed unknown variable in GHOP Access checker. Fixes Issue 691.

Enable document system for GHOP As can be seen from the changes outside app/soc/modules, there is still some work to be done to make the modules fully restricted to configuration changes and code in app/soc/modules. Reviewed-by: Sverre Rabbelier

Use the new rights code in core

Add document rights registration to core

Move around Core methods into more relevant sections

Use getOrCreateTaskSubscriptionForTask in the TaskSubscription View.

Added getOrCreateTaskSubscriptionForTask to TaskSubscription Logic.

Added listing of all Accepted GHOPOrganizations to the Program View. Reviewed by: Lennard de Rijk

ret_list keyword argument is added to tags_strings method to enable returning lists also instead of strings.

Added index to sort GHOPOrganizations per program by their name. Reviewed by: Lennard de Rijk

Added a templatetag for table field to show date in ordinal fashion.

Added missing argument to org_app View access check.

Added GHOP views helper to INSTALLED_APPS in django settings.py. Adding this path to INSTALLED_APPS enables GHOP specific templatetags that resides in this path.

Added apply_mentor view to GHOPOrganization view.

Added 2 missing views to the GHOPOrganization View.

Fixed error in mentor field cleaning, the list of mentors was never resolved.

Removed undefined order argument in GHOP Task View.

Bron paper bag fix, should have been part of ref809d10aa.

Fixed error occuring when tags list was empty in GHOPProgram edit View.

Map JS renamed because of latest changes.

Shrinksafe complains during compression of map JS fixed. It comes that "long" can't be used as a variable name as we did, because Shrinksafe complains that "long" is a reserved keyword.

Shrinksafe script fixed to workaround Linux vs BSD stat packages. Under MacOSX (BSD) the format for stat needs "-f" switch, while under Linux stat needs "-c". Changed to use ls and awk, which seem to be cross compatible.

Added program_logic parameter to checkCanEditTimeline access check and corresponding changes in timeline views. Reviewed by: Lennard de Rijk

Removed slots and apps_tasks_limit from extra_dynaexclude in params and added a getExtraMenus entry to callback for program. Reviewed by: Lennard de Rijk

Added all indexes required for GHOP specific queries. Reviewed by: Lennard de Rijk

Added all GHOP specific css properties. Reviewed by: Lennard de Rijk

Fixed the Student update to properly find its own URL. Also style fix in start_update module.

Enabled the Student School type updater. The updater now passes along the runner URL to the starter function. Also fixed the TaskRunner to display correct error messages when a invalid option has been specified.

Added updater to update the existing Student models with the school_type entry. Reviewed by: Lennard de Rijk

Moved the Student cleaner to the create form such that it is always used. Also enforced that the user picks a School type in the cleaner for the time being.

Changed the TaskRunner to start and run update tasks. Also changed the way the different updates are defined as to comments received on r2ddd386d1d.

Changed the Student Model cleaner to deal with the new Student properties. Patch by: Madhusudan.C.S and Lennard de Rijk Reviewed by: to-be-reviewed

Added school_type and grade property to Student model. A GAE Task will be provided to update the existing entities in a later commit. Reviewed by: Lennard de Rijk

Moved the updater to its own module.

Added Student create/edit/apply template for use with the new Student Model. Reviewed by: to-be-reviewed

Enabled the GHOPStudent view in the GHOP module.

Added GHOPStudent view and access checks. Reviewed by: Lennard de Rijk

Added tag v0-5-20090914 for changeset afeac06aabb2

Set new Melange version number to 0-5-20090914 in app.yaml.template.

Using the new checkIsMyActiveRole check where necessary.

Added checkIsMyActiveRole check to the access module.

Make coverage conditional on run.py flag Coverage can now be enabled by running './run.py --coverage'.

Manually call start and end in test_sidebar Since we are not using a request directly we need to manually do the set-up and tear-down required.

Use request.start and end Without the start and end we die on 'assert self.in_request' in the core per request value store methods.

Add a start and end method to MockRequest

Added tag v0-5-200913 for changeset 55adeea795ab

Set new Melange version number to 0-5-20090913 in app.yaml.template.

Changed the conversion starter system to an update starter system. Also increased the usability of the update page by adding more information abou t each update that can be done and for which version number this applies.

Use the new optional argument to endRequest in the middleware Currently endRequest is called twice on an exception if Django intercepts the exception and returns it's own result. By setting optional=True we do not crash on 'assert self.in_request'.

Add optional argument to endRequest The optional argument allows endRequest to be called more than once, as long as any invocation after the first has optional=True.

Document value store methods

Remove memcache setup from interactive.py script Memcache integration with remote_api has been added in the latest AppEngine release, so we no longer have to use the stub.

Add docstring to middleware hooks

Fix copy/paste fail in maintenance middleware docstring

Enable the new middleware and empty the view decorator The view decorator should be removed entirely in a later commit.

Add ValueStoreMiddleware Based on the view decorator.

Add MaintenanceMiddleware Based on the view decorator.

Add ExceptionHandlerMiddleware Based on the existing view decorator.

Add Middleware directory

Fix broken maintenance mode Maintenance mode has been broken since r7fe19ebfe0d3 (Thu Jun 4) "Display caught errors on the page itself", fix it by passing the site entity, rather than the site module to isActivePeriod.

Fix 500 when saving /site/edit without email When saving /site/edit with no no_reply_email set, a 500 error page would be returned due to an empty value being passed as value to the datastore (which is not allowed for email fields).

Remove __melange_queries logging It causes the local instance to become very slow, as it has to pickle all queries. A better solution would be to store them in the per request value store and then add middleware to store that data at end-of-request.

Moved enabling GHOP to settings.py.

Added the GHOP modules to the callback. The ENABLE_MODULE has been added to ensure that the current build does not suffer from any weird artefacts that might occur due to the presence of this module. Of course in time it will be removed. Thanks Madhusudan for getting us this far ^_^. Minor CSS and image patches should follow shortly.

Use available Rights Checker when rights are already defined. Reviewed by: Lennard de Rijk

Several style and import fixes regarding the GHOP module. Reviewed by: Lennard de Rijk

Added jquery in-place-edit. Reviewed by: to-be-reviewed

Added GHOP Program View. Reviewed by: to-be-reviewed

Added GHOP Timeline View. Reviewed by: to-be-reviewed

Added GHOP Task Subscription View. Reviewed by: Lennard de Rijk.

Added GHOP Organization View. Reviewed by: Lennard de Rijk

Added GHOP Org Admin View. Reviewed by: Lennard de Rijk

Added GHOP Mentor View. Note that the access checks have not been updated yet. Reviewed by: Lennard de Rijk

Added GHOP Task View. TODO's have been added on the places where the code struggles with consistency and compactness issues. Reviewed by: to-be-reviewed

Renamed method in GHOP Cleaning to match style guide.

Hook up the conversion tasks

Add a view to start conversion tasks

Add templates for conversion task starter

Fix import sort order

Revert "revert wrong head" This reverts commit re440e94a87.

merge with wrong head

Fix miscaching of homepage Add system.getHostname() and system.getAppVersion() to the homepage key so that we do not use an wrong version.

Use system.getHostname() everywhere Replace os.environ['HTTP_HOST'] with system.getHostname(), as a result we do not crash when 'HTTP_HOST' is unset now.

Add a getHostname to system It is better to abstract how we retrieve the hostname than to access it directly (see also getAppVersion).

Enable local memcache api in interactive console

Scripts to run Shrinksafe during build. The function that runs shrinksafe over JS files has been put to a separate shell file to be run standalone without building if needed.

Added Shrinksafe code to shrink JS files before deploy.

revert wrong head

Added tag v0-5-20090906 for changeset 9f7f269383f7

Fix miscaching of homepage Add system.getHostname() and system.getAppVersion() to the homepage key so that we do not use an wrong version.

Set new Melange version number to 0-5-20090906 in app.yaml.template.

Use system.getHostname() everywhere Replace os.environ['HTTP_HOST'] with system.getHostname(), as a result we do not crash when 'HTTP_HOST' is unset now.

Remove some left overs from recent Google App Engine 1.2.5 update.

Add a getHostname to system It is better to abstract how we retrieve the hostname than to access it directly (see also getAppVersion).

Update Google App Engine from 1.2.3 to 1.2.5 in thirdparty folder.

Enable local memcache api in interactive console

Fixed Ivory Coast rename that was introduced in r74f0972f52.

Fixed GHOP Cleaning clean_mentors_list method from using query on list. Somehow this fix was missing from the previous revision, bad HG.

Added cleaning method to validate a list of mentor's link_ids. Reviewed by: Lennard de Rijk

Added cleaning method to convert a list of comma separated strings into a set. Reviewed by: Lennard de Rijk

Added additional methods for TaskTag model and add arbit_tag type to GHOPTask.

Updated to r11 of app_profiler

Prefetch referenced fields in project listing

Hook up prefetching in the view (helper)

Add support for prefetching fields This makes it possible to specify the fields that should be prefetched as part of a getForFields query. Doing a prefetch on a ReferenceProperty when it is known that the property will be referenced in (almost all) entities is far more efficient than doing the invididual fetches sequentially.

only store queries in debug mode

fix typo in memcache.get in base logic

Store queries in memcache

Do not store core in Checker

Add self.in_request to Core and verify correct state

Convert profiler/start page to html

Use profiler.py to prevent import failures

Set expiration date of static dirs to 1d

GHOPWorkSubmission model is made id_based and inherits from base. Also a reference property to GHOPOrganization is added in GHOPWorkSubmission model.

Added missing blank line to GHOP redirects helper.

Added __init__ file to the GHOP views module. Reviewed by: Lennard de Rijk

Added list_info method for use in the GHOP module. Reviewed by: Lennard de Rijk

Updated the docstrings for GHOP access methods. The checkRoleAndStatusForTask and checkStatusForTask methods' docstrings tell more on what they specifically do and why they both exist separately.

Added access checks for GHOP Module. Reviewed by: Lennard de Rijk

Added redirects module for GHOP. Reviewed by: Lennard de Rijk

Added templatetag and filter libraries for GHOP. Reviewed by: Lennard de Rijk

Set profiler/ to admin only

Use per-request store to store access rights

Use the per-request store to store the context

Hook up the new per-request value storage

Add a new per-request value store to Core

Profiling patch