Tue, 30 Sep 2008 16:49:54 +0000 Clean up too long lines in profile.py. Add ReadOnlyInput widget to custom_widgets module, it can be used to display read-only form fields. Display read-only "Id" field in LookUp view if user has been found and in User Edit Developer view.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 16:49:54 +0000] rev 215
Clean up too long lines in profile.py. Add ReadOnlyInput widget to custom_widgets module, it can be used to display read-only form fields. Display read-only "Id" field in LookUp view if user has been found and in User Edit Developer view. Patch by: Pawel Solyga Review by: to-be-reviewed
Tue, 30 Sep 2008 16:26:30 +0000 Add polymodel folder to DEFAULT_APP_DIRS variable in make_release.sh script.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 16:26:30 +0000] rev 214
Add polymodel folder to DEFAULT_APP_DIRS variable in make_release.sh script.
Tue, 30 Sep 2008 15:21:05 +0000 Add key naming function for Sponsor, School, Organization, Club key_names.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 15:21:05 +0000] rev 213
Add key naming function for Sponsor, School, Organization, Club key_names. Patch by: Pawel Solyga Review by: to-be-reviewed
Tue, 30 Sep 2008 14:00:11 +0000 Add org ReferenceProperty to Administrator model (many:1 relationship associating Administrators with specific Organization). Update Organization model __doc__ string with information about the back-reference 'admins'.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 14:00:11 +0000] rev 212
Add org ReferenceProperty to Administrator model (many:1 relationship associating Administrators with specific Organization). Update Organization model __doc__ string with information about the back-reference 'admins'. Patch by: Pawel Solyga Review by: to-be-reviewed
Tue, 30 Sep 2008 12:59:59 +0000 Made mce_settings class variable in TinyMCE widget a copy of default settings instead of reference.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 12:59:59 +0000] rev 211
Made mce_settings class variable in TinyMCE widget a copy of default settings instead of reference.
Tue, 30 Sep 2008 12:47:05 +0000 Replaced context.update call to simple value assignment in site.user.profile.create view function.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 12:47:05 +0000] rev 210
Replaced context.update call to simple value assignment in site.user.profile.create view function.
Mon, 29 Sep 2008 17:22:31 +0000 Load ../../google_appengine/ into trunk/thirdparty/google_appengine.
Todd Larsen <tlarsen@google.com> [Mon, 29 Sep 2008 17:22:31 +0000] rev 209
Load ../../google_appengine/ into trunk/thirdparty/google_appengine.
Mon, 29 Sep 2008 15:46:42 +0000 Take advantage of the Model inheritance provided by polymodel.PolyModel to
Todd Larsen <tlarsen@google.com> [Mon, 29 Sep 2008 15:46:42 +0000] rev 208
Take advantage of the Model inheritance provided by polymodel.PolyModel to have Club, School, Sponsor, and Organization actually inherit from the Group Model class, rather than being composed via ReferenceProperties. Patch by: Todd Larsen Review by: Pawel Solyga, Sverre Rabbelier, Augie Fackler Review URL: http://codereviews.googleopensourceprograms.com/606
Mon, 29 Sep 2008 15:34:40 +0000 Take advantage of the Model inheritance provided by polymodel.PolyModel to
Todd Larsen <tlarsen@google.com> [Mon, 29 Sep 2008 15:34:40 +0000] rev 207
Take advantage of the Model inheritance provided by polymodel.PolyModel to have create a class hierarchy rooted at Person. Also, add some missing Role classes, such as Role, (Organization) Mentor, (Club) Member, (School) Student. Make (Organization) Administrator be a Reviewer like Mentor is. Patch by: Todd Larsen Review by: Pawel Solyga, Sverre Rabbelier, Augie Fackler Review URL: http://codereviews.googleopensourceprograms.com/607
Mon, 29 Sep 2008 15:31:50 +0000 Make use of PolyModel for Works, Documents, etc. Add some (but not all) of
Todd Larsen <tlarsen@google.com> [Mon, 29 Sep 2008 15:31:50 +0000] rev 206
Make use of PolyModel for Works, Documents, etc. Add some (but not all) of the missing Models related to Documents. Refactor site settings to be useful for any "/home" page view. Make the resulting home settings store a reference to the Document, rather than looking up the Document by a hard-code key name. This is to set the stage for Document editing being generic, and then being able to select from some existing documents which one to use as the "/home" static content. This makes it possible to pre-edit several Documents, have them Reviewed, and then quickly change the "/home" page content as a setting, rather than editing the Document in the settings form (though settings forms might still embed the current document into their form for convenience). Patch by: Todd Larsen Review by: Pawel Solyga Review URL: http://codereviews.googleopensourceprograms.com/1001
Mon, 29 Sep 2008 14:03:45 +0000 Fixed not working "Create New User" view which was caused by adding key_name into User Edit Developer view. This commit divides edit() view function in soc.views.site.user.profile into edit() and create() request handlers. New create() request handler is used only in "Create New User" view and has specific form validation functions and uses updateOrCreateUserFromId() instead of updateUserForKeyName().
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 29 Sep 2008 14:03:45 +0000] rev 205
Fixed not working "Create New User" view which was caused by adding key_name into User Edit Developer view. This commit divides edit() view function in soc.views.site.user.profile into edit() and create() request handlers. New create() request handler is used only in "Create New User" view and has specific form validation functions and uses updateOrCreateUserFromId() instead of updateUserForKeyName(). Patch by: Pawel Solyga Review by: to-be-reviewed
Fri, 26 Sep 2008 19:47:07 +0000 Add ModelWithFieldAttributes *before* PolyModel, so that everything does not
Todd Larsen <tlarsen@google.com> [Fri, 26 Sep 2008 19:47:07 +0000] rev 204
Add ModelWithFieldAttributes *before* PolyModel, so that everything does not become a "ModelWithFieldAttributes" in the Datastore. The way PolyModel works, each Model class hierarchy is stored in the Datastore as the class that directly inherited from PolyModel. So, we do not want to insert ModelWithFieldAttributes *after* PolyModel by inheriting *from* PolyModel, or everything would just be a ModelWithFieldAttributes in the Datastore, instead of Person, Work, Group, etc.
Fri, 26 Sep 2008 19:35:21 +0000 Add the third-party PolyModel class. This class supports inheritance in
Todd Larsen <tlarsen@google.com> [Fri, 26 Sep 2008 19:35:21 +0000] rev 203
Add the third-party PolyModel class. This class supports inheritance in Google App Engine Datastore Model classes.
Thu, 25 Sep 2008 17:17:11 +0000 A key_name controller module to collect all of the name...() functions that
Todd Larsen <tlarsen@google.com> [Thu, 25 Sep 2008 17:17:11 +0000] rev 202
A key_name controller module to collect all of the name...() functions that compose Model entity key names, plus some minor changes to other controller modules to illustrate the proposed use. Patch by: Todd Larsen Review by: Pawel Solyga Review URL: http://codereviews.googleopensourceprograms.com/804 Review URL: http://codereviews.googleopensourceprograms.com/804
Wed, 24 Sep 2008 21:23:42 +0000 Fixed missing urlparse import in request_helpers which cause /user/profile and /site/user/profile not to work at all. Removed not used module imports in response_helpers.py.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 24 Sep 2008 21:23:42 +0000] rev 201
Fixed missing urlparse import in request_helpers which cause /user/profile and /site/user/profile not to work at all. Removed not used module imports in response_helpers.py.
Wed, 24 Sep 2008 06:00:28 +0000 Replace mock-up of sidebar with first draft of dynamic sidebar functionality.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 06:00:28 +0000] rev 200
Replace mock-up of sidebar with first draft of dynamic sidebar functionality.
Wed, 24 Sep 2008 05:58:45 +0000 Minor tweaks to Site menu item names to make them more descriptive.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 05:58:45 +0000] rev 199
Minor tweaks to Site menu item names to make them more descriptive.
Wed, 24 Sep 2008 05:58:15 +0000 Major refactoring, to switch from using inheritance from soc.logic.menu classes
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 05:58:15 +0000] rev 198
Major refactoring, to switch from using inheritance from soc.logic.menu classes to an envelope-letter model instead.
Wed, 24 Sep 2008 05:17:44 +0000 Sidebar-building controller, with a TODO remaining to implement marking the
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 05:17:44 +0000] rev 197
Sidebar-building controller, with a TODO remaining to implement marking the current page as "selected".
Wed, 24 Sep 2008 02:46:52 +0000 Make views.helpers.html_menu MenuItem classes and logic.menu MenuItem classes
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:46:52 +0000] rev 196
Make views.helpers.html_menu MenuItem classes and logic.menu MenuItem classes more closely related. This is part of some refactoring in my working copy to keep soc/logic/site/sidebar.py from having to deal with html_menu classes (which is like having view code in the controller, which is bad).
Wed, 24 Sep 2008 02:36:47 +0000 Classes that wrap soc.logic.menu.Menu and soc.logic.menu.MenuItem to produce
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:36:47 +0000] rev 195
Classes that wrap soc.logic.menu.Menu and soc.logic.menu.MenuItem to produce HTML renderings of such lists.
Wed, 24 Sep 2008 02:27:01 +0000 Change indentation level to 2 (from 4) and rename MCE_DEF_SETTINGS to
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:27:01 +0000] rev 194
Change indentation level to 2 (from 4) and rename MCE_DEF_SETTINGS to DEF_MCE_SETTINGS to match the "default constant" naming convention elsewhere in the code.
Wed, 24 Sep 2008 02:24:49 +0000 Note 'groups' back-reference from 'founder' property in soc.models.group.Group.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:24:49 +0000] rev 193
Note 'groups' back-reference from 'founder' property in soc.models.group.Group.
Wed, 24 Sep 2008 02:23:32 +0000 Simple MenuItem and Menu classes for keeping track of ordered menus.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:23:32 +0000] rev 192
Simple MenuItem and Menu classes for keeping track of ordered menus.
Wed, 24 Sep 2008 02:22:12 +0000 These changes should have been in r620, but somehow I did not save them, or
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:22:12 +0000] rev 191
These changes should have been in r620, but somehow I did not save them, or saved over them with an old copy in the editor. Not sure...
Tue, 23 Sep 2008 23:30:15 +0000 Move isReferrerSelf() and replaceSuffix() into new request_helpers.py module,
Todd Larsen <tlarsen@google.com> [Tue, 23 Sep 2008 23:30:15 +0000] rev 190
Move isReferrerSelf() and replaceSuffix() into new request_helpers.py module, since they are (mainly) used to manipulate parts of an HTTP request.
Tue, 23 Sep 2008 23:20:23 +0000 Split out HTTP request manipulation functions from template_helpers.py, which
Todd Larsen <tlarsen@google.com> [Tue, 23 Sep 2008 23:20:23 +0000] rev 189
Split out HTTP request manipulation functions from template_helpers.py, which is in danger of becoming a "misc" or "util" module unnecessarily.
Tue, 23 Sep 2008 19:20:57 +0000 Changes in TinyMCE widget in custom_widgets.py based on review comments.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 23 Sep 2008 19:20:57 +0000] rev 188
Changes in TinyMCE widget in custom_widgets.py based on review comments. Patch by: Pawel Solyga Review url: http://code.google.com/p/soc/source/detail?r=550
Tue, 23 Sep 2008 17:55:54 +0000 Change user list view instruction. Don't show "Next >" disabled greyed text in the list pagination if there is only one page.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 23 Sep 2008 17:55:54 +0000] rev 187
Change user list view instruction. Don't show "Next >" disabled greyed text in the list pagination if there is only one page.
Mon, 22 Sep 2008 14:13:32 +0000 Add Users List Developer view which is available at /site/user/list. Add User list custom templates which are used with list_helpers. Add "Users List" link in base.html template.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 22 Sep 2008 14:13:32 +0000] rev 186
Add Users List Developer view which is available at /site/user/list. Add User list custom templates which are used with list_helpers. Add "Users List" link in base.html template. Patch by: Pawel Solyga Reviewed by: to-be-reviewed
(0) -100 -50 -30 +30 +50 +100 +300 +1000 tip