Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 02:14:05 +0000] rev 860
Add a clean_agrees_to_tos() validator that requires "Yes" if ToS exists.
Also, more user_logic.logic => user_logic fixes. If you are going to import
"as", you might as well make the renaming worthwhile. Maybe we need to add
a section on "import ... from ... as ..." in the style guide?
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 00:32:05 +0000] rev 859
Change "Show" to "Export" missed in r1446 commit.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 00:27:39 +0000] rev 858
Add an export() view, and implement it as text/text for Document.
For every Model except Document, the public() view is displayed for any
attempts to access the export() view.
Currently, the permissions for export() are the same as for public(). This
seems reasonable for Document, since anyone could extract the raw HTML from
the page source anyway. The permissions should probably be different for
other types of exports, such as vCard or iCard exports of profiles, CSV
exports of lists, etc.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 23:13:03 +0000] rev 857
If a site-wide ToS exist, display the User profile "Agrees to ToS" checkbox.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 23:01:24 +0000] rev 856
Set agrees_to_tos example text to link to site-wide ToS (or a warning message).
Also, since a renaming import statement is being used already, change
user_logic.logic to just user_logic.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 22:33:43 +0000] rev 855
Do not crash on *every* page load if there is no ToS Document.
'tos' ReferenceProperty might be present, but still be None.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 22:30:21 +0000] rev 854
A better way to add site-wide ToS link to *all* pages on the site.
getUniversalContext() already fetches a copy of the Site settings, so use that
to see if the site-wide ToS exist and produce a link.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 22:21:32 +0000] rev 853
Linux /bin/sh (GNU) is not the same as OS X /bin/sh (BSD), so use /bin/bash.
Fixes:
scripts/pylint/do_pylint.sh: 27: Syntax error: "(" unexpected
on Ubuntu (and possibly other Linux distros).
Patch by: Todd Larsen
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 22:01:02 +0000] rev 852
Replace css class 'notice' that is used in User profile template field help text with new 'fieldhelptext' class. Notice is part of CSS for notification bar and we want width limit just for field help text not for notification bar text.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 21:48:28 +0000] rev 851
Add getSingleton() method to return the Site settings entity.
There is always only one Site entity, referred to by DEF_SITE_LINK_ID.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 21:37:30 +0000] rev 850
Return the ToS Document of the supplied Presence entity, if there is one.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 21:26:34 +0000] rev 849
Support HTML tags in form field example_text column.
Improve the Program Model example_text as an example.
Patch by: Todd Larsen
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 21:00:55 +0000] rev 848
Disable R0801 messages in pylintrc. R0801 messages indicates that a set of similar lines has been detected among multiple file. This usually means that the code should be refactored to avoid this duplication but in our case it's useless since it shows a lot of imports code or authors.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 20:52:12 +0000] rev 847
Add calendar widget support for timeline fields. Fix docstring typo in soc.views.models.timeline module. Add timeline edit template which loads necessary javascript files for datetimepicker widget.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 20:49:49 +0000] rev 846
Remove member_template from extra_dynaexclude in soc.views.models.club since member_template is only available in Organization as of recent commit.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 20:16:07 +0000] rev 845
Add the agrees_to_tos property to Roles (as its own changeset this time...).
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 20:04:21 +0000] rev 844
Make getToSLink() an actual method for re-use by others.
Uses the views.helper.redirects module to create the /document/show path,
instead of hard-coding it as a format string.
Patch by: Todd Larsen
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 20 Jan 2009 19:40:41 +0000] rev 843
Fixed EOL and whitespace damage
Patch by: Sverre Rabbelier
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 17:56:10 +0000] rev 842
This file should not have been included in r1428. Reverting...
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 17:53:36 +0000] rev 841
Changing ReadOnlyBool to type "text" makes it display "True" or "False".
Patch by: Todd Larsen
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 20 Jan 2009 17:41:47 +0000] rev 840
When constructing the sidebar don't overide 'sidebar'
Instead specify 'sidebar_additional' and include it even if there
is a 'sidebar' defined.
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:31:53 +0000] rev 839
Add datetimepicker javascript widget files and css file.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:27:36 +0000] rev 838
Set notice width to 450px. It was way too long. Notice is displayed with help text on yellow background in User profile.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:12:55 +0000] rev 837
Add missing blank line in soc.views.helper.params module. Fix docstring typo in soc.views.models.role module. Add missing dots at the end of sentences in soc.logic.cleaning and soc.view.models.user_self modules.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:10:04 +0000] rev 836
Add missing 'of' word to list description strings in soc.views.models.club_app module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:09:09 +0000] rev 835
Add missing blank lines and dots in soc.views.helper.templatetags.forms_helpers module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:08:16 +0000] rev 834
Move member_template property from Group to Organization model since it's Organization specific property.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:03:55 +0000] rev 833
Disable R0201 message in pylintrc since we allow for that kind of methods. R0201 tells us that method could be a function. Used when a method doesn't use its bound instance, and so could be written as a function.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:00:19 +0000] rev 832
Fix typo in settings.py (missing '>' character).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 15:59:07 +0000] rev 831
Add missing dots in docstrings. Add sendNotification parameters description to docstring in soc.logic.helper module.
Patch by: Pawel Solyga
Review by: to-be-reviewed