Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 01:18:15 +0000] rev 147
Pristine initial commit of upload.py script from
http://code.google.com/p/rietveld (r310).
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 01:15:00 +0000] rev 146
gcl.py customized to work with codereviews.googleopensourceprograms.com and the
melange-soc-dev@googlegroups.com mailing list.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 01:14:18 +0000] rev 145
Pristine initial commit of gcl.py script from chromium.org.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 14 Sep 2008 20:32:32 +0000] rev 144
Release shell script and associated changes. Set svn:ignore property on /app/django.zip file and /release folder.
Patch by: Pawel Solyga, Augie Fackler
Review by: Todd Larsen, review-after-commit
Review issue: 363
Review URL: http://codereviews.googleopensourceprograms.com/363
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 14 Sep 2008 00:23:49 +0000] rev 143
FIxed documentation in soc/logic/document.py for getDocumentFromPath function
Patch by: Christian López Espínol
Reviewed by: Pawel Solyga
Reviewed via: discussion on melange-soc-dev group
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 13 Sep 2008 22:53:07 +0000] rev 142
Forgot to change widgets to custom_widgets import in home.py after changing the name of soc/views/helpers/widgets.py file.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 13 Sep 2008 22:00:51 +0000] rev 141
Added Melange front page edit view where you can change title, content, feed url. Created SiteSettings and Document models and some logic for them. Added isFeedURLValid function in soc/logic/feed.py. Created some functions for handling datastore updates of different kinds of Models (soc/logic/model.py). Fixed some typos and too long lines of code.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 13 Sep 2008 21:27:17 +0000] rev 140
Added feedparser to soc/utils and modified svn:externals for vendor to include feedparser svn
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 12 Sep 2008 21:54:37 +0000] rev 139
Add getAltResponseIfNotLoggedIn() and getAltResponseIfNotDeveloper() simple
view helpers. These cannot go into response_helpers.py because they create
a circular reference with simple.py, and Django view import fails.
Review URL: http://codereviews.googleopensourceprograms.com/602
Todd Larsen <tlarsen@google.com> [Fri, 12 Sep 2008 20:36:17 +0000] rev 138
Improve the __doc__ string of isIdDeveloper() to explain better how it now
functions.
Todd Larsen <tlarsen@google.com> [Fri, 12 Sep 2008 20:31:56 +0000] rev 137
Make isIdDeveloper() also able to check an is_developer Boolean property in
User entities.
Review URL: http://codereviews.googleopensourceprograms.com/601
Todd Larsen <tlarsen@google.com> [Fri, 12 Sep 2008 19:01:44 +0000] rev 136
Replace checkLinkNameForId() with isLinkNameAvailableForId(), and implement
that new function in terms of only the existing doesLinkNameExist() and
doesLinkNameBelongToId().
Patch by: Todd Larsen
Review by: Pawel Solyga
Review via: discussion of patches on melange-soc-dev mailing list
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 12 Sep 2008 16:33:04 +0000] rev 135
Fixed one typo in response_helpers which caused is_admin context variable not to work correctly.
Created new checkLinkNameForId function that checks if link_name is correct when creating new user and modifying existing one. This is now used for validation instead of doesLinkNameBelongToId in UserForm clean_link_name function. The previous validation function didn't allow to create new users and modify linkname of existing ones. Additionally I created new doesLinkNameExist helper function.
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 12 Sep 2008 10:56:21 +0000] rev 134
Fixed wrong user variable in lookup.html template for edit link (was user should be found_user).
There is no DeveloperForm in site/user/profile.py changed that to LookupForm.
Todd Larsen <tlarsen@google.com> [Fri, 12 Sep 2008 02:46:21 +0000] rev 133
gcl.py committed this file, when it should not have even existed.
Todd Larsen <tlarsen@google.com> [Fri, 12 Sep 2008 02:37:15 +0000] rev 132
Add a /site/user/lookup view that provides Developers with a form to look up
User entities given email addresses or link names.
Todd Larsen <tlarsen@google.com> [Fri, 12 Sep 2008 02:12:38 +0000] rev 131
...
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 11 Sep 2008 21:30:08 +0000] rev 130
Updated the script to:
* Include a comment describing what it does
* Use variables for anything non-standard
* Use the --parse-only flag of epydoc
* Exclude all 'django' modules through --exclude=
* Run on '../app' by default, no more arguments needed
* Clean up the output directory before running
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 11 Sep 2008 20:50:58 +0000] rev 129
Bugfix, invalid syntax noticed by epydoc.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 11 Sep 2008 12:06:57 +0000] rev 128
Updated docs in response_helpers.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 11 Sep 2008 12:01:20 +0000] rev 127
Created custom_widgets.py and added TinyMCE django widget that can be later used for particular form fields.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 11 Sep 2008 11:56:24 +0000] rev 126
Added TinyMCE to Melange in soc/content/js
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 30 Aug 2008 02:54:22 +0000] rev 125
An emerging pattern with makeSiblingTemplatesList() is that views calling that
function then append a known, default template "just in case". This change
adds a default_template parameter to makeSiblingTemplatesList() to eliminate
the extra "append a known default to the end" step for the caller.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 29 Aug 2008 04:24:31 +0000] rev 124
Refactor soc/views/user/profile.py to make use of several of the new views
available in soc/views/simple.py.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 29 Aug 2008 02:59:59 +0000] rev 123
Fix an overlooked cut-and-paste error.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 29 Aug 2008 02:52:02 +0000] rev 122
Add a public() convenience wrapper around templateWithLinkName() for the common
public.html case. Add a requestLogin() view.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 29 Aug 2008 00:00:34 +0000] rev 121
This CSS change belonged with soc/templates/soc/error.html committed in r454.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 28 Aug 2008 23:56:29 +0000] rev 120
A default error.html template to go with the simple.errorResponse() view.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 28 Aug 2008 23:54:35 +0000] rev 119
Add soc.views.simple containing (initially) two simple template views.
templateWithLinkName() is a view that can replace most public() read-only
views. errorResponse() is a view that renders an error page for
out_of_band.ErrorResponse exceptions. Also, change response_helpers.respond()
to accept keyword arguments to pass to http.HttpResponse(). (errorResponse()
makes use of this new respond() feature.)
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 28 Aug 2008 22:27:40 +0000] rev 118
Clean up User Model and User profile edit view now that soc.logic.site.id_user
module exists. Change usage of "user" to be "id" the variable refers to a
Google Account and not a User entity.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 28 Aug 2008 22:23:11 +0000] rev 117
Pawel and I were working on the same thing, apparently. My template_helpers.py
is more complete, so I am removing this one (that Pawel appears to not have
used yet).
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 28 Aug 2008 22:06:31 +0000] rev 116
Factor out a getUniversalContext() function so that views that do not call
response_helpers.response() can benefit from the code that constructs shared
template context variables common to many templates.
Patch by: Todd Larsen
Review by: to-be-reviewed