Daniel Diniz <ajaksu@gmail.com> [Sat, 04 Jul 2009 14:15:11 +0200] rev 2527
Add a grade field to the Grading Project Survey form.
This also takes care of validating and transforming the data into True(pass) or False(fail). GradingProjectSurveys are hereby working for developers.
Reviewed by: Lennard de Rijk
James Levy <jamesalexanderlevy@gmail.com> [Sat, 04 Jul 2009 13:53:17 +0200] rev 2526
Survey editing/taking Javascript and CSS fixes.
This patch adds some cosmetic changes and functional fixes:
- UI now removes all of the field content when a field is deleted,
- CSS tweaks, and jQuery hack to specialize comment CSS,
- fixed JS path in take.html.
Reviewed by: Pawel Solyga (with some small changes)
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 04 Jul 2009 12:07:27 +0200] rev 2525
Remove public role type from SURVEY_TAKING_ACCESS in Survey model.
Sverre Rabbelier <sverre@rabbelier.nl> [Fri, 03 Jul 2009 20:41:19 -0700] rev 2524
try to fix the surveys-have-no-scope issue
to-be-reviewed: also untested
Sverre Rabbelier <sverre@rabbelier.nl> [Fri, 03 Jul 2009 18:39:17 -0700] rev 2523
addressed comments to previous version
to-be-reviewed: still untested
Sverre Rabbelier <sverre@rabbelier.nl> [Fri, 03 Jul 2009 18:24:02 -0700] rev 2522
return found entity for activity checks
Sverre Rabbelier <sverre@rabbelier.nl> [Fri, 03 Jul 2009 18:23:12 -0700] rev 2521
survey access: stylefix and remove public role type
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 22:36:10 +0200] rev 2520
Style fixes in Survey helper.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 22:27:42 +0200] rev 2519
Added _getSurveyTakeForm to the Survey view.
Subclasses can overwrite this method to create their own form. ProjectGradingSurvey will likely be an example for this.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 21:59:10 +0200] rev 2518
Only initialize a SurveyTakeForm in take instead of in takeGet and takePost.
This will allow for other subclassed views to easily replace the form the view is using.
Also small style fix in Survey helper.
Daniel Diniz <ajaksu@gmail.com> [Fri, 03 Jul 2009 21:06:22 +0200] rev 2517
Split SurveyForm into SurveyTakeForm and SurveyEditForm.
This allows for a more cleaner implementation of the Form code. And this will make it easier to break free from the getFields method in the future.
Also the getRoleSpecifcFields method and the this_user and project variables have been removed. They are deemed obsolete.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 20:38:43 +0200] rev 2516
Do not call takeGet when SurveyForm ValidationError occurs.
Problems occured when a SurveyRecord was specified in the SurveyForm. The SurveyRecord data reset the erroneous POST data. Further code reduction might be possible soonish.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 19:15:09 +0200] rev 2515
Several stylefixes due to received reviews.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 18:39:30 +0200] rev 2514
Style fixes in Access module.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 18:34:18 +0200] rev 2513
Style fixes to the GradingProjectSurvey View module.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 18:23:34 +0200] rev 2512
Sub_merge params for GradingProjectSurvey View.
James Levy <jamesalexanderlevy@gmail.com> [Fri, 03 Jul 2009 18:23:02 +0200] rev 2511
Added rudimentary grade field to GradingProjectSurvey take View.
Patch by: James Levy, Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 18:20:33 +0200] rev 2510
Ensure that the params from subclasses get merged properly with ProjectSurvey view.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 18:09:48 +0200] rev 2509
Corrected the links to Grading Project Surveys in Program menu.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 17:55:36 +0200] rev 2508
Added missing import to ProjectSurvey View.
Daniel Diniz <ajaksu@gmail.com> [Fri, 03 Jul 2009 15:21:44 +0200] rev 2507
Fix pick_multi only returning one answer as maximum.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 15:00:00 +0200] rev 2506
Removed getSurveyResponseFromPost from Surveys helper.
We will use the power of Django Forms instead of getting our own properties. This fits better into the rest of Melange which also uses this approach.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 14:53:26 +0200] rev 2505
Renamed survey-edit-090627.js due to recent changes.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 14:43:49 +0200] rev 2504
Form errors when taking a Survey now have the correct context.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 14:36:16 +0200] rev 2503
Fixed Survey Form error giving 505.
I failed when changing the system to work with collectCleanedFields.
Daniel Diniz <ajaksu@gmail.com> [Fri, 03 Jul 2009 14:35:03 +0200] rev 2502
Surveys can now have required questions and comments can be turned on/off.
Storing comments is now working. However some issues arise when form errors occur, like missing context and the errors also trigger before a form has been submitted.
Reviewed by: Lennard de Rijk
Daniel Diniz <ajaksu@gmail.com> [Fri, 03 Jul 2009 14:19:23 +0200] rev 2501
Added Survey From Field validation.
Also added the COMMENT_PREFIX in Survey model to ensure that comments are stored in the same way everwhere.
Reviewed by: Lennard de Rijk
Daniel Diniz <ajaksu@gmail.com> [Fri, 03 Jul 2009 12:10:24 +0200] rev 2500
Style fixes and a forgotten parameter in Survey(Record) logic.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 12:05:23 +0200] rev 2499
Removed unnecessary variable in ProjectSurvey take method.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 12:02:57 +0200] rev 2498
Overwrite _getSurveyRecordFor in ProjectSurvey view to take StudentProject into account.