Added clean_user_is_current to cleaning and fixed some indentation. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Add a script to (re)seed the datastore For obvious reasons enabled only when running in debug mode. Patch by: Sverre Rabbelier

Added no-cache headers to pick and bulk-accept views. Also added a TODO since IE7 seems to ignore the headers. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Remove private data from club and org public templates Also re-use the club/public.html template in organization's template. Patch by: Sverre Rabbelier

Skip a field when it's value is not set Patch by: Sverre Rabbelier

Added bulk acceptance and progress bar in review org applications view. In the list of organization applications for reviewing, if you click the button "click here" the whole first text line will fade out and the progress bar will fade in while starting to contact the server for the list of orgs to accept and then make synchronous calls for acceptance, while updating the progress bar, the name of the organization currently accepting and the number of orgs already accepted against the total. Inside the script, what's inside the parenthesis is converted due to regexp (in this case (link_id)) and then read the json_object.applications[index].link_id. By doing this with an eval(), you can use other names as well and the script will be reading for example json_object.applications[index].attribute_name if you insert "(attribute_name)" inside the link returned by {{ bulk_accept_link }}. Notes by Lennard: -Put Done outside the for-loop so that it also shows when there are 0 pre-accepted organizations. -Made some minor style fixes Patch by: Mario Ferraro Reviewed by: Lennard de Rijk

Now using the correct path to the loading animation in jquery-thickbox. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Minor style fix dicts.merge already takes care of the case where target is None. Patch by: Sverre Rabbelier

Add a list_public view to organization Patch by: Sverre Rabbelier

Factor out the 'key fields without link_id' logic from document Also make sure the to-be-removed is present before removing it when doing the field reordening. Patch by: Sverre Rabbelier

Add a getListRedirect and getListPublicRedirect function Patch by: Sverre Rabbelier

Add an idea list (url) property to organization Also include this url in the organisation list. Patch by: Sverre Rabbelier

Fixed missing parameters in program view due to change in _getTimeDependentEntries in r1943. Also the sidebar once more shows "Apply to become an Organization" even if you are not logged in. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Include scope_path as django_args Otherwise users cannot create documents in their own prefix. Patch by: Sverre Rabbelier

Disable the raw create and list link for documents Patch by: Sverre Rabbelier

Add custom access check for document listing Patch by: Sverre Rabbelier

Add a 'list documents' link everywhere Also disable the Documents sidebar menu, since it does not provide anything useful anymore. Patch by: Sverre Rabbelier

Allow documents to be filtered by prefix and scope Patch by: Sverre Rabbelier

Developers have all roles Patch by: Sverre Rabbelier

Organization prefix was renamed to 'org' The reference to it in the logic/rights.py module was not updated. Patch by: Sverre Rabbelier

Force-check the 'agreed to admin agreement' field if applicable If the current user is the applicant of the relevant organization, they already agreed to the agreement once. As such the box should be pre-checked. Patch by: Sverre Rabbelier

Fix a bug in group_app If context is not set, kwargs['context'] will raise an exception. Patch by: Sverre Rabbelier

Add cleaning methods for document ACL Patch by: Sverre Rabbelier

Make document ACL's a constant This makes it possible to refer to it in other modules. Patch by: Sverre Rabbelier

Fix a bug if you have no roles at all This could not happen currently, but might happen later on if a group is defined that does not have an 'anybody' membership. Patch by: Sverre Rabbelier

Partially reverted "Update the copyright notice for 2009." This partially reverts commit r1933. Only the files that were created in 2008 were reverted. Patch by: Sverre Rabbelier

Update the copyright notice for 2009. Patch by: Sverre Rabbelier

Fix ToS link s/Terms/Google App Engine Terms/ Patch by: Sverre Rabbelier

Do access checks on the pick url for documents Patch by: Sverre Rabbelier

Convert the QueryDict to a regular dictionary This way we support a query with multiple args specified. Patch by: Sverre Rabbelier

Add prefix filtering and refactored program field generation Patch by: Sverre Rabbelier

We generate the select url ourselves, so it's safe This prevented urls with an & in it to be correctly generated. Patch by: Sverre Rabbelier

Added a filter_fields parameter to the ReferenceField widget This paramater makes it possible to do 'hard coded' filtering. Patch by: Sverre Rabbelier

Factor out the hasMembership method from checkMembership This makes it possible for the document picker to reuse it. Patch by: Sverre Rabbelier

Add a getMemberships method to logic/rights.py This will be used by the document picker ACL checks. Patch by: Sverre Rabbelier

Fixes as requested by Leslie on behalf of the Legal team Upped the copyright statement from 2008 to 2009, and link to the GAE Terms of Service instead of any custom ToS. Patch by: Sverre Rabbelier

Added number of applications and their type to the bulkaccept JSON object. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Implemented the 2nd part of bulk acceptance. The context of the _list call can now be set by using the kwarg context. This will be merged with the universalcontext. Added a TODO to create the organziation accepted email template. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Document prefix in params now defaults to url_name. This is because the short name does not have to be url friendly. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added bulk_accept view which returns a JSON object. This is going to be used to bulk accept org applications. Also added a new unfinished template so Merio can test his JS. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Only a club admin should see resign as club admin in the sidebar. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed a bug in club and org logic. This bug would give an error when no backup was set. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed a bug in group_app templates. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Brown Paper Bag Fix: L2R Appspot error logs. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed a bug in group_app view. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Returning None instead of the empty to fix a bug on melange-demo instance. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added check_field_is_empty decorator to cleaning.py. This makes sure the cleaning checks are skipped when a field is empty. Note that Djanog will raise it's own ValidationError when a required field is empty before attempting to clean it. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed.

Org App review page now shows accept and pre-accept button. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed comment and typo in cleaning.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Add ToS agreement to mentor application related forms. Patch by: Sverre Rabbelier

Add ToS agreement to org_admin application related forms. Patch by: Sverre Rabbelier

Do not attempt to render a field if it is disabled This is required to make it possible to disable fields dynamically. Patch by: Sverre Rabbelier

Program requires the filter to be set to __scoped__ Patch by: Sverre Rabbelier

Disable clubs for now Disabling the clubs in this way is a lot easier than adding a switch for it in Site Settings, and probably safer too (as the urls are no longer valid). Patch by: Sverre Rabbelier

App Engine 1.1.9 update breaks django 1.0. Monkey patch django to only check for SVN revision number when not running using dev_appserver. On deployed version this doesn't apply since we use django from zipped file. This issue was discussed here: http://groups.google.com/group/codereview-discuss/browse_thread/thread/a7ab6ceb39c09ce6 http://groups.google.com/group/google-appengine/browse_thread/thread/bbdebf8617b57512 Patch by: Pawel Solyga Review by: to-be-reviewed

Load /Users/solydzajs/Downloads/google_appengine into trunk/thirdparty/google_appengine.

Removed unused argument in program.py Patch by: Sverre Rabbelier

Initial implementation of a ToS requirement in org_app If the _editContext method can be made generic enough, it should be easy to add ToSes to other forms. This solution should also be applied to user_self, as the current implementation is not very clean to say the least. Patch By: Sverre Rabbelier

Added an AgreementField widget Displays an Agreement Document in a scrolling text field. The text of the document can be set by modifying the 'text' property. Patch by: Sverre Rabbelier

Rename TinyMCE to FullTinyMCE and add TinyMCE widget The FullTinyMCE (irony intended) is the full-fledged editor, usefull in editing documents etc. The regular TinyMCE widget can be used for smaller tasks that allow HTML input (such as the description field). Patch by: Sverre Rabbelier

Use the newly added __scoped__ and references for program's ToSes This fixes the ToSes autocompletion and 'enables' them. Patch by: Sverre Rabbelier

Added an agreed_to_admin_agreement property Patch by: Sverre Rabbelier

Add '__scoped__' as a special filter It sets the scope_path to the entity's key().value(). Patch by: Sverre Rabbelier

Fields are always safe, as we generate them ourselves This will be used by a future widget. Patch by: Sverre Rabbelier

Add an _editContext hook Usefull when one wants to have a hook that will always be called. Patch by: Sverre Rabbelier

Resolve references if they are specified All views sould make use of this instead of doing it manually in _editGet and _editPost. Patch by: Sverre Rabbelier

Make it possible to put fields at the end of the form This is usefull for Terms of Service etc. Patch by: Sverre Rabbelier

Changed the access checks for organization. This should allow normal users to use organizations as well. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added allowsidebar to checkIsDocumentReadable. Note that this means that documents you can't actually read might show up in the sidebar. A todo has been added to fix this. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added organization entity sidebar entries. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed a bug in access.py that made it impossible to show featured documents in the sidebar. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed document to also filter on the prefix when getting the documents for a scope. For this to work the organization prefix is now org. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed a typo in org_admin model. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added Agreement properties to Program Model. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Reset the RELEASE_TAG to None (unreleased) now that the 0.2-20090209 release candidate branch has been created. Patch by: Pawel Solyga

Set RELEASE_TAG to 0.2-20090209rc for release candidate. Patch by: Pawel Solyga

Added a button to list all your org applications to a speficic program menu. The entry only shows up when orgs can apply. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Put the tos extra_dynaexclude in presence_with_tos.py where it belongs. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Redone the listing in group_app.py. There is now a list_self that only shows the group application of the current user in the given a scope. The redirects point to edit or applicant when necessary. Review_overview will show all the group applications that can be reviewed in the given scope, the redirect points to review for all statusses. And list will just show all the group applications and redirect you to edit. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added new redirect for the new list views for group_app's. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fix bug in group_app Patch by: Sverre Rabbelier

Temp bug fix This should be fixed properly at some point. Patch by: Sverre Rabbelier

Add myself to authors since I was missing. (Also, a test commit for buildbot) Patch By: Augie Fackler <durin42@gmail.com> Review By: TBR

Fixed access checkers for orgs Patch by: Sverre Rabbelier, Lennard de Rijk

Remove unneeded stylesheet and js and fix notification area Patch by: Sverre Rabbelier

Rename checkHasActiveRole to checkHasActiveRoleForScope This is to prepare for a checker that checks if the user has any such role, regardless of scope. Patch by: Sverre Rabbelier

If there is no user account, don't show New Document link under Site Patch by: Sverre Rabbelier

Fixing r1855 that was bugged by Tortoise ^_^. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed broken autocomplete due to wrongly named file This should have been in r1852. Patch by: Sverre Rabbelier

Should be part of r1855. FOSDEM got the best of me :). Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Use short_name for the header title in a presence's home page Patch by: Sverre Rabbelier

Handle GAE account normalization Also forbid users from going back to a former account. Patch by: Sverre Rabbelier

Pimp TinyMCE widget. Patch by: Sverre Rabbelier

Always return a site singleton and fix Edit Site Settings Patch by: Sverre Rabbelier

Stylefixes in access.py and removal of self.deny calls The result of self.deny() is not very helpfull to the user, as such we should not use it if we can provide a more sensible message. Also made the document access checks use getForKeyFieldsOr404 to prevent an error page when the specified document doesn't exist. Patch by: Sverre Rabbelier

Added scoped group_app listing. Also moved the review program applications menuentry to the specific program menu. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added missing comment in access.py and removed excessive whitespace. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Hide all *.pyc files in trunk/. r1850 was supposed to be a recursive property change, but was not. Patch by: Todd Larsen Review by: to-be-reviewed

Name .js and .css files more consistently with those previously present. Patch by: Todd Larsen Review by: to-be-reviewed

Add image that appears to be missing from the original thickbox patches. Patch by: Todd Larsen Review by: to-be-reviewed

Hide *.pyc files in trunk/ from 'svn status' output. Patch by: Todd Larsen Review by: to-be-reviewed

Added pre-accpeted status to group_app. This can be used when we want to accept all org's at once. Instead of one by one. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added some help_text and clarifications to org_app model fields. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Cleanup in org_app and replace ReferenceProperty with LinkProperty Using LinkProperty allows the org to host their idea's list on Melange through the Document system, and then specify the URL of that document. This also makes it possible for the orgs to specify a document that is not hosted on Melange. Patch by: Sverre Rabbelier

Refactored the picker so that it is more generic The picker now also works in the case the scope_path of the entity should not be filtered on. Also, it is now easier to add new functionality due to the fact that there is a seperate Field type to handle it now. Patch by: Sverre Rabbelier

Added a ReferenceField widget Also removed the unused ReadOnlyBool widget (as we now have a properlyworking ReadOnly widget). Patch by: Sverre Rabbelier

Make picker work generically Also removed some unused params from the JSON object. Deleted the now unused checkHasPickGetArgs method. Patch by: Sverre Rabbelier

Fix broken document access checks The 'normalized checker' syntax was used to specify the access checkers, but the normalization never happened. Patch by: Sverre Rabbelier

Org applications can now only be made by a user when a program allows it. To do this a new access_type has been added called apply. This ensures that users can only used the seeded version of create. Also the review_overview now has his own access type to ensure the separability of hosts for different sponsors in case of org app reviews. Note that the access checks for hosts are broken and only give access to developers at the moment. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added a new redirect for apply accesstype. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added new access checks to deal with timeline for programs. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Updated docstrings and used keyfields where necessary in soc/logic/models/base.py Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Remove extra whitespaces in soc.views.models.organization module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Add missing blank line to soc.logic.helper.timeline module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Fix import sorting in soc.views.models.sponsor module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Cleaned up getKeyNameFromFields in Logic base. You can now pass it a dictionary that can contain other fields next to the keyfields. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Reverted r1819 and making an application will now reserve the link_id indefinitely. This is to make sure our statistics dont get messed up. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Make the ToS text in-line and hook up thick-box in the help-text. This way the user can see the ToS in scrollable form between the link_id and the 'agree to tos' checkbox. Also, when clicking on the link to the 'side-wide terms of service' a thickbox will pop up and display the Terms of Service in an overlay. Patch by: "Mario Ferraro" <fadinlight@gmail.com>

Hook up the new jquery plugins in base.html and _as_table_row.html A very important todo here is to make loading these plugins only when needed, as to not waste bandwith. This should be trivial to do later on though, so leaving as-is now. Patch by: "Mario Ferraro" <fadinlight@gmail.com> Reviewed by: Sverre Rabbelier

Include the field_id in the context of _as_table_helper This makes it possible to refer to the field that is being edited by it's ID (in for example Javascript). Patch by: "Mario Ferraro" <fadinlight@gmail.com>

Make toDict "dereference" the 'name' property if it is present This makes it possible to turn 'name' into a consistent alias that can be used to represent an entity. Patch by: Sverre Rabbelier

Added jquery thickbox, ajaxQueue, autocomplete and bgiframe Also added the soc-specific stylesheets for jquery and thickbox. Patch by: "Mario Ferraro" <fadinlight@gmail.com>

Now calling block.super in timeline/edit.html template. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Added timezone clarification to the timeline edit form. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Specific program menu's now show a "Apply to become an Organization" entry when the program's timeline states that it's open. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added new helper module for timelines. This helps to determine wether a given event or period has begun/isactive/ended. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added missing table header for org_apps. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Refactored the application review template into group_app. Patch by: Madhusudan C.S Reviewed by: Lennard de Rijk

Added validate_new_group to cleaning and removed clean_new_club_link_id. This new cleaning method is a general purpose method for cleaning the form of a new group or group_app. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed an error in group_app view that didnt let you create a new application. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Renamed checkHasRole to checkHasActiveRole. We need this distinction to later allow another check to grant access upon a role that also might be inactive. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added removal of an existing group application when someone else is applying. This makes sure that the fields we do not collect via the form also get wiped when a rejected application is being redone by someone else. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added checkCanReviewGroupApp to acces.py. To make this work allowSidebar decorator was added as well. This will make sure that the Review buttons show up in the sidebar. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added checkCanEditGroupApp to access.py. Group Applications can now only be edited if they are either rejected or still in need of review. Also fixed a bug in checkIsMyEntity. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed whitespace in /soc/models/group_app.py Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added some extra isUser checks to make sure that you have to accept the ToS before you can do anything concerning requests. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixes a bug where notifications can't be deleted. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Only do the update routine when the status changes for group_app's and role requests. This helps prevent spamming multiple notifications. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed a bug where a GMAP error message would be displayed when the form was not valid. The wrong params were used, so the wrong template was used to display the form. This also caused the instruction_text to dissapear. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

The simplejson in Django is now used, so do not create a symlink in build.sh. Patch by: Todd Larsen Review by: to-be-reviewed

Fixed a typo in getForCurrentAccount comment. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Adds the possibility to exclude the user from the website. getForCurrentAccount now only returns a user entity when it is valid. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed default value for write_access in Document model. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Probably fixed a bug on the live instance. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

More access related fixes Also make it possible to do access checks for 'create'. Patch by: Sverre Rabbelier

Reset the RELEASE_TAG to None (unreleased) now that the 0.2-20090202 release candidate branch has been created. Patch by: Pawel Solyga

Set RELEASE_TAG to 0.2-20090202rc for release candidate 02/02/2009. Patch by: Pawel Solyga

Fixed EOL errors. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Create org_application now shows select program view. Also fixed the menu heading. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Use .logic in checkIsAllowedToManageRole at the caller This is to be consistent with the rest of the module. Patch by: Sverre Rabbelier

Make getForFields work with no filter Patch by: Sverre Rabbelier

Fixed EOL damage in org_app and access checks Patch by: Sverre Rabbelier

Calling getForCurrentAccount where necessary. Also fixed whitespace error in soc/views/models/user_self.py Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed club_app The user could not edit their own club app due to a buggy check. Patch by: Sverre Rabbelier

Rewrite getForFields to use GQL instead of the Query API Apparently the Query API does not support the IN statement. Patch by: Sverre Rabbelier

Removed work flow field from the check in getExtraMenus for program. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

More access related fixes Patch by: Sverre Rabbelier

Fixed access related bugs Patch by: Sverre Rabbelier

Make longitude and latitude hidden fields not required in soc.views.models.role module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Fix broken Roles public templates. By mistake we used entity.user.public_name instead of entity.user.name. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Changes in club_app and org_app public templates. Don't show email address in public template. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Style fixes in soc.views.models.user module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Style fixes in soc.logic.models modules. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Fix missing indention in css file. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Set the right field type in user_self to overcome confusion. Also reverted a template change. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Adding a hidden agreed_to_tos field when the user has signed the ToS. This a more cleaner solution then r1774. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fix the JS but mentioned in the previous commit Patch by: Sverre Rabbelier Reviewed by: Pawel Solyga

Fix get args construction when there are multiple lists on the page It is now possible to go back and forward through the liast, and specify the limit (both offset and limit can be done per list). The JS driving the list boxes is buggy, if visiting an url like: http://localhost:8080/notification/list?limit_0=10 And then change the limit in the second checkbox, it directs to: http://localhost:8080/notification/list?limit_1=25 Whereas it should redirect to: http://localhost:8080/notification/list?limit_0=10&limit_1=25 The logic _does_ work properly when the limit of the changed list is already present in the url. Patch by: Sverre Rabbelier

Unify 'getForFields' and 'getForLimitAndOffset' This also fixes the broken list views for filtered lists. Patch by: Sverre Rabbelier

User profile now shows the time on which you signed the ToS. Note that this solution is temporary and a hidden_field_as_table_row will be made by Pawel soon. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Cleaned up access.py Removed a lot of duplicate code and added more generic checkers in their place. Patch by: Sverre Rabbelier

Do not return empty menu's in program. Patch by: Sverre Rabbelier

This patch prohibits changing of agreed_to_tos and agreed_to_tos_on by the Logic module. This is used so that legally the agreed_to_tos fields can never change in the User model once set. Patch by: Haoyu Bai Reviewed by: Lennard de Rijk

Add publish_location boolean property to Role model. This field indicates whether the User has agreed to publish his location. It is not supported yet in any logic, views or templates but we won't want to change models later so it's being added now. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Fixes an error occurring when editing a User as Developer when the ToS have been signed. By disabling the input of the field Django will not attempt to wrongly parse it as a DateTime instance. Patch by: Haoyu Bai Reviewed by: Lennard de Rijk

ReadOnlyInput widget now shows text instead of a greyed-out input box. Patch by: Haoyu Bai Reviewed by: Lennard de Rijk

Added status property to the user model. This is to accommodate the ability to exclude users from using the website. Note that since the access modules is currently undergoing some reconstruction changing the status will not actually effect the User yet. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed EOL and whitespace in org_app templates Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Update error message that shows when Google Maps API key is missing. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Implement the last step in the org application process. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Refactored applicant from club view to group view. This is to accommodate the OrgApplication Process. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Add Google Maps integration for Role profiles create/edit views. Now when editing/creating your Role Profile page Google Maps widget will show up at the bottom of the form as "Location" field. When you type in your Street, City, Country or State it will automatically update the map with the location based on your address. The zoom level depends on the address information you provided. So for example if you just select Country it will be different then when you select both Country and City. The longitude and latitude fields are hidden and are updated with the coordinates from the address you provided. Also if the map is not accurate enough you can adjust your location by dragging the red market, which will change your location and save new coordinates into hidden fields. This patch also includes some style fixes in soc.views.models.role module. Patch by: Mario Ferraro & Pawel Solyga Reviewed by: Pawel Solyga

Added org_app view and templates. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed club_app review template to use key.name. This will ensure that if we ever decide to change it to a scoped entity the review template will not break. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed some errors in the org_app model. The backup_admin property has been removed because it's present in the group_app model. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added org_app logic. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed group_app to use scope_logic in constructor. This is so org_app logic can use a scope_logic. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed getApplicantRedirect to use the key_name instead of just a link_id. This is to make it work with OrgApplication. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fix import sorting in soc.views.models.document module to comply with our style guide. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Rename 'Create a new document' links to 'Create a New Document', also rename 'Create a new Program' to 'Create a New Program' in soc.views.models modules. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Fix missing dots and blank lines to soc.logic modules. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Fix missing dot and wrong import sorting in soc.views.helper.access module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Style fixes in soc.models.document module (adding of missing whitespaces). Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Style fixes in soc.logic.models modules (basically removing of extra whitespaces). Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Changed the url regexpr for review and added 2 missing imports. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Refactored review and reviewoverview out of club_app.py This is to help accomodate the upcoming OrgApplication. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added view for mentors. This one is for real. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added two forgotten comments in rights.Checker Patch by: Sverre Rabbelier

Hook up the ACL system for documents. Org access checks are left unimplemented as they are not done yet. Patch by: Sverre Rabbelier

Final changes to the document model With a seperate set of read and write permissions it is possible to very accurately specify the ACL of the document. Patch by: Sverre Rabbelier

Added a rights module The purpose of this module is to translate from document prefix and status to a set of access checks. Patch by: Sverre Rabbelier

Replace name_on_certificates property with name_on_documents, since mentors, club admins, hosts and org admins don't get certificates it's better to name it 'Name on documents' which can indicate any kind of documents including awards certificates. Also don't show name_on_documents in public Role profiles, instead show user public name in that place. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Changed display_name to name_on_certificates in models/role.py. This is to make the intention of this property more clear as to display_name which would remind people of for instance nicknames or a replacement for their public name for this role. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added view and templates for mentors. Mentors can be invited or send a request to become a mentor for a specific org. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed a bug in soc/views/models/role.py. This bug allowed the creation of only invalid requests opposed to valid requests. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added a view and templates for the organization admin. This means that org admins can now be created/invited. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed two small errors. Removed an unnecessary edit_extra field in club.py. And made group.py call getForCurrentAccount where necessary. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added organization view and templates. Also added TODO's so it's clear what still needs to be done to make this work. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Removed obsolete _editPost and _editGet in soc/views/models/club.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Reverting a change from r1732 for reasons stated in soc/logic/models/group.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed scope_logic for requests to linkable_logic. This makes the scope_path for a requests of a variable length which is needed for reuse. Patch by: Sverre Rabbelier and Lennard de Rijk Reviewed by: to-be-reviewed

Removed workflow type as keyfield from program. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added mentor and org_admin logic. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Add an 'unread' style and add 'new document' link for user Patch by: Sverre Rabbelier

Fixed a string formatting bug in soc/views/models/role.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

When moving stuff please make sure that all your belongings are safely secured. Brown Paper Bag fix. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed a bug in role.py that made it call the wrong superclass. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Moved create_extra_dynafields from club_admin and member to role. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Cleanups in base.Logic * Use regular kwargs instead of **kwargs * Fold getKeyNameFromFields into _keyName * Fold getIfFields into getFromFieldsOr404 * Rename getKeyValues to getKeyValuesFromEntity * Rename getKeyFieldsFromDict to getKeyFieldsFromFields * Rename getFromFieldsOr404 to getFromKeyFieldsOr404 * Rename getKeyValues to getKeyValuesFromEntity Patch by: Sverre Rabbelier

Add checkIsProgramActive to the rights flushing Patch by: Sverre Rabbelier

Small changes in Mentor model (we don't inherit from Reviewer anymore since model inheritance is not supported in datastore). Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Add Organization Administrator model. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Remove not used Administrator model that is replaced by Host model. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

soc/views/models/club.py now uses getForCurrentAccount where necessary. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Edited the access check for show in site settings. Not everyone should see our keys :). And also moved the template to site folder and changed presence back to the way it should be. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added rights to soc/views/models/timeline.py. Only a developer or a host for the program this timeline is for can edit it now. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added status to program. Also added a new access_check and changed the program edit template to the basic one without edit timeline button. Changed the program menu to show more helpful links like Edit Timeline. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Flush sidebar when creating a new entity Patch by: Sverre Rabbelier

Update site/home.html to match the new document structure Patch by: Sverre Rabbelier

Added a Create a New Program link to the Program Owners's menu. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Flush sidebar when creating site entity Patch by: Sverre Rabbelier

Brown paper bag fix We can only add the create link if there is a site entity. Patch by: Sverre Rabbelier

Made presence document retrievel specify prefix Patch by: Sverre Rabbelier

Added a 'create new document' link to site Patch by: Sverre Rabbelier

Remove simplejson module from our repository since it's a duplicate of django.utils.simplejson. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Use django.utils.simplejson in soc.views.models.base pick method instead of our standalone simplejson module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Add a 'Create new document' link for clubs, sponsors and programs Patch by: Sverre Rabbelier

Added a getCreateDocumentRedirect Patch by: Sverre Rabbelier

Add access control to document model and view The access checks are not yet written, but at least the model is stable from now on. Also converted the document view to dynaform while at it. Patch by: Sverre Rabbelier

Factor out the getPattern logic from params This is to facilitate it's use by the document view later on. Patch by: Sverre Rabbelier

Made the /create/<scope> url conditional The 'no_create_with_scope' parameter can be used to disable it. Patch by: Sverre Rabbelier

Removed unused key_fields_prefix variable Patch by: Sverre Rabbelier

Moved is_featured property to Document Only Documents can be featured in the sidebar, as such it makes sense to have this property in the Document model. Patch by: Sverre Rabbelier

Added missing dot. Patch by: Sverre Rabbelier

Copy the default django patterns rather than modifying them This prevents an ever-growing list of urls in the case that getDjangoURLPatterns is called multiple times. Patch by: Sverre Rabbelier

Added a clean_scope_path to cleaning Patch by: Sverre Rabbelier

Fix the notification bar messages that show up when you click 'Save Changes' button. It only works on Edit views right now. Patch by: Madhusudan C.S Reviewed by: Pawel Solyga

^_^, fixed header in templates/soc/request/list/heading.html. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Renamed state to status where appropriate. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Requests can now not be created when you already have a similar request or already have the role the request is for. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Moved clean_club_app_link_id to cleaning. This method is now also used by the club create_form. Which means that you cannot create a new club with an already reserved link_id until the club application has been rejected. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed group_app logic to support scope_path. Moved link_id only as keyvalues to club_app. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added a cleaning method to club_app view. This ensures that you can't create a application for an already taken Link ID. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed status in group app model to state. Also changed it wherever needed to increase consistency. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed clean_link_id to be in a wrapper form as well. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Deleted soc/models/member.py since it's the equivalent of club_member. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

docstring fix in soc/models/student.py. Patch by: Haoyu Bai Reviewed by: Lennard de Rijk

Added agreed_to_tos_on field in user and role model. Also the user and user_self view no properly handle this new field. The ToS will be shown on-screen (not in a nice way) only if it is in effect and a user has not signed it yet. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Cleaned up overly enthousiastic comments From the styleguide: On the other hand, never describe the code. Assume the person reading the code knows Python (though not what you're trying to do) better than you do. Patch by: Sverre Rabbelier

Properly check if a program is active Also cleaned up checkIsHost, which got merge-mangled when refactoring the access module. Patch by: Sverre Rabbelier

Factor out the allowIfCheckPasses logic Keep allowDeveloper around as convenience method though. Patch by: Sverre Rabbelier

Fix EOL damage and add link to first row item for notifcations Patch by: Sverre Rabbelier

Added menu entries for a specific Sponsor Entity. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed rights flushing Patch by: Sverre Rabbelier

Added resign as club admin and club member links to the club entity menu. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed docstring for checkIsAllowedToManageRole. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added manage view for Club Admins, Club Members and Hosts. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added checkIsAllowedToManageRole to access.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added manage redirect. Also changed the menu layout for group entities. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Edited existing templates to deal with the new fields in group model. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Redone access checks in club and sponsor model to deal with state property in their model. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Creating a new host or club_admin will set the group state to active if it's new. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Redone access checks concerning groups to deal with the state property. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added state and shipping address fields to group model. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

prefixing the link_id of a notification with a t for time to agree to the new link_id pattern. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fix regexp for link id format validation. Link id needs to start with ASCII lowercase and not with digit, which caused User Profile view to crash. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Fix typos in comments and help text in soc.models.program module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Added a simple slot allocation algorithm Comes with a whole bunch of tests, but not nearly enough. Patch by: Sverre Rabbelier

Update test to match new sidebar caching signature Patch by: Sverre Rabbelier

Add forgotten __init__.py to pymox Patch by: Sverre Rabbelier

Rename the confusing Tossed Model class to PresenceWithToS. Patch by: Todd Larsen Review by: to-be-reviewed

Added a 'allocations_visible' property to program Patch by: Sverre Rabbelier

Create a new Tossed layer in the MVC Also move is_enabled to program instead of presence. Patch by: Sverre Rabbelier

Add 'Flush Cache' button next to Admin link. It's visible only when working on dev_appserver locally. This is a quick way of flushing memcache. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Fixed the edit site view having a delete button Also a minor cleanup in group.py. Patch by: Sverre Rabbelier

Changed access.py to comply more with the style of the module.

Changed the Terms Of Service boolean so that it is None as long as the user owning the account has not Agreed to it. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed the verbose name for agrees_to_tos to I agree to the Terms of Service. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Removed default value for agrees_to_tos in soc/models/user.py Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Reverted r1646. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Redone the user's profile page. A user can now create his profile on /user/create_profile. A user can edit his profile on /user/edit_profile. Created new access checks to correctly allow access to the new profile page. Changed the /user/edit_self.html template to /user/edit_profile.html. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Renamed _getToSExampleText to getToSExampleText in soc/views/models/user.py. Removed a TODO that has already been done. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added default values to the User model. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added a TODO to soc/logic/models/site.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added new clean_agrees_to_tos to cleaning.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Allow for a program on/off switch Patch by: Sverre Rabbelier

Fix wrong order of decorators and some cleanup Patch by: Sverre Rabbelier

Add an 'edit' link to the program menu Patch by: Sverre Rabbelier

Allow for setting a edit_cancel_redirect Defaults to list view for the entity but can be overriden by setting the parameter manually. Falls back to history.go(-1) if not set. Patch by: Sverre Rabbelier

Make the user/edit.html template derive from soc/models/edit.html Patch by: Sverre Rabbelier

Also flush the user's ACL's when flushing the sidebar It is pretty pointless to flush the sidebar if the same ACL's will be re-used anyway, so make sure the ACL's are flushed as well. Patch by: Sverre Rabbelier

Style fixes in soc.views.helper.redirects and soc.models.base modules. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Add gmaps_api_key to context is settings entity exists. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Style fixes in soc.views.models modules. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Style fixes in soc.cache modules. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Style fixes in soc.logic.cleaning module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Style and import sorting fixes in tests modules. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Fixed typo's in soc/views/helper/dynaform.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Add grouping to the existing views Patch by: Sverre Rabbelier

Group dynamically generated menu items Also allow for grouping other views by setting the 'sidebar_grouping' param to a value another than 'main'. Patch by: Sverre Rabbelier

Bugfixes after recent refactoring Patch by: Sverre Rabbelier

Added Haoyu Bai to the AUTHORS file Patch by: Sverre Rabbelier

Allow appending to dynainclude/-exclude Patch by: Sverre Rabbelier

Reduce caching time of sidebar to 3 minutes Patch by: Sverre Rabbelier

Flush cache if user makes a document featured Also flush it if a new document is created as featured. Patch by: Sverre Rabbelier

Make tooltips work when tabbing Fixed the tooltips on IE, and changed the background colour to be nicer on Firefox. Patch by: Haoyu Bai <baihaoyu@gmail.com>

Cache access checks and disable sidebar caching Patch by: Sverre Rabbelier

Create a decorator for allowDeveloper Patch by: Sverre Rabbelier

Add profiling support to Melange. By assigning profile_main_as_logs or profile_main_as_html to main variable you can turn on profiling. profile_main_as_logs will log profile data to App Engine console logs, profile_main_as_html will show profile data as html at the bottom of the page. If you want to profile app on deployed app just set the profiling function and deploy it. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

soc/views/models/user.py now uses dynaform and appropriate cleaning methods. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added new clean methods in preparation for new User View. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fold checkAgreesToSiteToS into checkIsUser No use in having a check that's not used except in another checker anyway, so might as well fold it in. Patch by: Sverre Rabbelier

Removed unused URL pattern in soc/views/models/request.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed two access related bugs Patch by: Sverre Rabbelier

Added some very basic tests for the sidebar and access modules Also updated run.py to set the USER_EMAIL variable. Patch by: Sverre Rabbelier

Fix testing views, which broke because now we need to register a proxy for the memcache API as well. Patch By: Augie Fackler <durin42@gmail.com> Review By: TBR

Major refactor of the access module The first step to sanity is a leap into the unknown? Create an object to represent the access checks for each module instead of a bunch of loose functions. Converted all views and params.py to use the new access checker. Main differences: * arguments to a checker can be passed by using a tuple * checkers are referenced by string, rather than directly * the Checker constructor handles merging with child views Patch by: Sverre Rabbelier

Added a sidebar link for all users that accepted the ToS to a view that allows you to choose a club which you want to become a member for. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed method name in access.py to fix overwriting another method. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed typo in club sidebar entry. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added sidebar entries for club entities. Added the right['home'] to club and sponsor view. Fixed some comments in the group view. Also added a TODO for the sponsor sidebar entries. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added sidebar support for group instances. Also group now properly inherits from the presence view. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Flush the sidebar cache when a new active role entity has been created. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Add pymox to tests folder. Requested by Sverre. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Developers are hosts for every sponsor now. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Implemented the listing of all the roles in for a specific group. Removed a TODO about removing the tolist assignment in soc/views/models/host.py because this list is now obsolete. Added a TODO to change the redirect of the member listing once the manage page is done. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added flushing the sidebar when dealing with notifications. On request from Pawel Solyga. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Renamed checkIsHostForProgram to checkIsHostForSponsor. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added rights check to sponsor.py. In the process of doing so also fixed checkIsHostForProgram method in access.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

listRequests now only shows the requests that concerns the given group. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Renamed role_names to role_logic and made it a dictionary. It now maps a role_name to role_logic. This will be useful for listing for instance club members. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed a bug in access.py. Context was not assigned to a variable during a redesign of access.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added cache flush for the user who creates a group and the user whose role has been activated. As requested by Sverre Rabbelier. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added two needed redirects in role.py. To make this work properly group_view was added to params in club_admin and club_member. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Moved listRequests from club to group view. Added a TODO for adding request list to sidebar entry for every group. And for setting the rights for Sponsor view. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Flush the sidebar if a user's rights change Patch by: Sverre Rabbelier

Cache sidebar with a simple caching API We cache the sidebar once for every user, the downside is that once the user meets new access criteria, their sidebar does not get updated. This can be fixed by calling soc.cache.sidebar.flush() when appropriate. Patch by: Sverre Rabbelier

Rename ModelProperties to EntityProperties We use 'model' when referring to the db.Model, the context in which 'ModelProperties' was used we really mean 'entity', which refers to an instantiation of the model. Patch by: Sverre Rabbelier

Added getListRequestsRedirect to redirects.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Forgotten in last commit, the json template Patch by: Sverre Rabbelier

Added request listing for Club Admins. This page will redirect them to the Request Processing page. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed the title for the process_request webpage. Also removed some whitespace. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added getProcessRequestRedirect method to redirects.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added Club Members to SoC. Every user can request to become a Club Member. Club Admins can invite users. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added checkCanMakeRequestToGroup to access.py. Note that states for a group have not been implemented yet, so a TODO has been added for this check. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Moved getGroupEntityFromScopePath to logic/models/role.py. Also removed a TODO that has been done :). Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Have /entity/pick return a JSON object instead of a user view This is in preparation of a patch that will add a more fancy picker with JS. Patch by: Sverre Rabbelier

Add simplejson folder to build.sh script. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Add simplejson library to app folder. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Removed unused method from access.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Do not pass around request anymore in buildSidebar It is no longer needed since checkAccess doesn't require it. Patch by: Sverre Rabbelier

Remove the request and arg parameter from the checkAccess call They are obsolete with the introduction of kwargs (args was never needed in the first place). Patch by: Sverre Rabbelier

Use getSingleton in getUniversalContext Patch by: Sverre Rabbelier

Use ugettext instead of ugettext_lazy Reports from Matthew Wilkes indicate that the regular form of ugettext works just fine. The downside of ugettext_lazy is that it prevents pages containing ugettext_lazy-ed text cannot be memcached, since they cannot be pickled. Patch by: Sverre Rabbelier

Brown paper bag fix. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed a bug in _editPost for club_admin and host. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed clean_url to work with dynaform. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed a bug in _oncreate in soc/logic/models/club.py. Non-existing fields were set. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed user_logic call to it's convenience function getForCurrentAccount. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Coding style fix in views/models/role.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Parameterized patterns in role.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added request creation and processing to role.py. This is used if you want to request to become a certain role for a group. For instance becoming a club member. The process request view will also be used to cancel outstanding invites might this be necessary. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Add Madhusudan.C.S to AUTHORS. Fix docstring parameters list in soc.logic.models.base module Base class getForFields method. Patch by: Madhusudan.C.S Reviewed by: Pawel Solyga

Added checkCanProcessRequest in access.py. This is used in the upcoming Request patch. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Some style guide fixes, docstring fixes and removal of unused imports in different modules. Rename acceptInvite view variable to accept_invite in soc.views.models.host module to comply to our style guide. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix some missing dots in access and club_admin modules. Patch by: Pawel Solyga Review by: to-be-reviewed

Add missing parameter description to docstring of soc.views.models.base module methods. Patch by: Pawel Solyga Review by: to-be-reviewed

Make select link in _as_table_row.html a nice button instead of <a href>. Patch by: Pawel Solyga Review by: to-be-reviewed

Remove extra whitespaces and fix too long lines in soc.logic.helper.request module. Patch by: Pawel Solyga Review by: to-be-reviewed

Remove unused imports from soc.models.club_admin model. Patch by: Pawel Solyga Review by: to-be-reviewed

Remove extra blank lines in soc.views.models.request module. Patch by: Pawel Solyga Review by: to-be-reviewed

Rename acceptInvite view variable to accept_invite to comply to our style guide. Remove unused imports. Add missing blank lines in soc.views.models.club_admin module. Patch by: Pawel Solyga Review by: to-be-reviewed

Rename processInvite view variable to process_invite to comply to our style guide. Remove some not needed whitespaces. Fix listSelf method parameters docstring in soc.views.models.request module. Patch by: Pawel Solyga Review by: to-be-reviewed

Added missing dot to access.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Check if timeline exists and when somebody tries to edit non existing timelime display error message. Add TODO regarding error message customization for Timeline. Add support for calendar widget in timeline for both gsoc and ghop programs (gsoc was hardcoded before). Patch by: Pawel Solyga Review by: to-be-reviewed

Add missing blank lines and remove unused checkIsInvited function from soc.views.helper.access module. Patch by: Pawel Solyga Review by: to-be-reviewed

Rename soc/request/list/row.html template column class "to" to "for" since the name changed in header template. Patch by: Pawel Solyga Review by: to-be-reviewed

Add missing dots in soc.views.helper.redirects module function docstrings. Patch by: Pawel Solyga Review by: to-be-reviewed

Little change in soc.logic.hlper.request module completeRequestForRole function docstring. Patch by: Pawel Solyga Review by: to-be-reviewed

Refactored invite system from club_admin to role to make the system work with host as well. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed an access related bug in checkIsClubAdminForClub. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed bug in access.py concerning host checks. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Add a warning about discarding unsaved changes Also set the colspan of the label (on seperate row) to max. Patch by: Sverre Rabbelier

Changed the access checks to comply with state in request. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Make reference picker work for create too Caveat, it only works for one reference atm. Patch by: Sverre Rabbelier

Brown paper bag fix Patch by: Sverre Rabbelier

Do not crash if an invalid field name is entered Patch by: Sverre Rabbelier

Enable pick links for all the references we have Patch by: Sverre Rabbelier

Adust the as_table tag to render a pick link if appropriate The templates are adjusted to pass on a 'reference' value, which is the url_name of the view from which the entity should be picked. The as_table (and related) function(s) construct and then pass on this argument and enable takes_contex so that we have access to the context of the enclosing template. We only extract ReferenceProperties that end with '_link_id' since that is how all RP's are currently named. It is not possible to create a field with the same name as the RP, as GAE will try to interpret it's contents as the key of an entity before even calling any function we can override. Patch by: Sverre Rabbelier

Add a 'pick' view to the appropriate views Only views that represent entities that are pointed to by a ReferenceProperty at some point are considered 'appropriate'. Patch by: Sverre Rabbelier

Added a 'pick' view This view can be used to pick a specific document and then redirect to another view. Patch by: Sverre Rabbelier

Add redirects for the new pick view Patch by: Sverre Rabbelier

Add a simple access check for a picker The picker page should not be accessible if the required GET args are not present. Patch by: Sverre Rabbelier

Added missing changes from r1522. Eclipse found it funny not to save resources ^_^. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Renamed redirect methods to comply with the rest of the module. Added use for getInviteAcceptedRedirect in the soc/views/models/request.py process_invite view. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Replaced the boolean properties in soc/models/request.py with a state property. new : new Request group_accepted : The group has accepted this request completed : This request has been handled either following a creation of the role entity rejected : This request has been rejected by either the user or the group ignored : The request has been ignored by the group and will not give the user access to create the role Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Restore context in deny() page Now that we know when the sidebar is doing the access checks we can safely construct a new context in deny (without having to worry that it will try to do more access checks that result in deny, which will call for a new context... etc). Patch by: Sverre Rabbelier

Bugfixes to last commit Access rights for 'home' pages and an errornous endif tag. Patch by: Sverre Rabbelier

Removed club property from club_admin model. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Generate proper html instead of having nested <td> tags Patch by: Sverre Rabbelier

Hook up the 'home' view for site and program Also point to it in the sidebar's "home" link. Patch by: Sverre Rabbelier

Generate the 'edit settings' link dynamically We used to point to '/site/edit', which is rather lame for a generic presence template (especially since site has it's own template). Patch by: Sverre Rabbelier

Create a new 'home' view for Presences This also restores the 'show' view for Presences as there is no need to hide it with the 'home' view anymore. Patch by: Sverre Rabbelier

Added the new way to process invites for club_admin only. This patch contains the separability needed to ensure that we can successfully do the access checks we need. Host invites can for the time being only be completed by developers due to the reorganization. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added missing comment to soc/views/models/club.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed the request templates to match the changes to the model. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added missing role_verbose. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Redid removeRequestForRole to completeRequestForRole. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added verbose role name to the request model. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added various access methods in preperation for the new request system. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added state property to role model. This can be used when for instance a member has been removed from a club or a when a program has been marked inactive. Certain roles would then be shown on the upcoming roles page marked as previous roles. This would give us the archiving capability that was shown in the mockup. Patch by: Lennard de Rijk Reviewd by: to-be-reviewed

Renamed org property in club_admin model to club. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Add slots and student applications/tasks limit integer properties to the Program model. Patch by: Pawel Solyga Review by: to-be-reviewed

Change build.sh to create a build/ output directory (rather than release/). Patch by: Todd Larsen Review by: to-be-reviewed

Move make_release.sh to build.sh. This script creates a "build" really, not a release. A separate release.sh script should be written to automate the current manual release process (at some point...). Patch by: Todd Larsen Review by: to-be-reviewed

Remove unused decorators import from soc.views.models.role module. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix idention in soc.views.models.club module. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix missing dots in soc.views.helper.decoratos module docstrings. Patch by: Pawel Solyga Review by: to-be-reviewed

Rename clean_existing_user_not_equal_to_current function to clean_users_not_same in soc.logic.cleaning module and fix affected files. Patch by: Pawel Solyga Review by: to-be-reviewed

Hide the 'link_id' field for site Also construct the scope_path from the fields in case the entity has not yet been created. Patch by: Sverre Rabbelier

Rename "site/settings" to "site" The "/site/settings" view is not about the Site Settings an sich, but more about the "site presence singleton". In this context it does not make sense to call it "site/settings". Patch by: Sverre Rabbelier

Fixed one style error and one typo. Patch by: Lennard de Rijk

Presence is now a 'abstract' View, pull in members from program This is signified by the removal of params['name'] and other values that are required by params.py, but also by the removal of the 'view' definition at the bottom of the file. Patch by: Sverre Rabbelier

Extend dicts.merge to be (optionally) recursive This is very useful when dealing for views that expect to be inhereted from but wish to provide default values. Patch by: Sverre Rabbelier

Fix form errors and hidden form errors The conversion to django left out the 'prettyfying' of form and hidden form errors, as these could occur when running live, restore this behavior. Patch by: Sverre Rabbelier

Added a cleaning method for a LinkProperty Field. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed wrong conditional in soc/views/models/club_app.py. Notifications will now be send again. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed import sorting and indentation in soc/views/models/club.py Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Even developers need to agree to the terms of service for Melange Patch by: Sverre Rabbelier

Corrected the list index parameters in soc/views/models/club_app.py Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added Ignored applications to the list view. Also restored the New Club notification upon application acceptance. That broke in r1483. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Replaced boolean properties in soc/models/group_app with status property. This property has 5 choices ['accepted','rejected','ignored','needs review','completed'] Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Move getToSLink() to soc.views.helper.redirects.getToSRedirect(). Fixes a circular import problem that prevented the site-wide ToS link from being displayed by checkAgreesToSiteToS(). This is now completely implemented. Patch by: Todd Larsen Review by: to-be-reviewed

Tighten more checkIsUser() access to checkAgreesToSiteToS() instead. Update the checkIsHost() comment. Patch by: Todd Larsen Review by: to-be-reviewed

Make checkAgreesToSiteToS() the default access check for many other checks. Replace checkIsUser() with the more-strict checkAgreesToSiteToS(). Also, add missing args and kwargs parameters to checkAgreesToSiteToS() that were missed in the merge right before commit. Patch by: Todd Larsen Review by: to-be-reviewed

Add checkAgreesToSiteToS() (partially implemented until circular import fixed). Need to fix a circular import problem before the alternate message will include a link to the site-wide ToS Document. Also, fixed the descriptions in the first few check...() functions. Patch by: Todd Larsen Review by: to-be-reviewed

Take advantage of new "from ... import ... as ..." rules in the style guide. Patch by: Todd Larsen Review by: to-be-reviewed

Added clean_existing_user_not_equal_to_current to clean the backup Administrator field in an application. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed the redirect in club application overview to the correct page. Patch by: Lennard de Rijk

Changed checkIsClubAppAccepted into a more generic checkIsApplicationAccepted. Also fixed a minor bug in club_app view. Patch by: Lennard de Rijk

Changed the collection name and help text for Organization member template. Patch by: Lennard de Rijk

Added club_app model and logic. Patch by: Lennard de Rijk

Added created and last modified timestamps to the group_app model. Also edited the templates to show some extra information. The review template has the names for the new properties hard coded because the auto_add and auto_add_now datetimeproperties don't show up in the fields of the entity. Patch by: Lennard de Rijk

Fixed typo in r1446. Patch by: Todd Larsen Review by: to-be-reviewed

Changes in Role model. Clarified that we are asking for a shipping adress. Also moved Agrees to ToS to the bottom. Patch by: Lennard de Rijk

Fix trailing whitespace and apply decorators Patch by: Sverre Rabbelier

Fix whitespace damage Patch by: Sverre Rabbelier

Make use of the new decorators in all applicable views Patch by: Sverre Rabbelier

Renamed showReviewOverview to review_overview and reviewOverview Patch by: Sverre Rabbelier

Fixed two trivial bugs A "kwargs=kwargs" instead of **kwargs Missing 'and entity' check Patch by: Sverre Rabbelier

Added a merge_params and check_access decorator The merge_params decorator is very simple and takes self._params and merges it with params. It's main purpose is to explicitly mark the views in which it is intended that self._params is merged raw. The check_access decorator factors out the access checking process and passes args and kwargs to the access checking methods. Patch by: Sverre Rabbelier

Prepare access to receive args and kwargs as argument Also use two "magic values" when the sidebar is doing the access checks, this might be useful later. Patch by: Sverre Rabbelier

Reverted r1457. Patch by: Lennard de Rijk

Changed link in club_app accepted notification. Patch by: Lennard de Rijk

Added a new view to help with application -> group process. The applicant view is available only when there is an accepted application present. This will be checked by the access checker in an upcoming patch. The view uses a special form so that certain fields cannot be edited by the user. These fields correspond to important fields filled in during the application process. Create access for a club has now been set to Host level. Patch by: Lennard de Rijk

onCreate for a Club now marks any application for the same club as completed and invites the admins. This is useful for when the club has been created without using the application. Patch by: Lennard de Rijk

Edited the method used to clean link_id in params.py. Removed the clean_new_link_id from the logic/cleaning.py module because this is not used anymore. This method should be replaced by a method that is used after all the fields have been cleaned so that the actual key_name of an entity can be constructed. Patch by: Lennard de Rijk

Fixed a typo in the comments of soc/views/helper/forms.py Patch by: Lennard de Rijk

Fix missing import identified by pylint. ************* Module app.soc.logic.models.user E0602: 99:Logic.agreesToSiteToS: Undefined variable 'db' Patch by: Todd Larsen Review by: to-be-reviewed

Fix missing import identified by pylint. ************* Module app.soc.logic.models.presence E0602: 56:Logic.getToS: Undefined variable 'db' Patch by: Todd Larsen Review by: to-be-reviewed

Fix missing import identified by pylint. ************* Module app.soc.views.helper.responses E0602:187:getToSLink: Undefined variable 'db' Patch by: Todd Larsen Review by: to-be-reviewed

Add agreesToSiteToS() logic method to indicate if User accepts site-wide ToS. Patch by: Todd Larsen Review by: to-be-reviewed

Give error messages more room in the existing form field "as_table" templates. Patch by: Todd Larsen Review by: to-be-reviewed

Add a clean_agrees_to_tos() validator that requires "Yes" if ToS exists. Also, more user_logic.logic => user_logic fixes. If you are going to import "as", you might as well make the renaming worthwhile. Maybe we need to add a section on "import ... from ... as ..." in the style guide? Patch by: Todd Larsen Review by: to-be-reviewed

Change "Show" to "Export" missed in r1446 commit. Patch by: Todd Larsen Review by: to-be-reviewed

Add an export() view, and implement it as text/text for Document. For every Model except Document, the public() view is displayed for any attempts to access the export() view. Currently, the permissions for export() are the same as for public(). This seems reasonable for Document, since anyone could extract the raw HTML from the page source anyway. The permissions should probably be different for other types of exports, such as vCard or iCard exports of profiles, CSV exports of lists, etc. Patch by: Todd Larsen Review by: to-be-reviewed

If a site-wide ToS exist, display the User profile "Agrees to ToS" checkbox. Patch by: Todd Larsen Review by: to-be-reviewed

Set agrees_to_tos example text to link to site-wide ToS (or a warning message). Also, since a renaming import statement is being used already, change user_logic.logic to just user_logic. Patch by: Todd Larsen Review by: to-be-reviewed

Do not crash on *every* page load if there is no ToS Document. 'tos' ReferenceProperty might be present, but still be None. Patch by: Todd Larsen Review by: to-be-reviewed

A better way to add site-wide ToS link to *all* pages on the site. getUniversalContext() already fetches a copy of the Site settings, so use that to see if the site-wide ToS exist and produce a link. Patch by: Todd Larsen Review by: to-be-reviewed

Linux /bin/sh (GNU) is not the same as OS X /bin/sh (BSD), so use /bin/bash. Fixes: scripts/pylint/do_pylint.sh: 27: Syntax error: "(" unexpected on Ubuntu (and possibly other Linux distros). Patch by: Todd Larsen Review by: to-be-reviewed

Replace css class 'notice' that is used in User profile template field help text with new 'fieldhelptext' class. Notice is part of CSS for notification bar and we want width limit just for field help text not for notification bar text. Patch by: Pawel Solyga Review by: to-be-reviewed

Add getSingleton() method to return the Site settings entity. There is always only one Site entity, referred to by DEF_SITE_LINK_ID. Patch by: Todd Larsen Review by: to-be-reviewed

Return the ToS Document of the supplied Presence entity, if there is one. Patch by: Todd Larsen Review by: to-be-reviewed

Support HTML tags in form field example_text column. Improve the Program Model example_text as an example. Patch by: Todd Larsen Review by: to-be-reviewed

Disable R0801 messages in pylintrc. R0801 messages indicates that a set of similar lines has been detected among multiple file. This usually means that the code should be refactored to avoid this duplication but in our case it's useless since it shows a lot of imports code or authors. Patch by: Pawel Solyga Review by: to-be-reviewed

Add calendar widget support for timeline fields. Fix docstring typo in soc.views.models.timeline module. Add timeline edit template which loads necessary javascript files for datetimepicker widget. Patch by: Pawel Solyga Review by: to-be-reviewed

Remove member_template from extra_dynaexclude in soc.views.models.club since member_template is only available in Organization as of recent commit. Patch by: Pawel Solyga Review by: to-be-reviewed

Add the agrees_to_tos property to Roles (as its own changeset this time...). Patch by: Todd Larsen Review by: to-be-reviewed

Make getToSLink() an actual method for re-use by others. Uses the views.helper.redirects module to create the /document/show path, instead of hard-coding it as a format string. Patch by: Todd Larsen Review by: to-be-reviewed

Fixed EOL and whitespace damage Patch by: Sverre Rabbelier

This file should not have been included in r1428. Reverting... Patch by: Todd Larsen Review by: to-be-reviewed

Changing ReadOnlyBool to type "text" makes it display "True" or "False". Patch by: Todd Larsen Review by: to-be-reviewed

When constructing the sidebar don't overide 'sidebar' Instead specify 'sidebar_additional' and include it even if there is a 'sidebar' defined. Patch by: Sverre Rabbelier

Add datetimepicker javascript widget files and css file. Patch by: Pawel Solyga Review by: to-be-reviewed

Set notice width to 450px. It was way too long. Notice is displayed with help text on yellow background in User profile. Patch by: Pawel Solyga Review by: to-be-reviewed

Add missing blank line in soc.views.helper.params module. Fix docstring typo in soc.views.models.role module. Add missing dots at the end of sentences in soc.logic.cleaning and soc.view.models.user_self modules. Patch by: Pawel Solyga Review by: to-be-reviewed

Add missing 'of' word to list description strings in soc.views.models.club_app module. Patch by: Pawel Solyga Review by: to-be-reviewed

Add missing blank lines and dots in soc.views.helper.templatetags.forms_helpers module. Patch by: Pawel Solyga Review by: to-be-reviewed

Move member_template property from Group to Organization model since it's Organization specific property. Patch by: Pawel Solyga Review by: to-be-reviewed

Disable R0201 message in pylintrc since we allow for that kind of methods. R0201 tells us that method could be a function. Used when a method doesn't use its bound instance, and so could be written as a function. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix typo in settings.py (missing '>' character). Patch by: Pawel Solyga Review by: to-be-reviewed

Add missing dots in docstrings. Add sendNotification parameters description to docstring in soc.logic.helper module. Patch by: Pawel Solyga Review by: to-be-reviewed

Added missing import to views/models/notification.py Patch by: Lennard de Rijk

Users now have the right to delete their own notifications. Patch by: Lennard de Rijk

Load /Users/solydzajs/Downloads/google_appengine into trunk/thirdparty/google_appengine.

Split the notification list in read/unread Patch by: Sverre Rabbelier

Add an unread count indication next to the notification link Similar to how this is done in gmail. Patch by: Sverre Rabbelier

Use 'from .. import .. as ..' in user_self Patch by: Sverre Rabbelier

Fixed whitespace and EOL damage Patch by: Sverre Rabbelier

Add a 'pending/accepted/denied' seperation to club_app list This is not only to make it easier to see which applictions have been accepted, but also to make it possible to redirect to /club/create for the accepted applications, rather than to /club_app/edit. Patch by: Sverre Rabbelier

Fixed whitespace damage Patch by: Sverre Rabbelier

Send a notifcation if a club application is accepted Patch by: Sverre Rabbelier

Factor out sendNotification from sendInviteNotification This makes it easier to create different types of notifications, such as a sendNewClubNotification. Patch by: Sverre Rabbelier

Fixed whitespace and EOL damage Patch by: Sverre Rabbelier

Fixed whitespace damage Patch by: Sverre Rabbelier

Added club_admin templates. Patch by: Lennard de Rijk

Added Mario Ferraro to the AUTHORS list. Patch by: Lennard de Rijk

Tooltips now properly disappear when another text box with a tooltip has been highlighted. Also known as Issue 132. Patch by: Mario Ferraro Reviewed by: Lennard de Rijk

Implement the checkIsClubAppAccepted function Also added a stub for checkIsClubAdminForClub. Patch by: Sverre Rabbelier

Display state (but dis-allow edits) of User's agrees_to_tos boolean Property. Patch by: Todd Larsen Review by: to-be-reviewed

Add read-only boolean form field widget. Developers should be able to view, but not change, the User's agrees_to_tos state. Patch by: Todd Larsen Review by: to-be-reviewed

Add "agrees to site-wide Terms of Service" boolean property for all Users. Patch by: Todd Larsen Review by: to-be-reviewed

Hide 'tos' pull-down selector from Program profile forms. Until a way to select Documents for use as the Terms of Service for a Program exists (see http://code.google.com/p/soc/issues/detail?id=151), there is no point in hacking in scope_path and link_id fields here. The per-Program ToS feature will just be unavailable until an appropriate Document selector exists. Patch by: Todd Larsen Review by: to-be-reviewed

Hide 'tos' pull-down selector from Group profile forms. Until a way to select Documents for use as the Terms of Service for a Group exist (see http://code.google.com/p/soc/issues/detail?id=151), there is no point in hacking in scope_path and link_id fields here. The per-Group ToS feature will just be unavailable until an appropriate Document selector exists. Patch by: Todd Larsen Review by: to-be-reviewed

Hide 'tos' pull-down selector from Site Settings forms. Patch by: Todd Larsen Review by: to-be-reviewed

Hack in tos_scope_path and tos_link_id to select Terms of Service Document. Patch by: Todd Larsen Review by: to-be-reviewed

Show Terms of Service link in footer if tos_link is defined in the context. Patch by: Todd Larsen Review by: to-be-reviewed

Add a ReferenceProperty pointing to a Terms of Service Document. Patch by: Todd Larsen Review by: to-be-reviewed

Fixed a bug that was triggered on manual club creation without an application. Now also sets the application_completed flag upon club creation. Patch by: Lennard de Rijk

Fixed missing params in views/models/club_app.py. Patch by: Lennard de Rijk

Added Club Admin model, logic, and view Patch by: Sverre Rabbelier

Invite (backup-)admin when creating a club Patch by: Sverre Rabbelier

Added a create method that uses an existing application Patch by: Sverre Rabbelier

Construct names automatically from base name. Saves a lot of typing for the common case Patch by: Sverre Rabbelier

Fixed a wrong method being called when accepting/declyning an application. Patch by: Lennard de Rijk

Added basic review functionality for club applications. The access rights are open for discussion. The review page uses GET data to determine the decision made by the user. For convenience the Review Club Applications button directs you to a multi-list view so you can see the state of different applications. The review state will reset whenever the application has been changed using the edit form. Patch by: Lennard de Rijk

Fixed a typo in the comment in helper/access.py. Patch by: Lennard de Rijk

Added control fields to group_app. Moved unnecessary fields containing questions about past participation from group_app to org_app. Updated the club_app public page to show the correct information using twoline layout. Patch by: Lennard de Rijk

Added _readonly_field_as_twoline_table_row . Patch by: Lennard de Rijk

Resolved a bug when editing a timeline. Scope path is now set correctly when editing a timeline. Patch by: Lennard de Rijk

Fixed line-ending and whitespace damage Patch by: Sverre Rabbelier

Added the club_app view, logic and model Patch by: Sverre Rabbelier

Removed unneeded params from club Patch by: Sverre Rabbelier

Moved the member_template field to app and removed 'optional' Also shortened the verbose_name of the member_template field. Patch by: Sverre Rabbelier

Factored out the clean_existing_user method Patch by: Sverre Rabbelier

Fix login link Without the leading slash the link does not work on appspot. Patch by: Sverre Rabbelier

Fixed a typo in the group_app model Patch by: Sverre Rabbelier

Added a twoline_edit.html page An as_twoline_edit template tag was added for this purpose. This tag renders the label field on a seperate line. Patch by: Sverre Rabbelier

Fix missing dots at the end of sentences in docstring and fix wrong import sorting in soc.logic.helper.notifications module. Patch by: Pawel Solyga Review by: to-be-reviewed

Extract BSD license text into a separate file to make it easier to find. Patch by: Todd Larsen Review by: to-be-reviewed

Fixed missing files in r1364. Patch by: Lennard de Rijk

Fix the setup of the test environment, including clearing the datastore between tests.

Add support for coverage to our testing system.

Added support for creating clubs. Patch by : Lennard de Rijk

Added support for mutliple edit forms based on entity type This makes it possible to have different edit forms in timeline based on which workflow type is used. Patch by: Sverre Rabbelier

Added an 'edit timeline' button to the program edit page Also made the create timeline functionality use the logic modules introduced in the previous commit. Patch by: Sverre Rabbelier

Started on edit timeline Added a gsoc timeline logic module. Also added a scope_path as the key_field to timeline. Updated the django_paterns to only include the edit field and removed link_id as dynafield. Patch by: Sverre Rabbelier

Fixed missing import in soc/models/organization.py. Patch by: Lennard de Rijk

Add hard-coded GroupApplication and OrgApplication Models. These are being hard-coded because the "real" Question/Answer/Quiz/Response implementation will not be ready any time soon. Patch by: Todd Larsen Review by: to-be-reviewed

Mailing list EmailProperty should be StringProperty instead, so that it is possible, for example, to supply a Google Group URL for sign-up purposes. Patch by: Todd Larsen Review by: to-be-reviewed

Add IRC channel and mailing list properties to the Group and Organization Models. Patch by: Todd Larsen Review by: to-be-reviewed

Typo and style fixes. Patch by: Pawel Solyga and Lennard de Rijk

Fixed a bug where a new timeline would get created on every edit of an existing program. Patch by: Lennard de Rijk

Added an elementary workflow choosing method to program creation. Patch by: Lennard de Rijk

Added logic and view classes for the Timeline model Patch by: Sverre Rabbelier

Sorted build.py's sitemap.addPages lines Patch by: Sverre Rabbelier

Made Program reference Timeline Also made Timeline inherit from base like it should. Patch by: Sverre Rabbelier

Copy/paste fix Typo fix: s/founder/program Patch by: Sverre Rabbelier

Added a basic Timeline model The timeline model will contain the deadlines and time ranges for the individual programs. Patch by: Sverre Rabbelier

Set no_create_with_key_fields paramater to True for Notifications. Patch by: Lennard de Rijk

Revert "Overwrite default patterns in views/models/notification.py to disallow certain URL's." This should instead be done by setting the no_create_with_key_fields parameter to True. Patch by: Sverre Rabbelier

Allow disabling of the create url with key_fields Patch by: Sverre Rabbelier

Overwrite default patterns in views/models/notification.py to disallow certain URL's. Patch by: Lennard de Rijk

Fixed a too long line in logic/helper/notifications.py Patch by: Lennard de Rijk

Added base template for notification messages. This makes the messages a bit more friendly by including a greeting and signature. Patch by: Lennard de Rijk

Added email message when receiving a notification.py At the moment this only triggers when the new notification is your first unread message. Also fixed an url bug in the invite notification. Patch by: Lennard de Rijk

Changed invitation email and into a notification. Also changed the public template for Notification to allow HTML code. Patch by: Lennard de Rijk

Remove unused imports and variables in different soc.views.models modules. Patch by: Pawel Solyga

Remove unused import in soc.views.hlper.templatetags.forms_helpers module. Patch by: Pawel Solyga

Since DbModelForm has been renamed to BaseForm change super() call from BaseForm to djangoforms.ModelForm in soc.views.helper.forms module. Patch by: Pawel Solyga

Some docstring fixes and unused import removal in soc.logic.models.site module. Patch by: Pawel Solyga

Fix inheritance in soc.models.base module. FieldsProxy inherited from DbModelForm which was deleted in previous commits (replace that with BaseForm). Patch by: Pawel Solyga

Fix too long lines in soc.logic.helper.notifications module. Patch by: Pawel Solyga

Remove unused import in soc.logic.accounts module. Patch by: Pawel Solyga

Remove unused imports in models modules. Patch by: Pawel Solyga

In soc.views.models.notification module remove unused imports, add missing white space, change list() method definition to comply with base View list() method declaration. Add missing Meta class docstring. Patch by: Pawel Solyga

Fix import sorting in soc.views.helper.access module and rename 'host' to 'Program Administrator'. Patch by: Pawel Solyga

Remove not used TYPE_NAME, TYPE_NAME_SHORT and TYPE_NAME_PLURAL consts in all Group models. Patch by: Pawel Solyga

Add missing dots, fix imports sorting and too long lines in different modules. Add TODO in soc.views.models.host module. Patch by: Pawel Solyga

Have user/edit.html use the as_table tag as well Patch by: Sverre Rabbelier

Removed unused template Patch by: Sverre Rabbelier

Converted as_table to be a template tag This allows us to move all the HTML from python code (which made it extremely icky and unreadable) to Django templates, which is _a lot_ more readable, and makes it feasable for HTML/CSS experts to change the way these tables are generated. Patch by: Sverre Rabbelier

Added some example_text to program Patch by: Sverre Rabbelier

Added support for example texts Initial patch by Benjamin, some minor fixes by Sverre. Patch by: Benjamin Lyaunzbe, Sverre Rabbelier

Brown-paper-bag fix in notification.py Was missing a leading slash in the redirect. Patch by: Sverre Rabbelier

Notification property has_been_read changed into unread Due to comments on r1309. Patch By: Lennard de Rijk

No override needed in notifications.py The only downside is that the ?s=0 parameter will still be appended but is not handled in list(). The right solution would be to update list() so that it does say "Message Sent" or such, to give the user an indication that their message was sent succesfully. Patch by: Sverre Rabbelier

Make it possible to redirect anywhere after editPost This makes it possible to not include the suffix in the redirect by making it a named parameter. Patch by: Sverre Rabbelier

Make the place of the rights declaration consistent Other code places it at the top, so we should do that in notification as well. Patch by: Sverre Rabbelier

Remove custom override of django_patterns_defaults Instead restrict access to the edit method, also, there is no need to set the default access to allow. Patch by: Sverre Rabbelier

Fix whitespace and EOL damage in notifcation.py Patch by: Sverre Rabbelier

Make use of readonly_field_as_table_row Instead of manually typing out the <br /> etc. Patch by: Sverre Rabbelier

Fix EOL-damage We use \n for line endings, so remove the \r from public.html Patch by: Sverre Rabbelier

Make checkIsMyInvitation use Django to parse the URL Using django is more reliable and makes the code easier to read as there is no knowledge of the url layout required. Patch by: Sverre Rabbelier

Added a readonly_multiline_field_as_table_row tag This is useful when a field is allowed to include newlines. Patch by: Sverre Rabbelier

Using getForCurrentAccount where possible due to comments on r1309. Patch by: Lennard de Rijk

Added Notifications. Notifications will primarily be used to serve the user information message like "New Request Pending". The system can be expanded later on to a messaging system. If you are a developer you can create message by going to notification/create . This has been done so the system can easily be tested. But will of course be visible in an easy-to-access location when the transition to a message system has been made. Patch by: Lennard de Rijk

Filter the "list Hosts" view This way only those Hosts are shown that belong to a Sponsor the user is a host for. Patch by: Sverre Rabbelier

Allows a user object to be passed to accounts.isDeveloper This saves a trip to the database if the user object has already been retrieved. Patch by: Sverre Rabbelier

Make getForFields use the db.Query API While at it, add support for the IN statement in the form of a value of the list type. Patch by: Sverre Rabbelier

Added getForCurrentAccount to user.Logic It returns the user entity associated with the currently logged in user. Patch by: Sverre Rabbelier

Added a filter method to dicts The best way to explain this is probably with an example: >>> split({'foo':'bar', 'bar':['one', 'two'], 'baz': ['three', 'four']}) [{'bar': 'one', 'foo': 'bar', 'baz': 'three'}, {'bar': 'two', 'foo': 'bar', 'baz': 'three'}, {'bar': 'one', 'foo': 'bar', 'baz': 'four'}, {'bar': 'two', 'foo': 'bar', 'baz': 'four'}] Patch by: Sverre Rabbelier

Make it possible to invite another Host as Host We do this by asking Django to resolve the current url for us, then reshufle that url and ask Django (again) to resolve that new url. From that resolved url we know the appropriate view, and as such we know which rights dictioanry to pass to access.checkAccess. Patch by: Sverre Rabbelier

Added a trivial unzip method, counterpart to zip Patch by: Sverre Rabbelier

Add some ignore properties for when we get working coverage support.

Fixed missing header in site settings. Also known as Issue 146. Patch by: Lennard de Rijk

Changed "Sponsor" to "Program Owner" Changed "Host" to "Program Administrator" Patch by: Lennard de Rijk

Adds the removal of requests from the datastore when a new role entity is created. This uses the classname from the role entity as the type of role in the request. Patch by: Lennard de Rijk

Add missing dots in docstrings, proper sorting of imports and small docstring typo fixes. Patch by: Pawel Solyga

Thinkofix in access.checkIsInvited Patch by: Sverre Rabbelier

Some forgotten changes with the access_type commit Patch by: Sverre Rabbelier

Program Name column showed link_id instead of name, replace link_id with name in soc/program/list/row.html template. Patch by: Pawel Solyga

Add explicit access_types from the url This does two things, it reduces the amount of repeated data (e.g., the checkAccess used to repeat the access_type that was already specified in the url). At the same time, it allows for example the 'create' page to push its access_type to 'edit'. Patch by: Sverre Rabbelier

Add checkIsHost in access Patch by: Sverre Rabbelier

Some cleanups in role.py and site.py and create() Patch by: Sverre Rabbelier

Changed template for home/public.html to show last modified in the top-right corner. Patch by: Lennard de Rijk

Add site scoped documents to the Site menu This allows for featured documents that belong to the Site scope to show up in the 'Site' menu. Patch by: Sverre Rabbelier

Move document sidebar entries extraction to document.View This way other modules can benefit from the same logic. Also make use of the sidebar.getSidebarMenu method so that getMenusForScope is no longer specific to full menu's. Patch by: Sverre Rabbelier

Factor out sidebar entry construction This makes it possible to reuse this logic in other modules as well, preventing code duplication. While at it, move additional_sidebar merging before the other entries (additional entries should go first, since the other entries are mostly dev-only etc). Patch by: Sverre Rabbelier

Rename getSidebarLinks to getSidebarMenus Patch by: Sverre Rabbelier

Remove bogus scope from Site This makes Site an unscoped entity (similar to how User and Sponsor do not have a scope). Patch by: Sverre Rabbelier

If an entity is unscoped, do not try to retrieve a scope Patch by: Sverre Rabbelier

Dynamically add sidebar items for programs This adds sidebar items for programs as appropriate. From the docstring: A menu item is generated for each program that is currently running. The public page for each program is added as menu item, as well as all public documents for that program. Additionally, we allow access to a program's public page to everyone, even if the user is not logged in. Patch by: Sverre Rabbelier

Add and use a placeholder for checkIsDocumentPublic We should somehow decide whether a document is publically viewable. This should of course be dependant on what the document is, e.g. the FAQ of a program should be allow(), whereas a student's application should be checkIsMentor(). Patch by: Sverre Rabbelier

Added a public redirect Also some minor cleanups in the redirects code. Patch by: Sverre Rabbelier

Prepare for callbacks that return more than one menu This paves the way for callbacks that dynamically construct their menu based on in-db content, such as Programs and Documents. Patch by: Sverre Rabbelier

Make use of the 'sidebar' param for user_self Instead of overriding getSidebarLinks we use the sidebar param since user_self is now in it's own View. Patch by: Sverre Rabbelier

Fixed email adress in urls.py. Patch by: Lennard de Rijk

Fixes 'module' object has no attribute 'handler500' and 404 on instances where debug is False. Patch by: Lennard de Rijk

Fixed the header on the List Programs page. Patch by: Lennard de Rijk

Reset the RELEASE_TAG to None (unreleased) now that the 0.1a20081206 release candidate branch has been created. Patch by: Pawel Solyga

Set RELEASE_TAG to 0.1a20081206rc for release candidate 06/12/2008. Patch by: Pawel Solyga

Fix imports sorting in soc.views.models.organization. Patch by: Pawel Solyga

Add missing dots in docstrings in modules. Patch by: Pawel Solyga

Changed generic_name to group_label in models/program.py. Also I've updated the comments and help text to explain the meaning of this field. Patch by: Lennard de Rijk

Updated to the latest version of upload.py Patch by: Sverre Rabbelier

Load ../../google_appengine_1.1.7/ into trunk/thirdparty/google_appengine.

Comment fixes for state in group and role model. Patch by: Lennard de Rijk

Fix for randomely ocurring bug The bug and it's fix are described by the first comment from Guido in http://code.google.com/p/googleappengine/issues/detail?id=772. Patch by: Guido van Rossum

Changed state property for models/group.py to be optional as the description states. Patch by: Lennard de Rijk

Added organizations Really basic for now, next stop is to have a proper document selector for the Presences. Patch by: Sverre Rabbelier

Cleanups in group and program The missing super call in group prevented the scope from being set as it should be. Patch by: Sverre Rabbelier

Added a new create regexp in urls for just scope_path Now that scope_path is properly defined we can add a url matching just the scope path. This allows some other custom create regexps to be removed/rewritten. Note: It needs to be -after- the full key_name regexp, since for arbitrarily nested scopes it would always match as just scope_path, even if there are other fields needed after the scope. Patch by: Sverre Rabbelier

Introduce dynamic scope_path regexps Instead of relying on scope_path's being "one slash deep", we should instead allow for either: 1. scope_paths that have a pre-defined depth 2. scope_paths that can be arbitrarily deep We achieve 1 by setting an entities scope_logic to another logic module. We then recursively call getScopeDepth until we get to the topmost entity (that is, an unscoped entity). A little different is the solution to 2, since some entities can have an arbitrarily deep scope (such as Documents), we need to have some way of signaling this to getScopePattern. A clean solution is to return None, rather than a number. If None is returned, the SCOPE_PATH_ARG_PATTERN is returned as regexp instead, which will match an arbitrarily deeply nested scope. The solution for 2 requires that we return None somewhere in the scope_logic chain, the most straight forward method to do so is to override getScopeDepth anywhere such a scope is needed and make it return None. A more elegant solution however, is to set the scope_logic to that module in all entities that require it. Patch by: Sverre Rabbelier

Added a linkable logic module The linkable logic module is used to signal the fact that the scope of an entity can be any linkable. Patch by: Sverre Rabbelier

Fix scope lookup for unscoped entities As scope_logic is now always set (since r1250), we need to check if it is None, rather than check if it exists. Patch by: Sverre Rabbelier

Swap the order of request key fields This will make it easier to remove scope_path as explicit key field at some point by having it as inplicit key field for all entities. Patch by: Sverre Rabbelier

Use key().name() instead of link_id This is now possible because key_name is constructed purely from the key fields of an entity. It is not sufficient to use just link_id, that works only for single-scoped entities (e.g., those that either do not have a scope, or that have a scope which itself does not have a scope). It would break if there was an entity that has a scoped scope (it would only include the scope's link_id in the url, which made it impossible to look up the scope as we missed the link_id of the scope's scope). Patch by: Sverre Rabbelier

More DI on scope_logic Patch by: Sverre Rabbelier

Partial revert Last commit contained some changes that did not belong there, revert them for now. Patch by: Sverre Rabbelier

Some more cleanups in base.Logic Patch by: Sverre Rabbelier

Apply DI on the scope logic Patch by: Sverre Rabbelier

Removed unused file path_link_name Patch by: Sverre Rabbelier

Remove unneeded method getSuffixValues Patch by: Sverre Rabbelier

Some style and typo fixes in different modules. Patch by: Pawel Solyga

Some more import sorting fixes and docstring typos in program modules and soc.views.helper.redirects module. Patch by: Pawel Solyga

Fix import sorting and docstring typos in soc.views.models.program module. Patch by: Pawel Solyga

Fix import sorting in soc.views.sitemap.build module. Patch by: Pawel Solyga

Some style fixes in soc.logic.helper.notifications module. Little changes in welcome.html template. Patch by: Pawel Solyga

Make base.View.create lookup the scope if appropriate Also re-introduce the custom description of the list selection for the redirection. Patch by: Sverre Rabbelier

Make use of the new generic key_name by lookup up scope_path This way base classes do not have to look up the 'scope' property, instead they can rely on the base class to do it for them provided they define the 'scope_logic' param. Patch by: Sverre Rabbelier

Change the key name to not include entity type This allows for direct lookup by scope_path, rather than having to do more complex things. Patch by: Sverre Rabbelier

Introduced django_extra_patterns This way no classes ever need to override the getDjangoURLPatterns, which results in less code, which is also more clear (that is, it is immediately obvious that a View adds an extra mapping if it sets the new django_extra_patterns value, or that it overrides the mapping when it sets django_patterns_defaults. Patch by: Sverre Rabbelier

Make scope_path required for program Patch by: Sverre Rabbelier

Factor out the Group part of Sponsor This makes it possible to reuse the Group logic. Patch by: Sverre Rabbelier

Rename role.RoleView to role.View Patch by: Sverre Rabbelier

Cleanups in the views module Mainly rename from original_params to new_params (so that the keyword argument in the __init__ method is the same for all). Also use super(View, self) where appropriate. Patch by: Sverre Rabbelier

Cleanups to the logic module Mainly converting to super(Logic, self) and adding some missing empty lines while at it. Patch by: Sverre Rabbelier

Fixed the 'New Host' link Also removed the 'Invite Host' button from the Sponsor view now that the link is working. Patch by: Sverre Rabbelier

Make the 'select entity' View generic This allows the selection of any entity from an arbitrary View by specifying the 'target view' and the redirect function. Patch by: Sverre Rabbelier

Cleanups in preparation of general selector view Renamed LIST... to DEF_LIST since it is a global definition. Renamed getCreateProgramRedirect to getCreateRedirect since it will work on all entities as it uses params. Added a getParams method to base.View Updated selectSponsor as appropriate. Patch by: Sverre Rabbelier

Remove the logic parameter from getListContent Now that params always has a 'logic' attribute, we can use that instead of requiring that it is passed as argument. Patch by: Sverre Rabbelier

Changed clean_link_id to convert the input to lower characters for user comfort. It has been changed in a couple of files, most importantly in logic/cleaning.py wich will be used by future forms to do their cleaning. Patch by: Lennard de Rijk

Finish Program Added some fields, and made TinyMCE the editor for the description field. Also updated the public page to show these new fields. We really need generic public views... Patch by: Sverre Rabbelier

Brown paperbag fix in recent cycle breaking Self is no longer used, 'error' should be used instead. Patch by: Sverre Rabbelier

Swap order of merged params to fix sponsor select view The sponsor select view (in 'create new program') was showing the wrong information (and also using the wrong list template) because the order in which the params were merged was wrong way around. This fixes that and at the same time fixes the 'instruction_text' attribute, which should be named 'list_description' instead. At the same time we lookup and set Sponsor as the scope of the newly created program. Patch by: Sverre Rabbelier

Remove cyclic imports by moving response method of out_of_band.Error class to soc.views.helper.responses module as errorResponse function. Apply changes to affected files. Patch by: Pawel Solyga

Remov unused import from Quiz model and add missing blank line. Patch by: Pawel Solyga

Remove Great Britain from country list. Great Britain was included as a country, although it has a country code (.gb) it's not a state. United Kingdom is correct and remains in the list. Patch by: Matthew Wilkes Review by: Pawel Solyga

Added programs Currently the programs are somewhat of empty, but due to the ease with which we can add new fields later, it is acceptable to commit it in it's current form. Patch by: Sverre Rabbelier

Allow for extra dynamic fields for the create form Also some minor cleanups, such as making base.Logic inherit from object, as per the style guide. Patch by: Sverre Rabbelier

Fixed a styling error. Patch by: Lennard de Rijk

Added User welcome message. Added templates/soc/mail/welcome.html as a template for the message. Also fixed a cyclic import that was about to happen in notifications.py.

Some docstring fixes in few modules (soc.views.helper soc.views.models.base). Patch by: Pawel Solyga

Add missing dot and correctly sort imports in soc.logic.helper.notifications module. Patch by: Pawel Solyga

Some docstring and missing blank lines fixes in soc.views.sitemap modules. Patch by: Pawel Solyga

Sponsor name now shows in List Hosts. Patch by: Lennard de Rijk

Moved sendInviteMessage to a new module in logic/helper/notifications.py. Renamed sendInviteMessage to sendInviteNotification. Removed the now obsolete imports in logic/models/request.py. This has been done to keep the models/logic modules clean.

Changed email address in logic/models/base.py. Patch by: Lennard de Rijk

Allow developers access to anything that does a checkIsInvited. Patch by: Lennard de Rijk

Remove unused imports from some modules. Patch by: Pawel Solyga

Fix typo and too long lines in soc.logic.models.request module. Patch by: Pawel Solyga

Add missing import, remove unused import and add missing parameters to methods in soc.views.models.user_self module. Patch by: Pawel Solyga

Add missing dots and fix too long line in soc.views.helper.dynaform module. Remove unused imports in soc.views.models.document module. Fix too long lines. Add missing docstring for Meta classes. Patch by: Pawel Solyga

Add module docstring and license for soc, soc.models, soc.views.helper.templatetags. Patch by: Pawel Solyga

Remove python-graph from thirdparty, remove check_includes script and graph folder from scripts. This functionality is (cyclic imports check) is supported by pylint automatically so we don't need that any more. Patch by: Pawel Solyga Review by: Sverre Rabbelier

Fix too long lines in soc.views.models.request, remove unused imports and change pending requests list description. Remove unused imports from soc.logic.path_link_name module. Patch by: Pawel Solyga

Add missing dots in soc.logic.lists module. Change method names to comply with Style Guide. Make class variable protected by adding "_" to the name of variable. Update lists templates respectively (methods name change). Patch by: Pawel Solyga

Remove unused imports in soc.views.models role, host and site modules. Add missing parameter in getDjangoURLPatters method. Patch by: Pawel Solyga

Remove unused imports in soc.views.models.user and soc.views.models.sponsor modules. Patch by: Pawel Solyga

Remove unused import in soc.models.task. Patch by: Pawel Solyga

Fix too long lines in soc.model.work. Patch by: Pawel Solyga

Put the redirects in the views/helper/redirects.py module. Changed the getCreateRequestRedirect to comply with the new signature. Also changed it's docstring to a more suitable one. Fixed a useless merge in views/models/role.py in the process.

Style fixes for previous commit We also need to run pylint. Patch by: Sverre Rabbelier

Added invitation received message upon creating a new invite. Moved the inviteAcceptedRedirect into the logic code. Added a TODO for further user notification upon creating a request. Patch by: Lennard de Rijk

Now invited users can create a new Host profile Before the invited user had to be a developer for this to work. Now, instead the default checkIsDeveloper check for the 'edit Host', a custom checkIsInvite check is used. Patch by: Sverre Rabbelier

Fixed requests not working anymore We really need a test suite. Patch by: Sverre Rabbelier

Fixed a bug in latest commit Patch by: Sverre Rabbelier

Moved getSidebarLinks to sitemap.sidebar This is the fourth, and final patch, that attempts to improve the cohesion in the base.View class. Patch by: Sverre Rabbelier

Moved getDjangoURLPatterns to sitemap.sitemap Third commit in a series that aims to improve the cohesion in the base.View class. Patch by: Sverre Rabbelier

Moved checkAccess and getCleanedFields into access and forms A second patch in an effort to increase the cohesion in the base.View class. Patch by: Sverre Rabbelier

Move parameter construction into a seperate module This is part of an effort to make base.py less bloated and have it's methods be more cohesive. Patch by: Sverre Rabbelier

Documented params usage in soc/views/models/base.py Patch by: Sverre Rabbelier