Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 16:47:39 +0000] rev 306
Removed obsolete logic directories and added one for model
The model/ directory will contain the Base logic classes.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 15:52:19 +0000] rev 305
Minor style and import fixes
Incorperated changes as suggested by Todd and Pawel.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 15:05:50 +0000] rev 304
Missing changes to soc.views.helper.access
Due to having to manually do the 'svn mv' of logic to helper,
the changes to access.py got lost, this commit fixes that.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 14:58:47 +0000] rev 303
Moved soc/logic/helper/access to soc/views/helper/access
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 12 Oct 2008 08:46:05 +0000] rev 302
Fix not working delete Sponsor functionality after recent commit. Add delete() method to Base class. Make soc.views.site.sponsor.delete() request handler use this method.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 12 Oct 2008 08:43:41 +0000] rev 301
Fix not working isIdDeveloper() function after recent commit. There is still confusion within getFormFields method (email is not id), but this change doesn't address that problem.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 12 Oct 2008 01:08:41 +0000] rev 300
Changed location of the svn command in svn_load_dirs.pl script from '/usr/bin/svn' to 'svn'. That makes the script more universal and it should work on Linux, Windows and Mac OS X if the svn is in the PATH.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 00:12:53 +0000] rev 299
Refactor nearly all the soc.logic code to use the Base class
Instead of having a lot of duplicate code, this patch aims
to reduce this duplication by introducing a Base abstraction.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 00:08:54 +0000] rev 298
Replace almost all occurences of linkname with link_name
In an attempt to have some atomicness in these commits
this patch does a rename for the sake of consistency.
Not all were changed, but the next commit will address that.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 10 Oct 2008 13:14:24 +0000] rev 297
Load /Users/solydzajs/Downloads/google_appengine/ into
trunk/thirdparty/google_appengine.
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 10 Oct 2008 06:56:56 +0000] rev 296
Add missing __init__.py to soc/logic/helper folder (Caused home page not to work).
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 09 Oct 2008 23:50:00 +0000] rev 295
Removed now-obsolete getAltResponse* methods from simple.py
The getAltResponse* methods have been replaced by the check*
methods in soc.logic.helper.access.
Patch by: Sverre Rabbelier
Reviewed by: Pawel Solyga, Augie Fackler, Todd Larsen
Reviewed at: http://codereviews.googleopensourceprograms.com/1601
Review id: 1601
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 09 Oct 2008 23:48:20 +0000] rev 294
Refactor existing code to use the new access module
Instead of ending up with many different ways to do
access control, we end up having only one centralized
place wher access control is done.
Patch by: Sverre Rabbelier
Reviewed by: Pawel Solyga, Augie Fackler, Todd Larsen
Reviewed at: http://codereviews.googleopensourceprograms.com/1601
Review id: 1601
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 09 Oct 2008 23:38:27 +0000] rev 293
Add an access control module
The module's purpose is to check access requirements,
(such as being logged in), and raise an exception
containing a authentication request when the requirement
is not met.
Patch by: Sverre Rabbelier
Reviewed by: Pawel Solyga, Augie Fackler, Todd Larsen
Reviewed at: http://codereviews.googleopensourceprograms.com/1601
Review id: 1601
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 18:11:37 +0000] rev 292
Enable recently commited delete Sponsor request handler (added to map.py) and Delete button in Sponsor edit view. Still missing "Are you sure ?" question box.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 18:06:50 +0000] rev 291
Create a submit_buttons blocks in all edit view templates and put submit buttons in separate html table (not as part of the fields table anymore).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 15:10:51 +0000] rev 290
Create a submit_buttons block in group edit profile template so that submit buttons can be customized. Replace submit_message usage with new notice block (still work in progress in Lookup User views). Add customized edit profile template for Sponsor with delete button (not used yet, upcoming commit). Add delete Sponsor request handler.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 13:56:42 +0000] rev 289
Add notification bar block in base.html template.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 13:50:44 +0000] rev 288
Add #notice class declaration in soc.css for upcoming notification bar.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 13:49:41 +0000] rev 287
Update indexes in index.yaml file.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 08 Oct 2008 21:22:50 +0000] rev 286
Fix typo in getSponsorFromLinkName (key_name variable name instead of sponsor_key_name). Add deleteSponsor function for deleting Sponsor entities from datastore.
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 05 Oct 2008 13:27:49 +0000] rev 285
Style fix, as requested by Todd to dict usage
Use "dict['key'] = value" instead of "dict.update({'key' : 'value'})"
when updating only one key.
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 07:22:43 +0000] rev 284
Call soc.logic.site.map.getDjangoUrlPatterns() to construct the urlpatterns
from the site map, rather than explicitly listing them in app/urls.py.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 07:20:48 +0000] rev 283
Update soc/logic/site/sidebar.py to use parts of the "site map" in
soc/logic/site/map.py to generate portions of the sidebar menu.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 07:17:00 +0000] rev 282
A site layout ("site map") of the web application, including URL regular
expression patterns, Django views, and metadata for constructing sidebar menus
and (eventually) breadcrumbs.
One function, soc.logic.site.map.getDjangoUrlPatterns(), converts these details
into urlpatterns for use by Django.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 07:14:11 +0000] rev 281
Url and Page classes used to encapsulate the "site map" information (URL
regular expressions, Django views, menu item names, etc.) and the relation
between pages in the site map.
There are still lots of TODOs in this first pass.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 06:25:07 +0000] rev 280
urllib.quote() is needed by the soc/logic/site/map.py work, so import it from
the Python 2.5.2 sources. The entire urllib.py is not supported by Google
App Engine (yet?), since it relies on 'import socket' (App Engine provides a
separate urlfetch module instead).
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 05:00:13 +0000] rev 279
Remove now-empty soc/views/helpers (everything has moved to soc/views/helper).
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 04:51:43 +0000] rev 278
Add create() wrapper views that simply call the existing edit() views, to
produce unique view names in preparation for the soc/logic/site/map.py code.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 04:42:37 +0000] rev 277
Speed up average case by appending remainder of original choices list unchanged
(avoiding remaining str -> int type conversions) once the insertion point is
found.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 04:34:16 +0000] rev 276
Move helpers/html_menu.py to helper/html_menu.py, to clear out
soc/views/helpers for deletion.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 04:32:28 +0000] rev 275
A specialized SortedDict used by soc/logic/site/page.py.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 23:59:49 +0000] rev 274
Move helpers/forms_helpers.py to helper/forms.py.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 23:24:12 +0000] rev 273
Move helpers/templatetags to helper/templatetags.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 23:17:49 +0000] rev 272
Move helpers/response_helpers.py to helper/responses.py.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 23:08:28 +0000] rev 271
Replace helpers/custom_widgets.py with helper/widgets.py.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 23:01:49 +0000] rev 270
Move helpers/template_helpers.py to helper/templates.py.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 22:17:05 +0000] rev 269
Move helpers/request.py to helper/requests.py to avoid conflict with common
local variable name "request".
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 22:09:32 +0000] rev 268
Move helpers/list.py to helper/lists.py to avoid conflict with built-in type
name "list".
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 21:59:32 +0000] rev 267
Replace soc/views/helpers/request_helpers with soc/views/helpers/request.py
and replace uses of request_helpers. with helpers.request. instead.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 21:41:12 +0000] rev 266
Move soc/views/helpers/list_helpers.py to soc/views/helpers/list.py and change
uses from list_helpers. to helpers.list. instead.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 17:21:41 +0000] rev 265
List views should have a selectable pagination "page" length:
http://code.google.com/p/soc/issues/detail?id=59
Patch by: Chen Lunpeng and Todd Larsen
Review by: Augie Fackler
Review URL: http://codereviews.googleopensourceprograms.com/1201
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 07:03:11 +0000] rev 264
Change to imports to follow the style guide:
http://code.google.com/p/soc/wiki/PythonStyleGuide#Module_and_package_imports
Specifically:
"Use from x import y only when x is a package and y is a module."
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 01:32:34 +0000] rev 263
Make findNearestUsers() code in soc/logic/site/id_user.py more generic and
move it to soc/logic/model.py. Orginal findNearest...() functions in
id_user.py are now convenience wrappers.
Add typed-query string construction functions to model.py.
Move getFulLClassName() from key_name.py model.py, since it has more to do
with Model types than key names.
Swap 'offset' and 'limit' and make 'limit' arguments non-optional. Also,
stop adding 1 inside the ...ForLimitAndOffset() functions and make the
callers do it (since it was being added for a very UI-specific reason of
whether or not to display a "Next>" link).
Patch by: Todd Larsen
Review by: Pawel Solyga
Review URL: http://codereviews.googleopensourceprograms.com/1401
Todd Larsen <tlarsen@google.com> [Thu, 02 Oct 2008 20:22:15 +0000] rev 262
Factor out an isIdAvailable() function from EditForm.clean_id() in
soc/views/site/user/profile.py and add it to soc/logic/site/id_user.py.
Addresses some comments on r614.
Patch by: Todd Larsen
Review by: Pawel Solyga
Review URL: http://codereviews.googleopensourceprograms.com/1202
Todd Larsen <tlarsen@google.com> [Thu, 02 Oct 2008 15:37:18 +0000] rev 261
Add Allen (Chen Lunpeng) to trunk/AUTHORS, due to his several recent patches.
Todd Larsen <tlarsen@google.com> [Thu, 02 Oct 2008 15:36:08 +0000] rev 260
Fix typo in recent validate.py changes (r682).
Patch by: Chen Lunpeng
Review by: Todd Larsen
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 22:19:22 +0000] rev 259
Add basic Sponsors List, Create New Sponsor, Sponsor Public Profile views. Change all properties in Group model as required for now. Remaining TODO: write validation functions for Sponsor edit and create form fields that need additional validation (like address, phone number format).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 22:12:26 +0000] rev 258
Add Sponsor logic functions.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 22:10:52 +0000] rev 257
Add group templates that can be used by Sponsor, Organization, School, Club views. Right now only upcoming commit of Sponsor views is using it.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 22:02:50 +0000] rev 256
Remove excluded field inheritance_line, since the User model does not inherit
from PolyModel (at this time).
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 21:58:31 +0000] rev 255
Add colon at the of _readonly_field_as_table_row template tag label parameter. Replace hardcoded labels in User Public profile template with linkname_user.fields.<field_name>.label values.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 21:53:52 +0000] rev 254
Fix missing blank line to follow PythonStyleGuide in model.py.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 21:21:03 +0000] rev 253
Add links in sidebar for upcoming Sponsor views.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 21:19:32 +0000] rev 252
Change key_name module usage to path_linkname module (fix to previous commit). Add comments about urls. Add Sponsor views urls for upcoming Sponsor views modules.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 20:52:39 +0000] rev 251
Move path and link_name related functions and regex patterns to a new
soc/logic/path_linkname.py module, and fix all dependencies. path/link_name
functionality is becoming the generic way to identify entities in the Datastore
in a URL-compatible way.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 20:48:58 +0000] rev 250
Make form field components use a smaller font, without shrinking the font
of all text in the page body.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 19:21:09 +0000] rev 249
Replace common module with validate module. Move validation function from feed module to validate module and remove feed.py. Correct any usage of validation functions from common and feed modules into validate module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 19:17:13 +0000] rev 248
Add missing blank line to follow PythonStyleGuide in document.py
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 19:15:20 +0000] rev 247
Fixed typo in DEF_CREATE_NEW_DOC_MSG.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 16:47:00 +0000] rev 246
Shrink the sidebar menu separately from the main body text.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 14:23:28 +0000] rev 245
Moved isLinkNameFormatValid function out of id_user module to new common module. This function is going to be used by other form validation functions that require to validate linkname (different kind of Groups, Programs etc).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 09:43:25 +0000] rev 244
Fixed models based on output from graph.py script and comments on
http://groups.google.com/group/melange-soc-dev/browse_thread/thread/fb532a7db1f19ea7
Tim Ansell <mithro@gmail.com> [Wed, 01 Oct 2008 07:26:45 +0000] rev 243
Tool to graph the data model.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 07:11:27 +0000] rev 242
Some TODOs on access control that I didn't want to forget.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 07:10:43 +0000] rev 241
Matching just /docs created a very small namespace, since any other path parts
would match the Document path. So, append /show after /docs for the display
view. This makes other views like /docs/edit possible later.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 07:01:06 +0000] rev 240
URL pattern changes that were missed by r671.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 07:00:26 +0000] rev 239
Some styles used by r671, the simplistic Document view.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 06:59:51 +0000] rev 238
A very simplistic Document viewer.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 06:24:17 +0000] rev 237
Implements a Site (Developer) generic Document editor form.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 06:03:53 +0000] rev 236
Changes to make breadcrumbs match page title. This is mostly to see how it
looks, since the new soc/logic/site/map.py code is going to implement the
breadcrumbs and page title contents in a similar way.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 05:17:15 +0000] rev 235
Start using "Site" instead of "Developer" in the UI.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 05:15:29 +0000] rev 234
Implement a Developer list view of all Documents.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 05:10:41 +0000] rev 233
Add missing all() __doc__ string comments: "Args:" and "Returns:" sections.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 05:02:42 +0000] rev 232
Fix some style guide issues: keyword arguments are supposed to always be
supplied using the keyword argument name=value.
http://code.google.com/p/soc/wiki/PythonStyleGuide#Default_Argument_Values
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 02:23:30 +0000] rev 231
Directory for up-coming /site/docs/list and /site/docs/edit templates.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 02:13:54 +0000] rev 230
Fix typo in findNearestUsersOffset() __doc__ string missed in r661.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 02:11:56 +0000] rev 229
Show link to /site/user/list on /site/user/lookup when User is not found.
http://code.google.com/p/soc/issues/detail?id=61
Patch by: Chen Lunpeng
Review by: Todd Larsen (with modifications)
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 02:02:44 +0000] rev 228
Add placeholder for future (to-be-implemented) getPreferredListPagination()
function.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:53:36 +0000] rev 227
Remove a TODO that should have been removed for r658.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:51:49 +0000] rev 226
Update some of the URL patterns to get their link_name parsing from the new
patterns in key_name.py. (Using it like this in urls.py is why key_name.py
needs to not depend on other modules...)
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:48:46 +0000] rev 225
Add functions to soc/logic/document.py for dealing with partial_paths combined
with link_names. Add getWorksForOffsetAndLimit() to query for Documents for
the /site/docs/list view.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:45:30 +0000] rev 224
Hide PolyModel inheritance_line bookkeeping property from the User Profile
form.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:43:07 +0000] rev 223
Use the LINKNAME_PATTERN from its new home in key_name.py. Also, add some
missing blank lines that are required by the style guide.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:41:18 +0000] rev 222
Add lots of new functions to key_name.py, including path/link_name processing.
Copy various link_name related regex patterns to key_name.py and use them.
Add error checking that raises a key_name.Error exception when name...()
functions are given empty arguments. Hard-code class names, since they match
what was typed into the module.class.__name__ to get the name anyway. This
eliminates dependencies on any modules by key_name.py.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:35:29 +0000] rev 221
Add sidebar menu items for /site/docs/list and /site/docs/edit. They do not
currently have view functions attached, but there are other links in the
mock-up portion of the sidebar that don't currently work, either. The goal
is to commit the /site/docs/list and /site/docs/edit changes in small bits
that don't break anyone else.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:33:43 +0000] rev 220
Add partial_path property explicitly to the Work model.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:25:31 +0000] rev 219
Should have been part of the r650 commit.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:23:32 +0000] rev 218
Directory for upcoming /site/docs views.
Todd Larsen <tlarsen@google.com> [Tue, 30 Sep 2008 17:03:51 +0000] rev 217
Add "Last updated" footer to front page body text, using the modified Property
from the Work entity.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 16:53:30 +0000] rev 216
Change _readonly_field_as_table_row <td> tag class names to match those used in _field_as_table_row. That should actually go into previous commit.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 16:49:54 +0000] rev 215
Clean up too long lines in profile.py. Add ReadOnlyInput widget to custom_widgets module, it can be used to display read-only form fields. Display read-only "Id" field in LookUp view if user has been found and in User Edit Developer view.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 16:26:30 +0000] rev 214
Add polymodel folder to DEFAULT_APP_DIRS variable in make_release.sh script.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 15:21:05 +0000] rev 213
Add key naming function for Sponsor, School, Organization, Club key_names.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 14:00:11 +0000] rev 212
Add org ReferenceProperty to Administrator model (many:1 relationship associating Administrators with specific Organization). Update Organization model __doc__ string with information about the back-reference 'admins'.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 12:59:59 +0000] rev 211
Made mce_settings class variable in TinyMCE widget a copy of default settings instead of reference.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 12:47:05 +0000] rev 210
Replaced context.update call to simple value assignment in site.user.profile.create view function.
Todd Larsen <tlarsen@google.com> [Mon, 29 Sep 2008 17:22:31 +0000] rev 209
Load ../../google_appengine/ into trunk/thirdparty/google_appengine.
Todd Larsen <tlarsen@google.com> [Mon, 29 Sep 2008 15:46:42 +0000] rev 208
Take advantage of the Model inheritance provided by polymodel.PolyModel to
have Club, School, Sponsor, and Organization actually inherit from the Group
Model class, rather than being composed via ReferenceProperties.
Patch by: Todd Larsen
Review by: Pawel Solyga, Sverre Rabbelier, Augie Fackler
Review URL: http://codereviews.googleopensourceprograms.com/606
Todd Larsen <tlarsen@google.com> [Mon, 29 Sep 2008 15:34:40 +0000] rev 207
Take advantage of the Model inheritance provided by polymodel.PolyModel to
have create a class hierarchy rooted at Person.
Also, add some missing Role classes, such as Role, (Organization) Mentor,
(Club) Member, (School) Student. Make (Organization) Administrator be a
Reviewer like Mentor is.
Patch by: Todd Larsen
Review by: Pawel Solyga, Sverre Rabbelier, Augie Fackler
Review URL: http://codereviews.googleopensourceprograms.com/607
Todd Larsen <tlarsen@google.com> [Mon, 29 Sep 2008 15:31:50 +0000] rev 206
Make use of PolyModel for Works, Documents, etc. Add some (but not all) of
the missing Models related to Documents. Refactor site settings to be useful
for any "/home" page view. Make the resulting home settings store a reference
to the Document, rather than looking up the Document by a hard-code key name.
This is to set the stage for Document editing being generic, and then being
able to select from some existing documents which one to use as the "/home"
static content. This makes it possible to pre-edit several Documents, have
them Reviewed, and then quickly change the "/home" page content as a setting,
rather than editing the Document in the settings form (though settings forms
might still embed the current document into their form for convenience).
Patch by: Todd Larsen
Review by: Pawel Solyga
Review URL: http://codereviews.googleopensourceprograms.com/1001
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 29 Sep 2008 14:03:45 +0000] rev 205
Fixed not working "Create New User" view which was caused by adding key_name into User Edit Developer view. This commit divides edit() view function in soc.views.site.user.profile into edit() and create() request handlers. New create() request handler is used only in "Create New User" view and has specific form validation functions and uses updateOrCreateUserFromId() instead of updateUserForKeyName().
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 26 Sep 2008 19:47:07 +0000] rev 204
Add ModelWithFieldAttributes *before* PolyModel, so that everything does not
become a "ModelWithFieldAttributes" in the Datastore.
The way PolyModel works, each Model class hierarchy is stored in the Datastore
as the class that directly inherited from PolyModel. So, we do not want to
insert ModelWithFieldAttributes *after* PolyModel by inheriting *from*
PolyModel, or everything would just be a ModelWithFieldAttributes in the
Datastore, instead of Person, Work, Group, etc.
Todd Larsen <tlarsen@google.com> [Fri, 26 Sep 2008 19:35:21 +0000] rev 203
Add the third-party PolyModel class. This class supports inheritance in
Google App Engine Datastore Model classes.
Todd Larsen <tlarsen@google.com> [Thu, 25 Sep 2008 17:17:11 +0000] rev 202
A key_name controller module to collect all of the name...() functions that
compose Model entity key names, plus some minor changes to other controller
modules to illustrate the proposed use.
Patch by: Todd Larsen
Review by: Pawel Solyga
Review URL: http://codereviews.googleopensourceprograms.com/804
Review URL: http://codereviews.googleopensourceprograms.com/804
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 24 Sep 2008 21:23:42 +0000] rev 201
Fixed missing urlparse import in request_helpers which cause /user/profile and /site/user/profile not to work at all. Removed not used module imports in response_helpers.py.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 06:00:28 +0000] rev 200
Replace mock-up of sidebar with first draft of dynamic sidebar functionality.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 05:58:45 +0000] rev 199
Minor tweaks to Site menu item names to make them more descriptive.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 05:58:15 +0000] rev 198
Major refactoring, to switch from using inheritance from soc.logic.menu classes
to an envelope-letter model instead.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 05:17:44 +0000] rev 197
Sidebar-building controller, with a TODO remaining to implement marking the
current page as "selected".
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:46:52 +0000] rev 196
Make views.helpers.html_menu MenuItem classes and logic.menu MenuItem classes
more closely related. This is part of some refactoring in my working copy
to keep soc/logic/site/sidebar.py from having to deal with html_menu classes
(which is like having view code in the controller, which is bad).
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:36:47 +0000] rev 195
Classes that wrap soc.logic.menu.Menu and soc.logic.menu.MenuItem to produce
HTML renderings of such lists.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:27:01 +0000] rev 194
Change indentation level to 2 (from 4) and rename MCE_DEF_SETTINGS to
DEF_MCE_SETTINGS to match the "default constant" naming convention elsewhere
in the code.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:24:49 +0000] rev 193
Note 'groups' back-reference from 'founder' property in soc.models.group.Group.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:23:32 +0000] rev 192
Simple MenuItem and Menu classes for keeping track of ordered menus.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:22:12 +0000] rev 191
These changes should have been in r620, but somehow I did not save them, or
saved over them with an old copy in the editor. Not sure...
Todd Larsen <tlarsen@google.com> [Tue, 23 Sep 2008 23:30:15 +0000] rev 190
Move isReferrerSelf() and replaceSuffix() into new request_helpers.py module,
since they are (mainly) used to manipulate parts of an HTTP request.
Todd Larsen <tlarsen@google.com> [Tue, 23 Sep 2008 23:20:23 +0000] rev 189
Split out HTTP request manipulation functions from template_helpers.py, which
is in danger of becoming a "misc" or "util" module unnecessarily.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 23 Sep 2008 19:20:57 +0000] rev 188
Changes in TinyMCE widget in custom_widgets.py based on review comments.
Patch by: Pawel Solyga
Review url: http://code.google.com/p/soc/source/detail?r=550
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 23 Sep 2008 17:55:54 +0000] rev 187
Change user list view instruction. Don't show "Next >" disabled greyed text in the list pagination if there is only one page.