Move helpers/templatetags to helper/templatetags. Patch by: Todd Larsen Review by: to-be-reviewed

Move helpers/response_helpers.py to helper/responses.py. Patch by: Todd Larsen Review by: to-be-reviewed

Replace helpers/custom_widgets.py with helper/widgets.py. Patch by: Todd Larsen Review by: to-be-reviewed

Move helpers/template_helpers.py to helper/templates.py. Patch by: Todd Larsen Review by: to-be-reviewed

Move helpers/request.py to helper/requests.py to avoid conflict with common local variable name "request". Patch by: Todd Larsen Review by: to-be-reviewed

Move helpers/list.py to helper/lists.py to avoid conflict with built-in type name "list". Patch by: Todd Larsen Review by: to-be-reviewed

Replace soc/views/helpers/request_helpers with soc/views/helpers/request.py and replace uses of request_helpers. with helpers.request. instead. Patch by: Todd Larsen Review by: to-be-reviewed

Move soc/views/helpers/list_helpers.py to soc/views/helpers/list.py and change uses from list_helpers. to helpers.list. instead. Patch by: Todd Larsen Review by: to-be-reviewed

List views should have a selectable pagination "page" length: http://code.google.com/p/soc/issues/detail?id=59 Patch by: Chen Lunpeng and Todd Larsen Review by: Augie Fackler Review URL: http://codereviews.googleopensourceprograms.com/1201

Change to imports to follow the style guide: http://code.google.com/p/soc/wiki/PythonStyleGuide#Module_and_package_imports Specifically: "Use from x import y only when x is a package and y is a module."

Make findNearestUsers() code in soc/logic/site/id_user.py more generic and move it to soc/logic/model.py. Orginal findNearest...() functions in id_user.py are now convenience wrappers. Add typed-query string construction functions to model.py. Move getFulLClassName() from key_name.py model.py, since it has more to do with Model types than key names. Swap 'offset' and 'limit' and make 'limit' arguments non-optional. Also, stop adding 1 inside the ...ForLimitAndOffset() functions and make the callers do it (since it was being added for a very UI-specific reason of whether or not to display a "Next>" link). Patch by: Todd Larsen Review by: Pawel Solyga Review URL: http://codereviews.googleopensourceprograms.com/1401

Factor out an isIdAvailable() function from EditForm.clean_id() in soc/views/site/user/profile.py and add it to soc/logic/site/id_user.py. Addresses some comments on r614. Patch by: Todd Larsen Review by: Pawel Solyga Review URL: http://codereviews.googleopensourceprograms.com/1202

Add Allen (Chen Lunpeng) to trunk/AUTHORS, due to his several recent patches.

Fix typo in recent validate.py changes (r682). Patch by: Chen Lunpeng Review by: Todd Larsen

Add basic Sponsors List, Create New Sponsor, Sponsor Public Profile views. Change all properties in Group model as required for now. Remaining TODO: write validation functions for Sponsor edit and create form fields that need additional validation (like address, phone number format). Patch by: Pawel Solyga Review by: to-be-reviewed

Add Sponsor logic functions. Patch by: Pawel Solyga Review by: to-be-reviewed

Add group templates that can be used by Sponsor, Organization, School, Club views. Right now only upcoming commit of Sponsor views is using it. Patch by: Pawel Solyga Review by: to-be-reviewed

Remove excluded field inheritance_line, since the User model does not inherit from PolyModel (at this time).

Add colon at the of _readonly_field_as_table_row template tag label parameter. Replace hardcoded labels in User Public profile template with linkname_user.fields.<field_name>.label values.

Fix missing blank line to follow PythonStyleGuide in model.py.

Add links in sidebar for upcoming Sponsor views. Patch by: Pawel Solyga Review by: to-be-reviewed

Change key_name module usage to path_linkname module (fix to previous commit). Add comments about urls. Add Sponsor views urls for upcoming Sponsor views modules. Patch by: Pawel Solyga Review by: to-be-reviewed

Move path and link_name related functions and regex patterns to a new soc/logic/path_linkname.py module, and fix all dependencies. path/link_name functionality is becoming the generic way to identify entities in the Datastore in a URL-compatible way.

Make form field components use a smaller font, without shrinking the font of all text in the page body.

Replace common module with validate module. Move validation function from feed module to validate module and remove feed.py. Correct any usage of validation functions from common and feed modules into validate module. Patch by: Pawel Solyga Review by: to-be-reviewed

Add missing blank line to follow PythonStyleGuide in document.py

Fixed typo in DEF_CREATE_NEW_DOC_MSG.

Shrink the sidebar menu separately from the main body text.

Moved isLinkNameFormatValid function out of id_user module to new common module. This function is going to be used by other form validation functions that require to validate linkname (different kind of Groups, Programs etc). Patch by: Pawel Solyga Review by: to-be-reviewed

Fixed models based on output from graph.py script and comments on http://groups.google.com/group/melange-soc-dev/browse_thread/thread/fb532a7db1f19ea7

Tool to graph the data model.

Some TODOs on access control that I didn't want to forget.

Matching just /docs created a very small namespace, since any other path parts would match the Document path. So, append /show after /docs for the display view. This makes other views like /docs/edit possible later.

URL pattern changes that were missed by r671.

Some styles used by r671, the simplistic Document view.

A very simplistic Document viewer.

Implements a Site (Developer) generic Document editor form.

Changes to make breadcrumbs match page title. This is mostly to see how it looks, since the new soc/logic/site/map.py code is going to implement the breadcrumbs and page title contents in a similar way.

Start using "Site" instead of "Developer" in the UI.

Implement a Developer list view of all Documents. Patch by: Todd Larsen Review by: to-be-reviewed

Add missing all() __doc__ string comments: "Args:" and "Returns:" sections.

Fix some style guide issues: keyword arguments are supposed to always be supplied using the keyword argument name=value. http://code.google.com/p/soc/wiki/PythonStyleGuide#Default_Argument_Values

Directory for up-coming /site/docs/list and /site/docs/edit templates.

Fix typo in findNearestUsersOffset() __doc__ string missed in r661.

Show link to /site/user/list on /site/user/lookup when User is not found. http://code.google.com/p/soc/issues/detail?id=61 Patch by: Chen Lunpeng Review by: Todd Larsen (with modifications)

Add placeholder for future (to-be-implemented) getPreferredListPagination() function.

Remove a TODO that should have been removed for r658.

Update some of the URL patterns to get their link_name parsing from the new patterns in key_name.py. (Using it like this in urls.py is why key_name.py needs to not depend on other modules...)

Add functions to soc/logic/document.py for dealing with partial_paths combined with link_names. Add getWorksForOffsetAndLimit() to query for Documents for the /site/docs/list view.

Hide PolyModel inheritance_line bookkeeping property from the User Profile form.

Use the LINKNAME_PATTERN from its new home in key_name.py. Also, add some missing blank lines that are required by the style guide.

Add lots of new functions to key_name.py, including path/link_name processing. Copy various link_name related regex patterns to key_name.py and use them. Add error checking that raises a key_name.Error exception when name...() functions are given empty arguments. Hard-code class names, since they match what was typed into the module.class.__name__ to get the name anyway. This eliminates dependencies on any modules by key_name.py.

Add sidebar menu items for /site/docs/list and /site/docs/edit. They do not currently have view functions attached, but there are other links in the mock-up portion of the sidebar that don't currently work, either. The goal is to commit the /site/docs/list and /site/docs/edit changes in small bits that don't break anyone else.

Add partial_path property explicitly to the Work model.

Should have been part of the r650 commit.

Directory for upcoming /site/docs views.

Add "Last updated" footer to front page body text, using the modified Property from the Work entity.

Change _readonly_field_as_table_row <td> tag class names to match those used in _field_as_table_row. That should actually go into previous commit. Patch by: Pawel Solyga Review by: to-be-reviewed

Clean up too long lines in profile.py. Add ReadOnlyInput widget to custom_widgets module, it can be used to display read-only form fields. Display read-only "Id" field in LookUp view if user has been found and in User Edit Developer view. Patch by: Pawel Solyga Review by: to-be-reviewed

Add polymodel folder to DEFAULT_APP_DIRS variable in make_release.sh script.

Add key naming function for Sponsor, School, Organization, Club key_names. Patch by: Pawel Solyga Review by: to-be-reviewed

Add org ReferenceProperty to Administrator model (many:1 relationship associating Administrators with specific Organization). Update Organization model __doc__ string with information about the back-reference 'admins'. Patch by: Pawel Solyga Review by: to-be-reviewed

Made mce_settings class variable in TinyMCE widget a copy of default settings instead of reference.

Replaced context.update call to simple value assignment in site.user.profile.create view function.

Load ../../google_appengine/ into trunk/thirdparty/google_appengine.

Take advantage of the Model inheritance provided by polymodel.PolyModel to have Club, School, Sponsor, and Organization actually inherit from the Group Model class, rather than being composed via ReferenceProperties. Patch by: Todd Larsen Review by: Pawel Solyga, Sverre Rabbelier, Augie Fackler Review URL: http://codereviews.googleopensourceprograms.com/606

Take advantage of the Model inheritance provided by polymodel.PolyModel to have create a class hierarchy rooted at Person. Also, add some missing Role classes, such as Role, (Organization) Mentor, (Club) Member, (School) Student. Make (Organization) Administrator be a Reviewer like Mentor is. Patch by: Todd Larsen Review by: Pawel Solyga, Sverre Rabbelier, Augie Fackler Review URL: http://codereviews.googleopensourceprograms.com/607

Make use of PolyModel for Works, Documents, etc. Add some (but not all) of the missing Models related to Documents. Refactor site settings to be useful for any "/home" page view. Make the resulting home settings store a reference to the Document, rather than looking up the Document by a hard-code key name. This is to set the stage for Document editing being generic, and then being able to select from some existing documents which one to use as the "/home" static content. This makes it possible to pre-edit several Documents, have them Reviewed, and then quickly change the "/home" page content as a setting, rather than editing the Document in the settings form (though settings forms might still embed the current document into their form for convenience). Patch by: Todd Larsen Review by: Pawel Solyga Review URL: http://codereviews.googleopensourceprograms.com/1001

Fixed not working "Create New User" view which was caused by adding key_name into User Edit Developer view. This commit divides edit() view function in soc.views.site.user.profile into edit() and create() request handlers. New create() request handler is used only in "Create New User" view and has specific form validation functions and uses updateOrCreateUserFromId() instead of updateUserForKeyName(). Patch by: Pawel Solyga Review by: to-be-reviewed

Add ModelWithFieldAttributes *before* PolyModel, so that everything does not become a "ModelWithFieldAttributes" in the Datastore. The way PolyModel works, each Model class hierarchy is stored in the Datastore as the class that directly inherited from PolyModel. So, we do not want to insert ModelWithFieldAttributes *after* PolyModel by inheriting *from* PolyModel, or everything would just be a ModelWithFieldAttributes in the Datastore, instead of Person, Work, Group, etc.

Add the third-party PolyModel class. This class supports inheritance in Google App Engine Datastore Model classes.

A key_name controller module to collect all of the name...() functions that compose Model entity key names, plus some minor changes to other controller modules to illustrate the proposed use. Patch by: Todd Larsen Review by: Pawel Solyga Review URL: http://codereviews.googleopensourceprograms.com/804 Review URL: http://codereviews.googleopensourceprograms.com/804

Fixed missing urlparse import in request_helpers which cause /user/profile and /site/user/profile not to work at all. Removed not used module imports in response_helpers.py.

Replace mock-up of sidebar with first draft of dynamic sidebar functionality.

Minor tweaks to Site menu item names to make them more descriptive.

Major refactoring, to switch from using inheritance from soc.logic.menu classes to an envelope-letter model instead.

Sidebar-building controller, with a TODO remaining to implement marking the current page as "selected".

Make views.helpers.html_menu MenuItem classes and logic.menu MenuItem classes more closely related. This is part of some refactoring in my working copy to keep soc/logic/site/sidebar.py from having to deal with html_menu classes (which is like having view code in the controller, which is bad).

Classes that wrap soc.logic.menu.Menu and soc.logic.menu.MenuItem to produce HTML renderings of such lists.

Change indentation level to 2 (from 4) and rename MCE_DEF_SETTINGS to DEF_MCE_SETTINGS to match the "default constant" naming convention elsewhere in the code.

Note 'groups' back-reference from 'founder' property in soc.models.group.Group.

Simple MenuItem and Menu classes for keeping track of ordered menus.

These changes should have been in r620, but somehow I did not save them, or saved over them with an old copy in the editor. Not sure...

Move isReferrerSelf() and replaceSuffix() into new request_helpers.py module, since they are (mainly) used to manipulate parts of an HTTP request.

Split out HTTP request manipulation functions from template_helpers.py, which is in danger of becoming a "misc" or "util" module unnecessarily.

Changes in TinyMCE widget in custom_widgets.py based on review comments. Patch by: Pawel Solyga Review url: http://code.google.com/p/soc/source/detail?r=550

Change user list view instruction. Don't show "Next >" disabled greyed text in the list pagination if there is only one page.

Add Users List Developer view which is available at /site/user/list. Add User list custom templates which are used with list_helpers. Add "Users List" link in base.html template. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Add list_helpers functions that are going to be used when rendering list views like (Users List, Sponsors List etc). Add list default templates and CSS classes. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Add support for changing User id (Google Account email) in User Profile Developer view. Now user profile developer edit view includes hidden key_name field. Fix typo in user/profile.py. Show former user ids in lookup and edit User Profile Developer views. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Small change to unescape function in template_helpers (move replace('&amp;', '&') at the end).

Add rounded corners graphics. Add .notice class and rounded corners classes to soc.css file, those will be used to better visualize submit_message like "Profile saved.".

Remove Author model (use Person instead). Update models after removing Author. Add new Sponsor, Organization models. Patch by: Pawel Solyga Reviewed by: Todd Larsen Review issue: 801 Review URL: http://codereviews.googleopensourceprograms.com/801

Two changes to ease CI: 1) If pysvn is missing, the tests for svn_helper don't run and pollute the output 2) svn_helper no longer depends on being located at trunk/scripts/ Patch by: Augie Fackler Review by: Todd Larsen Review Issue: 802 Reviewed URL: http://codereviews.googleopensourceprograms.com/802

Add custom 404 error message with link to "Create a New User" which is displayed when linkname in User Profile Developer view URL (/site/user/profile/<linkname>) doesn't exist. Add default value (None) to new_suffix parameter of template_helpers replaceSuffix and redirectToChangedSuffix functions.

Testing buildbot. Sorry about the noise. (Last one for now, I've got most of the kinks figured out I think)

Testing buildbot. Sorry about the noise.

Testing buildbot. Sorry about the noise.

Make django.zip in release/, instead of in app/ with a symlink in release/. This allows debugging into app/django source code, which the presence of app/django.zip was blocking. Tested with both: dev_appserver.py release and dev_appserver.py app

A rough draft of the Group Model, to be merged with Pawel's current effort in his working copy. This is *very* incomplete...

First pass (from some old code notes) of a School Model (a form of Group).

First pass (from some old code notes) of a Club Model (a form of Group).

Bug fixes to revision r596. User Account field in Developer User Profile view needs to be an email not a login name. Header title of User Profile Developer view, when form validation failes is now showing correct value ("Modify existing ..." instead of "Create new user ...").

Add /site/user/profile Developer view for editing arbitrary User entities. Update /user/profile edit() view to fix TODO about updating the URL when a POST of the form changes the link_name of the User. Add a Create New User link to the base.html sidebar mock-up.

Fix off-by-one corner case discovered during testing of /user/profile.

Added getSingleIndexedParamValue() that retrieves an index into a list of values from the named query parameter, and then indexes into the supplied list of values to return the corresponding value from the list. Used to convert numeric index query parameters passed by POST to the GET redirect target, so that the GET code can display messages, etc. (without passing the message itself as a query argument and having to escape it or have silly people pass in their own...).

Added replaceSuffix(), isReferrerSelf(), and redirectToChangedSuffix() to implement the TODO in the User profile views where the link name portion of the URL needs to change when the link_name Property is updated by the form.

Fixed too long lines and deleted unused imports in id_user.py.

New default values for page title, header title and body of site home page.

Documentation updates and one typo fix.

Add a td.formfielderrorlabel style, to highlight field labels that have errors.

Swap field value and "required" columns to make more columns for field errors.

Add a verbose_name and help_text to the User.id Property.

Explain why pushd and popd are needed when making tiny_mce.zip.

Use zip to compress tiny_mce, and use zipserve to serve it in Google App Engine.

Updated make_release.sh docs and added way for person invoking the script to override script variables such as RELEASE using something like "RELEASE=../testing_release ./make_release.sh".

Add recently-moved feedparser and tiny_mce to APP_DIRS.

Oops, this should have been part of the r580 commit.

Oops, this should have been part of the r577 commit.

Move third-party TinyMCE out of soc/content/js and into the application image root, like other third-party code. Update the app.yaml.template to add /tiny_mce as a source of static content.