return found entity for activity checks

survey access: stylefix and remove public role type

Style fixes in Survey helper.

Added _getSurveyTakeForm to the Survey view. Subclasses can overwrite this method to create their own form. ProjectGradingSurvey will likely be an example for this.

Only initialize a SurveyTakeForm in take instead of in takeGet and takePost. This will allow for other subclassed views to easily replace the form the view is using. Also small style fix in Survey helper.

Split SurveyForm into SurveyTakeForm and SurveyEditForm. This allows for a more cleaner implementation of the Form code. And this will make it easier to break free from the getFields method in the future. Also the getRoleSpecifcFields method and the this_user and project variables have been removed. They are deemed obsolete. Reviewed by: Lennard de Rijk

Do not call takeGet when SurveyForm ValidationError occurs. Problems occured when a SurveyRecord was specified in the SurveyForm. The SurveyRecord data reset the erroneous POST data. Further code reduction might be possible soonish.

Several stylefixes due to received reviews.

Style fixes in Access module.

Style fixes to the GradingProjectSurvey View module.

Sub_merge params for GradingProjectSurvey View.

Added rudimentary grade field to GradingProjectSurvey take View. Patch by: James Levy, Lennard de Rijk Reviewed by: to-be-reviewed

Ensure that the params from subclasses get merged properly with ProjectSurvey view.

Corrected the links to Grading Project Surveys in Program menu.

Added missing import to ProjectSurvey View.

Fix pick_multi only returning one answer as maximum. Reviewed by: Lennard de Rijk

Removed getSurveyResponseFromPost from Surveys helper. We will use the power of Django Forms instead of getting our own properties. This fits better into the rest of Melange which also uses this approach.

Renamed survey-edit-090627.js due to recent changes.

Form errors when taking a Survey now have the correct context.

Fixed Survey Form error giving 505. I failed when changing the system to work with collectCleanedFields.

Surveys can now have required questions and comments can be turned on/off. Storing comments is now working. However some issues arise when form errors occur, like missing context and the errors also trigger before a form has been submitted. Reviewed by: Lennard de Rijk

Added Survey From Field validation. Also added the COMMENT_PREFIX in Survey model to ensure that comments are stored in the same way everwhere. Reviewed by: Lennard de Rijk

Style fixes and a forgotten parameter in Survey(Record) logic. Reviewed by: Lennard de Rijk

Removed unnecessary variable in ProjectSurvey take method.

Overwrite _getSurveyRecordFor in ProjectSurvey view to take StudentProject into account.

Added _getSurveyRecordFor method to Survey View. This method is used by the Take view to get the right SurveyRecord for the current request. Subclassed Views that want to fetch their records in another way can override this method.

Added default Survey list templates for ProjectSurvey and GradingProjectSurvey.

Enable the ProjectSurvey and GradingProjectSurvey views in the core. Also add menu items to the program menu for easy access to these options. Reviewed by: Lennard de Rijk

Implemented taking ProjectSurveys. The user will first be served a list of all eligble StudentProjects for which the ProjectSurvey can be taken. After clicking on the list the key_name of the project is attached as a GET param and the code uses the normal take view with the hooks to let everything run smoothly. An extra access check method is required which checks if the Project mentioned in the GET param is a valid project for the current user. This check will run together with the isSurveyTakable checker.

Edit SurveyRecord model to not make use of different Survey property for each subclass. This does mean that a simple query needs to be constructed by hand whenever you want to query for every SurveyRecord for a specific Survey. However the naming is now the same over each SurveyRecord and it fits well into the rest of the design of Melange.