Thu, 25 Sep 2008 17:17:11 +0000 A key_name controller module to collect all of the name...() functions that
Todd Larsen <tlarsen@google.com> [Thu, 25 Sep 2008 17:17:11 +0000] rev 202
A key_name controller module to collect all of the name...() functions that compose Model entity key names, plus some minor changes to other controller modules to illustrate the proposed use. Patch by: Todd Larsen Review by: Pawel Solyga Review URL: http://codereviews.googleopensourceprograms.com/804 Review URL: http://codereviews.googleopensourceprograms.com/804
Wed, 24 Sep 2008 21:23:42 +0000 Fixed missing urlparse import in request_helpers which cause /user/profile and /site/user/profile not to work at all. Removed not used module imports in response_helpers.py.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 24 Sep 2008 21:23:42 +0000] rev 201
Fixed missing urlparse import in request_helpers which cause /user/profile and /site/user/profile not to work at all. Removed not used module imports in response_helpers.py.
Wed, 24 Sep 2008 06:00:28 +0000 Replace mock-up of sidebar with first draft of dynamic sidebar functionality.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 06:00:28 +0000] rev 200
Replace mock-up of sidebar with first draft of dynamic sidebar functionality.
Wed, 24 Sep 2008 05:58:45 +0000 Minor tweaks to Site menu item names to make them more descriptive.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 05:58:45 +0000] rev 199
Minor tweaks to Site menu item names to make them more descriptive.
Wed, 24 Sep 2008 05:58:15 +0000 Major refactoring, to switch from using inheritance from soc.logic.menu classes
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 05:58:15 +0000] rev 198
Major refactoring, to switch from using inheritance from soc.logic.menu classes to an envelope-letter model instead.
Wed, 24 Sep 2008 05:17:44 +0000 Sidebar-building controller, with a TODO remaining to implement marking the
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 05:17:44 +0000] rev 197
Sidebar-building controller, with a TODO remaining to implement marking the current page as "selected".
Wed, 24 Sep 2008 02:46:52 +0000 Make views.helpers.html_menu MenuItem classes and logic.menu MenuItem classes
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:46:52 +0000] rev 196
Make views.helpers.html_menu MenuItem classes and logic.menu MenuItem classes more closely related. This is part of some refactoring in my working copy to keep soc/logic/site/sidebar.py from having to deal with html_menu classes (which is like having view code in the controller, which is bad).
Wed, 24 Sep 2008 02:36:47 +0000 Classes that wrap soc.logic.menu.Menu and soc.logic.menu.MenuItem to produce
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:36:47 +0000] rev 195
Classes that wrap soc.logic.menu.Menu and soc.logic.menu.MenuItem to produce HTML renderings of such lists.
Wed, 24 Sep 2008 02:27:01 +0000 Change indentation level to 2 (from 4) and rename MCE_DEF_SETTINGS to
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:27:01 +0000] rev 194
Change indentation level to 2 (from 4) and rename MCE_DEF_SETTINGS to DEF_MCE_SETTINGS to match the "default constant" naming convention elsewhere in the code.
Wed, 24 Sep 2008 02:24:49 +0000 Note 'groups' back-reference from 'founder' property in soc.models.group.Group.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:24:49 +0000] rev 193
Note 'groups' back-reference from 'founder' property in soc.models.group.Group.
Wed, 24 Sep 2008 02:23:32 +0000 Simple MenuItem and Menu classes for keeping track of ordered menus.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:23:32 +0000] rev 192
Simple MenuItem and Menu classes for keeping track of ordered menus.
Wed, 24 Sep 2008 02:22:12 +0000 These changes should have been in r620, but somehow I did not save them, or
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:22:12 +0000] rev 191
These changes should have been in r620, but somehow I did not save them, or saved over them with an old copy in the editor. Not sure...
Tue, 23 Sep 2008 23:30:15 +0000 Move isReferrerSelf() and replaceSuffix() into new request_helpers.py module,
Todd Larsen <tlarsen@google.com> [Tue, 23 Sep 2008 23:30:15 +0000] rev 190
Move isReferrerSelf() and replaceSuffix() into new request_helpers.py module, since they are (mainly) used to manipulate parts of an HTTP request.
Tue, 23 Sep 2008 23:20:23 +0000 Split out HTTP request manipulation functions from template_helpers.py, which
Todd Larsen <tlarsen@google.com> [Tue, 23 Sep 2008 23:20:23 +0000] rev 189
Split out HTTP request manipulation functions from template_helpers.py, which is in danger of becoming a "misc" or "util" module unnecessarily.
Tue, 23 Sep 2008 19:20:57 +0000 Changes in TinyMCE widget in custom_widgets.py based on review comments.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 23 Sep 2008 19:20:57 +0000] rev 188
Changes in TinyMCE widget in custom_widgets.py based on review comments. Patch by: Pawel Solyga Review url: http://code.google.com/p/soc/source/detail?r=550
Tue, 23 Sep 2008 17:55:54 +0000 Change user list view instruction. Don't show "Next >" disabled greyed text in the list pagination if there is only one page.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 23 Sep 2008 17:55:54 +0000] rev 187
Change user list view instruction. Don't show "Next >" disabled greyed text in the list pagination if there is only one page.
Mon, 22 Sep 2008 14:13:32 +0000 Add Users List Developer view which is available at /site/user/list. Add User list custom templates which are used with list_helpers. Add "Users List" link in base.html template.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 22 Sep 2008 14:13:32 +0000] rev 186
Add Users List Developer view which is available at /site/user/list. Add User list custom templates which are used with list_helpers. Add "Users List" link in base.html template. Patch by: Pawel Solyga Reviewed by: to-be-reviewed
Mon, 22 Sep 2008 14:08:37 +0000 Add list_helpers functions that are going to be used when rendering list views like (Users List, Sponsors List etc).
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 22 Sep 2008 14:08:37 +0000] rev 185
Add list_helpers functions that are going to be used when rendering list views like (Users List, Sponsors List etc). Add list default templates and CSS classes. Patch by: Pawel Solyga Reviewed by: to-be-reviewed
Mon, 22 Sep 2008 13:42:53 +0000 Add support for changing User id (Google Account email) in User Profile Developer view. Now user profile developer edit view includes hidden key_name field. Fix typo in user/profile.py. Show former user ids in lookup and edit User Profile Developer views.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 22 Sep 2008 13:42:53 +0000] rev 184
Add support for changing User id (Google Account email) in User Profile Developer view. Now user profile developer edit view includes hidden key_name field. Fix typo in user/profile.py. Show former user ids in lookup and edit User Profile Developer views. Patch by: Pawel Solyga Reviewed by: to-be-reviewed
Sun, 21 Sep 2008 08:59:11 +0000 Small change to unescape function in template_helpers (move replace('&amp;', '&') at the end).
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 21 Sep 2008 08:59:11 +0000] rev 183
Small change to unescape function in template_helpers (move replace('&amp;', '&') at the end).
Sun, 21 Sep 2008 08:56:52 +0000 Add rounded corners graphics. Add .notice class and rounded corners classes to soc.css file, those will be used to better visualize submit_message like "Profile saved.".
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 21 Sep 2008 08:56:52 +0000] rev 182
Add rounded corners graphics. Add .notice class and rounded corners classes to soc.css file, those will be used to better visualize submit_message like "Profile saved.".
Sun, 21 Sep 2008 08:50:42 +0000 Remove Author model (use Person instead). Update models after removing Author. Add new Sponsor, Organization models.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 21 Sep 2008 08:50:42 +0000] rev 181
Remove Author model (use Person instead). Update models after removing Author. Add new Sponsor, Organization models. Patch by: Pawel Solyga Reviewed by: Todd Larsen Review issue: 801 Review URL: http://codereviews.googleopensourceprograms.com/801
Sun, 21 Sep 2008 02:16:00 +0000 Two changes to ease CI:
Augie Fackler <durin42@gmail.com> [Sun, 21 Sep 2008 02:16:00 +0000] rev 180
Two changes to ease CI: 1) If pysvn is missing, the tests for svn_helper don't run and pollute the output 2) svn_helper no longer depends on being located at trunk/scripts/ Patch by: Augie Fackler Review by: Todd Larsen Review Issue: 802 Reviewed URL: http://codereviews.googleopensourceprograms.com/802
Sat, 20 Sep 2008 19:04:43 +0000 Add custom 404 error message with link to "Create a New User" which is displayed when linkname in User Profile Developer view URL (/site/user/profile/<linkname>) doesn't exist. Add default value (None) to new_suffix parameter of template_helpers replaceSuffix and redirectToChangedSuffix functions.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 20 Sep 2008 19:04:43 +0000] rev 179
Add custom 404 error message with link to "Create a New User" which is displayed when linkname in User Profile Developer view URL (/site/user/profile/<linkname>) doesn't exist. Add default value (None) to new_suffix parameter of template_helpers replaceSuffix and redirectToChangedSuffix functions.
Sat, 20 Sep 2008 17:39:07 +0000 Testing buildbot. Sorry about the noise. (Last one for now, I've got most of the kinks figured out I think)
Augie Fackler <durin42@gmail.com> [Sat, 20 Sep 2008 17:39:07 +0000] rev 178
Testing buildbot. Sorry about the noise. (Last one for now, I've got most of the kinks figured out I think)
Sat, 20 Sep 2008 16:50:20 +0000 Testing buildbot. Sorry about the noise.
Augie Fackler <durin42@gmail.com> [Sat, 20 Sep 2008 16:50:20 +0000] rev 177
Testing buildbot. Sorry about the noise.
Sat, 20 Sep 2008 16:47:09 +0000 Testing buildbot. Sorry about the noise.
Augie Fackler <durin42@gmail.com> [Sat, 20 Sep 2008 16:47:09 +0000] rev 176
Testing buildbot. Sorry about the noise.
Fri, 19 Sep 2008 21:11:39 +0000 Make django.zip in release/, instead of in app/ with a symlink in release/.
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 21:11:39 +0000] rev 175
Make django.zip in release/, instead of in app/ with a symlink in release/. This allows debugging into app/django source code, which the presence of app/django.zip was blocking. Tested with both: dev_appserver.py release and dev_appserver.py app
Fri, 19 Sep 2008 18:02:37 +0000 A rough draft of the Group Model, to be merged with Pawel's current effort in
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 18:02:37 +0000] rev 174
A rough draft of the Group Model, to be merged with Pawel's current effort in his working copy. This is *very* incomplete...
Fri, 19 Sep 2008 17:51:33 +0000 First pass (from some old code notes) of a School Model (a form of Group).
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 17:51:33 +0000] rev 173
First pass (from some old code notes) of a School Model (a form of Group).
Fri, 19 Sep 2008 17:47:21 +0000 First pass (from some old code notes) of a Club Model (a form of Group).
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 17:47:21 +0000] rev 172
First pass (from some old code notes) of a Club Model (a form of Group).
Fri, 19 Sep 2008 12:45:13 +0000 Bug fixes to revision r596. User Account field in Developer User Profile view needs to be an email not a login name. Header title of User Profile Developer view, when form validation failes is now showing correct value ("Modify existing ..." instead of "Create new user ...").
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 19 Sep 2008 12:45:13 +0000] rev 171
Bug fixes to revision r596. User Account field in Developer User Profile view needs to be an email not a login name. Header title of User Profile Developer view, when form validation failes is now showing correct value ("Modify existing ..." instead of "Create new user ...").
Fri, 19 Sep 2008 05:15:20 +0000 Add /site/user/profile Developer view for editing arbitrary User entities.
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 05:15:20 +0000] rev 170
Add /site/user/profile Developer view for editing arbitrary User entities. Update /user/profile edit() view to fix TODO about updating the URL when a POST of the form changes the link_name of the User. Add a Create New User link to the base.html sidebar mock-up.
Fri, 19 Sep 2008 05:12:35 +0000 Fix off-by-one corner case discovered during testing of /user/profile.
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 05:12:35 +0000] rev 169
Fix off-by-one corner case discovered during testing of /user/profile.
Fri, 19 Sep 2008 04:50:42 +0000 Added getSingleIndexedParamValue() that retrieves an index into a list of
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 04:50:42 +0000] rev 168
Added getSingleIndexedParamValue() that retrieves an index into a list of values from the named query parameter, and then indexes into the supplied list of values to return the corresponding value from the list. Used to convert numeric index query parameters passed by POST to the GET redirect target, so that the GET code can display messages, etc. (without passing the message itself as a query argument and having to escape it or have silly people pass in their own...).
Fri, 19 Sep 2008 04:28:17 +0000 Added replaceSuffix(), isReferrerSelf(), and redirectToChangedSuffix() to
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 04:28:17 +0000] rev 167
Added replaceSuffix(), isReferrerSelf(), and redirectToChangedSuffix() to implement the TODO in the User profile views where the link name portion of the URL needs to change when the link_name Property is updated by the form.
Thu, 18 Sep 2008 23:07:06 +0000 Fixed too long lines and deleted unused imports in id_user.py.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 18 Sep 2008 23:07:06 +0000] rev 166
Fixed too long lines and deleted unused imports in id_user.py.
Thu, 18 Sep 2008 22:14:06 +0000 New default values for page title, header title and body of site home page.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 18 Sep 2008 22:14:06 +0000] rev 165
New default values for page title, header title and body of site home page.
Thu, 18 Sep 2008 22:11:56 +0000 Documentation updates and one typo fix.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 18 Sep 2008 22:11:56 +0000] rev 164
Documentation updates and one typo fix.
Thu, 18 Sep 2008 17:33:20 +0000 Add a td.formfielderrorlabel style, to highlight field labels that have errors.
Todd Larsen <tlarsen@google.com> [Thu, 18 Sep 2008 17:33:20 +0000] rev 163
Add a td.formfielderrorlabel style, to highlight field labels that have errors.
Thu, 18 Sep 2008 17:32:28 +0000 Swap field value and "required" columns to make more columns for field errors.
Todd Larsen <tlarsen@google.com> [Thu, 18 Sep 2008 17:32:28 +0000] rev 162
Swap field value and "required" columns to make more columns for field errors.
Thu, 18 Sep 2008 17:31:01 +0000 Add a verbose_name and help_text to the User.id Property.
Todd Larsen <tlarsen@google.com> [Thu, 18 Sep 2008 17:31:01 +0000] rev 161
Add a verbose_name and help_text to the User.id Property.
Tue, 16 Sep 2008 18:02:09 +0000 Explain why pushd and popd are needed when making tiny_mce.zip.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 18:02:09 +0000] rev 160
Explain why pushd and popd are needed when making tiny_mce.zip.
Tue, 16 Sep 2008 18:00:55 +0000 Use zip to compress tiny_mce, and use zipserve to serve it in Google App
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 18:00:55 +0000] rev 159
Use zip to compress tiny_mce, and use zipserve to serve it in Google App Engine.
Tue, 16 Sep 2008 17:38:09 +0000 Updated make_release.sh docs and added way for person invoking the script to override script variables such as RELEASE using something like "RELEASE=../testing_release ./make_release.sh".
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 16 Sep 2008 17:38:09 +0000] rev 158
Updated make_release.sh docs and added way for person invoking the script to override script variables such as RELEASE using something like "RELEASE=../testing_release ./make_release.sh".
Tue, 16 Sep 2008 17:07:58 +0000 Add recently-moved feedparser and tiny_mce to APP_DIRS.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 17:07:58 +0000] rev 157
Add recently-moved feedparser and tiny_mce to APP_DIRS.
Tue, 16 Sep 2008 17:05:43 +0000 Oops, this should have been part of the r580 commit.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 17:05:43 +0000] rev 156
Oops, this should have been part of the r580 commit.
Tue, 16 Sep 2008 17:05:07 +0000 Oops, this should have been part of the r577 commit.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 17:05:07 +0000] rev 155
Oops, this should have been part of the r577 commit.
Tue, 16 Sep 2008 16:49:25 +0000 Move third-party TinyMCE out of soc/content/js and into the application image
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 16:49:25 +0000] rev 154
Move third-party TinyMCE out of soc/content/js and into the application image root, like other third-party code. Update the app.yaml.template to add /tiny_mce as a source of static content.
Tue, 16 Sep 2008 16:42:55 +0000 Add README files to explain how third-party code is maintained in these
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 16:42:55 +0000] rev 153
Add README files to explain how third-party code is maintained in these directories.
Tue, 16 Sep 2008 16:24:18 +0000 Discourage third-party code from being embedded in the soc framework.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 16:24:18 +0000] rev 152
Discourage third-party code from being embedded in the soc framework.
Tue, 16 Sep 2008 16:22:49 +0000 Move third-party feedparser.py out of the soc framework package into its own
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 16:22:49 +0000] rev 151
Move third-party feedparser.py out of the soc framework package into its own package (similar to django).
Tue, 16 Sep 2008 15:56:15 +0000 Changed ZIPFILE variable to DJANGO_ZIPFILE in make_release.sh script and added 'cd $APP_FOLDER' before we zip django.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 16 Sep 2008 15:56:15 +0000] rev 150
Changed ZIPFILE variable to DJANGO_ZIPFILE in make_release.sh script and added 'cd $APP_FOLDER' before we zip django.
Tue, 16 Sep 2008 02:28:33 +0000 Load ../google_appengine into trunk/thirdparty/google_appengine.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 02:28:33 +0000] rev 149
Load ../google_appengine into trunk/thirdparty/google_appengine.
Tue, 16 Sep 2008 01:18:49 +0000 upload.py customized to work with codereviews.googleopensourceprograms.com.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 01:18:49 +0000] rev 148
upload.py customized to work with codereviews.googleopensourceprograms.com.
Tue, 16 Sep 2008 01:18:15 +0000 Pristine initial commit of upload.py script from
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 01:18:15 +0000] rev 147
Pristine initial commit of upload.py script from http://code.google.com/p/rietveld (r310).
Tue, 16 Sep 2008 01:15:00 +0000 gcl.py customized to work with codereviews.googleopensourceprograms.com and the
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 01:15:00 +0000] rev 146
gcl.py customized to work with codereviews.googleopensourceprograms.com and the melange-soc-dev@googlegroups.com mailing list.
Tue, 16 Sep 2008 01:14:18 +0000 Pristine initial commit of gcl.py script from chromium.org.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 01:14:18 +0000] rev 145
Pristine initial commit of gcl.py script from chromium.org.
Sun, 14 Sep 2008 20:32:32 +0000 Release shell script and associated changes. Set svn:ignore property on /app/django.zip file and /release folder.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 14 Sep 2008 20:32:32 +0000] rev 144
Release shell script and associated changes. Set svn:ignore property on /app/django.zip file and /release folder. Patch by: Pawel Solyga, Augie Fackler Review by: Todd Larsen, review-after-commit Review issue: 363 Review URL: http://codereviews.googleopensourceprograms.com/363
Sun, 14 Sep 2008 00:23:49 +0000 FIxed documentation in soc/logic/document.py for getDocumentFromPath function
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 14 Sep 2008 00:23:49 +0000] rev 143
FIxed documentation in soc/logic/document.py for getDocumentFromPath function Patch by: Christian López Espínol Reviewed by: Pawel Solyga Reviewed via: discussion on melange-soc-dev group
(0) -100 -60 +60 +100 +300 +1000 tip