Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 11:46:08 +0000] rev 1083
Moved clean_club_app_link_id to cleaning.
This method is now also used by the club create_form. Which means that you cannot create a new club with an already reserved link_id until the club application has been rejected.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 11:30:43 +0000] rev 1082
Changed group_app logic to support scope_path.
Moved link_id only as keyvalues to club_app.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 11:16:48 +0000] rev 1081
Added a cleaning method to club_app view.
This ensures that you can't create a application for an already taken Link ID.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 11:15:26 +0000] rev 1080
Changed status in group app model to state.
Also changed it wherever needed to increase consistency.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 10:36:23 +0000] rev 1079
Changed clean_link_id to be in a wrapper form as well.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 09:44:46 +0000] rev 1078
Deleted soc/models/member.py since it's the equivalent of club_member.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 09:43:11 +0000] rev 1077
docstring fix in soc/models/student.py.
Patch by: Haoyu Bai
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 09:31:56 +0000] rev 1076
Added agreed_to_tos_on field in user and role model.
Also the user and user_self view no properly handle this new field.
The ToS will be shown on-screen (not in a nice way) only if it is in effect and a user has not signed it yet.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 29 Jan 2009 23:07:04 +0000] rev 1075
Cleaned up overly enthousiastic comments
From the styleguide:
On the other hand, never describe the code. Assume the person reading
the code knows Python (though not what you're trying to do) better
than you do.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 29 Jan 2009 23:05:37 +0000] rev 1074
Properly check if a program is active
Also cleaned up checkIsHost, which got merge-mangled when refactoring
the access module.
Patch by: Sverre Rabbelier