Allows a user object to be passed to accounts.isDeveloper This saves a trip to the database if the user object has already been retrieved. Patch by: Sverre Rabbelier

Make getForFields use the db.Query API While at it, add support for the IN statement in the form of a value of the list type. Patch by: Sverre Rabbelier

Added getForCurrentAccount to user.Logic It returns the user entity associated with the currently logged in user. Patch by: Sverre Rabbelier

Added a filter method to dicts The best way to explain this is probably with an example: >>> split({'foo':'bar', 'bar':['one', 'two'], 'baz': ['three', 'four']}) [{'bar': 'one', 'foo': 'bar', 'baz': 'three'}, {'bar': 'two', 'foo': 'bar', 'baz': 'three'}, {'bar': 'one', 'foo': 'bar', 'baz': 'four'}, {'bar': 'two', 'foo': 'bar', 'baz': 'four'}] Patch by: Sverre Rabbelier

Make it possible to invite another Host as Host We do this by asking Django to resolve the current url for us, then reshufle that url and ask Django (again) to resolve that new url. From that resolved url we know the appropriate view, and as such we know which rights dictioanry to pass to access.checkAccess. Patch by: Sverre Rabbelier

Added a trivial unzip method, counterpart to zip Patch by: Sverre Rabbelier

Add some ignore properties for when we get working coverage support.

Fixed missing header in site settings. Also known as Issue 146. Patch by: Lennard de Rijk

Changed "Sponsor" to "Program Owner" Changed "Host" to "Program Administrator" Patch by: Lennard de Rijk

Adds the removal of requests from the datastore when a new role entity is created. This uses the classname from the role entity as the type of role in the request. Patch by: Lennard de Rijk

Add missing dots in docstrings, proper sorting of imports and small docstring typo fixes. Patch by: Pawel Solyga

Thinkofix in access.checkIsInvited Patch by: Sverre Rabbelier

Some forgotten changes with the access_type commit Patch by: Sverre Rabbelier

Program Name column showed link_id instead of name, replace link_id with name in soc/program/list/row.html template. Patch by: Pawel Solyga

Add explicit access_types from the url This does two things, it reduces the amount of repeated data (e.g., the checkAccess used to repeat the access_type that was already specified in the url). At the same time, it allows for example the 'create' page to push its access_type to 'edit'. Patch by: Sverre Rabbelier

Add checkIsHost in access Patch by: Sverre Rabbelier

Some cleanups in role.py and site.py and create() Patch by: Sverre Rabbelier

Changed template for home/public.html to show last modified in the top-right corner. Patch by: Lennard de Rijk

Add site scoped documents to the Site menu This allows for featured documents that belong to the Site scope to show up in the 'Site' menu. Patch by: Sverre Rabbelier

Move document sidebar entries extraction to document.View This way other modules can benefit from the same logic. Also make use of the sidebar.getSidebarMenu method so that getMenusForScope is no longer specific to full menu's. Patch by: Sverre Rabbelier

Factor out sidebar entry construction This makes it possible to reuse this logic in other modules as well, preventing code duplication. While at it, move additional_sidebar merging before the other entries (additional entries should go first, since the other entries are mostly dev-only etc). Patch by: Sverre Rabbelier

Rename getSidebarLinks to getSidebarMenus Patch by: Sverre Rabbelier

Remove bogus scope from Site This makes Site an unscoped entity (similar to how User and Sponsor do not have a scope). Patch by: Sverre Rabbelier

If an entity is unscoped, do not try to retrieve a scope Patch by: Sverre Rabbelier

Dynamically add sidebar items for programs This adds sidebar items for programs as appropriate. From the docstring: A menu item is generated for each program that is currently running. The public page for each program is added as menu item, as well as all public documents for that program. Additionally, we allow access to a program's public page to everyone, even if the user is not logged in. Patch by: Sverre Rabbelier

Add and use a placeholder for checkIsDocumentPublic We should somehow decide whether a document is publically viewable. This should of course be dependant on what the document is, e.g. the FAQ of a program should be allow(), whereas a student's application should be checkIsMentor(). Patch by: Sverre Rabbelier

Added a public redirect Also some minor cleanups in the redirects code. Patch by: Sverre Rabbelier

Prepare for callbacks that return more than one menu This paves the way for callbacks that dynamically construct their menu based on in-db content, such as Programs and Documents. Patch by: Sverre Rabbelier

Make use of the 'sidebar' param for user_self Instead of overriding getSidebarLinks we use the sidebar param since user_self is now in it's own View. Patch by: Sverre Rabbelier

Fixed email adress in urls.py. Patch by: Lennard de Rijk

Fixes 'module' object has no attribute 'handler500' and 404 on instances where debug is False. Patch by: Lennard de Rijk

Fixed the header on the List Programs page. Patch by: Lennard de Rijk

Reset the RELEASE_TAG to None (unreleased) now that the 0.1a20081206 release candidate branch has been created. Patch by: Pawel Solyga

Set RELEASE_TAG to 0.1a20081206rc for release candidate 06/12/2008. Patch by: Pawel Solyga

Fix imports sorting in soc.views.models.organization. Patch by: Pawel Solyga

Add missing dots in docstrings in modules. Patch by: Pawel Solyga

Changed generic_name to group_label in models/program.py. Also I've updated the comments and help text to explain the meaning of this field. Patch by: Lennard de Rijk

Updated to the latest version of upload.py Patch by: Sverre Rabbelier

Load ../../google_appengine_1.1.7/ into trunk/thirdparty/google_appengine.

Comment fixes for state in group and role model. Patch by: Lennard de Rijk

Fix for randomely ocurring bug The bug and it's fix are described by the first comment from Guido in http://code.google.com/p/googleappengine/issues/detail?id=772. Patch by: Guido van Rossum

Changed state property for models/group.py to be optional as the description states. Patch by: Lennard de Rijk

Added organizations Really basic for now, next stop is to have a proper document selector for the Presences. Patch by: Sverre Rabbelier

Cleanups in group and program The missing super call in group prevented the scope from being set as it should be. Patch by: Sverre Rabbelier

Added a new create regexp in urls for just scope_path Now that scope_path is properly defined we can add a url matching just the scope path. This allows some other custom create regexps to be removed/rewritten. Note: It needs to be -after- the full key_name regexp, since for arbitrarily nested scopes it would always match as just scope_path, even if there are other fields needed after the scope. Patch by: Sverre Rabbelier

Introduce dynamic scope_path regexps Instead of relying on scope_path's being "one slash deep", we should instead allow for either: 1. scope_paths that have a pre-defined depth 2. scope_paths that can be arbitrarily deep We achieve 1 by setting an entities scope_logic to another logic module. We then recursively call getScopeDepth until we get to the topmost entity (that is, an unscoped entity). A little different is the solution to 2, since some entities can have an arbitrarily deep scope (such as Documents), we need to have some way of signaling this to getScopePattern. A clean solution is to return None, rather than a number. If None is returned, the SCOPE_PATH_ARG_PATTERN is returned as regexp instead, which will match an arbitrarily deeply nested scope. The solution for 2 requires that we return None somewhere in the scope_logic chain, the most straight forward method to do so is to override getScopeDepth anywhere such a scope is needed and make it return None. A more elegant solution however, is to set the scope_logic to that module in all entities that require it. Patch by: Sverre Rabbelier

Added a linkable logic module The linkable logic module is used to signal the fact that the scope of an entity can be any linkable. Patch by: Sverre Rabbelier

Fix scope lookup for unscoped entities As scope_logic is now always set (since r1250), we need to check if it is None, rather than check if it exists. Patch by: Sverre Rabbelier

Swap the order of request key fields This will make it easier to remove scope_path as explicit key field at some point by having it as inplicit key field for all entities. Patch by: Sverre Rabbelier

Use key().name() instead of link_id This is now possible because key_name is constructed purely from the key fields of an entity. It is not sufficient to use just link_id, that works only for single-scoped entities (e.g., those that either do not have a scope, or that have a scope which itself does not have a scope). It would break if there was an entity that has a scoped scope (it would only include the scope's link_id in the url, which made it impossible to look up the scope as we missed the link_id of the scope's scope). Patch by: Sverre Rabbelier

More DI on scope_logic Patch by: Sverre Rabbelier

Partial revert Last commit contained some changes that did not belong there, revert them for now. Patch by: Sverre Rabbelier

Some more cleanups in base.Logic Patch by: Sverre Rabbelier

Apply DI on the scope logic Patch by: Sverre Rabbelier

Removed unused file path_link_name Patch by: Sverre Rabbelier

Remove unneeded method getSuffixValues Patch by: Sverre Rabbelier

Some style and typo fixes in different modules. Patch by: Pawel Solyga

Some more import sorting fixes and docstring typos in program modules and soc.views.helper.redirects module. Patch by: Pawel Solyga

Fix import sorting and docstring typos in soc.views.models.program module. Patch by: Pawel Solyga

Fix import sorting in soc.views.sitemap.build module. Patch by: Pawel Solyga

Some style fixes in soc.logic.helper.notifications module. Little changes in welcome.html template. Patch by: Pawel Solyga

Make base.View.create lookup the scope if appropriate Also re-introduce the custom description of the list selection for the redirection. Patch by: Sverre Rabbelier

Make use of the new generic key_name by lookup up scope_path This way base classes do not have to look up the 'scope' property, instead they can rely on the base class to do it for them provided they define the 'scope_logic' param. Patch by: Sverre Rabbelier

Change the key name to not include entity type This allows for direct lookup by scope_path, rather than having to do more complex things. Patch by: Sverre Rabbelier

Introduced django_extra_patterns This way no classes ever need to override the getDjangoURLPatterns, which results in less code, which is also more clear (that is, it is immediately obvious that a View adds an extra mapping if it sets the new django_extra_patterns value, or that it overrides the mapping when it sets django_patterns_defaults. Patch by: Sverre Rabbelier

Make scope_path required for program Patch by: Sverre Rabbelier

Factor out the Group part of Sponsor This makes it possible to reuse the Group logic. Patch by: Sverre Rabbelier

Rename role.RoleView to role.View Patch by: Sverre Rabbelier

Cleanups in the views module Mainly rename from original_params to new_params (so that the keyword argument in the __init__ method is the same for all). Also use super(View, self) where appropriate. Patch by: Sverre Rabbelier

Cleanups to the logic module Mainly converting to super(Logic, self) and adding some missing empty lines while at it. Patch by: Sverre Rabbelier

Fixed the 'New Host' link Also removed the 'Invite Host' button from the Sponsor view now that the link is working. Patch by: Sverre Rabbelier

Make the 'select entity' View generic This allows the selection of any entity from an arbitrary View by specifying the 'target view' and the redirect function. Patch by: Sverre Rabbelier

Cleanups in preparation of general selector view Renamed LIST... to DEF_LIST since it is a global definition. Renamed getCreateProgramRedirect to getCreateRedirect since it will work on all entities as it uses params. Added a getParams method to base.View Updated selectSponsor as appropriate. Patch by: Sverre Rabbelier

Remove the logic parameter from getListContent Now that params always has a 'logic' attribute, we can use that instead of requiring that it is passed as argument. Patch by: Sverre Rabbelier

Changed clean_link_id to convert the input to lower characters for user comfort. It has been changed in a couple of files, most importantly in logic/cleaning.py wich will be used by future forms to do their cleaning. Patch by: Lennard de Rijk

Finish Program Added some fields, and made TinyMCE the editor for the description field. Also updated the public page to show these new fields. We really need generic public views... Patch by: Sverre Rabbelier

Brown paperbag fix in recent cycle breaking Self is no longer used, 'error' should be used instead. Patch by: Sverre Rabbelier

Swap order of merged params to fix sponsor select view The sponsor select view (in 'create new program') was showing the wrong information (and also using the wrong list template) because the order in which the params were merged was wrong way around. This fixes that and at the same time fixes the 'instruction_text' attribute, which should be named 'list_description' instead. At the same time we lookup and set Sponsor as the scope of the newly created program. Patch by: Sverre Rabbelier

Remove cyclic imports by moving response method of out_of_band.Error class to soc.views.helper.responses module as errorResponse function. Apply changes to affected files. Patch by: Pawel Solyga

Remov unused import from Quiz model and add missing blank line. Patch by: Pawel Solyga

Remove Great Britain from country list. Great Britain was included as a country, although it has a country code (.gb) it's not a state. United Kingdom is correct and remains in the list. Patch by: Matthew Wilkes Review by: Pawel Solyga

Added programs Currently the programs are somewhat of empty, but due to the ease with which we can add new fields later, it is acceptable to commit it in it's current form. Patch by: Sverre Rabbelier

Allow for extra dynamic fields for the create form Also some minor cleanups, such as making base.Logic inherit from object, as per the style guide. Patch by: Sverre Rabbelier

Fixed a styling error. Patch by: Lennard de Rijk

Added User welcome message. Added templates/soc/mail/welcome.html as a template for the message. Also fixed a cyclic import that was about to happen in notifications.py.

Some docstring fixes in few modules (soc.views.helper soc.views.models.base). Patch by: Pawel Solyga

Add missing dot and correctly sort imports in soc.logic.helper.notifications module. Patch by: Pawel Solyga

Some docstring and missing blank lines fixes in soc.views.sitemap modules. Patch by: Pawel Solyga

Sponsor name now shows in List Hosts. Patch by: Lennard de Rijk

Moved sendInviteMessage to a new module in logic/helper/notifications.py. Renamed sendInviteMessage to sendInviteNotification. Removed the now obsolete imports in logic/models/request.py. This has been done to keep the models/logic modules clean.

Changed email address in logic/models/base.py. Patch by: Lennard de Rijk

Allow developers access to anything that does a checkIsInvited. Patch by: Lennard de Rijk

Remove unused imports from some modules. Patch by: Pawel Solyga

Fix typo and too long lines in soc.logic.models.request module. Patch by: Pawel Solyga

Add missing import, remove unused import and add missing parameters to methods in soc.views.models.user_self module. Patch by: Pawel Solyga

Add missing dots and fix too long line in soc.views.helper.dynaform module. Remove unused imports in soc.views.models.document module. Fix too long lines. Add missing docstring for Meta classes. Patch by: Pawel Solyga

Add module docstring and license for soc, soc.models, soc.views.helper.templatetags. Patch by: Pawel Solyga

Remove python-graph from thirdparty, remove check_includes script and graph folder from scripts. This functionality is (cyclic imports check) is supported by pylint automatically so we don't need that any more. Patch by: Pawel Solyga Review by: Sverre Rabbelier

Fix too long lines in soc.views.models.request, remove unused imports and change pending requests list description. Remove unused imports from soc.logic.path_link_name module. Patch by: Pawel Solyga

Add missing dots in soc.logic.lists module. Change method names to comply with Style Guide. Make class variable protected by adding "_" to the name of variable. Update lists templates respectively (methods name change). Patch by: Pawel Solyga

Remove unused imports in soc.views.models role, host and site modules. Add missing parameter in getDjangoURLPatters method. Patch by: Pawel Solyga

Remove unused imports in soc.views.models.user and soc.views.models.sponsor modules. Patch by: Pawel Solyga

Remove unused import in soc.models.task. Patch by: Pawel Solyga

Fix too long lines in soc.model.work. Patch by: Pawel Solyga

Put the redirects in the views/helper/redirects.py module. Changed the getCreateRequestRedirect to comply with the new signature. Also changed it's docstring to a more suitable one. Fixed a useless merge in views/models/role.py in the process.

Style fixes for previous commit We also need to run pylint. Patch by: Sverre Rabbelier

Added invitation received message upon creating a new invite. Moved the inviteAcceptedRedirect into the logic code. Added a TODO for further user notification upon creating a request. Patch by: Lennard de Rijk

Now invited users can create a new Host profile Before the invited user had to be a developer for this to work. Now, instead the default checkIsDeveloper check for the 'edit Host', a custom checkIsInvite check is used. Patch by: Sverre Rabbelier

Fixed requests not working anymore We really need a test suite. Patch by: Sverre Rabbelier

Fixed a bug in latest commit Patch by: Sverre Rabbelier

Moved getSidebarLinks to sitemap.sidebar This is the fourth, and final patch, that attempts to improve the cohesion in the base.View class. Patch by: Sverre Rabbelier

Moved getDjangoURLPatterns to sitemap.sitemap Third commit in a series that aims to improve the cohesion in the base.View class. Patch by: Sverre Rabbelier

Moved checkAccess and getCleanedFields into access and forms A second patch in an effort to increase the cohesion in the base.View class. Patch by: Sverre Rabbelier

Move parameter construction into a seperate module This is part of an effort to make base.py less bloated and have it's methods be more cohesive. Patch by: Sverre Rabbelier

Documented params usage in soc/views/models/base.py Patch by: Sverre Rabbelier

Fixed AUTHORS to comply with the specified format Patch by: Lennard de Rijk

Added _onCreate _onUpdate and _onDelete methods to logic/models/base.py. These methods can be overwritten by other logic/models/ modules to serve as a way to for instance send out an update message. Patch by: Lennard de Rijk

Fixed typo in docstring. Patch by: Lennard de Rijk

Make forms generic Currently only Sponsor uses the new generic forms, as such this makes the form code more complex. The other forms, however, can be converted in a similar way, which will result in a lot of code reduction. Patch by: Sverre Rabbelier

Made _logic a param The _logic parameter is added in base.py to make this as small and non-intrustive change. Patch by: Sverre Rabbelier