Set new Melange version number to 0-5-20090914 in app.yaml.template.

Using the new checkIsMyActiveRole check where necessary.

Added checkIsMyActiveRole check to the access module.

Make coverage conditional on run.py flag Coverage can now be enabled by running './run.py --coverage'.

Manually call start and end in test_sidebar Since we are not using a request directly we need to manually do the set-up and tear-down required.

Use request.start and end Without the start and end we die on 'assert self.in_request' in the core per request value store methods.

Add a start and end method to MockRequest

Added tag v0-5-200913 for changeset 55adeea795ab

Set new Melange version number to 0-5-20090913 in app.yaml.template.

Changed the conversion starter system to an update starter system. Also increased the usability of the update page by adding more information abou t each update that can be done and for which version number this applies.

Use the new optional argument to endRequest in the middleware Currently endRequest is called twice on an exception if Django intercepts the exception and returns it's own result. By setting optional=True we do not crash on 'assert self.in_request'.

Add optional argument to endRequest The optional argument allows endRequest to be called more than once, as long as any invocation after the first has optional=True.

Document value store methods

Remove memcache setup from interactive.py script Memcache integration with remote_api has been added in the latest AppEngine release, so we no longer have to use the stub.

Add docstring to middleware hooks

Fix copy/paste fail in maintenance middleware docstring

Enable the new middleware and empty the view decorator The view decorator should be removed entirely in a later commit.

Add ValueStoreMiddleware Based on the view decorator.

Add MaintenanceMiddleware Based on the view decorator.

Add ExceptionHandlerMiddleware Based on the existing view decorator.

Add Middleware directory

Fix broken maintenance mode Maintenance mode has been broken since r7fe19ebfe0d3 (Thu Jun 4) "Display caught errors on the page itself", fix it by passing the site entity, rather than the site module to isActivePeriod.

Fix 500 when saving /site/edit without email When saving /site/edit with no no_reply_email set, a 500 error page would be returned due to an empty value being passed as value to the datastore (which is not allowed for email fields).

Remove __melange_queries logging It causes the local instance to become very slow, as it has to pickle all queries. A better solution would be to store them in the per request value store and then add middleware to store that data at end-of-request.

Moved enabling GHOP to settings.py.

Added the GHOP modules to the callback. The ENABLE_MODULE has been added to ensure that the current build does not suffer from any weird artefacts that might occur due to the presence of this module. Of course in time it will be removed. Thanks Madhusudan for getting us this far ^_^. Minor CSS and image patches should follow shortly.

Use available Rights Checker when rights are already defined. Reviewed by: Lennard de Rijk

Several style and import fixes regarding the GHOP module. Reviewed by: Lennard de Rijk

Added jquery in-place-edit. Reviewed by: to-be-reviewed

Added GHOP Program View. Reviewed by: to-be-reviewed

Added GHOP Timeline View. Reviewed by: to-be-reviewed

Added GHOP Task Subscription View. Reviewed by: Lennard de Rijk.

Added GHOP Organization View. Reviewed by: Lennard de Rijk

Added GHOP Org Admin View. Reviewed by: Lennard de Rijk

Added GHOP Mentor View. Note that the access checks have not been updated yet. Reviewed by: Lennard de Rijk

Added GHOP Task View. TODO's have been added on the places where the code struggles with consistency and compactness issues. Reviewed by: to-be-reviewed

Renamed method in GHOP Cleaning to match style guide.

Hook up the conversion tasks

Add a view to start conversion tasks

Add templates for conversion task starter

Fix import sort order

Revert "revert wrong head" This reverts commit re440e94a87.

merge with wrong head

Fix miscaching of homepage Add system.getHostname() and system.getAppVersion() to the homepage key so that we do not use an wrong version.

Use system.getHostname() everywhere Replace os.environ['HTTP_HOST'] with system.getHostname(), as a result we do not crash when 'HTTP_HOST' is unset now.

Add a getHostname to system It is better to abstract how we retrieve the hostname than to access it directly (see also getAppVersion).

Enable local memcache api in interactive console

Scripts to run Shrinksafe during build. The function that runs shrinksafe over JS files has been put to a separate shell file to be run standalone without building if needed.

Added Shrinksafe code to shrink JS files before deploy.

revert wrong head

Added tag v0-5-20090906 for changeset 9f7f269383f7

Fix miscaching of homepage Add system.getHostname() and system.getAppVersion() to the homepage key so that we do not use an wrong version.

Set new Melange version number to 0-5-20090906 in app.yaml.template.

Use system.getHostname() everywhere Replace os.environ['HTTP_HOST'] with system.getHostname(), as a result we do not crash when 'HTTP_HOST' is unset now.

Remove some left overs from recent Google App Engine 1.2.5 update.

Add a getHostname to system It is better to abstract how we retrieve the hostname than to access it directly (see also getAppVersion).

Update Google App Engine from 1.2.3 to 1.2.5 in thirdparty folder.

Enable local memcache api in interactive console

Fixed Ivory Coast rename that was introduced in r74f0972f52.

Fixed GHOP Cleaning clean_mentors_list method from using query on list. Somehow this fix was missing from the previous revision, bad HG.

Added cleaning method to validate a list of mentor's link_ids. Reviewed by: Lennard de Rijk

Added cleaning method to convert a list of comma separated strings into a set. Reviewed by: Lennard de Rijk

Added additional methods for TaskTag model and add arbit_tag type to GHOPTask.

Updated to r11 of app_profiler

Prefetch referenced fields in project listing

Hook up prefetching in the view (helper)

Add support for prefetching fields This makes it possible to specify the fields that should be prefetched as part of a getForFields query. Doing a prefetch on a ReferenceProperty when it is known that the property will be referenced in (almost all) entities is far more efficient than doing the invididual fetches sequentially.

only store queries in debug mode

fix typo in memcache.get in base logic

Store queries in memcache

Do not store core in Checker

Add self.in_request to Core and verify correct state

Convert profiler/start page to html

Use profiler.py to prevent import failures

Set expiration date of static dirs to 1d

GHOPWorkSubmission model is made id_based and inherits from base. Also a reference property to GHOPOrganization is added in GHOPWorkSubmission model.

Added missing blank line to GHOP redirects helper.

Added __init__ file to the GHOP views module. Reviewed by: Lennard de Rijk

Added list_info method for use in the GHOP module. Reviewed by: Lennard de Rijk

Updated the docstrings for GHOP access methods. The checkRoleAndStatusForTask and checkStatusForTask methods' docstrings tell more on what they specifically do and why they both exist separately.

Added access checks for GHOP Module. Reviewed by: Lennard de Rijk

Added redirects module for GHOP. Reviewed by: Lennard de Rijk

Added templatetag and filter libraries for GHOP. Reviewed by: Lennard de Rijk

Set profiler/ to admin only

Use per-request store to store access rights

Use the per-request store to store the context

Hook up the new per-request value storage

Add a new per-request value store to Core

Profiling patch

STATE_TRANSITIONS dictionary values are changed to strings. Our assumption that Python's functions and methods are first class members and using the method names directly as dictionary values doesn't seem to work. So we are using method names as strings in STATE_TRANSITIONS dictionary and getting the method object using getattr.

Added templatetags for use in the GHOP module. Reviewed by: to-be-reviewed

Bulk added templates for GHOPOrganization views. Reviewed by: to-be-reviewed

Bulk add templates regarding GHOPProgram Views. Reviewed by: to-be-reviewed

Bulk add templates regarding Task Views. Reviewed by: to-be-reviewed

Added Task for sending out emails to subscribed users about a Comment. Reviewed by: Lennard de Rijk

Added method to send out mail about a Task update. Reviewed by: Lennard de Rijk

Added template for mails regarding Task updates. Reviewed by: Lennard de Rijk

Added several methods to the Task Logic module. These include the automatic tranistion methods. The methods for running updates , that for instance place comments, in a datastore transition to keep the Task synced with the comments. And a rudimentary way of updating the Tasks' history. Reviewed by: Lennard de Rijk

Removed scope and scope_path properties from GHOPComment since it is ID based.

Added reference to GHOPProgram entity for Work Submissions.

Added GHOP Form cleaning module. Reviewed by: Lennard de Rijk

Added GHOPTaskSubscription Logic module. Reviewed by: Lennard de Rijk

Added GHOP Student Logic. Note that on creation of a GHOPStudent a GAE Task is created to update the taskswith the new GHOPStudent reference. This is due to the fact that we allow users to claim task without being a registered Student. Reviewed by: Lennard de Rijk

Added GAE tasks that are related to updating GHOP Tasks. Several TODO's have been added. Also note that some functionality that is being used here is under construction and is being integrated asap. That's the price to pay for cleaner integration commits I guess :). Reviewed by: Lennard de Rijk

Added GHOP Logic helper package. Reviewed by: Lennard de Rijk

Added ghop-update queue for dealing with GHOP Task updates. Reviewed by: Lennard de Rijk

Added GHOP task package for holding GAE Task related modules.

Removed workflow property from Program model. This has become obsolete with the new Module approach. Also fixed a small error I made when reviewing Madhusudan's timeline patch in _editPost for Program View.

Moved createTimelineForType to Program Logic. Using polymorphism and the timeline_logic keyword argument the TIMELINE_LOGIC collection can now be removed. Reviewed by: Lennard de Rijk

Added timeline_logic keyword argument to Program logic. This will allow us to track which Timeline logic belongs to which each Program.

Make the timeline View work directly on the GSoC timeline for the time being. This will help us get rid of the weird TIMELINE_LOGIC constant we are using now to switch between the different timelines. The other timelines should get their own View module.

Make Sponsor the scope_logic for the GSoC timeline model. This will prevent errors when for instance generating URL's that are relying on the scope of this timeline.

Take the safe way when trying to delete a Sponsor.

GHOPComment Logic is made to inherit from base Logic and made ID based. This matches the recent changes to the GHOP Comment model. Reviewed by: Lennard de Rijk

Added role_name and disallow_last_resign keyword params to OA and Mentor Logic. Reviewed by: Lennard de Rijk

Added GHOPTaskSubscription model to keep track subscriptions for GHOPTasks.

JSLint comment moved because of new uncompressed JSLint complains.

JSLint script file renamed because of better file name style.

JSLint updated to uncompressed version.

Renamed all JS files affected by former commit. And also changed templates accordingly.

Made all JS code JSLint compliant.

JSLint added to verify Javascript code quality against guidelines.

Added SurveyRecordForm for viewing a SurveyRecord. This is subclassed into GradeSurveyRecord form for the GradingProjectSurveys. This should replace the need for the read_only kwarg in SurveyTakeForm. A TODO to try and extract this has been added. Fixes Issue 672. Reviewed by: Lennard de Rijk

Make sure the PlainTextWidget converts linebreaks to proper HTML.

Added tag v0-5-20090825 for changeset 776aae4d0499

Set new Melange version number to 0-5-20090825 in app.yaml.template.

Only create GradingRecords for succeful projects or failed projects with Surveys. This is done because it has no use to create new GradingRecords for already failed/invalid projects because the outcome of this one will have no changing effect on the status.

Set default taking access for GradingProjectSurvey to org. This will allow Mentors and Org Admins to take GradingProjectSurveys in case that an Org Admin has no Mentor roles.

Added org taking access to Surveys. This taking access means that everyone with an active role for any organization for a given program can take the Survey. This will allow one Survey to be taken by both Org Admins and Mentors.

Removed reference to GHOPTask and GHOPProgram. In addition changed required=True to False for information property.

Added GHOPStudent model which inherits from core Student model.

Changed GHOPComment model to inherit from base model. All the properties are specific to the GHOPComment model. The GHOPComment model is also made ID based. Changes changes property from StringProperty to StringListProperty.

Changed all status to start with Uppercase letters, made 3 properties required. Changed all the status to start with Uppercase letters because they are publicly visible. Also changed required=True to False for created_by, modified_by property to allow site admin to create and modify tasks. Also changed required=True to False for history to allow history not to be written until the task is published.

Reverting last 4 patches containing GHOP related views. As Lennard suggested all the model patches should come first followed by the logic and views patches, to make sure nothing committed breaks the existing code after thorough review.

Added extra menu items per GHOPOrganization.

Added Organization View for GHOP. Along with adding the View, the View is also registered with sitemap in the GHOP module's callback.py

Added timeline view for GHOP. Moved the method _createTimelineForType from Views to Logic for both core Program and GHOPProgram. Added default values parameter to apps_tasks_limit and slots in Program model. Registered timeline view for the sitemap in GHOP callback.py. Added timeline view module and class which overrides the edit method. Overriding the params['edit_form'] to accommodate dynainclude and dynaexclude fields.

Extended program configuration create/edit views specifically to support GHOP. Added the first views for GHOP, which are inherited from soc program views. Added new param keys, module_package. url_name key now specifies this is view is from a Melange GHOP module. Also added the view to GHOP module's callback.py. The program Logic class's timeline_logic variable is tied to corresponding timeline logic within the constructor.

Dotted path to the views in URL patterns is changed to a params parameter. This change makes the URL mapping from URL to View method in patterns generic where the base package path is taken from the params['module_package'] value to support module system of Melange where inherited View classes override the params['module_package'] value to specify their own View methods.

program_logic is passed as a parameter to three checkers than hard coding it. program_logic is added as a parameter to checkIsActivePeriod checkCanCreateOrgApp checkIsNotParticipatingInProgramInScope access check methods and the corresponding arguments are added in all the places they are used.

Whitespace fix in Base view.

Argument to_json added to json function in Base view. Its value (which should be a boolean) determines if the data should be converted to a JSON object. Therefore if someone has already a JSON string and wants to return it in a HTTP response, he or she may set to_json=False and the object will not be converted.

Whitespace fix in Program view.

Added redirect for use to manage statistics. Also some minor stylish issues fixed.

Added tag v0-5-20090814p1 for changeset 4027acdbf91d

Set new Melange version number to 0-5-20090814p1 in app.yaml.template.

Fixed call to get QueryForFields due to changes in r0548101922. The order argument was given as ancestor instead of order.

Added tag v0-5-20090814 for changeset bb96d2c3885e

Set new Melange version number to 0-5-20090814 in app.yaml.template.

checkIsAfterEvent takes logic as argument instead of hard coded program logic. checkIsAfterEvent access checker uses hard coded core program_logic. Instead it now takes the program logic as an argument to accommodate GHOPProgram logic.

Redone the acceptedStudentsExport functionality. The method has been renamed to exportStudentsWithProjects and retrieves the document_name and the new shipping address properties. Also it filters out all invalid projects or projects for wich the scope_path doesn't match the given scope_pa th_start. Also there is no more need to use the argument given to this method when adding the extra columns. The data is now prepared by one loop which uses the key present in the accepted_students dictionary for retrieving the data used by the extra columns.

Added export for Org Admins and Mentors, but only one per User.

Added methods that give the shipping information for a role entity. The shipping fields are only given when all the required address fields are set. Otherwise the residential fields are returned.

Changed to_dict to call all callable values when their key is in field_names. This is useful for instance when exporting role instances and you want to export document_name.

Fixed Survey Take page which was erroring on undefined variables. Get me a brown paper bag please ^_^.

Removed unused import from GradingProjectSurvey view.

Cleaned up Survey Logic.

Added base Model for Expando models. Due to comments on r031e5828f3.

Added intial GSoC logic modules. This will be filled with GSoC specific code once the transformation is complete.

Added basic GSoC module models. These models will be filled with GSoC specific entries once the transformation is complete.

Added inital GSoC module package structure.

Set ASCII-only cleaner for first and last name when dealing with roles.

Changed the parameter from ancestor to ancestors to accommodate a list of ancestors.

updateOrCreateFromFields is made to call updateOrCreateFromKeyName. updateOrCreateFromFields called self._model.get_or_insert which only creates new entities but doesn't update the properties if the entity already exists. So updateOrCreateFromFields is now made to call updateOrCreateFromKeyName which actually updates the entity properties if entity already exists. Reviewed by: Lennard de Rijk

Added ancestors property to getQueryForFields for queries with ancestor filter. Reviewed by: Lennard de Rijk

Completed the proper filter for the GradingProjectSurvey results view. Also set the access check to checkIsUser.

Project Survey results view now doesn't list all for plain users.

Set the proper filters for the ProjectSurvey results view. Also opened it up to users.

Fix copy/paste fail in Survey results view regarding allowed_to_read. allowed_to_read would never be set to True since survey_entity was not defined.

_getResultsViewRecordFields does not need fields argument anymore. It now returns its own filter dictionary when called. Should be overwritten by subclasses who wish to use other filters.

Open up the Survey Results view for users.

Upgrade jQuery UI to version 1.7. Following our upgrade to JQuery 1.3 we can now upgrade to the most recent version.

Updated several page titles to contain more information. Fixes Issue 437.

Added hook for the edit view. This hook is called on both GET and POST requests.

Redirect to the manage page for failed, completed and withdrawn projects.

Made the specific SurveyTakeForm used in a View part of params. This fixes the Grade question not showing up on the preview and view record pages.

Removed the grade_choices keyword argument from GradeSurveyTakeForm. This is because this class already assumes very specific things about the grade_choices keyword argument. Therefore it is now a constant inside this class.

Enable the project management page to be visited for project in other statusses. This enables org admins to easily view Survey results for projects that have failed.

Added tag v0-5-20090809 for changeset 107bec037dda

Set new Melange version number to 0-5-20090809 in app.yaml.template.

Added project title and student name to the ProjectSurvey take page. This required some reodering of the Survey take template and also a renamed setH elpAndStatus to _setSurveyTakeContext.

Added capability to update a single GradingRecord on the edit page.

Upgrade to jQuery library to 1.3.2 version. This will allow us to use also the new Event object (for example for publish/subscribe pattern) along with some plugins (like Colorbox) which work only with newer (>=1.3) jQuery versions. Some further testing is suggested.

List of countries is actually alphabetically sorted.

Argument store added to updateEntityProperties. This argument determines if an entity should be stored in the data model after its properties are updated. It may be useful, for example, along with tasks (Task Queue API). One may want to make some modifications to an entity during execution of a task, but the developer is sure that at least one new task, which also wants to modify the entity, will be queued, so he or she can just update the entity without saving the changes to the data model, set the entity in memcache and the following task (which is to be executed very shortly) is to retrive the current entity from the memcache (without any expensive calls to the actual data model).

Each country has its continent assigned. In order to retrive the continent, one has to use COUNTRIES_TO_CONTINENT dictionary.

Added and enabled new access check for viewing ProjectSurvey records. Org Admins, project Mentors and project Students are now allowed to see their own ProjectSurveyRecords. Note however that Students and Mentors have no interface yet to find the whereabouts of their records. Fixes Issue 659.

Added and enabled access check for viewing SurveyRecords. Note that viewing ProjectSurveys or ProjectGradingSurveys are still dev only.

Enabled Org Admins to take Surveys on behalf of their Mentors.

The Survey Results view now only list Records of interest to the current user. Also added a hook that can be overwritten by subclasses to adjust the filter. THis will be useful when wanting to filter on ProjectSurveyRecords for a specific org.

Redone the list_info function for the Project's manage page. This will reduce the overhead because Django calls the info method over and over again.

Added redirect to the StudentProject manage page for viewing SurveyRecords.

Whitespace fix in User model.

ViewResults for Surveys is now showing all SurveyRecords. The redirect will redirect the user to the viewing of a single SurveyRecord.

Added redirect for viewing SurveyRecords and enabled links in the Record list. Patch by: Lennard de Rijk and James Levy

Removed TODO from ProjectSurvey and GradingProjectSurvey views.

Added templates for listing SurveyRecords. In the process results_heading and results_row got renamed to records_heading and records_row. Reviewed by: Lennard de Rijk

The Survey public view now uses the proper page name. Also removed the pick view entry from the Survey View.

Added view for showing Survey Records. The current access level is set to Developer only until this feature is complete d. A start has also been made on the viewResults method which will list the appropr iate SurveyRecords for a given survey with a redirect to the viewRecord view. Patch by: Lennard de Rijk and James Levy

Added template for viewing Survey Records. Reviewed by: Lennard de Rijk

Use proper id for survey_description div.

Added link for students to resign their profile to the Program menu. Fixes Issue 549.

Fixed access check for Student Manage/Resign page.

Fixed typo in access module comment and StudentProject list description.

Added minimum age property to Program model. This will allow hosts to specify a minium age requirement for Students wanting to participate in a program. Reviewed and edited by: Lennard de Rijk

Added some helpful text to the Student Project Withdraw view.

Fixed Org home view map to only appear when projects have been announced.

Added tag v0-5-20090802 for changeset 2fb96db18711

Set new Melange version number to 0-5-20090802 in app.yaml.template.

addressed comments by Lennard

add checkIsHostForStudentProject checker

Add parent parameter to accommodate entity groups.

Notification logic in main SoC is capable of getting constructor parameters.

Fix for copy/paste fail

Add link to withdraw student project page

Allow hosts to withdraw student projects

Add three new redirects

Style fixes in the ghop task model module.

Added optional filters property to deepFetch. Note that additional indexes are required whenever this is used. Reviewed by: Lennard de Rijk

Organization home page map dimensions now fit the world.

Role name for mentors now correctly shown in map's infoWindows.

Enable the map that shows the connections between mentors and students.

Edited the role form to clarify the intention of the checkbox+marker.

Renamed main CSS and map JS file due to recent changes.

Moved the student<->mentor map on the org home page below the list. Also fixed the wrong EOL in the home.html template. Patch by: Mario Ferraro and Lennard de Rijk Reviewed by: to-be-reviewed

Redone the student<-> mentor map JS to reflect recent datastructure changes. Reviewed by: Lennard de Rijk (functional review)

Redone the gathering of data for the student<->mentor map. Note that the data is not actually being put in the template yet.

Style fixes in StudentProject View.

Factored out the "No Record Available" message.

Pre-storing the information for setStudentProjectSurveyInfo. This is a rename from getStudentProjectSurveyInfo because it now sets the info directly in the list content. This is done because Django queries the wrapper method every time the info is called in the template.

Added project information to the Project manage page.

Renamed hasAtLeastOneRecord to hasRecord.

Added list of Surveys to the Project's manage page. This list will show wether or not a Survey has been taken and will also feature links to (re)take a Survey and in the near future to see the actual SurveyRecord. Note that the take Survey link is working however Org Admins will receive an access denied message when following this link.

Added getProjectSurveyInfoForProject to list_info helper.

Added new table templates for showing Suryves on the Project manage page. Note that a system for showing SurveyRecords still needs to be committed.

Added columns to the manage project page that show the amount of evaluations. The total possible amount of evaluations that is shown is based on surveys which have at least one Record.

Added hasAtLeastOneRecord method to Survey Logic.

Two style fixes.

Added tag v0-5-20090727 for changeset 0b4358ef9983

Set new Melange version number to 0-5-20090727 in app.yaml.template.

Every radio button is now properly shown on a new line. Update issue 655 Owner: ljvderijk Fixes Issue 655.

Adds to Melange a tags framework based on taggable-mixin. The taggable-mixin allowed only tag per Datastore model. This is extended framework allows any arbitrary number of tags per Datastore model. Also, now one can define different models for different Tag types which are all inherited from the base Tag model provided by taggable-mixin. The GHOPTask model makes use of 2 tags per model, one for difficulty and the other for task_type, both using the tags framework. Reviewed by: Paweł Sołyga

Send out a Notification upon creation of a new Request entity. The receivers are specified by the corresponding Role logic this Role Request is for. Currently Organization and Club Administrators will receive "new request" messages about respectively Mentor and Club Membership requests. Fixes Issue 442.

Use proper in-line import in Request helper.

Added sendNewRequestNotification to the Notifications helper. This method will send out a notification upon arrival of a new Request to all users who have an active role for the Request's scope and the roles as specified by the getRoleLogicsToNotifyUponNewRequest. Also renamed getRoleLogicsToNotifyUponeNewRequest to getRoleLogicsToNotifyUponNewRequest.

Added template for a notification upon arrival of a new Request.

Tables listing Requests now show the name of the Group the request is for/from.

Added missing role_name to org_admin Logic. Also reordered keyword arguments in role Logics.

Added getRoleLogicsToNotifyUponeNewRequest for use with notifications. This method returns a list of all the Role Logics that can be used to query who should receive a notification when a new Role Request arrives.

Use proper in-line imports where possible in the Notifications helper.

fix for issue 653 by adding wrap=hard attr to textareas for surveys

seed_db now creates fixture student project entities, and corresponding project surveys and grading surveys for debugging purposes.

Use role_name where needed for creating/handling requests. Also added TODO to extend the redirect for further use with the new module system.

Use role_name to register the Role with the Group View.

Use role_name from Role Logic as key to store the different Role Views.

Style fixes in Group View.

Added registerRole to Role Logic where all roles are registered. This is used to make the use of the role property in the Request Model more easily consistent.

update Sidebar tests to use getCore

register a core for the test modules to use

Fixed line length.

Another batch of style fixes for Surveys.

More style fixes due to code reviews for Surveys.

Several style fixes and code cleaning for surveys.

Fixed wrong js being referenced by the public Survey template. Reviewed by: Lennard de Rijk

Added validation to email fields where needed. Apparently Django did not generate an email field when it was required. Fixes issue 623.

Slow down mail tasks some more to ensure they actually complete. ApplicationError 1 might occur when mails are being sent too fast.

Added tag v0-5-20090714 for changeset 8846761b3a6c

Set new Melange version number to 0-5-20090714 in app.yaml.template.

Made requested changes to GradingRecord results mail.

Added the ability to update project + mail when editing a single GradingRecord

Fixed message on Records page for GradingSurveyGroups.

Fixed issue where GradingSurveyRecords from another group could be edited.

Added button to the GradingRecords overview to send mail when updating projects. Note that this will mail all the projects for which a record is available.

Added task to send out email for each processed GradingRecord. If send_mail evaluates to True in the POST data for updateProjectsForSurveyGroup task then the results of every GradingRecord will be mailed to the Student. The Mentor and Org Admins will be cc'ed.

Added mail template for when GradingRecords are proccessed.

Made the reminder templates extend the mail base instead of notification.

Added Task to process GradingRecords and update their StudentProjects. An index for this operation is required and has been added to the index.yaml file.

Added updateProjectsForGradingRecords to StudentProject Logic. This method takes a list of record_entities, processes them and batch puts the update StudentProjects.

Add new project status column to accepted students csv export.

Added Student and Mentor link id to the GradingRecord list.

Fixed an error occuring when assigning more then one secondary mentors.

Withdrawn projects are removed from GradingRecord creation/update task.

Changed tag for latest version to match the correct commit. Sorry, somehow one file stayed behind :).

Excluded the new StudentProject failed_evaluations property from Forms. (Something went wrong on my side this should have been in before the tag)

Added tag v0-5-20090713 for changeset 51d83d0572ec

Set new Melange version number to 0-5-20090713 in app.yaml.template.

Added failed_evaluations property to StudentProject model. This is used to store GradingRecords which state a fail for this project. It's a list because manual changes in GradingRecords might force multiple GradingRecords to state a fail. Also it needs to be clear which GradingRecords have been processed and with which grade_decision.

Changed GradingRecord heading/row templates to give more useful info.

Added view for editing GradingRecords. This view shows a list of GradingRecords if the id param is not present in the GET data. Also renamed grading_record to view_records and fixed the redirect for that page to also point to the GradingRecord edit page.

Fixed style error in GradingSurveyGroup Task model.

Made the locked property non-required. This makes it easier to generate a Form that can properly deal with GradingRecords. Since required boolean properties can only be set to true by such an automatically generated form.

Added template for editing GradingRecords.

Added getRecordLogic method to GradingSurveyGroup Logic.

Added redirect for editing a GradingRecord. The view for this will be added in a later commit.

Fixed bug where grade_decision would not be properly set in 2 out of 4 cases.

Style fix in callback.py

Fixed issue with opening items on survey lists while pressing ctrl button

Added messages to the Records page when a task has been successfully started.

Style fixes in GradingRecord Logic.

Changed GradingRecord list templates to show more info. They now show wether or not a Mentor/Student eval has been found.

Added GradingSurveyGroup tasks to the core URL's.

The buttons on the GradingSurveyGroup record page now enqueue Tasks.

Added Tasks to update/create GradingRecords for a given GradingSurveyGroup. Also added a stub to update StudentProjects for a given GradingSurveyGroup.

Added methods to GradingRecord Logic to facilitate creating/updating them. UpdateOrCreateRecordsFor will batch put GradingRecords for a given SurveyGroup and StudentProject. getFieldsForGradingRecord will return the fields that need to be set for a single GradingRecord entity given a StudentProject, GradingSurveyGroup and if it is an update a GradingRecord entity.

Added buttons to start tasks to GradingSurveyGroup Record view. Also fixed an error in the GradingRecord row template.

Fixed errors in comments and docstring for the Surveys Task module.

Refactored logErrorAndReturnOK into separate module.

buildout.cfg: We require nose as well for tests.

Added view to GradingSurveyGroup to list all records for a specified group. This view will later be extended with options to start Tasks for collecting the data and processing it.

Added listing templates for GradingRecords.

Add scope view for GradingSurveyGroup and set access checks. The access checks are now properly set for create, edit and show. To facilitate the scope view the access check have an extra check built in to ensure that a scope is actually present before cheking for an existing Program.

Fixed passing along empty params to scope selection view.

Renamed tag for latest version to match the app.yaml version entry. Thanks to Madhusudan C.S. for noticing this.

Added tag 0-5-20090711p1 for changeset 03aa33e8600b

Set new Melange version number to 0-5-20090711p1 in app.yaml.template.

Removed several sidebar entries for Surveys which where not properly working.

Added tag v0-5-20090711 for changeset 4db295c3fbb3

Set new Melange version number to 0-5-20090711 in app.yaml.template.

Fixed typo in ProjectSurvey reminder mail.

Fixed the redirect for Survey reminder emails.

Fixed typo in GradingProjectSurvey reminder email.

Add queue.yaml to build scripts.

Changed URL pattern for starting sending out survey reminders.

Added the Surveys Tasks to the registered URL patterns.

Added a view to start sending out a reminder. Note that this view is currently developer-only.

Added Surveys Tasks module to send reminders. All reminders are CC'ed to the org admins. Also added an index property on StudentProjects which is required for the reminder Tasks.

Added empty Tasks package and queue.yaml. Also reserved an admin only URL space for use by Tasks.

Edited help text to be more clear when a Survey has been submitted.

Add setOrganizationInSurveyRecords function to stats.py script. setOrganizationInSurveyRecords will iterate thru all ProjectSurveyRecords and GradingProjectSurveyRecords and set the organization property in the record model.This will be useful later for showing Org admins their mentors and students surveys list and results.

Add Organization reference property to ProjectSurveyRecord. Also update ProjectSurvey view _takePost method to set this property everytime survey is taken.

Fix indention and add missing dot in docstring in survey models.

GradingSurveyGroup now uses DynaForm for its forms.

Indention fixes and adding "reference_class=" in ReferenceProperty params.

Start using buildout to bring in external dependencies. This makes running tests easier in situations where dependencies are not always available, such as buildbot. Thanks to Matthew Wilkes <matthew@matthewwilkes.co.uk> for help and moral support.

Added GradingSurveyGroup to the sitemap and sidebar.

Completed the Create and Edit view for GradingSurveyGroup. Note that I've added a TODO to redo _editPost to give us kwargs. Would also get rid of hidden fields elsewhere. Reviewed by: Lennard de Rijk

Fixed GradingRecord and GradingSurveyRecord Logic to load the correct Model.

Added denySidebar to several access checks.

Added Surveys to sidebar menu.

Changed title entry in GradingSurveyGroup's public template to name.

Added skeleton view and templates for GradingSurveyGroup.

Added name property to GradingSurveyGroup. This can be used (by humans :D) to easily identify different instances of this model.

Added missing blank line to GradingSurveyGroup logic.

Added logic for GradingRecord and GradingSurveyGroup.

Removed results list from Survey edit. Some changes to the Survey Result page have also been made, however the results viewer and the CSV export are not working properly in that View. Reviewd by: Lennard de Rijk

Extended tooltip timeout to 10 seconds for all fields. This is because the tooltip currently timesout to fast for people to read the whole stories they can contain. Especially because Surveys can have custom tooltips. Reviewed by: Lennard de Rijk

Minor stylefix to StudentProject model.

Changed the StudentProject model to handle a dynamic amount of GradeRecords. This allows for a dynamic amount of moments where a StudentProject can be evaluated. Also included in this patch are changes to the status property that will help to enable PA's to withdraw StudentProjects from the program without the need for a developer to step in.

Renamed several files due to recent changes.

Style fixing in GradeRecord model

Several Survey UI fixes. Fixes: Too narrow fieldsets in new question/option dialogs. Survey submit (on take view) and save/export/etc. buttons at weird places, instead of at bottom. Weird placement of radio buttons in Opera. Too narrow selects in IE. Broken images in edit view in IE and Opera. Reviewed by: Lennard de Rijk (Only on IE)

Fixed base template URL to tagged version of the deployed source code. The old link revered to SVN based projects. Reviewed by: Lennard de Rijk

Fixed imports for Survey logic.

Added skeleton models for GradingSurveyGroup and Records. SurveyRecordGroup has been renamed to GradingRecord. GradingSurveyGroup will hold which Surveys should be linked. While the acompanying GradingRecords (with their reference to a GradingSurveyGroup) will hold the Records for each StudentProject that can take these Surveys.

Added tag v0-5-20090706 for changeset c17b671e5657

Set new Melange version number to 0-5-20090706 in app.yaml.template.

Ensure that the Grade field data stays in clean_data. This prevents a bug that happens when you pick an invalid entry in the choice a grade field. If this bug was triggered the value of the survey_record.grade was used. Now however a proper ValidationError is raised.

Add missing import to Project Survey view. Reviewed by: Lennard de Rijk

Renamed several files due to recent changes.

Now properly escaping JS and converting new lines into br for Tooltips. Patch by: Mario Ferraro, Lennard de Rijk

Added ability to add custom tooltips and UI improvements. Reviewed by: Lennard de Rijk

Public Survey template now resembles the take template more closely.

Added the possiblitity to add a description to the top of the Survey. Thie uses the content property which has been inherited from the Work model.

Use CSS instead of JS for Survey layout. Reviewed by: Lennard de Rijk

Remove the custom propmpt inside textareas and input fields. This will hopefully be replaced with custom tooltips. Two reasons for this are that the tooltips will still be readable once your start typing and this way we avoid a bug that caused a textarea to go into prompt mode on some form validation errors. Reviewed by: Lennard de Rijk

Fix HtmlSanitizer to return cleaned string in proper encoding. This fix prevent HtmlSanitizer from throwing UnicodeDecodeError exception.

Added clear:right property to submit button in Survey take form. Reviewed by: Lennard de Rijk

Fix button layout on Safari 4.0 for Survey take page. Reviewed by: Lennard de Rijk

Fix comment indention in survey-take javascript file.

Renamed survey-take-090627.js to survey-take-090705.js.

Increased bottom margin on comments for better grouping. Reviewed by: Lennard de Rijk

Changed the filter for getting a SurveyRecord for a ProjectSurvey ProjectSurveyRecords are characterized by the Survey and a Project entity. The user property is just there to state who last submitted the Survey.

Added tag v0-5-20090705p1 for changeset c7726e3ab173

Set new Melange version number to 0-5-20090705p1 in app.yaml.template.

Ensure that accessViolations for Survey menu items get captured. (Also ensure that you think before committing something you broke yourself :()

Added tag v0-5-20090705 for changeset 8f3a8e066111

Set new Melange version number to 0-5-20090705 in app.yaml.template.

Added Menu items for all three kinds of Surveys to the program menu. The menu items turn red when the user has not taken the Survey yet. Patch by: James Levy, Lennard de Rijk Reviewed by: to-be-reviewed

POST data always overwrites survey_record data when used to populate form. It also fixes validation errors on takeGet. Patch by: Daniel Diniz, Lennard de Rijk Reviewed by: to-be-reviewed

Fixes bug when option name contains double quotes.

Several style fixes due to code reviews.

Ensure that long questions and comments are stored as db.Text. This is done by adding the setCleaners methods which sets the appropriate cleaners for dynamic fields. Reviewed by: Lennard de Rijk

Style fix in access module.

Returned ProjectSurvey create to checkIsUser. The access protection is properly done by the form validator.

Added access checks for taking a Project(Grading)Survey.

Brown paper bag fix for using non-existing logic in ProjectSurvey views.

Fixed basic Survey access check. Also enabled this check for all relevant Views. However ProjectSurveys and subclasses still need an additional check. A stub for this has been added to the access module.

Fixed broken selection questions from refactoring SurveyForm. Reviewed by: Lennard de Rijk

Fixed showing the correct list of projects for taking a Grading Project Survey. Note that when a user is a mentor for a lot of Organizations the amount of subqueries might exceed the allowed amount. A TODO has been added to fix this issue. However this will hopefully not be a problem that pops up soon. Also some minor docstring addition to Project Survey view.

Refactored filter construction to _constructFilterForProjectSelection. This allows Grading Project Survey to overwrite this method and create its own filter.

Make sure that radio button questions validate correctly and allow only one choice. Reviewed by: Lennard de Rijk

Added Daniel Diniz and Zachary Voase to the AUTHORS file.

Added Daniel Diniz to authors for Grading Project Survey View.

Add a grade field to the Grading Project Survey form. This also takes care of validating and transforming the data into True(pass) or False(fail). GradingProjectSurveys are hereby working for developers. Reviewed by: Lennard de Rijk

Survey editing/taking Javascript and CSS fixes. This patch adds some cosmetic changes and functional fixes: - UI now removes all of the field content when a field is deleted, - CSS tweaks, and jQuery hack to specialize comment CSS, - fixed JS path in take.html. Reviewed by: Pawel Solyga (with some small changes)

Remove public role type from SURVEY_TAKING_ACCESS in Survey model.

try to fix the surveys-have-no-scope issue to-be-reviewed: also untested

addressed comments to previous version to-be-reviewed: still untested

return found entity for activity checks

survey access: stylefix and remove public role type

Style fixes in Survey helper.

Added _getSurveyTakeForm to the Survey view. Subclasses can overwrite this method to create their own form. ProjectGradingSurvey will likely be an example for this.

Only initialize a SurveyTakeForm in take instead of in takeGet and takePost. This will allow for other subclassed views to easily replace the form the view is using. Also small style fix in Survey helper.

Split SurveyForm into SurveyTakeForm and SurveyEditForm. This allows for a more cleaner implementation of the Form code. And this will make it easier to break free from the getFields method in the future. Also the getRoleSpecifcFields method and the this_user and project variables have been removed. They are deemed obsolete. Reviewed by: Lennard de Rijk

Do not call takeGet when SurveyForm ValidationError occurs. Problems occured when a SurveyRecord was specified in the SurveyForm. The SurveyRecord data reset the erroneous POST data. Further code reduction might be possible soonish.

Several stylefixes due to received reviews.

Style fixes in Access module.

Style fixes to the GradingProjectSurvey View module.

Sub_merge params for GradingProjectSurvey View.

Added rudimentary grade field to GradingProjectSurvey take View. Patch by: James Levy, Lennard de Rijk Reviewed by: to-be-reviewed

Ensure that the params from subclasses get merged properly with ProjectSurvey view.

Corrected the links to Grading Project Surveys in Program menu.

Added missing import to ProjectSurvey View.

Fix pick_multi only returning one answer as maximum. Reviewed by: Lennard de Rijk

Removed getSurveyResponseFromPost from Surveys helper. We will use the power of Django Forms instead of getting our own properties. This fits better into the rest of Melange which also uses this approach.

Renamed survey-edit-090627.js due to recent changes.

Form errors when taking a Survey now have the correct context.

Fixed Survey Form error giving 505. I failed when changing the system to work with collectCleanedFields.

Surveys can now have required questions and comments can be turned on/off. Storing comments is now working. However some issues arise when form errors occur, like missing context and the errors also trigger before a form has been submitted. Reviewed by: Lennard de Rijk

Added Survey From Field validation. Also added the COMMENT_PREFIX in Survey model to ensure that comments are stored in the same way everwhere. Reviewed by: Lennard de Rijk

Style fixes and a forgotten parameter in Survey(Record) logic. Reviewed by: Lennard de Rijk

Removed unnecessary variable in ProjectSurvey take method.

Overwrite _getSurveyRecordFor in ProjectSurvey view to take StudentProject into account.

Added _getSurveyRecordFor method to Survey View. This method is used by the Take view to get the right SurveyRecord for the current request. Subclassed Views that want to fetch their records in another way can override this method.

Added default Survey list templates for ProjectSurvey and GradingProjectSurvey.

Enable the ProjectSurvey and GradingProjectSurvey views in the core. Also add menu items to the program menu for easy access to these options. Reviewed by: Lennard de Rijk

Implemented taking ProjectSurveys. The user will first be served a list of all eligble StudentProjects for which the ProjectSurvey can be taken. After clicking on the list the key_name of the project is attached as a GET param and the code uses the normal take view with the hooks to let everything run smoothly. An extra access check method is required which checks if the Project mentioned in the GET param is a valid project for the current user. This check will run together with the isSurveyTakable checker.

Edit SurveyRecord model to not make use of different Survey property for each subclass. This does mean that a simple query needs to be constructed by hand whenever you want to query for every SurveyRecord for a specific Survey. However the naming is now the same over each SurveyRecord and it fits well into the rest of the design of Melange.

Made the CSV exporter for Survey not rely on the BackReferenceProperty in Survey.

Added getTakeProjectSurveyRedirect. This redirect is used when taking a ProjectSurvey.

Added the possibility to change the action of the form on the Survey take page.

Small style fix in Surveys helper.

Set required is True for StudentProject reference in ProjectSurveyRecord.

Removed obsolete if tag form take template.

Added hook methods to takeGet and takePost.

Fixed typo in title of Survey Take page.

Add a base implementation of takePost. Normal Surveys can now be taken, however comments are not stored yet.

Added getSurveyResponseFromPost method to Surveys Helper. This method will be used to read the POST dictionary from a request. And will transform it into the fields that need to be set in a SurveyRecord for the questions specified by the given Survey. A TODO has been added to handle the naming/handling of the comment fields.

Added updateOrCreateFromFields method to SurveyRecordLogic. The reading of the fields from the POST request will not happen in this Logic anymore.

Added base class logic for Expando based models.

Removed two obsolete/outdated methods in Survey Logic. The updateSurveyRecord can be found in the SurveyRecord logic.

Removed obsolote method call in Program View.

Clean up and other fixes for Survey modules. Reviewed by: Lennard de Rijk

Implemented the takeGet view for Surveys.

Fixed multiple typos in Survey tooltips strings.

Added skeleton for the take view and its template. Also fixed the sorting of imports of the Survey View.

Move getMenusForScope to the end of the View class. Adhering to our principle that we the methods we use for generating our menus can be usually found at the bottom of the View class.

Changed the Survey public view to give a preview of the Survey. Also changed the access rights for deleting a Survey because of the possible invalid references problem. Added two TODO's to the _public method. The first one involves enabling the SurveyForm to generate a form without passing along the Logic since it is only used to retrieve the Survey entity which we already have available. The second one involves a brief discussion about the getFields method's functionality and name.

Removed activate grade URL pattern from Survey View. The remaining methods will be ported over in a patch from Ajaksu.

Brown paper bag "without tea" morning typo fix in Survey View.

Style fix in Survey views helper.

Returned access checks in Survey View to the right state. This got bugged in James's commt.

Fixed too long line in Surveys helper.

Solved some merging problems and use the getRecordLogic where needed.

Reverted some changes in SurveyLogic. SurveyRecord logic is defined in its own module.

Use an existing logic for showing Survey Results.

Merge params from inheriting Survey views so functionality can be reused.

Add more flexibility to the Survey helper for use with the new Survey types. This includes using the new SurveyLogic methods from an earlier commit. And passing on the Logic from the view where necessary.

Added getRecordLogic method to SurveyLogic. This is used to retrieve the SurveyRecordLogic that belongs to a certain SurveyLogic.

Removed setting of the scope in the ProjectSurvey init. This is because it is not possible to query for another entity outside your entity group in the __init__ fucntion.

Added getSurveyForContent method to SurveyLogic. This method returns a Survey for a given content. The backreferenceproperty will not work because of inheritance.

Calling the correct super in Project and Grading Survey Logic.

merged upstream

Add paver script that will replace our current build.sh from scripts folder. Until I update the wiki to describe how this new paver build script works I'm leaving the old one in the repository. Reviewed by: Pawel Solyga

Add checkHasSurveyAccess access check To-be-reviewed, untested code

fixed critical errors related to survey subclassing and renaming of deadline and opening properties, and surveys in sidebar are now marked as such and have a red color if untaken

Removed survey_kind from Survey model. The inheritance structure should make this obsolete.

Set the correct base_model and scope_logic for extended Survey logic.

Added two missing imports to the Project and Grading Surveys views.

Added SurveyContentSchema to improve readability for the survey helper. Reviewed by: Lennard de Rijk

Added tag v0-5-20090629 for changeset 0dee663d6582

et new Melange version number to 0-5-20090629 in app.yaml.template.

Added skeleton view for ProjectSurvey and GradingProjectSurvey.

Prepared Survey access controls to deal with multiple logics. Also added a TODO to move a method to another view.

Extracted the ProjectSurvey and ProjectGradingSurvey records to a new module.

Removed unused import from Survey model.

Separated two survey types out of the main survey model. These models are ProjectSurvey and GradingProjectSurvey.

Seperated Logic for ProjectSurvey and GradingProject surveys. These changes also include their respective records.

Start on adding ProjectSurvey and GradingProjectSurvey. New classes still need to be made for logic and views so the appropriate methods can be overwritten. Reviewed by: Lennard de Rijk

Added .settings to hgignore. Eclipse IDE uses this map to store some settings. Since this is widely used I decided to add it to the ignore list.

Renamed opening to survey_start and deadline to survey_end. Symmetry seems to be both pleasing and helpful when understanding the code.

Put ResultsLogic in its own Logic module named survey_record.

Removed non-existing import in Survey Logic. James don't get ahead of yourself :D.

Added Survey menu items to the Program menu. Patch by: Daniel Diniz Reviewed by: Lennard de Rijk

Added Surveys to the sitemap. Patch by: Daniel Diniz Reviewed by: Lennard de Rijk

Added View for Surveys. Patch by: James Levy, Daniel Diniz Reviewed by: to-be-reviewed

Added redirect for use in Surveys. Also some minor style changes. Patch by: Daniel Diniz Reviewed by: Lennard de Rijk

Added Access checks for Surveys. Patch by: Daniel Diniz, James Levy Reviewed by: Lennard de Rijk

Added Survey Views Helper for rendering several widgets. Patch by: James Levy, Daniel Diniz, Lennard de Rijk Reviewed by: Lennard de Rijk

Added logic for Survey and SurveyRecord. The logic for the SurveyRecord will be seperated within the upcoming days. Patch by: James Levy, Daniel Diniz, Lennard de Rijk Reviewed by: Lennard de Rijk

Added SurveyRecordGroup for the use in evaluation surveys. Patch by: James Levy, Daniel Diniz Reviewed by: Lennard de Rijk

Added SurveyRecordModel. Lennard: On top of the orginial patch I've added several comments to the fields and two TODO's for further subclassing. Patch by: James Levy, Daniel Diniz, Lennard de Rijk Reviewed by: Lennard de Rijk

Added Survey and SurveyContent model. They are currently located in a single file this can be undone later on. Patch by: James Levy, Daniel Diniz, Lennard de Rijk Reviewed by: Lennard de Rijk

Fixed docstring in Document Logic.

Renamed css due to previous changes in previous commit.

Edited stylesheet for use in Surveys. Patch by: Daniel Diniz, James Levy Reviewed by: Mario Ferraro

Renamed JavaScript files in templates to match the correct files using prefixes.

Adding JS files for use in Surveys. Patch by: Daniel Diniz, James Levy Reviewed by: Mario Ferraro

Added templates considering Surveys. Patch by: Daniel Diniz, James Levy Reviewed by: Lennard de Rijk

Renamed jquery.growfield.js to jquery-growfield.js. Reviewed by: Lennard de Rijk

Patch that adds the JS and CSS files for surveys. The only update is in app/jquery/jquery-ui.core.js, from a non-release (added by Paweł for the date picker) to a slightly updated released version. Reviewed by: Lennard de Rijk, Mario Ferraro Patch by: Daniel Diniz, James Levy

Patch that touches 'upstream' templates, for use in surveys. Consists out of three changes. 1 - Move the </head> placement in base.hmtl to after the closing of scripts_block, so templates that extend base.html can add scripts to the <head>. 2 - Add tooltips for checkboxes inside fieldsets. 3 - Comment out an empty table row in templatetags/_as_table.html, which probably has an arcane reason to stay empty :) Reviewed by: Lennard de Rijk, Pawel Solyga Patch by: Daniel Diniz, James Levy

Fixes an issue where the organization home page would throw a 505 when no projects where accepted. This only happens after the project announced deadline because only then would the project list be constructed.

Added tag v0-5-20090621 for changeset 96ff51144dca

Set new Melange version number to 0-5-20090621 in app.yaml.template

jQuery Spin plugin updated to version 1.1.1 Former version had a bug if max was not specified

Use build-in django 1.0.x on deployed version of Melange. Using SDK (Development server) right now we are still using django.zip when running from build folder and django folder when running from app folder. django.zip file is still uploaded when deploying the app but it's not used. We might totally get rid of django folder and django.zip soon (discussion needed).

Update GAE to 1.2.3 in thirdparty folder.

Added tag v0-5-20090608 for changeset 19e9fdde919e

Set new Melange version number to 0-5-20090604 in app.yaml.template

Temporary fix for Issue 636 by turning off the caching of the page's entities. This also means that pagination is turned back on because querying all 1000 projects every time will take too long.

fix copy/paste fail in homepage caching

Added group attribute to each GHOPProgram property so it is grouped on edit/create forms. Added 3 new groups, "Contest Rules" group, "Prize Information" group and "Task Settings" group to organize the properties in a useful manner on the edit/create forms. Reviewed by: Lennard de Rijk

Changed GHOP module imports to be consistent with rest of Melange code. The imports used the from <module-path> import <module> as <local_module_name> syntax. These kinds of imports are changed to import <module_path.module_name> syntax to be consistent with the Melange code base. Reviewed by: Lennard de Rijk

Changed the property that holds the minimum age required for Students to participate in a GHOP based program. Added a new property student_min_age_as_of to hold the DateTime from when the minimum age should be reached. Changed student_min_age property to now store the student minimum age as an integer. This all feel more user friendly then letting the program admin calculate the required DateTime. Storing the two properties is then still needed in this case since information might be lost otherwise when the program admin brings up the edit view. Reviewed by: Lennard de Rijk

Remove now unneeded getCallback from ghop.__init__

Remove getCallback indirection in modules Instead, assume that the imported module contains the Callback class that was previously returned by getCallback. This is done to prevent a circular import (caused by the __init__ importing a submodule).

Removed authors from 'empty' __init__.py files.

Add HTTP_HOST to environ variables mocked. Also add license headers to run.py.

Added logic for every GHOP specific model. Defined logic for every model defined for GHOP. These logics do nothing special now. They are just inherited from their parent classes. Necessary GHOP specific logic will be added later as necessary. Reviewed by: Lennard de Rijk

Added licenses and fixed the authors of __init__.py for the GHOP module.

Changed imports in models to comply with recent GHOP code move. Reviewed by: Lennard de Rijk

Removed unused import.

Moved the GHOP module into the modules package. This also includes moving the templates and content into their respective place inside the Soc folder. This is to avoid adding every folder to the app.yaml file. Patch by: Madhusudan C.S. and Lennard de Rijk Reviewed by: Lennard de Rijk

also rename batch_size in cron.py

Added tag v0-5-20090604 for changeset 1dc8d7f9458e

Set new Melange version number to 0-5-20090604 in app.yaml.template

Display caught errors on the page itself Similar to the previous commit, show directly rather than redirect.

Make the maintenance page a hardcoded response Show the maintenance message on the requested page, instead of redirecting to a specific url which then displays a page with the maintenance notice.

Merge with Pawel's tip.

Partial fix for displaying mentors and students on Organization home page. Connections between mentors and students are not yet displayed and also there is some probably with displaying markers in Safari for some reason, everything works fine in FF.

Comment out GMaps support in Organization home page template.

Small indentation fix.

Add missing if statement in organization list row template.

Fixed an issue where some access checks would fail due to missing arguments. This happens when an org document is being checked for write access when trying to show the edit link on the document's show page.

Introduced 'module_package' key in params dict to support modules in melange

Now showing link to edit the home page document on the home page. This will only show up if you have the right to edit the document. Update issue 271 Now also working for home pages.

Temporary turn off GMaps support on Organization home pages until it's fixed. Currently not all markers and polyline connections between students and mentors show up.

Added link to edit the Document on the Document's public page. This link will only show if the user is allowed to edit the document. Fixes issue 271. Update issue 271 Owner: ljvderijk

Rename soc-090421.css and update base.html template.

Clarified docstring for document read/write access check.

Small changes in #extra_left, #extra_right tags in css file. Google Maps and Student Project List on Organization home page now doesn't lay on page footer if too high.

Added a link to the website where the user has registered to the welcome email. Fixes Issue 630.

Add taggable-mixin and gviz to build script.

Extend taggable-mixin to support different Tag models. Usage is pretty simple. Tag model is default in Taggable constructor but you can call it with different model like GHOPTaskType that inherits from Tag model. Both Taggable and Tag models have been updated and they don't use hardcoded Tag model anymore and instead use cls of class methods or self.__class__. In case of Taggable it's self.__tag_model.

Make taggable-mixin tests working by updating GAE path.

Merge with Pawel's head.

Add google-visualization-python project to Melange repository. This python module will be used with our Statistics module to leverage Google Visualization API and python as a data source.

Removed unecessary use of %.

Changed University Student expected graduation date to be a dynamic dropdown. The range of choices is dynamically made by taking the current_year-1 to the current_year+20. It does not start at the current year because a Student might need to change it's profile during a Program that runs across multiple years.

Added GHOP specific Mentor and Org Admin Models.

Add missing __init__.py file in taggable-mixin module.

Add taggable-mixin to Melange repository.

Add some missing docstrings to Seeder classes in seed_db.py

Style fixes and pylint: disable-msg comments in different modules.

Add pylint: disable-msg= where needed in Melange modules.

Rename bathSize variable to batch_size in soc.logic.models.base module.

Style fixes and wrong function call fix in soc.views.helper.lists module.

Remove unused variable from soc.view.models.cron module.

Some more pylint fixes in different Melange modules.

Style and pylint fixes in Melange modules.

Style and variable names fixes in soc.modules.core module.

Remove unused imports in Melange modules.

Remove unused imports from main.py.

Some small fixes to unique_user_id_adder module.

Fixed typo in org_prize_assignment model.

remove accidental head

Fixed the notification list to show a properly formatted date and time column.

Link id and key name fixes for Organization And OrgApplication in seed_db.

Add Organization Application seeding. Fix the seeding in seed_db so that a consistent linkid for organization applications is used. Use the last entry in the split array instead of the 2nd.

Make user_id property in User model not required.

Merged with Sverre

Fixed model name and comment typo's in task model. Also changed the corresponding reference properties.

Added several models related to the GHOP workflow. These models will form the base of the GHOP infrastructure together with the already commited task model. Reviewed by: Lennard de Rijk

Do not die on NeedIndexErrors

Add helper functions, model update and jobs for unique user ids.

Add missing django.template import to shell.py.

Revert "Add a supplemantal block to the edit form" This reverts commit f50455c4cdcb.

Revert "Add an EditForm id to the edit form" This reverts commit f835e39b4dbc.

Add a supplemantal block to the edit form

Add an EditForm id to the edit form

Remove executable bit from datatimepicker

Added GHOP Task model. Reviewed by: Lennard de Rijk

Added __init__.py to ghop folder.

Merge with Sverre's recent module architecture commit.

Add web based python shell to Melange. It is accessible via http://host/admin/shell url and requires developer rights. Shell project is part of google-app-engine-samples. This commit moves django configuration from main.py to separate gae_django.py module. Shell project has been modified in order to work correctly with django 1.0+. Build script has been updated and includes shell folder and gae_django.py file. http://code.google.com/p/google-app-engine-samples/source/browse/trunk/shell/

Comment style fix in soc.views.models.organization module.

First step in the module design The new module design allows modules to be registered by adding them to settings.MODULES. Currently modules cannot do a lot (they can register with the sidebar and the sitemap), but the structure is in place.

Add comment regarding Student Project sorting on Organization home page.

Add sorting of student projects on organization home page. List of student projects on organization home page is now sorted in alphabetical order by student name. Fixes issue 613.

Now clicking cancel button returns user to previous page. Fixes issue 569. If you don't want that behaviour you can define cancel_redirect and user will be redirected to given url on "Cancel" button click instead of redirecting to previous page. Patch by: Daniel Hans & Pawel Solyga

Add comment to clean_html_content function and update __authors__.

Invoke pylint from build script. Using --skip-pylint build script command line parameter you can skip pylint invocation.

Replace usage of feedparser for sanitizing html with new HtmlSanitizer module. HtmlSanitizer prevents from XSS attacks (Fixes issue 606).

Add htmlsanitizer folder to build script.

Add missing __init__.py file to htmlsanitizer folder.

Add HtmlSanitizer python module to Melange repository.

Add BeautifulSoup Python HTML/XML parser to Melange repository.

Add acceptedStudentsCSVExport function to stats.py script. This funtion is used to generate CSV with all accepted students. It still needs some work and I left TODOs there. I also added helper function for saving data to CSV, which can be reused for other kinds of reports.

Remove accidentaly committed file.

Merge with Sverre's accidental head.

Do not rely on notifiction module being imported This has worked so far mostly by accident, but it turned out to be brittle while writing tests. This makes sure that the notification module is always imported before use.

Style fixes in test_functional.py.

Add some example function tests that use gaeftest

Use key_name instead of link_id Some entities do not have a link_id, but all entities are guaranteed to have a key_name (or an id).

Use key_name instead of link_id Some entities do not have a link_id, but all entities are guaranteed to have a key_name (or an id).

Include required antl3 library and check if datastore is available The datastore is checked for availability before requesting it to be cleared. This is because gaeftest uses its own method for ensuring no leakage of data by providing a temporary file as the backend. Reviewed by: Sverre Rabbelier

Use offset_linkid instead of offset to scan >1000 entities. this is a first-cut. It works in all the ways I could make earlier versions fail. It passes link_id as URL parameters. It also has a new class LinkCreator which makes the main body of getListContents even easier to write. I wasn't sure if link_id's could have non alphanumeric characters; if so, they need to be URL encoded/decoded. I also need to go and remove any mention of raw offsets now, because we don't use them. I believe I've talked about this approach with a few of you and it sounded reasonable. Feel free to roll-back/fix/amend/comment-for-me-to-fix. This is my first big-logic-change to Melange. Patch by: Dan Bentley

Revert not finished 1000 limitation fix commit (ef7222d484). We are going to put this into separate branch until it's finished.

Add vcs-load-dirs project to thirdparty directory. vcs-load-dirs project contains load-dir scripts for different version control sysystems including git, hg, darcs, bazaar. More information about the project: http://software.complete.org/software/wiki/vcs-load-dirs/ http://software.complete.org/static/vcs-load-dirs/doc//hg_load_dirs.1.html

Add .DS_Store Mac OS X specific files to .hgignore.

Update Google App Engine to 1.2.2 in thirdparty folder.

added foo

Fix ordering of names in AUTHORS file.

Add .gitignore to .hgignore We're all ignoring one another, pretending the other doesn't exist at all, how rude!

Add .git to the .hgignore file

Remove __init__.py from project root as well This is in line with the earlier patch to remove the __init__.py file from the app/ directory. --- 0 files changed, 0 insertions(+), 0 deletions(-) delete mode 100644 __init__.py

[PATCH] Remove __init__.py from app, as app is not a module From 6916391964ed3b48021351d3a9ea7a7bc836a373 Mon Sep 17 00:00:00 2001 Date: Sat, 9 May 2009 15:19:04 +0200 --- scripts/build.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) delete mode 100644 app/__init__.py

Renamed duplicate slots because of recent changes.

Fixes Issue 625 where the Duplicate calculation would hang if no assigned slots where available. Reviewed by: Lennard de Rijk

Fixed Issue 627 where multiple Purr boxes would show when using calendar widget.

Add Marcelo to AUTHORS file and fix typo

Add coverage support to the test suite This requires nose 0.11 to run.

Added coverage output files to .hgignore Patch by: Sverre Rabbelier

Fixed typo in docstring as to comments on r3012 (svn repo). Also now importing logic and using keyword arguments as to comply with the codebase standards Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Replace BeautyTips tooltips with purr info box for all form fields with help text. Patch by: Mario Ferraro Reviewed by: Pawel Solyga

Use python2.5 in our unit tests Patch by: Sverre Rabbelier

Ignore .project and .pydevproject files Patch by: Sverre Rabbelier

Add full list of accepted students Patch by: Daniel Hans

Ignore backup files (*~) Patch by: Sverre Rabbelier

Ignore zip files and build directory Patch by: Sverre Rabbelier

Merged revert

Backed out changeset 571f2de51138 Test commit that was not meant to be committed. Patch by: Sverre Rabbelier

Make dev_appserver error out when python version >2.5 is used Patch by: Sverre Rabbelier

Added file 'foo.txt'

Fixed StudentProposal apply view that broke during split of Create/Edit view. Also included whitespace fixes. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fix Issue 389 (Clicking list entry will not open new tab/window). Patch by: Daniel Hans Reviewed by: Pawel Solyga

Fix too long line in soc.view.models.organization module. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Remove E1103 and E1101 errors from ignore list in pylintrc file. We are going to use "# pylint disable-msg=E1103" comments in the source file itself to ignore false-positives. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Style fixes in app.soc.views.models.student_project module. Too long line and missing whitespace. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Show all Co-Mentors on the Student Project public page. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed Additional Mentors to Co-Mentors in the manage view. Due to a conversation with Pawel. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added functionality to set additional mentors for a Student Project. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed missing value in context when a form with a different name then form was used. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fix broken tests by renaming default app id from "your_app_id" to "test-app-run". This fix is required due to changes in GAE 1.2.1. Patch by: Pawel Solyga

Add .hgignore to repository and ignore all .pyc files and app.yaml file. Patch by: Pawel Solyga

Add getStudentsProjects to context in stats.py script. Patch by: Pawel Solyga

Load /Users/solydzajs/Desktop/google_appengine into trunk/thirdparty/google_appengine.

Renamed .css file due to recent changes. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added map of accepted student proposals to mentors to the org home page. Patch by: Madhusudan C.S Reviewed by: Lennard de Rijk

Fix missing dot in stats.py docstring. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Fixing the build now that emails have been tested. Patch by: Augie Fackler

Intentionally breaking the build so that we can verify BuildBot will send email. Patch by: Augie Fackler

Fixing the build now that emails have been tested. Patch by: Augie Fackler

Intentionally breaking the build so that we can verify BuildBot will send email. Patch by: Augie Fackler

Added reviveJobs and deidleJobs to stats.py These can be used to mark jobs as 'waiting' (meaning they will be executed again). Patch by: Sverre Rabbelier

Email address is actually private, not public, make this obvios Patch by: Sverre Rabbelier

Set the last_modified_on date to last change Patch by: Sverre Rabbelier

Set batch size to 10 Patch by: Sverre Rabbelier

Added index needed to convert proposals Patch by: Sverre Rabbelier

Some minor style fixes. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed the accepted and rejected list to redirect to the review page in ListProposals view. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Allowing student project review page to be viewed in read-only mode after the deadline has passed. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed typo in access module naming. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Set new Melange version number to 0-5-20090420 in app.yaml.template. Patch by: Pawel Solyga

Some minor style fixes. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added listing of accepted and rejected proposals to the organization proposal page. The link will redirect to the public page where comments can still be placed. Patch by: Madhusudan.C.S Reviewed by: Lennard de Rijk

Added org_home_gmap function to the map JS for displaying the mentor-student map. Patch by: Madhusudan.C.S and Merio Ferraro Reviewed by: Lennard de Rijk

Added mentor-marker.png to content\images. This is for use on the organization home pages having the map displayed. Patch by: Madhusudan.C.S Reviewed by: Lennard de Rijk

Renamed map JS to facilitate upcoming changes. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added the gathering of data required to display a map on the org home page. Patch by: Madhusudan.C.S Reviewed by: Lennard de Rijk

Added ccTld property to role to retrieve the ccTld of the country of residence for a specific role entity. Patch by: Madhusudan.C.S Reviewed by: Lennard de Rijk

Added dictionary mapping country names to their CCTLD in countries model. Patch by: Madhusudan.C.S Reviewed by: Lennard de Rijk

Don't run in a transaction if not needed Patch by: Sverre Rabbelier

Tweak the 'load balancing' algorithm In order to reduce contention we randomly skipped jobs, but this caused many jobs to end up stopping early. Now instead we keep on going until we time out (also increased the chance of doing work). Patch by: Sverre Rabbelier

Added deleteEntities methods to stats.py Patch by: Sverre Rabbelier

Fixed typo in cron.job module's timeOutJob docstring. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Use status codes in job.py The previous behavior of being able go do 'if not handler.handle' is still valid as the status code for 'timed out' is 0. Patch by: Sverre Rabbelier

getDefaultMailSender now properly handles users who are logged in but not registered. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Allow anyone to see student projects The required rights['show'] exception was already made, but the any_access check was preventing it from being effictive. Patch by: Sverre Rabbelier

Changed the type of Error occurring when no valid sender could be found to a FatalJobError in student_proposal_mailer. This means that the job will be immediately aborted. This patch is due to comments on r3000 by SRabbelier. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Students can not list their own projects before the accepted students announced deadline. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Student Proposal Mailer is now sending out real emails. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed a comment typo and possible bug in mail_dispatcher. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added email templates for accepted and rejected students in a GSoC like program. These templates are specifically for GSoC2009 as per request in Issue 379. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Major brown paper bag fix Filter was set to empty dict while it was passed in as a possibly empty param. Patch by: Sverre Rabbelier

Add a startSpam method to stats This method creates the job responsible for sending out emails to students. Patch by: Sverre Rabbelier

Add job to the index Patch by: Sverre Rabbelier

Add a random chance to ignore a job to reduce contention This should probably be solved better (perhaps with a binary exponential backoff). Patch by: Sverre Rabbelier

Do not fetch all jobs with each poke Patch by: Sverre Rabbelier

Add entityIterator to base Logic Patch by: Sverre Rabbelier

Store how many times a job has timed out and abort if needed Patch by: Sverre Rabblier

Wrong usage of twoline_table_row caused weird layout in project Patch by: Sverre Rabbelier

Add cron.yaml to the build script Patch by: Sverre Rabbelier, Lennard de Rijk

Instead of text_data use key_data property to check for uniqueness. Brown paper bag fix, querying for TextProperty is not smart ^_^. Patch by: Lennard de Rijk, Sverre Rabbelier Reviewed by: to-be-reviewed

Style fix in Job model. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Hook up the Student Proposal Mailer in the cron/jobs module. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added Student Proposal Mailer module for mailing students who are accepted/rejected into the program. TODO has been added to actually sent out the emails. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Various improvements to convertProposals It should now be ready to convert proposals to projects and reject all proposals that were not accepted. Patch by: Sverre Rabbelier

Add a silent option to updateOrCreateFromFields Patch by: Sverre Rabbelier

Fixed wrong import for list proposals view. This seems to be working in the p3 release though. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed typo and added myself to authors in the cron/job module. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Add a script to convert proposals. Patch by: Sverre Rabbelier

Added FatalJobError to the cron/job module. This Error will lead to abortion of the raising job. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed typo in documentation of the Job Model. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed the response message in the cron poke view. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Remove debug url too This should have been part of the previous commit. Patch by: Sverre Rabbelier

Remove testing method and update docstring for cron system Patch by: Sverre Rabbelier

Removed unneeded imports and variables Patch by: Sverre Rabbelier

Add cron, the core of the job system Patch by: Sverre Rabbelier

Add priority groups and jobs to the sitemap Also add an entry in the Site menu to list them. Patch by: Sverre Rabbelier

Add jobs (model, logic, and view) Jobs are the core of the Job system, allowing distributed processing of taks in an interuptable manner. Patch by: Sverre Rabbelier

Add priority groups (model, logic, and view) Priority groups will be a key part of the Job system, allowing the site admin to give a higher priority to certain job types on the fly. Patch by: Sverre Rabbelier

The listing of accepted projects on the Organization's homepage is now timeline dependent. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

White space fix in list_info module. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fix user_self calling editGet with a wrong parameter Also fix wrong call to collectCleanedFields and stray seed argument in user_self. Patch by: Sverre Rabbelier, Lennard de Rijk

Split edit and create into different methods This makes removes unneeded responsibility from the edit view and makes it possible to more tightly restrict the usage of the edit and create views to only creating/editing. Patch by: Sverre Rabbelier

Add support for ID based entities This allows entities that do not have a key name to be created and edited without requiring the presence of a key_name. Patch by: Sverre Rabbelier

Use proposal key instead of raw proposal Patch by: Sverre Rabbelier, Lennard de Rijk

Show in green the proposals that would be accepted Patch by: Sverre Rabbelier, Lennard de Rijk

Add proper generation of Student entities and StudentProposal entities to seed_db module. Add link for generating 200 Students to seed_db.html template. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Rename that should have been part of r2953. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed