Fix 500 when saving /site/edit without email When saving /site/edit with no no_reply_email set, a 500 error page would be returned due to an empty value being passed as value to the datastore (which is not allowed for email fields).

Remove __melange_queries logging It causes the local instance to become very slow, as it has to pickle all queries. A better solution would be to store them in the per request value store and then add middleware to store that data at end-of-request.

Moved enabling GHOP to settings.py.

Added the GHOP modules to the callback. The ENABLE_MODULE has been added to ensure that the current build does not suffer from any weird artefacts that might occur due to the presence of this module. Of course in time it will be removed. Thanks Madhusudan for getting us this far ^_^. Minor CSS and image patches should follow shortly.

Use available Rights Checker when rights are already defined. Reviewed by: Lennard de Rijk

Several style and import fixes regarding the GHOP module. Reviewed by: Lennard de Rijk

Added jquery in-place-edit. Reviewed by: to-be-reviewed

Added GHOP Program View. Reviewed by: to-be-reviewed

Added GHOP Timeline View. Reviewed by: to-be-reviewed

Added GHOP Task Subscription View. Reviewed by: Lennard de Rijk.

Added GHOP Organization View. Reviewed by: Lennard de Rijk

Added GHOP Org Admin View. Reviewed by: Lennard de Rijk

Added GHOP Mentor View. Note that the access checks have not been updated yet. Reviewed by: Lennard de Rijk

Added GHOP Task View. TODO's have been added on the places where the code struggles with consistency and compactness issues. Reviewed by: to-be-reviewed

Renamed method in GHOP Cleaning to match style guide.

Hook up the conversion tasks

Add a view to start conversion tasks

Add templates for conversion task starter

Fix import sort order

Revert "revert wrong head" This reverts commit re440e94a87.

merge with wrong head

Fix miscaching of homepage Add system.getHostname() and system.getAppVersion() to the homepage key so that we do not use an wrong version.

Use system.getHostname() everywhere Replace os.environ['HTTP_HOST'] with system.getHostname(), as a result we do not crash when 'HTTP_HOST' is unset now.

Add a getHostname to system It is better to abstract how we retrieve the hostname than to access it directly (see also getAppVersion).

Enable local memcache api in interactive console

Scripts to run Shrinksafe during build. The function that runs shrinksafe over JS files has been put to a separate shell file to be run standalone without building if needed.

Added Shrinksafe code to shrink JS files before deploy.

revert wrong head

Added tag v0-5-20090906 for changeset 9f7f269383f7

Fix miscaching of homepage Add system.getHostname() and system.getAppVersion() to the homepage key so that we do not use an wrong version.

Set new Melange version number to 0-5-20090906 in app.yaml.template.

Use system.getHostname() everywhere Replace os.environ['HTTP_HOST'] with system.getHostname(), as a result we do not crash when 'HTTP_HOST' is unset now.

Remove some left overs from recent Google App Engine 1.2.5 update.

Add a getHostname to system It is better to abstract how we retrieve the hostname than to access it directly (see also getAppVersion).

Update Google App Engine from 1.2.3 to 1.2.5 in thirdparty folder.

Enable local memcache api in interactive console

Fixed Ivory Coast rename that was introduced in r74f0972f52.

Fixed GHOP Cleaning clean_mentors_list method from using query on list. Somehow this fix was missing from the previous revision, bad HG.

Added cleaning method to validate a list of mentor's link_ids. Reviewed by: Lennard de Rijk

Added cleaning method to convert a list of comma separated strings into a set. Reviewed by: Lennard de Rijk

Added additional methods for TaskTag model and add arbit_tag type to GHOPTask.

Updated to r11 of app_profiler

Prefetch referenced fields in project listing

Hook up prefetching in the view (helper)

Add support for prefetching fields This makes it possible to specify the fields that should be prefetched as part of a getForFields query. Doing a prefetch on a ReferenceProperty when it is known that the property will be referenced in (almost all) entities is far more efficient than doing the invididual fetches sequentially.

only store queries in debug mode

fix typo in memcache.get in base logic

Store queries in memcache

Do not store core in Checker

Add self.in_request to Core and verify correct state

Convert profiler/start page to html

Use profiler.py to prevent import failures

Set expiration date of static dirs to 1d

GHOPWorkSubmission model is made id_based and inherits from base. Also a reference property to GHOPOrganization is added in GHOPWorkSubmission model.

Added missing blank line to GHOP redirects helper.

Added __init__ file to the GHOP views module. Reviewed by: Lennard de Rijk

Added list_info method for use in the GHOP module. Reviewed by: Lennard de Rijk

Updated the docstrings for GHOP access methods. The checkRoleAndStatusForTask and checkStatusForTask methods' docstrings tell more on what they specifically do and why they both exist separately.

Added access checks for GHOP Module. Reviewed by: Lennard de Rijk

Added redirects module for GHOP. Reviewed by: Lennard de Rijk

Added templatetag and filter libraries for GHOP. Reviewed by: Lennard de Rijk

Set profiler/ to admin only

Use per-request store to store access rights

Use the per-request store to store the context

Hook up the new per-request value storage

Add a new per-request value store to Core

Profiling patch

STATE_TRANSITIONS dictionary values are changed to strings. Our assumption that Python's functions and methods are first class members and using the method names directly as dictionary values doesn't seem to work. So we are using method names as strings in STATE_TRANSITIONS dictionary and getting the method object using getattr.

Added templatetags for use in the GHOP module. Reviewed by: to-be-reviewed

Bulk added templates for GHOPOrganization views. Reviewed by: to-be-reviewed

Bulk add templates regarding GHOPProgram Views. Reviewed by: to-be-reviewed

Bulk add templates regarding Task Views. Reviewed by: to-be-reviewed

Added Task for sending out emails to subscribed users about a Comment. Reviewed by: Lennard de Rijk

Added method to send out mail about a Task update. Reviewed by: Lennard de Rijk

Added template for mails regarding Task updates. Reviewed by: Lennard de Rijk

Added several methods to the Task Logic module. These include the automatic tranistion methods. The methods for running updates , that for instance place comments, in a datastore transition to keep the Task synced with the comments. And a rudimentary way of updating the Tasks' history. Reviewed by: Lennard de Rijk

Removed scope and scope_path properties from GHOPComment since it is ID based.

Added reference to GHOPProgram entity for Work Submissions.

Added GHOP Form cleaning module. Reviewed by: Lennard de Rijk

Added GHOPTaskSubscription Logic module. Reviewed by: Lennard de Rijk

Added GHOP Student Logic. Note that on creation of a GHOPStudent a GAE Task is created to update the taskswith the new GHOPStudent reference. This is due to the fact that we allow users to claim task without being a registered Student. Reviewed by: Lennard de Rijk

Added GAE tasks that are related to updating GHOP Tasks. Several TODO's have been added. Also note that some functionality that is being used here is under construction and is being integrated asap. That's the price to pay for cleaner integration commits I guess :). Reviewed by: Lennard de Rijk

Added GHOP Logic helper package. Reviewed by: Lennard de Rijk

Added ghop-update queue for dealing with GHOP Task updates. Reviewed by: Lennard de Rijk

Added GHOP task package for holding GAE Task related modules.

Removed workflow property from Program model. This has become obsolete with the new Module approach. Also fixed a small error I made when reviewing Madhusudan's timeline patch in _editPost for Program View.

Moved createTimelineForType to Program Logic. Using polymorphism and the timeline_logic keyword argument the TIMELINE_LOGIC collection can now be removed. Reviewed by: Lennard de Rijk

Added timeline_logic keyword argument to Program logic. This will allow us to track which Timeline logic belongs to which each Program.

Make the timeline View work directly on the GSoC timeline for the time being. This will help us get rid of the weird TIMELINE_LOGIC constant we are using now to switch between the different timelines. The other timelines should get their own View module.

Make Sponsor the scope_logic for the GSoC timeline model. This will prevent errors when for instance generating URL's that are relying on the scope of this timeline.

Take the safe way when trying to delete a Sponsor.

GHOPComment Logic is made to inherit from base Logic and made ID based. This matches the recent changes to the GHOP Comment model. Reviewed by: Lennard de Rijk

Added role_name and disallow_last_resign keyword params to OA and Mentor Logic. Reviewed by: Lennard de Rijk

Added GHOPTaskSubscription model to keep track subscriptions for GHOPTasks.

JSLint comment moved because of new uncompressed JSLint complains.

JSLint script file renamed because of better file name style.

JSLint updated to uncompressed version.

Renamed all JS files affected by former commit. And also changed templates accordingly.

Made all JS code JSLint compliant.

JSLint added to verify Javascript code quality against guidelines.

Added SurveyRecordForm for viewing a SurveyRecord. This is subclassed into GradeSurveyRecord form for the GradingProjectSurveys. This should replace the need for the read_only kwarg in SurveyTakeForm. A TODO to try and extract this has been added. Fixes Issue 672. Reviewed by: Lennard de Rijk

Make sure the PlainTextWidget converts linebreaks to proper HTML.

Added tag v0-5-20090825 for changeset 776aae4d0499

Set new Melange version number to 0-5-20090825 in app.yaml.template.

Only create GradingRecords for succeful projects or failed projects with Surveys. This is done because it has no use to create new GradingRecords for already failed/invalid projects because the outcome of this one will have no changing effect on the status.

Set default taking access for GradingProjectSurvey to org. This will allow Mentors and Org Admins to take GradingProjectSurveys in case that an Org Admin has no Mentor roles.

Added org taking access to Surveys. This taking access means that everyone with an active role for any organization for a given program can take the Survey. This will allow one Survey to be taken by both Org Admins and Mentors.

Removed reference to GHOPTask and GHOPProgram. In addition changed required=True to False for information property.

Added GHOPStudent model which inherits from core Student model.

Changed GHOPComment model to inherit from base model. All the properties are specific to the GHOPComment model. The GHOPComment model is also made ID based. Changes changes property from StringProperty to StringListProperty.

Changed all status to start with Uppercase letters, made 3 properties required. Changed all the status to start with Uppercase letters because they are publicly visible. Also changed required=True to False for created_by, modified_by property to allow site admin to create and modify tasks. Also changed required=True to False for history to allow history not to be written until the task is published.

Reverting last 4 patches containing GHOP related views. As Lennard suggested all the model patches should come first followed by the logic and views patches, to make sure nothing committed breaks the existing code after thorough review.

Added extra menu items per GHOPOrganization.

Added Organization View for GHOP. Along with adding the View, the View is also registered with sitemap in the GHOP module's callback.py

Added timeline view for GHOP. Moved the method _createTimelineForType from Views to Logic for both core Program and GHOPProgram. Added default values parameter to apps_tasks_limit and slots in Program model. Registered timeline view for the sitemap in GHOP callback.py. Added timeline view module and class which overrides the edit method. Overriding the params['edit_form'] to accommodate dynainclude and dynaexclude fields.

Extended program configuration create/edit views specifically to support GHOP. Added the first views for GHOP, which are inherited from soc program views. Added new param keys, module_package. url_name key now specifies this is view is from a Melange GHOP module. Also added the view to GHOP module's callback.py. The program Logic class's timeline_logic variable is tied to corresponding timeline logic within the constructor.

Dotted path to the views in URL patterns is changed to a params parameter. This change makes the URL mapping from URL to View method in patterns generic where the base package path is taken from the params['module_package'] value to support module system of Melange where inherited View classes override the params['module_package'] value to specify their own View methods.

program_logic is passed as a parameter to three checkers than hard coding it. program_logic is added as a parameter to checkIsActivePeriod checkCanCreateOrgApp checkIsNotParticipatingInProgramInScope access check methods and the corresponding arguments are added in all the places they are used.

Whitespace fix in Base view.

Argument to_json added to json function in Base view. Its value (which should be a boolean) determines if the data should be converted to a JSON object. Therefore if someone has already a JSON string and wants to return it in a HTTP response, he or she may set to_json=False and the object will not be converted.