Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:59:24 +0000] rev 1528
Allow to do 'checkHasActiveRole' checks for document access
This is used for documents in the site prefix.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:58:45 +0000] rev 1527
Simplify the account retrieval logic
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:58:15 +0000] rev 1526
Convert everything to use the new access methods
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:57:13 +0000] rev 1525
Remove direct uses of checkIsActive, replace with helper methods
This makes _checkIsActive a lot easier to understand, and makes the
access checkers involved a lot more explicit.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:56:37 +0000] rev 1524
Make django_args optional where appropriate and whitespace fixes
Access methods that do not use django_args should make it optional.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:56:01 +0000] rev 1523
Added an isDeveloper method to user logic
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:55:23 +0000] rev 1522
Always normalize accounts, before even storing them
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:54:44 +0000] rev 1521
Factor out the getForAccount logic in user
Also normalize the account before retrieving it.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:54:08 +0000] rev 1520
Add a normalizeAccount to logic.accounts
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:53:36 +0000] rev 1519
Remove unused isAccountAvailable function
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:53:05 +0000] rev 1518
Add a _createField hook
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:52:29 +0000] rev 1517
Pass _updateField the entity_properties dict instead of just the value
This enables _updateField to change the value in entity_properties if
desired.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:51:35 +0000] rev 1516
Do not update newly created model properties
There is no real reason to favor old behavior over the current, plus
the new behavior saves an extra disk write (which are expensive).
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:50:59 +0000] rev 1515
Move the hooks in base.Logic to the bottom of the class
This more closely follows 'important methods first'.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:50:22 +0000] rev 1514
Minor cleanups in base.Logic
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:49:45 +0000] rev 1513
Add argument validation to base.Logic
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:49:06 +0000] rev 1512
Remove updateOrCreateFromFields and it's uses
All uses of updateOrCreateFromFields were replaced with
updateOrCreateFromKeyname. This way the logic API is not as cluttered
with a bunch of helper methods.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:48:02 +0000] rev 1511
Fix some whitespace damadge and a style fix
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:47:04 +0000] rev 1510
Remove _silentUpdateEntityProperties
Instead, pass a silent flag to updateEtitytProperties.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:46:29 +0000] rev 1509
Style fix in role.py
Patch b: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:45:53 +0000] rev 1508
Added todo for Lennard
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:45:18 +0000] rev 1507
Make it more explicit which argument is the key_fields
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 26 Feb 2009 09:02:51 +0000] rev 1506
Solved the JSON caching problem for bulk acceptance.
This is done in the same way as it is done in AJAX calls by appending the current time as a GET argument.
Patch by: Mario Ferraro, Lennard de Rijk
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 26 Feb 2009 08:48:02 +0000] rev 1505
Edited checkCanReviewGroupApp to cope with the new pre-rejected status.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 26 Feb 2009 08:47:21 +0000] rev 1504
Add the ability to put GroupApplications into the pre-rejected state.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 26 Feb 2009 08:38:09 +0000] rev 1503
Added pre-rejected choice to GroupApplication.
This will be used to bulk reject organizations.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 26 Feb 2009 04:29:56 +0000] rev 1502
Remove the release.py module and just use the field in app.yaml.template.
This is a DRY fix, to have the release /branches/ and /tags/ use a release
version that is compatible with the app.yaml file "version:" field.
Also, the steps for creating a release were simplified (with several steps
removed), and the release procedure moved to app/README, since
app/soc/release.py is now deleted.
Patch by: Todd Larsen
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 25 Feb 2009 20:42:46 +0000] rev 1501
Make validate.isURLValid more robust
Also make the control flow more explicit while at it.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 25 Feb 2009 20:42:16 +0000] rev 1500
Fixed broken 'Edit <entity name> Settings' for orgs
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 25 Feb 2009 20:41:28 +0000] rev 1499
Fix the delete button submitting the form
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 25 Feb 2009 20:11:22 +0000] rev 1498
Added proposal withdrawal for students.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 24 Feb 2009 23:11:15 +0000] rev 1497
Pass the seed to _constructResponse
This way _editContext has access to it; this will be used by the
commenting system.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 24 Feb 2009 23:10:50 +0000] rev 1496
Allow the document lookup to be done by key name
This will be used by the commenting logic.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 24 Feb 2009 22:15:50 +0000] rev 1495
Removed double home page link in group public view
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 24 Feb 2009 20:48:20 +0000] rev 1494
Reset the RELEASE_TAG to None (unreleased) now that the 0.4-20090224 release
candidate branch has been created.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 24 Feb 2009 20:40:30 +0000] rev 1493
Set RELEASE_TAG to 0.4-20090224rc for release candidate.
Patch by: Pawel Solyga
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 24 Feb 2009 20:29:27 +0000] rev 1492
Textual change in program menu due to comment on r2113.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 24 Feb 2009 20:28:16 +0000] rev 1491
Style fixes in student_proposal and organization view.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 24 Feb 2009 20:14:59 +0000] rev 1490
Textual changes in organization and program view.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 24 Feb 2009 20:13:01 +0000] rev 1489
Added view for organizations to list all proposals.
Currently this redirects to the public view of a proposal.
Also added extra whitespace for clarification in _getExtraMenuItems.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 24 Feb 2009 20:09:36 +0000] rev 1488
Brown paper bag fix
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 24 Feb 2009 19:54:36 +0000] rev 1487
Added list proposals redirect.
This is used to list student proposals directed to one organization.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 24 Feb 2009 19:51:40 +0000] rev 1486
Added a checkHasAny method
A simple 'OR' for checkers.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 24 Feb 2009 19:49:27 +0000] rev 1485
Added redirect for the student proposal view.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 24 Feb 2009 19:43:51 +0000] rev 1484
Changed the method and variable name in student_proposal to match the access type.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 24 Feb 2009 19:43:15 +0000] rev 1483
Added link in program menu to the new list_orgs view.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 24 Feb 2009 19:40:15 +0000] rev 1482
Added view which lists all orgs a student can propose to.
The redirect takes the student to the create proposal page.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 24 Feb 2009 18:58:57 +0000] rev 1481
Add missing comment to checkIsMyEntity
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 24 Feb 2009 18:58:22 +0000] rev 1480
Make all default URLS customizable
Patch by: SVerre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 24 Feb 2009 12:52:19 +0000] rev 1479
Fix the user editing
Noticed by: Lennard de Rijk
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 23 Feb 2009 21:01:33 +0000] rev 1478
Moved google analytics to after the footer block as commented on r866.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 23 Feb 2009 19:52:15 +0000] rev 1477
Update the test suite to match the new signature of the cache methods
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 23 Feb 2009 19:51:41 +0000] rev 1476
Be more lenient in what we accept in cache.get() and cache.put()
This makes testing easier.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 23 Feb 2009 18:27:14 +0000] rev 1475
Make timeline a Linkable
Patch by: Sverre Rabbelier, Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 23 Feb 2009 18:26:00 +0000] rev 1474
Set proper scope_logic for program and timeline
Patch by: Sverre Rabbelier, Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 23 Feb 2009 16:44:47 +0000] rev 1473
Changed the message displayed when no homepage is set to show the correct settings name.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 23 Feb 2009 16:05:30 +0000] rev 1472
Textual change in cleaing.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 22 Feb 2009 21:47:41 +0000] rev 1471
Temp IE7 style fix for forms.
A percentage-based layout does not seem to work in IE7, the fields show up as large as the initial text that is in them.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 22 Feb 2009 21:08:41 +0000] rev 1470
Added list my Student Proposals link to the program menu.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 22 Feb 2009 21:01:43 +0000] rev 1469
Added listing of your own student proposals.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed