Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:59:24 +0000] rev 1528
Allow to do 'checkHasActiveRole' checks for document access
This is used for documents in the site prefix.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:58:45 +0000] rev 1527
Simplify the account retrieval logic
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:58:15 +0000] rev 1526
Convert everything to use the new access methods
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:57:13 +0000] rev 1525
Remove direct uses of checkIsActive, replace with helper methods
This makes _checkIsActive a lot easier to understand, and makes the
access checkers involved a lot more explicit.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:56:37 +0000] rev 1524
Make django_args optional where appropriate and whitespace fixes
Access methods that do not use django_args should make it optional.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:56:01 +0000] rev 1523
Added an isDeveloper method to user logic
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:55:23 +0000] rev 1522
Always normalize accounts, before even storing them
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:54:44 +0000] rev 1521
Factor out the getForAccount logic in user
Also normalize the account before retrieving it.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:54:08 +0000] rev 1520
Add a normalizeAccount to logic.accounts
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:53:36 +0000] rev 1519
Remove unused isAccountAvailable function
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:53:05 +0000] rev 1518
Add a _createField hook
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:52:29 +0000] rev 1517
Pass _updateField the entity_properties dict instead of just the value
This enables _updateField to change the value in entity_properties if
desired.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:51:35 +0000] rev 1516
Do not update newly created model properties
There is no real reason to favor old behavior over the current, plus
the new behavior saves an extra disk write (which are expensive).
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:50:59 +0000] rev 1515
Move the hooks in base.Logic to the bottom of the class
This more closely follows 'important methods first'.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:50:22 +0000] rev 1514
Minor cleanups in base.Logic
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:49:45 +0000] rev 1513
Add argument validation to base.Logic
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:49:06 +0000] rev 1512
Remove updateOrCreateFromFields and it's uses
All uses of updateOrCreateFromFields were replaced with
updateOrCreateFromKeyname. This way the logic API is not as cluttered
with a bunch of helper methods.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:48:02 +0000] rev 1511
Fix some whitespace damadge and a style fix
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:47:04 +0000] rev 1510
Remove _silentUpdateEntityProperties
Instead, pass a silent flag to updateEtitytProperties.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:46:29 +0000] rev 1509
Style fix in role.py
Patch b: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:45:53 +0000] rev 1508
Added todo for Lennard
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 26 Feb 2009 16:45:18 +0000] rev 1507
Make it more explicit which argument is the key_fields
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 26 Feb 2009 09:02:51 +0000] rev 1506
Solved the JSON caching problem for bulk acceptance.
This is done in the same way as it is done in AJAX calls by appending the current time as a GET argument.
Patch by: Mario Ferraro, Lennard de Rijk
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 26 Feb 2009 08:48:02 +0000] rev 1505
Edited checkCanReviewGroupApp to cope with the new pre-rejected status.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 26 Feb 2009 08:47:21 +0000] rev 1504
Add the ability to put GroupApplications into the pre-rejected state.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 26 Feb 2009 08:38:09 +0000] rev 1503
Added pre-rejected choice to GroupApplication.
This will be used to bulk reject organizations.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 26 Feb 2009 04:29:56 +0000] rev 1502
Remove the release.py module and just use the field in app.yaml.template.
This is a DRY fix, to have the release /branches/ and /tags/ use a release
version that is compatible with the app.yaml file "version:" field.
Also, the steps for creating a release were simplified (with several steps
removed), and the release procedure moved to app/README, since
app/soc/release.py is now deleted.
Patch by: Todd Larsen
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 25 Feb 2009 20:42:46 +0000] rev 1501
Make validate.isURLValid more robust
Also make the control flow more explicit while at it.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 25 Feb 2009 20:42:16 +0000] rev 1500
Fixed broken 'Edit <entity name> Settings' for orgs
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 25 Feb 2009 20:41:28 +0000] rev 1499
Fix the delete button submitting the form
Patch by: Sverre Rabbelier