Renamed checkIsHostForProgram to checkIsHostForSponsor. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added rights check to sponsor.py. In the process of doing so also fixed checkIsHostForProgram method in access.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

listRequests now only shows the requests that concerns the given group. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Renamed role_names to role_logic and made it a dictionary. It now maps a role_name to role_logic. This will be useful for listing for instance club members. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed a bug in access.py. Context was not assigned to a variable during a redesign of access.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added cache flush for the user who creates a group and the user whose role has been activated. As requested by Sverre Rabbelier. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added two needed redirects in role.py. To make this work properly group_view was added to params in club_admin and club_member. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Moved listRequests from club to group view. Added a TODO for adding request list to sidebar entry for every group. And for setting the rights for Sponsor view. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Flush the sidebar if a user's rights change Patch by: Sverre Rabbelier

Cache sidebar with a simple caching API We cache the sidebar once for every user, the downside is that once the user meets new access criteria, their sidebar does not get updated. This can be fixed by calling soc.cache.sidebar.flush() when appropriate. Patch by: Sverre Rabbelier

Rename ModelProperties to EntityProperties We use 'model' when referring to the db.Model, the context in which 'ModelProperties' was used we really mean 'entity', which refers to an instantiation of the model. Patch by: Sverre Rabbelier

Added getListRequestsRedirect to redirects.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Forgotten in last commit, the json template Patch by: Sverre Rabbelier

Added request listing for Club Admins. This page will redirect them to the Request Processing page. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed the title for the process_request webpage. Also removed some whitespace. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added getProcessRequestRedirect method to redirects.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added Club Members to SoC. Every user can request to become a Club Member. Club Admins can invite users. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added checkCanMakeRequestToGroup to access.py. Note that states for a group have not been implemented yet, so a TODO has been added for this check. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Moved getGroupEntityFromScopePath to logic/models/role.py. Also removed a TODO that has been done :). Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Have /entity/pick return a JSON object instead of a user view This is in preparation of a patch that will add a more fancy picker with JS. Patch by: Sverre Rabbelier

Add simplejson folder to build.sh script. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Add simplejson library to app folder. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Removed unused method from access.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Do not pass around request anymore in buildSidebar It is no longer needed since checkAccess doesn't require it. Patch by: Sverre Rabbelier

Remove the request and arg parameter from the checkAccess call They are obsolete with the introduction of kwargs (args was never needed in the first place). Patch by: Sverre Rabbelier

Use getSingleton in getUniversalContext Patch by: Sverre Rabbelier

Use ugettext instead of ugettext_lazy Reports from Matthew Wilkes indicate that the regular form of ugettext works just fine. The downside of ugettext_lazy is that it prevents pages containing ugettext_lazy-ed text cannot be memcached, since they cannot be pickled. Patch by: Sverre Rabbelier

Brown paper bag fix. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed a bug in _editPost for club_admin and host. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed clean_url to work with dynaform. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed a bug in _oncreate in soc/logic/models/club.py. Non-existing fields were set. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed user_logic call to it's convenience function getForCurrentAccount. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Coding style fix in views/models/role.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Parameterized patterns in role.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added request creation and processing to role.py. This is used if you want to request to become a certain role for a group. For instance becoming a club member. The process request view will also be used to cancel outstanding invites might this be necessary. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Add Madhusudan.C.S to AUTHORS. Fix docstring parameters list in soc.logic.models.base module Base class getForFields method. Patch by: Madhusudan.C.S Reviewed by: Pawel Solyga

Added checkCanProcessRequest in access.py. This is used in the upcoming Request patch. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Some style guide fixes, docstring fixes and removal of unused imports in different modules. Rename acceptInvite view variable to accept_invite in soc.views.models.host module to comply to our style guide. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix some missing dots in access and club_admin modules. Patch by: Pawel Solyga Review by: to-be-reviewed

Add missing parameter description to docstring of soc.views.models.base module methods. Patch by: Pawel Solyga Review by: to-be-reviewed

Make select link in _as_table_row.html a nice button instead of <a href>. Patch by: Pawel Solyga Review by: to-be-reviewed

Remove extra whitespaces and fix too long lines in soc.logic.helper.request module. Patch by: Pawel Solyga Review by: to-be-reviewed

Remove unused imports from soc.models.club_admin model. Patch by: Pawel Solyga Review by: to-be-reviewed

Remove extra blank lines in soc.views.models.request module. Patch by: Pawel Solyga Review by: to-be-reviewed

Rename acceptInvite view variable to accept_invite to comply to our style guide. Remove unused imports. Add missing blank lines in soc.views.models.club_admin module. Patch by: Pawel Solyga Review by: to-be-reviewed

Rename processInvite view variable to process_invite to comply to our style guide. Remove some not needed whitespaces. Fix listSelf method parameters docstring in soc.views.models.request module. Patch by: Pawel Solyga Review by: to-be-reviewed

Added missing dot to access.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Check if timeline exists and when somebody tries to edit non existing timelime display error message. Add TODO regarding error message customization for Timeline. Add support for calendar widget in timeline for both gsoc and ghop programs (gsoc was hardcoded before). Patch by: Pawel Solyga Review by: to-be-reviewed

Add missing blank lines and remove unused checkIsInvited function from soc.views.helper.access module. Patch by: Pawel Solyga Review by: to-be-reviewed

Rename soc/request/list/row.html template column class "to" to "for" since the name changed in header template. Patch by: Pawel Solyga Review by: to-be-reviewed

Add missing dots in soc.views.helper.redirects module function docstrings. Patch by: Pawel Solyga Review by: to-be-reviewed

Little change in soc.logic.hlper.request module completeRequestForRole function docstring. Patch by: Pawel Solyga Review by: to-be-reviewed

Refactored invite system from club_admin to role to make the system work with host as well. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed an access related bug in checkIsClubAdminForClub. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed bug in access.py concerning host checks. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Add a warning about discarding unsaved changes Also set the colspan of the label (on seperate row) to max. Patch by: Sverre Rabbelier

Changed the access checks to comply with state in request. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Make reference picker work for create too Caveat, it only works for one reference atm. Patch by: Sverre Rabbelier

Brown paper bag fix Patch by: Sverre Rabbelier

Do not crash if an invalid field name is entered Patch by: Sverre Rabbelier

Enable pick links for all the references we have Patch by: Sverre Rabbelier

Adust the as_table tag to render a pick link if appropriate The templates are adjusted to pass on a 'reference' value, which is the url_name of the view from which the entity should be picked. The as_table (and related) function(s) construct and then pass on this argument and enable takes_contex so that we have access to the context of the enclosing template. We only extract ReferenceProperties that end with '_link_id' since that is how all RP's are currently named. It is not possible to create a field with the same name as the RP, as GAE will try to interpret it's contents as the key of an entity before even calling any function we can override. Patch by: Sverre Rabbelier

Add a 'pick' view to the appropriate views Only views that represent entities that are pointed to by a ReferenceProperty at some point are considered 'appropriate'. Patch by: Sverre Rabbelier

Added a 'pick' view This view can be used to pick a specific document and then redirect to another view. Patch by: Sverre Rabbelier

Add redirects for the new pick view Patch by: Sverre Rabbelier

Add a simple access check for a picker The picker page should not be accessible if the required GET args are not present. Patch by: Sverre Rabbelier

Added missing changes from r1522. Eclipse found it funny not to save resources ^_^. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Renamed redirect methods to comply with the rest of the module. Added use for getInviteAcceptedRedirect in the soc/views/models/request.py process_invite view. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Replaced the boolean properties in soc/models/request.py with a state property. new : new Request group_accepted : The group has accepted this request completed : This request has been handled either following a creation of the role entity rejected : This request has been rejected by either the user or the group ignored : The request has been ignored by the group and will not give the user access to create the role Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Restore context in deny() page Now that we know when the sidebar is doing the access checks we can safely construct a new context in deny (without having to worry that it will try to do more access checks that result in deny, which will call for a new context... etc). Patch by: Sverre Rabbelier

Bugfixes to last commit Access rights for 'home' pages and an errornous endif tag. Patch by: Sverre Rabbelier

Removed club property from club_admin model. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Generate proper html instead of having nested <td> tags Patch by: Sverre Rabbelier

Hook up the 'home' view for site and program Also point to it in the sidebar's "home" link. Patch by: Sverre Rabbelier

Generate the 'edit settings' link dynamically We used to point to '/site/edit', which is rather lame for a generic presence template (especially since site has it's own template). Patch by: Sverre Rabbelier

Create a new 'home' view for Presences This also restores the 'show' view for Presences as there is no need to hide it with the 'home' view anymore. Patch by: Sverre Rabbelier

Added the new way to process invites for club_admin only. This patch contains the separability needed to ensure that we can successfully do the access checks we need. Host invites can for the time being only be completed by developers due to the reorganization. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added missing comment to soc/views/models/club.py. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed the request templates to match the changes to the model. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added missing role_verbose. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Redid removeRequestForRole to completeRequestForRole. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added verbose role name to the request model. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added various access methods in preperation for the new request system. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added state property to role model. This can be used when for instance a member has been removed from a club or a when a program has been marked inactive. Certain roles would then be shown on the upcoming roles page marked as previous roles. This would give us the archiving capability that was shown in the mockup. Patch by: Lennard de Rijk Reviewd by: to-be-reviewed

Renamed org property in club_admin model to club. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Add slots and student applications/tasks limit integer properties to the Program model. Patch by: Pawel Solyga Review by: to-be-reviewed

Change build.sh to create a build/ output directory (rather than release/). Patch by: Todd Larsen Review by: to-be-reviewed

Move make_release.sh to build.sh. This script creates a "build" really, not a release. A separate release.sh script should be written to automate the current manual release process (at some point...). Patch by: Todd Larsen Review by: to-be-reviewed

Remove unused decorators import from soc.views.models.role module. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix idention in soc.views.models.club module. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix missing dots in soc.views.helper.decoratos module docstrings. Patch by: Pawel Solyga Review by: to-be-reviewed

Rename clean_existing_user_not_equal_to_current function to clean_users_not_same in soc.logic.cleaning module and fix affected files. Patch by: Pawel Solyga Review by: to-be-reviewed

Hide the 'link_id' field for site Also construct the scope_path from the fields in case the entity has not yet been created. Patch by: Sverre Rabbelier

Rename "site/settings" to "site" The "/site/settings" view is not about the Site Settings an sich, but more about the "site presence singleton". In this context it does not make sense to call it "site/settings". Patch by: Sverre Rabbelier

Fixed one style error and one typo. Patch by: Lennard de Rijk

Presence is now a 'abstract' View, pull in members from program This is signified by the removal of params['name'] and other values that are required by params.py, but also by the removal of the 'view' definition at the bottom of the file. Patch by: Sverre Rabbelier

Extend dicts.merge to be (optionally) recursive This is very useful when dealing for views that expect to be inhereted from but wish to provide default values. Patch by: Sverre Rabbelier

Fix form errors and hidden form errors The conversion to django left out the 'prettyfying' of form and hidden form errors, as these could occur when running live, restore this behavior. Patch by: Sverre Rabbelier

Added a cleaning method for a LinkProperty Field. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed wrong conditional in soc/views/models/club_app.py. Notifications will now be send again. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Fixed import sorting and indentation in soc/views/models/club.py Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Even developers need to agree to the terms of service for Melange Patch by: Sverre Rabbelier

Corrected the list index parameters in soc/views/models/club_app.py Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Added Ignored applications to the list view. Also restored the New Club notification upon application acceptance. That broke in r1483. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Replaced boolean properties in soc/models/group_app with status property. This property has 5 choices ['accepted','rejected','ignored','needs review','completed'] Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Move getToSLink() to soc.views.helper.redirects.getToSRedirect(). Fixes a circular import problem that prevented the site-wide ToS link from being displayed by checkAgreesToSiteToS(). This is now completely implemented. Patch by: Todd Larsen Review by: to-be-reviewed

Tighten more checkIsUser() access to checkAgreesToSiteToS() instead. Update the checkIsHost() comment. Patch by: Todd Larsen Review by: to-be-reviewed

Make checkAgreesToSiteToS() the default access check for many other checks. Replace checkIsUser() with the more-strict checkAgreesToSiteToS(). Also, add missing args and kwargs parameters to checkAgreesToSiteToS() that were missed in the merge right before commit. Patch by: Todd Larsen Review by: to-be-reviewed

Add checkAgreesToSiteToS() (partially implemented until circular import fixed). Need to fix a circular import problem before the alternate message will include a link to the site-wide ToS Document. Also, fixed the descriptions in the first few check...() functions. Patch by: Todd Larsen Review by: to-be-reviewed

Take advantage of new "from ... import ... as ..." rules in the style guide. Patch by: Todd Larsen Review by: to-be-reviewed

Added clean_existing_user_not_equal_to_current to clean the backup Administrator field in an application. Patch by: Lennard de Rijk Reviewed by: to-be-reviewed

Changed the redirect in club application overview to the correct page. Patch by: Lennard de Rijk

Changed checkIsClubAppAccepted into a more generic checkIsApplicationAccepted. Also fixed a minor bug in club_app view. Patch by: Lennard de Rijk

Changed the collection name and help text for Organization member template. Patch by: Lennard de Rijk

Added club_app model and logic. Patch by: Lennard de Rijk

Added created and last modified timestamps to the group_app model. Also edited the templates to show some extra information. The review template has the names for the new properties hard coded because the auto_add and auto_add_now datetimeproperties don't show up in the fields of the entity. Patch by: Lennard de Rijk

Fixed typo in r1446. Patch by: Todd Larsen Review by: to-be-reviewed

Changes in Role model. Clarified that we are asking for a shipping adress. Also moved Agrees to ToS to the bottom. Patch by: Lennard de Rijk

Fix trailing whitespace and apply decorators Patch by: Sverre Rabbelier

Fix whitespace damage Patch by: Sverre Rabbelier

Make use of the new decorators in all applicable views Patch by: Sverre Rabbelier

Renamed showReviewOverview to review_overview and reviewOverview Patch by: Sverre Rabbelier

Fixed two trivial bugs A "kwargs=kwargs" instead of **kwargs Missing 'and entity' check Patch by: Sverre Rabbelier

Added a merge_params and check_access decorator The merge_params decorator is very simple and takes self._params and merges it with params. It's main purpose is to explicitly mark the views in which it is intended that self._params is merged raw. The check_access decorator factors out the access checking process and passes args and kwargs to the access checking methods. Patch by: Sverre Rabbelier

Prepare access to receive args and kwargs as argument Also use two "magic values" when the sidebar is doing the access checks, this might be useful later. Patch by: Sverre Rabbelier

Reverted r1457. Patch by: Lennard de Rijk

Changed link in club_app accepted notification. Patch by: Lennard de Rijk

Added a new view to help with application -> group process. The applicant view is available only when there is an accepted application present. This will be checked by the access checker in an upcoming patch. The view uses a special form so that certain fields cannot be edited by the user. These fields correspond to important fields filled in during the application process. Create access for a club has now been set to Host level. Patch by: Lennard de Rijk

onCreate for a Club now marks any application for the same club as completed and invites the admins. This is useful for when the club has been created without using the application. Patch by: Lennard de Rijk

Edited the method used to clean link_id in params.py. Removed the clean_new_link_id from the logic/cleaning.py module because this is not used anymore. This method should be replaced by a method that is used after all the fields have been cleaned so that the actual key_name of an entity can be constructed. Patch by: Lennard de Rijk

Fixed a typo in the comments of soc/views/helper/forms.py Patch by: Lennard de Rijk

Fix missing import identified by pylint. ************* Module app.soc.logic.models.user E0602: 99:Logic.agreesToSiteToS: Undefined variable 'db' Patch by: Todd Larsen Review by: to-be-reviewed

Fix missing import identified by pylint. ************* Module app.soc.logic.models.presence E0602: 56:Logic.getToS: Undefined variable 'db' Patch by: Todd Larsen Review by: to-be-reviewed

Fix missing import identified by pylint. ************* Module app.soc.views.helper.responses E0602:187:getToSLink: Undefined variable 'db' Patch by: Todd Larsen Review by: to-be-reviewed

Add agreesToSiteToS() logic method to indicate if User accepts site-wide ToS. Patch by: Todd Larsen Review by: to-be-reviewed

Give error messages more room in the existing form field "as_table" templates. Patch by: Todd Larsen Review by: to-be-reviewed

Add a clean_agrees_to_tos() validator that requires "Yes" if ToS exists. Also, more user_logic.logic => user_logic fixes. If you are going to import "as", you might as well make the renaming worthwhile. Maybe we need to add a section on "import ... from ... as ..." in the style guide? Patch by: Todd Larsen Review by: to-be-reviewed

Change "Show" to "Export" missed in r1446 commit. Patch by: Todd Larsen Review by: to-be-reviewed

Add an export() view, and implement it as text/text for Document. For every Model except Document, the public() view is displayed for any attempts to access the export() view. Currently, the permissions for export() are the same as for public(). This seems reasonable for Document, since anyone could extract the raw HTML from the page source anyway. The permissions should probably be different for other types of exports, such as vCard or iCard exports of profiles, CSV exports of lists, etc. Patch by: Todd Larsen Review by: to-be-reviewed

If a site-wide ToS exist, display the User profile "Agrees to ToS" checkbox. Patch by: Todd Larsen Review by: to-be-reviewed

Set agrees_to_tos example text to link to site-wide ToS (or a warning message). Also, since a renaming import statement is being used already, change user_logic.logic to just user_logic. Patch by: Todd Larsen Review by: to-be-reviewed

Do not crash on *every* page load if there is no ToS Document. 'tos' ReferenceProperty might be present, but still be None. Patch by: Todd Larsen Review by: to-be-reviewed

A better way to add site-wide ToS link to *all* pages on the site. getUniversalContext() already fetches a copy of the Site settings, so use that to see if the site-wide ToS exist and produce a link. Patch by: Todd Larsen Review by: to-be-reviewed

Linux /bin/sh (GNU) is not the same as OS X /bin/sh (BSD), so use /bin/bash. Fixes: scripts/pylint/do_pylint.sh: 27: Syntax error: "(" unexpected on Ubuntu (and possibly other Linux distros). Patch by: Todd Larsen Review by: to-be-reviewed

Replace css class 'notice' that is used in User profile template field help text with new 'fieldhelptext' class. Notice is part of CSS for notification bar and we want width limit just for field help text not for notification bar text. Patch by: Pawel Solyga Review by: to-be-reviewed

Add getSingleton() method to return the Site settings entity. There is always only one Site entity, referred to by DEF_SITE_LINK_ID. Patch by: Todd Larsen Review by: to-be-reviewed

Return the ToS Document of the supplied Presence entity, if there is one. Patch by: Todd Larsen Review by: to-be-reviewed

Support HTML tags in form field example_text column. Improve the Program Model example_text as an example. Patch by: Todd Larsen Review by: to-be-reviewed

Disable R0801 messages in pylintrc. R0801 messages indicates that a set of similar lines has been detected among multiple file. This usually means that the code should be refactored to avoid this duplication but in our case it's useless since it shows a lot of imports code or authors. Patch by: Pawel Solyga Review by: to-be-reviewed

Add calendar widget support for timeline fields. Fix docstring typo in soc.views.models.timeline module. Add timeline edit template which loads necessary javascript files for datetimepicker widget. Patch by: Pawel Solyga Review by: to-be-reviewed

Remove member_template from extra_dynaexclude in soc.views.models.club since member_template is only available in Organization as of recent commit. Patch by: Pawel Solyga Review by: to-be-reviewed

Add the agrees_to_tos property to Roles (as its own changeset this time...). Patch by: Todd Larsen Review by: to-be-reviewed

Make getToSLink() an actual method for re-use by others. Uses the views.helper.redirects module to create the /document/show path, instead of hard-coding it as a format string. Patch by: Todd Larsen Review by: to-be-reviewed

Fixed EOL and whitespace damage Patch by: Sverre Rabbelier

This file should not have been included in r1428. Reverting... Patch by: Todd Larsen Review by: to-be-reviewed

Changing ReadOnlyBool to type "text" makes it display "True" or "False". Patch by: Todd Larsen Review by: to-be-reviewed

When constructing the sidebar don't overide 'sidebar' Instead specify 'sidebar_additional' and include it even if there is a 'sidebar' defined. Patch by: Sverre Rabbelier

Add datetimepicker javascript widget files and css file. Patch by: Pawel Solyga Review by: to-be-reviewed

Set notice width to 450px. It was way too long. Notice is displayed with help text on yellow background in User profile. Patch by: Pawel Solyga Review by: to-be-reviewed

Add missing blank line in soc.views.helper.params module. Fix docstring typo in soc.views.models.role module. Add missing dots at the end of sentences in soc.logic.cleaning and soc.view.models.user_self modules. Patch by: Pawel Solyga Review by: to-be-reviewed

Add missing 'of' word to list description strings in soc.views.models.club_app module. Patch by: Pawel Solyga Review by: to-be-reviewed

Add missing blank lines and dots in soc.views.helper.templatetags.forms_helpers module. Patch by: Pawel Solyga Review by: to-be-reviewed

Move member_template property from Group to Organization model since it's Organization specific property. Patch by: Pawel Solyga Review by: to-be-reviewed

Disable R0201 message in pylintrc since we allow for that kind of methods. R0201 tells us that method could be a function. Used when a method doesn't use its bound instance, and so could be written as a function. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix typo in settings.py (missing '>' character). Patch by: Pawel Solyga Review by: to-be-reviewed

Add missing dots in docstrings. Add sendNotification parameters description to docstring in soc.logic.helper module. Patch by: Pawel Solyga Review by: to-be-reviewed

Added missing import to views/models/notification.py Patch by: Lennard de Rijk

Users now have the right to delete their own notifications. Patch by: Lennard de Rijk

Load /Users/solydzajs/Downloads/google_appengine into trunk/thirdparty/google_appengine.

Split the notification list in read/unread Patch by: Sverre Rabbelier

Add an unread count indication next to the notification link Similar to how this is done in gmail. Patch by: Sverre Rabbelier

Use 'from .. import .. as ..' in user_self Patch by: Sverre Rabbelier

Fixed whitespace and EOL damage Patch by: Sverre Rabbelier

Add a 'pending/accepted/denied' seperation to club_app list This is not only to make it easier to see which applictions have been accepted, but also to make it possible to redirect to /club/create for the accepted applications, rather than to /club_app/edit. Patch by: Sverre Rabbelier

Fixed whitespace damage Patch by: Sverre Rabbelier

Send a notifcation if a club application is accepted Patch by: Sverre Rabbelier

Factor out sendNotification from sendInviteNotification This makes it easier to create different types of notifications, such as a sendNewClubNotification. Patch by: Sverre Rabbelier

Fixed whitespace and EOL damage Patch by: Sverre Rabbelier

Fixed whitespace damage Patch by: Sverre Rabbelier

Added club_admin templates. Patch by: Lennard de Rijk

Added Mario Ferraro to the AUTHORS list. Patch by: Lennard de Rijk

Tooltips now properly disappear when another text box with a tooltip has been highlighted. Also known as Issue 132. Patch by: Mario Ferraro Reviewed by: Lennard de Rijk

Implement the checkIsClubAppAccepted function Also added a stub for checkIsClubAdminForClub. Patch by: Sverre Rabbelier

Display state (but dis-allow edits) of User's agrees_to_tos boolean Property. Patch by: Todd Larsen Review by: to-be-reviewed

Add read-only boolean form field widget. Developers should be able to view, but not change, the User's agrees_to_tos state. Patch by: Todd Larsen Review by: to-be-reviewed

Add "agrees to site-wide Terms of Service" boolean property for all Users. Patch by: Todd Larsen Review by: to-be-reviewed

Hide 'tos' pull-down selector from Program profile forms. Until a way to select Documents for use as the Terms of Service for a Program exists (see http://code.google.com/p/soc/issues/detail?id=151), there is no point in hacking in scope_path and link_id fields here. The per-Program ToS feature will just be unavailable until an appropriate Document selector exists. Patch by: Todd Larsen Review by: to-be-reviewed

Hide 'tos' pull-down selector from Group profile forms. Until a way to select Documents for use as the Terms of Service for a Group exist (see http://code.google.com/p/soc/issues/detail?id=151), there is no point in hacking in scope_path and link_id fields here. The per-Group ToS feature will just be unavailable until an appropriate Document selector exists. Patch by: Todd Larsen Review by: to-be-reviewed

Hide 'tos' pull-down selector from Site Settings forms. Patch by: Todd Larsen Review by: to-be-reviewed

Hack in tos_scope_path and tos_link_id to select Terms of Service Document. Patch by: Todd Larsen Review by: to-be-reviewed

Show Terms of Service link in footer if tos_link is defined in the context. Patch by: Todd Larsen Review by: to-be-reviewed

Add a ReferenceProperty pointing to a Terms of Service Document. Patch by: Todd Larsen Review by: to-be-reviewed

Fixed a bug that was triggered on manual club creation without an application. Now also sets the application_completed flag upon club creation. Patch by: Lennard de Rijk

Fixed missing params in views/models/club_app.py. Patch by: Lennard de Rijk

Added Club Admin model, logic, and view Patch by: Sverre Rabbelier

Invite (backup-)admin when creating a club Patch by: Sverre Rabbelier

Added a create method that uses an existing application Patch by: Sverre Rabbelier

Construct names automatically from base name. Saves a lot of typing for the common case Patch by: Sverre Rabbelier

Fixed a wrong method being called when accepting/declyning an application. Patch by: Lennard de Rijk

Added basic review functionality for club applications. The access rights are open for discussion. The review page uses GET data to determine the decision made by the user. For convenience the Review Club Applications button directs you to a multi-list view so you can see the state of different applications. The review state will reset whenever the application has been changed using the edit form. Patch by: Lennard de Rijk

Fixed a typo in the comment in helper/access.py. Patch by: Lennard de Rijk

Added control fields to group_app. Moved unnecessary fields containing questions about past participation from group_app to org_app. Updated the club_app public page to show the correct information using twoline layout. Patch by: Lennard de Rijk

Added _readonly_field_as_twoline_table_row . Patch by: Lennard de Rijk

Resolved a bug when editing a timeline. Scope path is now set correctly when editing a timeline. Patch by: Lennard de Rijk

Fixed line-ending and whitespace damage Patch by: Sverre Rabbelier

Added the club_app view, logic and model Patch by: Sverre Rabbelier

Removed unneeded params from club Patch by: Sverre Rabbelier

Moved the member_template field to app and removed 'optional' Also shortened the verbose_name of the member_template field. Patch by: Sverre Rabbelier

Factored out the clean_existing_user method Patch by: Sverre Rabbelier

Fix login link Without the leading slash the link does not work on appspot. Patch by: Sverre Rabbelier

Fixed a typo in the group_app model Patch by: Sverre Rabbelier

Added a twoline_edit.html page An as_twoline_edit template tag was added for this purpose. This tag renders the label field on a seperate line. Patch by: Sverre Rabbelier

Fix missing dots at the end of sentences in docstring and fix wrong import sorting in soc.logic.helper.notifications module. Patch by: Pawel Solyga Review by: to-be-reviewed

Extract BSD license text into a separate file to make it easier to find. Patch by: Todd Larsen Review by: to-be-reviewed

Fixed missing files in r1364. Patch by: Lennard de Rijk

Fix the setup of the test environment, including clearing the datastore between tests.

Add support for coverage to our testing system.

Added support for creating clubs. Patch by : Lennard de Rijk

Added support for mutliple edit forms based on entity type This makes it possible to have different edit forms in timeline based on which workflow type is used. Patch by: Sverre Rabbelier

Added an 'edit timeline' button to the program edit page Also made the create timeline functionality use the logic modules introduced in the previous commit. Patch by: Sverre Rabbelier

Started on edit timeline Added a gsoc timeline logic module. Also added a scope_path as the key_field to timeline. Updated the django_paterns to only include the edit field and removed link_id as dynafield. Patch by: Sverre Rabbelier

Fixed missing import in soc/models/organization.py. Patch by: Lennard de Rijk

Add hard-coded GroupApplication and OrgApplication Models. These are being hard-coded because the "real" Question/Answer/Quiz/Response implementation will not be ready any time soon. Patch by: Todd Larsen Review by: to-be-reviewed

Mailing list EmailProperty should be StringProperty instead, so that it is possible, for example, to supply a Google Group URL for sign-up purposes. Patch by: Todd Larsen Review by: to-be-reviewed

Add IRC channel and mailing list properties to the Group and Organization Models. Patch by: Todd Larsen Review by: to-be-reviewed

Typo and style fixes. Patch by: Pawel Solyga and Lennard de Rijk

Fixed a bug where a new timeline would get created on every edit of an existing program. Patch by: Lennard de Rijk

Added an elementary workflow choosing method to program creation. Patch by: Lennard de Rijk

Added logic and view classes for the Timeline model Patch by: Sverre Rabbelier

Sorted build.py's sitemap.addPages lines Patch by: Sverre Rabbelier

Made Program reference Timeline Also made Timeline inherit from base like it should. Patch by: Sverre Rabbelier

Copy/paste fix Typo fix: s/founder/program Patch by: Sverre Rabbelier

Added a basic Timeline model The timeline model will contain the deadlines and time ranges for the individual programs. Patch by: Sverre Rabbelier

Set no_create_with_key_fields paramater to True for Notifications. Patch by: Lennard de Rijk

Revert "Overwrite default patterns in views/models/notification.py to disallow certain URL's." This should instead be done by setting the no_create_with_key_fields parameter to True. Patch by: Sverre Rabbelier

Allow disabling of the create url with key_fields Patch by: Sverre Rabbelier

Overwrite default patterns in views/models/notification.py to disallow certain URL's. Patch by: Lennard de Rijk

Fixed a too long line in logic/helper/notifications.py Patch by: Lennard de Rijk

Added base template for notification messages. This makes the messages a bit more friendly by including a greeting and signature. Patch by: Lennard de Rijk

Added email message when receiving a notification.py At the moment this only triggers when the new notification is your first unread message. Also fixed an url bug in the invite notification. Patch by: Lennard de Rijk

Changed invitation email and into a notification. Also changed the public template for Notification to allow HTML code. Patch by: Lennard de Rijk

Remove unused imports and variables in different soc.views.models modules. Patch by: Pawel Solyga

Remove unused import in soc.views.hlper.templatetags.forms_helpers module. Patch by: Pawel Solyga

Since DbModelForm has been renamed to BaseForm change super() call from BaseForm to djangoforms.ModelForm in soc.views.helper.forms module. Patch by: Pawel Solyga

Some docstring fixes and unused import removal in soc.logic.models.site module. Patch by: Pawel Solyga

Fix inheritance in soc.models.base module. FieldsProxy inherited from DbModelForm which was deleted in previous commits (replace that with BaseForm). Patch by: Pawel Solyga

Fix too long lines in soc.logic.helper.notifications module. Patch by: Pawel Solyga

Remove unused import in soc.logic.accounts module. Patch by: Pawel Solyga

Remove unused imports in models modules. Patch by: Pawel Solyga

In soc.views.models.notification module remove unused imports, add missing white space, change list() method definition to comply with base View list() method declaration. Add missing Meta class docstring. Patch by: Pawel Solyga

Fix import sorting in soc.views.helper.access module and rename 'host' to 'Program Administrator'. Patch by: Pawel Solyga

Remove not used TYPE_NAME, TYPE_NAME_SHORT and TYPE_NAME_PLURAL consts in all Group models. Patch by: Pawel Solyga

Add missing dots, fix imports sorting and too long lines in different modules. Add TODO in soc.views.models.host module. Patch by: Pawel Solyga

Have user/edit.html use the as_table tag as well Patch by: Sverre Rabbelier

Removed unused template Patch by: Sverre Rabbelier

Converted as_table to be a template tag This allows us to move all the HTML from python code (which made it extremely icky and unreadable) to Django templates, which is _a lot_ more readable, and makes it feasable for HTML/CSS experts to change the way these tables are generated. Patch by: Sverre Rabbelier

Added some example_text to program Patch by: Sverre Rabbelier

Added support for example texts Initial patch by Benjamin, some minor fixes by Sverre. Patch by: Benjamin Lyaunzbe, Sverre Rabbelier

Brown-paper-bag fix in notification.py Was missing a leading slash in the redirect. Patch by: Sverre Rabbelier

Notification property has_been_read changed into unread Due to comments on r1309. Patch By: Lennard de Rijk

No override needed in notifications.py The only downside is that the ?s=0 parameter will still be appended but is not handled in list(). The right solution would be to update list() so that it does say "Message Sent" or such, to give the user an indication that their message was sent succesfully. Patch by: Sverre Rabbelier

Make it possible to redirect anywhere after editPost This makes it possible to not include the suffix in the redirect by making it a named parameter. Patch by: Sverre Rabbelier

Make the place of the rights declaration consistent Other code places it at the top, so we should do that in notification as well. Patch by: Sverre Rabbelier

Remove custom override of django_patterns_defaults Instead restrict access to the edit method, also, there is no need to set the default access to allow. Patch by: Sverre Rabbelier

Fix whitespace and EOL damage in notifcation.py Patch by: Sverre Rabbelier

Make use of readonly_field_as_table_row Instead of manually typing out the <br /> etc. Patch by: Sverre Rabbelier

Fix EOL-damage We use \n for line endings, so remove the \r from public.html Patch by: Sverre Rabbelier

Make checkIsMyInvitation use Django to parse the URL Using django is more reliable and makes the code easier to read as there is no knowledge of the url layout required. Patch by: Sverre Rabbelier

Added a readonly_multiline_field_as_table_row tag This is useful when a field is allowed to include newlines. Patch by: Sverre Rabbelier

Using getForCurrentAccount where possible due to comments on r1309. Patch by: Lennard de Rijk

Added Notifications. Notifications will primarily be used to serve the user information message like "New Request Pending". The system can be expanded later on to a messaging system. If you are a developer you can create message by going to notification/create . This has been done so the system can easily be tested. But will of course be visible in an easy-to-access location when the transition to a message system has been made. Patch by: Lennard de Rijk

Filter the "list Hosts" view This way only those Hosts are shown that belong to a Sponsor the user is a host for. Patch by: Sverre Rabbelier

Allows a user object to be passed to accounts.isDeveloper This saves a trip to the database if the user object has already been retrieved. Patch by: Sverre Rabbelier

Make getForFields use the db.Query API While at it, add support for the IN statement in the form of a value of the list type. Patch by: Sverre Rabbelier

Added getForCurrentAccount to user.Logic It returns the user entity associated with the currently logged in user. Patch by: Sverre Rabbelier

Added a filter method to dicts The best way to explain this is probably with an example: >>> split({'foo':'bar', 'bar':['one', 'two'], 'baz': ['three', 'four']}) [{'bar': 'one', 'foo': 'bar', 'baz': 'three'}, {'bar': 'two', 'foo': 'bar', 'baz': 'three'}, {'bar': 'one', 'foo': 'bar', 'baz': 'four'}, {'bar': 'two', 'foo': 'bar', 'baz': 'four'}] Patch by: Sverre Rabbelier

Make it possible to invite another Host as Host We do this by asking Django to resolve the current url for us, then reshufle that url and ask Django (again) to resolve that new url. From that resolved url we know the appropriate view, and as such we know which rights dictioanry to pass to access.checkAccess. Patch by: Sverre Rabbelier

Added a trivial unzip method, counterpart to zip Patch by: Sverre Rabbelier

Add some ignore properties for when we get working coverage support.

Fixed missing header in site settings. Also known as Issue 146. Patch by: Lennard de Rijk

Changed "Sponsor" to "Program Owner" Changed "Host" to "Program Administrator" Patch by: Lennard de Rijk

Adds the removal of requests from the datastore when a new role entity is created. This uses the classname from the role entity as the type of role in the request. Patch by: Lennard de Rijk

Add missing dots in docstrings, proper sorting of imports and small docstring typo fixes. Patch by: Pawel Solyga

Thinkofix in access.checkIsInvited Patch by: Sverre Rabbelier

Some forgotten changes with the access_type commit Patch by: Sverre Rabbelier

Program Name column showed link_id instead of name, replace link_id with name in soc/program/list/row.html template. Patch by: Pawel Solyga

Add explicit access_types from the url This does two things, it reduces the amount of repeated data (e.g., the checkAccess used to repeat the access_type that was already specified in the url). At the same time, it allows for example the 'create' page to push its access_type to 'edit'. Patch by: Sverre Rabbelier

Add checkIsHost in access Patch by: Sverre Rabbelier

Some cleanups in role.py and site.py and create() Patch by: Sverre Rabbelier

Changed template for home/public.html to show last modified in the top-right corner. Patch by: Lennard de Rijk

Add site scoped documents to the Site menu This allows for featured documents that belong to the Site scope to show up in the 'Site' menu. Patch by: Sverre Rabbelier

Move document sidebar entries extraction to document.View This way other modules can benefit from the same logic. Also make use of the sidebar.getSidebarMenu method so that getMenusForScope is no longer specific to full menu's. Patch by: Sverre Rabbelier

Factor out sidebar entry construction This makes it possible to reuse this logic in other modules as well, preventing code duplication. While at it, move additional_sidebar merging before the other entries (additional entries should go first, since the other entries are mostly dev-only etc). Patch by: Sverre Rabbelier

Rename getSidebarLinks to getSidebarMenus Patch by: Sverre Rabbelier

Remove bogus scope from Site This makes Site an unscoped entity (similar to how User and Sponsor do not have a scope). Patch by: Sverre Rabbelier

If an entity is unscoped, do not try to retrieve a scope Patch by: Sverre Rabbelier

Dynamically add sidebar items for programs This adds sidebar items for programs as appropriate. From the docstring: A menu item is generated for each program that is currently running. The public page for each program is added as menu item, as well as all public documents for that program. Additionally, we allow access to a program's public page to everyone, even if the user is not logged in. Patch by: Sverre Rabbelier

Add and use a placeholder for checkIsDocumentPublic We should somehow decide whether a document is publically viewable. This should of course be dependant on what the document is, e.g. the FAQ of a program should be allow(), whereas a student's application should be checkIsMentor(). Patch by: Sverre Rabbelier

Added a public redirect Also some minor cleanups in the redirects code. Patch by: Sverre Rabbelier

Prepare for callbacks that return more than one menu This paves the way for callbacks that dynamically construct their menu based on in-db content, such as Programs and Documents. Patch by: Sverre Rabbelier

Make use of the 'sidebar' param for user_self Instead of overriding getSidebarLinks we use the sidebar param since user_self is now in it's own View. Patch by: Sverre Rabbelier

Fixed email adress in urls.py. Patch by: Lennard de Rijk

Fixes 'module' object has no attribute 'handler500' and 404 on instances where debug is False. Patch by: Lennard de Rijk

Fixed the header on the List Programs page. Patch by: Lennard de Rijk

Reset the RELEASE_TAG to None (unreleased) now that the 0.1a20081206 release candidate branch has been created. Patch by: Pawel Solyga

Set RELEASE_TAG to 0.1a20081206rc for release candidate 06/12/2008. Patch by: Pawel Solyga

Fix imports sorting in soc.views.models.organization. Patch by: Pawel Solyga

Add missing dots in docstrings in modules. Patch by: Pawel Solyga

Changed generic_name to group_label in models/program.py. Also I've updated the comments and help text to explain the meaning of this field. Patch by: Lennard de Rijk

Updated to the latest version of upload.py Patch by: Sverre Rabbelier

Load ../../google_appengine_1.1.7/ into trunk/thirdparty/google_appengine.

Comment fixes for state in group and role model. Patch by: Lennard de Rijk

Fix for randomely ocurring bug The bug and it's fix are described by the first comment from Guido in http://code.google.com/p/googleappengine/issues/detail?id=772. Patch by: Guido van Rossum

Changed state property for models/group.py to be optional as the description states. Patch by: Lennard de Rijk

Added organizations Really basic for now, next stop is to have a proper document selector for the Presences. Patch by: Sverre Rabbelier

Cleanups in group and program The missing super call in group prevented the scope from being set as it should be. Patch by: Sverre Rabbelier

Added a new create regexp in urls for just scope_path Now that scope_path is properly defined we can add a url matching just the scope path. This allows some other custom create regexps to be removed/rewritten. Note: It needs to be -after- the full key_name regexp, since for arbitrarily nested scopes it would always match as just scope_path, even if there are other fields needed after the scope. Patch by: Sverre Rabbelier

Introduce dynamic scope_path regexps Instead of relying on scope_path's being "one slash deep", we should instead allow for either: 1. scope_paths that have a pre-defined depth 2. scope_paths that can be arbitrarily deep We achieve 1 by setting an entities scope_logic to another logic module. We then recursively call getScopeDepth until we get to the topmost entity (that is, an unscoped entity). A little different is the solution to 2, since some entities can have an arbitrarily deep scope (such as Documents), we need to have some way of signaling this to getScopePattern. A clean solution is to return None, rather than a number. If None is returned, the SCOPE_PATH_ARG_PATTERN is returned as regexp instead, which will match an arbitrarily deeply nested scope. The solution for 2 requires that we return None somewhere in the scope_logic chain, the most straight forward method to do so is to override getScopeDepth anywhere such a scope is needed and make it return None. A more elegant solution however, is to set the scope_logic to that module in all entities that require it. Patch by: Sverre Rabbelier

Added a linkable logic module The linkable logic module is used to signal the fact that the scope of an entity can be any linkable. Patch by: Sverre Rabbelier

Fix scope lookup for unscoped entities As scope_logic is now always set (since r1250), we need to check if it is None, rather than check if it exists. Patch by: Sverre Rabbelier

Swap the order of request key fields This will make it easier to remove scope_path as explicit key field at some point by having it as inplicit key field for all entities. Patch by: Sverre Rabbelier

Use key().name() instead of link_id This is now possible because key_name is constructed purely from the key fields of an entity. It is not sufficient to use just link_id, that works only for single-scoped entities (e.g., those that either do not have a scope, or that have a scope which itself does not have a scope). It would break if there was an entity that has a scoped scope (it would only include the scope's link_id in the url, which made it impossible to look up the scope as we missed the link_id of the scope's scope). Patch by: Sverre Rabbelier

More DI on scope_logic Patch by: Sverre Rabbelier

Partial revert Last commit contained some changes that did not belong there, revert them for now. Patch by: Sverre Rabbelier

Some more cleanups in base.Logic Patch by: Sverre Rabbelier

Apply DI on the scope logic Patch by: Sverre Rabbelier

Removed unused file path_link_name Patch by: Sverre Rabbelier

Remove unneeded method getSuffixValues Patch by: Sverre Rabbelier

Some style and typo fixes in different modules. Patch by: Pawel Solyga

Some more import sorting fixes and docstring typos in program modules and soc.views.helper.redirects module. Patch by: Pawel Solyga

Fix import sorting and docstring typos in soc.views.models.program module. Patch by: Pawel Solyga

Fix import sorting in soc.views.sitemap.build module. Patch by: Pawel Solyga

Some style fixes in soc.logic.helper.notifications module. Little changes in welcome.html template. Patch by: Pawel Solyga

Make base.View.create lookup the scope if appropriate Also re-introduce the custom description of the list selection for the redirection. Patch by: Sverre Rabbelier

Make use of the new generic key_name by lookup up scope_path This way base classes do not have to look up the 'scope' property, instead they can rely on the base class to do it for them provided they define the 'scope_logic' param. Patch by: Sverre Rabbelier

Change the key name to not include entity type This allows for direct lookup by scope_path, rather than having to do more complex things. Patch by: Sverre Rabbelier

Introduced django_extra_patterns This way no classes ever need to override the getDjangoURLPatterns, which results in less code, which is also more clear (that is, it is immediately obvious that a View adds an extra mapping if it sets the new django_extra_patterns value, or that it overrides the mapping when it sets django_patterns_defaults. Patch by: Sverre Rabbelier

Make scope_path required for program Patch by: Sverre Rabbelier

Factor out the Group part of Sponsor This makes it possible to reuse the Group logic. Patch by: Sverre Rabbelier

Rename role.RoleView to role.View Patch by: Sverre Rabbelier

Cleanups in the views module Mainly rename from original_params to new_params (so that the keyword argument in the __init__ method is the same for all). Also use super(View, self) where appropriate. Patch by: Sverre Rabbelier

Cleanups to the logic module Mainly converting to super(Logic, self) and adding some missing empty lines while at it. Patch by: Sverre Rabbelier

Fixed the 'New Host' link Also removed the 'Invite Host' button from the Sponsor view now that the link is working. Patch by: Sverre Rabbelier

Make the 'select entity' View generic This allows the selection of any entity from an arbitrary View by specifying the 'target view' and the redirect function. Patch by: Sverre Rabbelier

Cleanups in preparation of general selector view Renamed LIST... to DEF_LIST since it is a global definition. Renamed getCreateProgramRedirect to getCreateRedirect since it will work on all entities as it uses params. Added a getParams method to base.View Updated selectSponsor as appropriate. Patch by: Sverre Rabbelier

Remove the logic parameter from getListContent Now that params always has a 'logic' attribute, we can use that instead of requiring that it is passed as argument. Patch by: Sverre Rabbelier

Changed clean_link_id to convert the input to lower characters for user comfort. It has been changed in a couple of files, most importantly in logic/cleaning.py wich will be used by future forms to do their cleaning. Patch by: Lennard de Rijk

Finish Program Added some fields, and made TinyMCE the editor for the description field. Also updated the public page to show these new fields. We really need generic public views... Patch by: Sverre Rabbelier

Brown paperbag fix in recent cycle breaking Self is no longer used, 'error' should be used instead. Patch by: Sverre Rabbelier

Swap order of merged params to fix sponsor select view The sponsor select view (in 'create new program') was showing the wrong information (and also using the wrong list template) because the order in which the params were merged was wrong way around. This fixes that and at the same time fixes the 'instruction_text' attribute, which should be named 'list_description' instead. At the same time we lookup and set Sponsor as the scope of the newly created program. Patch by: Sverre Rabbelier

Remove cyclic imports by moving response method of out_of_band.Error class to soc.views.helper.responses module as errorResponse function. Apply changes to affected files. Patch by: Pawel Solyga

Remov unused import from Quiz model and add missing blank line. Patch by: Pawel Solyga

Remove Great Britain from country list. Great Britain was included as a country, although it has a country code (.gb) it's not a state. United Kingdom is correct and remains in the list. Patch by: Matthew Wilkes Review by: Pawel Solyga

Added programs Currently the programs are somewhat of empty, but due to the ease with which we can add new fields later, it is acceptable to commit it in it's current form. Patch by: Sverre Rabbelier

Allow for extra dynamic fields for the create form Also some minor cleanups, such as making base.Logic inherit from object, as per the style guide. Patch by: Sverre Rabbelier

Fixed a styling error. Patch by: Lennard de Rijk

Added User welcome message. Added templates/soc/mail/welcome.html as a template for the message. Also fixed a cyclic import that was about to happen in notifications.py.

Some docstring fixes in few modules (soc.views.helper soc.views.models.base). Patch by: Pawel Solyga

Add missing dot and correctly sort imports in soc.logic.helper.notifications module. Patch by: Pawel Solyga

Some docstring and missing blank lines fixes in soc.views.sitemap modules. Patch by: Pawel Solyga

Sponsor name now shows in List Hosts. Patch by: Lennard de Rijk

Moved sendInviteMessage to a new module in logic/helper/notifications.py. Renamed sendInviteMessage to sendInviteNotification. Removed the now obsolete imports in logic/models/request.py. This has been done to keep the models/logic modules clean.

Changed email address in logic/models/base.py. Patch by: Lennard de Rijk

Allow developers access to anything that does a checkIsInvited. Patch by: Lennard de Rijk

Remove unused imports from some modules. Patch by: Pawel Solyga

Fix typo and too long lines in soc.logic.models.request module. Patch by: Pawel Solyga

Add missing import, remove unused import and add missing parameters to methods in soc.views.models.user_self module. Patch by: Pawel Solyga

Add missing dots and fix too long line in soc.views.helper.dynaform module. Remove unused imports in soc.views.models.document module. Fix too long lines. Add missing docstring for Meta classes. Patch by: Pawel Solyga

Add module docstring and license for soc, soc.models, soc.views.helper.templatetags. Patch by: Pawel Solyga

Remove python-graph from thirdparty, remove check_includes script and graph folder from scripts. This functionality is (cyclic imports check) is supported by pylint automatically so we don't need that any more. Patch by: Pawel Solyga Review by: Sverre Rabbelier

Fix too long lines in soc.views.models.request, remove unused imports and change pending requests list description. Remove unused imports from soc.logic.path_link_name module. Patch by: Pawel Solyga

Add missing dots in soc.logic.lists module. Change method names to comply with Style Guide. Make class variable protected by adding "_" to the name of variable. Update lists templates respectively (methods name change). Patch by: Pawel Solyga

Remove unused imports in soc.views.models role, host and site modules. Add missing parameter in getDjangoURLPatters method. Patch by: Pawel Solyga

Remove unused imports in soc.views.models.user and soc.views.models.sponsor modules. Patch by: Pawel Solyga

Remove unused import in soc.models.task. Patch by: Pawel Solyga

Fix too long lines in soc.model.work. Patch by: Pawel Solyga

Put the redirects in the views/helper/redirects.py module. Changed the getCreateRequestRedirect to comply with the new signature. Also changed it's docstring to a more suitable one. Fixed a useless merge in views/models/role.py in the process.

Style fixes for previous commit We also need to run pylint. Patch by: Sverre Rabbelier

Added invitation received message upon creating a new invite. Moved the inviteAcceptedRedirect into the logic code. Added a TODO for further user notification upon creating a request. Patch by: Lennard de Rijk

Now invited users can create a new Host profile Before the invited user had to be a developer for this to work. Now, instead the default checkIsDeveloper check for the 'edit Host', a custom checkIsInvite check is used. Patch by: Sverre Rabbelier

Fixed requests not working anymore We really need a test suite. Patch by: Sverre Rabbelier

Fixed a bug in latest commit Patch by: Sverre Rabbelier

Moved getSidebarLinks to sitemap.sidebar This is the fourth, and final patch, that attempts to improve the cohesion in the base.View class. Patch by: Sverre Rabbelier

Moved getDjangoURLPatterns to sitemap.sitemap Third commit in a series that aims to improve the cohesion in the base.View class. Patch by: Sverre Rabbelier

Moved checkAccess and getCleanedFields into access and forms A second patch in an effort to increase the cohesion in the base.View class. Patch by: Sverre Rabbelier

Move parameter construction into a seperate module This is part of an effort to make base.py less bloated and have it's methods be more cohesive. Patch by: Sverre Rabbelier

Documented params usage in soc/views/models/base.py Patch by: Sverre Rabbelier

Fixed AUTHORS to comply with the specified format Patch by: Lennard de Rijk

Added _onCreate _onUpdate and _onDelete methods to logic/models/base.py. These methods can be overwritten by other logic/models/ modules to serve as a way to for instance send out an update message. Patch by: Lennard de Rijk

Fixed typo in docstring. Patch by: Lennard de Rijk

Make forms generic Currently only Sponsor uses the new generic forms, as such this makes the form code more complex. The other forms, however, can be converted in a similar way, which will result in a lot of code reduction. Patch by: Sverre Rabbelier

Made _logic a param The _logic parameter is added in base.py to make this as small and non-intrustive change. Patch by: Sverre Rabbelier

Added Lennard to the AUTHORS file Long overdue patch, perhaps we should add a test to the test suite to check if all authors are propertly credited in AUTHORS... Patch by: Sverre Rabbelier

Make Sponsor use the new DynaForm module Currently only a slight reduction in code, but hopefully some (or all?) of the form's definition can move up into base.View. Patch by: Sverre Rabbelier

Added a DynaForm module This allows GAE forms to be defined 'semi' dymamically, rather than by having to explicitly create the new class. Patch by: Sverre Rabbelier

Added a cleaning module This module is the start of a (hopefully more generic) set of cleaning functions that can be used in the GAE forms. Patch by: Sverre Rabbelier

Apache license and __author__ added. Also added a todo for the __doc__ string. Patch by: Lennard de Rijk

Moved check_includes and graph from app to scripts Patch by: Sverre Rabbelier

Change command parsing and do file walking manually Also print warnings to stderr Patch by: Sverre Rabbelier

Proper working implementation of a cycle detection algorithm, that returns the cycles (rather than printing them) by constructing the path between the two nodes that were found to be cyclic. Patch by: Sverre Rabbelier

Fix some typo in logic.models.base. Patch by: Pawel Solyga

Added rudementry include checker Patch by: Sverre Rabbelier

Added the python-graph module http://code.google.com/p/python-graph/ Patch by: Sverre Rabbelier

Removed cruft from the tests directory The current tests were outdated (they tested code that no longer exists), and were causing the test suite (insofar as it deserves that name) to fail for no reason. Patch by: Sverre Rabbelier

Fixed an outstanding TODO for tlarsen A nice side-effect is that accounts now does not depend on out_of_band, sadly that does not fix the cyclic dependency, but it is a nice side-effect nonetheless.

Lists now use plural_name instead of name in the description. Patch by: Lennard de Rijk

Created a seperate module for editSelf things This improves the coherency in the user module, while at the same time making it easier to set proper access control for the editSelf related pages. Patch by: Sverre Rabbelier

Fixes empty spaces appearing in the menu if a person is not allowed to see this menu or if no menu is defined. Patch by: Lennard de Rijk

Fixes an error that occurs when moving the document by setting another link ID or Scope path. This is due to the fact that author is a required property in the Work model. Patch by: Lennard de Rijk

Fixed some access related bugs These were not obvious previously, but with the sidebar not showing up when one does not have access, they stood out.

Make the sidebar dynamic depending on the user's rights This is done by doing the usual access checks that are also called when the user actually visits the page.

Have the sidebar be rebuilt on every request with callbacks This makes is possible for the sidebar constructing to take into account the current users privilidges etc.

Adds and uses a modified_by property in models/work.py This property is used to display the user who last edited the work in the document viewer. Fixes author being set on every edit. Also edited the style-sheet to fix issue i128. Patch by: Lennard de Rijk

Fills in the Founded By box in edit sponsor with the user's public name Fixes Founded By being overwritten on edit by another user. Patch by: Lennard de Rijk

Set trunk RELEASE_TAG back to None after creation of 0.0a20081123rc release candidate branch. Patch by: Todd Larsen

Attempt number two at a release process, with correct usage of /tags/ this time around. Patch by: Todd Larsen

Reset the RELEASE_TAG to None (unreleased) now that the 0.0a20081123 release tag has been created. Add some release instructions to the soc/release.py __doc__ string. Patch by: Todd Larsen

Display '(unreleased)' as a link to trunk/ when RELEASE_TAG is false. Patch by: Todd Larsen

Add release tag string, Melange "badge" image, and Google App Engine version to base.html template. Patch by: Todd Larsen

Provide a simple method in the Role Model class that aliases the existing 'display_name' Property to 'name'. Patch by: Todd Larsen

Fixed spurious 'Invite Host' button in 'create host' Patch by: Sverre Rabbelier

Fix Host invites This fixes the UI for Host invites by hiding the fields that are not used, and by auto-filling in the user and scope fields based on link_id and scope_path.

Fixed pages for missing home page (document) links Patch by: Sverre Rabbelier

Moved the custom error.html page for Site to it's proper place Also made the error template a proper parameter instead of re-using the edit/public template.

Made list pagination part of Lists This way the pagination for one list does not affect the pagination of a another one. Patch by: Sverre Rabbelier

Remove polymodel module from repository. Patch by: Pawel Solyga, Sverre Rabbelier

Remove polymodel folder from DEFAULT_APP_DIRS variable in make_release script. Patch by: Pawel Solyga, Sverre Rabbelier

Remove inheritance_line from Form meta class excludes in all currently used forms. Patch by: Pawel Solyga, Sverre Rabbelier

Remove inheritance from PolyModel in Answer and Linkable model. Replace PolyModel inheritance with base.ModelWithFieldAttributes. A little explanation why we are trying to get rid of PolyModel. We decided to use PolyModel in order to get support for model inheritance in App Engine, however as we know this was a hacky workaround which added inheritance_line property to each model. Recent commits which added Linkable model caused our data viewer in admin console to show only one model "Linkable" since all of the classes inherited from it. Basically datastore viewer was useless plus we had a really big mess in datastore since everything was of one kind (Linkable). It's almost like creating one huge table in SQL database. Upcoming commits will eliminate all usage of PolyModel and finally remove PolyModel from our repository. We are still using inheritance however this doesn't modify how models are saved in data store so basically it's like copy and paste of properties from parent models. Patch by: Pawel Solyga, Sverre Rabbelier

Add customized User Edit Developer view template with working listing of former accounts. Patch by: Pawel Solyga

Disabled 'Home Settings' menu until we have a use for it Also fixed a typo in the request row template that caused it to display the wrong value. Patch by: Sverre Rabbelier

Removed no-longer used code This code is no longer in use and has been replaced by getForFields and similar methods.

Hide the 'home' field until we have a proper document selector Rather than having a confusing 'home' field that lists all Linkables (in other words, everything in the database), we're better off hiding it for now.

Fixed redirects to work consistently Revision 1133 broke 'Edit Site Settings' by relying on the fact that the url for create pages is '<entity>/create', which it is not for 'Edit Site Settings'.

Made Request use the new link_id and scope_path This cleans a lot of weird user interface badness and demonstrates how Linkable can be used.

Added a requests overview using the new multi-list page. Renamed the roles page to Requests Overview. Patch by: Lennard de Rijk

Requests are almost working now You can accept a request by clicking on it in the roles view. Patch by: Sverre Rabbelier

Fix names of methods in soc.views.model.site. Patch by: Pawel Solyga

Fix wrong comment format in request.py. Patch by: Pawel Solyga

Added missing import Patch by: Lennard de Rijk

Refactor requestSelf to be make use of the new split Patch by: Sverre Rabbelier

Split the list view code up in three pieces 1. getListContents which returns the required contents dictionary 2. _list which returns the response for a specified list of contents 3. list which constructs just one content dict and passes it to _list This way it is easier to do step 1 and 2 in other code than list(), which makes it possible to display multiple list pages (by calling getListContents multiple times and passing the result to _list).

Renamed templates/soc/entity/list/entity_*.html to *.html This makes it possible to generalize list template positions. Patch by: Sverre Rabbelier

Make redirect generic using the new Lists object This makes it possible (and easier) to have the list view redirect to any page specially tailored to the current item. Patch by: Sverre Rabbelier

Fixed the description on the user's role page. This broke in r1111. The new lists also removed the need for instruction_text in models/base.py. Removed an obsolete assignment in models/request.py Patch by: Lennard de Rijk

Define a default for rights['public'] in views/models/base.py. Alter rights in views/models/site.py to allow anyone, even signed-out users, to view the site home page. Patch by: Todd Larsen

Hide the 'scope' property from forms for now, since this is really supposed to be set by "Role context" as determined by logic code in the controller. Patch by: Todd Larsen

Fix some broken help_text bubbles (they are truncated or not displayed if they contain " double quotation marks). Add notice text (sort of ugly at the moment, Dmitri? :) explaining the "Public name" and "Link ID" fields in great detail. This patch is in preparation for making "Link ID" immutable for Users in a subsequent patch. Patch by: Todd Larsen

Fix for 404 occuring when signing out during the creation of, for example, a new Document. This patch makes sure that the request.path is not altered when requesting the create page (alteration of which caused the 404). This also results in the seeds now being remembered when being forced to log in. The editPost method now correctly switches to the edit path after a successful edit. Patch by: Lennard de Rijk

Fixed former_accounts detection by supplying the missing error message. Patch by: Todd Larsen

Rename the User.public_name Property to simply 'name' (but leave the verbose name as "Public name"). This is to take advantage of standardizing on 'name' in the common edit template (and possibly other common templates). The Property was renamed because public_name was already a "name", unlike the recent change to the Work Model class, where 'title' was "aliases" using a tiny name() method instead. Patch by: Todd Larsen

Include name of entity in the text of the link to the read-only public view present in the common edit template. Provide a simple method in the Work Model class that aliases the existing 'title' Property to 'name'. Patch by: Todd Larsen

Fix broken Site settings form by uncommenting code that was inadvertently committed commented out. Patch by: Todd Larsen

Merge soc/logic/out_of_band.py into soc/views/out_of_band.py. Merge errorResponse() and requestLogin() from soc/views/simple.py into out_of_band.Error and out_of_band.LoginRequest exception classes, respectively. Remove no-longer-used soc/logic/out_of_band.py and soc/views/simple.py. Fix some problems where usage of out_of_band was broken. Patch by: Todd Larsen

Remove redundant dicts for URL patterns and sidebar menu text, and use the existing params dict instead. Add a sidebar_heading customization to params. Better differentiate the 'User (self)' and 'Users' sidebar menus. Remove the redundant Site settings menu items now that the Site entity is a singleton. Patch by: Todd Larsen

By default, exclude files that are likely to be binary files. Patch by: Todd Larsen

Add User.public_name help text, per discussions on melange-soc-dev. Patch by: Todd Larsen

Allow for multiple list objects At the moment there's not really a practical use for it, since there is no way to make soc.views.models.base.View.list() show more than one list, but it shouldn't be too hard to allow for that. Patch by: Sverre Rabbelier

Make it more obvious that a format string constant is a format string by appending _FMT. Patch by: Todd Larsen

Fix getKeyValues() method footprint mismatches in soc.logic.models.site.Logic after the recent refactoring. Remove 'Link scope' drop-down from Edit Site Settings form. Patch by: Todd Larsen

Add a page name for 'Edit Main Site Settings'

Refactor classes in soc/logic/models to make more use of inheritance. Add some missing classes, such as soc.logic.models.group.Logic, so that key name similarities between various Groups can be exploited via inheritance instead of repetition of code. Patch by: Todd Larsen

Replace HomeSettings with Presence Model class. Replace SiteSettings with Site Model class. Derive Group Model class from Presence, adding the "home page settings" properties in a Melange site presence to every Group. Patch by: Todd Larsen

Move LINK_ID and SCOPE_PATH regular expressions to soc/models/linkable.py. Fix some too-long lines. Change key names back to type:scope_path/link_id (instead of type:scope_path:link_id). Some minor __doc__ string updates. Patch by: Todd Larsen

Removed unnecesary lines according to comment on r1067 Patch by: Lennard de Rijk

Make editSelf() work by adding 'inheritance_line' to the list of excluded fields in the UserForm. Also, fix a few too-long lines and add some missing parentheses (the style guide says do not rely on operator precedence). Patch by: Todd Larsen

Remove imports of the soc.logic.key_name module, since it was deleted by r1071 (and wasn't referenced in these modules anyway). Patch by: Todd Larsen

Replace nick_name and its variants with public_name. Remove the soc/templates/soc/person/edit.html template, since it does not appear to be referenced anywhere (and contained a nick_name reference that would otherwise need to be remedied). Patch by: Todd Larsen

Some indention and too long lines fixes in soc.views.models. Patch by: Pawel Solyga

Delete some more not needed directories this time in soc/logic and soc/templates. Patch by: Pawel Solyga

Remove not needed directories in soc/views. Patch by: Pawel Solyga

Created a checkIsInvited method Patch by: Sverre Rabbelier

Small comment fix in Linkable model. Patch by: Pawel Solyga

Removed one more unneccesary module Last commit reminded me that this one is obsolete too.

OK, this one file was missing from r1061 for some reason. Patch by: Todd Larsen

Minor improvements to roles page Mainly not hard-coding the page name and showing all requests that are _accepted_, instead of the one's that aren't yet.

Split a too long line

Adds the user's role page. Currently this only has an overview of the user's unhandled requests. Patch by: Lennard de Rijk

Changes the list template to use an instruction_text property that sets the text above the list. This makes the create_invite template unneeded. The instruction_text comes in handy when defining special lists. Patch by: Lennard de Rijk

Deleted unused files and files