Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:35:29 +0000] rev 221
Add sidebar menu items for /site/docs/list and /site/docs/edit. They do not
currently have view functions attached, but there are other links in the
mock-up portion of the sidebar that don't currently work, either. The goal
is to commit the /site/docs/list and /site/docs/edit changes in small bits
that don't break anyone else.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:33:43 +0000] rev 220
Add partial_path property explicitly to the Work model.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:25:31 +0000] rev 219
Should have been part of the r650 commit.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:23:32 +0000] rev 218
Directory for upcoming /site/docs views.
Todd Larsen <tlarsen@google.com> [Tue, 30 Sep 2008 17:03:51 +0000] rev 217
Add "Last updated" footer to front page body text, using the modified Property
from the Work entity.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 16:53:30 +0000] rev 216
Change _readonly_field_as_table_row <td> tag class names to match those used in _field_as_table_row. That should actually go into previous commit.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 16:49:54 +0000] rev 215
Clean up too long lines in profile.py. Add ReadOnlyInput widget to custom_widgets module, it can be used to display read-only form fields. Display read-only "Id" field in LookUp view if user has been found and in User Edit Developer view.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 16:26:30 +0000] rev 214
Add polymodel folder to DEFAULT_APP_DIRS variable in make_release.sh script.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 15:21:05 +0000] rev 213
Add key naming function for Sponsor, School, Organization, Club key_names.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 14:00:11 +0000] rev 212
Add org ReferenceProperty to Administrator model (many:1 relationship associating Administrators with specific Organization). Update Organization model __doc__ string with information about the back-reference 'admins'.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 12:59:59 +0000] rev 211
Made mce_settings class variable in TinyMCE widget a copy of default settings instead of reference.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 12:47:05 +0000] rev 210
Replaced context.update call to simple value assignment in site.user.profile.create view function.
Todd Larsen <tlarsen@google.com> [Mon, 29 Sep 2008 17:22:31 +0000] rev 209
Load ../../google_appengine/ into trunk/thirdparty/google_appengine.
Todd Larsen <tlarsen@google.com> [Mon, 29 Sep 2008 15:46:42 +0000] rev 208
Take advantage of the Model inheritance provided by polymodel.PolyModel to
have Club, School, Sponsor, and Organization actually inherit from the Group
Model class, rather than being composed via ReferenceProperties.
Patch by: Todd Larsen
Review by: Pawel Solyga, Sverre Rabbelier, Augie Fackler
Review URL: http://codereviews.googleopensourceprograms.com/606
Todd Larsen <tlarsen@google.com> [Mon, 29 Sep 2008 15:34:40 +0000] rev 207
Take advantage of the Model inheritance provided by polymodel.PolyModel to
have create a class hierarchy rooted at Person.
Also, add some missing Role classes, such as Role, (Organization) Mentor,
(Club) Member, (School) Student. Make (Organization) Administrator be a
Reviewer like Mentor is.
Patch by: Todd Larsen
Review by: Pawel Solyga, Sverre Rabbelier, Augie Fackler
Review URL: http://codereviews.googleopensourceprograms.com/607
Todd Larsen <tlarsen@google.com> [Mon, 29 Sep 2008 15:31:50 +0000] rev 206
Make use of PolyModel for Works, Documents, etc. Add some (but not all) of
the missing Models related to Documents. Refactor site settings to be useful
for any "/home" page view. Make the resulting home settings store a reference
to the Document, rather than looking up the Document by a hard-code key name.
This is to set the stage for Document editing being generic, and then being
able to select from some existing documents which one to use as the "/home"
static content. This makes it possible to pre-edit several Documents, have
them Reviewed, and then quickly change the "/home" page content as a setting,
rather than editing the Document in the settings form (though settings forms
might still embed the current document into their form for convenience).
Patch by: Todd Larsen
Review by: Pawel Solyga
Review URL: http://codereviews.googleopensourceprograms.com/1001
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 29 Sep 2008 14:03:45 +0000] rev 205
Fixed not working "Create New User" view which was caused by adding key_name into User Edit Developer view. This commit divides edit() view function in soc.views.site.user.profile into edit() and create() request handlers. New create() request handler is used only in "Create New User" view and has specific form validation functions and uses updateOrCreateUserFromId() instead of updateUserForKeyName().
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 26 Sep 2008 19:47:07 +0000] rev 204
Add ModelWithFieldAttributes *before* PolyModel, so that everything does not
become a "ModelWithFieldAttributes" in the Datastore.
The way PolyModel works, each Model class hierarchy is stored in the Datastore
as the class that directly inherited from PolyModel. So, we do not want to
insert ModelWithFieldAttributes *after* PolyModel by inheriting *from*
PolyModel, or everything would just be a ModelWithFieldAttributes in the
Datastore, instead of Person, Work, Group, etc.
Todd Larsen <tlarsen@google.com> [Fri, 26 Sep 2008 19:35:21 +0000] rev 203
Add the third-party PolyModel class. This class supports inheritance in
Google App Engine Datastore Model classes.
Todd Larsen <tlarsen@google.com> [Thu, 25 Sep 2008 17:17:11 +0000] rev 202
A key_name controller module to collect all of the name...() functions that
compose Model entity key names, plus some minor changes to other controller
modules to illustrate the proposed use.
Patch by: Todd Larsen
Review by: Pawel Solyga
Review URL: http://codereviews.googleopensourceprograms.com/804
Review URL: http://codereviews.googleopensourceprograms.com/804
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 24 Sep 2008 21:23:42 +0000] rev 201
Fixed missing urlparse import in request_helpers which cause /user/profile and /site/user/profile not to work at all. Removed not used module imports in response_helpers.py.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 06:00:28 +0000] rev 200
Replace mock-up of sidebar with first draft of dynamic sidebar functionality.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 05:58:45 +0000] rev 199
Minor tweaks to Site menu item names to make them more descriptive.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 05:58:15 +0000] rev 198
Major refactoring, to switch from using inheritance from soc.logic.menu classes
to an envelope-letter model instead.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 05:17:44 +0000] rev 197
Sidebar-building controller, with a TODO remaining to implement marking the
current page as "selected".
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:46:52 +0000] rev 196
Make views.helpers.html_menu MenuItem classes and logic.menu MenuItem classes
more closely related. This is part of some refactoring in my working copy
to keep soc/logic/site/sidebar.py from having to deal with html_menu classes
(which is like having view code in the controller, which is bad).
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:36:47 +0000] rev 195
Classes that wrap soc.logic.menu.Menu and soc.logic.menu.MenuItem to produce
HTML renderings of such lists.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:27:01 +0000] rev 194
Change indentation level to 2 (from 4) and rename MCE_DEF_SETTINGS to
DEF_MCE_SETTINGS to match the "default constant" naming convention elsewhere
in the code.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:24:49 +0000] rev 193
Note 'groups' back-reference from 'founder' property in soc.models.group.Group.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:23:32 +0000] rev 192
Simple MenuItem and Menu classes for keeping track of ordered menus.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:22:12 +0000] rev 191
These changes should have been in r620, but somehow I did not save them, or
saved over them with an old copy in the editor. Not sure...
Todd Larsen <tlarsen@google.com> [Tue, 23 Sep 2008 23:30:15 +0000] rev 190
Move isReferrerSelf() and replaceSuffix() into new request_helpers.py module,
since they are (mainly) used to manipulate parts of an HTTP request.
Todd Larsen <tlarsen@google.com> [Tue, 23 Sep 2008 23:20:23 +0000] rev 189
Split out HTTP request manipulation functions from template_helpers.py, which
is in danger of becoming a "misc" or "util" module unnecessarily.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 23 Sep 2008 19:20:57 +0000] rev 188
Changes in TinyMCE widget in custom_widgets.py based on review comments.
Patch by: Pawel Solyga
Review url: http://code.google.com/p/soc/source/detail?r=550
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 23 Sep 2008 17:55:54 +0000] rev 187
Change user list view instruction. Don't show "Next >" disabled greyed text in the list pagination if there is only one page.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 22 Sep 2008 14:13:32 +0000] rev 186
Add Users List Developer view which is available at /site/user/list. Add User list custom templates which are used with list_helpers. Add "Users List" link in base.html template.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 22 Sep 2008 14:08:37 +0000] rev 185
Add list_helpers functions that are going to be used when rendering list views like (Users List, Sponsors List etc).
Add list default templates and CSS classes.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 22 Sep 2008 13:42:53 +0000] rev 184
Add support for changing User id (Google Account email) in User Profile Developer view. Now user profile developer edit view includes hidden key_name field. Fix typo in user/profile.py. Show former user ids in lookup and edit User Profile Developer views.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 21 Sep 2008 08:59:11 +0000] rev 183
Small change to unescape function in template_helpers (move replace('&', '&') at the end).
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 21 Sep 2008 08:56:52 +0000] rev 182
Add rounded corners graphics. Add .notice class and rounded corners classes to soc.css file, those will be used to better visualize submit_message like "Profile saved.".
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 21 Sep 2008 08:50:42 +0000] rev 181
Remove Author model (use Person instead). Update models after removing Author. Add new Sponsor, Organization models.
Patch by: Pawel Solyga
Reviewed by: Todd Larsen
Review issue: 801
Review URL: http://codereviews.googleopensourceprograms.com/801
Augie Fackler <durin42@gmail.com> [Sun, 21 Sep 2008 02:16:00 +0000] rev 180
Two changes to ease CI:
1) If pysvn is missing, the tests for svn_helper don't run and pollute the
output
2) svn_helper no longer depends on being located at trunk/scripts/
Patch by: Augie Fackler
Review by: Todd Larsen
Review Issue: 802
Reviewed URL: http://codereviews.googleopensourceprograms.com/802
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 20 Sep 2008 19:04:43 +0000] rev 179
Add custom 404 error message with link to "Create a New User" which is displayed when linkname in User Profile Developer view URL (/site/user/profile/<linkname>) doesn't exist. Add default value (None) to new_suffix parameter of template_helpers replaceSuffix and redirectToChangedSuffix functions.
Augie Fackler <durin42@gmail.com> [Sat, 20 Sep 2008 17:39:07 +0000] rev 178
Testing buildbot. Sorry about the noise. (Last one for now, I've got most of the kinks figured out I think)
Augie Fackler <durin42@gmail.com> [Sat, 20 Sep 2008 16:50:20 +0000] rev 177
Testing buildbot. Sorry about the noise.
Augie Fackler <durin42@gmail.com> [Sat, 20 Sep 2008 16:47:09 +0000] rev 176
Testing buildbot. Sorry about the noise.
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 21:11:39 +0000] rev 175
Make django.zip in release/, instead of in app/ with a symlink in release/.
This allows debugging into app/django source code, which the presence of
app/django.zip was blocking. Tested with both:
dev_appserver.py release
and
dev_appserver.py app
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 18:02:37 +0000] rev 174
A rough draft of the Group Model, to be merged with Pawel's current effort in
his working copy. This is *very* incomplete...
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 17:51:33 +0000] rev 173
First pass (from some old code notes) of a School Model (a form of Group).
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 17:47:21 +0000] rev 172
First pass (from some old code notes) of a Club Model (a form of Group).
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 19 Sep 2008 12:45:13 +0000] rev 171
Bug fixes to revision r596. User Account field in Developer User Profile view needs to be an email not a login name. Header title of User Profile Developer view, when form validation failes is now showing correct value ("Modify existing ..." instead of "Create new user ...").
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 05:15:20 +0000] rev 170
Add /site/user/profile Developer view for editing arbitrary User entities.
Update /user/profile edit() view to fix TODO about updating the URL when a
POST of the form changes the link_name of the User. Add a Create New User
link to the base.html sidebar mock-up.
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 05:12:35 +0000] rev 169
Fix off-by-one corner case discovered during testing of /user/profile.
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 04:50:42 +0000] rev 168
Added getSingleIndexedParamValue() that retrieves an index into a list of
values from the named query parameter, and then indexes into the supplied list
of values to return the corresponding value from the list. Used to convert
numeric index query parameters passed by POST to the GET redirect target, so
that the GET code can display messages, etc. (without passing the message
itself as a query argument and having to escape it or have silly people pass
in their own...).
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 04:28:17 +0000] rev 167
Added replaceSuffix(), isReferrerSelf(), and redirectToChangedSuffix() to
implement the TODO in the User profile views where the link name portion of
the URL needs to change when the link_name Property is updated by the form.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 18 Sep 2008 23:07:06 +0000] rev 166
Fixed too long lines and deleted unused imports in id_user.py.