Sverre Rabbelier <srabbelier@gmail.com> [Sat, 14 Feb 2009 15:15:38 +0000] rev 1312
Fix a bug in group_app
If context is not set, kwargs['context'] will raise an exception.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 14 Feb 2009 14:11:45 +0000] rev 1311
Add cleaning methods for document ACL
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 14 Feb 2009 14:11:18 +0000] rev 1310
Make document ACL's a constant
This makes it possible to refer to it in other modules.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 14 Feb 2009 14:10:56 +0000] rev 1309
Fix a bug if you have no roles at all
This could not happen currently, but might happen later on if a group
is defined that does not have an 'anybody' membership.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 13 Feb 2009 23:18:39 +0000] rev 1308
Partially reverted "Update the copyright notice for 2009."
This partially reverts commit r1933. Only the files that were created
in 2008 were reverted.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 13 Feb 2009 22:36:45 +0000] rev 1307
Update the copyright notice for 2009.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 13 Feb 2009 21:54:35 +0000] rev 1306
Fix ToS link
s/Terms/Google App Engine Terms/
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 13 Feb 2009 21:54:10 +0000] rev 1305
Do access checks on the pick url for documents
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 13 Feb 2009 21:53:42 +0000] rev 1304
Convert the QueryDict to a regular dictionary
This way we support a query with multiple args specified.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 13 Feb 2009 21:53:15 +0000] rev 1303
Add prefix filtering and refactored program field generation
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 13 Feb 2009 21:52:38 +0000] rev 1302
We generate the select url ourselves, so it's safe
This prevented urls with an & in it to be correctly generated.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 13 Feb 2009 21:52:10 +0000] rev 1301
Added a filter_fields parameter to the ReferenceField widget
This paramater makes it possible to do 'hard coded' filtering.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 13 Feb 2009 21:51:41 +0000] rev 1300
Factor out the hasMembership method from checkMembership
This makes it possible for the document picker to reuse it.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 13 Feb 2009 21:51:16 +0000] rev 1299
Add a getMemberships method to logic/rights.py
This will be used by the document picker ACL checks.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 13 Feb 2009 19:22:34 +0000] rev 1298
Fixes as requested by Leslie on behalf of the Legal team
Upped the copyright statement from 2008 to 2009, and link to the GAE
Terms of Service instead of any custom ToS.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 13 Feb 2009 17:34:29 +0000] rev 1297
Added number of applications and their type to the bulkaccept JSON object.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 13 Feb 2009 16:40:02 +0000] rev 1296
Implemented the 2nd part of bulk acceptance.
The context of the _list call can now be set by using the kwarg context. This will be merged with the universalcontext.
Added a TODO to create the organziation accepted email template.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 13 Feb 2009 13:35:31 +0000] rev 1295
Document prefix in params now defaults to url_name.
This is because the short name does not have to be url friendly.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 13 Feb 2009 13:33:31 +0000] rev 1294
Added bulk_accept view which returns a JSON object.
This is going to be used to bulk accept org applications.
Also added a new unfinished template so Merio can test his JS.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 13 Feb 2009 11:46:06 +0000] rev 1293
Only a club admin should see resign as club admin in the sidebar.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 12 Feb 2009 23:35:44 +0000] rev 1292
Fixed a bug in club and org logic.
This bug would give an error when no backup was set.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 12 Feb 2009 23:26:23 +0000] rev 1291
Fixed a bug in group_app templates.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 12 Feb 2009 23:14:07 +0000] rev 1290
Brown Paper Bag Fix: L2R Appspot error logs.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 12 Feb 2009 23:12:09 +0000] rev 1289
Fixed a bug in group_app view.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 12 Feb 2009 23:06:14 +0000] rev 1288
Returning None instead of the empty to fix a bug on melange-demo instance.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 12 Feb 2009 22:52:16 +0000] rev 1287
Added check_field_is_empty decorator to cleaning.py.
This makes sure the cleaning checks are skipped when a field is empty. Note that Djanog will raise it's own ValidationError when a required field is empty before attempting to clean it.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 12 Feb 2009 22:20:13 +0000] rev 1286
Org App review page now shows accept and pre-accept button.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 12 Feb 2009 21:25:00 +0000] rev 1285
Fixed comment and typo in cleaning.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 12 Feb 2009 20:15:20 +0000] rev 1284
Add ToS agreement to mentor application related forms.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 12 Feb 2009 20:14:51 +0000] rev 1283
Add ToS agreement to org_admin application related forms.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 12 Feb 2009 20:14:17 +0000] rev 1282
Do not attempt to render a field if it is disabled
This is required to make it possible to disable fields dynamically.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 12 Feb 2009 20:13:51 +0000] rev 1281
Program requires the filter to be set to __scoped__
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 12 Feb 2009 20:13:27 +0000] rev 1280
Disable clubs for now
Disabling the clubs in this way is a lot easier than adding a switch
for it in Site Settings, and probably safer too (as the urls are no
longer valid).
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 12 Feb 2009 12:58:26 +0000] rev 1279
App Engine 1.1.9 update breaks django 1.0. Monkey patch django to only check for SVN revision number when not running using dev_appserver. On deployed version this doesn't apply since we use django from zipped file.
This issue was discussed here:
http://groups.google.com/group/codereview-discuss/browse_thread/thread/a7ab6ceb39c09ce6
http://groups.google.com/group/google-appengine/browse_thread/thread/bbdebf8617b57512
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 12 Feb 2009 12:30:36 +0000] rev 1278
Load /Users/solydzajs/Downloads/google_appengine into
trunk/thirdparty/google_appengine.
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 12 Feb 2009 10:24:37 +0000] rev 1277
Removed unused argument in program.py
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 12 Feb 2009 00:04:32 +0000] rev 1276
Initial implementation of a ToS requirement in org_app
If the _editContext method can be made generic enough, it should be
easy to add ToSes to other forms. This solution should also be
applied to user_self, as the current implementation is not very clean
to say the least.
Patch By: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 12 Feb 2009 00:02:06 +0000] rev 1275
Added an AgreementField widget
Displays an Agreement Document in a scrolling text field. The text of
the document can be set by modifying the 'text' property.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 11 Feb 2009 23:59:41 +0000] rev 1274
Rename TinyMCE to FullTinyMCE and add TinyMCE widget
The FullTinyMCE (irony intended) is the full-fledged editor, usefull
in editing documents etc. The regular TinyMCE widget can be used for
smaller tasks that allow HTML input (such as the description field).
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 11 Feb 2009 23:57:08 +0000] rev 1273
Use the newly added __scoped__ and references for program's ToSes
This fixes the ToSes autocompletion and 'enables' them.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 11 Feb 2009 23:54:41 +0000] rev 1272
Added an agreed_to_admin_agreement property
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 11 Feb 2009 23:52:11 +0000] rev 1271
Add '__scoped__' as a special filter
It sets the scope_path to the entity's key().value().
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 11 Feb 2009 23:49:44 +0000] rev 1270
Fields are always safe, as we generate them ourselves
This will be used by a future widget.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 11 Feb 2009 23:47:13 +0000] rev 1269
Add an _editContext hook
Usefull when one wants to have a hook that will always be called.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 11 Feb 2009 23:44:38 +0000] rev 1268
Resolve references if they are specified
All views sould make use of this instead of doing it manually in
_editGet and _editPost.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 11 Feb 2009 23:42:03 +0000] rev 1267
Make it possible to put fields at the end of the form
This is usefull for Terms of Service etc.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 11 Feb 2009 20:55:17 +0000] rev 1266
Changed the access checks for organization.
This should allow normal users to use organizations as well.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 11 Feb 2009 20:10:53 +0000] rev 1265
Added allowsidebar to checkIsDocumentReadable.
Note that this means that documents you can't actually read might show up in the sidebar. A todo has been added to fix this.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 11 Feb 2009 20:05:33 +0000] rev 1264
Added organization entity sidebar entries.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 11 Feb 2009 20:04:29 +0000] rev 1263
Fixed a bug in access.py that made it impossible to show featured documents in the sidebar.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 11 Feb 2009 20:02:46 +0000] rev 1262
Changed document to also filter on the prefix when getting the documents for a scope.
For this to work the organization prefix is now org.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 11 Feb 2009 19:59:27 +0000] rev 1261
Fixed a typo in org_admin model.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 10 Feb 2009 23:13:06 +0000] rev 1260
Added Agreement properties to Program Model.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 09 Feb 2009 16:17:25 +0000] rev 1259
Reset the RELEASE_TAG to None (unreleased) now that the 0.2-20090209 release candidate branch has been created.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 09 Feb 2009 15:58:17 +0000] rev 1258
Set RELEASE_TAG to 0.2-20090209rc for release candidate.
Patch by: Pawel Solyga
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 09 Feb 2009 00:02:07 +0000] rev 1257
Added a button to list all your org applications to a speficic program menu.
The entry only shows up when orgs can apply.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 08 Feb 2009 23:56:56 +0000] rev 1256
Put the tos extra_dynaexclude in presence_with_tos.py where it belongs.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 08 Feb 2009 23:55:44 +0000] rev 1255
Redone the listing in group_app.py.
There is now a list_self that only shows the group application of the current user in the given a scope. The redirects point to edit or applicant when necessary.
Review_overview will show all the group applications that can be reviewed in the given scope, the redirect points to review for all statusses.
And list will just show all the group applications and redirect you to edit.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 08 Feb 2009 23:49:29 +0000] rev 1254
Added new redirect for the new list views for group_app's.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 08 Feb 2009 22:57:23 +0000] rev 1253
Fix bug in group_app
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 08 Feb 2009 11:58:43 +0000] rev 1252
Temp bug fix
This should be fixed properly at some point.
Patch by: Sverre Rabbelier
Augie Fackler <durin42@gmail.com> [Sun, 08 Feb 2009 03:36:05 +0000] rev 1251
Add myself to authors since I was missing.
(Also, a test commit for buildbot)
Patch By: Augie Fackler <durin42@gmail.com>
Review By: TBR
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 07 Feb 2009 23:26:38 +0000] rev 1250
Fixed access checkers for orgs
Patch by: Sverre Rabbelier, Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 07 Feb 2009 22:56:15 +0000] rev 1249
Remove unneeded stylesheet and js and fix notification area
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 07 Feb 2009 22:49:51 +0000] rev 1248
Rename checkHasActiveRole to checkHasActiveRoleForScope
This is to prepare for a checker that checks if the user has any such
role, regardless of scope.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 07 Feb 2009 22:47:51 +0000] rev 1247
If there is no user account, don't show New Document link under Site
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 07 Feb 2009 22:10:19 +0000] rev 1246
Fixing r1855 that was bugged by Tortoise ^_^.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 07 Feb 2009 21:48:02 +0000] rev 1245
Fixed broken autocomplete due to wrongly named file
This should have been in r1852.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 07 Feb 2009 21:43:27 +0000] rev 1244
Should be part of r1855.
FOSDEM got the best of me :).
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 07 Feb 2009 20:44:05 +0000] rev 1243
Use short_name for the header title in a presence's home page
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 07 Feb 2009 20:42:28 +0000] rev 1242
Handle GAE account normalization
Also forbid users from going back to a former account.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 07 Feb 2009 20:40:48 +0000] rev 1241
Pimp TinyMCE widget.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 07 Feb 2009 20:39:08 +0000] rev 1240
Always return a site singleton and fix Edit Site Settings
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 07 Feb 2009 20:37:28 +0000] rev 1239
Stylefixes in access.py and removal of self.deny calls
The result of self.deny() is not very helpfull to the user, as such
we should not use it if we can provide a more sensible message.
Also made the document access checks use getForKeyFieldsOr404 to
prevent an error page when the specified document doesn't exist.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 07 Feb 2009 13:40:20 +0000] rev 1238
Added scoped group_app listing.
Also moved the review program applications menuentry to the specific program menu.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 07 Feb 2009 13:36:50 +0000] rev 1237
Added missing comment in access.py and removed excessive whitespace.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 07 Feb 2009 00:50:49 +0000] rev 1236
Hide all *.pyc files in trunk/.
r1850 was supposed to be a recursive property change, but was not.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 07 Feb 2009 00:37:28 +0000] rev 1235
Name .js and .css files more consistently with those previously present.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 07 Feb 2009 00:34:12 +0000] rev 1234
Add image that appears to be missing from the original thickbox patches.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 07 Feb 2009 00:21:23 +0000] rev 1233
Hide *.pyc files in trunk/ from 'svn status' output.
Patch by: Todd Larsen
Review by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 06 Feb 2009 10:24:45 +0000] rev 1232
Added pre-accpeted status to group_app.
This can be used when we want to accept all org's at once. Instead of one by one.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 06 Feb 2009 10:21:18 +0000] rev 1231
Added some help_text and clarifications to org_app model fields.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 05 Feb 2009 23:52:27 +0000] rev 1230
Cleanup in org_app and replace ReferenceProperty with LinkProperty
Using LinkProperty allows the org to host their idea's list on
Melange through the Document system, and then specify the URL of that
document. This also makes it possible for the orgs to specify a
document that is not hosted on Melange.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 05 Feb 2009 23:49:46 +0000] rev 1229
Refactored the picker so that it is more generic
The picker now also works in the case the scope_path of the entity
should not be filtered on. Also, it is now easier to add new
functionality due to the fact that there is a seperate Field type
to handle it now.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 05 Feb 2009 23:46:39 +0000] rev 1228
Added a ReferenceField widget
Also removed the unused ReadOnlyBool widget (as we now have a
properlyworking ReadOnly widget).
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 05 Feb 2009 23:43:52 +0000] rev 1227
Make picker work generically
Also removed some unused params from the JSON object.
Deleted the now unused checkHasPickGetArgs method.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 05 Feb 2009 23:41:02 +0000] rev 1226
Fix broken document access checks
The 'normalized checker' syntax was used to specify the access
checkers, but the normalization never happened.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 05 Feb 2009 22:15:38 +0000] rev 1225
Org applications can now only be made by a user when a program allows it.
To do this a new access_type has been added called apply. This ensures that users can only used the seeded version of create.
Also the review_overview now has his own access type to ensure the separability of hosts for different sponsors in case of org app reviews.
Note that the access checks for hosts are broken and only give access to developers at the moment.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 05 Feb 2009 22:13:49 +0000] rev 1224
Added a new redirect for apply accesstype.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 05 Feb 2009 22:13:12 +0000] rev 1223
Added new access checks to deal with timeline for programs.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 05 Feb 2009 21:29:55 +0000] rev 1222
Updated docstrings and used keyfields where necessary in soc/logic/models/base.py
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 05 Feb 2009 20:33:47 +0000] rev 1221
Remove extra whitespaces in soc.views.models.organization module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 05 Feb 2009 20:33:12 +0000] rev 1220
Add missing blank line to soc.logic.helper.timeline module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 05 Feb 2009 20:32:45 +0000] rev 1219
Fix import sorting in soc.views.models.sponsor module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 05 Feb 2009 20:19:17 +0000] rev 1218
Cleaned up getKeyNameFromFields in Logic base.
You can now pass it a dictionary that can contain other fields next to the keyfields.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 05 Feb 2009 19:30:43 +0000] rev 1217
Reverted r1819 and making an application will now reserve the link_id indefinitely.
This is to make sure our statistics dont get messed up.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 04 Feb 2009 23:09:28 +0000] rev 1216
Make the ToS text in-line and hook up thick-box in the help-text.
This way the user can see the ToS in scrollable form between the
link_id and the 'agree to tos' checkbox. Also, when clicking on the
link to the 'side-wide terms of service' a thickbox will pop up and
display the Terms of Service in an overlay.
Patch by: "Mario Ferraro" <fadinlight@gmail.com>
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 04 Feb 2009 23:06:48 +0000] rev 1215
Hook up the new jquery plugins in base.html and _as_table_row.html
A very important todo here is to make loading these plugins only when
needed, as to not waste bandwith. This should be trivial to do later
on though, so leaving as-is now.
Patch by: "Mario Ferraro" <fadinlight@gmail.com>
Reviewed by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 04 Feb 2009 23:04:10 +0000] rev 1214
Include the field_id in the context of _as_table_helper
This makes it possible to refer to the field that is being edited by
it's ID (in for example Javascript).
Patch by: "Mario Ferraro" <fadinlight@gmail.com>
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 04 Feb 2009 23:01:36 +0000] rev 1213
Make toDict "dereference" the 'name' property if it is present
This makes it possible to turn 'name' into a consistent alias that
can be used to represent an entity.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 04 Feb 2009 22:52:33 +0000] rev 1212
Added jquery thickbox, ajaxQueue, autocomplete and bgiframe
Also added the soc-specific stylesheets for jquery and thickbox.
Patch by: "Mario Ferraro" <fadinlight@gmail.com>
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 04 Feb 2009 21:24:36 +0000] rev 1211
Now calling block.super in timeline/edit.html template.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 04 Feb 2009 21:15:26 +0000] rev 1210
Added timezone clarification to the timeline edit form.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 04 Feb 2009 21:12:29 +0000] rev 1209
Specific program menu's now show a "Apply to become an Organization" entry when the program's timeline states that it's open.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 04 Feb 2009 21:10:34 +0000] rev 1208
Added new helper module for timelines.
This helps to determine wether a given event or period has begun/isactive/ended.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 04 Feb 2009 21:09:06 +0000] rev 1207
Added missing table header for org_apps.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 03 Feb 2009 21:15:12 +0000] rev 1206
Refactored the application review template into group_app.
Patch by: Madhusudan C.S
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 03 Feb 2009 20:30:08 +0000] rev 1205
Added validate_new_group to cleaning and removed clean_new_club_link_id.
This new cleaning method is a general purpose method for cleaning the form of a new group or group_app.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 03 Feb 2009 20:18:15 +0000] rev 1204
Fixed an error in group_app view that didnt let you create a new application.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 03 Feb 2009 15:18:40 +0000] rev 1203
Renamed checkHasRole to checkHasActiveRole.
We need this distinction to later allow another check to grant access upon a role that also might be inactive.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 03 Feb 2009 14:19:51 +0000] rev 1202
Added removal of an existing group application when someone else is applying.
This makes sure that the fields we do not collect via the form also get wiped when a rejected application is being redone by someone else.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 03 Feb 2009 13:50:41 +0000] rev 1201
Added checkCanReviewGroupApp to acces.py.
To make this work allowSidebar decorator was added as well. This will make sure that the Review buttons show up in the sidebar.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 03 Feb 2009 13:27:52 +0000] rev 1200
Added checkCanEditGroupApp to access.py.
Group Applications can now only be edited if they are either rejected or still in need of review.
Also fixed a bug in checkIsMyEntity.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 03 Feb 2009 13:26:34 +0000] rev 1199
Fixed whitespace in /soc/models/group_app.py
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 03 Feb 2009 09:20:09 +0000] rev 1198
Added some extra isUser checks to make sure that you have to accept the ToS before you can do anything concerning requests.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 03 Feb 2009 08:36:05 +0000] rev 1197
Fixes a bug where notifications can't be deleted.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 03 Feb 2009 08:33:46 +0000] rev 1196
Only do the update routine when the status changes for group_app's and role requests.
This helps prevent spamming multiple notifications.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 03 Feb 2009 08:25:47 +0000] rev 1195
Fixed a bug where a GMAP error message would be displayed when the form was not valid.
The wrong params were used, so the wrong template was used to display the form. This also caused the instruction_text to dissapear.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Mon, 02 Feb 2009 22:58:57 +0000] rev 1194
The simplejson in Django is now used, so do not create a symlink in build.sh.
Patch by: Todd Larsen
Review by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 02 Feb 2009 21:48:37 +0000] rev 1193
Fixed a typo in getForCurrentAccount comment.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 02 Feb 2009 21:46:01 +0000] rev 1192
Adds the possibility to exclude the user from the website.
getForCurrentAccount now only returns a user entity when it is valid.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 02 Feb 2009 20:56:14 +0000] rev 1191
Fixed default value for write_access in Document model.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 02 Feb 2009 20:07:52 +0000] rev 1190
Probably fixed a bug on the live instance.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 02 Feb 2009 17:02:31 +0000] rev 1189
More access related fixes
Also make it possible to do access checks for 'create'.
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 02 Feb 2009 16:57:21 +0000] rev 1188
Reset the RELEASE_TAG to None (unreleased) now that the 0.2-20090202 release
candidate branch has been created.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 02 Feb 2009 16:44:17 +0000] rev 1187
Set RELEASE_TAG to 0.2-20090202rc for release candidate 02/02/2009.
Patch by: Pawel Solyga
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 02 Feb 2009 16:42:31 +0000] rev 1186
Fixed EOL errors.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 02 Feb 2009 16:21:33 +0000] rev 1185
Create org_application now shows select program view.
Also fixed the menu heading.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 02 Feb 2009 16:03:21 +0000] rev 1184
Use .logic in checkIsAllowedToManageRole at the caller
This is to be consistent with the rest of the module.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 02 Feb 2009 15:39:22 +0000] rev 1183
Make getForFields work with no filter
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 02 Feb 2009 15:34:45 +0000] rev 1182
Fixed EOL damage in org_app and access checks
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 02 Feb 2009 15:04:04 +0000] rev 1181
Calling getForCurrentAccount where necessary.
Also fixed whitespace error in soc/views/models/user_self.py
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 02 Feb 2009 15:00:43 +0000] rev 1180
Fixed club_app
The user could not edit their own club app due to a buggy check.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 02 Feb 2009 14:47:09 +0000] rev 1179
Rewrite getForFields to use GQL instead of the Query API
Apparently the Query API does not support the IN statement.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 02 Feb 2009 14:19:22 +0000] rev 1178
Removed work flow field from the check in getExtraMenus for program.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 02 Feb 2009 14:09:24 +0000] rev 1177
More access related fixes
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 02 Feb 2009 13:59:07 +0000] rev 1176
Fixed access related bugs
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 02 Feb 2009 13:48:15 +0000] rev 1175
Make longitude and latitude hidden fields not required in soc.views.models.role module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 02 Feb 2009 10:15:07 +0000] rev 1174
Fix broken Roles public templates. By mistake we used entity.user.public_name instead of entity.user.name.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 02 Feb 2009 10:10:39 +0000] rev 1173
Changes in club_app and org_app public templates. Don't show email address in public template.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 02 Feb 2009 10:09:18 +0000] rev 1172
Style fixes in soc.views.models.user module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 02 Feb 2009 10:07:34 +0000] rev 1171
Style fixes in soc.logic.models modules.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 02 Feb 2009 10:06:36 +0000] rev 1170
Fix missing indention in css file.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 23:36:50 +0000] rev 1169
Set the right field type in user_self to overcome confusion.
Also reverted a template change.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 23:27:28 +0000] rev 1168
Adding a hidden agreed_to_tos field when the user has signed the ToS.
This a more cleaner solution then r1774.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 01 Feb 2009 22:51:14 +0000] rev 1167
Fix the JS but mentioned in the previous commit
Patch by: Sverre Rabbelier
Reviewed by: Pawel Solyga
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 01 Feb 2009 22:48:48 +0000] rev 1166
Fix get args construction when there are multiple lists on the page
It is now possible to go back and forward through the liast, and
specify the limit (both offset and limit can be done per list).
The JS driving the list boxes is buggy, if visiting an url like:
http://localhost:8080/notification/list?limit_0=10
And then change the limit in the second checkbox, it directs to:
http://localhost:8080/notification/list?limit_1=25
Whereas it should redirect to:
http://localhost:8080/notification/list?limit_0=10&limit_1=25
The logic _does_ work properly when the limit of the changed list
is already present in the url.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 01 Feb 2009 22:44:14 +0000] rev 1165
Unify 'getForFields' and 'getForLimitAndOffset'
This also fixes the broken list views for filtered lists.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 22:35:35 +0000] rev 1164
User profile now shows the time on which you signed the ToS.
Note that this solution is temporary and a hidden_field_as_table_row will be made by Pawel soon.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 01 Feb 2009 20:44:47 +0000] rev 1163
Cleaned up access.py
Removed a lot of duplicate code and added more generic checkers in
their place.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 01 Feb 2009 20:41:58 +0000] rev 1162
Do not return empty menu's in program.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 17:52:12 +0000] rev 1161
This patch prohibits changing of agreed_to_tos and agreed_to_tos_on by the Logic module.
This is used so that legally the agreed_to_tos fields can never change in the User model once set.
Patch by: Haoyu Bai
Reviewed by: Lennard de Rijk
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 01 Feb 2009 17:40:26 +0000] rev 1160
Add publish_location boolean property to Role model. This field indicates whether the User has agreed to publish his location. It is not supported yet in any logic, views or templates but we won't want to change models later so it's being added now.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 17:31:09 +0000] rev 1159
Fixes an error occurring when editing a User as Developer when the ToS have been signed.
By disabling the input of the field Django will not attempt to wrongly parse it as a DateTime instance.
Patch by: Haoyu Bai
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 17:21:46 +0000] rev 1158
ReadOnlyInput widget now shows text instead of a greyed-out input box.
Patch by: Haoyu Bai
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 17:14:42 +0000] rev 1157
Added status property to the user model.
This is to accommodate the ability to exclude users from using the website.
Note that since the access modules is currently undergoing some reconstruction changing the status will not actually effect the User yet.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 16:18:04 +0000] rev 1156
Fixed EOL and whitespace in org_app templates
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 01 Feb 2009 16:14:25 +0000] rev 1155
Update error message that shows when Google Maps API key is missing.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 16:14:09 +0000] rev 1154
Implement the last step in the org application process.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 16:11:54 +0000] rev 1153
Refactored applicant from club view to group view.
This is to accommodate the OrgApplication Process.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 01 Feb 2009 16:10:20 +0000] rev 1152
Add Google Maps integration for Role profiles create/edit views.
Now when editing/creating your Role Profile page Google Maps widget will show up at the bottom of the form as "Location" field. When you type in your Street, City, Country or State it will automatically update the map with the location based on your address. The zoom level depends on the address information you provided. So for example if you just select Country it will be different then when you select both Country and City. The longitude and latitude fields are hidden and are updated with the coordinates from the address you provided. Also if the map is not accurate enough you can adjust your location by dragging the red market, which will change your location and save new coordinates into hidden fields. This patch also includes some style fixes in soc.views.models.role module.
Patch by: Mario Ferraro & Pawel Solyga
Reviewed by: Pawel Solyga
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 16:09:43 +0000] rev 1151
Added org_app view and templates.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 16:07:37 +0000] rev 1150
Changed club_app review template to use key.name.
This will ensure that if we ever decide to change it to a scoped entity the review template will not break.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 16:06:22 +0000] rev 1149
Changed some errors in the org_app model.
The backup_admin property has been removed because it's present in the group_app model.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 16:04:31 +0000] rev 1148
Added org_app logic.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 16:03:58 +0000] rev 1147
Changed group_app to use scope_logic in constructor.
This is so org_app logic can use a scope_logic.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 16:00:42 +0000] rev 1146
Changed getApplicantRedirect to use the key_name instead of just a link_id.
This is to make it work with OrgApplication.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 01 Feb 2009 13:33:48 +0000] rev 1145
Fix import sorting in soc.views.models.document module to comply with our style guide.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 01 Feb 2009 13:29:34 +0000] rev 1144
Rename 'Create a new document' links to 'Create a New Document', also rename 'Create a new Program' to 'Create a New Program' in soc.views.models modules.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 01 Feb 2009 13:26:25 +0000] rev 1143
Fix missing dots and blank lines to soc.logic modules.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 01 Feb 2009 13:25:27 +0000] rev 1142
Fix missing dot and wrong import sorting in soc.views.helper.access module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 01 Feb 2009 13:24:43 +0000] rev 1141
Style fixes in soc.models.document module (adding of missing whitespaces).
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 01 Feb 2009 13:24:00 +0000] rev 1140
Style fixes in soc.logic.models modules (basically removing of extra whitespaces).
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 13:07:12 +0000] rev 1139
Changed the url regexpr for review and added 2 missing imports.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 09:55:02 +0000] rev 1138
Refactored review and reviewoverview out of club_app.py
This is to help accomodate the upcoming OrgApplication.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 01 Feb 2009 09:11:39 +0000] rev 1137
Added view for mentors.
This one is for real.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 31 Jan 2009 22:59:27 +0000] rev 1136
Added two forgotten comments in rights.Checker
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 31 Jan 2009 22:32:54 +0000] rev 1135
Hook up the ACL system for documents.
Org access checks are left unimplemented as they are not done yet.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 31 Jan 2009 22:32:21 +0000] rev 1134
Final changes to the document model
With a seperate set of read and write permissions it is possible to
very accurately specify the ACL of the document.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 31 Jan 2009 22:32:01 +0000] rev 1133
Added a rights module
The purpose of this module is to translate from document prefix
and status to a set of access checks.
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 31 Jan 2009 22:23:23 +0000] rev 1132
Replace name_on_certificates property with name_on_documents, since mentors, club admins, hosts and org admins don't get certificates it's better to name it 'Name on documents' which can indicate any kind of documents including awards certificates. Also don't show name_on_documents in public Role profiles, instead show user public name in that place.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 21:32:29 +0000] rev 1131
Changed display_name to name_on_certificates in models/role.py.
This is to make the intention of this property more clear as to display_name which would remind people of for instance nicknames or a replacement for their public name for this role.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 19:46:55 +0000] rev 1130
Added view and templates for mentors.
Mentors can be invited or send a request to become a mentor for a specific org.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 19:33:40 +0000] rev 1129
Fixed a bug in soc/views/models/role.py.
This bug allowed the creation of only invalid requests opposed to valid requests.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 19:02:53 +0000] rev 1128
Added a view and templates for the organization admin.
This means that org admins can now be created/invited.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 18:58:09 +0000] rev 1127
Fixed two small errors.
Removed an unnecessary edit_extra field in club.py.
And made group.py call getForCurrentAccount where necessary.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 18:55:34 +0000] rev 1126
Added organization view and templates.
Also added TODO's so it's clear what still needs to be done to make this work.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 18:44:00 +0000] rev 1125
Removed obsolete _editPost and _editGet in soc/views/models/club.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 18:25:11 +0000] rev 1124
Reverting a change from r1732 for reasons stated in soc/logic/models/group.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 18:06:34 +0000] rev 1123
Changed scope_logic for requests to linkable_logic.
This makes the scope_path for a requests of a variable length which is needed for reuse.
Patch by: Sverre Rabbelier and Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 17:01:56 +0000] rev 1122
Removed workflow type as keyfield from program.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 16:20:11 +0000] rev 1121
Added mentor and org_admin logic.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 31 Jan 2009 16:16:44 +0000] rev 1120
Add an 'unread' style and add 'new document' link for user
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 16:15:53 +0000] rev 1119
Fixed a string formatting bug in soc/views/models/role.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 16:07:30 +0000] rev 1118
When moving stuff please make sure that all your belongings are safely secured.
Brown Paper Bag fix.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 16:04:22 +0000] rev 1117
Fixed a bug in role.py that made it call the wrong superclass.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 16:03:14 +0000] rev 1116
Moved create_extra_dynafields from club_admin and member to role.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 31 Jan 2009 15:41:45 +0000] rev 1115
Cleanups in base.Logic
* Use regular kwargs instead of **kwargs
* Fold getKeyNameFromFields into _keyName
* Fold getIfFields into getFromFieldsOr404
* Rename getKeyValues to getKeyValuesFromEntity
* Rename getKeyFieldsFromDict to getKeyFieldsFromFields
* Rename getFromFieldsOr404 to getFromKeyFieldsOr404
* Rename getKeyValues to getKeyValuesFromEntity
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 31 Jan 2009 15:40:32 +0000] rev 1114
Add checkIsProgramActive to the rights flushing
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 31 Jan 2009 14:39:05 +0000] rev 1113
Small changes in Mentor model (we don't inherit from Reviewer anymore since model inheritance is not supported in datastore).
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 31 Jan 2009 14:38:04 +0000] rev 1112
Add Organization Administrator model.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 31 Jan 2009 14:37:39 +0000] rev 1111
Remove not used Administrator model that is replaced by Host model.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 14:18:02 +0000] rev 1110
soc/views/models/club.py now uses getForCurrentAccount where necessary.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 13:59:49 +0000] rev 1109
Edited the access check for show in site settings.
Not everyone should see our keys :).
And also moved the template to site folder and changed presence back to the way it should be.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 13:49:50 +0000] rev 1108
Added rights to soc/views/models/timeline.py.
Only a developer or a host for the program this timeline is for can edit it now.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 13:48:48 +0000] rev 1107
Added status to program.
Also added a new access_check and changed the program edit template to the basic one without edit timeline button.
Changed the program menu to show more helpful links like Edit Timeline.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 31 Jan 2009 12:59:52 +0000] rev 1106
Flush sidebar when creating a new entity
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 31 Jan 2009 12:36:07 +0000] rev 1105
Update site/home.html to match the new document structure
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 31 Jan 2009 12:36:06 +0000] rev 1104
Added a Create a New Program link to the Program Owners's menu.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 31 Jan 2009 12:35:40 +0000] rev 1103
Flush sidebar when creating site entity
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 31 Jan 2009 12:22:01 +0000] rev 1102
Brown paper bag fix
We can only add the create link if there is a site entity.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 31 Jan 2009 12:12:05 +0000] rev 1101
Made presence document retrievel specify prefix
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 31 Jan 2009 12:11:34 +0000] rev 1100
Added a 'create new document' link to site
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 31 Jan 2009 11:28:05 +0000] rev 1099
Remove simplejson module from our repository since it's a duplicate of django.utils.simplejson.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 31 Jan 2009 11:25:53 +0000] rev 1098
Use django.utils.simplejson in soc.views.models.base pick method instead of our standalone simplejson module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 30 Jan 2009 22:02:20 +0000] rev 1097
Add a 'Create new document' link for clubs, sponsors and programs
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 30 Jan 2009 22:01:52 +0000] rev 1096
Added a getCreateDocumentRedirect
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 30 Jan 2009 22:01:27 +0000] rev 1095
Add access control to document model and view
The access checks are not yet written, but at least the model is
stable from now on.
Also converted the document view to dynaform while at it.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 30 Jan 2009 22:00:49 +0000] rev 1094
Factor out the getPattern logic from params
This is to facilitate it's use by the document view later on.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 30 Jan 2009 22:00:23 +0000] rev 1093
Made the /create/<scope> url conditional
The 'no_create_with_scope' parameter can be used to disable it.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 30 Jan 2009 22:00:01 +0000] rev 1092
Removed unused key_fields_prefix variable
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 30 Jan 2009 21:59:38 +0000] rev 1091
Moved is_featured property to Document
Only Documents can be featured in the sidebar, as such it makes sense
to have this property in the Document model.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 30 Jan 2009 21:59:13 +0000] rev 1090
Added missing dot.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 30 Jan 2009 21:58:53 +0000] rev 1089
Copy the default django patterns rather than modifying them
This prevents an ever-growing list of urls in the case that
getDjangoURLPatterns is called multiple times.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 30 Jan 2009 21:58:31 +0000] rev 1088
Added a clean_scope_path to cleaning
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 30 Jan 2009 20:16:53 +0000] rev 1087
Fix the notification bar messages that show up when you click 'Save Changes' button. It only works on Edit views right now.
Patch by: Madhusudan C.S
Reviewed by: Pawel Solyga
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 17:44:31 +0000] rev 1086
^_^, fixed header in templates/soc/request/list/heading.html.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 17:38:28 +0000] rev 1085
Renamed state to status where appropriate.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 17:23:19 +0000] rev 1084
Requests can now not be created when you already have a similar request or already have the role the request is for.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 11:46:08 +0000] rev 1083
Moved clean_club_app_link_id to cleaning.
This method is now also used by the club create_form. Which means that you cannot create a new club with an already reserved link_id until the club application has been rejected.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 11:30:43 +0000] rev 1082
Changed group_app logic to support scope_path.
Moved link_id only as keyvalues to club_app.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 11:16:48 +0000] rev 1081
Added a cleaning method to club_app view.
This ensures that you can't create a application for an already taken Link ID.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 11:15:26 +0000] rev 1080
Changed status in group app model to state.
Also changed it wherever needed to increase consistency.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 10:36:23 +0000] rev 1079
Changed clean_link_id to be in a wrapper form as well.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 09:44:46 +0000] rev 1078
Deleted soc/models/member.py since it's the equivalent of club_member.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 09:43:11 +0000] rev 1077
docstring fix in soc/models/student.py.
Patch by: Haoyu Bai
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 30 Jan 2009 09:31:56 +0000] rev 1076
Added agreed_to_tos_on field in user and role model.
Also the user and user_self view no properly handle this new field.
The ToS will be shown on-screen (not in a nice way) only if it is in effect and a user has not signed it yet.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 29 Jan 2009 23:07:04 +0000] rev 1075
Cleaned up overly enthousiastic comments
From the styleguide:
On the other hand, never describe the code. Assume the person reading
the code knows Python (though not what you're trying to do) better
than you do.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 29 Jan 2009 23:05:37 +0000] rev 1074
Properly check if a program is active
Also cleaned up checkIsHost, which got merge-mangled when refactoring
the access module.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 29 Jan 2009 23:04:12 +0000] rev 1073
Factor out the allowIfCheckPasses logic
Keep allowDeveloper around as convenience method though.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 29 Jan 2009 23:02:47 +0000] rev 1072
Fix EOL damage and add link to first row item for notifcations
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 29 Jan 2009 20:40:34 +0000] rev 1071
Added menu entries for a specific Sponsor Entity.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 29 Jan 2009 20:29:07 +0000] rev 1070
Fixed rights flushing
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 29 Jan 2009 18:26:03 +0000] rev 1069
Added resign as club admin and club member links to the club entity menu.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 29 Jan 2009 18:18:20 +0000] rev 1068
Changed docstring for checkIsAllowedToManageRole.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 29 Jan 2009 18:13:21 +0000] rev 1067
Added manage view for Club Admins, Club Members and Hosts.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 29 Jan 2009 18:11:11 +0000] rev 1066
Added checkIsAllowedToManageRole to access.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 29 Jan 2009 18:10:21 +0000] rev 1065
Added manage redirect.
Also changed the menu layout for group entities.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 29 Jan 2009 16:12:57 +0000] rev 1064
Edited existing templates to deal with the new fields in group model.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 29 Jan 2009 15:55:40 +0000] rev 1063
Redone access checks in club and sponsor model to deal with state property in their model.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 29 Jan 2009 15:54:50 +0000] rev 1062
Creating a new host or club_admin will set the group state to active if it's new.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 29 Jan 2009 15:53:35 +0000] rev 1061
Redone access checks concerning groups to deal with the state property.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 29 Jan 2009 15:46:33 +0000] rev 1060
Added state and shipping address fields to group model.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 29 Jan 2009 15:38:41 +0000] rev 1059
prefixing the link_id of a notification with a t for time to agree to the new link_id pattern.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 29 Jan 2009 09:33:50 +0000] rev 1058
Fix regexp for link id format validation. Link id needs to start with ASCII lowercase and not with digit, which caused User Profile view to crash.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 29 Jan 2009 08:14:46 +0000] rev 1057
Fix typos in comments and help text in soc.models.program module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 29 Jan 2009 01:39:31 +0000] rev 1056
Added a simple slot allocation algorithm
Comes with a whole bunch of tests, but not nearly enough.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 23:52:25 +0000] rev 1055
Update test to match new sidebar caching signature
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 23:49:45 +0000] rev 1054
Add forgotten __init__.py to pymox
Patch by: Sverre Rabbelier
Todd Larsen <tlarsen@google.com> [Wed, 28 Jan 2009 21:01:37 +0000] rev 1053
Rename the confusing Tossed Model class to PresenceWithToS.
Patch by: Todd Larsen
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 20:27:16 +0000] rev 1052
Added a 'allocations_visible' property to program
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 20:21:15 +0000] rev 1051
Create a new Tossed layer in the MVC
Also move is_enabled to program instead of presence.
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 28 Jan 2009 18:24:20 +0000] rev 1050
Add 'Flush Cache' button next to Admin link. It's visible only when working on dev_appserver locally. This is a quick way of flushing memcache.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 18:23:45 +0000] rev 1049
Fixed the edit site view having a delete button
Also a minor cleanup in group.py.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 28 Jan 2009 17:33:05 +0000] rev 1048
Changed access.py to comply more with the style of the module.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 28 Jan 2009 17:31:02 +0000] rev 1047
Changed the Terms Of Service boolean so that it is None as long as the user owning the account has not Agreed to it.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 28 Jan 2009 16:50:54 +0000] rev 1046
Changed the verbose name for agrees_to_tos to I agree to the Terms of Service.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 28 Jan 2009 16:48:41 +0000] rev 1045
Removed default value for agrees_to_tos in soc/models/user.py
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 28 Jan 2009 16:40:16 +0000] rev 1044
Reverted r1646.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 28 Jan 2009 15:43:30 +0000] rev 1043
Redone the user's profile page.
A user can now create his profile on /user/create_profile.
A user can edit his profile on /user/edit_profile.
Created new access checks to correctly allow access to the new profile page.
Changed the /user/edit_self.html template to /user/edit_profile.html.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 28 Jan 2009 15:40:44 +0000] rev 1042
Renamed _getToSExampleText to getToSExampleText in soc/views/models/user.py.
Removed a TODO that has already been done.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 28 Jan 2009 15:33:53 +0000] rev 1041
Added default values to the User model.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 28 Jan 2009 15:32:57 +0000] rev 1040
Added a TODO to soc/logic/models/site.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 28 Jan 2009 15:31:54 +0000] rev 1039
Added new clean_agrees_to_tos to cleaning.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 15:25:50 +0000] rev 1038
Allow for a program on/off switch
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 15:24:02 +0000] rev 1037
Fix wrong order of decorators and some cleanup
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 15:22:34 +0000] rev 1036
Add an 'edit' link to the program menu
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 14:18:31 +0000] rev 1035
Allow for setting a edit_cancel_redirect
Defaults to list view for the entity but can be overriden by setting
the parameter manually. Falls back to history.go(-1) if not set.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 14:16:46 +0000] rev 1034
Make the user/edit.html template derive from soc/models/edit.html
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 14:15:00 +0000] rev 1033
Also flush the user's ACL's when flushing the sidebar
It is pretty pointless to flush the sidebar if the same ACL's will
be re-used anyway, so make sure the ACL's are flushed as well.
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 28 Jan 2009 11:26:47 +0000] rev 1032
Style fixes in soc.views.helper.redirects and soc.models.base modules.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 28 Jan 2009 11:26:00 +0000] rev 1031
Add gmaps_api_key to context is settings entity exists.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 28 Jan 2009 11:24:34 +0000] rev 1030
Style fixes in soc.views.models modules.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 28 Jan 2009 11:23:19 +0000] rev 1029
Style fixes in soc.cache modules.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 28 Jan 2009 11:22:41 +0000] rev 1028
Style fixes in soc.logic.cleaning module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 28 Jan 2009 11:21:58 +0000] rev 1027
Style and import sorting fixes in tests modules.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 28 Jan 2009 11:15:32 +0000] rev 1026
Fixed typo's in soc/views/helper/dynaform.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 02:28:52 +0000] rev 1025
Add grouping to the existing views
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 02:27:25 +0000] rev 1024
Group dynamically generated menu items
Also allow for grouping other views by setting the 'sidebar_grouping'
param to a value another than 'main'.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 02:25:51 +0000] rev 1023
Bugfixes after recent refactoring
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 02:24:13 +0000] rev 1022
Added Haoyu Bai to the AUTHORS file
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 00:45:35 +0000] rev 1021
Allow appending to dynainclude/-exclude
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 00:36:30 +0000] rev 1020
Reduce caching time of sidebar to 3 minutes
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 00:35:11 +0000] rev 1019
Flush cache if user makes a document featured
Also flush it if a new document is created as featured.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 28 Jan 2009 00:33:47 +0000] rev 1018
Make tooltips work when tabbing
Fixed the tooltips on IE, and changed the background colour to be
nicer on Firefox.
Patch by: Haoyu Bai <baihaoyu@gmail.com>
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 27 Jan 2009 22:59:01 +0000] rev 1017
Cache access checks and disable sidebar caching
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 27 Jan 2009 22:57:19 +0000] rev 1016
Create a decorator for allowDeveloper
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 27 Jan 2009 21:56:32 +0000] rev 1015
Add profiling support to Melange. By assigning profile_main_as_logs or profile_main_as_html to main variable you can turn on profiling. profile_main_as_logs will log profile data to App Engine console logs, profile_main_as_html will show profile data as html at the bottom of the page. If you want to profile app on deployed app just set the profiling function and deploy it.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 27 Jan 2009 20:30:26 +0000] rev 1014
soc/views/models/user.py now uses dynaform and appropriate cleaning methods.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 27 Jan 2009 20:27:50 +0000] rev 1013
Added new clean methods in preparation for new User View.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 27 Jan 2009 13:36:45 +0000] rev 1012
Fold checkAgreesToSiteToS into checkIsUser
No use in having a check that's not used except in another checker
anyway, so might as well fold it in.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 27 Jan 2009 12:47:28 +0000] rev 1011
Removed unused URL pattern in soc/views/models/request.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 27 Jan 2009 11:17:18 +0000] rev 1010
Fixed two access related bugs
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 27 Jan 2009 11:15:49 +0000] rev 1009
Added some very basic tests for the sidebar and access modules
Also updated run.py to set the USER_EMAIL variable.
Patch by: Sverre Rabbelier
Augie Fackler <durin42@gmail.com> [Tue, 27 Jan 2009 04:09:57 +0000] rev 1008
Fix testing views, which broke because now we need to register a proxy for the
memcache API as well.
Patch By: Augie Fackler <durin42@gmail.com>
Review By: TBR
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 26 Jan 2009 23:32:10 +0000] rev 1007
Major refactor of the access module
The first step to sanity is a leap into the unknown? Create an object
to represent the access checks for each module instead of a bunch of
loose functions.
Converted all views and params.py to use the new access checker.
Main differences:
* arguments to a checker can be passed by using a tuple
* checkers are referenced by string, rather than directly
* the Checker constructor handles merging with child views
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 26 Jan 2009 21:22:53 +0000] rev 1006
Added a sidebar link for all users that accepted the ToS to a view that allows you to choose a club which you want to become a member for.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 26 Jan 2009 20:33:20 +0000] rev 1005
Changed method name in access.py to fix overwriting another method.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 26 Jan 2009 17:19:14 +0000] rev 1004
Fixed typo in club sidebar entry.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 26 Jan 2009 17:11:54 +0000] rev 1003
Added sidebar entries for club entities.
Added the right['home'] to club and sponsor view.
Fixed some comments in the group view.
Also added a TODO for the sponsor sidebar entries.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 26 Jan 2009 17:08:27 +0000] rev 1002
Added sidebar support for group instances.
Also group now properly inherits from the presence view.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 26 Jan 2009 16:11:50 +0000] rev 1001
Flush the sidebar cache when a new active role entity has been created.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 26 Jan 2009 16:04:19 +0000] rev 1000
Add pymox to tests folder.
Requested by Sverre.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 26 Jan 2009 14:51:07 +0000] rev 999
Developers are hosts for every sponsor now.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 26 Jan 2009 09:44:00 +0000] rev 998
Implemented the listing of all the roles in for a specific group.
Removed a TODO about removing the tolist assignment in soc/views/models/host.py because this list is now obsolete.
Added a TODO to change the redirect of the member listing once the manage page is done.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 23:35:39 +0000] rev 997
Added flushing the sidebar when dealing with notifications.
On request from Pawel Solyga.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 22:42:09 +0000] rev 996
Renamed checkIsHostForProgram to checkIsHostForSponsor.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 22:30:42 +0000] rev 995
Added rights check to sponsor.py.
In the process of doing so also fixed checkIsHostForProgram method in access.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 22:15:13 +0000] rev 994
listRequests now only shows the requests that concerns the given group.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 22:05:25 +0000] rev 993
Renamed role_names to role_logic and made it a dictionary.
It now maps a role_name to role_logic. This will be useful for listing for instance club members.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 21:52:35 +0000] rev 992
Fixed a bug in access.py.
Context was not assigned to a variable during a redesign of access.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 21:03:12 +0000] rev 991
Added cache flush for the user who creates a group and the user whose role has been activated.
As requested by Sverre Rabbelier.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 16:50:24 +0000] rev 990
Added two needed redirects in role.py.
To make this work properly group_view was added to params in club_admin and club_member.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 16:43:15 +0000] rev 989
Moved listRequests from club to group view.
Added a TODO for adding request list to sidebar entry for every group. And for setting the rights for Sponsor view.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 25 Jan 2009 16:29:36 +0000] rev 988
Flush the sidebar if a user's rights change
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 25 Jan 2009 16:28:07 +0000] rev 987
Cache sidebar with a simple caching API
We cache the sidebar once for every user, the downside is that once
the user meets new access criteria, their sidebar does not get
updated. This can be fixed by calling soc.cache.sidebar.flush() when
appropriate.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 25 Jan 2009 16:25:17 +0000] rev 986
Rename ModelProperties to EntityProperties
We use 'model' when referring to the db.Model, the context in which
'ModelProperties' was used we really mean 'entity', which refers to
an instantiation of the model.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 16:17:33 +0000] rev 985
Added getListRequestsRedirect to redirects.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 25 Jan 2009 15:09:10 +0000] rev 984
Forgotten in last commit, the json template
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 15:03:12 +0000] rev 983
Added request listing for Club Admins.
This page will redirect them to the Request Processing page.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 15:01:55 +0000] rev 982
Changed the title for the process_request webpage.
Also removed some whitespace.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 14:43:49 +0000] rev 981
Added getProcessRequestRedirect method to redirects.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 12:28:26 +0000] rev 980
Added Club Members to SoC.
Every user can request to become a Club Member. Club Admins can invite users.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 12:22:53 +0000] rev 979
Added checkCanMakeRequestToGroup to access.py.
Note that states for a group have not been implemented yet, so a TODO has been added for this check.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 12:20:35 +0000] rev 978
Moved getGroupEntityFromScopePath to logic/models/role.py.
Also removed a TODO that has been done :).
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 25 Jan 2009 11:44:25 +0000] rev 977
Have /entity/pick return a JSON object instead of a user view
This is in preparation of a patch that will add a more fancy picker
with JS.
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 25 Jan 2009 11:31:40 +0000] rev 976
Add simplejson folder to build.sh script.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 25 Jan 2009 11:31:15 +0000] rev 975
Add simplejson library to app folder.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 25 Jan 2009 09:10:23 +0000] rev 974
Removed unused method from access.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 25 Jan 2009 00:04:11 +0000] rev 973
Do not pass around request anymore in buildSidebar
It is no longer needed since checkAccess doesn't require it.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 25 Jan 2009 00:02:41 +0000] rev 972
Remove the request and arg parameter from the checkAccess call
They are obsolete with the introduction of kwargs (args was never
needed in the first place).
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 25 Jan 2009 00:01:19 +0000] rev 971
Use getSingleton in getUniversalContext
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 24 Jan 2009 23:56:34 +0000] rev 970
Use ugettext instead of ugettext_lazy
Reports from Matthew Wilkes indicate that the regular form of
ugettext works just fine. The downside of ugettext_lazy is that it
prevents pages containing ugettext_lazy-ed text cannot be memcached,
since they cannot be pickled.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 21:38:28 +0000] rev 969
Brown paper bag fix.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 20:51:51 +0000] rev 968
Fixed a bug in _editPost for club_admin and host.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 20:44:32 +0000] rev 967
Changed clean_url to work with dynaform.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 20:17:35 +0000] rev 966
Fixed a bug in _oncreate in soc/logic/models/club.py.
Non-existing fields were set.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 18:21:50 +0000] rev 965
Changed user_logic call to it's convenience function getForCurrentAccount.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 17:09:02 +0000] rev 964
Coding style fix in views/models/role.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 17:07:26 +0000] rev 963
Parameterized patterns in role.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 16:39:34 +0000] rev 962
Added request creation and processing to role.py.
This is used if you want to request to become a certain role for a group. For instance becoming a club member.
The process request view will also be used to cancel outstanding invites might this be necessary.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 14:14:14 +0000] rev 961
Add Madhusudan.C.S to AUTHORS. Fix docstring parameters list in soc.logic.models.base module Base class getForFields method.
Patch by: Madhusudan.C.S
Reviewed by: Pawel Solyga
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 14:14:11 +0000] rev 960
Added checkCanProcessRequest in access.py.
This is used in the upcoming Request patch.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 12:54:59 +0000] rev 959
Some style guide fixes, docstring fixes and removal of unused imports in different modules. Rename acceptInvite view variable to accept_invite in soc.views.models.host module to comply to our style guide.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 12:51:47 +0000] rev 958
Fix some missing dots in access and club_admin modules.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 12:50:59 +0000] rev 957
Add missing parameter description to docstring of soc.views.models.base module methods.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 12:47:21 +0000] rev 956
Make select link in _as_table_row.html a nice button instead of <a href>.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 12:45:57 +0000] rev 955
Remove extra whitespaces and fix too long lines in soc.logic.helper.request module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 11:25:15 +0000] rev 954
Remove unused imports from soc.models.club_admin model.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 11:24:45 +0000] rev 953
Remove extra blank lines in soc.views.models.request module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 11:24:07 +0000] rev 952
Rename acceptInvite view variable to accept_invite to comply to our style guide. Remove unused imports. Add missing blank lines in soc.views.models.club_admin module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 11:12:07 +0000] rev 951
Rename processInvite view variable to process_invite to comply to our style guide. Remove some not needed whitespaces. Fix listSelf method parameters docstring in soc.views.models.request module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 11:10:22 +0000] rev 950
Added missing dot to access.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 11:07:16 +0000] rev 949
Check if timeline exists and when somebody tries to edit non existing timelime display error message. Add TODO regarding error message customization for Timeline. Add support for calendar widget in timeline for both gsoc and ghop programs (gsoc was hardcoded before).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 11:04:15 +0000] rev 948
Add missing blank lines and remove unused checkIsInvited function from soc.views.helper.access module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 10:59:28 +0000] rev 947
Rename soc/request/list/row.html template column class "to" to "for" since the name changed in header template.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 10:57:53 +0000] rev 946
Add missing dots in soc.views.helper.redirects module function docstrings.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 24 Jan 2009 10:56:18 +0000] rev 945
Little change in soc.logic.hlper.request module completeRequestForRole function docstring.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 10:19:17 +0000] rev 944
Refactored invite system from club_admin to role to make the system work with host as well.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 10:18:30 +0000] rev 943
Fixed an access related bug in checkIsClubAdminForClub.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 24 Jan 2009 00:27:36 +0000] rev 942
Fixed bug in access.py concerning host checks.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 24 Jan 2009 00:07:34 +0000] rev 941
Add a warning about discarding unsaved changes
Also set the colspan of the label (on seperate row) to max.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 23:42:07 +0000] rev 940
Changed the access checks to comply with state in request.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 22:57:10 +0000] rev 939
Make reference picker work for create too
Caveat, it only works for one reference atm.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 22:20:20 +0000] rev 938
Brown paper bag fix
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 22:17:49 +0000] rev 937
Do not crash if an invalid field name is entered
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 21:22:09 +0000] rev 936
Enable pick links for all the references we have
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 21:20:33 +0000] rev 935
Adust the as_table tag to render a pick link if appropriate
The templates are adjusted to pass on a 'reference' value, which
is the url_name of the view from which the entity should be picked.
The as_table (and related) function(s) construct and then pass on
this argument and enable takes_contex so that we have access to the
context of the enclosing template.
We only extract ReferenceProperties that end with '_link_id' since
that is how all RP's are currently named. It is not possible to
create a field with the same name as the RP, as GAE will try to
interpret it's contents as the key of an entity before even calling
any function we can override.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 21:18:39 +0000] rev 934
Add a 'pick' view to the appropriate views
Only views that represent entities that are pointed to by a
ReferenceProperty at some point are considered 'appropriate'.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 21:17:01 +0000] rev 933
Added a 'pick' view
This view can be used to pick a specific document and then redirect
to another view.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 21:15:16 +0000] rev 932
Add redirects for the new pick view
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 21:04:45 +0000] rev 931
Add a simple access check for a picker
The picker page should not be accessible if the required GET args are
not present.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 17:51:35 +0000] rev 930
Added missing changes from r1522.
Eclipse found it funny not to save resources ^_^.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 17:41:30 +0000] rev 929
Renamed redirect methods to comply with the rest of the module.
Added use for getInviteAcceptedRedirect in the soc/views/models/request.py process_invite view.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 17:07:54 +0000] rev 928
Replaced the boolean properties in soc/models/request.py with a state property.
new : new Request
group_accepted : The group has accepted this request
completed : This request has been handled either following a creation of the role entity
rejected : This request has been rejected by either the user or the group
ignored : The request has been ignored by the group and will not give the user access to create the role
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 16:54:46 +0000] rev 927
Restore context in deny() page
Now that we know when the sidebar is doing the access checks we can
safely construct a new context in deny (without having to worry that
it will try to do more access checks that result in deny, which will
call for a new context... etc).
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 16:53:19 +0000] rev 926
Bugfixes to last commit
Access rights for 'home' pages and an errornous endif tag.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 16:23:01 +0000] rev 925
Removed club property from club_admin model.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 16:21:28 +0000] rev 924
Generate proper html instead of having nested <td> tags
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 15:32:58 +0000] rev 923
Hook up the 'home' view for site and program
Also point to it in the sidebar's "home" link.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 15:31:13 +0000] rev 922
Generate the 'edit settings' link dynamically
We used to point to '/site/edit', which is rather lame for a generic
presence template (especially since site has it's own template).
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 23 Jan 2009 15:29:42 +0000] rev 921
Create a new 'home' view for Presences
This also restores the 'show' view for Presences as there is no
need to hide it with the 'home' view anymore.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 12:00:48 +0000] rev 920
Added the new way to process invites for club_admin only.
This patch contains the separability needed to ensure that we can successfully do the access checks we need.
Host invites can for the time being only be completed by developers due to the reorganization.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 11:40:35 +0000] rev 919
Added missing comment to soc/views/models/club.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 11:39:14 +0000] rev 918
Changed the request templates to match the changes to the model.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 11:38:24 +0000] rev 917
Added missing role_verbose.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 11:36:55 +0000] rev 916
Redid removeRequestForRole to completeRequestForRole.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 11:34:58 +0000] rev 915
Added verbose role name to the request model.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 11:32:53 +0000] rev 914
Added various access methods in preperation for the new request system.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 09:08:26 +0000] rev 913
Added state property to role model.
This can be used when for instance a member has been removed from a club or a when a program has been marked inactive. Certain roles would then be shown on the upcoming roles page marked as previous roles. This would give us the archiving capability that was shown in the mockup.
Patch by: Lennard de Rijk
Reviewd by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 23 Jan 2009 08:49:09 +0000] rev 912
Renamed org property in club_admin model to club.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 22 Jan 2009 23:20:15 +0000] rev 911
Add slots and student applications/tasks limit integer properties to the Program model.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 22 Jan 2009 22:54:46 +0000] rev 910
Change build.sh to create a build/ output directory (rather than release/).
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 22 Jan 2009 22:35:41 +0000] rev 909
Move make_release.sh to build.sh.
This script creates a "build" really, not a release. A separate release.sh
script should be written to automate the current manual release process (at
some point...).
Patch by: Todd Larsen
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 22 Jan 2009 22:04:00 +0000] rev 908
Remove unused decorators import from soc.views.models.role module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 22 Jan 2009 22:03:32 +0000] rev 907
Fix idention in soc.views.models.club module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 22 Jan 2009 22:02:40 +0000] rev 906
Fix missing dots in soc.views.helper.decoratos module docstrings.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 22 Jan 2009 22:01:16 +0000] rev 905
Rename clean_existing_user_not_equal_to_current function to clean_users_not_same in soc.logic.cleaning module and fix affected files.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 22 Jan 2009 17:26:14 +0000] rev 904
Hide the 'link_id' field for site
Also construct the scope_path from the fields in case the entity
has not yet been created.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 22 Jan 2009 17:23:17 +0000] rev 903
Rename "site/settings" to "site"
The "/site/settings" view is not about the Site Settings an sich, but
more about the "site presence singleton". In this context it does not
make sense to call it "site/settings".
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 22 Jan 2009 16:05:49 +0000] rev 902
Fixed one style error and one typo.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 22 Jan 2009 16:04:48 +0000] rev 901
Presence is now a 'abstract' View, pull in members from program
This is signified by the removal of params['name'] and other values
that are required by params.py, but also by the removal of the 'view'
definition at the bottom of the file.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 22 Jan 2009 16:03:17 +0000] rev 900
Extend dicts.merge to be (optionally) recursive
This is very useful when dealing for views that expect to be
inhereted from but wish to provide default values.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 22 Jan 2009 16:01:51 +0000] rev 899
Fix form errors and hidden form errors
The conversion to django left out the 'prettyfying' of form and
hidden form errors, as these could occur when running live, restore
this behavior.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 22 Jan 2009 13:50:25 +0000] rev 898
Added a cleaning method for a LinkProperty Field.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 22 Jan 2009 00:07:36 +0000] rev 897
Fixed wrong conditional in soc/views/models/club_app.py.
Notifications will now be send again.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 22 Jan 2009 00:03:28 +0000] rev 896
Fixed import sorting and indentation in soc/views/models/club.py
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 23:44:02 +0000] rev 895
Even developers need to agree to the terms of service for Melange
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 23:43:16 +0000] rev 894
Corrected the list index parameters in soc/views/models/club_app.py
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 23:18:39 +0000] rev 893
Added Ignored applications to the list view.
Also restored the New Club notification upon application acceptance. That broke in r1483.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 22:47:22 +0000] rev 892
Replaced boolean properties in soc/models/group_app with status property.
This property has 5 choices ['accepted','rejected','ignored','needs review','completed']
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 22:21:40 +0000] rev 891
Move getToSLink() to soc.views.helper.redirects.getToSRedirect().
Fixes a circular import problem that prevented the site-wide ToS link from
being displayed by checkAgreesToSiteToS(). This is now completely implemented.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 21:41:36 +0000] rev 890
Tighten more checkIsUser() access to checkAgreesToSiteToS() instead.
Update the checkIsHost() comment.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 21:32:51 +0000] rev 889
Make checkAgreesToSiteToS() the default access check for many other checks.
Replace checkIsUser() with the more-strict checkAgreesToSiteToS(). Also, add
missing args and kwargs parameters to checkAgreesToSiteToS() that were missed
in the merge right before commit.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 21:25:18 +0000] rev 888
Add checkAgreesToSiteToS() (partially implemented until circular import fixed).
Need to fix a circular import problem before the alternate message will
include a link to the site-wide ToS Document.
Also, fixed the descriptions in the first few check...() functions.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 21:09:52 +0000] rev 887
Take advantage of new "from ... import ... as ..." rules in the style guide.
Patch by: Todd Larsen
Review by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 20:25:07 +0000] rev 886
Added clean_existing_user_not_equal_to_current to clean the backup Administrator field in an application.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 19:53:23 +0000] rev 885
Changed the redirect in club application overview to the correct page.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 19:45:13 +0000] rev 884
Changed checkIsClubAppAccepted into a more generic checkIsApplicationAccepted.
Also fixed a minor bug in club_app view.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 19:40:39 +0000] rev 883
Changed the collection name and help text for Organization member template.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 19:32:00 +0000] rev 882
Added club_app model and logic.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 18:50:22 +0000] rev 881
Added created and last modified timestamps to the group_app model.
Also edited the templates to show some extra information. The review template has the names for the new properties hard coded because the auto_add and auto_add_now datetimeproperties don't show up in the fields of the entity.
Patch by: Lennard de Rijk
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 18:25:37 +0000] rev 880
Fixed typo in r1446.
Patch by: Todd Larsen
Review by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 16:13:51 +0000] rev 879
Changes in Role model.
Clarified that we are asking for a shipping adress. Also moved Agrees to ToS to the bottom.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 16:13:18 +0000] rev 878
Fix trailing whitespace and apply decorators
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 16:13:03 +0000] rev 877
Fix whitespace damage
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 16:12:48 +0000] rev 876
Make use of the new decorators in all applicable views
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 16:12:31 +0000] rev 875
Renamed showReviewOverview to review_overview and reviewOverview
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 16:12:16 +0000] rev 874
Fixed two trivial bugs
A "kwargs=kwargs" instead of **kwargs
Missing 'and entity' check
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 16:12:01 +0000] rev 873
Added a merge_params and check_access decorator
The merge_params decorator is very simple and takes self._params and
merges it with params. It's main purpose is to explicitly mark the
views in which it is intended that self._params is merged raw.
The check_access decorator factors out the access checking process
and passes args and kwargs to the access checking methods.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 16:11:47 +0000] rev 872
Prepare access to receive args and kwargs as argument
Also use two "magic values" when the sidebar is doing the access
checks, this might be useful later.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 15:35:10 +0000] rev 871
Reverted r1457.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 15:29:58 +0000] rev 870
Changed link in club_app accepted notification.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 15:11:45 +0000] rev 869
Added a new view to help with application -> group process.
The applicant view is available only when there is an accepted application present. This will be checked by the access checker in an upcoming patch. The view uses a special form so that certain fields cannot be edited by the user. These fields correspond to important fields filled in during the application process.
Create access for a club has now been set to Host level.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 14:57:12 +0000] rev 868
onCreate for a Club now marks any application for the same club as completed and invites the admins.
This is useful for when the club has been created without using the application.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 14:36:44 +0000] rev 867
Edited the method used to clean link_id in params.py.
Removed the clean_new_link_id from the logic/cleaning.py module because this is not used anymore.
This method should be replaced by a method that is used after all the fields have been cleaned so that the actual key_name of an entity can be constructed.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 13:55:06 +0000] rev 866
Fixed a typo in the comments of soc/views/helper/forms.py
Patch by: Lennard de Rijk
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 02:39:29 +0000] rev 865
Fix missing import identified by pylint.
************* Module app.soc.logic.models.user
E0602: 99:Logic.agreesToSiteToS: Undefined variable 'db'
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 02:37:43 +0000] rev 864
Fix missing import identified by pylint.
************* Module app.soc.logic.models.presence
E0602: 56:Logic.getToS: Undefined variable 'db'
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 02:34:43 +0000] rev 863
Fix missing import identified by pylint.
************* Module app.soc.views.helper.responses
E0602:187:getToSLink: Undefined variable 'db'
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 02:31:55 +0000] rev 862
Add agreesToSiteToS() logic method to indicate if User accepts site-wide ToS.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 02:18:07 +0000] rev 861
Give error messages more room in the existing form field "as_table" templates.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 02:14:05 +0000] rev 860
Add a clean_agrees_to_tos() validator that requires "Yes" if ToS exists.
Also, more user_logic.logic => user_logic fixes. If you are going to import
"as", you might as well make the renaming worthwhile. Maybe we need to add
a section on "import ... from ... as ..." in the style guide?
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 00:32:05 +0000] rev 859
Change "Show" to "Export" missed in r1446 commit.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 00:27:39 +0000] rev 858
Add an export() view, and implement it as text/text for Document.
For every Model except Document, the public() view is displayed for any
attempts to access the export() view.
Currently, the permissions for export() are the same as for public(). This
seems reasonable for Document, since anyone could extract the raw HTML from
the page source anyway. The permissions should probably be different for
other types of exports, such as vCard or iCard exports of profiles, CSV
exports of lists, etc.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 23:13:03 +0000] rev 857
If a site-wide ToS exist, display the User profile "Agrees to ToS" checkbox.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 23:01:24 +0000] rev 856
Set agrees_to_tos example text to link to site-wide ToS (or a warning message).
Also, since a renaming import statement is being used already, change
user_logic.logic to just user_logic.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 22:33:43 +0000] rev 855
Do not crash on *every* page load if there is no ToS Document.
'tos' ReferenceProperty might be present, but still be None.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 22:30:21 +0000] rev 854
A better way to add site-wide ToS link to *all* pages on the site.
getUniversalContext() already fetches a copy of the Site settings, so use that
to see if the site-wide ToS exist and produce a link.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 22:21:32 +0000] rev 853
Linux /bin/sh (GNU) is not the same as OS X /bin/sh (BSD), so use /bin/bash.
Fixes:
scripts/pylint/do_pylint.sh: 27: Syntax error: "(" unexpected
on Ubuntu (and possibly other Linux distros).
Patch by: Todd Larsen
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 22:01:02 +0000] rev 852
Replace css class 'notice' that is used in User profile template field help text with new 'fieldhelptext' class. Notice is part of CSS for notification bar and we want width limit just for field help text not for notification bar text.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 21:48:28 +0000] rev 851
Add getSingleton() method to return the Site settings entity.
There is always only one Site entity, referred to by DEF_SITE_LINK_ID.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 21:37:30 +0000] rev 850
Return the ToS Document of the supplied Presence entity, if there is one.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 21:26:34 +0000] rev 849
Support HTML tags in form field example_text column.
Improve the Program Model example_text as an example.
Patch by: Todd Larsen
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 21:00:55 +0000] rev 848
Disable R0801 messages in pylintrc. R0801 messages indicates that a set of similar lines has been detected among multiple file. This usually means that the code should be refactored to avoid this duplication but in our case it's useless since it shows a lot of imports code or authors.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 20:52:12 +0000] rev 847
Add calendar widget support for timeline fields. Fix docstring typo in soc.views.models.timeline module. Add timeline edit template which loads necessary javascript files for datetimepicker widget.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 20:49:49 +0000] rev 846
Remove member_template from extra_dynaexclude in soc.views.models.club since member_template is only available in Organization as of recent commit.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 20:16:07 +0000] rev 845
Add the agrees_to_tos property to Roles (as its own changeset this time...).
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 20:04:21 +0000] rev 844
Make getToSLink() an actual method for re-use by others.
Uses the views.helper.redirects module to create the /document/show path,
instead of hard-coding it as a format string.
Patch by: Todd Larsen
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 20 Jan 2009 19:40:41 +0000] rev 843
Fixed EOL and whitespace damage
Patch by: Sverre Rabbelier
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 17:56:10 +0000] rev 842
This file should not have been included in r1428. Reverting...
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 17:53:36 +0000] rev 841
Changing ReadOnlyBool to type "text" makes it display "True" or "False".
Patch by: Todd Larsen
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 20 Jan 2009 17:41:47 +0000] rev 840
When constructing the sidebar don't overide 'sidebar'
Instead specify 'sidebar_additional' and include it even if there
is a 'sidebar' defined.
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:31:53 +0000] rev 839
Add datetimepicker javascript widget files and css file.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:27:36 +0000] rev 838
Set notice width to 450px. It was way too long. Notice is displayed with help text on yellow background in User profile.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:12:55 +0000] rev 837
Add missing blank line in soc.views.helper.params module. Fix docstring typo in soc.views.models.role module. Add missing dots at the end of sentences in soc.logic.cleaning and soc.view.models.user_self modules.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:10:04 +0000] rev 836
Add missing 'of' word to list description strings in soc.views.models.club_app module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:09:09 +0000] rev 835
Add missing blank lines and dots in soc.views.helper.templatetags.forms_helpers module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:08:16 +0000] rev 834
Move member_template property from Group to Organization model since it's Organization specific property.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:03:55 +0000] rev 833
Disable R0201 message in pylintrc since we allow for that kind of methods. R0201 tells us that method could be a function. Used when a method doesn't use its bound instance, and so could be written as a function.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 16:00:19 +0000] rev 832
Fix typo in settings.py (missing '>' character).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 15:59:07 +0000] rev 831
Add missing dots in docstrings. Add sendNotification parameters description to docstring in soc.logic.helper module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 20 Jan 2009 14:12:54 +0000] rev 830
Added missing import to views/models/notification.py
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 20 Jan 2009 14:09:39 +0000] rev 829
Users now have the right to delete their own notifications.
Patch by: Lennard de Rijk
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 13:19:45 +0000] rev 828
Load /Users/solydzajs/Downloads/google_appengine into
trunk/thirdparty/google_appengine.
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 20 Jan 2009 01:12:43 +0000] rev 827
Split the notification list in read/unread
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 20 Jan 2009 00:48:49 +0000] rev 826
Add an unread count indication next to the notification link
Similar to how this is done in gmail.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 20 Jan 2009 00:48:30 +0000] rev 825
Use 'from .. import .. as ..' in user_self
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 20 Jan 2009 00:48:16 +0000] rev 824
Fixed whitespace and EOL damage
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 20 Jan 2009 00:11:38 +0000] rev 823
Add a 'pending/accepted/denied' seperation to club_app list
This is not only to make it easier to see which applictions have been
accepted, but also to make it possible to redirect to /club/create
for the accepted applications, rather than to /club_app/edit.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 20 Jan 2009 00:11:21 +0000] rev 822
Fixed whitespace damage
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 19 Jan 2009 23:26:09 +0000] rev 821
Send a notifcation if a club application is accepted
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 19 Jan 2009 23:25:49 +0000] rev 820
Factor out sendNotification from sendInviteNotification
This makes it easier to create different types of notifications,
such as a sendNewClubNotification.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 19 Jan 2009 23:25:36 +0000] rev 819
Fixed whitespace and EOL damage
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 19 Jan 2009 23:25:23 +0000] rev 818
Fixed whitespace damage
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 19 Jan 2009 16:23:37 +0000] rev 817
Added club_admin templates.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 16 Jan 2009 17:54:46 +0000] rev 816
Added Mario Ferraro to the AUTHORS list.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 16 Jan 2009 17:52:42 +0000] rev 815
Tooltips now properly disappear when another text box with a tooltip has been highlighted.
Also known as Issue 132.
Patch by: Mario Ferraro
Reviewed by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 15 Jan 2009 17:01:15 +0000] rev 814
Implement the checkIsClubAppAccepted function
Also added a stub for checkIsClubAdminForClub.
Patch by: Sverre Rabbelier
Todd Larsen <tlarsen@google.com> [Wed, 14 Jan 2009 22:37:05 +0000] rev 813
Display state (but dis-allow edits) of User's agrees_to_tos boolean Property.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 14 Jan 2009 22:30:24 +0000] rev 812
Add read-only boolean form field widget.
Developers should be able to view, but not change, the User's agrees_to_tos
state.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 14 Jan 2009 22:02:39 +0000] rev 811
Add "agrees to site-wide Terms of Service" boolean property for all Users.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 14 Jan 2009 20:37:56 +0000] rev 810
Hide 'tos' pull-down selector from Program profile forms.
Until a way to select Documents for use as the Terms of Service for a Program
exists (see http://code.google.com/p/soc/issues/detail?id=151), there is no
point in hacking in scope_path and link_id fields here. The per-Program ToS
feature will just be unavailable until an appropriate Document selector
exists.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 14 Jan 2009 20:37:47 +0000] rev 809
Hide 'tos' pull-down selector from Group profile forms.
Until a way to select Documents for use as the Terms of Service for a Group
exist (see http://code.google.com/p/soc/issues/detail?id=151), there is no
point in hacking in scope_path and link_id fields here. The per-Group ToS
feature will just be unavailable until an appropriate Document selector
exists.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 14 Jan 2009 20:37:34 +0000] rev 808
Hide 'tos' pull-down selector from Site Settings forms.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 14 Jan 2009 20:37:24 +0000] rev 807
Hack in tos_scope_path and tos_link_id to select Terms of Service Document.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 14 Jan 2009 20:05:15 +0000] rev 806
Show Terms of Service link in footer if tos_link is defined in the context.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 14 Jan 2009 20:05:05 +0000] rev 805
Add a ReferenceProperty pointing to a Terms of Service Document.
Patch by: Todd Larsen
Review by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 10 Jan 2009 19:11:34 +0000] rev 804
Fixed a bug that was triggered on manual club creation without an application.
Now also sets the application_completed flag upon club creation.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 10 Jan 2009 18:56:54 +0000] rev 803
Fixed missing params in views/models/club_app.py.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 10 Jan 2009 18:18:10 +0000] rev 802
Added Club Admin model, logic, and view
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 10 Jan 2009 18:17:44 +0000] rev 801
Invite (backup-)admin when creating a club
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 10 Jan 2009 18:17:30 +0000] rev 800
Added a create method that uses an existing application
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 10 Jan 2009 18:17:16 +0000] rev 799
Construct names automatically from base name.
Saves a lot of typing for the common case
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 10 Jan 2009 14:49:45 +0000] rev 798
Fixed a wrong method being called when accepting/declyning an application.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 10 Jan 2009 14:44:04 +0000] rev 797
Added basic review functionality for club applications.
The access rights are open for discussion.
The review page uses GET data to determine the decision made by the user.
For convenience the Review Club Applications button directs you to a multi-list view so you can see the state of different applications.
The review state will reset whenever the application has been changed using the edit form.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 10 Jan 2009 14:14:38 +0000] rev 796
Fixed a typo in the comment in helper/access.py.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 10 Jan 2009 13:50:41 +0000] rev 795
Added control fields to group_app.
Moved unnecessary fields containing questions about past participation from group_app to org_app.
Updated the club_app public page to show the correct information using twoline layout.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 10 Jan 2009 13:28:04 +0000] rev 794
Added _readonly_field_as_twoline_table_row .
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 08 Jan 2009 21:44:03 +0000] rev 793
Resolved a bug when editing a timeline.
Scope path is now set correctly when editing a timeline.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 08 Jan 2009 21:24:36 +0000] rev 792
Fixed line-ending and whitespace damage
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 08 Jan 2009 21:24:27 +0000] rev 791
Added the club_app view, logic and model
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 08 Jan 2009 21:24:10 +0000] rev 790
Removed unneeded params from club
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 08 Jan 2009 21:23:52 +0000] rev 789
Moved the member_template field to app and removed 'optional'
Also shortened the verbose_name of the member_template field.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 08 Jan 2009 21:23:42 +0000] rev 788
Factored out the clean_existing_user method
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 08 Jan 2009 21:23:33 +0000] rev 787
Fix login link
Without the leading slash the link does not work on appspot.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 08 Jan 2009 21:23:24 +0000] rev 786
Fixed a typo in the group_app model
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 08 Jan 2009 21:23:15 +0000] rev 785
Added a twoline_edit.html page
An as_twoline_edit template tag was added for this purpose. This tag
renders the label field on a seperate line.
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 08 Jan 2009 20:27:21 +0000] rev 784
Fix missing dots at the end of sentences in docstring and fix wrong import sorting in soc.logic.helper.notifications module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 08 Jan 2009 20:09:24 +0000] rev 783
Extract BSD license text into a separate file to make it easier to find.
Patch by: Todd Larsen
Review by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 08 Jan 2009 17:22:37 +0000] rev 782
Fixed missing files in r1364.
Patch by: Lennard de Rijk
Augie Fackler <durin42@gmail.com> [Thu, 08 Jan 2009 15:31:41 +0000] rev 781
Fix the setup of the test environment, including clearing the datastore
between tests.
Augie Fackler <durin42@gmail.com> [Thu, 08 Jan 2009 15:31:33 +0000] rev 780
Add support for coverage to our testing system.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 07 Jan 2009 22:09:52 +0000] rev 779
Added support for creating clubs.
Patch by : Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 07 Jan 2009 21:58:43 +0000] rev 778
Added support for mutliple edit forms based on entity type
This makes it possible to have different edit forms in timeline based
on which workflow type is used.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 07 Jan 2009 21:57:48 +0000] rev 777
Added an 'edit timeline' button to the program edit page
Also made the create timeline functionality use the logic modules
introduced in the previous commit.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 07 Jan 2009 21:57:12 +0000] rev 776
Started on edit timeline
Added a gsoc timeline logic module. Also added a scope_path as the
key_field to timeline. Updated the django_paterns to only include
the edit field and removed link_id as dynafield.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 07 Jan 2009 20:56:50 +0000] rev 775
Fixed missing import in soc/models/organization.py.
Patch by: Lennard de Rijk
Todd Larsen <tlarsen@google.com> [Wed, 07 Jan 2009 20:30:38 +0000] rev 774
Add hard-coded GroupApplication and OrgApplication Models.
These are being hard-coded because the "real" Question/Answer/Quiz/Response
implementation will not be ready any time soon.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 07 Jan 2009 20:24:38 +0000] rev 773
Mailing list EmailProperty should be StringProperty instead, so that it is
possible, for example, to supply a Google Group URL for sign-up purposes.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 07 Jan 2009 19:38:29 +0000] rev 772
Add IRC channel and mailing list properties to the Group and Organization
Models.
Patch by: Todd Larsen
Review by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 07 Jan 2009 16:49:16 +0000] rev 771
Typo and style fixes.
Patch by: Pawel Solyga and Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 06 Jan 2009 21:21:09 +0000] rev 770
Fixed a bug where a new timeline would get created on every edit of an existing program.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 06 Jan 2009 20:56:48 +0000] rev 769
Added an elementary workflow choosing method to program creation.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 06 Jan 2009 17:26:06 +0000] rev 768
Added logic and view classes for the Timeline model
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 06 Jan 2009 17:25:54 +0000] rev 767
Sorted build.py's sitemap.addPages lines
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 06 Jan 2009 16:55:27 +0000] rev 766
Made Program reference Timeline
Also made Timeline inherit from base like it should.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 06 Jan 2009 16:01:16 +0000] rev 765
Copy/paste fix
Typo fix: s/founder/program
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 06 Jan 2009 00:14:32 +0000] rev 764
Added a basic Timeline model
The timeline model will contain the deadlines and time ranges for the
individual programs.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 29 Dec 2008 18:51:36 +0000] rev 763
Set no_create_with_key_fields paramater to True for Notifications.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 18 Dec 2008 09:52:20 +0000] rev 762
Revert "Overwrite default patterns in views/models/notification.py to disallow certain URL's."
This should instead be done by setting the no_create_with_key_fields
parameter to True.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 18 Dec 2008 09:52:04 +0000] rev 761
Allow disabling of the create url with key_fields
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 18 Dec 2008 07:02:48 +0000] rev 760
Overwrite default patterns in views/models/notification.py to disallow certain URL's.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 17 Dec 2008 22:27:55 +0000] rev 759
Fixed a too long line in logic/helper/notifications.py
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 17 Dec 2008 22:25:16 +0000] rev 758
Added base template for notification messages.
This makes the messages a bit more friendly by including a greeting and signature.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 17 Dec 2008 22:15:21 +0000] rev 757
Added email message when receiving a notification.py
At the moment this only triggers when the new notification is your first unread message. Also fixed an url bug in the invite notification.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 17 Dec 2008 19:33:03 +0000] rev 756
Changed invitation email and into a notification.
Also changed the public template for Notification to allow HTML code.
Patch by: Lennard de Rijk
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 01:15:32 +0000] rev 755
Remove unused imports and variables in different soc.views.models modules.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 01:13:07 +0000] rev 754
Remove unused import in soc.views.hlper.templatetags.forms_helpers module.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 01:12:28 +0000] rev 753
Since DbModelForm has been renamed to BaseForm change super() call from BaseForm to djangoforms.ModelForm in soc.views.helper.forms module.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 01:11:12 +0000] rev 752
Some docstring fixes and unused import removal in soc.logic.models.site module.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 01:10:32 +0000] rev 751
Fix inheritance in soc.models.base module. FieldsProxy inherited from DbModelForm which was deleted in previous commits (replace that with BaseForm).
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 01:08:16 +0000] rev 750
Fix too long lines in soc.logic.helper.notifications module.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 01:07:18 +0000] rev 749
Remove unused import in soc.logic.accounts module.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 01:06:13 +0000] rev 748
Remove unused imports in models modules.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 00:34:46 +0000] rev 747
In soc.views.models.notification module remove unused imports, add missing white space, change list() method definition to comply with base View list() method declaration. Add missing Meta class docstring.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 00:24:24 +0000] rev 746
Fix import sorting in soc.views.helper.access module and rename 'host' to 'Program Administrator'.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 00:22:50 +0000] rev 745
Remove not used TYPE_NAME, TYPE_NAME_SHORT and TYPE_NAME_PLURAL consts in all Group models.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 15 Dec 2008 00:21:26 +0000] rev 744
Add missing dots, fix imports sorting and too long lines in different modules. Add TODO in soc.views.models.host module.
Patch by: Pawel Solyga
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 14 Dec 2008 00:51:03 +0000] rev 743
Have user/edit.html use the as_table tag as well
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 14 Dec 2008 00:50:49 +0000] rev 742
Removed unused template
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 14 Dec 2008 00:33:59 +0000] rev 741
Converted as_table to be a template tag
This allows us to move all the HTML from python code (which made it
extremely icky and unreadable) to Django templates, which is _a lot_
more readable, and makes it feasable for HTML/CSS experts to change
the way these tables are generated.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 14 Dec 2008 00:33:41 +0000] rev 740
Added some example_text to program
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 14 Dec 2008 00:33:29 +0000] rev 739
Added support for example texts
Initial patch by Benjamin, some minor fixes by Sverre.
Patch by: Benjamin Lyaunzbe, Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 18:21:35 +0000] rev 738
Brown-paper-bag fix in notification.py
Was missing a leading slash in the redirect.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 13 Dec 2008 14:55:00 +0000] rev 737
Notification property has_been_read changed into unread
Due to comments on r1309.
Patch By: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 13:28:01 +0000] rev 736
No override needed in notifications.py
The only downside is that the ?s=0 parameter will still be appended
but is not handled in list(). The right solution would be to update
list() so that it does say "Message Sent" or such, to give the user
an indication that their message was sent succesfully.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 13:27:40 +0000] rev 735
Make it possible to redirect anywhere after editPost
This makes it possible to not include the suffix in the redirect by
making it a named parameter.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 13:09:06 +0000] rev 734
Make the place of the rights declaration consistent
Other code places it at the top, so we should do that in notification
as well.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 13:08:45 +0000] rev 733
Remove custom override of django_patterns_defaults
Instead restrict access to the edit method, also, there is no need to
set the default access to allow.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 13:08:23 +0000] rev 732
Fix whitespace and EOL damage in notifcation.py
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 12:49:57 +0000] rev 731
Make use of readonly_field_as_table_row
Instead of manually typing out the <br /> etc.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 12:49:34 +0000] rev 730
Fix EOL-damage
We use \n for line endings, so remove the \r from public.html
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 12:49:11 +0000] rev 729
Make checkIsMyInvitation use Django to parse the URL
Using django is more reliable and makes the code easier to read as
there is no knowledge of the url layout required.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 13 Dec 2008 12:48:49 +0000] rev 728
Added a readonly_multiline_field_as_table_row tag
This is useful when a field is allowed to include newlines.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 13 Dec 2008 11:02:08 +0000] rev 727
Using getForCurrentAccount where possible due to comments on r1309.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 12 Dec 2008 23:28:18 +0000] rev 726
Added Notifications.
Notifications will primarily be used to serve the user information message like "New Request Pending". The system can be expanded later on to a messaging system.
If you are a developer you can create message by going to notification/create . This has been done so the system can easily be tested. But will of course be visible in an easy-to-access location when the transition to a message system has been made.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 12 Dec 2008 00:35:51 +0000] rev 725
Filter the "list Hosts" view
This way only those Hosts are shown that belong to a Sponsor the
user is a host for.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 12 Dec 2008 00:35:28 +0000] rev 724
Allows a user object to be passed to accounts.isDeveloper
This saves a trip to the database if the user object has already
been retrieved.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 12 Dec 2008 00:35:08 +0000] rev 723
Make getForFields use the db.Query API
While at it, add support for the IN statement in the form of a value
of the list type.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 12 Dec 2008 00:34:39 +0000] rev 722
Added getForCurrentAccount to user.Logic
It returns the user entity associated with the currently logged in
user.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 12 Dec 2008 00:34:12 +0000] rev 721
Added a filter method to dicts
The best way to explain this is probably with an example:
>>> split({'foo':'bar', 'bar':['one', 'two'], 'baz': ['three', 'four']})
[{'bar': 'one', 'foo': 'bar', 'baz': 'three'},
{'bar': 'two', 'foo': 'bar', 'baz': 'three'},
{'bar': 'one', 'foo': 'bar', 'baz': 'four'},
{'bar': 'two', 'foo': 'bar', 'baz': 'four'}]
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 11 Dec 2008 20:54:22 +0000] rev 720
Make it possible to invite another Host as Host
We do this by asking Django to resolve the current url for us, then
reshufle that url and ask Django (again) to resolve that new url.
From that resolved url we know the appropriate view, and as such we
know which rights dictioanry to pass to access.checkAccess.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 11 Dec 2008 20:53:57 +0000] rev 719
Added a trivial unzip method, counterpart to zip
Patch by: Sverre Rabbelier
Augie Fackler <durin42@gmail.com> [Thu, 11 Dec 2008 04:23:42 +0000] rev 718
Add some ignore properties for when we get working coverage support.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 10 Dec 2008 07:38:56 +0000] rev 717
Fixed missing header in site settings.
Also known as Issue 146.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 09 Dec 2008 15:43:56 +0000] rev 716
Changed "Sponsor" to "Program Owner"
Changed "Host" to "Program Administrator"
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 08 Dec 2008 17:31:33 +0000] rev 715
Adds the removal of requests from the datastore when a new role entity is created.
This uses the classname from the role entity as the type of role in the request.
Patch by: Lennard de Rijk
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 07 Dec 2008 20:25:50 +0000] rev 714
Add missing dots in docstrings, proper sorting of imports and small docstring typo fixes.
Patch by: Pawel Solyga
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 20:02:40 +0000] rev 713
Thinkofix in access.checkIsInvited
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 20:02:17 +0000] rev 712
Some forgotten changes with the access_type commit
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 07 Dec 2008 19:18:24 +0000] rev 711
Program Name column showed link_id instead of name, replace link_id with name in soc/program/list/row.html template.
Patch by: Pawel Solyga
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 19:02:41 +0000] rev 710
Add explicit access_types from the url
This does two things, it reduces the amount of repeated data (e.g.,
the checkAccess used to repeat the access_type that was already
specified in the url). At the same time, it allows for example the
'create' page to push its access_type to 'edit'.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 19:02:02 +0000] rev 709
Add checkIsHost in access
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 19:01:35 +0000] rev 708
Some cleanups in role.py and site.py and create()
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 07 Dec 2008 17:26:59 +0000] rev 707
Changed template for home/public.html to show last modified in the top-right corner.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 17:02:32 +0000] rev 706
Add site scoped documents to the Site menu
This allows for featured documents that belong to the Site scope to
show up in the 'Site' menu.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 17:02:10 +0000] rev 705
Move document sidebar entries extraction to document.View
This way other modules can benefit from the same logic. Also make use
of the sidebar.getSidebarMenu method so that getMenusForScope is no
longer specific to full menu's.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 17:01:44 +0000] rev 704
Factor out sidebar entry construction
This makes it possible to reuse this logic in other modules as well,
preventing code duplication. While at it, move additional_sidebar
merging before the other entries (additional entries should go first,
since the other entries are mostly dev-only etc).
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 15:29:37 +0000] rev 703
Rename getSidebarLinks to getSidebarMenus
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 15:29:10 +0000] rev 702
Remove bogus scope from Site
This makes Site an unscoped entity (similar to how User and Sponsor
do not have a scope).
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 15:28:36 +0000] rev 701
If an entity is unscoped, do not try to retrieve a scope
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 15:02:29 +0000] rev 700
Dynamically add sidebar items for programs
This adds sidebar items for programs as appropriate. From the docstring:
A menu item is generated for each program that is currently
running. The public page for each program is added as menu item,
as well as all public documents for that program.
Additionally, we allow access to a program's public page to everyone,
even if the user is not logged in.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 15:02:03 +0000] rev 699
Add and use a placeholder for checkIsDocumentPublic
We should somehow decide whether a document is publically viewable.
This should of course be dependant on what the document is, e.g. the
FAQ of a program should be allow(), whereas a student's application
should be checkIsMentor().
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 15:01:31 +0000] rev 698
Added a public redirect
Also some minor cleanups in the redirects code.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 13:49:22 +0000] rev 697
Prepare for callbacks that return more than one menu
This paves the way for callbacks that dynamically construct their
menu based on in-db content, such as Programs and Documents.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 13:38:53 +0000] rev 696
Make use of the 'sidebar' param for user_self
Instead of overriding getSidebarLinks we use the sidebar param since
user_self is now in it's own View.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 07 Dec 2008 13:06:26 +0000] rev 695
Fixed email adress in urls.py.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 07 Dec 2008 12:41:28 +0000] rev 694
Fixes 'module' object has no attribute 'handler500' and 404 on instances where debug is False.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 07 Dec 2008 10:23:10 +0000] rev 693
Fixed the header on the List Programs page.
Patch by: Lennard de Rijk
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 06 Dec 2008 22:34:25 +0000] rev 692
Reset the RELEASE_TAG to None (unreleased) now that the 0.1a20081206 release candidate branch has been created.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 06 Dec 2008 22:18:21 +0000] rev 691
Set RELEASE_TAG to 0.1a20081206rc for release candidate 06/12/2008.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 06 Dec 2008 21:32:36 +0000] rev 690
Fix imports sorting in soc.views.models.organization.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 06 Dec 2008 21:27:47 +0000] rev 689
Add missing dots in docstrings in modules.
Patch by: Pawel Solyga
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 06 Dec 2008 21:05:17 +0000] rev 688
Changed generic_name to group_label in models/program.py.
Also I've updated the comments and help text to explain the meaning of this field.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 19:25:01 +0000] rev 687
Updated to the latest version of upload.py
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 16:52:21 +0000] rev 686
Load ../../google_appengine_1.1.7/ into
trunk/thirdparty/google_appengine.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 06 Dec 2008 14:50:45 +0000] rev 685
Comment fixes for state in group and role model.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 14:46:19 +0000] rev 684
Fix for randomely ocurring bug
The bug and it's fix are described by the first comment from Guido
in http://code.google.com/p/googleappengine/issues/detail?id=772.
Patch by: Guido van Rossum
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 06 Dec 2008 14:44:02 +0000] rev 683
Changed state property for models/group.py to be optional as the description states.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 14:25:24 +0000] rev 682
Added organizations
Really basic for now, next stop is to have a proper document selector
for the Presences.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 14:24:50 +0000] rev 681
Cleanups in group and program
The missing super call in group prevented the scope from being set
as it should be.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 14:24:26 +0000] rev 680
Added a new create regexp in urls for just scope_path
Now that scope_path is properly defined we can add a url matching
just the scope path. This allows some other custom create regexps to
be removed/rewritten.
Note: It needs to be -after- the full key_name regexp, since for
arbitrarily nested scopes it would always match as just scope_path,
even if there are other fields needed after the scope.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 14:23:53 +0000] rev 679
Introduce dynamic scope_path regexps
Instead of relying on scope_path's being "one slash deep", we should
instead allow for either:
1. scope_paths that have a pre-defined depth
2. scope_paths that can be arbitrarily deep
We achieve 1 by setting an entities scope_logic to another logic
module. We then recursively call getScopeDepth until we get to the
topmost entity (that is, an unscoped entity).
A little different is the solution to 2, since some entities can have
an arbitrarily deep scope (such as Documents), we need to have some
way of signaling this to getScopePattern. A clean solution is to
return None, rather than a number. If None is returned, the
SCOPE_PATH_ARG_PATTERN is returned as regexp instead, which will
match an arbitrarily deeply nested scope.
The solution for 2 requires that we return None somewhere in the
scope_logic chain, the most straight forward method to do so is to
override getScopeDepth anywhere such a scope is needed and make it
return None. A more elegant solution however, is to set the
scope_logic to that module in all entities that require it.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 14:23:25 +0000] rev 678
Added a linkable logic module
The linkable logic module is used to signal the fact that the scope
of an entity can be any linkable.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 12:13:19 +0000] rev 677
Fix scope lookup for unscoped entities
As scope_logic is now always set (since r1250), we need to check if
it is None, rather than check if it exists.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 12:12:58 +0000] rev 676
Swap the order of request key fields
This will make it easier to remove scope_path as explicit key field
at some point by having it as inplicit key field for all entities.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:53:26 +0000] rev 675
Use key().name() instead of link_id
This is now possible because key_name is constructed purely from the
key fields of an entity. It is not sufficient to use just link_id,
that works only for single-scoped entities (e.g., those that either
do not have a scope, or that have a scope which itself does not have
a scope). It would break if there was an entity that has a scoped
scope (it would only include the scope's link_id in the url, which
made it impossible to look up the scope as we missed the link_id of
the scope's scope).
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:53:05 +0000] rev 674
More DI on scope_logic
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:31:08 +0000] rev 673
Partial revert
Last commit contained some changes that did not belong there, revert
them for now.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:26:15 +0000] rev 672
Some more cleanups in base.Logic
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:21:41 +0000] rev 671
Apply DI on the scope logic
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:21:01 +0000] rev 670
Removed unused file path_link_name
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:20:44 +0000] rev 669
Remove unneeded method getSuffixValues
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 05 Dec 2008 22:54:43 +0000] rev 668
Some style and typo fixes in different modules.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 05 Dec 2008 22:27:04 +0000] rev 667
Some more import sorting fixes and docstring typos in program modules and soc.views.helper.redirects module.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 05 Dec 2008 22:25:57 +0000] rev 666
Fix import sorting and docstring typos in soc.views.models.program module.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 05 Dec 2008 22:25:08 +0000] rev 665
Fix import sorting in soc.views.sitemap.build module.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 05 Dec 2008 12:24:02 +0000] rev 664
Some style fixes in soc.logic.helper.notifications module. Little changes in welcome.html template.
Patch by: Pawel Solyga
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 04 Dec 2008 10:09:38 +0000] rev 663
Make base.View.create lookup the scope if appropriate
Also re-introduce the custom description of the list selection for
the redirection.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 23:49:10 +0000] rev 662
Make use of the new generic key_name by lookup up scope_path
This way base classes do not have to look up the 'scope' property,
instead they can rely on the base class to do it for them provided
they define the 'scope_logic' param.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 23:48:33 +0000] rev 661
Change the key name to not include entity type
This allows for direct lookup by scope_path, rather than having to
do more complex things.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 23:48:10 +0000] rev 660
Introduced django_extra_patterns
This way no classes ever need to override the getDjangoURLPatterns,
which results in less code, which is also more clear (that is, it is
immediately obvious that a View adds an extra mapping if it sets
the new django_extra_patterns value, or that it overrides the mapping
when it sets django_patterns_defaults.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 21:28:16 +0000] rev 659
Make scope_path required for program
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 21:27:52 +0000] rev 658
Factor out the Group part of Sponsor
This makes it possible to reuse the Group logic.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 21:27:27 +0000] rev 657
Rename role.RoleView to role.View
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 21:27:01 +0000] rev 656
Cleanups in the views module
Mainly rename from original_params to new_params (so that the keyword
argument in the __init__ method is the same for all). Also use
super(View, self) where appropriate.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 03 Dec 2008 21:26:16 +0000] rev 655
Cleanups to the logic module
Mainly converting to super(Logic, self) and adding some missing
empty lines while at it.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 02 Dec 2008 22:05:13 +0000] rev 654
Fixed the 'New Host' link
Also removed the 'Invite Host' button from the Sponsor view now
that the link is working.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 02 Dec 2008 22:04:38 +0000] rev 653
Make the 'select entity' View generic
This allows the selection of any entity from an arbitrary View
by specifying the 'target view' and the redirect function.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 02 Dec 2008 22:04:15 +0000] rev 652
Cleanups in preparation of general selector view
Renamed LIST... to DEF_LIST since it is a global definition.
Renamed getCreateProgramRedirect to getCreateRedirect since it will
work on all entities as it uses params.
Added a getParams method to base.View
Updated selectSponsor as appropriate.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 02 Dec 2008 22:03:46 +0000] rev 651
Remove the logic parameter from getListContent
Now that params always has a 'logic' attribute, we can use that
instead of requiring that it is passed as argument.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 02 Dec 2008 20:14:14 +0000] rev 650
Changed clean_link_id to convert the input to lower characters for user comfort.
It has been changed in a couple of files, most importantly in logic/cleaning.py wich will be used by future forms to do their cleaning.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 02 Dec 2008 20:10:23 +0000] rev 649
Finish Program
Added some fields, and made TinyMCE the editor for the description
field. Also updated the public page to show these new fields.
We really need generic public views...
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 02 Dec 2008 18:48:42 +0000] rev 648
Brown paperbag fix in recent cycle breaking
Self is no longer used, 'error' should be used instead.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 02 Dec 2008 17:59:44 +0000] rev 647
Swap order of merged params to fix sponsor select view
The sponsor select view (in 'create new program') was showing the
wrong information (and also using the wrong list template) because
the order in which the params were merged was wrong way around.
This fixes that and at the same time fixes the 'instruction_text'
attribute, which should be named 'list_description' instead. At the
same time we lookup and set Sponsor as the scope of the newly
created program.
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 02 Dec 2008 17:14:18 +0000] rev 646
Remove cyclic imports by moving response method of out_of_band.Error class to soc.views.helper.responses module as errorResponse function. Apply changes to affected files.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 02 Dec 2008 11:20:08 +0000] rev 645
Remov unused import from Quiz model and add missing blank line.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 02 Dec 2008 10:44:56 +0000] rev 644
Remove Great Britain from country list. Great Britain was included as a country, although it has a country code (.gb) it's not a state. United Kingdom is correct and remains in the list.
Patch by: Matthew Wilkes
Review by: Pawel Solyga
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 01 Dec 2008 21:38:25 +0000] rev 643
Added programs
Currently the programs are somewhat of empty, but due to the
ease with which we can add new fields later, it is acceptable
to commit it in it's current form.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 01 Dec 2008 21:37:27 +0000] rev 642
Allow for extra dynamic fields for the create form
Also some minor cleanups, such as making base.Logic inherit from
object, as per the style guide.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 01 Dec 2008 21:30:01 +0000] rev 641
Fixed a styling error.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 01 Dec 2008 21:03:20 +0000] rev 640
Added User welcome message.
Added templates/soc/mail/welcome.html as a template for the message.
Also fixed a cyclic import that was about to happen in notifications.py.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 01 Dec 2008 12:37:16 +0000] rev 639
Some docstring fixes in few modules (soc.views.helper soc.views.models.base).
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 01 Dec 2008 12:35:56 +0000] rev 638
Add missing dot and correctly sort imports in soc.logic.helper.notifications module.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 01 Dec 2008 12:34:55 +0000] rev 637
Some docstring and missing blank lines fixes in soc.views.sitemap modules.
Patch by: Pawel Solyga
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 30 Nov 2008 22:30:01 +0000] rev 636
Sponsor name now shows in List Hosts.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 30 Nov 2008 22:15:39 +0000] rev 635
Moved sendInviteMessage to a new module in logic/helper/notifications.py.
Renamed sendInviteMessage to sendInviteNotification.
Removed the now obsolete imports in logic/models/request.py.
This has been done to keep the models/logic modules clean.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 30 Nov 2008 21:49:14 +0000] rev 634
Changed email address in logic/models/base.py.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 30 Nov 2008 21:28:25 +0000] rev 633
Allow developers access to anything that does a checkIsInvited.
Patch by: Lennard de Rijk
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 17:37:06 +0000] rev 632
Remove unused imports from some modules.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 17:35:48 +0000] rev 631
Fix typo and too long lines in soc.logic.models.request module.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 17:35:05 +0000] rev 630
Add missing import, remove unused import and add missing parameters to methods in soc.views.models.user_self module.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 17:06:32 +0000] rev 629
Add missing dots and fix too long line in soc.views.helper.dynaform module. Remove unused imports in soc.views.models.document module. Fix too long lines. Add missing docstring for Meta classes.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 16:46:32 +0000] rev 628
Add module docstring and license for soc, soc.models, soc.views.helper.templatetags.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 16:44:27 +0000] rev 627
Remove python-graph from thirdparty, remove check_includes script and graph folder from scripts. This functionality is (cyclic imports check) is supported by pylint automatically so we don't need that any more.
Patch by: Pawel Solyga
Review by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 16:39:18 +0000] rev 626
Fix too long lines in soc.views.models.request, remove unused imports and change pending requests list description. Remove unused imports from soc.logic.path_link_name module.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 16:36:17 +0000] rev 625
Add missing dots in soc.logic.lists module. Change method names to comply with Style Guide. Make class variable protected by adding "_" to the name of variable. Update lists templates respectively (methods name change).
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 16:32:23 +0000] rev 624
Remove unused imports in soc.views.models role, host and site modules. Add missing parameter in getDjangoURLPatters method.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 16:29:48 +0000] rev 623
Remove unused imports in soc.views.models.user and soc.views.models.sponsor modules.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 15:25:31 +0000] rev 622
Remove unused import in soc.models.task.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 15:25:07 +0000] rev 621
Fix too long lines in soc.model.work.
Patch by: Pawel Solyga
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 29 Nov 2008 23:51:24 +0000] rev 620
Put the redirects in the views/helper/redirects.py module.
Changed the getCreateRequestRedirect to comply with the new signature. Also changed it's docstring to a more suitable one.
Fixed a useless merge in views/models/role.py in the process.
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 22:48:15 +0000] rev 619
Style fixes for previous commit
We also need to run pylint.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 29 Nov 2008 22:36:51 +0000] rev 618
Added invitation received message upon creating a new invite.
Moved the inviteAcceptedRedirect into the logic code. Added a TODO for further user notification upon creating a request.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 21:58:34 +0000] rev 617
Now invited users can create a new Host profile
Before the invited user had to be a developer for this to
work. Now, instead the default checkIsDeveloper check for
the 'edit Host', a custom checkIsInvite check is used.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 21:21:04 +0000] rev 616
Fixed requests not working anymore
We really need a test suite.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 21:04:09 +0000] rev 615
Fixed a bug in latest commit
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 19:45:19 +0000] rev 614
Moved getSidebarLinks to sitemap.sidebar
This is the fourth, and final patch, that attempts to
improve the cohesion in the base.View class.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 19:44:48 +0000] rev 613
Moved getDjangoURLPatterns to sitemap.sitemap
Third commit in a series that aims to improve the cohesion
in the base.View class.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 19:00:03 +0000] rev 612
Moved checkAccess and getCleanedFields into access and forms
A second patch in an effort to increase the cohesion in the
base.View class.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 18:30:58 +0000] rev 611
Move parameter construction into a seperate module
This is part of an effort to make base.py less bloated
and have it's methods be more cohesive.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 17:20:52 +0000] rev 610
Documented params usage in soc/views/models/base.py
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 29 Nov 2008 14:41:43 +0000] rev 609
Fixed AUTHORS to comply with the specified format
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 29 Nov 2008 13:44:02 +0000] rev 608
Added _onCreate _onUpdate and _onDelete methods to logic/models/base.py.
These methods can be overwritten by other logic/models/ modules to serve as a way to for instance send out an update message.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 29 Nov 2008 11:26:04 +0000] rev 607
Fixed typo in docstring.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 00:12:47 +0000] rev 606
Make forms generic
Currently only Sponsor uses the new generic forms, as such this
makes the form code more complex. The other forms, however, can
be converted in a similar way, which will result in a lot of
code reduction.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 00:12:16 +0000] rev 605
Made _logic a param
The _logic parameter is added in base.py to make this as small and
non-intrustive change.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 28 Nov 2008 23:08:14 +0000] rev 604
Added Lennard to the AUTHORS file
Long overdue patch, perhaps we should add a test to the test suite
to check if all authors are propertly credited in AUTHORS...
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 28 Nov 2008 22:49:26 +0000] rev 603
Make Sponsor use the new DynaForm module
Currently only a slight reduction in code, but hopefully some
(or all?) of the form's definition can move up into base.View.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 28 Nov 2008 22:49:03 +0000] rev 602
Added a DynaForm module
This allows GAE forms to be defined 'semi' dymamically, rather than
by having to explicitly create the new class.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 28 Nov 2008 22:48:41 +0000] rev 601
Added a cleaning module
This module is the start of a (hopefully more generic) set of
cleaning functions that can be used in the GAE forms.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 28 Nov 2008 08:24:57 +0000] rev 600
Apache license and __author__ added. Also added a todo for the __doc__ string.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 27 Nov 2008 23:41:08 +0000] rev 599
Moved check_includes and graph from app to scripts
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 27 Nov 2008 23:40:30 +0000] rev 598
Change command parsing and do file walking manually
Also print warnings to stderr
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 27 Nov 2008 21:57:24 +0000] rev 597
Proper working implementation of a cycle detection algorithm, that
returns the cycles (rather than printing them) by constructing the
path between the two nodes that were found to be cyclic.
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 27 Nov 2008 17:22:39 +0000] rev 596
Fix some typo in logic.models.base.
Patch by: Pawel Solyga
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 26 Nov 2008 23:56:35 +0000] rev 595
Added rudementry include checker
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 26 Nov 2008 23:56:19 +0000] rev 594
Added the python-graph module
http://code.google.com/p/python-graph/
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 26 Nov 2008 23:55:10 +0000] rev 593
Removed cruft from the tests directory
The current tests were outdated (they tested code that no longer
exists), and were causing the test suite (insofar as it deserves
that name) to fail for no reason.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 26 Nov 2008 23:54:40 +0000] rev 592
Fixed an outstanding TODO for tlarsen
A nice side-effect is that accounts now does not depend on
out_of_band, sadly that does not fix the cyclic dependency, but it is
a nice side-effect nonetheless.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 26 Nov 2008 21:34:11 +0000] rev 591
Lists now use plural_name instead of name in the description.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 26 Nov 2008 20:50:56 +0000] rev 590
Created a seperate module for editSelf things
This improves the coherency in the user module, while at the same
time making it easier to set proper access control for the editSelf
related pages.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 26 Nov 2008 16:33:36 +0000] rev 589
Fixes empty spaces appearing in the menu if a person is not allowed to see this menu or if no menu is defined.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 26 Nov 2008 15:52:38 +0000] rev 588
Fixes an error that occurs when moving the document by setting another link ID or Scope path. This is due to the fact that author is a required property in the Work model.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 25 Nov 2008 23:16:32 +0000] rev 587
Fixed some access related bugs
These were not obvious previously, but with the sidebar not showing
up when one does not have access, they stood out.
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 25 Nov 2008 17:19:37 +0000] rev 586
Make the sidebar dynamic depending on the user's rights
This is done by doing the usual access checks that are also called
when the user actually visits the page.
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 25 Nov 2008 17:18:57 +0000] rev 585
Have the sidebar be rebuilt on every request with callbacks
This makes is possible for the sidebar constructing to take
into account the current users privilidges etc.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 24 Nov 2008 22:34:56 +0000] rev 584
Adds and uses a modified_by property in models/work.py
This property is used to display the user who last edited the work in the document viewer.
Fixes author being set on every edit.
Also edited the style-sheet to fix issue i128.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 24 Nov 2008 18:31:46 +0000] rev 583
Fills in the Founded By box in edit sponsor with the user's public name
Fixes Founded By being overwritten on edit by another user.
Patch by: Lennard de Rijk
Todd Larsen <tlarsen@google.com> [Sun, 23 Nov 2008 18:48:28 +0000] rev 582
Set trunk RELEASE_TAG back to None after creation of 0.0a20081123rc release
candidate branch.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Sun, 23 Nov 2008 18:45:04 +0000] rev 581
Attempt number two at a release process, with correct usage of /tags/ this
time around.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Sun, 23 Nov 2008 07:38:00 +0000] rev 580
Reset the RELEASE_TAG to None (unreleased) now that the 0.0a20081123 release
tag has been created. Add some release instructions to the soc/release.py
__doc__ string.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Sun, 23 Nov 2008 07:25:31 +0000] rev 579
Display '(unreleased)' as a link to trunk/ when RELEASE_TAG is false.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Sun, 23 Nov 2008 07:15:13 +0000] rev 578
Add release tag string, Melange "badge" image, and Google App Engine version
to base.html template.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Sun, 23 Nov 2008 06:34:22 +0000] rev 577
Provide a simple method in the Role Model class that aliases the existing
'display_name' Property to 'name'.
Patch by: Todd Larsen
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 23 Nov 2008 00:44:13 +0000] rev 576
Fixed spurious 'Invite Host' button in 'create host'
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 23 Nov 2008 00:38:35 +0000] rev 575
Fix Host invites
This fixes the UI for Host invites by hiding the fields that
are not used, and by auto-filling in the user and scope fields
based on link_id and scope_path.
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 22 Nov 2008 23:34:06 +0000] rev 574
Fixed pages for missing home page (document) links
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 22 Nov 2008 23:23:37 +0000] rev 573
Moved the custom error.html page for Site to it's proper place
Also made the error template a proper parameter instead of re-using
the edit/public template.
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 22 Nov 2008 23:08:26 +0000] rev 572
Made list pagination part of Lists
This way the pagination for one list does not affect the pagination
of a another one.
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 22 Nov 2008 22:47:10 +0000] rev 571
Remove polymodel module from repository.
Patch by: Pawel Solyga, Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 22 Nov 2008 22:46:37 +0000] rev 570
Remove polymodel folder from DEFAULT_APP_DIRS variable in make_release script.
Patch by: Pawel Solyga, Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 22 Nov 2008 22:45:14 +0000] rev 569
Remove inheritance_line from Form meta class excludes in all currently used forms.
Patch by: Pawel Solyga, Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 22 Nov 2008 22:44:02 +0000] rev 568
Remove inheritance from PolyModel in Answer and Linkable model. Replace PolyModel inheritance with base.ModelWithFieldAttributes.
A little explanation why we are trying to get rid of PolyModel. We decided to use PolyModel in order to get support for model inheritance in App Engine, however as we know this was a hacky workaround which added inheritance_line property to each model. Recent commits which added Linkable model caused our data viewer in admin console to show only one model "Linkable" since all of the classes inherited from it. Basically datastore viewer was useless plus we had a really big mess in datastore since everything was of one kind (Linkable). It's almost like creating one huge table in SQL database. Upcoming commits will eliminate all usage of PolyModel and finally remove PolyModel from our repository. We are still using inheritance however this doesn't modify how models are saved in data store so basically it's like copy and paste of properties from parent models.
Patch by: Pawel Solyga, Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 22 Nov 2008 22:30:32 +0000] rev 567
Add customized User Edit Developer view template with working listing of former accounts.
Patch by: Pawel Solyga
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 22 Nov 2008 21:33:54 +0000] rev 566
Disabled 'Home Settings' menu until we have a use for it
Also fixed a typo in the request row template that caused it
to display the wrong value.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 22 Nov 2008 21:15:21 +0000] rev 565
Removed no-longer used code
This code is no longer in use and has been replaced by
getForFields and similar methods.
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 22 Nov 2008 20:54:42 +0000] rev 564
Hide the 'home' field until we have a proper document selector
Rather than having a confusing 'home' field that lists all Linkables
(in other words, everything in the database), we're better off hiding
it for now.
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 22 Nov 2008 20:38:27 +0000] rev 563
Fixed redirects to work consistently
Revision 1133 broke 'Edit Site Settings' by relying on the
fact that the url for create pages is '<entity>/create', which
it is not for 'Edit Site Settings'.
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 22 Nov 2008 20:10:43 +0000] rev 562
Made Request use the new link_id and scope_path
This cleans a lot of weird user interface badness and
demonstrates how Linkable can be used.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 22 Nov 2008 18:58:32 +0000] rev 561
Added a requests overview using the new multi-list page.
Renamed the roles page to Requests Overview.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 22 Nov 2008 18:22:36 +0000] rev 560
Requests are almost working now
You can accept a request by clicking on it in the roles view.
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 22 Nov 2008 18:16:42 +0000] rev 559
Fix names of methods in soc.views.model.site.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 22 Nov 2008 18:15:58 +0000] rev 558
Fix wrong comment format in request.py.
Patch by: Pawel Solyga
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 22 Nov 2008 18:12:00 +0000] rev 557
Added missing import
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 22 Nov 2008 15:11:59 +0000] rev 556
Refactor requestSelf to be make use of the new split
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 22 Nov 2008 14:53:23 +0000] rev 555
Split the list view code up in three pieces
1. getListContents which returns the required contents dictionary
2. _list which returns the response for a specified list of contents
3. list which constructs just one content dict and passes it to _list
This way it is easier to do step 1 and 2 in other code than list(),
which makes it possible to display multiple list pages (by calling
getListContents multiple times and passing the result to _list).
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 22 Nov 2008 14:01:39 +0000] rev 554
Renamed templates/soc/entity/list/entity_*.html to *.html
This makes it possible to generalize list template positions.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 22 Nov 2008 13:59:34 +0000] rev 553
Make redirect generic using the new Lists object
This makes it possible (and easier) to have the list view redirect
to any page specially tailored to the current item.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 22 Nov 2008 11:19:20 +0000] rev 552
Fixed the description on the user's role page. This broke in r1111. The new lists also removed the need for instruction_text in models/base.py.
Removed an obsolete assignment in models/request.py
Patch by: Lennard de Rijk
Todd Larsen <tlarsen@google.com> [Sat, 22 Nov 2008 10:29:13 +0000] rev 551
Define a default for rights['public'] in views/models/base.py. Alter rights
in views/models/site.py to allow anyone, even signed-out users, to view the
site home page.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Sat, 22 Nov 2008 10:06:03 +0000] rev 550
Hide the 'scope' property from forms for now, since this is really supposed
to be set by "Role context" as determined by logic code in the controller.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Sat, 22 Nov 2008 09:49:13 +0000] rev 549
Fix some broken help_text bubbles (they are truncated or not displayed if they
contain " double quotation marks). Add notice text (sort of ugly at the
moment, Dmitri? :) explaining the "Public name" and "Link ID" fields in great
detail. This patch is in preparation for making "Link ID" immutable for Users
in a subsequent patch.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Sat, 22 Nov 2008 09:22:44 +0000] rev 548
Fix for 404 occuring when signing out during the creation of, for example,
a new Document. This patch makes sure that the request.path is not altered
when requesting the create page (alteration of which caused the 404). This
also results in the seeds now being remembered when being forced to log in.
The editPost method now correctly switches to the edit path after a
successful edit.
Patch by: Lennard de Rijk
Todd Larsen <tlarsen@google.com> [Sat, 22 Nov 2008 09:08:29 +0000] rev 547
Fixed former_accounts detection by supplying the missing error message.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Sat, 22 Nov 2008 08:55:55 +0000] rev 546
Rename the User.public_name Property to simply 'name' (but leave the verbose
name as "Public name"). This is to take advantage of standardizing on 'name'
in the common edit template (and possibly other common templates). The
Property was renamed because public_name was already a "name", unlike the
recent change to the Work Model class, where 'title' was "aliases" using a
tiny name() method instead.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Sat, 22 Nov 2008 08:44:54 +0000] rev 545
Include name of entity in the text of the link to the read-only public view
present in the common edit template. Provide a simple method in the Work
Model class that aliases the existing 'title' Property to 'name'.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Sat, 22 Nov 2008 08:40:10 +0000] rev 544
Fix broken Site settings form by uncommenting code that was inadvertently
committed commented out.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Sat, 22 Nov 2008 07:57:00 +0000] rev 543
Merge soc/logic/out_of_band.py into soc/views/out_of_band.py. Merge
errorResponse() and requestLogin() from soc/views/simple.py into
out_of_band.Error and out_of_band.LoginRequest exception classes, respectively.
Remove no-longer-used soc/logic/out_of_band.py and soc/views/simple.py. Fix
some problems where usage of out_of_band was broken.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Sat, 22 Nov 2008 03:13:59 +0000] rev 542
Remove redundant dicts for URL patterns and sidebar menu text, and use the
existing params dict instead. Add a sidebar_heading customization to params.
Better differentiate the 'User (self)' and 'Users' sidebar menus. Remove
the redundant Site settings menu items now that the Site entity is a singleton.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Sat, 22 Nov 2008 01:55:19 +0000] rev 541
By default, exclude files that are likely to be binary files.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Sat, 22 Nov 2008 00:23:10 +0000] rev 540
Add User.public_name help text, per discussions on melange-soc-dev.
Patch by: Todd Larsen
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 21 Nov 2008 23:45:37 +0000] rev 539
Allow for multiple list objects
At the moment there's not really a practical use for it, since there
is no way to make soc.views.models.base.View.list() show more than
one list, but it shouldn't be too hard to allow for that.
Patch by: Sverre Rabbelier
Todd Larsen <tlarsen@google.com> [Fri, 21 Nov 2008 23:45:15 +0000] rev 538
Make it more obvious that a format string constant is a format string by
appending _FMT.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Fri, 21 Nov 2008 22:38:38 +0000] rev 537
Fix getKeyValues() method footprint mismatches in soc.logic.models.site.Logic
after the recent refactoring. Remove 'Link scope' drop-down from Edit Site
Settings form.
Patch by: Todd Larsen
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 21 Nov 2008 12:01:59 +0000] rev 536
Add a page name for 'Edit Main Site Settings'
Todd Larsen <tlarsen@google.com> [Fri, 21 Nov 2008 11:44:39 +0000] rev 535
Refactor classes in soc/logic/models to make more use of inheritance. Add
some missing classes, such as soc.logic.models.group.Logic, so that
key name similarities between various Groups can be exploited via inheritance
instead of repetition of code.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Fri, 21 Nov 2008 10:46:15 +0000] rev 534
Replace HomeSettings with Presence Model class. Replace SiteSettings with
Site Model class. Derive Group Model class from Presence, adding the "home
page settings" properties in a Melange site presence to every Group.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Fri, 21 Nov 2008 08:41:23 +0000] rev 533
Move LINK_ID and SCOPE_PATH regular expressions to soc/models/linkable.py.
Fix some too-long lines. Change key names back to type:scope_path/link_id
(instead of type:scope_path:link_id). Some minor __doc__ string updates.
Patch by: Todd Larsen
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 21 Nov 2008 08:38:53 +0000] rev 532
Removed unnecesary lines according to comment on r1067
Patch by: Lennard de Rijk
Todd Larsen <tlarsen@google.com> [Fri, 21 Nov 2008 08:13:52 +0000] rev 531
Make editSelf() work by adding 'inheritance_line' to the list of excluded
fields in the UserForm. Also, fix a few too-long lines and add some missing
parentheses (the style guide says do not rely on operator precedence).
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Fri, 21 Nov 2008 07:36:44 +0000] rev 530
Remove imports of the soc.logic.key_name module, since it was deleted by r1071
(and wasn't referenced in these modules anyway).
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Fri, 21 Nov 2008 07:07:55 +0000] rev 529
Replace nick_name and its variants with public_name. Remove the
soc/templates/soc/person/edit.html template, since it does not appear to be
referenced anywhere (and contained a nick_name reference that would otherwise
need to be remedied).
Patch by: Todd Larsen
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 20 Nov 2008 23:51:45 +0000] rev 528
Some indention and too long lines fixes in soc.views.models.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 20 Nov 2008 23:34:26 +0000] rev 527
Delete some more not needed directories this time in soc/logic and soc/templates.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 20 Nov 2008 23:31:44 +0000] rev 526
Remove not needed directories in soc/views.
Patch by: Pawel Solyga
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 20 Nov 2008 23:07:38 +0000] rev 525
Created a checkIsInvited method
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 20 Nov 2008 22:51:07 +0000] rev 524
Small comment fix in Linkable model.
Patch by: Pawel Solyga
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 20 Nov 2008 22:44:22 +0000] rev 523
Removed one more unneccesary module
Last commit reminded me that this one is obsolete too.
Todd Larsen <tlarsen@google.com> [Thu, 20 Nov 2008 22:33:18 +0000] rev 522
OK, this one file was missing from r1061 for some reason.
Patch by: Todd Larsen
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 20 Nov 2008 21:57:25 +0000] rev 521
Minor improvements to roles page
Mainly not hard-coding the page name and showing all requests
that are _accepted_, instead of the one's that aren't yet.
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 20 Nov 2008 21:18:19 +0000] rev 520
Split a too long line
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 20 Nov 2008 21:14:37 +0000] rev 519
Adds the user's role page. Currently this only has an overview of the user's unhandled requests.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 20 Nov 2008 21:08:07 +0000] rev 518
Changes the list template to use an instruction_text property that sets the text above the list. This makes the create_invite template unneeded. The instruction_text comes in handy when defining special lists.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 20 Nov 2008 21:06:21 +0000] rev 517
Deleted unused files and files
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 20 Nov 2008 21:01:18 +0000] rev 516
The list method in models/base.py can now use a filter to make a selection of entities to show.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 20 Nov 2008 20:59:10 +0000] rev 515
Moved the last remnant of soc.views.user.profile to soc.views.models
Sadly, it is non-trivial to port this code to be generic enough to
work with soc.views.models.base.edit. On the other hand, this will
make customizing the editSelf code a lot easier.
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 20 Nov 2008 20:58:46 +0000] rev 514
Move saved message to the base class
This removes some duplicate code that was in all the child
classes of soc.views.models.base.View.
Todd Larsen <tlarsen@google.com> [Thu, 20 Nov 2008 19:43:31 +0000] rev 513
Rename partial_path to scope_path, ignoring case, etc.
(Similar to the recent link_name => link_id change). Also, fix two missed
"Linkname" column headers in some templates.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Thu, 20 Nov 2008 18:50:30 +0000] rev 512
Rename link_name to link_id everywhere, regardless of case (so LINK_NAME
becomes LINK_ID, "link name" becomes "link id", etc.). Also, rename LINKNAME
to LINK_ID.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Thu, 20 Nov 2008 18:06:43 +0000] rev 511
Ignore "dot" directories like .hg and .svn by default.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Thu, 20 Nov 2008 17:54:51 +0000] rev 510
id() is a built-in function in Python, so rename the property to link_id. Add
a scope_path StringProperty to cache the string representation of the
transitive closure of the nested scopes of an entity.
Patch by: Todd Larsen
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 20 Nov 2008 16:07:40 +0000] rev 509
Adds the rights['edit'] to models/base.py wich was left out in r1049.
Fixes two small typos in the comments in logic/mail_dispatcher.py
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 20 Nov 2008 15:41:31 +0000] rev 508
Add a access.deny and access.allow method
Respectively always deny, and always allow access to view
a part of the site.
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 20 Nov 2008 15:41:14 +0000] rev 507
Fold the _rights dictionary into params
Todd Larsen <tlarsen@google.com> [Wed, 19 Nov 2008 21:05:31 +0000] rev 506
Fix bug where script fails when it encounters a socket (which is not a regular
file). Fix bug where exception is raised if error occurred before parser
object was returned from _buildParser(). Add a --notext option, so that just
the file paths will be output on matches (both find and find/replace); useful
with xargs.
Patch by: Todd Larsen
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 19 Nov 2008 08:39:29 +0000] rev 505
Fix user key stuff
Key field for user is now link_name, instead of account, as such
the method's used by 'create new user' should be updated.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 18 Nov 2008 21:17:53 +0000] rev 504
Fix not working request creation.
Patch by: Pawel Solyga
Todd Larsen <tlarsen@google.com> [Tue, 18 Nov 2008 03:28:47 +0000] rev 503
Derive Linkable Model class from PolyModel.
Patch by: Todd Larsen
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 17 Nov 2008 22:21:02 +0000] rev 502
Add new parameters to views: url_name which is name used in urls (instead of using lower entity names) and module_name which is used for constructing django urls. Append changes to all affected files. Fix some title names. Change urls that included underscores like "site_settings" into urls with slash "site/settings". Plus some other minor fixes.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 17 Nov 2008 22:12:34 +0000] rev 501
Fix not working feed display for home settings public view. Modify blog javascript so that we can define how many feed entries we want to display. Change default number of entries to 3 as suggested by Leslie and Chris.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 17 Nov 2008 12:18:09 +0000] rev 500
Replace old page parameter doc string description with new one for page_name.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 17 Nov 2008 10:36:35 +0000] rev 499
Fix missing dots in doc strings and some other doc string corrections.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 17 Nov 2008 10:34:21 +0000] rev 498
Remove empty docs folder in soc/views.
Patch by: Pawel Solyga
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 17 Nov 2008 00:01:59 +0000] rev 497
Added a default _editSeed method
Also added the invite shortcut in the host view.
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 17 Nov 2008 00:01:33 +0000] rev 496
Temporary fix for creating a new user account
This should probably be solved more elegantly, but edit_self is going
to be used soon.
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 16 Nov 2008 23:04:48 +0000] rev 495
Added basic 'invite' functionality
Currently the invite can only be created, existing ones can be
listed and edited, or deleted if desired.
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 16 Nov 2008 23:03:37 +0000] rev 494
Refactored SiteMap to be generic
With this mechanism (in combination with the new sidebar) in place
adding a new entity to the site becomes very easy, rather than having
to add a lot of code to 'map.py', one can simply register with
the sitemap modules.
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 16 Nov 2008 23:02:31 +0000] rev 493
Refactor the sidebar to use Django templates
With this change the html for the sidebar is no longer generated by
Melange, instead it's delegated to Django (which is what it does
best anyway). The downside is that it is no longer possible to have
arbitrary deeply nested menu's.
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 16 Nov 2008 22:11:58 +0000] rev 492
Fixed redirection after creation to Just Work
Accomplished by generating a link to the creation page instead of
trying to deduct it from the current path.
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 16 Nov 2008 22:11:16 +0000] rev 491
Improved public page link text
Instead of putting the name of the entity in the link text to the
public page, a way better solution is to put static text there.
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 16 Nov 2008 17:59:30 +0000] rev 490
Allow pre-seeding a create form
With this feature the Site Settings create form can be pre-seeded
with it's "magic values", which allows those fields to be hidden
from the user. At the same time, it allows 'Edit Main Site Settings'
to either create or edit the Main Site Settings.
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 16 Nov 2008 15:51:19 +0000] rev 489
Fixed typo in soc.views.models.host redirects
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 16 Nov 2008 15:50:57 +0000] rev 488
Restored default Sponsor edit view
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 16 Nov 2008 15:50:29 +0000] rev 487
Fixed a typo in soc.logic.models.base
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 16 Nov 2008 15:50:05 +0000] rev 486
Added a filter method to dicts
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 16 Nov 2008 15:26:40 +0000] rev 485
Change id to account in base.html template (without this change we couldn't signout using top right links and also couldn't display currently logged in account information on the left side of links). This patch is related to commit in revision r1022.
http://code.google.com/p/soc/source/detail?r=1022
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 16 Nov 2008 12:48:23 +0000] rev 484
Add an e-mail dispatcher that can be used to send messages via the website. Add base and invitation templates that can be used with email dispatcher to send invitation emails. Please read the module doc string for more information how to use it.
Patch by: Lennard de Rijk, Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 15 Nov 2008 21:46:23 +0000] rev 483
Fix broken User link_name validations. Changes in r1014 still caused some problems so I came out with new idea to compare User accounts (previously called "id").
Patch by: Pawel Solyga
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 15 Nov 2008 16:17:11 +0000] rev 482
Factor out direct use of the page object
Instead of directly using the page object in the html,
pass around page_name. This will make it easier to remove
Page in favor of a simpler implementation.
Todd Larsen <tlarsen@google.com> [Sat, 15 Nov 2008 03:12:33 +0000] rev 481
Attempt to rename User.id to User.account, in preparation for making User be
derived from Linkable, which will have a property named 'id'.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Fri, 14 Nov 2008 06:36:42 +0000] rev 480
For those times when sed isn't enough, but awk is too much, there's munge.py...
Patch by: Todd Larsen
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 13 Nov 2008 20:46:41 +0000] rev 479
Make sure the user edit form has the complete mail adress in the user account field when opened. Replace confusing id field in form with email field. Editing the email adress of an existing user will still result in an error but that should be fixed soon.
Patch by: Lennard de Rijk
Review by: Pawel Solyga
Todd Larsen <tlarsen@google.com> [Thu, 13 Nov 2008 19:41:16 +0000] rev 478
upload.py (customized for use with codereviews.googleopensourceprograms.com)
updated from latest Rietveld release.
Patch by: Todd Larsen
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 13 Nov 2008 16:40:05 +0000] rev 477
Moved from docs -> document
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 12 Nov 2008 21:43:15 +0000] rev 476
Fixed typo in docstring
Todd Larsen <tlarsen@google.com> [Wed, 12 Nov 2008 07:28:12 +0000] rev 475
Copy the link_name regex patterns into linkable.py, in preparation for
removing them from path_link_name.py (eventually).
Patch by: Todd Larsen
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 11 Nov 2008 21:07:38 +0000] rev 474
Move all the properties from Person model to Role model. Update all the comments and docs according to the changes. Remove Person model.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 11 Nov 2008 19:49:00 +0000] rev 473
Fix broken User link name (it was possible to change link name to one that was already used, validation was not working correctly).
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 11 Nov 2008 01:02:56 +0000] rev 472
Move "(required)" text to third column instead of second column in templatetags, it's much more user friendly that way. Add new version of as_table that support our current error messages format, information about required fields and tooltips.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 10 Nov 2008 23:18:06 +0000] rev 471
Remove stop parameter from home_settings and site_settings views. This is something Sverre didn't mean to commit :-) Add missing params description to the models Base class docs.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 10 Nov 2008 22:50:27 +0000] rev 470
In soc.views.models.user module fix too long line. Delete unused email variable, add missing doc and rename self method and global variable to editSelf and edit_self so it's not confused with "self" used in classes and there is no outerscope variable name overwriting anymore.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 10 Nov 2008 22:45:17 +0000] rev 469
Some name changes in soc.logic.site.map module for User self edit view.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 10 Nov 2008 22:38:20 +0000] rev 468
Fix typo in linkable model and add some missing comments.
Patch by: Pawel Solyga
Todd Larsen <tlarsen@google.com> [Mon, 10 Nov 2008 18:00:47 +0000] rev 467
Initial thoughts on a Linkable Model class. Please comment.
Patch by: Todd Larsen
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 10 Nov 2008 17:25:05 +0000] rev 466
Fix names typos in home_settings and site_settings modules.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 10 Nov 2008 16:46:16 +0000] rev 465
Change Google Maps property name from gm_api_key to gmaps_api_key.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 10 Nov 2008 16:40:51 +0000] rev 464
Change partial path and link name verbose names in home_settings.py. Some comments fixes in site_settings.py.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 10 Nov 2008 16:07:18 +0000] rev 463
Add jquery folder to make_release.sh script to fix not working jquery on deployed app.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 10 Nov 2008 14:40:16 +0000] rev 462
Adds a check to logic/valididate.py that checks the partial path format using a regexp. This regexp has been added to logic/path_link_name.py, therefore changing PATH_LINKNAME_REGEX to use the PARTIAL_PATH in building this regexp. Plus views/models/docs.py now uses the validation functions in the clean_ methods.
Patch by: Lennard de Rijk
Review by: Pawel Solyga
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 10 Nov 2008 00:42:41 +0000] rev 461
Partially use the new user code
The 'edit self' is not working fully yet, the 'lookup' code is not
working at all, as such, only 'create', 'edit', 'list', and 'delete'
make use of the generic code.
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 10 Nov 2008 00:42:18 +0000] rev 460
Added a generic user page
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 10 Nov 2008 00:41:54 +0000] rev 459
Preparation for generic user views
Added a getSuffixValues method that is meant to allow for having a
non-public field as key_name.
Also added support for a key-name field being embeded in the form so
that if the key-fields change the old key_name is not lost.
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 10 Nov 2008 00:41:01 +0000] rev 458
Added support for providing a custom params dict
This has been a long outstanding feature request for tlarsen, luckily
it turned out to be very easy to implement with the dict.merge
utility method. To have custom _rights one should instead to the
required access checks before calling the view method.
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 10 Nov 2008 00:40:39 +0000] rev 457
Fixed a typo in id_user
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 10 Nov 2008 00:40:15 +0000] rev 456
Fix create redirect
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 10 Nov 2008 00:39:50 +0000] rev 455
Added support for providing a custom params dict
This has been a long outstanding feature request for tlarsen, luckily
it turned out to be very easy to implement with the dict.merge
utility method. To have custom _rights one should instead to the
required access checks before calling the view method.
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 10 Nov 2008 00:39:26 +0000] rev 454
Minor fix to sponsor missing from the site restructure
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 09 Nov 2008 21:40:28 +0000] rev 453
Add a Google Maps property to Site Settings
Patch by: Lennard de Rijk <ljvderijk@gmail.com>
Reviewed by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 09 Nov 2008 21:24:49 +0000] rev 452
Fixes to {Site,Home}Settings
Also improved help text on HomeSettings partial_path and link_name.
Dmitri Gaskin <dmitrig01@gmail.com> [Sat, 08 Nov 2008 18:35:46 +0000] rev 451
Fixing the string for the default home page
Dmitri Gaskin <dmitrig01@gmail.com> [Sat, 08 Nov 2008 17:40:12 +0000] rev 450
Making the docs template prettier
Dmitri Gaskin <dmitrig01@gmail.com> [Sat, 08 Nov 2008 17:06:35 +0000] rev 449
Allowing + and - to be clicked in the menu
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 07 Nov 2008 22:24:01 +0000] rev 448
Fix not working former_ids. Add support for "Invalid accounts". Now when id from former_ids tries to create a profile "This account is invalid." error message is displayed. Compare emails in lower cases to prevent changing User email to the same email with different character casing (needs some more testing).
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 07 Nov 2008 22:13:20 +0000] rev 447
Some indention fixes and remove not needed variable in soc.logic.models.base module.
Patch by: Pawel Solyga
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 05 Nov 2008 23:38:00 +0000] rev 446
Refactoring of {site/home}_settings to make them use base.View
This makes the way for deleting the key_name.py module
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 05 Nov 2008 23:36:28 +0000] rev 445
Major site restructuring, also deleting of many unused or obsolete documents
The new structure is as follows:
<entity>/list - list all <entitie>s
<entity>/create - create a new <entity>
<entity>/show/<key fields> - public page for <entity>
<entity>/edit/<key fields> - edit a <entity>
<entity>/delete/key fields> - delete a specific entity
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 05 Nov 2008 23:33:22 +0000] rev 444
Fix sponsor key field extraction
When extracting key field there is no sponsor or user object, instead
only their link names are known.
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 05 Nov 2008 23:32:59 +0000] rev 443
Implements base.Logic functions in home_settings, site_settings and work
This patch implements the base.Logic funtions needed for making
logic/key_name.py obsolete. This patch defines the needed functions
in home_settings, site_settings and work. All modules in logic/models
now have these functions defined.
logic/models/site_settings.py now inherits from
logic/models/home_settings.py because of their similar connection in
the corresponding models. Please note that the self._keyName for
these two modules still points to logic/key_name.py since entity_type
is still used in views/home.py.
A partial_path and link_name were added to HomeSettings as requested
by SRabbelier.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 04 Nov 2008 20:06:36 +0000] rev 442
Fix wrong redirect when changing partial path or link name. Remove an unnecessary assignment in logic/models/base.py that would generate an error when an entity did not exist.
Patch by: Lennard de Rijk
Review by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 04 Nov 2008 14:09:37 +0000] rev 441
Fix not working former ids feature of User Profile Developer Edit view. Add missing Error exception class to soc.logic.models.base module.
Patch by: Pawel Solyga
Todd Larsen <tlarsen@google.com> [Tue, 04 Nov 2008 02:50:55 +0000] rev 440
Third-party Javascript that should have been part of r891. Same license as
JQuery.
Patch by: Todd Larsen
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 03 Nov 2008 19:47:02 +0000] rev 439
Minor fixes needed for generic key name
We no longer try to retreive an entity when there are unset fields.
This sort of makes 'getIfFields' obsolete, since we check if fields
now anyway. This is needed because getKeyFieldsFromDict expects the
fields to be set.
Also a minor fix in a Django template so that the generic 'edit' page
has a working delete button again.
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 03 Nov 2008 19:04:04 +0000] rev 438
Quick fix to fix user profile creation
This change will be obsolete when User refactoring is finished, but
it will fix the build untill then.
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 03 Nov 2008 18:20:53 +0000] rev 437
Django Fix according to code.djangoproject.com/attachement/ticket/9115/check_for_unlink_in_temp.patch
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 03 Nov 2008 15:03:09 +0000] rev 436
Add missing TODOs to soc.logic.models classes. Fix comments format in base.Logic class. Changes based on comments to r972.
http://code.google.com/p/soc/source/detail?r=972
Patch by: Pawel Solyga
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 02 Nov 2008 22:57:46 +0000] rev 435
Refactor out the abundance of dictionary (un)packing
Instead, keep the dict packed once packed, and only unpack
it when needed.
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 02 Nov 2008 22:56:52 +0000] rev 434
Added key field definitions to the User logic
This is the first part of making the User views generic.
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 02 Nov 2008 22:56:28 +0000] rev 433
Add a getForFields method
It allows for generic queries with restrictions specified
in a dictionary.
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 02 Nov 2008 22:50:22 +0000] rev 432
Add a generic method for getting a Keyname
This patch will make logic/key_name.py obsolete in the future when
everything is compliant with base.logic.
This also makes the naming of already compliant logic modules generic
and also fixes the _name field to be consistent with the naming in
key_name.py.
Note: This does not use Group/Sponsor, Group/School,
Group/Organisation or Group/Club.
Patch by: "Lennard de Rijk" <rijk0214@gmail.com>
Reviewed by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 02 Nov 2008 18:25:07 +0000] rev 431
Added a missing 'pass' statement
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 02 Nov 2008 18:10:30 +0000] rev 430
Create a Site Settings sub-menu
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 02 Nov 2008 17:26:06 +0000] rev 429
Fixed typo in e-mail address
Instead of 'sverre@rabbelier.nl' everything read 'sverer@rabbelier.nl'
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 02 Nov 2008 17:25:10 +0000] rev 428
Fixed typo in access check
Instead of checking for 'public' the rights for 'edit' were checked.
Todd Larsen <tlarsen@google.com> [Mon, 27 Oct 2008 19:31:51 +0000] rev 427
The pretty blue triangles from Google Code!
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Mon, 27 Oct 2008 19:19:44 +0000] rev 426
Add tooltips style display of help_text, instead of widening the form with
another (often ridiculously large) column. Also, version the .css and .js
files so that browsers won't display the wrong cached one when we change
something.
Patch by: Dmitri Gaskin, Todd Larsen
Review by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Mon, 27 Oct 2008 18:54:53 +0000] rev 425
Change Site and User sub-menus so that the "header" entry for those sub-menus
is not a clickable link, but instead just a placeholder.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Mon, 27 Oct 2008 18:36:19 +0000] rev 424
Use nice "plus" and "minus" symbols from Google Code, instead of current
triangles, for sidebar menu.
Patch by: Todd Larsen
Augie Fackler <durin42@gmail.com> [Sun, 26 Oct 2008 21:36:29 +0000] rev 423
Add javascript expandable menus.
Patch by: Dmitri Gaskin
Review by: Augie Fackler
Augie Fackler <durin42@gmail.com> [Sun, 26 Oct 2008 21:26:35 +0000] rev 422
Add jQuery.
Patch by: Dmitri Gaskin
Review by: Augie Fackler
Augie Fackler <durin42@gmail.com> [Sun, 26 Oct 2008 00:57:33 +0000] rev 421
Remove bogus import from a previous iteration.
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 26 Oct 2008 00:52:23 +0000] rev 420
Remove newlines in sidebar
Augie Fackler <durin42@gmail.com> [Sun, 26 Oct 2008 00:27:17 +0000] rev 419
Start a test system for the webapp itself.
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 26 Oct 2008 00:13:26 +0000] rev 418
Always check if a user filled in a user profile
Also, if there is no checks defined, still do the general
checks.
Tim Ansell <mithro@gmail.com> [Sat, 25 Oct 2008 22:28:31 +0000] rev 417
Do not include attributes which are inherited.
Also some extra comments.
Review URL: http://codereviews.googleopensourceprograms.com/1603
Tim Ansell <mithro@gmail.com> [Sat, 25 Oct 2008 22:26:34 +0000] rev 416
Run with Python 2.5
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 23 Oct 2008 12:00:29 +0000] rev 415
Fix typo in models/public.html template. Changes in Host Public Profile template (new header title and deletion of some fields).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 23 Oct 2008 11:42:22 +0000] rev 414
Fix mistakes in Host List templates. Change Host List second row to Sponsor name instead of Sponsor link name.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 23 Oct 2008 11:20:35 +0000] rev 413
Rename Host list templates from group_<something> to host_<something> and move then to soc/host/list folder. Update affected files with new paths.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 23 Oct 2008 09:47:38 +0000] rev 412
Fix Sponsor profile edit/create template. Don't show "View Sponsor Public Profile" link and Delete button in Create Sponsor view.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 23 Oct 2008 09:08:02 +0000] rev 411
Addresses comments to r866.
http://code.google.com/p/soc/source/detail?r=866
Patch by: Pawel Solyga
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 23 Oct 2008 05:21:41 +0000] rev 410
Moved all key_name related things to the logic modules
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 23 Oct 2008 05:21:26 +0000] rev 409
Addressed comments by Pawel and Todd
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 22 Oct 2008 17:18:57 +0000] rev 408
Inherit from BaseForm in all forms instead of from DbModelForm. This change doesn't include changes to templates and usage of as_table everywhere (work in progress).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 22 Oct 2008 17:03:08 +0000] rev 407
Fix not working Create views (committed in r864). Check if entity exist in constructKeyNameSuffix funtion and apply changes to affected files.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 22 Oct 2008 16:55:35 +0000] rev 406
Fix some wrong paths to templates (committed in r864).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 22 Oct 2008 16:21:50 +0000] rev 405
Add Google Analytics support to Site Settings. The reason I created additional SettingsValidationForm is because you cannot inherit from Form that has already defined Meta class, so it's sort of workaround for that. I didn't want to have same validation functions in both Form classes.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 22 Oct 2008 06:20:02 +0000] rev 404
Added a Host profile and generalized some views
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 22 Oct 2008 06:19:12 +0000] rev 403
Some more improvements to the generic view code
Namely getEmptyKeyFields and constructKeyNameSuffix,
some whitespace issues, and a few extra fields in the
context.
Patch by: Sverre Rabbelier
Reviewd by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 21 Oct 2008 01:22:36 +0000] rev 402
Incorperated suggestions by Todd
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 20 Oct 2008 23:24:41 +0000] rev 401
Make use of the new generic views
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 20 Oct 2008 23:24:32 +0000] rev 400
Added a generic version of the Document views
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 20 Oct 2008 23:24:21 +0000] rev 399
Various improvements to the generic View code
Among others:
* Added the 'page' argument to the simple.errorResponse call
* Pass the result of getEmptyKeyFields to edit() in create()
* Fix typo's in error responses
* Fixed a todo to properly redirect on create
* Made editPost return something when the form is not valid
* Added an _editGet hook
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 20 Oct 2008 23:24:07 +0000] rev 398
Rename 'existing_doc' and 'document' to entity
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 20 Oct 2008 23:23:53 +0000] rev 397
Remove the google search box and the google analytics page
These are left over from the mockups (removed because they
caused long wait times when no internet connection is
available).
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 20 Oct 2008 23:23:43 +0000] rev 396
Improve the error message for getIfFields
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Mon, 20 Oct 2008 22:18:32 +0000] rev 395
Add documentation in response to Pawel's comments:
http://code.google.com/p/soc/source/detail?r=832
Patch by: Todd Larsen
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 19 Oct 2008 21:12:08 +0000] rev 394
Add BaseForm class to soc.views.helper.forms module (work in progress). This changes the way as_table function displays the form (for more information have a look into doc string). BaseForm is going to be used for all forms in Melange in future. Right now it's still missing custom form errors labels and "required" text in 3rd column, but that's added as TODO and I'm working on it.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 19 Oct 2008 21:08:08 +0000] rev 393
Add colon after label in _field_as_table_row template for consistency reasons with form.as_table output.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 19 Oct 2008 18:00:14 +0000] rev 392
Add "View Sponsor Public Profile" to Sponsor Edit view template. Remove not needed <p> in home/public.html template. Add missing '$' at the end of some urls in site/map.py module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 19 Oct 2008 17:33:44 +0000] rev 391
Address comments to r844 and r845.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 19 Oct 2008 16:17:32 +0000] rev 390
Remove unused imports, fix too long lines and indentions.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 19 Oct 2008 13:14:40 +0000] rev 389
Fix identions, too long lines, unused imports and some other mistakes.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 19 Oct 2008 13:06:20 +0000] rev 388
Add pylint configuration file (pylintrc) and do_pylint.sh script which runs pylint checkers on Melange code using pylintrc file as config. do_pylint.sh as default shows additional information like reports, TODOs, code similarities and unused imports, but you can run it in silent mode (--silent) which disables all of that. The only problem with unused imports in pylint right now is that it doesn't work in the situation described in last example at http://code.google.com/p/soc/wiki/PythonStyleGuide#Packages, so sometimes we get unused import soc when we actually shouldn't. However this can be fixed by writing pylint plugins (our own checkers) in future.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 19 Oct 2008 00:34:33 +0000] rev 387
Addressed comments by Todd on r822
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 18 Oct 2008 21:55:38 +0000] rev 386
Fix identions in reflistprop module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 18 Oct 2008 21:54:13 +0000] rev 385
Remove not used imports in models. Fix missing spaces in models when operator not preceded by a space. Add missing ugettext_lazy import to Proposal model.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 18 Oct 2008 17:49:46 +0000] rev 384
Add missing ugettext_lazy for string in soc.views.user.profile module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 18 Oct 2008 17:27:53 +0000] rev 383
Fix missing keyword argument in soc.views.user.profile.create() function when calling edit().
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 18 Oct 2008 17:25:04 +0000] rev 382
Change Sponsor delete url from /site/sponsor/profile/<link_name>/delete to /site/sponsor/profile/delete/<link_name> to match convention used in Document delete url.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Chen Lunpeng <forever.clp@gmail.com> [Sat, 18 Oct 2008 05:59:04 +0000] rev 381
Fixed not working to edit a doc that selected from the docs list view. soc/templates/soc/docs/list/docs_row.html not full updated.
Patch by: Chen Lunpeng
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 18 Oct 2008 05:30:57 +0000] rev 380
Change the "Site home page Document is missing" default text to give
instructions similar to those in the Site Settings form.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 18 Oct 2008 05:26:53 +0000] rev 379
Remove another now-empty templates directory.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 18 Oct 2008 05:25:47 +0000] rev 378
Nothing left in this templates directory, so remove it.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 18 Oct 2008 05:11:37 +0000] rev 377
Refactor various site views into more generic locations, in preparation for
using access permissions to decide the fuctionality in the view, instead of
having lots of cut-and-paste copies of the same view functions.
site/home.py into more generic home.py
site/settings.py into more generic settings.py
site/docs/list.py into more generic docs/list.py
site/docs/edit.py into more generic docs/edit.py
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 18 Oct 2008 04:56:39 +0000] rev 376
Add a style that appears in form error lists produced by Django Forms and
make it match the style of the existing td.formfielderror used by the
field_as_table_row helper.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 18 Oct 2008 01:51:02 +0000] rev 375
Create package for soon-to-be-refactored group/home.py and group/settings.py
packages.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 18 Oct 2008 01:47:02 +0000] rev 374
Add the Page object to the context of each view. Update templates to make
use of the newly-available page.long_name and page.short_name.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 18 Oct 2008 01:35:08 +0000] rev 373
Add the Page object to the context of each view method. Also, add some missing
Arg: sections to __doc__ strings and fix the missing context issue in
editPost() and editGet().
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 18 Oct 2008 01:32:40 +0000] rev 372
Formalize the concept of a NonPage that can appear in the site-map, useful for
non-clickable sidebar menu divisions, for example. Convert "hacky" fake Pages
into NonPages in the site-map.
Also, pass page=self to every view as a keyword argument when generating the
Django urlpatterns.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 18 Oct 2008 01:00:10 +0000] rev 371
Add a relative symlink pointing at ../rietveld/upload.py in thirdparty/chromium
so that gcl.py can import the thirdparty/rietveld/upload.py module.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 17 Oct 2008 23:10:49 +0000] rev 370
Replace missing:
from google.appengine.api import users
that appears to have been removed by r824. Needed by call in the edit() view
to users.get_current_user().
Patch by: Todd Larsen
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 17 Oct 2008 13:57:54 +0000] rev 369
Replace GROUP_TYPE_PLURAL and GROUP_TYPE_SHORT constants in Group models with more generic TYPE_NAME, TYPE_NAME_SHORT, TYPE_NAME_PLURAL names and apply changes in affected files. Use ugettext_lazy for TYPE_NAME and TYPE_NAME_PLURAL constants. This approach is similar to the upcoming refactor of views.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 17 Oct 2008 13:04:51 +0000] rev 368
Move TODO about isDeletable Sponsor logic method to sponsor.py module and extend a little bit doc string.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 17 Oct 2008 12:52:02 +0000] rev 367
Remove not needed request argument in view decorator.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Chen Lunpeng <forever.clp@gmail.com> [Fri, 17 Oct 2008 02:43:39 +0000] rev 366
Fixed not working after click the "List Site Sponsors" in site menu bar. due to wrongly imported modules.
Patch by: Chen Lunpeng
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 23:31:57 +0000] rev 365
Create decorators module in view/helper and add view decorator that catches exceptions like DeadlineExceededError, MemoryError, AssertionError (this code is being moved from respond function). Add view decorator to all view functions. In addition remove not needed imports from all affected files and fix too long lines.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 16 Oct 2008 23:26:58 +0000] rev 364
Last commit missed the new __init__.py file
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 16 Oct 2008 23:23:16 +0000] rev 363
Add a framework for generic views
This commit does not enable the new code, as such there
should be no change in functionality. In order to use the
new code the maps.py file should be updated to point at the
new views/models/sponsor.py module.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 16 Oct 2008 18:08:35 +0000] rev 362
entity_type is not the same as entity_type_short
The previous commit wrongfully assumed this.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 17:34:10 +0000] rev 361
Make page argument required for errorResponse and requestLogin functions in simple.py and update affected files. Some keyword argument changes to in user/profile.py. All the changes are based on comments to r817.
http://code.google.com/p/soc/source/detail?r=817
Patch by: Pawel Solyga
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 16 Oct 2008 17:30:58 +0000] rev 360
Rename 'group' to 'entity' in the Django templates
This allows for generic use of these templates.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 16:05:08 +0000] rev 359
DeadlineExceededError in the recent version of AppEngine lives only in one place so there is no need to try import it from both runtime (deployed) and runtime.apiproxy_errors (dev server) modules anymore.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 15:22:41 +0000] rev 358
Add page=None parameter to all views. Information from page argument (which is soc.logic.site.page.Page object) is going to be used later in views code and for some context values. Fix some indentions in __doc__ strings. Add proper __doc__ string for all() function in sponsor/list.py module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 15:12:00 +0000] rev 357
Some indention fixes in access.py module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 13:18:59 +0000] rev 356
Change name of login_request variable in access.py module to login_response.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 13:16:46 +0000] rev 355
Change name of getUserFromLinkNameOrDie function to getUserFromLinkNameOr404 and apply changes to affected files.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 13:14:13 +0000] rev 354
Fix mistakes in docs and comments in logic/models/base.py.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Chen Lunpeng <forever.clp@gmail.com> [Thu, 16 Oct 2008 09:14:26 +0000] rev 353
Log Fix not working after click the "Site Settings" in home page. templete wasn't updated when soc/app/soc/logic/site/map.py was update.
Patch by: Chen Lunpeng
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 09:05:02 +0000] rev 352
Remove #docsummary class from css file as it is not used anymore. Add #createdby class in css file. Fix typo in docs/profile.html template. Put document content in <div class='content'>.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 16 Oct 2008 04:37:13 +0000] rev 351
Eliminate the Work.abstract property and move the Document.content property
to Work.content instead. Update affected views, and re-base some classes
that were deriving from Document just to get Document.content to now be
derived from Work instead.
The Document class now has a "pass" body with no additional properties. It
is debatable whether Work should become Document, since I am not sure that
we plan to be able to generically display, say, a Quiz or a Question (which
are Works) on the home page (which can only specifically display a Document,
or now, the basic Work entity...).
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 16 Oct 2008 04:30:26 +0000] rev 350
"new" is a little bit redundant in the short_name of sidebar menu items that
already begin with "Create...", since that implies the result will be something
new.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 16 Oct 2008 04:27:07 +0000] rev 349
A quick-and-dirty way to create non-link sub-menu dividers, plus a TODO on
how this should be formalizes to not be so hacky.
This change was inspired by the ever-growing "Site" sidebar menu.
Patch by: Todd larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 15 Oct 2008 21:31:36 +0000] rev 348
Should have been part of recent r806.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 15 Oct 2008 21:27:47 +0000] rev 347
First phase of making the / (site/home) view generic enough to use it for
Sponsor "home" page, Program "home" page, Organization "home" page, etc. when
combined with HomeSettings.
First phase of addressing this issue:
http://code.google.com/p/soc/issues/detail?id=64
by factoring "Site Settings" apart from the site/home stuff.
Patch by: Todd Larsen
Review by: Pawel Solyga
Review URL: http://codereviews.googleopensourceprograms.com/1405
Todd Larsen <tlarsen@google.com> [Wed, 15 Oct 2008 21:23:29 +0000] rev 346
Add the empty directory where site/home/edit.html is moving, to see if this
fixes a problem with gcl.py.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Oct 2008 20:27:40 +0000] rev 345
Update TinyMCE wiget code according to r783. I hope I did it correctly this time.
http://code.google.com/p/soc/source/detail?r=783
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Oct 2008 20:24:02 +0000] rev 344
Change verbose_name of founder property in Group model from "Created by" to "Founded by". Add GROUP_TYPE_SHORT and GROUP_TYPE_PLURAL for all models that inherit from Group and use that values in templates and contexts. Assume that group_type, group_type_short and group_type_plural are defined in context and remove not needed ifs in templates. Rename "Linkname" to "Link name" in list/group_heading.html template.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Oct 2008 20:10:07 +0000] rev 343
Remov "founder" text from the first line of edit.py, this is fix to r799 commit.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 15 Oct 2008 19:33:50 +0000] rev 342
Remove the proposed WorksAuthors many:many relation and promote the "founder"
property from Document up to Work. Update all subclasses of Work and any
affected views accordingly. This addresses review comments here:
http://code.google.com/p/soc/source/detail?r=786
Patch by: Todd Larsen
Review by: to-be-reviewed
Tim Ansell <mithro@gmail.com> [Wed, 15 Oct 2008 18:06:07 +0000] rev 341
Fixed the evil black logo.
Tim Ansell <mithro@gmail.com> [Wed, 15 Oct 2008 18:03:21 +0000] rev 340
Make this file excutable by default.
Todd Larsen <tlarsen@google.com> [Wed, 15 Oct 2008 17:10:27 +0000] rev 339
Define the Models for implementing Quizzes (collections of Questions) and their
Responses (collections of Answers to those Questions). These Models would
form the basis of storage for such items as:
Terms of Service (Quiz)
Question ("I agree...")
Response -> Answer (answer to "I agree..." confirmation)
solution ("Yes" Answer to the "I agree..." Question)
Mentor and Student surveys (Quiz)
Questions (including "Pay this student?")
Response -> Answers
solution ("Yes" Answer to the "Pay this student?" Question)
Organization applications
Student Proposal review, comment, and scoring system
GHOP task tracking (a specific task list item would be a Quiz)
Patch by: Todd Larsen
Review by: Pawel Solyga, Sverre Rabbelier, Chen Lunpeng
Review URL: http://codereviews.googleopensourceprograms.com/1403
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Oct 2008 14:06:33 +0000] rev 338
Show "Created by" read-only field in Document Edit view. Update size of TinyMCE widget in Document Edit/Create views. Change user property name to founder in Document model and update files according to this change (now founder is used in Group and Document models). Remove not used variables and imports in views/site/docs/edit.py. Refactor EditForm and CreateForm in views/site/docs/edit.py so that EditForm inherits from CreateForm and just extends it.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Oct 2008 13:59:52 +0000] rev 337
Show "Created by" read-only field in Sponsor Edit view. Fix function keyword arguments in sponsor/list.py to follow our PythonStyleGuide. Sponsor founder property is not updated anymore when editing Sponsor profile, it's just saved once when creating Sponsor profile.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Oct 2008 13:54:00 +0000] rev 336
Fix not working docs show view. Document show view wasn't updated when the logic refactor was made.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Oct 2008 13:51:31 +0000] rev 335
Changes to TinyMCE widget that enable to pass mce_settings in the class constructor and that way update default settings if needed.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Oct 2008 13:49:17 +0000] rev 334
Add nameHomeSettings function to key_name module. Add HomeSettings logic.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Oct 2008 13:47:10 +0000] rev 333
Update comments in models/group.py (changed Optional to Required). Add verbose_name to founder property in Group model.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Oct 2008 22:57:52 +0000] rev 332
Fix bug that caused Lookup user by User Account not to work properly. Basically wrong parameter to models.user.logic.getFromFields().
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Oct 2008 22:35:46 +0000] rev 331
Add deleted in r732 (don't know why) functionality that displays custom Error page when linkname in Developer User Profile url doesn't exist (/site/user/profile/<not_existing_linkname>).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Oct 2008 22:20:55 +0000] rev 330
Add underscore in two word div class names in templates (nick_name, short_name, partial_path).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 14 Oct 2008 21:39:57 +0000] rev 329
Add is_featured boolean property to the Work model, so that Works can be
designated as "featured" items in various places in the UI. This will be
used to allow Sponsors, Programs, and Organizations to select Documents that
should be included in their sidebar menus.
Perhaps featured "site" Documents, such as site-wide Terms of Service,
should probably be listed below the "User (sign-out)" menu, since the User
will have to read and agree to these before being allowed to use the site.
A collapsable Javascript sidebar is probably going to be needed soon...
Patch by: Todd Larsen
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Oct 2008 21:33:57 +0000] rev 328
Add missing blank lines, clean up the doc string and remove white spaces at the end of the lines in reflistprop.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Oct 2008 21:06:23 +0000] rev 327
Move <div id='notice'> into notice block in base.html template. Change formatting of notice block to make it much easier to "parse" visually. This patch is based on comments to r722.
http://code.google.com/p/soc/source/detail?r=722
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 14 Oct 2008 21:02:28 +0000] rev 326
Add a third-party ReferenceListProperty class. This is going to be used to
contain the references to Questions that make up a Quiz.
Patch by: Todd Larsen
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Oct 2008 20:33:20 +0000] rev 325
Fix some defects for lookup user view. More information about the patch can be found under the link below.
http://groups.google.com/group/melange-soc-dev/browse_thread/thread/5d378c8d3679945f/d1e7cc3a53adda4e
Patch by: Chen Lunpeng
Review by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Oct 2008 16:10:07 +0000] rev 324
Add missing import in soc/views/site/sponsor/list.py which caused exception when app was deployed and first site you visited was "List Site Sponsors". Update files according to recent django update and django backwards incompatibility (for example newforms is changed to forms).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Oct 2008 16:00:59 +0000] rev 323
Load ../vendor/django into trunk/app/django.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Oct 2008 12:36:55 +0000] rev 322
Fixed imports sorting based on comments for r751.
http://code.google.com/p/soc/source/detail?r=751
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Oct 2008 12:02:42 +0000] rev 321
Some indentations fixes. Changed all the email=id function arguments to email=id.email().
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 13 Oct 2008 22:32:09 +0000] rev 320
Some indentations fixes and ugettext_lazy() wrap up for DEF_DEV_LOGOUT_LOGIN_MSG_FMT in access.py.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 13 Oct 2008 22:22:16 +0000] rev 319
Rename soc/logic/models/settings.py to model site_settings.py and apply import name change to soc/views/site/home.py
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 13 Oct 2008 22:18:54 +0000] rev 318
Fix typos in doc string in sponsor.py and settings.py
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 13 Oct 2008 22:04:42 +0000] rev 317
Remove spaces between dict key name and colon. Fix some typos based on comments http://code.google.com/p/soc/source/detail?r=739.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 13 Oct 2008 21:54:51 +0000] rev 316
Add missing blank lines between imports and sort all of the imports.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 13 Oct 2008 21:34:07 +0000] rev 315
Add missing blank lines between imports in access.py module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 13 Oct 2008 17:41:20 +0000] rev 314
Rearrange imports in home.py so they apply to new discussed format (separate "from ..." and "import ..." blocks). Add Delete Document functionality.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 13 Oct 2008 06:19:43 +0000] rev 313
Bugfixes to the latest revision
Some pages did not work due to missing imports, or wrongly
imported modules.
Patch by: Chen Lunpeng
Reviewd by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 13 Oct 2008 04:34:14 +0000] rev 312
Added missing models/__init__.py and removed empty logic/model directory
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 18:40:32 +0000] rev 311
Dictionaries need String values for keys
The cleanup patch earlier mistakenly used raw names as keys
to the dictionary (such as one would do in a function call).
This fixes that mistake.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 18:32:43 +0000] rev 310
Removed now-obsolete code from model.py and __init__.py
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 18:30:37 +0000] rev 309
Made the existing code use the new soc.logic.models
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 18:11:20 +0000] rev 308
Added invididual model logic files
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 16:50:28 +0000] rev 307
Also removed helper directory
Which somehow did not get removed with the last commit
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 16:47:39 +0000] rev 306
Removed obsolete logic directories and added one for model
The model/ directory will contain the Base logic classes.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 15:52:19 +0000] rev 305
Minor style and import fixes
Incorperated changes as suggested by Todd and Pawel.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 15:05:50 +0000] rev 304
Missing changes to soc.views.helper.access
Due to having to manually do the 'svn mv' of logic to helper,
the changes to access.py got lost, this commit fixes that.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 14:58:47 +0000] rev 303
Moved soc/logic/helper/access to soc/views/helper/access
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 12 Oct 2008 08:46:05 +0000] rev 302
Fix not working delete Sponsor functionality after recent commit. Add delete() method to Base class. Make soc.views.site.sponsor.delete() request handler use this method.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 12 Oct 2008 08:43:41 +0000] rev 301
Fix not working isIdDeveloper() function after recent commit. There is still confusion within getFormFields method (email is not id), but this change doesn't address that problem.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 12 Oct 2008 01:08:41 +0000] rev 300
Changed location of the svn command in svn_load_dirs.pl script from '/usr/bin/svn' to 'svn'. That makes the script more universal and it should work on Linux, Windows and Mac OS X if the svn is in the PATH.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 00:12:53 +0000] rev 299
Refactor nearly all the soc.logic code to use the Base class
Instead of having a lot of duplicate code, this patch aims
to reduce this duplication by introducing a Base abstraction.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 00:08:54 +0000] rev 298
Replace almost all occurences of linkname with link_name
In an attempt to have some atomicness in these commits
this patch does a rename for the sake of consistency.
Not all were changed, but the next commit will address that.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 10 Oct 2008 13:14:24 +0000] rev 297
Load /Users/solydzajs/Downloads/google_appengine/ into
trunk/thirdparty/google_appengine.
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 10 Oct 2008 06:56:56 +0000] rev 296
Add missing __init__.py to soc/logic/helper folder (Caused home page not to work).
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 09 Oct 2008 23:50:00 +0000] rev 295
Removed now-obsolete getAltResponse* methods from simple.py
The getAltResponse* methods have been replaced by the check*
methods in soc.logic.helper.access.
Patch by: Sverre Rabbelier
Reviewed by: Pawel Solyga, Augie Fackler, Todd Larsen
Reviewed at: http://codereviews.googleopensourceprograms.com/1601
Review id: 1601
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 09 Oct 2008 23:48:20 +0000] rev 294
Refactor existing code to use the new access module
Instead of ending up with many different ways to do
access control, we end up having only one centralized
place wher access control is done.
Patch by: Sverre Rabbelier
Reviewed by: Pawel Solyga, Augie Fackler, Todd Larsen
Reviewed at: http://codereviews.googleopensourceprograms.com/1601
Review id: 1601
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 09 Oct 2008 23:38:27 +0000] rev 293
Add an access control module
The module's purpose is to check access requirements,
(such as being logged in), and raise an exception
containing a authentication request when the requirement
is not met.
Patch by: Sverre Rabbelier
Reviewed by: Pawel Solyga, Augie Fackler, Todd Larsen
Reviewed at: http://codereviews.googleopensourceprograms.com/1601
Review id: 1601
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 18:11:37 +0000] rev 292
Enable recently commited delete Sponsor request handler (added to map.py) and Delete button in Sponsor edit view. Still missing "Are you sure ?" question box.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 18:06:50 +0000] rev 291
Create a submit_buttons blocks in all edit view templates and put submit buttons in separate html table (not as part of the fields table anymore).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 15:10:51 +0000] rev 290
Create a submit_buttons block in group edit profile template so that submit buttons can be customized. Replace submit_message usage with new notice block (still work in progress in Lookup User views). Add customized edit profile template for Sponsor with delete button (not used yet, upcoming commit). Add delete Sponsor request handler.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 13:56:42 +0000] rev 289
Add notification bar block in base.html template.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 13:50:44 +0000] rev 288
Add #notice class declaration in soc.css for upcoming notification bar.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 13:49:41 +0000] rev 287
Update indexes in index.yaml file.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 08 Oct 2008 21:22:50 +0000] rev 286
Fix typo in getSponsorFromLinkName (key_name variable name instead of sponsor_key_name). Add deleteSponsor function for deleting Sponsor entities from datastore.
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 05 Oct 2008 13:27:49 +0000] rev 285
Style fix, as requested by Todd to dict usage
Use "dict['key'] = value" instead of "dict.update({'key' : 'value'})"
when updating only one key.
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 07:22:43 +0000] rev 284
Call soc.logic.site.map.getDjangoUrlPatterns() to construct the urlpatterns
from the site map, rather than explicitly listing them in app/urls.py.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 07:20:48 +0000] rev 283
Update soc/logic/site/sidebar.py to use parts of the "site map" in
soc/logic/site/map.py to generate portions of the sidebar menu.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 07:17:00 +0000] rev 282
A site layout ("site map") of the web application, including URL regular
expression patterns, Django views, and metadata for constructing sidebar menus
and (eventually) breadcrumbs.
One function, soc.logic.site.map.getDjangoUrlPatterns(), converts these details
into urlpatterns for use by Django.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 07:14:11 +0000] rev 281
Url and Page classes used to encapsulate the "site map" information (URL
regular expressions, Django views, menu item names, etc.) and the relation
between pages in the site map.
There are still lots of TODOs in this first pass.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 06:25:07 +0000] rev 280
urllib.quote() is needed by the soc/logic/site/map.py work, so import it from
the Python 2.5.2 sources. The entire urllib.py is not supported by Google
App Engine (yet?), since it relies on 'import socket' (App Engine provides a
separate urlfetch module instead).
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 05:00:13 +0000] rev 279
Remove now-empty soc/views/helpers (everything has moved to soc/views/helper).
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 04:51:43 +0000] rev 278
Add create() wrapper views that simply call the existing edit() views, to
produce unique view names in preparation for the soc/logic/site/map.py code.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 04:42:37 +0000] rev 277
Speed up average case by appending remainder of original choices list unchanged
(avoiding remaining str -> int type conversions) once the insertion point is
found.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 04:34:16 +0000] rev 276
Move helpers/html_menu.py to helper/html_menu.py, to clear out
soc/views/helpers for deletion.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 04:32:28 +0000] rev 275
A specialized SortedDict used by soc/logic/site/page.py.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 23:59:49 +0000] rev 274
Move helpers/forms_helpers.py to helper/forms.py.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 23:24:12 +0000] rev 273
Move helpers/templatetags to helper/templatetags.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 23:17:49 +0000] rev 272
Move helpers/response_helpers.py to helper/responses.py.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 23:08:28 +0000] rev 271
Replace helpers/custom_widgets.py with helper/widgets.py.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 23:01:49 +0000] rev 270
Move helpers/template_helpers.py to helper/templates.py.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 22:17:05 +0000] rev 269
Move helpers/request.py to helper/requests.py to avoid conflict with common
local variable name "request".
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 22:09:32 +0000] rev 268
Move helpers/list.py to helper/lists.py to avoid conflict with built-in type
name "list".
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 21:59:32 +0000] rev 267
Replace soc/views/helpers/request_helpers with soc/views/helpers/request.py
and replace uses of request_helpers. with helpers.request. instead.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 21:41:12 +0000] rev 266
Move soc/views/helpers/list_helpers.py to soc/views/helpers/list.py and change
uses from list_helpers. to helpers.list. instead.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 17:21:41 +0000] rev 265
List views should have a selectable pagination "page" length:
http://code.google.com/p/soc/issues/detail?id=59
Patch by: Chen Lunpeng and Todd Larsen
Review by: Augie Fackler
Review URL: http://codereviews.googleopensourceprograms.com/1201
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 07:03:11 +0000] rev 264
Change to imports to follow the style guide:
http://code.google.com/p/soc/wiki/PythonStyleGuide#Module_and_package_imports
Specifically:
"Use from x import y only when x is a package and y is a module."
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 01:32:34 +0000] rev 263
Make findNearestUsers() code in soc/logic/site/id_user.py more generic and
move it to soc/logic/model.py. Orginal findNearest...() functions in
id_user.py are now convenience wrappers.
Add typed-query string construction functions to model.py.
Move getFulLClassName() from key_name.py model.py, since it has more to do
with Model types than key names.
Swap 'offset' and 'limit' and make 'limit' arguments non-optional. Also,
stop adding 1 inside the ...ForLimitAndOffset() functions and make the
callers do it (since it was being added for a very UI-specific reason of
whether or not to display a "Next>" link).
Patch by: Todd Larsen
Review by: Pawel Solyga
Review URL: http://codereviews.googleopensourceprograms.com/1401
Todd Larsen <tlarsen@google.com> [Thu, 02 Oct 2008 20:22:15 +0000] rev 262
Factor out an isIdAvailable() function from EditForm.clean_id() in
soc/views/site/user/profile.py and add it to soc/logic/site/id_user.py.
Addresses some comments on r614.
Patch by: Todd Larsen
Review by: Pawel Solyga
Review URL: http://codereviews.googleopensourceprograms.com/1202
Todd Larsen <tlarsen@google.com> [Thu, 02 Oct 2008 15:37:18 +0000] rev 261
Add Allen (Chen Lunpeng) to trunk/AUTHORS, due to his several recent patches.
Todd Larsen <tlarsen@google.com> [Thu, 02 Oct 2008 15:36:08 +0000] rev 260
Fix typo in recent validate.py changes (r682).
Patch by: Chen Lunpeng
Review by: Todd Larsen
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 22:19:22 +0000] rev 259
Add basic Sponsors List, Create New Sponsor, Sponsor Public Profile views. Change all properties in Group model as required for now. Remaining TODO: write validation functions for Sponsor edit and create form fields that need additional validation (like address, phone number format).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 22:12:26 +0000] rev 258
Add Sponsor logic functions.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 22:10:52 +0000] rev 257
Add group templates that can be used by Sponsor, Organization, School, Club views. Right now only upcoming commit of Sponsor views is using it.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 22:02:50 +0000] rev 256
Remove excluded field inheritance_line, since the User model does not inherit
from PolyModel (at this time).
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 21:58:31 +0000] rev 255
Add colon at the of _readonly_field_as_table_row template tag label parameter. Replace hardcoded labels in User Public profile template with linkname_user.fields.<field_name>.label values.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 21:53:52 +0000] rev 254
Fix missing blank line to follow PythonStyleGuide in model.py.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 21:21:03 +0000] rev 253
Add links in sidebar for upcoming Sponsor views.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 21:19:32 +0000] rev 252
Change key_name module usage to path_linkname module (fix to previous commit). Add comments about urls. Add Sponsor views urls for upcoming Sponsor views modules.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 20:52:39 +0000] rev 251
Move path and link_name related functions and regex patterns to a new
soc/logic/path_linkname.py module, and fix all dependencies. path/link_name
functionality is becoming the generic way to identify entities in the Datastore
in a URL-compatible way.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 20:48:58 +0000] rev 250
Make form field components use a smaller font, without shrinking the font
of all text in the page body.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 19:21:09 +0000] rev 249
Replace common module with validate module. Move validation function from feed module to validate module and remove feed.py. Correct any usage of validation functions from common and feed modules into validate module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 19:17:13 +0000] rev 248
Add missing blank line to follow PythonStyleGuide in document.py
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 19:15:20 +0000] rev 247
Fixed typo in DEF_CREATE_NEW_DOC_MSG.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 16:47:00 +0000] rev 246
Shrink the sidebar menu separately from the main body text.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 14:23:28 +0000] rev 245
Moved isLinkNameFormatValid function out of id_user module to new common module. This function is going to be used by other form validation functions that require to validate linkname (different kind of Groups, Programs etc).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 09:43:25 +0000] rev 244
Fixed models based on output from graph.py script and comments on
http://groups.google.com/group/melange-soc-dev/browse_thread/thread/fb532a7db1f19ea7
Tim Ansell <mithro@gmail.com> [Wed, 01 Oct 2008 07:26:45 +0000] rev 243
Tool to graph the data model.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 07:11:27 +0000] rev 242
Some TODOs on access control that I didn't want to forget.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 07:10:43 +0000] rev 241
Matching just /docs created a very small namespace, since any other path parts
would match the Document path. So, append /show after /docs for the display
view. This makes other views like /docs/edit possible later.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 07:01:06 +0000] rev 240
URL pattern changes that were missed by r671.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 07:00:26 +0000] rev 239
Some styles used by r671, the simplistic Document view.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 06:59:51 +0000] rev 238
A very simplistic Document viewer.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 06:24:17 +0000] rev 237
Implements a Site (Developer) generic Document editor form.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 06:03:53 +0000] rev 236
Changes to make breadcrumbs match page title. This is mostly to see how it
looks, since the new soc/logic/site/map.py code is going to implement the
breadcrumbs and page title contents in a similar way.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 05:17:15 +0000] rev 235
Start using "Site" instead of "Developer" in the UI.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 05:15:29 +0000] rev 234
Implement a Developer list view of all Documents.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 05:10:41 +0000] rev 233
Add missing all() __doc__ string comments: "Args:" and "Returns:" sections.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 05:02:42 +0000] rev 232
Fix some style guide issues: keyword arguments are supposed to always be
supplied using the keyword argument name=value.
http://code.google.com/p/soc/wiki/PythonStyleGuide#Default_Argument_Values
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 02:23:30 +0000] rev 231
Directory for up-coming /site/docs/list and /site/docs/edit templates.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 02:13:54 +0000] rev 230
Fix typo in findNearestUsersOffset() __doc__ string missed in r661.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 02:11:56 +0000] rev 229
Show link to /site/user/list on /site/user/lookup when User is not found.
http://code.google.com/p/soc/issues/detail?id=61
Patch by: Chen Lunpeng
Review by: Todd Larsen (with modifications)
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 02:02:44 +0000] rev 228
Add placeholder for future (to-be-implemented) getPreferredListPagination()
function.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:53:36 +0000] rev 227
Remove a TODO that should have been removed for r658.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:51:49 +0000] rev 226
Update some of the URL patterns to get their link_name parsing from the new
patterns in key_name.py. (Using it like this in urls.py is why key_name.py
needs to not depend on other modules...)
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:48:46 +0000] rev 225
Add functions to soc/logic/document.py for dealing with partial_paths combined
with link_names. Add getWorksForOffsetAndLimit() to query for Documents for
the /site/docs/list view.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:45:30 +0000] rev 224
Hide PolyModel inheritance_line bookkeeping property from the User Profile
form.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:43:07 +0000] rev 223
Use the LINKNAME_PATTERN from its new home in key_name.py. Also, add some
missing blank lines that are required by the style guide.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:41:18 +0000] rev 222
Add lots of new functions to key_name.py, including path/link_name processing.
Copy various link_name related regex patterns to key_name.py and use them.
Add error checking that raises a key_name.Error exception when name...()
functions are given empty arguments. Hard-code class names, since they match
what was typed into the module.class.__name__ to get the name anyway. This
eliminates dependencies on any modules by key_name.py.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:35:29 +0000] rev 221
Add sidebar menu items for /site/docs/list and /site/docs/edit. They do not
currently have view functions attached, but there are other links in the
mock-up portion of the sidebar that don't currently work, either. The goal
is to commit the /site/docs/list and /site/docs/edit changes in small bits
that don't break anyone else.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:33:43 +0000] rev 220
Add partial_path property explicitly to the Work model.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:25:31 +0000] rev 219
Should have been part of the r650 commit.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:23:32 +0000] rev 218
Directory for upcoming /site/docs views.
Todd Larsen <tlarsen@google.com> [Tue, 30 Sep 2008 17:03:51 +0000] rev 217
Add "Last updated" footer to front page body text, using the modified Property
from the Work entity.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 16:53:30 +0000] rev 216
Change _readonly_field_as_table_row <td> tag class names to match those used in _field_as_table_row. That should actually go into previous commit.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 16:49:54 +0000] rev 215
Clean up too long lines in profile.py. Add ReadOnlyInput widget to custom_widgets module, it can be used to display read-only form fields. Display read-only "Id" field in LookUp view if user has been found and in User Edit Developer view.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 16:26:30 +0000] rev 214
Add polymodel folder to DEFAULT_APP_DIRS variable in make_release.sh script.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 15:21:05 +0000] rev 213
Add key naming function for Sponsor, School, Organization, Club key_names.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 14:00:11 +0000] rev 212
Add org ReferenceProperty to Administrator model (many:1 relationship associating Administrators with specific Organization). Update Organization model __doc__ string with information about the back-reference 'admins'.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 12:59:59 +0000] rev 211
Made mce_settings class variable in TinyMCE widget a copy of default settings instead of reference.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 12:47:05 +0000] rev 210
Replaced context.update call to simple value assignment in site.user.profile.create view function.
Todd Larsen <tlarsen@google.com> [Mon, 29 Sep 2008 17:22:31 +0000] rev 209
Load ../../google_appengine/ into trunk/thirdparty/google_appengine.
Todd Larsen <tlarsen@google.com> [Mon, 29 Sep 2008 15:46:42 +0000] rev 208
Take advantage of the Model inheritance provided by polymodel.PolyModel to
have Club, School, Sponsor, and Organization actually inherit from the Group
Model class, rather than being composed via ReferenceProperties.
Patch by: Todd Larsen
Review by: Pawel Solyga, Sverre Rabbelier, Augie Fackler
Review URL: http://codereviews.googleopensourceprograms.com/606
Todd Larsen <tlarsen@google.com> [Mon, 29 Sep 2008 15:34:40 +0000] rev 207
Take advantage of the Model inheritance provided by polymodel.PolyModel to
have create a class hierarchy rooted at Person.
Also, add some missing Role classes, such as Role, (Organization) Mentor,
(Club) Member, (School) Student. Make (Organization) Administrator be a
Reviewer like Mentor is.
Patch by: Todd Larsen
Review by: Pawel Solyga, Sverre Rabbelier, Augie Fackler
Review URL: http://codereviews.googleopensourceprograms.com/607
Todd Larsen <tlarsen@google.com> [Mon, 29 Sep 2008 15:31:50 +0000] rev 206
Make use of PolyModel for Works, Documents, etc. Add some (but not all) of
the missing Models related to Documents. Refactor site settings to be useful
for any "/home" page view. Make the resulting home settings store a reference
to the Document, rather than looking up the Document by a hard-code key name.
This is to set the stage for Document editing being generic, and then being
able to select from some existing documents which one to use as the "/home"
static content. This makes it possible to pre-edit several Documents, have
them Reviewed, and then quickly change the "/home" page content as a setting,
rather than editing the Document in the settings form (though settings forms
might still embed the current document into their form for convenience).
Patch by: Todd Larsen
Review by: Pawel Solyga
Review URL: http://codereviews.googleopensourceprograms.com/1001
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 29 Sep 2008 14:03:45 +0000] rev 205
Fixed not working "Create New User" view which was caused by adding key_name into User Edit Developer view. This commit divides edit() view function in soc.views.site.user.profile into edit() and create() request handlers. New create() request handler is used only in "Create New User" view and has specific form validation functions and uses updateOrCreateUserFromId() instead of updateUserForKeyName().
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 26 Sep 2008 19:47:07 +0000] rev 204
Add ModelWithFieldAttributes *before* PolyModel, so that everything does not
become a "ModelWithFieldAttributes" in the Datastore.
The way PolyModel works, each Model class hierarchy is stored in the Datastore
as the class that directly inherited from PolyModel. So, we do not want to
insert ModelWithFieldAttributes *after* PolyModel by inheriting *from*
PolyModel, or everything would just be a ModelWithFieldAttributes in the
Datastore, instead of Person, Work, Group, etc.
Todd Larsen <tlarsen@google.com> [Fri, 26 Sep 2008 19:35:21 +0000] rev 203
Add the third-party PolyModel class. This class supports inheritance in
Google App Engine Datastore Model classes.
Todd Larsen <tlarsen@google.com> [Thu, 25 Sep 2008 17:17:11 +0000] rev 202
A key_name controller module to collect all of the name...() functions that
compose Model entity key names, plus some minor changes to other controller
modules to illustrate the proposed use.
Patch by: Todd Larsen
Review by: Pawel Solyga
Review URL: http://codereviews.googleopensourceprograms.com/804
Review URL: http://codereviews.googleopensourceprograms.com/804
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 24 Sep 2008 21:23:42 +0000] rev 201
Fixed missing urlparse import in request_helpers which cause /user/profile and /site/user/profile not to work at all. Removed not used module imports in response_helpers.py.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 06:00:28 +0000] rev 200
Replace mock-up of sidebar with first draft of dynamic sidebar functionality.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 05:58:45 +0000] rev 199
Minor tweaks to Site menu item names to make them more descriptive.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 05:58:15 +0000] rev 198
Major refactoring, to switch from using inheritance from soc.logic.menu classes
to an envelope-letter model instead.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 05:17:44 +0000] rev 197
Sidebar-building controller, with a TODO remaining to implement marking the
current page as "selected".
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:46:52 +0000] rev 196
Make views.helpers.html_menu MenuItem classes and logic.menu MenuItem classes
more closely related. This is part of some refactoring in my working copy
to keep soc/logic/site/sidebar.py from having to deal with html_menu classes
(which is like having view code in the controller, which is bad).
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:36:47 +0000] rev 195
Classes that wrap soc.logic.menu.Menu and soc.logic.menu.MenuItem to produce
HTML renderings of such lists.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:27:01 +0000] rev 194
Change indentation level to 2 (from 4) and rename MCE_DEF_SETTINGS to
DEF_MCE_SETTINGS to match the "default constant" naming convention elsewhere
in the code.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:24:49 +0000] rev 193
Note 'groups' back-reference from 'founder' property in soc.models.group.Group.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:23:32 +0000] rev 192
Simple MenuItem and Menu classes for keeping track of ordered menus.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:22:12 +0000] rev 191
These changes should have been in r620, but somehow I did not save them, or
saved over them with an old copy in the editor. Not sure...
Todd Larsen <tlarsen@google.com> [Tue, 23 Sep 2008 23:30:15 +0000] rev 190
Move isReferrerSelf() and replaceSuffix() into new request_helpers.py module,
since they are (mainly) used to manipulate parts of an HTTP request.
Todd Larsen <tlarsen@google.com> [Tue, 23 Sep 2008 23:20:23 +0000] rev 189
Split out HTTP request manipulation functions from template_helpers.py, which
is in danger of becoming a "misc" or "util" module unnecessarily.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 23 Sep 2008 19:20:57 +0000] rev 188
Changes in TinyMCE widget in custom_widgets.py based on review comments.
Patch by: Pawel Solyga
Review url: http://code.google.com/p/soc/source/detail?r=550
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 23 Sep 2008 17:55:54 +0000] rev 187
Change user list view instruction. Don't show "Next >" disabled greyed text in the list pagination if there is only one page.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 22 Sep 2008 14:13:32 +0000] rev 186
Add Users List Developer view which is available at /site/user/list. Add User list custom templates which are used with list_helpers. Add "Users List" link in base.html template.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 22 Sep 2008 14:08:37 +0000] rev 185
Add list_helpers functions that are going to be used when rendering list views like (Users List, Sponsors List etc).
Add list default templates and CSS classes.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 22 Sep 2008 13:42:53 +0000] rev 184
Add support for changing User id (Google Account email) in User Profile Developer view. Now user profile developer edit view includes hidden key_name field. Fix typo in user/profile.py. Show former user ids in lookup and edit User Profile Developer views.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 21 Sep 2008 08:59:11 +0000] rev 183
Small change to unescape function in template_helpers (move replace('&', '&') at the end).
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 21 Sep 2008 08:56:52 +0000] rev 182
Add rounded corners graphics. Add .notice class and rounded corners classes to soc.css file, those will be used to better visualize submit_message like "Profile saved.".
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 21 Sep 2008 08:50:42 +0000] rev 181
Remove Author model (use Person instead). Update models after removing Author. Add new Sponsor, Organization models.
Patch by: Pawel Solyga
Reviewed by: Todd Larsen
Review issue: 801
Review URL: http://codereviews.googleopensourceprograms.com/801
Augie Fackler <durin42@gmail.com> [Sun, 21 Sep 2008 02:16:00 +0000] rev 180
Two changes to ease CI:
1) If pysvn is missing, the tests for svn_helper don't run and pollute the
output
2) svn_helper no longer depends on being located at trunk/scripts/
Patch by: Augie Fackler
Review by: Todd Larsen
Review Issue: 802
Reviewed URL: http://codereviews.googleopensourceprograms.com/802
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 20 Sep 2008 19:04:43 +0000] rev 179
Add custom 404 error message with link to "Create a New User" which is displayed when linkname in User Profile Developer view URL (/site/user/profile/<linkname>) doesn't exist. Add default value (None) to new_suffix parameter of template_helpers replaceSuffix and redirectToChangedSuffix functions.
Augie Fackler <durin42@gmail.com> [Sat, 20 Sep 2008 17:39:07 +0000] rev 178
Testing buildbot. Sorry about the noise. (Last one for now, I've got most of the kinks figured out I think)
Augie Fackler <durin42@gmail.com> [Sat, 20 Sep 2008 16:50:20 +0000] rev 177
Testing buildbot. Sorry about the noise.
Augie Fackler <durin42@gmail.com> [Sat, 20 Sep 2008 16:47:09 +0000] rev 176
Testing buildbot. Sorry about the noise.
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 21:11:39 +0000] rev 175
Make django.zip in release/, instead of in app/ with a symlink in release/.
This allows debugging into app/django source code, which the presence of
app/django.zip was blocking. Tested with both:
dev_appserver.py release
and
dev_appserver.py app
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 18:02:37 +0000] rev 174
A rough draft of the Group Model, to be merged with Pawel's current effort in
his working copy. This is *very* incomplete...
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 17:51:33 +0000] rev 173
First pass (from some old code notes) of a School Model (a form of Group).
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 17:47:21 +0000] rev 172
First pass (from some old code notes) of a Club Model (a form of Group).
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 19 Sep 2008 12:45:13 +0000] rev 171
Bug fixes to revision r596. User Account field in Developer User Profile view needs to be an email not a login name. Header title of User Profile Developer view, when form validation failes is now showing correct value ("Modify existing ..." instead of "Create new user ...").
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 05:15:20 +0000] rev 170
Add /site/user/profile Developer view for editing arbitrary User entities.
Update /user/profile edit() view to fix TODO about updating the URL when a
POST of the form changes the link_name of the User. Add a Create New User
link to the base.html sidebar mock-up.
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 05:12:35 +0000] rev 169
Fix off-by-one corner case discovered during testing of /user/profile.
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 04:50:42 +0000] rev 168
Added getSingleIndexedParamValue() that retrieves an index into a list of
values from the named query parameter, and then indexes into the supplied list
of values to return the corresponding value from the list. Used to convert
numeric index query parameters passed by POST to the GET redirect target, so
that the GET code can display messages, etc. (without passing the message
itself as a query argument and having to escape it or have silly people pass
in their own...).
Todd Larsen <tlarsen@google.com> [Fri, 19 Sep 2008 04:28:17 +0000] rev 167
Added replaceSuffix(), isReferrerSelf(), and redirectToChangedSuffix() to
implement the TODO in the User profile views where the link name portion of
the URL needs to change when the link_name Property is updated by the form.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 18 Sep 2008 23:07:06 +0000] rev 166
Fixed too long lines and deleted unused imports in id_user.py.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 18 Sep 2008 22:14:06 +0000] rev 165
New default values for page title, header title and body of site home page.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 18 Sep 2008 22:11:56 +0000] rev 164
Documentation updates and one typo fix.
Todd Larsen <tlarsen@google.com> [Thu, 18 Sep 2008 17:33:20 +0000] rev 163
Add a td.formfielderrorlabel style, to highlight field labels that have errors.
Todd Larsen <tlarsen@google.com> [Thu, 18 Sep 2008 17:32:28 +0000] rev 162
Swap field value and "required" columns to make more columns for field errors.
Todd Larsen <tlarsen@google.com> [Thu, 18 Sep 2008 17:31:01 +0000] rev 161
Add a verbose_name and help_text to the User.id Property.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 18:02:09 +0000] rev 160
Explain why pushd and popd are needed when making tiny_mce.zip.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 18:00:55 +0000] rev 159
Use zip to compress tiny_mce, and use zipserve to serve it in Google App
Engine.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 16 Sep 2008 17:38:09 +0000] rev 158
Updated make_release.sh docs and added way for person invoking the script to override script variables such as RELEASE using something like "RELEASE=../testing_release ./make_release.sh".
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 17:07:58 +0000] rev 157
Add recently-moved feedparser and tiny_mce to APP_DIRS.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 17:05:43 +0000] rev 156
Oops, this should have been part of the r580 commit.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 17:05:07 +0000] rev 155
Oops, this should have been part of the r577 commit.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 16:49:25 +0000] rev 154
Move third-party TinyMCE out of soc/content/js and into the application image
root, like other third-party code. Update the app.yaml.template to add
/tiny_mce as a source of static content.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 16:42:55 +0000] rev 153
Add README files to explain how third-party code is maintained in these
directories.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 16:24:18 +0000] rev 152
Discourage third-party code from being embedded in the soc framework.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 16:22:49 +0000] rev 151
Move third-party feedparser.py out of the soc framework package into its own
package (similar to django).
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 16 Sep 2008 15:56:15 +0000] rev 150
Changed ZIPFILE variable to DJANGO_ZIPFILE in make_release.sh script and added 'cd $APP_FOLDER' before we zip django.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 02:28:33 +0000] rev 149
Load ../google_appengine into trunk/thirdparty/google_appengine.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 01:18:49 +0000] rev 148
upload.py customized to work with codereviews.googleopensourceprograms.com.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 01:18:15 +0000] rev 147
Pristine initial commit of upload.py script from
http://code.google.com/p/rietveld (r310).
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 01:15:00 +0000] rev 146
gcl.py customized to work with codereviews.googleopensourceprograms.com and the
melange-soc-dev@googlegroups.com mailing list.
Todd Larsen <tlarsen@google.com> [Tue, 16 Sep 2008 01:14:18 +0000] rev 145
Pristine initial commit of gcl.py script from chromium.org.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 14 Sep 2008 20:32:32 +0000] rev 144
Release shell script and associated changes. Set svn:ignore property on /app/django.zip file and /release folder.
Patch by: Pawel Solyga, Augie Fackler
Review by: Todd Larsen, review-after-commit
Review issue: 363
Review URL: http://codereviews.googleopensourceprograms.com/363
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 14 Sep 2008 00:23:49 +0000] rev 143
FIxed documentation in soc/logic/document.py for getDocumentFromPath function
Patch by: Christian López EspÃnol
Reviewed by: Pawel Solyga
Reviewed via: discussion on melange-soc-dev group
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 13 Sep 2008 22:53:07 +0000] rev 142
Forgot to change widgets to custom_widgets import in home.py after changing the name of soc/views/helpers/widgets.py file.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 13 Sep 2008 22:00:51 +0000] rev 141
Added Melange front page edit view where you can change title, content, feed url. Created SiteSettings and Document models and some logic for them. Added isFeedURLValid function in soc/logic/feed.py. Created some functions for handling datastore updates of different kinds of Models (soc/logic/model.py). Fixed some typos and too long lines of code.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 13 Sep 2008 21:27:17 +0000] rev 140
Added feedparser to soc/utils and modified svn:externals for vendor to include feedparser svn
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 12 Sep 2008 21:54:37 +0000] rev 139
Add getAltResponseIfNotLoggedIn() and getAltResponseIfNotDeveloper() simple
view helpers. These cannot go into response_helpers.py because they create
a circular reference with simple.py, and Django view import fails.
Review URL: http://codereviews.googleopensourceprograms.com/602
Todd Larsen <tlarsen@google.com> [Fri, 12 Sep 2008 20:36:17 +0000] rev 138
Improve the __doc__ string of isIdDeveloper() to explain better how it now
functions.
Todd Larsen <tlarsen@google.com> [Fri, 12 Sep 2008 20:31:56 +0000] rev 137
Make isIdDeveloper() also able to check an is_developer Boolean property in
User entities.
Review URL: http://codereviews.googleopensourceprograms.com/601
Todd Larsen <tlarsen@google.com> [Fri, 12 Sep 2008 19:01:44 +0000] rev 136
Replace checkLinkNameForId() with isLinkNameAvailableForId(), and implement
that new function in terms of only the existing doesLinkNameExist() and
doesLinkNameBelongToId().
Patch by: Todd Larsen
Review by: Pawel Solyga
Review via: discussion of patches on melange-soc-dev mailing list
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 12 Sep 2008 16:33:04 +0000] rev 135
Fixed one typo in response_helpers which caused is_admin context variable not to work correctly.
Created new checkLinkNameForId function that checks if link_name is correct when creating new user and modifying existing one. This is now used for validation instead of doesLinkNameBelongToId in UserForm clean_link_name function. The previous validation function didn't allow to create new users and modify linkname of existing ones. Additionally I created new doesLinkNameExist helper function.
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 12 Sep 2008 10:56:21 +0000] rev 134
Fixed wrong user variable in lookup.html template for edit link (was user should be found_user).
There is no DeveloperForm in site/user/profile.py changed that to LookupForm.
Todd Larsen <tlarsen@google.com> [Fri, 12 Sep 2008 02:46:21 +0000] rev 133
gcl.py committed this file, when it should not have even existed.
Todd Larsen <tlarsen@google.com> [Fri, 12 Sep 2008 02:37:15 +0000] rev 132
Add a /site/user/lookup view that provides Developers with a form to look up
User entities given email addresses or link names.
Todd Larsen <tlarsen@google.com> [Fri, 12 Sep 2008 02:12:38 +0000] rev 131
...
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 11 Sep 2008 21:30:08 +0000] rev 130
Updated the script to:
* Include a comment describing what it does
* Use variables for anything non-standard
* Use the --parse-only flag of epydoc
* Exclude all 'django' modules through --exclude=
* Run on '../app' by default, no more arguments needed
* Clean up the output directory before running
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 11 Sep 2008 20:50:58 +0000] rev 129
Bugfix, invalid syntax noticed by epydoc.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 11 Sep 2008 12:06:57 +0000] rev 128
Updated docs in response_helpers.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 11 Sep 2008 12:01:20 +0000] rev 127
Created custom_widgets.py and added TinyMCE django widget that can be later used for particular form fields.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 11 Sep 2008 11:56:24 +0000] rev 126
Added TinyMCE to Melange in soc/content/js
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 30 Aug 2008 02:54:22 +0000] rev 125
An emerging pattern with makeSiblingTemplatesList() is that views calling that
function then append a known, default template "just in case". This change
adds a default_template parameter to makeSiblingTemplatesList() to eliminate
the extra "append a known default to the end" step for the caller.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 29 Aug 2008 04:24:31 +0000] rev 124
Refactor soc/views/user/profile.py to make use of several of the new views
available in soc/views/simple.py.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 29 Aug 2008 02:59:59 +0000] rev 123
Fix an overlooked cut-and-paste error.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 29 Aug 2008 02:52:02 +0000] rev 122
Add a public() convenience wrapper around templateWithLinkName() for the common
public.html case. Add a requestLogin() view.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 29 Aug 2008 00:00:34 +0000] rev 121
This CSS change belonged with soc/templates/soc/error.html committed in r454.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 28 Aug 2008 23:56:29 +0000] rev 120
A default error.html template to go with the simple.errorResponse() view.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 28 Aug 2008 23:54:35 +0000] rev 119
Add soc.views.simple containing (initially) two simple template views.
templateWithLinkName() is a view that can replace most public() read-only
views. errorResponse() is a view that renders an error page for
out_of_band.ErrorResponse exceptions. Also, change response_helpers.respond()
to accept keyword arguments to pass to http.HttpResponse(). (errorResponse()
makes use of this new respond() feature.)
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 28 Aug 2008 22:27:40 +0000] rev 118
Clean up User Model and User profile edit view now that soc.logic.site.id_user
module exists. Change usage of "user" to be "id" the variable refers to a
Google Account and not a User entity.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 28 Aug 2008 22:23:11 +0000] rev 117
Pawel and I were working on the same thing, apparently. My template_helpers.py
is more complete, so I am removing this one (that Pawel appears to not have
used yet).
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 28 Aug 2008 22:06:31 +0000] rev 116
Factor out a getUniversalContext() function so that views that do not call
response_helpers.response() can benefit from the code that constructs shared
template context variables common to many templates.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 28 Aug 2008 21:49:53 +0000] rev 115
Create a package for controller modules that interact with User entities.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 28 Aug 2008 21:35:34 +0000] rev 114
A collection of functions for determining the characteristics of the "system"
on which a Melange application is running. Currently, this consists of only
a boolean isDebug() function.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 28 Aug 2008 21:30:55 +0000] rev 113
Helpers for manipulating templates and template search paths.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 28 Aug 2008 21:15:39 +0000] rev 112
Consolidate functions dealing with Google Accounts and look-up of User entities
into a single site-wide controller module. Tests will be added in a subsequent
commit as soon as Google App Engine tests using mocker are figured out.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 28 Aug 2008 16:17:42 +0000] rev 111
Exception classes used by controller logic to request an "out-of-band" response
be displayed by the view instead of what the view would normally display.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 27 Aug 2008 21:21:44 +0000] rev 110
Base classes for all Datastore Models in Melange.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 26 Aug 2008 21:49:54 +0000] rev 109
Load ../../google_appengine into trunk/thirdparty/google_appengine.
Todd Larsen <tlarsen@google.com> [Tue, 26 Aug 2008 21:37:29 +0000] rev 108
Create directories to load project into.
* trunk/thirdparty/google_appengine: New directory.
Todd Larsen <tlarsen@google.com> [Tue, 26 Aug 2008 21:29:33 +0000] rev 107
Move third-party code that is not required to be part of trunk/app into a
trunk/thirdparty "sandbox".
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 26 Aug 2008 21:26:38 +0000] rev 106
Move third-party code that is not required to be part of trunk/app into a
trunk/thirdparty "sandbox".
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 26 Aug 2008 21:24:50 +0000] rev 105
Remove the obsolete scripts left over from when trunk/app did not contain the
entire Google App Engine image.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 26 Aug 2008 21:22:29 +0000] rev 104
Add mocker 0.10.1 to trunk/thirdparty, so that it can be used to create mocks
for testing the Google App Engine app itself. See also:
http://blog.appenginefan.com/2008/06/unit-tests-for-google-app-engine-apps.html
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 26 Aug 2008 21:20:44 +0000] rev 103
Move LICENSE.django closer to the actual trumk/app/django code we are importing
(that exists in trunk/app to be part of the Google App Engine image).
LICENSE.django cannot go in trunk/app/django itself, because that directory is
maintained from the /vendor/django svn external using svn_load_dirs.pl (so
putting all the way into trunk/app/django gets it repeatedly removed).
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 26 Aug 2008 21:05:43 +0000] rev 102
Third-party packages that do not need to be part of trunk/app (because they are
not part of a Google App Engine image upload).
Todd Larsen <tlarsen@google.com> [Tue, 26 Aug 2008 21:04:45 +0000] rev 101
Since google_appengine isn't part of the uploaded trunk/app, there is no reason
why it couldn't be in a thirdparty directory, alongside mocker.
Todd Larsen <tlarsen@google.com> [Tue, 26 Aug 2008 20:20:50 +0000] rev 100
Create directories to load project into.
* trunk/google_appengine: New directory.
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 22 Aug 2008 13:44:50 +0000] rev 99
Added public view support (not using controller yet)
Changed Google Account variable from user to id in views and templates (no more confusions with Melange user).
Added templates_helpers for makeSimblingTemplate function.
Addded new template tag readonly_field_as_table_row used in public views
Fixed one typo in roles.py
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 20 Aug 2008 21:59:00 +0000] rev 98
User Profile view (without controller yet).
Patch by: Pawel Solyga
Review by: Todd Larsen
Review issue: 386
Review URL: http://codereviews.googleopensourceprograms.com/386
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 20 Aug 2008 18:36:55 +0000] rev 97
Moved Proposal model from wiki to source code and updated ProposalModel wiki page.
Patch by: Pawel Solyga
Review by: Todd Larsen
Review issue: 362
Review URL: http://codereviews.googleopensourceprograms.com/362
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 20 Aug 2008 10:14:49 +0000] rev 96
Moved td.formfieldlabel to FORM TABLE FIELDS section.
Todd Larsen <tlarsen@google.com> [Wed, 20 Aug 2008 02:30:44 +0000] rev 95
Move soc/control to soc/logic, so that tab-completion doesn't keep matching
soc/content instead.
Todd Larsen <tlarsen@google.com> [Wed, 20 Aug 2008 01:54:11 +0000] rev 94
nickname was moved from Person to User recently.
Todd Larsen <tlarsen@google.com> [Wed, 20 Aug 2008 00:19:49 +0000] rev 93
Add Roles template directory that was missing from r426 commit.
Todd Larsen <tlarsen@google.com> [Wed, 20 Aug 2008 00:18:56 +0000] rev 92
Create package for up-coming Role views.
Todd Larsen <tlarsen@google.com> [Wed, 20 Aug 2008 00:18:10 +0000] rev 91
Minor indentation fix.
Todd Larsen <tlarsen@google.com> [Wed, 20 Aug 2008 00:17:13 +0000] rev 90
Create package for standard Melange controller modules.
Todd Larsen <tlarsen@google.com> [Wed, 20 Aug 2008 00:16:27 +0000] rev 89
Reduce the indent to two spaces per hierarchy level, comment some groups of
tags that are related, move #header down by #footer.
Todd Larsen <tlarsen@google.com> [Wed, 20 Aug 2008 00:10:59 +0000] rev 88
Some additional __doc__ comments (with some ideas for future plans) and removal
of some unnecessary imports.
Todd Larsen <tlarsen@google.com> [Wed, 20 Aug 2008 00:08:31 +0000] rev 87
Clean up some deletions from previous rearranging that did not get committed.
Todd Larsen <tlarsen@google.com> [Wed, 20 Aug 2008 00:04:42 +0000] rev 86
Fix up the URLs mapping to soc.views.user.profile.edit() and make the site base
template (mostly a mock-up) point to /user/profile instead of the old
/usr/linkname/profile from the static mock-up.
Todd Larsen <tlarsen@google.com> [Wed, 20 Aug 2008 00:02:49 +0000] rev 85
Move soc.views.user.profile.profile() to soc.views.user.profile.edit().
Todd Larsen <tlarsen@google.com> [Tue, 19 Aug 2008 23:51:31 +0000] rev 84
Flesh out the user/roles placeholders a little bit more.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 19 Aug 2008 23:13:24 +0000] rev 83
Created response helper respond() function that is used to generate base templates and it's child templates (handles sign in/out links, user name etc).
Updated User model helper text.
Added basic user profile view (not finished yet).
Added css entries for buttons and added buttons background.
Added /user/profile and /user/profile/linkname support in urls.py.
Todd Larsen <tlarsen@google.com> [Tue, 19 Aug 2008 22:37:40 +0000] rev 82
Create placeholders for User Roles prototype.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 19 Aug 2008 22:26:24 +0000] rev 81
Moved soc/site/home.html to soc/site/home/public.html and updated default template for public() in home.py
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 19 Aug 2008 18:06:23 +0000] rev 80
Indents in css file are now 2 spaces long.
Patch by: Pawel Solyga
Review by: Todd Larsen
Review issue: 385
Review URL: http://codereviews.googleopensourceprograms.com/385
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 19 Aug 2008 17:57:58 +0000] rev 79
Home site templates and basic view.
Patch by: Pawel Solyga
Review by: Todd Larsen
Review issue: 385
Review URL: http://codereviews.googleopensourceprograms.com/385
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 19 Aug 2008 17:52:13 +0000] rev 78
Updated User and Person models.
Patch by: Pawel Solyga
Review by: Todd Larsen
Review issue: 382
Review URL: http://codereviews.googleopensourceprograms.com/382
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 19 Aug 2008 17:49:59 +0000] rev 77
Debug flag value depends now on App Engine environment.
Patch by: Pawel Solyga
Review by: Todd Larsen
Review issue: 381
Review URL: http://codereviews.googleopensourceprograms.com/381
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 18 Aug 2008 23:39:58 +0000] rev 76
Changed name of the custom logo file. Now file name describes better image content.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 18 Aug 2008 22:09:43 +0000] rev 75
Added logo for Melange home site (this will be used soon)
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 18 Aug 2008 17:00:23 +0000] rev 74
Added 404 and 500 errors templates. You need to set DEBUG = False in Settings.py in order to see the pages.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 18 Aug 2008 16:58:23 +0000] rev 73
Created robots.txtx and simple Melange favicon.
Added favicon and robots.txt support in app.yaml template.
Todd Larsen <tlarsen@google.com> [Wed, 13 Aug 2008 21:52:40 +0000] rev 72
Make soc.googlecode.com serve up mock-up pages as text/html.
Todd Larsen <tlarsen@google.com> [Wed, 13 Aug 2008 21:48:11 +0000] rev 71
Add a mock-up of a previously-run (but not currently running) Program.
Todd Larsen <tlarsen@google.com> [Wed, 13 Aug 2008 21:45:59 +0000] rev 70
Re-arrange mock-up paths for program/docs so that they go from less-specific
(e.g. ghop2008, gsoc2009 program linknames) to more-specific (tos, rules,
faqs document linknames). This matches the pattern of all of the other view
paths, from "view descriptors" (like program/docs) to the specific item
(ghop2008/rules).
Todd Larsen <tlarsen@google.com> [Wed, 13 Aug 2008 21:35:22 +0000] rev 69
New mockup for User Roles page.
Todd Larsen <tlarsen@google.com> [Wed, 13 Aug 2008 20:33:25 +0000] rev 68
Relative URL path structure example for Organization admin role, for a specific
Program. View mock-up form will be added later.
Todd Larsen <tlarsen@google.com> [Wed, 13 Aug 2008 20:30:48 +0000] rev 67
Fix some broken links in the GHOP 2008 Program home page mock-up.
Todd Larsen <tlarsen@google.com> [Mon, 11 Aug 2008 16:57:46 +0000] rev 66
Finished migrating the "proto" app (which only contained a Person profile edit
form) to the new combined trunk/app layout. Also, moved the form template
from profile.html to profile/edit.html, to follow the "one template per view"
approach (rather than have read-write vs. read-only logic in a single
template).
Todd Larsen <tlarsen@google.com> [Mon, 11 Aug 2008 16:44:47 +0000] rev 65
Move app.yaml to app.yaml.template and add app.yaml to svn:ignore in trunk/app.
Each Google App Engine instance needs its own "application:" ID, and this
should *not* be committed into the SoC SVN repository in trunk/app. (Individual
deployment branches *will* have app.yaml files with Google App Engine
application IDs in them, just not trunk/app.)
Todd Larsen <tlarsen@google.com> [Mon, 04 Aug 2008 22:43:48 +0000] rev 64
Remove last remnants of /thirdparty/.
Todd Larsen <tlarsen@google.com> [Mon, 04 Aug 2008 22:38:35 +0000] rev 63
Move tests/ to top level of trunk/. Fix tests to run from new location. Add
missing __init__.py modules to make relative imports from tests work properly.
Todd Larsen <tlarsen@google.com> [Mon, 04 Aug 2008 22:09:35 +0000] rev 62
Finish moving the remaining "prototype" app pieces out of apps/proto,
and then remove trunk/apps. There is still some editing to do in the
newly-relocated files (now in trunk/app/soc and trunk/app/ghop).
Todd Larsen <tlarsen@google.com> [Mon, 28 Jul 2008 21:27:52 +0000] rev 61
Change the MIME type of the remaining .html files to text/html
Todd Larsen <tlarsen@google.com> [Mon, 28 Jul 2008 20:59:03 +0000] rev 60
Set svn:mime-type to text/css so that browsers will use it as CSS when loaded
from http://soc.googlecode.com/svn/trunk/mockups/
Todd Larsen <tlarsen@google.com> [Mon, 28 Jul 2008 20:44:54 +0000] rev 59
Set svn:mime-type to text/html so that browser will render the page when viewed
via the http://soc.googlecode.com/svn/trunk/mockups/ link.
Todd Larsen <tlarsen@google.com> [Mon, 28 Jul 2008 20:42:10 +0000] rev 58
Mockups for some of the Melange views, adapted from the existing GSoC web app
(but in some cases significantly altered). All of the relative links assume
/svn/trunk/mockups/ so that the pages will display properly when accessed from
http://soc.googlecode.com/svn/trunk/mockups/.
Todd Larsen <tlarsen@google.com> [Fri, 18 Jul 2008 18:38:41 +0000] rev 57
HTML mockups of proposed Melange (generic), GSoC, and GHOP pages and forms.
The HTML files in this directory are formatted to be viewed directly from svn
via http://soc.googlecode.com/svn/trunk/mockups/. All of the paths will be
relative (rooted at /svn/trunk/mockups/) and instructions will be added (in a
mockups/README file) for configuring an Apache web server for previewing the
pages from the svn working copy during development.
Todd Larsen <tlarsen@google.com> [Fri, 18 Jul 2008 18:31:46 +0000] rev 56
Make static content framework- and program-specific.
Todd Larsen <tlarsen@google.com> [Fri, 18 Jul 2008 18:28:19 +0000] rev 55
Remove the old "gsoc" and "ghop" apps directories (which now only contain a
lingering __init__.py file anyway).
Todd Larsen <tlarsen@google.com> [Fri, 18 Jul 2008 18:22:23 +0000] rev 54
Major reorganization of the soc svn repo, to merge into a single App Engine
image (to make development easier, now that only a single app will run all
Google Open Source programs).
Todd Larsen <tlarsen@google.com> [Fri, 18 Jul 2008 18:14:01 +0000] rev 53
First step of restructuring /trunk/ into a single App Engine app, avoiding all
of the complicated scripts.
Todd Larsen <tlarsen@google.com> [Tue, 10 Jun 2008 16:23:20 +0000] rev 52
Changes to address comments by Sverre about the previous commit.
Patch by: Todd Larsen
Review by: Sverre Rabbelier
Review issue: 301
Review URL: http://codereviews.googleopensourceprograms.com/301
Todd Larsen <tlarsen@google.com> [Tue, 10 Jun 2008 16:19:59 +0000] rev 51
Changes to address comments by Sverre about the previous commit.
Patch by: Todd Larsen
Review by: Sverre Rabbelier
Review issue: 341
Review URL: http://codereviews.googleopensourceprograms.com/341
Todd Larsen <tlarsen@google.com> [Tue, 10 Jun 2008 16:10:31 +0000] rev 50
Changes to address Sverre's comments about the previous commit.
Patch by: Todd Larsen
Review by: Sverre Rabbelier
Review issue: 321
Review URL: http://codereviews.googleopensourceprograms.com/321
Todd Larsen <tlarsen@google.com> [Tue, 10 Jun 2008 16:08:15 +0000] rev 49
Changes to address Sverre's comments to the previous commit.
Patch by: Todd Larsen
Review by: Sverre Rabbelier
Review issue: 281
Review URL: http://codereviews.googleopensourceprograms.com/281
Todd Larsen <tlarsen@google.com> [Mon, 09 Jun 2008 23:49:20 +0000] rev 48
Addressed Sverre's commits on the previous commit.
Patch by: Todd Larsen
Review by: Sverre Rabbelier
Review issue: 282
Review URL: http://codereviews.googleopensourceprograms.com/282
Todd Larsen <tlarsen@google.com> [Fri, 06 Jun 2008 04:30:49 +0000] rev 47
Script to 'svn cp' /trunk/apps/<app>, /thirdparty/, /trunk/soc/ into a branch.
Patch by: Todd Larsen
TO BE REVIEWED
Review issue: 341
Review URL: http://codereviews.googleopensourceprograms.com/341
Todd Larsen <tlarsen@google.com> [Fri, 06 Jun 2008 04:10:52 +0000] rev 46
Script to 'svn export' /trunk/apps/<app>, /thirdparty/, /trunk/soc/ to local
filesystem.
Patch by: Todd Larsen
TO BE REVIEWED
Review issue: 321
Review URL: http://codereviews.googleopensourceprograms.com/321
Todd Larsen <tlarsen@google.com> [Fri, 06 Jun 2008 03:25:08 +0000] rev 45
Module for new_branch.py and related scripts to manipulate Google App Engine
"image" directories.
Patch by: Todd Larsen
TO BE REVIEWED
Review issue: 282
Review URL: http://codereviews.googleopensourceprograms.com/282
Todd Larsen <tlarsen@google.com> [Fri, 06 Jun 2008 03:18:55 +0000] rev 44
New svn_helper.py functionality for new_branch.py and related scripts.
Patch by: Todd Larsen
TO BE REVIEWED
Review issue: 301
Review URL: http://codereviews.googleopensourceprograms.com/301
Todd Larsen <tlarsen@google.com> [Fri, 06 Jun 2008 03:15:26 +0000] rev 43
New settings.py functionality for new_branch.py and related scripts.
Patch by: Todd Larsen
TO BE REVIEWED
Review issue: 281
Review URL: http://codereviews.googleopensourceprograms.com/281
Todd Larsen <tlarsen@google.com> [Sat, 31 May 2008 01:13:58 +0000] rev 42
Updated version of proto.css that defines some "form field" table cell styles
that was missed in the previous commit.
Todd Larsen <tlarsen@google.com> [Sat, 31 May 2008 01:11:22 +0000] rev 41
Empty index.yaml file created by dev_appserver.py, so that it will stop
showing up as an unknown file in the 'svn status' output.
Todd Larsen <tlarsen@google.com> [Fri, 30 May 2008 17:14:42 +0000] rev 40
A {% field_as_table_row %} template tag to simplify custom forms. (This
template file was missed in the r348 commit.)
Patch by: Todd Larsen
Review by: Pawel Solyga
Review issue: 221
Review URL: http://codereviews.googleopensourceprograms.com/221
Todd Larsen <tlarsen@google.com> [Wed, 28 May 2008 20:52:28 +0000] rev 39
Major revamp of Person model, splitting up poorly-validated properties into
StringProperties, etc.
Patch by: Todd Larsen
Review by: Pawel Solyga
Review issue: 261
Review URL: http://codereviews.googleopensourceprograms.com/261
Todd Larsen <tlarsen@google.com> [Fri, 23 May 2008 20:56:02 +0000] rev 38
A {% field_as_table_row %} template tag to simplify custom forms.
Patch by: Todd Larsen
Review by: Pawel Solyga
Review issue: 221
Review URL: http://codereviews.googleopensourceprograms.com/221
Todd Larsen <tlarsen@google.com> [Fri, 23 May 2008 19:07:45 +0000] rev 37
List of countries and territories used in addresses.
Patch by: Todd Larsen
Review by: Maarten Lankhorst
Review issue: 241
Review URL: http://codereviews.googleopensourceprograms.com/241
Todd Larsen <tlarsen@google.com> [Fri, 23 May 2008 03:35:33 +0000] rev 36
DbModelForm class that fixes verbose_name and help_text handling for Django
forms generated from App Engine Datastore models.
Patch by: Todd Larsen
Review by: Augie Fackler
Review issue: 201
Review URL: http://codereviews.googleopensourceprograms.com/201
Todd Larsen <tlarsen@google.com> [Fri, 23 May 2008 00:22:07 +0000] rev 35
Replace verbose text in __doc__ string with link to wiki topic about using
nosetests to run the tests.
Todd Larsen <tlarsen@google.com> [Thu, 22 May 2008 19:49:02 +0000] rev 34
Fix a typo in the {% extends %} example and add a section on Model-specific
View template sub-directories.
Todd Larsen <tlarsen@google.com> [Thu, 22 May 2008 19:37:38 +0000] rev 33
Add customized proto/person/profile.html template that was missed in the
original apps/proto commit, and follow the new <model>/<view>.html directory
structure now used in soc/templates/soc.
Todd Larsen <tlarsen@google.com> [Thu, 22 May 2008 19:36:13 +0000] rev 32
Move soc/profile.html into soc/person/profile.html, to avoid collisions between
similarly-named templates.
Todd Larsen <tlarsen@google.com> [Wed, 21 May 2008 16:27:35 +0000] rev 31
First iteration of a "prototype" Melange app, along with an initial Person
Profile view.
Patch by: Augie Fackler (with some additions by Todd Larsen)
Review by: Todd Larsen
Review issue: 46
Review URL: http://codereviews.googleopensourceprograms.com/46
Todd Larsen <tlarsen@google.com> [Mon, 19 May 2008 17:01:02 +0000] rev 30
Helper module used by utility and tool scripts to access svn repositories.
Patch by: Todd Larsen
Review by: Sverre Rabbelier
Review issue: 105
Review URL: http://codereviews.googleopensourceprograms.com/105
Todd Larsen <tlarsen@google.com> [Fri, 16 May 2008 19:46:16 +0000] rev 29
settings.py module (and associated tests) for reading a settings file and
combining it with command-line options, for SoC utility and tool scripts.
Patch by: Todd Larsen
Review by: Sverre Rabbelier
Review issue: 145
Review URL: http://codereviews.googleopensourceprograms.com/145
Todd Larsen <tlarsen@google.com> [Wed, 14 May 2008 01:48:13 +0000] rev 28
Make the scripts and scripts/tests directories into packages by adding empty
__init__.py files.
Todd Larsen <tlarsen@google.com> [Wed, 14 May 2008 01:47:24 +0000] rev 27
Create a sub-directory for tests of scripts and script helper modules.
Todd Larsen <tlarsen@google.com> [Tue, 13 May 2008 17:33:55 +0000] rev 26
Nest GHOP module directories in a ghop/ghop sub-directory to preserve the
module namespace when /trunk/apps/ghop/ is branched into a Google App Engine
image.
Todd Larsen <tlarsen@google.com> [Tue, 13 May 2008 17:31:56 +0000] rev 25
Moving gsoc and ghop Melange app directories into /trunk/apps/ per Pawel's
recent suggestion.
Todd Larsen <tlarsen@google.com> [Tue, 13 May 2008 00:43:02 +0000] rev 24
Move the GSoC-specific module hierarchy into a sub-directory to simplify the
branch-building scripts.
Todd Larsen <tlarsen@google.com> [Tue, 13 May 2008 00:39:42 +0000] rev 23
Move the GSoC-specific module hierarchy into a sub-directory to simplify the
branch-building scripts.
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 12 May 2008 21:04:15 +0000] rev 22
Initial definition of the Review Model.
Patch by: Sverre Rabbelier
Review by: Todd Larsen
Review issue: 162
Review URL: http://codereviews.googleopensourceprograms.com/162
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 12 May 2008 20:40:56 +0000] rev 21
Initial definition of the Documentation Model.
Patch by: Sverre Rabbelier
Review by: Todd Larsen
Review issue: 25
Review URL: http://codereviews.googleopensourceprograms.com/25
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 12 May 2008 20:12:46 +0000] rev 20
Initial definition of the Answer Model.
Patch by: Sverre Rabbelier
Review by: Todd Larsen
Review issue: 102
Review URL: http://codereviews.googleopensourceprograms.com/102
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 12 May 2008 19:34:58 +0000] rev 19
Initial definition of the Host Model.
Patch by: Sverre Rabbelier
Review by: Todd Larsen
Review issue: 101
Review URL: http://codereviews.googleopensourceprograms.com/101
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 10 May 2008 02:15:40 +0000] rev 18
Initial definition of the Work Model.
Patch by: Sverre Rabbelier
Review by: Todd Larsen
Review issue: 24
Review URL: http://codereviews.googleopensourceprograms.com/24
Augie Fackler <durin42@gmail.com> [Fri, 09 May 2008 04:30:45 +0000] rev 17
Per tlarsen, remove this externals reference to Django trunk.
Todd Larsen <tlarsen@google.com> [Fri, 09 May 2008 03:22:14 +0000] rev 16
Initial definition of the Work Model.
Review: http://codereviews.googleopensourceprograms.com/63
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 08 May 2008 23:58:47 +0000] rev 15
Initial implementation of the Reviewer Model in the reviewer.py module.
Review: http://codereviews.googleopensourceprograms.com/42
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 08 May 2008 23:48:43 +0000] rev 14
Initial implementation of the Contributor Model in the contributor.py module.
Review: http://codereviews.googleopensourceprograms.com/61
Todd Larsen <tlarsen@google.com> [Thu, 08 May 2008 22:34:47 +0000] rev 13
Clarify back-reference relations the same way that they are documented for
the User model in user.py.
Review: http://codereviews.googleopensourceprograms.com/81
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 08 May 2008 22:29:31 +0000] rev 12
Initial implementation of the Author Model in the author.py module.
Review: http://codereviews.googleopensourceprograms.com/41
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 08 May 2008 21:48:03 +0000] rev 11
Initial implementation of the Administrator Model in the administrator.py module.
Reviewed-at: http://codereviews.googleopensourceprograms.com/21
Todd Larsen <tlarsen@google.com> [Wed, 07 May 2008 21:52:33 +0000] rev 10
Script to generate epydoc documents in wiki/html/epydoc.
Contributed by Sverre Rabbelier.
Todd Larsen <tlarsen@google.com> [Wed, 07 May 2008 19:55:24 +0000] rev 9
Oops. The original scripts sub-directory was put in the wrong place.
Todd Larsen <tlarsen@google.com> [Wed, 07 May 2008 00:39:03 +0000] rev 8
Initial conversion of the Person Model from PersonModel.wiki to person.py.
Todd Larsen <tlarsen@google.com> [Tue, 06 May 2008 22:06:43 +0000] rev 7
Initial revision of the user.py module, containing the User Model, from the
patch contributed by Sverre Rabbelier. Thanks, Sverre, for contributing our
first external patch!
Todd Larsen <tlarsen@google.com> [Tue, 06 May 2008 21:58:48 +0000] rev 6
Add /trunk/ of Django using svn:externals.
Todd Larsen <tlarsen@google.com> [Tue, 06 May 2008 20:26:14 +0000] rev 5
Initial AUTHORS file. Each contributor is added when their first contribution
is commmitted.
Todd Larsen <tlarsen@google.com> [Tue, 06 May 2008 19:31:07 +0000] rev 4
Create the package directory structure for the GSoC and GHOP Melange
applications, since we know that these are going to be written for sure.
Todd Larsen <tlarsen@google.com> [Tue, 06 May 2008 19:25:37 +0000] rev 3
Add a "namespace-subdivided" Django templates directory for the SoC
framework.
Todd Larsen <tlarsen@google.com> [Tue, 06 May 2008 19:19:22 +0000] rev 2
Create the soc.views sub-package for modules that implement Views.
Todd Larsen <tlarsen@google.com> [Mon, 05 May 2008 22:46:54 +0000] rev 1
Define the soc package and the soc.models sub-package.
Todd Larsen <tlarsen@google.com> [Thu, 24 Apr 2008 16:34:55 +0000] rev 0
Add license text file for Apache 2.0 license.