For those times when sed isn't enough, but awk is too much, there's munge.py... Patch by: Todd Larsen

Make sure the user edit form has the complete mail adress in the user account field when opened. Replace confusing id field in form with email field. Editing the email adress of an existing user will still result in an error but that should be fixed soon. Patch by: Lennard de Rijk Review by: Pawel Solyga

upload.py (customized for use with codereviews.googleopensourceprograms.com) updated from latest Rietveld release. Patch by: Todd Larsen

Moved from docs -> document

Fixed typo in docstring

Copy the link_name regex patterns into linkable.py, in preparation for removing them from path_link_name.py (eventually). Patch by: Todd Larsen

Move all the properties from Person model to Role model. Update all the comments and docs according to the changes. Remove Person model. Patch by: Pawel Solyga

Fix broken User link name (it was possible to change link name to one that was already used, validation was not working correctly). Patch by: Pawel Solyga

Move "(required)" text to third column instead of second column in templatetags, it's much more user friendly that way. Add new version of as_table that support our current error messages format, information about required fields and tooltips. Patch by: Pawel Solyga

Remove stop parameter from home_settings and site_settings views. This is something Sverre didn't mean to commit :-) Add missing params description to the models Base class docs. Patch by: Pawel Solyga

In soc.views.models.user module fix too long line. Delete unused email variable, add missing doc and rename self method and global variable to editSelf and edit_self so it's not confused with "self" used in classes and there is no outerscope variable name overwriting anymore. Patch by: Pawel Solyga

Some name changes in soc.logic.site.map module for User self edit view. Patch by: Pawel Solyga

Fix typo in linkable model and add some missing comments. Patch by: Pawel Solyga

Initial thoughts on a Linkable Model class. Please comment. Patch by: Todd Larsen

Fix names typos in home_settings and site_settings modules. Patch by: Pawel Solyga

Change Google Maps property name from gm_api_key to gmaps_api_key. Patch by: Pawel Solyga

Change partial path and link name verbose names in home_settings.py. Some comments fixes in site_settings.py. Patch by: Pawel Solyga

Add jquery folder to make_release.sh script to fix not working jquery on deployed app. Patch by: Pawel Solyga

Adds a check to logic/valididate.py that checks the partial path format using a regexp. This regexp has been added to logic/path_link_name.py, therefore changing PATH_LINKNAME_REGEX to use the PARTIAL_PATH in building this regexp. Plus views/models/docs.py now uses the validation functions in the clean_ methods. Patch by: Lennard de Rijk Review by: Pawel Solyga

Partially use the new user code The 'edit self' is not working fully yet, the 'lookup' code is not working at all, as such, only 'create', 'edit', 'list', and 'delete' make use of the generic code.

Added a generic user page

Preparation for generic user views Added a getSuffixValues method that is meant to allow for having a non-public field as key_name. Also added support for a key-name field being embeded in the form so that if the key-fields change the old key_name is not lost.

Added support for providing a custom params dict This has been a long outstanding feature request for tlarsen, luckily it turned out to be very easy to implement with the dict.merge utility method. To have custom _rights one should instead to the required access checks before calling the view method.

Fixed a typo in id_user

Fix create redirect

Added support for providing a custom params dict This has been a long outstanding feature request for tlarsen, luckily it turned out to be very easy to implement with the dict.merge utility method. To have custom _rights one should instead to the required access checks before calling the view method.

Minor fix to sponsor missing from the site restructure

Add a Google Maps property to Site Settings Patch by: Lennard de Rijk <ljvderijk@gmail.com> Reviewed by: Sverre Rabbelier

Fixes to {Site,Home}Settings Also improved help text on HomeSettings partial_path and link_name.

Fixing the string for the default home page

Making the docs template prettier

Allowing + and - to be clicked in the menu

Fix not working former_ids. Add support for "Invalid accounts". Now when id from former_ids tries to create a profile "This account is invalid." error message is displayed. Compare emails in lower cases to prevent changing User email to the same email with different character casing (needs some more testing). Patch by: Pawel Solyga

Some indention fixes and remove not needed variable in soc.logic.models.base module. Patch by: Pawel Solyga

Refactoring of {site/home}_settings to make them use base.View This makes the way for deleting the key_name.py module

Major site restructuring, also deleting of many unused or obsolete documents The new structure is as follows: <entity>/list - list all <entitie>s <entity>/create - create a new <entity> <entity>/show/<key fields> - public page for <entity> <entity>/edit/<key fields> - edit a <entity> <entity>/delete/key fields> - delete a specific entity

Fix sponsor key field extraction When extracting key field there is no sponsor or user object, instead only their link names are known.

Implements base.Logic functions in home_settings, site_settings and work This patch implements the base.Logic funtions needed for making logic/key_name.py obsolete. This patch defines the needed functions in home_settings, site_settings and work. All modules in logic/models now have these functions defined. logic/models/site_settings.py now inherits from logic/models/home_settings.py because of their similar connection in the corresponding models. Please note that the self._keyName for these two modules still points to logic/key_name.py since entity_type is still used in views/home.py. A partial_path and link_name were added to HomeSettings as requested by SRabbelier.

Fix wrong redirect when changing partial path or link name. Remove an unnecessary assignment in logic/models/base.py that would generate an error when an entity did not exist. Patch by: Lennard de Rijk Review by: Pawel Solyga

Fix not working former ids feature of User Profile Developer Edit view. Add missing Error exception class to soc.logic.models.base module. Patch by: Pawel Solyga

Third-party Javascript that should have been part of r891. Same license as JQuery. Patch by: Todd Larsen

Minor fixes needed for generic key name We no longer try to retreive an entity when there are unset fields. This sort of makes 'getIfFields' obsolete, since we check if fields now anyway. This is needed because getKeyFieldsFromDict expects the fields to be set. Also a minor fix in a Django template so that the generic 'edit' page has a working delete button again.

Quick fix to fix user profile creation This change will be obsolete when User refactoring is finished, but it will fix the build untill then.

Django Fix according to code.djangoproject.com/attachement/ticket/9115/check_for_unlink_in_temp.patch

Add missing TODOs to soc.logic.models classes. Fix comments format in base.Logic class. Changes based on comments to r972. http://code.google.com/p/soc/source/detail?r=972 Patch by: Pawel Solyga

Refactor out the abundance of dictionary (un)packing Instead, keep the dict packed once packed, and only unpack it when needed.

Added key field definitions to the User logic This is the first part of making the User views generic.

Add a getForFields method It allows for generic queries with restrictions specified in a dictionary.

Add a generic method for getting a Keyname This patch will make logic/key_name.py obsolete in the future when everything is compliant with base.logic. This also makes the naming of already compliant logic modules generic and also fixes the _name field to be consistent with the naming in key_name.py. Note: This does not use Group/Sponsor, Group/School, Group/Organisation or Group/Club. Patch by: "Lennard de Rijk" <rijk0214@gmail.com> Reviewed by: Sverre Rabbelier

Added a missing 'pass' statement

Create a Site Settings sub-menu

Fixed typo in e-mail address Instead of 'sverre@rabbelier.nl' everything read 'sverer@rabbelier.nl'

Fixed typo in access check Instead of checking for 'public' the rights for 'edit' were checked.

The pretty blue triangles from Google Code! Patch by: Todd Larsen

Add tooltips style display of help_text, instead of widening the form with another (often ridiculously large) column. Also, version the .css and .js files so that browsers won't display the wrong cached one when we change something. Patch by: Dmitri Gaskin, Todd Larsen Review by: Todd Larsen

Change Site and User sub-menus so that the "header" entry for those sub-menus is not a clickable link, but instead just a placeholder. Patch by: Todd Larsen