Remove inheritance_line from Form meta class excludes in all currently used forms. Patch by: Pawel Solyga, Sverre Rabbelier

Remove inheritance from PolyModel in Answer and Linkable model. Replace PolyModel inheritance with base.ModelWithFieldAttributes. A little explanation why we are trying to get rid of PolyModel. We decided to use PolyModel in order to get support for model inheritance in App Engine, however as we know this was a hacky workaround which added inheritance_line property to each model. Recent commits which added Linkable model caused our data viewer in admin console to show only one model "Linkable" since all of the classes inherited from it. Basically datastore viewer was useless plus we had a really big mess in datastore since everything was of one kind (Linkable). It's almost like creating one huge table in SQL database. Upcoming commits will eliminate all usage of PolyModel and finally remove PolyModel from our repository. We are still using inheritance however this doesn't modify how models are saved in data store so basically it's like copy and paste of properties from parent models. Patch by: Pawel Solyga, Sverre Rabbelier

Add customized User Edit Developer view template with working listing of former accounts. Patch by: Pawel Solyga

Disabled 'Home Settings' menu until we have a use for it Also fixed a typo in the request row template that caused it to display the wrong value. Patch by: Sverre Rabbelier

Removed no-longer used code This code is no longer in use and has been replaced by getForFields and similar methods.

Hide the 'home' field until we have a proper document selector Rather than having a confusing 'home' field that lists all Linkables (in other words, everything in the database), we're better off hiding it for now.

Fixed redirects to work consistently Revision 1133 broke 'Edit Site Settings' by relying on the fact that the url for create pages is '<entity>/create', which it is not for 'Edit Site Settings'.

Made Request use the new link_id and scope_path This cleans a lot of weird user interface badness and demonstrates how Linkable can be used.

Added a requests overview using the new multi-list page. Renamed the roles page to Requests Overview. Patch by: Lennard de Rijk

Requests are almost working now You can accept a request by clicking on it in the roles view. Patch by: Sverre Rabbelier

Fix names of methods in soc.views.model.site. Patch by: Pawel Solyga

Fix wrong comment format in request.py. Patch by: Pawel Solyga

Added missing import Patch by: Lennard de Rijk

Refactor requestSelf to be make use of the new split Patch by: Sverre Rabbelier

Split the list view code up in three pieces 1. getListContents which returns the required contents dictionary 2. _list which returns the response for a specified list of contents 3. list which constructs just one content dict and passes it to _list This way it is easier to do step 1 and 2 in other code than list(), which makes it possible to display multiple list pages (by calling getListContents multiple times and passing the result to _list).

Renamed templates/soc/entity/list/entity_*.html to *.html This makes it possible to generalize list template positions. Patch by: Sverre Rabbelier

Make redirect generic using the new Lists object This makes it possible (and easier) to have the list view redirect to any page specially tailored to the current item. Patch by: Sverre Rabbelier

Fixed the description on the user's role page. This broke in r1111. The new lists also removed the need for instruction_text in models/base.py. Removed an obsolete assignment in models/request.py Patch by: Lennard de Rijk

Define a default for rights['public'] in views/models/base.py. Alter rights in views/models/site.py to allow anyone, even signed-out users, to view the site home page. Patch by: Todd Larsen

Hide the 'scope' property from forms for now, since this is really supposed to be set by "Role context" as determined by logic code in the controller. Patch by: Todd Larsen

Fix some broken help_text bubbles (they are truncated or not displayed if they contain " double quotation marks). Add notice text (sort of ugly at the moment, Dmitri? :) explaining the "Public name" and "Link ID" fields in great detail. This patch is in preparation for making "Link ID" immutable for Users in a subsequent patch. Patch by: Todd Larsen

Fix for 404 occuring when signing out during the creation of, for example, a new Document. This patch makes sure that the request.path is not altered when requesting the create page (alteration of which caused the 404). This also results in the seeds now being remembered when being forced to log in. The editPost method now correctly switches to the edit path after a successful edit. Patch by: Lennard de Rijk

Fixed former_accounts detection by supplying the missing error message. Patch by: Todd Larsen

Rename the User.public_name Property to simply 'name' (but leave the verbose name as "Public name"). This is to take advantage of standardizing on 'name' in the common edit template (and possibly other common templates). The Property was renamed because public_name was already a "name", unlike the recent change to the Work Model class, where 'title' was "aliases" using a tiny name() method instead. Patch by: Todd Larsen

Include name of entity in the text of the link to the read-only public view present in the common edit template. Provide a simple method in the Work Model class that aliases the existing 'title' Property to 'name'. Patch by: Todd Larsen

Fix broken Site settings form by uncommenting code that was inadvertently committed commented out. Patch by: Todd Larsen

Merge soc/logic/out_of_band.py into soc/views/out_of_band.py. Merge errorResponse() and requestLogin() from soc/views/simple.py into out_of_band.Error and out_of_band.LoginRequest exception classes, respectively. Remove no-longer-used soc/logic/out_of_band.py and soc/views/simple.py. Fix some problems where usage of out_of_band was broken. Patch by: Todd Larsen

Remove redundant dicts for URL patterns and sidebar menu text, and use the existing params dict instead. Add a sidebar_heading customization to params. Better differentiate the 'User (self)' and 'Users' sidebar menus. Remove the redundant Site settings menu items now that the Site entity is a singleton. Patch by: Todd Larsen

By default, exclude files that are likely to be binary files. Patch by: Todd Larsen

Add User.public_name help text, per discussions on melange-soc-dev. Patch by: Todd Larsen

Allow for multiple list objects At the moment there's not really a practical use for it, since there is no way to make soc.views.models.base.View.list() show more than one list, but it shouldn't be too hard to allow for that. Patch by: Sverre Rabbelier

Make it more obvious that a format string constant is a format string by appending _FMT. Patch by: Todd Larsen

Fix getKeyValues() method footprint mismatches in soc.logic.models.site.Logic after the recent refactoring. Remove 'Link scope' drop-down from Edit Site Settings form. Patch by: Todd Larsen

Add a page name for 'Edit Main Site Settings'

Refactor classes in soc/logic/models to make more use of inheritance. Add some missing classes, such as soc.logic.models.group.Logic, so that key name similarities between various Groups can be exploited via inheritance instead of repetition of code. Patch by: Todd Larsen

Replace HomeSettings with Presence Model class. Replace SiteSettings with Site Model class. Derive Group Model class from Presence, adding the "home page settings" properties in a Melange site presence to every Group. Patch by: Todd Larsen

Move LINK_ID and SCOPE_PATH regular expressions to soc/models/linkable.py. Fix some too-long lines. Change key names back to type:scope_path/link_id (instead of type:scope_path:link_id). Some minor __doc__ string updates. Patch by: Todd Larsen

Removed unnecesary lines according to comment on r1067 Patch by: Lennard de Rijk

Make editSelf() work by adding 'inheritance_line' to the list of excluded fields in the UserForm. Also, fix a few too-long lines and add some missing parentheses (the style guide says do not rely on operator precedence). Patch by: Todd Larsen

Remove imports of the soc.logic.key_name module, since it was deleted by r1071 (and wasn't referenced in these modules anyway). Patch by: Todd Larsen

Replace nick_name and its variants with public_name. Remove the soc/templates/soc/person/edit.html template, since it does not appear to be referenced anywhere (and contained a nick_name reference that would otherwise need to be remedied). Patch by: Todd Larsen

Some indention and too long lines fixes in soc.views.models. Patch by: Pawel Solyga

Delete some more not needed directories this time in soc/logic and soc/templates. Patch by: Pawel Solyga

Remove not needed directories in soc/views. Patch by: Pawel Solyga

Created a checkIsInvited method Patch by: Sverre Rabbelier

Small comment fix in Linkable model. Patch by: Pawel Solyga

Removed one more unneccesary module Last commit reminded me that this one is obsolete too.

OK, this one file was missing from r1061 for some reason. Patch by: Todd Larsen

Minor improvements to roles page Mainly not hard-coding the page name and showing all requests that are _accepted_, instead of the one's that aren't yet.

Split a too long line

Adds the user's role page. Currently this only has an overview of the user's unhandled requests. Patch by: Lennard de Rijk

Changes the list template to use an instruction_text property that sets the text above the list. This makes the create_invite template unneeded. The instruction_text comes in handy when defining special lists. Patch by: Lennard de Rijk

Deleted unused files and files

The list method in models/base.py can now use a filter to make a selection of entities to show. Patch by: Lennard de Rijk

Moved the last remnant of soc.views.user.profile to soc.views.models Sadly, it is non-trivial to port this code to be generic enough to work with soc.views.models.base.edit. On the other hand, this will make customizing the editSelf code a lot easier.

Move saved message to the base class This removes some duplicate code that was in all the child classes of soc.views.models.base.View.

Rename partial_path to scope_path, ignoring case, etc. (Similar to the recent link_name => link_id change). Also, fix two missed "Linkname" column headers in some templates. Patch by: Todd Larsen

Rename link_name to link_id everywhere, regardless of case (so LINK_NAME becomes LINK_ID, "link name" becomes "link id", etc.). Also, rename LINKNAME to LINK_ID. Patch by: Todd Larsen

Ignore "dot" directories like .hg and .svn by default. Patch by: Todd Larsen

id() is a built-in function in Python, so rename the property to link_id. Add a scope_path StringProperty to cache the string representation of the transitive closure of the nested scopes of an entity. Patch by: Todd Larsen

Adds the rights['edit'] to models/base.py wich was left out in r1049. Fixes two small typos in the comments in logic/mail_dispatcher.py

Add a access.deny and access.allow method Respectively always deny, and always allow access to view a part of the site.

Fold the _rights dictionary into params

Fix bug where script fails when it encounters a socket (which is not a regular file). Fix bug where exception is raised if error occurred before parser object was returned from _buildParser(). Add a --notext option, so that just the file paths will be output on matches (both find and find/replace); useful with xargs. Patch by: Todd Larsen

Fix user key stuff Key field for user is now link_name, instead of account, as such the method's used by 'create new user' should be updated.

Fix not working request creation. Patch by: Pawel Solyga

Derive Linkable Model class from PolyModel. Patch by: Todd Larsen

Add new parameters to views: url_name which is name used in urls (instead of using lower entity names) and module_name which is used for constructing django urls. Append changes to all affected files. Fix some title names. Change urls that included underscores like "site_settings" into urls with slash "site/settings". Plus some other minor fixes. Patch by: Pawel Solyga

Fix not working feed display for home settings public view. Modify blog javascript so that we can define how many feed entries we want to display. Change default number of entries to 3 as suggested by Leslie and Chris. Patch by: Pawel Solyga

Replace old page parameter doc string description with new one for page_name. Patch by: Pawel Solyga

Fix missing dots in doc strings and some other doc string corrections. Patch by: Pawel Solyga

Remove empty docs folder in soc/views. Patch by: Pawel Solyga

Added a default _editSeed method Also added the invite shortcut in the host view.

Temporary fix for creating a new user account This should probably be solved more elegantly, but edit_self is going to be used soon.

Added basic 'invite' functionality Currently the invite can only be created, existing ones can be listed and edited, or deleted if desired.

Refactored SiteMap to be generic With this mechanism (in combination with the new sidebar) in place adding a new entity to the site becomes very easy, rather than having to add a lot of code to 'map.py', one can simply register with the sitemap modules.

Refactor the sidebar to use Django templates With this change the html for the sidebar is no longer generated by Melange, instead it's delegated to Django (which is what it does best anyway). The downside is that it is no longer possible to have arbitrary deeply nested menu's.

Fixed redirection after creation to Just Work Accomplished by generating a link to the creation page instead of trying to deduct it from the current path.

Improved public page link text Instead of putting the name of the entity in the link text to the public page, a way better solution is to put static text there.

Allow pre-seeding a create form With this feature the Site Settings create form can be pre-seeded with it's "magic values", which allows those fields to be hidden from the user. At the same time, it allows 'Edit Main Site Settings' to either create or edit the Main Site Settings.

Fixed typo in soc.views.models.host redirects

Restored default Sponsor edit view

Fixed a typo in soc.logic.models.base

Added a filter method to dicts

Change id to account in base.html template (without this change we couldn't signout using top right links and also couldn't display currently logged in account information on the left side of links). This patch is related to commit in revision r1022. http://code.google.com/p/soc/source/detail?r=1022 Patch by: Pawel Solyga

Add an e-mail dispatcher that can be used to send messages via the website. Add base and invitation templates that can be used with email dispatcher to send invitation emails. Please read the module doc string for more information how to use it. Patch by: Lennard de Rijk, Pawel Solyga

Fix broken User link_name validations. Changes in r1014 still caused some problems so I came out with new idea to compare User accounts (previously called "id"). Patch by: Pawel Solyga

Factor out direct use of the page object Instead of directly using the page object in the html, pass around page_name. This will make it easier to remove Page in favor of a simpler implementation.

Attempt to rename User.id to User.account, in preparation for making User be derived from Linkable, which will have a property named 'id'. Patch by: Todd Larsen

For those times when sed isn't enough, but awk is too much, there's munge.py... Patch by: Todd Larsen

Make sure the user edit form has the complete mail adress in the user account field when opened. Replace confusing id field in form with email field. Editing the email adress of an existing user will still result in an error but that should be fixed soon. Patch by: Lennard de Rijk Review by: Pawel Solyga

upload.py (customized for use with codereviews.googleopensourceprograms.com) updated from latest Rietveld release. Patch by: Todd Larsen

Moved from docs -> document

Fixed typo in docstring

Copy the link_name regex patterns into linkable.py, in preparation for removing them from path_link_name.py (eventually). Patch by: Todd Larsen

Move all the properties from Person model to Role model. Update all the comments and docs according to the changes. Remove Person model. Patch by: Pawel Solyga

Fix broken User link name (it was possible to change link name to one that was already used, validation was not working correctly). Patch by: Pawel Solyga

Move "(required)" text to third column instead of second column in templatetags, it's much more user friendly that way. Add new version of as_table that support our current error messages format, information about required fields and tooltips. Patch by: Pawel Solyga

Remove stop parameter from home_settings and site_settings views. This is something Sverre didn't mean to commit :-) Add missing params description to the models Base class docs. Patch by: Pawel Solyga

In soc.views.models.user module fix too long line. Delete unused email variable, add missing doc and rename self method and global variable to editSelf and edit_self so it's not confused with "self" used in classes and there is no outerscope variable name overwriting anymore. Patch by: Pawel Solyga

Some name changes in soc.logic.site.map module for User self edit view. Patch by: Pawel Solyga

Fix typo in linkable model and add some missing comments. Patch by: Pawel Solyga

Initial thoughts on a Linkable Model class. Please comment. Patch by: Todd Larsen

Fix names typos in home_settings and site_settings modules. Patch by: Pawel Solyga

Change Google Maps property name from gm_api_key to gmaps_api_key. Patch by: Pawel Solyga

Change partial path and link name verbose names in home_settings.py. Some comments fixes in site_settings.py. Patch by: Pawel Solyga

Add jquery folder to make_release.sh script to fix not working jquery on deployed app. Patch by: Pawel Solyga

Adds a check to logic/valididate.py that checks the partial path format using a regexp. This regexp has been added to logic/path_link_name.py, therefore changing PATH_LINKNAME_REGEX to use the PARTIAL_PATH in building this regexp. Plus views/models/docs.py now uses the validation functions in the clean_ methods. Patch by: Lennard de Rijk Review by: Pawel Solyga

Partially use the new user code The 'edit self' is not working fully yet, the 'lookup' code is not working at all, as such, only 'create', 'edit', 'list', and 'delete' make use of the generic code.

Added a generic user page

Preparation for generic user views Added a getSuffixValues method that is meant to allow for having a non-public field as key_name. Also added support for a key-name field being embeded in the form so that if the key-fields change the old key_name is not lost.

Added support for providing a custom params dict This has been a long outstanding feature request for tlarsen, luckily it turned out to be very easy to implement with the dict.merge utility method. To have custom _rights one should instead to the required access checks before calling the view method.

Fixed a typo in id_user

Fix create redirect

Added support for providing a custom params dict This has been a long outstanding feature request for tlarsen, luckily it turned out to be very easy to implement with the dict.merge utility method. To have custom _rights one should instead to the required access checks before calling the view method.

Minor fix to sponsor missing from the site restructure

Add a Google Maps property to Site Settings Patch by: Lennard de Rijk <ljvderijk@gmail.com> Reviewed by: Sverre Rabbelier

Fixes to {Site,Home}Settings Also improved help text on HomeSettings partial_path and link_name.

Fixing the string for the default home page

Making the docs template prettier

Allowing + and - to be clicked in the menu

Fix not working former_ids. Add support for "Invalid accounts". Now when id from former_ids tries to create a profile "This account is invalid." error message is displayed. Compare emails in lower cases to prevent changing User email to the same email with different character casing (needs some more testing). Patch by: Pawel Solyga

Some indention fixes and remove not needed variable in soc.logic.models.base module. Patch by: Pawel Solyga

Refactoring of {site/home}_settings to make them use base.View This makes the way for deleting the key_name.py module

Major site restructuring, also deleting of many unused or obsolete documents The new structure is as follows: <entity>/list - list all <entitie>s <entity>/create - create a new <entity> <entity>/show/<key fields> - public page for <entity> <entity>/edit/<key fields> - edit a <entity> <entity>/delete/key fields> - delete a specific entity

Fix sponsor key field extraction When extracting key field there is no sponsor or user object, instead only their link names are known.

Implements base.Logic functions in home_settings, site_settings and work This patch implements the base.Logic funtions needed for making logic/key_name.py obsolete. This patch defines the needed functions in home_settings, site_settings and work. All modules in logic/models now have these functions defined. logic/models/site_settings.py now inherits from logic/models/home_settings.py because of their similar connection in the corresponding models. Please note that the self._keyName for these two modules still points to logic/key_name.py since entity_type is still used in views/home.py. A partial_path and link_name were added to HomeSettings as requested by SRabbelier.

Fix wrong redirect when changing partial path or link name. Remove an unnecessary assignment in logic/models/base.py that would generate an error when an entity did not exist. Patch by: Lennard de Rijk Review by: Pawel Solyga

Fix not working former ids feature of User Profile Developer Edit view. Add missing Error exception class to soc.logic.models.base module. Patch by: Pawel Solyga

Third-party Javascript that should have been part of r891. Same license as JQuery. Patch by: Todd Larsen

Minor fixes needed for generic key name We no longer try to retreive an entity when there are unset fields. This sort of makes 'getIfFields' obsolete, since we check if fields now anyway. This is needed because getKeyFieldsFromDict expects the fields to be set. Also a minor fix in a Django template so that the generic 'edit' page has a working delete button again.

Quick fix to fix user profile creation This change will be obsolete when User refactoring is finished, but it will fix the build untill then.

Django Fix according to code.djangoproject.com/attachement/ticket/9115/check_for_unlink_in_temp.patch

Add missing TODOs to soc.logic.models classes. Fix comments format in base.Logic class. Changes based on comments to r972. http://code.google.com/p/soc/source/detail?r=972 Patch by: Pawel Solyga

Refactor out the abundance of dictionary (un)packing Instead, keep the dict packed once packed, and only unpack it when needed.

Added key field definitions to the User logic This is the first part of making the User views generic.

Add a getForFields method It allows for generic queries with restrictions specified in a dictionary.

Add a generic method for getting a Keyname This patch will make logic/key_name.py obsolete in the future when everything is compliant with base.logic. This also makes the naming of already compliant logic modules generic and also fixes the _name field to be consistent with the naming in key_name.py. Note: This does not use Group/Sponsor, Group/School, Group/Organisation or Group/Club. Patch by: "Lennard de Rijk" <rijk0214@gmail.com> Reviewed by: Sverre Rabbelier

Added a missing 'pass' statement

Create a Site Settings sub-menu

Fixed typo in e-mail address Instead of 'sverre@rabbelier.nl' everything read 'sverer@rabbelier.nl'

Fixed typo in access check Instead of checking for 'public' the rights for 'edit' were checked.

The pretty blue triangles from Google Code! Patch by: Todd Larsen

Add tooltips style display of help_text, instead of widening the form with another (often ridiculously large) column. Also, version the .css and .js files so that browsers won't display the wrong cached one when we change something. Patch by: Dmitri Gaskin, Todd Larsen Review by: Todd Larsen

Change Site and User sub-menus so that the "header" entry for those sub-menus is not a clickable link, but instead just a placeholder. Patch by: Todd Larsen

Use nice "plus" and "minus" symbols from Google Code, instead of current triangles, for sidebar menu. Patch by: Todd Larsen

Add javascript expandable menus. Patch by: Dmitri Gaskin Review by: Augie Fackler

Add jQuery. Patch by: Dmitri Gaskin Review by: Augie Fackler

Remove bogus import from a previous iteration.

Remove newlines in sidebar

Start a test system for the webapp itself.

Always check if a user filled in a user profile Also, if there is no checks defined, still do the general checks.

Do not include attributes which are inherited. Also some extra comments. Review URL: http://codereviews.googleopensourceprograms.com/1603

Run with Python 2.5

Fix typo in models/public.html template. Changes in Host Public Profile template (new header title and deletion of some fields). Patch by: Pawel Solyga Review by: to-be-reviewed

Fix mistakes in Host List templates. Change Host List second row to Sponsor name instead of Sponsor link name. Patch by: Pawel Solyga Review by: to-be-reviewed

Rename Host list templates from group_<something> to host_<something> and move then to soc/host/list folder. Update affected files with new paths. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix Sponsor profile edit/create template. Don't show "View Sponsor Public Profile" link and Delete button in Create Sponsor view. Patch by: Pawel Solyga Review by: to-be-reviewed

Addresses comments to r866. http://code.google.com/p/soc/source/detail?r=866 Patch by: Pawel Solyga Review by: to-be-reviewed

Moved all key_name related things to the logic modules Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Addressed comments by Pawel and Todd Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Inherit from BaseForm in all forms instead of from DbModelForm. This change doesn't include changes to templates and usage of as_table everywhere (work in progress). Patch by: Pawel Solyga Review by: to-be-reviewed

Fix not working Create views (committed in r864). Check if entity exist in constructKeyNameSuffix funtion and apply changes to affected files. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix some wrong paths to templates (committed in r864). Patch by: Pawel Solyga Review by: to-be-reviewed

Add Google Analytics support to Site Settings. The reason I created additional SettingsValidationForm is because you cannot inherit from Form that has already defined Meta class, so it's sort of workaround for that. I didn't want to have same validation functions in both Form classes. Patch by: Pawel Solyga Review by: to-be-reviewed

Added a Host profile and generalized some views Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Some more improvements to the generic view code Namely getEmptyKeyFields and constructKeyNameSuffix, some whitespace issues, and a few extra fields in the context. Patch by: Sverre Rabbelier Reviewd by: to-be-reviewed

Incorperated suggestions by Todd Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Make use of the new generic views Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Added a generic version of the Document views Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Various improvements to the generic View code Among others: * Added the 'page' argument to the simple.errorResponse call * Pass the result of getEmptyKeyFields to edit() in create() * Fix typo's in error responses * Fixed a todo to properly redirect on create * Made editPost return something when the form is not valid * Added an _editGet hook Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Rename 'existing_doc' and 'document' to entity Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Remove the google search box and the google analytics page These are left over from the mockups (removed because they caused long wait times when no internet connection is available).

Improve the error message for getIfFields Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Add documentation in response to Pawel's comments: http://code.google.com/p/soc/source/detail?r=832 Patch by: Todd Larsen Review by: to-be-reviewed

Add BaseForm class to soc.views.helper.forms module (work in progress). This changes the way as_table function displays the form (for more information have a look into doc string). BaseForm is going to be used for all forms in Melange in future. Right now it's still missing custom form errors labels and "required" text in 3rd column, but that's added as TODO and I'm working on it. Patch by: Pawel Solyga Review by: to-be-reviewed

Add colon after label in _field_as_table_row template for consistency reasons with form.as_table output. Patch by: Pawel Solyga Review by: to-be-reviewed

Add "View Sponsor Public Profile" to Sponsor Edit view template. Remove not needed <p> in home/public.html template. Add missing '$' at the end of some urls in site/map.py module. Patch by: Pawel Solyga Review by: to-be-reviewed

Address comments to r844 and r845. Patch by: Pawel Solyga Review by: to-be-reviewed

Remove unused imports, fix too long lines and indentions. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix identions, too long lines, unused imports and some other mistakes. Patch by: Pawel Solyga Review by: to-be-reviewed

Add pylint configuration file (pylintrc) and do_pylint.sh script which runs pylint checkers on Melange code using pylintrc file as config. do_pylint.sh as default shows additional information like reports, TODOs, code similarities and unused imports, but you can run it in silent mode (--silent) which disables all of that. The only problem with unused imports in pylint right now is that it doesn't work in the situation described in last example at http://code.google.com/p/soc/wiki/PythonStyleGuide#Packages, so sometimes we get unused import soc when we actually shouldn't. However this can be fixed by writing pylint plugins (our own checkers) in future. Patch by: Pawel Solyga Review by: to-be-reviewed

Addressed comments by Todd on r822 Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Fix identions in reflistprop module. Patch by: Pawel Solyga Review by: to-be-reviewed

Remove not used imports in models. Fix missing spaces in models when operator not preceded by a space. Add missing ugettext_lazy import to Proposal model. Patch by: Pawel Solyga Review by: to-be-reviewed

Add missing ugettext_lazy for string in soc.views.user.profile module. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix missing keyword argument in soc.views.user.profile.create() function when calling edit(). Patch by: Pawel Solyga Review by: to-be-reviewed

Change Sponsor delete url from /site/sponsor/profile/<link_name>/delete to /site/sponsor/profile/delete/<link_name> to match convention used in Document delete url. Patch by: Pawel Solyga Review by: to-be-reviewed

Fixed not working to edit a doc that selected from the docs list view. soc/templates/soc/docs/list/docs_row.html not full updated. Patch by: Chen Lunpeng Review by: to-be-reviewed

Change the "Site home page Document is missing" default text to give instructions similar to those in the Site Settings form. Patch by: Todd Larsen Review by: to-be-reviewed

Remove another now-empty templates directory. Patch by: Todd Larsen Review by: to-be-reviewed

Nothing left in this templates directory, so remove it. Patch by: Todd Larsen Review by: to-be-reviewed

Refactor various site views into more generic locations, in preparation for using access permissions to decide the fuctionality in the view, instead of having lots of cut-and-paste copies of the same view functions. site/home.py into more generic home.py site/settings.py into more generic settings.py site/docs/list.py into more generic docs/list.py site/docs/edit.py into more generic docs/edit.py Patch by: Todd Larsen Review by: to-be-reviewed

Add a style that appears in form error lists produced by Django Forms and make it match the style of the existing td.formfielderror used by the field_as_table_row helper. Patch by: Todd Larsen Review by: to-be-reviewed

Create package for soon-to-be-refactored group/home.py and group/settings.py packages. Patch by: Todd Larsen Review by: to-be-reviewed

Add the Page object to the context of each view. Update templates to make use of the newly-available page.long_name and page.short_name. Patch by: Todd Larsen Review by: to-be-reviewed

Add the Page object to the context of each view method. Also, add some missing Arg: sections to __doc__ strings and fix the missing context issue in editPost() and editGet(). Patch by: Todd Larsen Review by: to-be-reviewed

Formalize the concept of a NonPage that can appear in the site-map, useful for non-clickable sidebar menu divisions, for example. Convert "hacky" fake Pages into NonPages in the site-map. Also, pass page=self to every view as a keyword argument when generating the Django urlpatterns. Patch by: Todd Larsen Review by: to-be-reviewed

Add a relative symlink pointing at ../rietveld/upload.py in thirdparty/chromium so that gcl.py can import the thirdparty/rietveld/upload.py module. Patch by: Todd Larsen Review by: to-be-reviewed

Replace missing: from google.appengine.api import users that appears to have been removed by r824. Needed by call in the edit() view to users.get_current_user(). Patch by: Todd Larsen Review by: to-be-reviewed

Replace GROUP_TYPE_PLURAL and GROUP_TYPE_SHORT constants in Group models with more generic TYPE_NAME, TYPE_NAME_SHORT, TYPE_NAME_PLURAL names and apply changes in affected files. Use ugettext_lazy for TYPE_NAME and TYPE_NAME_PLURAL constants. This approach is similar to the upcoming refactor of views. Patch by: Pawel Solyga Review by: to-be-reviewed

Move TODO about isDeletable Sponsor logic method to sponsor.py module and extend a little bit doc string. Patch by: Pawel Solyga Review by: to-be-reviewed

Remove not needed request argument in view decorator. Patch by: Pawel Solyga Review by: to-be-reviewed

Fixed not working after click the "List Site Sponsors" in site menu bar. due to wrongly imported modules. Patch by: Chen Lunpeng Review by: to-be-reviewed

Create decorators module in view/helper and add view decorator that catches exceptions like DeadlineExceededError, MemoryError, AssertionError (this code is being moved from respond function). Add view decorator to all view functions. In addition remove not needed imports from all affected files and fix too long lines. Patch by: Pawel Solyga Review by: to-be-reviewed

Last commit missed the new __init__.py file

Add a framework for generic views This commit does not enable the new code, as such there should be no change in functionality. In order to use the new code the maps.py file should be updated to point at the new views/models/sponsor.py module. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

entity_type is not the same as entity_type_short The previous commit wrongfully assumed this. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Make page argument required for errorResponse and requestLogin functions in simple.py and update affected files. Some keyword argument changes to in user/profile.py. All the changes are based on comments to r817. http://code.google.com/p/soc/source/detail?r=817 Patch by: Pawel Solyga Review by: to-be-reviewed

Rename 'group' to 'entity' in the Django templates This allows for generic use of these templates. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

DeadlineExceededError in the recent version of AppEngine lives only in one place so there is no need to try import it from both runtime (deployed) and runtime.apiproxy_errors (dev server) modules anymore. Patch by: Pawel Solyga Review by: to-be-reviewed

Add page=None parameter to all views. Information from page argument (which is soc.logic.site.page.Page object) is going to be used later in views code and for some context values. Fix some indentions in __doc__ strings. Add proper __doc__ string for all() function in sponsor/list.py module. Patch by: Pawel Solyga Review by: to-be-reviewed

Some indention fixes in access.py module. Patch by: Pawel Solyga Review by: to-be-reviewed

Change name of login_request variable in access.py module to login_response. Patch by: Pawel Solyga Review by: to-be-reviewed

Change name of getUserFromLinkNameOrDie function to getUserFromLinkNameOr404 and apply changes to affected files. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix mistakes in docs and comments in logic/models/base.py. Patch by: Pawel Solyga Review by: to-be-reviewed

Log Fix not working after click the "Site Settings" in home page. templete wasn't updated when soc/app/soc/logic/site/map.py was update. Patch by: Chen Lunpeng Review by: to-be-reviewed

Remove #docsummary class from css file as it is not used anymore. Add #createdby class in css file. Fix typo in docs/profile.html template. Put document content in <div class='content'>. Patch by: Pawel Solyga Review by: to-be-reviewed

Eliminate the Work.abstract property and move the Document.content property to Work.content instead. Update affected views, and re-base some classes that were deriving from Document just to get Document.content to now be derived from Work instead. The Document class now has a "pass" body with no additional properties. It is debatable whether Work should become Document, since I am not sure that we plan to be able to generically display, say, a Quiz or a Question (which are Works) on the home page (which can only specifically display a Document, or now, the basic Work entity...). Patch by: Todd Larsen Review by: to-be-reviewed

"new" is a little bit redundant in the short_name of sidebar menu items that already begin with "Create...", since that implies the result will be something new. Patch by: Todd Larsen Review by: to-be-reviewed

A quick-and-dirty way to create non-link sub-menu dividers, plus a TODO on how this should be formalizes to not be so hacky. This change was inspired by the ever-growing "Site" sidebar menu. Patch by: Todd larsen Review by: to-be-reviewed

Should have been part of recent r806. Patch by: Todd Larsen Review by: to-be-reviewed

First phase of making the / (site/home) view generic enough to use it for Sponsor "home" page, Program "home" page, Organization "home" page, etc. when combined with HomeSettings. First phase of addressing this issue: http://code.google.com/p/soc/issues/detail?id=64 by factoring "Site Settings" apart from the site/home stuff. Patch by: Todd Larsen Review by: Pawel Solyga Review URL: http://codereviews.googleopensourceprograms.com/1405

Add the empty directory where site/home/edit.html is moving, to see if this fixes a problem with gcl.py.

Update TinyMCE wiget code according to r783. I hope I did it correctly this time. http://code.google.com/p/soc/source/detail?r=783 Patch by: Pawel Solyga Review by: to-be-reviewed

Change verbose_name of founder property in Group model from "Created by" to "Founded by". Add GROUP_TYPE_SHORT and GROUP_TYPE_PLURAL for all models that inherit from Group and use that values in templates and contexts. Assume that group_type, group_type_short and group_type_plural are defined in context and remove not needed ifs in templates. Rename "Linkname" to "Link name" in list/group_heading.html template. Patch by: Pawel Solyga Review by: to-be-reviewed

Remov "founder" text from the first line of edit.py, this is fix to r799 commit. Patch by: Pawel Solyga Review by: to-be-reviewed

Remove the proposed WorksAuthors many:many relation and promote the "founder" property from Document up to Work. Update all subclasses of Work and any affected views accordingly. This addresses review comments here: http://code.google.com/p/soc/source/detail?r=786 Patch by: Todd Larsen Review by: to-be-reviewed

Fixed the evil black logo.

Make this file excutable by default.

Define the Models for implementing Quizzes (collections of Questions) and their Responses (collections of Answers to those Questions). These Models would form the basis of storage for such items as: Terms of Service (Quiz) Question ("I agree...") Response -> Answer (answer to "I agree..." confirmation) solution ("Yes" Answer to the "I agree..." Question) Mentor and Student surveys (Quiz) Questions (including "Pay this student?") Response -> Answers solution ("Yes" Answer to the "Pay this student?" Question) Organization applications Student Proposal review, comment, and scoring system GHOP task tracking (a specific task list item would be a Quiz) Patch by: Todd Larsen Review by: Pawel Solyga, Sverre Rabbelier, Chen Lunpeng Review URL: http://codereviews.googleopensourceprograms.com/1403

Show "Created by" read-only field in Document Edit view. Update size of TinyMCE widget in Document Edit/Create views. Change user property name to founder in Document model and update files according to this change (now founder is used in Group and Document models). Remove not used variables and imports in views/site/docs/edit.py. Refactor EditForm and CreateForm in views/site/docs/edit.py so that EditForm inherits from CreateForm and just extends it. Patch by: Pawel Solyga Review by: to-be-reviewed

Show "Created by" read-only field in Sponsor Edit view. Fix function keyword arguments in sponsor/list.py to follow our PythonStyleGuide. Sponsor founder property is not updated anymore when editing Sponsor profile, it's just saved once when creating Sponsor profile. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix not working docs show view. Document show view wasn't updated when the logic refactor was made. Patch by: Pawel Solyga Review by: to-be-reviewed

Changes to TinyMCE widget that enable to pass mce_settings in the class constructor and that way update default settings if needed. Patch by: Pawel Solyga Review by: to-be-reviewed

Add nameHomeSettings function to key_name module. Add HomeSettings logic. Patch by: Pawel Solyga Review by: to-be-reviewed

Update comments in models/group.py (changed Optional to Required). Add verbose_name to founder property in Group model. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix bug that caused Lookup user by User Account not to work properly. Basically wrong parameter to models.user.logic.getFromFields(). Patch by: Pawel Solyga Review by: to-be-reviewed

Add deleted in r732 (don't know why) functionality that displays custom Error page when linkname in Developer User Profile url doesn't exist (/site/user/profile/<not_existing_linkname>). Patch by: Pawel Solyga Review by: to-be-reviewed

Add underscore in two word div class names in templates (nick_name, short_name, partial_path). Patch by: Pawel Solyga Review by: to-be-reviewed

Add is_featured boolean property to the Work model, so that Works can be designated as "featured" items in various places in the UI. This will be used to allow Sponsors, Programs, and Organizations to select Documents that should be included in their sidebar menus. Perhaps featured "site" Documents, such as site-wide Terms of Service, should probably be listed below the "User (sign-out)" menu, since the User will have to read and agree to these before being allowed to use the site. A collapsable Javascript sidebar is probably going to be needed soon... Patch by: Todd Larsen Review by: to-be-reviewed

Add missing blank lines, clean up the doc string and remove white spaces at the end of the lines in reflistprop. Patch by: Pawel Solyga Review by: to-be-reviewed

Move <div id='notice'> into notice block in base.html template. Change formatting of notice block to make it much easier to "parse" visually. This patch is based on comments to r722. http://code.google.com/p/soc/source/detail?r=722 Patch by: Pawel Solyga Review by: to-be-reviewed

Add a third-party ReferenceListProperty class. This is going to be used to contain the references to Questions that make up a Quiz. Patch by: Todd Larsen Review by: to-be-reviewed

Fix some defects for lookup user view. More information about the patch can be found under the link below. http://groups.google.com/group/melange-soc-dev/browse_thread/thread/5d378c8d3679945f/d1e7cc3a53adda4e Patch by: Chen Lunpeng Review by: Pawel Solyga

Add missing import in soc/views/site/sponsor/list.py which caused exception when app was deployed and first site you visited was "List Site Sponsors". Update files according to recent django update and django backwards incompatibility (for example newforms is changed to forms). Patch by: Pawel Solyga Review by: to-be-reviewed

Load ../vendor/django into trunk/app/django.

Fixed imports sorting based on comments for r751. http://code.google.com/p/soc/source/detail?r=751 Patch by: Pawel Solyga Review by: to-be-reviewed

Some indentations fixes. Changed all the email=id function arguments to email=id.email(). Patch by: Pawel Solyga Review by: to-be-reviewed

Some indentations fixes and ugettext_lazy() wrap up for DEF_DEV_LOGOUT_LOGIN_MSG_FMT in access.py. Patch by: Pawel Solyga Review by: to-be-reviewed

Rename soc/logic/models/settings.py to model site_settings.py and apply import name change to soc/views/site/home.py Patch by: Pawel Solyga Review by: to-be-reviewed

Fix typos in doc string in sponsor.py and settings.py Patch by: Pawel Solyga Review by: to-be-reviewed

Remove spaces between dict key name and colon. Fix some typos based on comments http://code.google.com/p/soc/source/detail?r=739. Patch by: Pawel Solyga Review by: to-be-reviewed

Add missing blank lines between imports and sort all of the imports. Patch by: Pawel Solyga Review by: to-be-reviewed

Add missing blank lines between imports in access.py module. Patch by: Pawel Solyga Review by: to-be-reviewed

Rearrange imports in home.py so they apply to new discussed format (separate "from ..." and "import ..." blocks). Add Delete Document functionality. Patch by: Pawel Solyga Review by: to-be-reviewed

Bugfixes to the latest revision Some pages did not work due to missing imports, or wrongly imported modules. Patch by: Chen Lunpeng Reviewd by: Sverre Rabbelier

Added missing models/__init__.py and removed empty logic/model directory Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Dictionaries need String values for keys The cleanup patch earlier mistakenly used raw names as keys to the dictionary (such as one would do in a function call). This fixes that mistake. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Removed now-obsolete code from model.py and __init__.py Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Made the existing code use the new soc.logic.models Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Added invididual model logic files Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Also removed helper directory Which somehow did not get removed with the last commit Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Removed obsolete logic directories and added one for model The model/ directory will contain the Base logic classes. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Minor style and import fixes Incorperated changes as suggested by Todd and Pawel. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Missing changes to soc.views.helper.access Due to having to manually do the 'svn mv' of logic to helper, the changes to access.py got lost, this commit fixes that. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Moved soc/logic/helper/access to soc/views/helper/access Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Fix not working delete Sponsor functionality after recent commit. Add delete() method to Base class. Make soc.views.site.sponsor.delete() request handler use this method. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix not working isIdDeveloper() function after recent commit. There is still confusion within getFormFields method (email is not id), but this change doesn't address that problem. Patch by: Pawel Solyga Review by: to-be-reviewed

Changed location of the svn command in svn_load_dirs.pl script from '/usr/bin/svn' to 'svn'. That makes the script more universal and it should work on Linux, Windows and Mac OS X if the svn is in the PATH. Patch by: Pawel Solyga Review by: to-be-reviewed

Refactor nearly all the soc.logic code to use the Base class Instead of having a lot of duplicate code, this patch aims to reduce this duplication by introducing a Base abstraction. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Replace almost all occurences of linkname with link_name In an attempt to have some atomicness in these commits this patch does a rename for the sake of consistency. Not all were changed, but the next commit will address that. Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Load /Users/solydzajs/Downloads/google_appengine/ into trunk/thirdparty/google_appengine.

Add missing __init__.py to soc/logic/helper folder (Caused home page not to work).

Removed now-obsolete getAltResponse* methods from simple.py The getAltResponse* methods have been replaced by the check* methods in soc.logic.helper.access. Patch by: Sverre Rabbelier Reviewed by: Pawel Solyga, Augie Fackler, Todd Larsen Reviewed at: http://codereviews.googleopensourceprograms.com/1601 Review id: 1601

Refactor existing code to use the new access module Instead of ending up with many different ways to do access control, we end up having only one centralized place wher access control is done. Patch by: Sverre Rabbelier Reviewed by: Pawel Solyga, Augie Fackler, Todd Larsen Reviewed at: http://codereviews.googleopensourceprograms.com/1601 Review id: 1601

Add an access control module The module's purpose is to check access requirements, (such as being logged in), and raise an exception containing a authentication request when the requirement is not met. Patch by: Sverre Rabbelier Reviewed by: Pawel Solyga, Augie Fackler, Todd Larsen Reviewed at: http://codereviews.googleopensourceprograms.com/1601 Review id: 1601

Enable recently commited delete Sponsor request handler (added to map.py) and Delete button in Sponsor edit view. Still missing "Are you sure ?" question box. Patch by: Pawel Solyga Review by: to-be-reviewed

Create a submit_buttons blocks in all edit view templates and put submit buttons in separate html table (not as part of the fields table anymore). Patch by: Pawel Solyga Review by: to-be-reviewed

Create a submit_buttons block in group edit profile template so that submit buttons can be customized. Replace submit_message usage with new notice block (still work in progress in Lookup User views). Add customized edit profile template for Sponsor with delete button (not used yet, upcoming commit). Add delete Sponsor request handler. Patch by: Pawel Solyga Review by: to-be-reviewed

Add notification bar block in base.html template. Patch by: Pawel Solyga Review by: to-be-reviewed

Add #notice class declaration in soc.css for upcoming notification bar. Patch by: Pawel Solyga Review by: to-be-reviewed

Update indexes in index.yaml file. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix typo in getSponsorFromLinkName (key_name variable name instead of sponsor_key_name). Add deleteSponsor function for deleting Sponsor entities from datastore.

Style fix, as requested by Todd to dict usage Use "dict['key'] = value" instead of "dict.update({'key' : 'value'})" when updating only one key.

Call soc.logic.site.map.getDjangoUrlPatterns() to construct the urlpatterns from the site map, rather than explicitly listing them in app/urls.py. Patch by: Todd Larsen Review by: to-be-reviewed

Update soc/logic/site/sidebar.py to use parts of the "site map" in soc/logic/site/map.py to generate portions of the sidebar menu. Patch by: Todd Larsen Review by: to-be-reviewed

A site layout ("site map") of the web application, including URL regular expression patterns, Django views, and metadata for constructing sidebar menus and (eventually) breadcrumbs. One function, soc.logic.site.map.getDjangoUrlPatterns(), converts these details into urlpatterns for use by Django. Patch by: Todd Larsen Review by: to-be-reviewed

Url and Page classes used to encapsulate the "site map" information (URL regular expressions, Django views, menu item names, etc.) and the relation between pages in the site map. There are still lots of TODOs in this first pass. Patch by: Todd Larsen Review by: to-be-reviewed

urllib.quote() is needed by the soc/logic/site/map.py work, so import it from the Python 2.5.2 sources. The entire urllib.py is not supported by Google App Engine (yet?), since it relies on 'import socket' (App Engine provides a separate urlfetch module instead). Patch by: Todd Larsen Review by: to-be-reviewed

Remove now-empty soc/views/helpers (everything has moved to soc/views/helper). Patch by: Todd Larsen Review by: to-be-reviewed

Add create() wrapper views that simply call the existing edit() views, to produce unique view names in preparation for the soc/logic/site/map.py code. Patch by: Todd Larsen Review by: to-be-reviewed

Speed up average case by appending remainder of original choices list unchanged (avoiding remaining str -> int type conversions) once the insertion point is found. Patch by: Todd Larsen Review by: to-be-reviewed

Move helpers/html_menu.py to helper/html_menu.py, to clear out soc/views/helpers for deletion. Patch by: Todd Larsen Review by: to-be-reviewed

A specialized SortedDict used by soc/logic/site/page.py. Patch by: Todd Larsen Review by: to-be-reviewed

Move helpers/forms_helpers.py to helper/forms.py. Patch by: Todd Larsen Review by: to-be-reviewed

Move helpers/templatetags to helper/templatetags. Patch by: Todd Larsen Review by: to-be-reviewed

Move helpers/response_helpers.py to helper/responses.py. Patch by: Todd Larsen Review by: to-be-reviewed

Replace helpers/custom_widgets.py with helper/widgets.py. Patch by: Todd Larsen Review by: to-be-reviewed

Move helpers/template_helpers.py to helper/templates.py. Patch by: Todd Larsen Review by: to-be-reviewed

Move helpers/request.py to helper/requests.py to avoid conflict with common local variable name "request". Patch by: Todd Larsen Review by: to-be-reviewed

Move helpers/list.py to helper/lists.py to avoid conflict with built-in type name "list". Patch by: Todd Larsen Review by: to-be-reviewed

Replace soc/views/helpers/request_helpers with soc/views/helpers/request.py and replace uses of request_helpers. with helpers.request. instead. Patch by: Todd Larsen Review by: to-be-reviewed

Move soc/views/helpers/list_helpers.py to soc/views/helpers/list.py and change uses from list_helpers. to helpers.list. instead. Patch by: Todd Larsen Review by: to-be-reviewed

List views should have a selectable pagination "page" length: http://code.google.com/p/soc/issues/detail?id=59 Patch by: Chen Lunpeng and Todd Larsen Review by: Augie Fackler Review URL: http://codereviews.googleopensourceprograms.com/1201

Change to imports to follow the style guide: http://code.google.com/p/soc/wiki/PythonStyleGuide#Module_and_package_imports Specifically: "Use from x import y only when x is a package and y is a module."

Make findNearestUsers() code in soc/logic/site/id_user.py more generic and move it to soc/logic/model.py. Orginal findNearest...() functions in id_user.py are now convenience wrappers. Add typed-query string construction functions to model.py. Move getFulLClassName() from key_name.py model.py, since it has more to do with Model types than key names. Swap 'offset' and 'limit' and make 'limit' arguments non-optional. Also, stop adding 1 inside the ...ForLimitAndOffset() functions and make the callers do it (since it was being added for a very UI-specific reason of whether or not to display a "Next>" link). Patch by: Todd Larsen Review by: Pawel Solyga Review URL: http://codereviews.googleopensourceprograms.com/1401

Factor out an isIdAvailable() function from EditForm.clean_id() in soc/views/site/user/profile.py and add it to soc/logic/site/id_user.py. Addresses some comments on r614. Patch by: Todd Larsen Review by: Pawel Solyga Review URL: http://codereviews.googleopensourceprograms.com/1202

Add Allen (Chen Lunpeng) to trunk/AUTHORS, due to his several recent patches.

Fix typo in recent validate.py changes (r682). Patch by: Chen Lunpeng Review by: Todd Larsen

Add basic Sponsors List, Create New Sponsor, Sponsor Public Profile views. Change all properties in Group model as required for now. Remaining TODO: write validation functions for Sponsor edit and create form fields that need additional validation (like address, phone number format). Patch by: Pawel Solyga Review by: to-be-reviewed

Add Sponsor logic functions. Patch by: Pawel Solyga Review by: to-be-reviewed

Add group templates that can be used by Sponsor, Organization, School, Club views. Right now only upcoming commit of Sponsor views is using it. Patch by: Pawel Solyga Review by: to-be-reviewed

Remove excluded field inheritance_line, since the User model does not inherit from PolyModel (at this time).

Add colon at the of _readonly_field_as_table_row template tag label parameter. Replace hardcoded labels in User Public profile template with linkname_user.fields.<field_name>.label values.

Fix missing blank line to follow PythonStyleGuide in model.py.

Add links in sidebar for upcoming Sponsor views. Patch by: Pawel Solyga Review by: to-be-reviewed

Change key_name module usage to path_linkname module (fix to previous commit). Add comments about urls. Add Sponsor views urls for upcoming Sponsor views modules. Patch by: Pawel Solyga Review by: to-be-reviewed

Move path and link_name related functions and regex patterns to a new soc/logic/path_linkname.py module, and fix all dependencies. path/link_name functionality is becoming the generic way to identify entities in the Datastore in a URL-compatible way.

Make form field components use a smaller font, without shrinking the font of all text in the page body.

Replace common module with validate module. Move validation function from feed module to validate module and remove feed.py. Correct any usage of validation functions from common and feed modules into validate module. Patch by: Pawel Solyga Review by: to-be-reviewed

Add missing blank line to follow PythonStyleGuide in document.py

Fixed typo in DEF_CREATE_NEW_DOC_MSG.

Shrink the sidebar menu separately from the main body text.

Moved isLinkNameFormatValid function out of id_user module to new common module. This function is going to be used by other form validation functions that require to validate linkname (different kind of Groups, Programs etc). Patch by: Pawel Solyga Review by: to-be-reviewed

Fixed models based on output from graph.py script and comments on http://groups.google.com/group/melange-soc-dev/browse_thread/thread/fb532a7db1f19ea7

Tool to graph the data model.

Some TODOs on access control that I didn't want to forget.

Matching just /docs created a very small namespace, since any other path parts would match the Document path. So, append /show after /docs for the display view. This makes other views like /docs/edit possible later.

URL pattern changes that were missed by r671.

Some styles used by r671, the simplistic Document view.

A very simplistic Document viewer.

Implements a Site (Developer) generic Document editor form.

Changes to make breadcrumbs match page title. This is mostly to see how it looks, since the new soc/logic/site/map.py code is going to implement the breadcrumbs and page title contents in a similar way.

Start using "Site" instead of "Developer" in the UI.

Implement a Developer list view of all Documents. Patch by: Todd Larsen Review by: to-be-reviewed

Add missing all() __doc__ string comments: "Args:" and "Returns:" sections.

Fix some style guide issues: keyword arguments are supposed to always be supplied using the keyword argument name=value. http://code.google.com/p/soc/wiki/PythonStyleGuide#Default_Argument_Values

Directory for up-coming /site/docs/list and /site/docs/edit templates.

Fix typo in findNearestUsersOffset() __doc__ string missed in r661.

Show link to /site/user/list on /site/user/lookup when User is not found. http://code.google.com/p/soc/issues/detail?id=61 Patch by: Chen Lunpeng Review by: Todd Larsen (with modifications)

Add placeholder for future (to-be-implemented) getPreferredListPagination() function.

Remove a TODO that should have been removed for r658.

Update some of the URL patterns to get their link_name parsing from the new patterns in key_name.py. (Using it like this in urls.py is why key_name.py needs to not depend on other modules...)

Add functions to soc/logic/document.py for dealing with partial_paths combined with link_names. Add getWorksForOffsetAndLimit() to query for Documents for the /site/docs/list view.

Hide PolyModel inheritance_line bookkeeping property from the User Profile form.

Use the LINKNAME_PATTERN from its new home in key_name.py. Also, add some missing blank lines that are required by the style guide.

Add lots of new functions to key_name.py, including path/link_name processing. Copy various link_name related regex patterns to key_name.py and use them. Add error checking that raises a key_name.Error exception when name...() functions are given empty arguments. Hard-code class names, since they match what was typed into the module.class.__name__ to get the name anyway. This eliminates dependencies on any modules by key_name.py.

Add sidebar menu items for /site/docs/list and /site/docs/edit. They do not currently have view functions attached, but there are other links in the mock-up portion of the sidebar that don't currently work, either. The goal is to commit the /site/docs/list and /site/docs/edit changes in small bits that don't break anyone else.

Add partial_path property explicitly to the Work model.

Should have been part of the r650 commit.

Directory for upcoming /site/docs views.

Add "Last updated" footer to front page body text, using the modified Property from the Work entity.

Change _readonly_field_as_table_row <td> tag class names to match those used in _field_as_table_row. That should actually go into previous commit. Patch by: Pawel Solyga Review by: to-be-reviewed

Clean up too long lines in profile.py. Add ReadOnlyInput widget to custom_widgets module, it can be used to display read-only form fields. Display read-only "Id" field in LookUp view if user has been found and in User Edit Developer view. Patch by: Pawel Solyga Review by: to-be-reviewed

Add polymodel folder to DEFAULT_APP_DIRS variable in make_release.sh script.

Add key naming function for Sponsor, School, Organization, Club key_names. Patch by: Pawel Solyga Review by: to-be-reviewed

Add org ReferenceProperty to Administrator model (many:1 relationship associating Administrators with specific Organization). Update Organization model __doc__ string with information about the back-reference 'admins'. Patch by: Pawel Solyga Review by: to-be-reviewed

Made mce_settings class variable in TinyMCE widget a copy of default settings instead of reference.

Replaced context.update call to simple value assignment in site.user.profile.create view function.

Load ../../google_appengine/ into trunk/thirdparty/google_appengine.

Take advantage of the Model inheritance provided by polymodel.PolyModel to have Club, School, Sponsor, and Organization actually inherit from the Group Model class, rather than being composed via ReferenceProperties. Patch by: Todd Larsen Review by: Pawel Solyga, Sverre Rabbelier, Augie Fackler Review URL: http://codereviews.googleopensourceprograms.com/606

Take advantage of the Model inheritance provided by polymodel.PolyModel to have create a class hierarchy rooted at Person. Also, add some missing Role classes, such as Role, (Organization) Mentor, (Club) Member, (School) Student. Make (Organization) Administrator be a Reviewer like Mentor is. Patch by: Todd Larsen Review by: Pawel Solyga, Sverre Rabbelier, Augie Fackler Review URL: http://codereviews.googleopensourceprograms.com/607

Make use of PolyModel for Works, Documents, etc. Add some (but not all) of the missing Models related to Documents. Refactor site settings to be useful for any "/home" page view. Make the resulting home settings store a reference to the Document, rather than looking up the Document by a hard-code key name. This is to set the stage for Document editing being generic, and then being able to select from some existing documents which one to use as the "/home" static content. This makes it possible to pre-edit several Documents, have them Reviewed, and then quickly change the "/home" page content as a setting, rather than editing the Document in the settings form (though settings forms might still embed the current document into their form for convenience). Patch by: Todd Larsen Review by: Pawel Solyga Review URL: http://codereviews.googleopensourceprograms.com/1001

Fixed not working "Create New User" view which was caused by adding key_name into User Edit Developer view. This commit divides edit() view function in soc.views.site.user.profile into edit() and create() request handlers. New create() request handler is used only in "Create New User" view and has specific form validation functions and uses updateOrCreateUserFromId() instead of updateUserForKeyName(). Patch by: Pawel Solyga Review by: to-be-reviewed

Add ModelWithFieldAttributes *before* PolyModel, so that everything does not become a "ModelWithFieldAttributes" in the Datastore. The way PolyModel works, each Model class hierarchy is stored in the Datastore as the class that directly inherited from PolyModel. So, we do not want to insert ModelWithFieldAttributes *after* PolyModel by inheriting *from* PolyModel, or everything would just be a ModelWithFieldAttributes in the Datastore, instead of Person, Work, Group, etc.

Add the third-party PolyModel class. This class supports inheritance in Google App Engine Datastore Model classes.

A key_name controller module to collect all of the name...() functions that compose Model entity key names, plus some minor changes to other controller modules to illustrate the proposed use. Patch by: Todd Larsen Review by: Pawel Solyga Review URL: http://codereviews.googleopensourceprograms.com/804 Review URL: http://codereviews.googleopensourceprograms.com/804

Fixed missing urlparse import in request_helpers which cause /user/profile and /site/user/profile not to work at all. Removed not used module imports in response_helpers.py.

Replace mock-up of sidebar with first draft of dynamic sidebar functionality.

Minor tweaks to Site menu item names to make them more descriptive.

Major refactoring, to switch from using inheritance from soc.logic.menu classes to an envelope-letter model instead.

Sidebar-building controller, with a TODO remaining to implement marking the current page as "selected".

Make views.helpers.html_menu MenuItem classes and logic.menu MenuItem classes more closely related. This is part of some refactoring in my working copy to keep soc/logic/site/sidebar.py from having to deal with html_menu classes (which is like having view code in the controller, which is bad).

Classes that wrap soc.logic.menu.Menu and soc.logic.menu.MenuItem to produce HTML renderings of such lists.

Change indentation level to 2 (from 4) and rename MCE_DEF_SETTINGS to DEF_MCE_SETTINGS to match the "default constant" naming convention elsewhere in the code.

Note 'groups' back-reference from 'founder' property in soc.models.group.Group.

Simple MenuItem and Menu classes for keeping track of ordered menus.

These changes should have been in r620, but somehow I did not save them, or saved over them with an old copy in the editor. Not sure...

Move isReferrerSelf() and replaceSuffix() into new request_helpers.py module, since they are (mainly) used to manipulate parts of an HTTP request.

Split out HTTP request manipulation functions from template_helpers.py, which is in danger of becoming a "misc" or "util" module unnecessarily.

Changes in TinyMCE widget in custom_widgets.py based on review comments. Patch by: Pawel Solyga Review url: http://code.google.com/p/soc/source/detail?r=550

Change user list view instruction. Don't show "Next >" disabled greyed text in the list pagination if there is only one page.

Add Users List Developer view which is available at /site/user/list. Add User list custom templates which are used with list_helpers. Add "Users List" link in base.html template. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Add list_helpers functions that are going to be used when rendering list views like (Users List, Sponsors List etc). Add list default templates and CSS classes. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Add support for changing User id (Google Account email) in User Profile Developer view. Now user profile developer edit view includes hidden key_name field. Fix typo in user/profile.py. Show former user ids in lookup and edit User Profile Developer views. Patch by: Pawel Solyga Reviewed by: to-be-reviewed

Small change to unescape function in template_helpers (move replace('&amp;', '&') at the end).

Add rounded corners graphics. Add .notice class and rounded corners classes to soc.css file, those will be used to better visualize submit_message like "Profile saved.".

Remove Author model (use Person instead). Update models after removing Author. Add new Sponsor, Organization models. Patch by: Pawel Solyga Reviewed by: Todd Larsen Review issue: 801 Review URL: http://codereviews.googleopensourceprograms.com/801

Two changes to ease CI: 1) If pysvn is missing, the tests for svn_helper don't run and pollute the output 2) svn_helper no longer depends on being located at trunk/scripts/ Patch by: Augie Fackler Review by: Todd Larsen Review Issue: 802 Reviewed URL: http://codereviews.googleopensourceprograms.com/802

Add custom 404 error message with link to "Create a New User" which is displayed when linkname in User Profile Developer view URL (/site/user/profile/<linkname>) doesn't exist. Add default value (None) to new_suffix parameter of template_helpers replaceSuffix and redirectToChangedSuffix functions.

Testing buildbot. Sorry about the noise. (Last one for now, I've got most of the kinks figured out I think)

Testing buildbot. Sorry about the noise.

Testing buildbot. Sorry about the noise.

Make django.zip in release/, instead of in app/ with a symlink in release/. This allows debugging into app/django source code, which the presence of app/django.zip was blocking. Tested with both: dev_appserver.py release and dev_appserver.py app

A rough draft of the Group Model, to be merged with Pawel's current effort in his working copy. This is *very* incomplete...

First pass (from some old code notes) of a School Model (a form of Group).

First pass (from some old code notes) of a Club Model (a form of Group).

Bug fixes to revision r596. User Account field in Developer User Profile view needs to be an email not a login name. Header title of User Profile Developer view, when form validation failes is now showing correct value ("Modify existing ..." instead of "Create new user ...").

Add /site/user/profile Developer view for editing arbitrary User entities. Update /user/profile edit() view to fix TODO about updating the URL when a POST of the form changes the link_name of the User. Add a Create New User link to the base.html sidebar mock-up.

Fix off-by-one corner case discovered during testing of /user/profile.

Added getSingleIndexedParamValue() that retrieves an index into a list of values from the named query parameter, and then indexes into the supplied list of values to return the corresponding value from the list. Used to convert numeric index query parameters passed by POST to the GET redirect target, so that the GET code can display messages, etc. (without passing the message itself as a query argument and having to escape it or have silly people pass in their own...).

Added replaceSuffix(), isReferrerSelf(), and redirectToChangedSuffix() to implement the TODO in the User profile views where the link name portion of the URL needs to change when the link_name Property is updated by the form.

Fixed too long lines and deleted unused imports in id_user.py.

New default values for page title, header title and body of site home page.

Documentation updates and one typo fix.

Add a td.formfielderrorlabel style, to highlight field labels that have errors.

Swap field value and "required" columns to make more columns for field errors.

Add a verbose_name and help_text to the User.id Property.

Explain why pushd and popd are needed when making tiny_mce.zip.

Use zip to compress tiny_mce, and use zipserve to serve it in Google App Engine.

Updated make_release.sh docs and added way for person invoking the script to override script variables such as RELEASE using something like "RELEASE=../testing_release ./make_release.sh".

Add recently-moved feedparser and tiny_mce to APP_DIRS.

Oops, this should have been part of the r580 commit.

Oops, this should have been part of the r577 commit.

Move third-party TinyMCE out of soc/content/js and into the application image root, like other third-party code. Update the app.yaml.template to add /tiny_mce as a source of static content.

Add README files to explain how third-party code is maintained in these directories.

Discourage third-party code from being embedded in the soc framework.

Move third-party feedparser.py out of the soc framework package into its own package (similar to django).

Changed ZIPFILE variable to DJANGO_ZIPFILE in make_release.sh script and added 'cd $APP_FOLDER' before we zip django.

Load ../google_appengine into trunk/thirdparty/google_appengine.

upload.py customized to work with codereviews.googleopensourceprograms.com.

Pristine initial commit of upload.py script from http://code.google.com/p/rietveld (r310).

gcl.py customized to work with codereviews.googleopensourceprograms.com and the melange-soc-dev@googlegroups.com mailing list.

Pristine initial commit of gcl.py script from chromium.org.

Release shell script and associated changes. Set svn:ignore property on /app/django.zip file and /release folder. Patch by: Pawel Solyga, Augie Fackler Review by: Todd Larsen, review-after-commit Review issue: 363 Review URL: http://codereviews.googleopensourceprograms.com/363

FIxed documentation in soc/logic/document.py for getDocumentFromPath function Patch by: Christian López Espínol Reviewed by: Pawel Solyga Reviewed via: discussion on melange-soc-dev group

Forgot to change widgets to custom_widgets import in home.py after changing the name of soc/views/helpers/widgets.py file.

Added Melange front page edit view where you can change title, content, feed url. Created SiteSettings and Document models and some logic for them. Added isFeedURLValid function in soc/logic/feed.py. Created some functions for handling datastore updates of different kinds of Models (soc/logic/model.py). Fixed some typos and too long lines of code. Patch by: Pawel Solyga Review by: to-be-reviewed

Added feedparser to soc/utils and modified svn:externals for vendor to include feedparser svn Patch by: Pawel Solyga Review by: to-be-reviewed

Add getAltResponseIfNotLoggedIn() and getAltResponseIfNotDeveloper() simple view helpers. These cannot go into response_helpers.py because they create a circular reference with simple.py, and Django view import fails. Review URL: http://codereviews.googleopensourceprograms.com/602

Improve the __doc__ string of isIdDeveloper() to explain better how it now functions.

Make isIdDeveloper() also able to check an is_developer Boolean property in User entities. Review URL: http://codereviews.googleopensourceprograms.com/601

Replace checkLinkNameForId() with isLinkNameAvailableForId(), and implement that new function in terms of only the existing doesLinkNameExist() and doesLinkNameBelongToId(). Patch by: Todd Larsen Review by: Pawel Solyga Review via: discussion of patches on melange-soc-dev mailing list

Fixed one typo in response_helpers which caused is_admin context variable not to work correctly. Created new checkLinkNameForId function that checks if link_name is correct when creating new user and modifying existing one. This is now used for validation instead of doesLinkNameBelongToId in UserForm clean_link_name function. The previous validation function didn't allow to create new users and modify linkname of existing ones. Additionally I created new doesLinkNameExist helper function.

Fixed wrong user variable in lookup.html template for edit link (was user should be found_user). There is no DeveloperForm in site/user/profile.py changed that to LookupForm.

gcl.py committed this file, when it should not have even existed.

Add a /site/user/lookup view that provides Developers with a form to look up User entities given email addresses or link names.

...

Updated the script to: * Include a comment describing what it does * Use variables for anything non-standard * Use the --parse-only flag of epydoc * Exclude all 'django' modules through --exclude= * Run on '../app' by default, no more arguments needed * Clean up the output directory before running

Bugfix, invalid syntax noticed by epydoc.

Updated docs in response_helpers. Patch by: Pawel Solyga Review by: to-be-reviewed

Created custom_widgets.py and added TinyMCE django widget that can be later used for particular form fields. Patch by: Pawel Solyga Review by: to-be-reviewed

Added TinyMCE to Melange in soc/content/js Patch by: Pawel Solyga Review by: to-be-reviewed

An emerging pattern with makeSiblingTemplatesList() is that views calling that function then append a known, default template "just in case". This change adds a default_template parameter to makeSiblingTemplatesList() to eliminate the extra "append a known default to the end" step for the caller. Patch by: Todd Larsen Review by: to-be-reviewed

Refactor soc/views/user/profile.py to make use of several of the new views available in soc/views/simple.py. Patch by: Todd Larsen Review by: to-be-reviewed

Fix an overlooked cut-and-paste error. Patch by: Todd Larsen Review by: to-be-reviewed

Add a public() convenience wrapper around templateWithLinkName() for the common public.html case. Add a requestLogin() view. Patch by: Todd Larsen Review by: to-be-reviewed

This CSS change belonged with soc/templates/soc/error.html committed in r454. Patch by: Todd Larsen Review by: to-be-reviewed

A default error.html template to go with the simple.errorResponse() view. Patch by: Todd Larsen Review by: to-be-reviewed

Add soc.views.simple containing (initially) two simple template views. templateWithLinkName() is a view that can replace most public() read-only views. errorResponse() is a view that renders an error page for out_of_band.ErrorResponse exceptions. Also, change response_helpers.respond() to accept keyword arguments to pass to http.HttpResponse(). (errorResponse() makes use of this new respond() feature.) Patch by: Todd Larsen Review by: to-be-reviewed

Clean up User Model and User profile edit view now that soc.logic.site.id_user module exists. Change usage of "user" to be "id" the variable refers to a Google Account and not a User entity. Patch by: Todd Larsen Review by: to-be-reviewed

Pawel and I were working on the same thing, apparently. My template_helpers.py is more complete, so I am removing this one (that Pawel appears to not have used yet). Patch by: Todd Larsen Review by: to-be-reviewed

Factor out a getUniversalContext() function so that views that do not call response_helpers.response() can benefit from the code that constructs shared template context variables common to many templates. Patch by: Todd Larsen Review by: to-be-reviewed

Create a package for controller modules that interact with User entities. Patch by: Todd Larsen Review by: to-be-reviewed

A collection of functions for determining the characteristics of the "system" on which a Melange application is running. Currently, this consists of only a boolean isDebug() function. Patch by: Todd Larsen Review by: to-be-reviewed

Helpers for manipulating templates and template search paths. Patch by: Todd Larsen Review by: to-be-reviewed

Consolidate functions dealing with Google Accounts and look-up of User entities into a single site-wide controller module. Tests will be added in a subsequent commit as soon as Google App Engine tests using mocker are figured out. Patch by: Todd Larsen Review by: to-be-reviewed

Exception classes used by controller logic to request an "out-of-band" response be displayed by the view instead of what the view would normally display. Patch by: Todd Larsen Review by: to-be-reviewed

Base classes for all Datastore Models in Melange. Patch by: Todd Larsen Review by: to-be-reviewed

Load ../../google_appengine into trunk/thirdparty/google_appengine.

Create directories to load project into. * trunk/thirdparty/google_appengine: New directory.

Move third-party code that is not required to be part of trunk/app into a trunk/thirdparty "sandbox". Patch by: Todd Larsen Review by: to-be-reviewed

Move third-party code that is not required to be part of trunk/app into a trunk/thirdparty "sandbox". Patch by: Todd Larsen Review by: to-be-reviewed

Remove the obsolete scripts left over from when trunk/app did not contain the entire Google App Engine image. Patch by: Todd Larsen Review by: to-be-reviewed

Add mocker 0.10.1 to trunk/thirdparty, so that it can be used to create mocks for testing the Google App Engine app itself. See also: http://blog.appenginefan.com/2008/06/unit-tests-for-google-app-engine-apps.html Patch by: Todd Larsen Review by: to-be-reviewed

Move LICENSE.django closer to the actual trumk/app/django code we are importing (that exists in trunk/app to be part of the Google App Engine image). LICENSE.django cannot go in trunk/app/django itself, because that directory is maintained from the /vendor/django svn external using svn_load_dirs.pl (so putting all the way into trunk/app/django gets it repeatedly removed). Patch by: Todd Larsen Review by: to-be-reviewed

Third-party packages that do not need to be part of trunk/app (because they are not part of a Google App Engine image upload).

Since google_appengine isn't part of the uploaded trunk/app, there is no reason why it couldn't be in a thirdparty directory, alongside mocker.

Create directories to load project into. * trunk/google_appengine: New directory.

Added public view support (not using controller yet) Changed Google Account variable from user to id in views and templates (no more confusions with Melange user). Added templates_helpers for makeSimblingTemplate function. Addded new template tag readonly_field_as_table_row used in public views Fixed one typo in roles.py

User Profile view (without controller yet). Patch by: Pawel Solyga Review by: Todd Larsen Review issue: 386 Review URL: http://codereviews.googleopensourceprograms.com/386

Moved Proposal model from wiki to source code and updated ProposalModel wiki page. Patch by: Pawel Solyga Review by: Todd Larsen Review issue: 362 Review URL: http://codereviews.googleopensourceprograms.com/362

Moved td.formfieldlabel to FORM TABLE FIELDS section.

Move soc/control to soc/logic, so that tab-completion doesn't keep matching soc/content instead.

nickname was moved from Person to User recently.

Add Roles template directory that was missing from r426 commit.

Create package for up-coming Role views.

Minor indentation fix.

Create package for standard Melange controller modules.