Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 22 Jan 2009 22:04:00 +0000] rev 908
Remove unused decorators import from soc.views.models.role module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 22 Jan 2009 22:03:32 +0000] rev 907
Fix idention in soc.views.models.club module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 22 Jan 2009 22:02:40 +0000] rev 906
Fix missing dots in soc.views.helper.decoratos module docstrings.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 22 Jan 2009 22:01:16 +0000] rev 905
Rename clean_existing_user_not_equal_to_current function to clean_users_not_same in soc.logic.cleaning module and fix affected files.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 22 Jan 2009 17:26:14 +0000] rev 904
Hide the 'link_id' field for site
Also construct the scope_path from the fields in case the entity
has not yet been created.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 22 Jan 2009 17:23:17 +0000] rev 903
Rename "site/settings" to "site"
The "/site/settings" view is not about the Site Settings an sich, but
more about the "site presence singleton". In this context it does not
make sense to call it "site/settings".
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 22 Jan 2009 16:05:49 +0000] rev 902
Fixed one style error and one typo.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 22 Jan 2009 16:04:48 +0000] rev 901
Presence is now a 'abstract' View, pull in members from program
This is signified by the removal of params['name'] and other values
that are required by params.py, but also by the removal of the 'view'
definition at the bottom of the file.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 22 Jan 2009 16:03:17 +0000] rev 900
Extend dicts.merge to be (optionally) recursive
This is very useful when dealing for views that expect to be
inhereted from but wish to provide default values.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 22 Jan 2009 16:01:51 +0000] rev 899
Fix form errors and hidden form errors
The conversion to django left out the 'prettyfying' of form and
hidden form errors, as these could occur when running live, restore
this behavior.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 22 Jan 2009 13:50:25 +0000] rev 898
Added a cleaning method for a LinkProperty Field.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 22 Jan 2009 00:07:36 +0000] rev 897
Fixed wrong conditional in soc/views/models/club_app.py.
Notifications will now be send again.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 22 Jan 2009 00:03:28 +0000] rev 896
Fixed import sorting and indentation in soc/views/models/club.py
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 23:44:02 +0000] rev 895
Even developers need to agree to the terms of service for Melange
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 23:43:16 +0000] rev 894
Corrected the list index parameters in soc/views/models/club_app.py
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 23:18:39 +0000] rev 893
Added Ignored applications to the list view.
Also restored the New Club notification upon application acceptance. That broke in r1483.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 22:47:22 +0000] rev 892
Replaced boolean properties in soc/models/group_app with status property.
This property has 5 choices ['accepted','rejected','ignored','needs review','completed']
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 22:21:40 +0000] rev 891
Move getToSLink() to soc.views.helper.redirects.getToSRedirect().
Fixes a circular import problem that prevented the site-wide ToS link from
being displayed by checkAgreesToSiteToS(). This is now completely implemented.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 21:41:36 +0000] rev 890
Tighten more checkIsUser() access to checkAgreesToSiteToS() instead.
Update the checkIsHost() comment.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 21:32:51 +0000] rev 889
Make checkAgreesToSiteToS() the default access check for many other checks.
Replace checkIsUser() with the more-strict checkAgreesToSiteToS(). Also, add
missing args and kwargs parameters to checkAgreesToSiteToS() that were missed
in the merge right before commit.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 21:25:18 +0000] rev 888
Add checkAgreesToSiteToS() (partially implemented until circular import fixed).
Need to fix a circular import problem before the alternate message will
include a link to the site-wide ToS Document.
Also, fixed the descriptions in the first few check...() functions.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 21:09:52 +0000] rev 887
Take advantage of new "from ... import ... as ..." rules in the style guide.
Patch by: Todd Larsen
Review by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 20:25:07 +0000] rev 886
Added clean_existing_user_not_equal_to_current to clean the backup Administrator field in an application.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 19:53:23 +0000] rev 885
Changed the redirect in club application overview to the correct page.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 19:45:13 +0000] rev 884
Changed checkIsClubAppAccepted into a more generic checkIsApplicationAccepted.
Also fixed a minor bug in club_app view.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 19:40:39 +0000] rev 883
Changed the collection name and help text for Organization member template.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 19:32:00 +0000] rev 882
Added club_app model and logic.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 18:50:22 +0000] rev 881
Added created and last modified timestamps to the group_app model.
Also edited the templates to show some extra information. The review template has the names for the new properties hard coded because the auto_add and auto_add_now datetimeproperties don't show up in the fields of the entity.
Patch by: Lennard de Rijk
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 18:25:37 +0000] rev 880
Fixed typo in r1446.
Patch by: Todd Larsen
Review by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 16:13:51 +0000] rev 879
Changes in Role model.
Clarified that we are asking for a shipping adress. Also moved Agrees to ToS to the bottom.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 16:13:18 +0000] rev 878
Fix trailing whitespace and apply decorators
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 16:13:03 +0000] rev 877
Fix whitespace damage
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 16:12:48 +0000] rev 876
Make use of the new decorators in all applicable views
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 16:12:31 +0000] rev 875
Renamed showReviewOverview to review_overview and reviewOverview
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 16:12:16 +0000] rev 874
Fixed two trivial bugs
A "kwargs=kwargs" instead of **kwargs
Missing 'and entity' check
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 16:12:01 +0000] rev 873
Added a merge_params and check_access decorator
The merge_params decorator is very simple and takes self._params and
merges it with params. It's main purpose is to explicitly mark the
views in which it is intended that self._params is merged raw.
The check_access decorator factors out the access checking process
and passes args and kwargs to the access checking methods.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 21 Jan 2009 16:11:47 +0000] rev 872
Prepare access to receive args and kwargs as argument
Also use two "magic values" when the sidebar is doing the access
checks, this might be useful later.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 15:35:10 +0000] rev 871
Reverted r1457.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 15:29:58 +0000] rev 870
Changed link in club_app accepted notification.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 15:11:45 +0000] rev 869
Added a new view to help with application -> group process.
The applicant view is available only when there is an accepted application present. This will be checked by the access checker in an upcoming patch. The view uses a special form so that certain fields cannot be edited by the user. These fields correspond to important fields filled in during the application process.
Create access for a club has now been set to Host level.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 14:57:12 +0000] rev 868
onCreate for a Club now marks any application for the same club as completed and invites the admins.
This is useful for when the club has been created without using the application.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 14:36:44 +0000] rev 867
Edited the method used to clean link_id in params.py.
Removed the clean_new_link_id from the logic/cleaning.py module because this is not used anymore.
This method should be replaced by a method that is used after all the fields have been cleaned so that the actual key_name of an entity can be constructed.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 21 Jan 2009 13:55:06 +0000] rev 866
Fixed a typo in the comments of soc/views/helper/forms.py
Patch by: Lennard de Rijk
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 02:39:29 +0000] rev 865
Fix missing import identified by pylint.
************* Module app.soc.logic.models.user
E0602: 99:Logic.agreesToSiteToS: Undefined variable 'db'
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 02:37:43 +0000] rev 864
Fix missing import identified by pylint.
************* Module app.soc.logic.models.presence
E0602: 56:Logic.getToS: Undefined variable 'db'
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 02:34:43 +0000] rev 863
Fix missing import identified by pylint.
************* Module app.soc.views.helper.responses
E0602:187:getToSLink: Undefined variable 'db'
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 02:31:55 +0000] rev 862
Add agreesToSiteToS() logic method to indicate if User accepts site-wide ToS.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 02:18:07 +0000] rev 861
Give error messages more room in the existing form field "as_table" templates.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 02:14:05 +0000] rev 860
Add a clean_agrees_to_tos() validator that requires "Yes" if ToS exists.
Also, more user_logic.logic => user_logic fixes. If you are going to import
"as", you might as well make the renaming worthwhile. Maybe we need to add
a section on "import ... from ... as ..." in the style guide?
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 00:32:05 +0000] rev 859
Change "Show" to "Export" missed in r1446 commit.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 21 Jan 2009 00:27:39 +0000] rev 858
Add an export() view, and implement it as text/text for Document.
For every Model except Document, the public() view is displayed for any
attempts to access the export() view.
Currently, the permissions for export() are the same as for public(). This
seems reasonable for Document, since anyone could extract the raw HTML from
the page source anyway. The permissions should probably be different for
other types of exports, such as vCard or iCard exports of profiles, CSV
exports of lists, etc.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 23:13:03 +0000] rev 857
If a site-wide ToS exist, display the User profile "Agrees to ToS" checkbox.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 23:01:24 +0000] rev 856
Set agrees_to_tos example text to link to site-wide ToS (or a warning message).
Also, since a renaming import statement is being used already, change
user_logic.logic to just user_logic.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 22:33:43 +0000] rev 855
Do not crash on *every* page load if there is no ToS Document.
'tos' ReferenceProperty might be present, but still be None.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 22:30:21 +0000] rev 854
A better way to add site-wide ToS link to *all* pages on the site.
getUniversalContext() already fetches a copy of the Site settings, so use that
to see if the site-wide ToS exist and produce a link.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 22:21:32 +0000] rev 853
Linux /bin/sh (GNU) is not the same as OS X /bin/sh (BSD), so use /bin/bash.
Fixes:
scripts/pylint/do_pylint.sh: 27: Syntax error: "(" unexpected
on Ubuntu (and possibly other Linux distros).
Patch by: Todd Larsen
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 20 Jan 2009 22:01:02 +0000] rev 852
Replace css class 'notice' that is used in User profile template field help text with new 'fieldhelptext' class. Notice is part of CSS for notification bar and we want width limit just for field help text not for notification bar text.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 21:48:28 +0000] rev 851
Add getSingleton() method to return the Site settings entity.
There is always only one Site entity, referred to by DEF_SITE_LINK_ID.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 21:37:30 +0000] rev 850
Return the ToS Document of the supplied Presence entity, if there is one.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 20 Jan 2009 21:26:34 +0000] rev 849
Support HTML tags in form field example_text column.
Improve the Program Model example_text as an example.
Patch by: Todd Larsen
Review by: to-be-reviewed