Wed, 01 Oct 2008 20:52:39 +0000 Move path and link_name related functions and regex patterns to a new
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 20:52:39 +0000] rev 251
Move path and link_name related functions and regex patterns to a new soc/logic/path_linkname.py module, and fix all dependencies. path/link_name functionality is becoming the generic way to identify entities in the Datastore in a URL-compatible way.
Wed, 01 Oct 2008 20:48:58 +0000 Make form field components use a smaller font, without shrinking the font
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 20:48:58 +0000] rev 250
Make form field components use a smaller font, without shrinking the font of all text in the page body.
Wed, 01 Oct 2008 19:21:09 +0000 Replace common module with validate module. Move validation function from feed module to validate module and remove feed.py. Correct any usage of validation functions from common and feed modules into validate module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 19:21:09 +0000] rev 249
Replace common module with validate module. Move validation function from feed module to validate module and remove feed.py. Correct any usage of validation functions from common and feed modules into validate module. Patch by: Pawel Solyga Review by: to-be-reviewed
Wed, 01 Oct 2008 19:17:13 +0000 Add missing blank line to follow PythonStyleGuide in document.py
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 19:17:13 +0000] rev 248
Add missing blank line to follow PythonStyleGuide in document.py
Wed, 01 Oct 2008 19:15:20 +0000 Fixed typo in DEF_CREATE_NEW_DOC_MSG.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 19:15:20 +0000] rev 247
Fixed typo in DEF_CREATE_NEW_DOC_MSG.
Wed, 01 Oct 2008 16:47:00 +0000 Shrink the sidebar menu separately from the main body text.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 16:47:00 +0000] rev 246
Shrink the sidebar menu separately from the main body text.
Wed, 01 Oct 2008 14:23:28 +0000 Moved isLinkNameFormatValid function out of id_user module to new common module. This function is going to be used by other form validation functions that require to validate linkname (different kind of Groups, Programs etc).
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 14:23:28 +0000] rev 245
Moved isLinkNameFormatValid function out of id_user module to new common module. This function is going to be used by other form validation functions that require to validate linkname (different kind of Groups, Programs etc). Patch by: Pawel Solyga Review by: to-be-reviewed
Wed, 01 Oct 2008 09:43:25 +0000 Fixed models based on output from graph.py script and comments on
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 09:43:25 +0000] rev 244
Fixed models based on output from graph.py script and comments on http://groups.google.com/group/melange-soc-dev/browse_thread/thread/fb532a7db1f19ea7
Wed, 01 Oct 2008 07:26:45 +0000 Tool to graph the data model.
Tim Ansell <mithro@gmail.com> [Wed, 01 Oct 2008 07:26:45 +0000] rev 243
Tool to graph the data model.
Wed, 01 Oct 2008 07:11:27 +0000 Some TODOs on access control that I didn't want to forget.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 07:11:27 +0000] rev 242
Some TODOs on access control that I didn't want to forget.
Wed, 01 Oct 2008 07:10:43 +0000 Matching just /docs created a very small namespace, since any other path parts
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 07:10:43 +0000] rev 241
Matching just /docs created a very small namespace, since any other path parts would match the Document path. So, append /show after /docs for the display view. This makes other views like /docs/edit possible later.
Wed, 01 Oct 2008 07:01:06 +0000 URL pattern changes that were missed by r671.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 07:01:06 +0000] rev 240
URL pattern changes that were missed by r671.
Wed, 01 Oct 2008 07:00:26 +0000 Some styles used by r671, the simplistic Document view.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 07:00:26 +0000] rev 239
Some styles used by r671, the simplistic Document view.
Wed, 01 Oct 2008 06:59:51 +0000 A very simplistic Document viewer.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 06:59:51 +0000] rev 238
A very simplistic Document viewer.
Wed, 01 Oct 2008 06:24:17 +0000 Implements a Site (Developer) generic Document editor form.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 06:24:17 +0000] rev 237
Implements a Site (Developer) generic Document editor form.
Wed, 01 Oct 2008 06:03:53 +0000 Changes to make breadcrumbs match page title. This is mostly to see how it
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 06:03:53 +0000] rev 236
Changes to make breadcrumbs match page title. This is mostly to see how it looks, since the new soc/logic/site/map.py code is going to implement the breadcrumbs and page title contents in a similar way.
Wed, 01 Oct 2008 05:17:15 +0000 Start using "Site" instead of "Developer" in the UI.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 05:17:15 +0000] rev 235
Start using "Site" instead of "Developer" in the UI.
Wed, 01 Oct 2008 05:15:29 +0000 Implement a Developer list view of all Documents.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 05:15:29 +0000] rev 234
Implement a Developer list view of all Documents. Patch by: Todd Larsen Review by: to-be-reviewed
Wed, 01 Oct 2008 05:10:41 +0000 Add missing all() __doc__ string comments: "Args:" and "Returns:" sections.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 05:10:41 +0000] rev 233
Add missing all() __doc__ string comments: "Args:" and "Returns:" sections.
Wed, 01 Oct 2008 05:02:42 +0000 Fix some style guide issues: keyword arguments are supposed to always be
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 05:02:42 +0000] rev 232
Fix some style guide issues: keyword arguments are supposed to always be supplied using the keyword argument name=value. http://code.google.com/p/soc/wiki/PythonStyleGuide#Default_Argument_Values
Wed, 01 Oct 2008 02:23:30 +0000 Directory for up-coming /site/docs/list and /site/docs/edit templates.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 02:23:30 +0000] rev 231
Directory for up-coming /site/docs/list and /site/docs/edit templates.
Wed, 01 Oct 2008 02:13:54 +0000 Fix typo in findNearestUsersOffset() __doc__ string missed in r661.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 02:13:54 +0000] rev 230
Fix typo in findNearestUsersOffset() __doc__ string missed in r661.
Wed, 01 Oct 2008 02:11:56 +0000 Show link to /site/user/list on /site/user/lookup when User is not found.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 02:11:56 +0000] rev 229
Show link to /site/user/list on /site/user/lookup when User is not found. http://code.google.com/p/soc/issues/detail?id=61 Patch by: Chen Lunpeng Review by: Todd Larsen (with modifications)
Wed, 01 Oct 2008 02:02:44 +0000 Add placeholder for future (to-be-implemented) getPreferredListPagination()
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 02:02:44 +0000] rev 228
Add placeholder for future (to-be-implemented) getPreferredListPagination() function.
Wed, 01 Oct 2008 00:53:36 +0000 Remove a TODO that should have been removed for r658.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:53:36 +0000] rev 227
Remove a TODO that should have been removed for r658.
Wed, 01 Oct 2008 00:51:49 +0000 Update some of the URL patterns to get their link_name parsing from the new
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:51:49 +0000] rev 226
Update some of the URL patterns to get their link_name parsing from the new patterns in key_name.py. (Using it like this in urls.py is why key_name.py needs to not depend on other modules...)
Wed, 01 Oct 2008 00:48:46 +0000 Add functions to soc/logic/document.py for dealing with partial_paths combined
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:48:46 +0000] rev 225
Add functions to soc/logic/document.py for dealing with partial_paths combined with link_names. Add getWorksForOffsetAndLimit() to query for Documents for the /site/docs/list view.
Wed, 01 Oct 2008 00:45:30 +0000 Hide PolyModel inheritance_line bookkeeping property from the User Profile
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:45:30 +0000] rev 224
Hide PolyModel inheritance_line bookkeeping property from the User Profile form.
Wed, 01 Oct 2008 00:43:07 +0000 Use the LINKNAME_PATTERN from its new home in key_name.py. Also, add some
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:43:07 +0000] rev 223
Use the LINKNAME_PATTERN from its new home in key_name.py. Also, add some missing blank lines that are required by the style guide.
Wed, 01 Oct 2008 00:41:18 +0000 Add lots of new functions to key_name.py, including path/link_name processing.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:41:18 +0000] rev 222
Add lots of new functions to key_name.py, including path/link_name processing. Copy various link_name related regex patterns to key_name.py and use them. Add error checking that raises a key_name.Error exception when name...() functions are given empty arguments. Hard-code class names, since they match what was typed into the module.class.__name__ to get the name anyway. This eliminates dependencies on any modules by key_name.py.
Wed, 01 Oct 2008 00:35:29 +0000 Add sidebar menu items for /site/docs/list and /site/docs/edit. They do not
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:35:29 +0000] rev 221
Add sidebar menu items for /site/docs/list and /site/docs/edit. They do not currently have view functions attached, but there are other links in the mock-up portion of the sidebar that don't currently work, either. The goal is to commit the /site/docs/list and /site/docs/edit changes in small bits that don't break anyone else.
Wed, 01 Oct 2008 00:33:43 +0000 Add partial_path property explicitly to the Work model.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:33:43 +0000] rev 220
Add partial_path property explicitly to the Work model.
Wed, 01 Oct 2008 00:25:31 +0000 Should have been part of the r650 commit.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:25:31 +0000] rev 219
Should have been part of the r650 commit.
Wed, 01 Oct 2008 00:23:32 +0000 Directory for upcoming /site/docs views.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 00:23:32 +0000] rev 218
Directory for upcoming /site/docs views.
Tue, 30 Sep 2008 17:03:51 +0000 Add "Last updated" footer to front page body text, using the modified Property
Todd Larsen <tlarsen@google.com> [Tue, 30 Sep 2008 17:03:51 +0000] rev 217
Add "Last updated" footer to front page body text, using the modified Property from the Work entity.
Tue, 30 Sep 2008 16:53:30 +0000 Change _readonly_field_as_table_row <td> tag class names to match those used in _field_as_table_row. That should actually go into previous commit.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 16:53:30 +0000] rev 216
Change _readonly_field_as_table_row <td> tag class names to match those used in _field_as_table_row. That should actually go into previous commit. Patch by: Pawel Solyga Review by: to-be-reviewed
Tue, 30 Sep 2008 16:49:54 +0000 Clean up too long lines in profile.py. Add ReadOnlyInput widget to custom_widgets module, it can be used to display read-only form fields. Display read-only "Id" field in LookUp view if user has been found and in User Edit Developer view.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 16:49:54 +0000] rev 215
Clean up too long lines in profile.py. Add ReadOnlyInput widget to custom_widgets module, it can be used to display read-only form fields. Display read-only "Id" field in LookUp view if user has been found and in User Edit Developer view. Patch by: Pawel Solyga Review by: to-be-reviewed
Tue, 30 Sep 2008 16:26:30 +0000 Add polymodel folder to DEFAULT_APP_DIRS variable in make_release.sh script.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 16:26:30 +0000] rev 214
Add polymodel folder to DEFAULT_APP_DIRS variable in make_release.sh script.
Tue, 30 Sep 2008 15:21:05 +0000 Add key naming function for Sponsor, School, Organization, Club key_names.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 15:21:05 +0000] rev 213
Add key naming function for Sponsor, School, Organization, Club key_names. Patch by: Pawel Solyga Review by: to-be-reviewed
Tue, 30 Sep 2008 14:00:11 +0000 Add org ReferenceProperty to Administrator model (many:1 relationship associating Administrators with specific Organization). Update Organization model __doc__ string with information about the back-reference 'admins'.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 14:00:11 +0000] rev 212
Add org ReferenceProperty to Administrator model (many:1 relationship associating Administrators with specific Organization). Update Organization model __doc__ string with information about the back-reference 'admins'. Patch by: Pawel Solyga Review by: to-be-reviewed
Tue, 30 Sep 2008 12:59:59 +0000 Made mce_settings class variable in TinyMCE widget a copy of default settings instead of reference.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 12:59:59 +0000] rev 211
Made mce_settings class variable in TinyMCE widget a copy of default settings instead of reference.
Tue, 30 Sep 2008 12:47:05 +0000 Replaced context.update call to simple value assignment in site.user.profile.create view function.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 30 Sep 2008 12:47:05 +0000] rev 210
Replaced context.update call to simple value assignment in site.user.profile.create view function.
Mon, 29 Sep 2008 17:22:31 +0000 Load ../../google_appengine/ into trunk/thirdparty/google_appengine.
Todd Larsen <tlarsen@google.com> [Mon, 29 Sep 2008 17:22:31 +0000] rev 209
Load ../../google_appengine/ into trunk/thirdparty/google_appengine.
Mon, 29 Sep 2008 15:46:42 +0000 Take advantage of the Model inheritance provided by polymodel.PolyModel to
Todd Larsen <tlarsen@google.com> [Mon, 29 Sep 2008 15:46:42 +0000] rev 208
Take advantage of the Model inheritance provided by polymodel.PolyModel to have Club, School, Sponsor, and Organization actually inherit from the Group Model class, rather than being composed via ReferenceProperties. Patch by: Todd Larsen Review by: Pawel Solyga, Sverre Rabbelier, Augie Fackler Review URL: http://codereviews.googleopensourceprograms.com/606
Mon, 29 Sep 2008 15:34:40 +0000 Take advantage of the Model inheritance provided by polymodel.PolyModel to
Todd Larsen <tlarsen@google.com> [Mon, 29 Sep 2008 15:34:40 +0000] rev 207
Take advantage of the Model inheritance provided by polymodel.PolyModel to have create a class hierarchy rooted at Person. Also, add some missing Role classes, such as Role, (Organization) Mentor, (Club) Member, (School) Student. Make (Organization) Administrator be a Reviewer like Mentor is. Patch by: Todd Larsen Review by: Pawel Solyga, Sverre Rabbelier, Augie Fackler Review URL: http://codereviews.googleopensourceprograms.com/607
Mon, 29 Sep 2008 15:31:50 +0000 Make use of PolyModel for Works, Documents, etc. Add some (but not all) of
Todd Larsen <tlarsen@google.com> [Mon, 29 Sep 2008 15:31:50 +0000] rev 206
Make use of PolyModel for Works, Documents, etc. Add some (but not all) of the missing Models related to Documents. Refactor site settings to be useful for any "/home" page view. Make the resulting home settings store a reference to the Document, rather than looking up the Document by a hard-code key name. This is to set the stage for Document editing being generic, and then being able to select from some existing documents which one to use as the "/home" static content. This makes it possible to pre-edit several Documents, have them Reviewed, and then quickly change the "/home" page content as a setting, rather than editing the Document in the settings form (though settings forms might still embed the current document into their form for convenience). Patch by: Todd Larsen Review by: Pawel Solyga Review URL: http://codereviews.googleopensourceprograms.com/1001
Mon, 29 Sep 2008 14:03:45 +0000 Fixed not working "Create New User" view which was caused by adding key_name into User Edit Developer view. This commit divides edit() view function in soc.views.site.user.profile into edit() and create() request handlers. New create() request handler is used only in "Create New User" view and has specific form validation functions and uses updateOrCreateUserFromId() instead of updateUserForKeyName().
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 29 Sep 2008 14:03:45 +0000] rev 205
Fixed not working "Create New User" view which was caused by adding key_name into User Edit Developer view. This commit divides edit() view function in soc.views.site.user.profile into edit() and create() request handlers. New create() request handler is used only in "Create New User" view and has specific form validation functions and uses updateOrCreateUserFromId() instead of updateUserForKeyName(). Patch by: Pawel Solyga Review by: to-be-reviewed
Fri, 26 Sep 2008 19:47:07 +0000 Add ModelWithFieldAttributes *before* PolyModel, so that everything does not
Todd Larsen <tlarsen@google.com> [Fri, 26 Sep 2008 19:47:07 +0000] rev 204
Add ModelWithFieldAttributes *before* PolyModel, so that everything does not become a "ModelWithFieldAttributes" in the Datastore. The way PolyModel works, each Model class hierarchy is stored in the Datastore as the class that directly inherited from PolyModel. So, we do not want to insert ModelWithFieldAttributes *after* PolyModel by inheriting *from* PolyModel, or everything would just be a ModelWithFieldAttributes in the Datastore, instead of Person, Work, Group, etc.
Fri, 26 Sep 2008 19:35:21 +0000 Add the third-party PolyModel class. This class supports inheritance in
Todd Larsen <tlarsen@google.com> [Fri, 26 Sep 2008 19:35:21 +0000] rev 203
Add the third-party PolyModel class. This class supports inheritance in Google App Engine Datastore Model classes.
Thu, 25 Sep 2008 17:17:11 +0000 A key_name controller module to collect all of the name...() functions that
Todd Larsen <tlarsen@google.com> [Thu, 25 Sep 2008 17:17:11 +0000] rev 202
A key_name controller module to collect all of the name...() functions that compose Model entity key names, plus some minor changes to other controller modules to illustrate the proposed use. Patch by: Todd Larsen Review by: Pawel Solyga Review URL: http://codereviews.googleopensourceprograms.com/804 Review URL: http://codereviews.googleopensourceprograms.com/804
Wed, 24 Sep 2008 21:23:42 +0000 Fixed missing urlparse import in request_helpers which cause /user/profile and /site/user/profile not to work at all. Removed not used module imports in response_helpers.py.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 24 Sep 2008 21:23:42 +0000] rev 201
Fixed missing urlparse import in request_helpers which cause /user/profile and /site/user/profile not to work at all. Removed not used module imports in response_helpers.py.
Wed, 24 Sep 2008 06:00:28 +0000 Replace mock-up of sidebar with first draft of dynamic sidebar functionality.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 06:00:28 +0000] rev 200
Replace mock-up of sidebar with first draft of dynamic sidebar functionality.
Wed, 24 Sep 2008 05:58:45 +0000 Minor tweaks to Site menu item names to make them more descriptive.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 05:58:45 +0000] rev 199
Minor tweaks to Site menu item names to make them more descriptive.
Wed, 24 Sep 2008 05:58:15 +0000 Major refactoring, to switch from using inheritance from soc.logic.menu classes
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 05:58:15 +0000] rev 198
Major refactoring, to switch from using inheritance from soc.logic.menu classes to an envelope-letter model instead.
Wed, 24 Sep 2008 05:17:44 +0000 Sidebar-building controller, with a TODO remaining to implement marking the
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 05:17:44 +0000] rev 197
Sidebar-building controller, with a TODO remaining to implement marking the current page as "selected".
Wed, 24 Sep 2008 02:46:52 +0000 Make views.helpers.html_menu MenuItem classes and logic.menu MenuItem classes
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:46:52 +0000] rev 196
Make views.helpers.html_menu MenuItem classes and logic.menu MenuItem classes more closely related. This is part of some refactoring in my working copy to keep soc/logic/site/sidebar.py from having to deal with html_menu classes (which is like having view code in the controller, which is bad).
Wed, 24 Sep 2008 02:36:47 +0000 Classes that wrap soc.logic.menu.Menu and soc.logic.menu.MenuItem to produce
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:36:47 +0000] rev 195
Classes that wrap soc.logic.menu.Menu and soc.logic.menu.MenuItem to produce HTML renderings of such lists.
Wed, 24 Sep 2008 02:27:01 +0000 Change indentation level to 2 (from 4) and rename MCE_DEF_SETTINGS to
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:27:01 +0000] rev 194
Change indentation level to 2 (from 4) and rename MCE_DEF_SETTINGS to DEF_MCE_SETTINGS to match the "default constant" naming convention elsewhere in the code.
Wed, 24 Sep 2008 02:24:49 +0000 Note 'groups' back-reference from 'founder' property in soc.models.group.Group.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:24:49 +0000] rev 193
Note 'groups' back-reference from 'founder' property in soc.models.group.Group.
Wed, 24 Sep 2008 02:23:32 +0000 Simple MenuItem and Menu classes for keeping track of ordered menus.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:23:32 +0000] rev 192
Simple MenuItem and Menu classes for keeping track of ordered menus.
(0) -100 -60 +60 +100 +300 +1000 tip