Todd Larsen <tlarsen@google.com> [Mon, 29 Sep 2008 15:34:40 +0000] rev 207
Take advantage of the Model inheritance provided by polymodel.PolyModel to
have create a class hierarchy rooted at Person.
Also, add some missing Role classes, such as Role, (Organization) Mentor,
(Club) Member, (School) Student. Make (Organization) Administrator be a
Reviewer like Mentor is.
Patch by: Todd Larsen
Review by: Pawel Solyga, Sverre Rabbelier, Augie Fackler
Review URL: http://codereviews.googleopensourceprograms.com/607
Todd Larsen <tlarsen@google.com> [Mon, 29 Sep 2008 15:31:50 +0000] rev 206
Make use of PolyModel for Works, Documents, etc. Add some (but not all) of
the missing Models related to Documents. Refactor site settings to be useful
for any "/home" page view. Make the resulting home settings store a reference
to the Document, rather than looking up the Document by a hard-code key name.
This is to set the stage for Document editing being generic, and then being
able to select from some existing documents which one to use as the "/home"
static content. This makes it possible to pre-edit several Documents, have
them Reviewed, and then quickly change the "/home" page content as a setting,
rather than editing the Document in the settings form (though settings forms
might still embed the current document into their form for convenience).
Patch by: Todd Larsen
Review by: Pawel Solyga
Review URL: http://codereviews.googleopensourceprograms.com/1001
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 29 Sep 2008 14:03:45 +0000] rev 205
Fixed not working "Create New User" view which was caused by adding key_name into User Edit Developer view. This commit divides edit() view function in soc.views.site.user.profile into edit() and create() request handlers. New create() request handler is used only in "Create New User" view and has specific form validation functions and uses updateOrCreateUserFromId() instead of updateUserForKeyName().
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 26 Sep 2008 19:47:07 +0000] rev 204
Add ModelWithFieldAttributes *before* PolyModel, so that everything does not
become a "ModelWithFieldAttributes" in the Datastore.
The way PolyModel works, each Model class hierarchy is stored in the Datastore
as the class that directly inherited from PolyModel. So, we do not want to
insert ModelWithFieldAttributes *after* PolyModel by inheriting *from*
PolyModel, or everything would just be a ModelWithFieldAttributes in the
Datastore, instead of Person, Work, Group, etc.
Todd Larsen <tlarsen@google.com> [Fri, 26 Sep 2008 19:35:21 +0000] rev 203
Add the third-party PolyModel class. This class supports inheritance in
Google App Engine Datastore Model classes.
Todd Larsen <tlarsen@google.com> [Thu, 25 Sep 2008 17:17:11 +0000] rev 202
A key_name controller module to collect all of the name...() functions that
compose Model entity key names, plus some minor changes to other controller
modules to illustrate the proposed use.
Patch by: Todd Larsen
Review by: Pawel Solyga
Review URL: http://codereviews.googleopensourceprograms.com/804
Review URL: http://codereviews.googleopensourceprograms.com/804
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 24 Sep 2008 21:23:42 +0000] rev 201
Fixed missing urlparse import in request_helpers which cause /user/profile and /site/user/profile not to work at all. Removed not used module imports in response_helpers.py.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 06:00:28 +0000] rev 200
Replace mock-up of sidebar with first draft of dynamic sidebar functionality.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 05:58:45 +0000] rev 199
Minor tweaks to Site menu item names to make them more descriptive.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 05:58:15 +0000] rev 198
Major refactoring, to switch from using inheritance from soc.logic.menu classes
to an envelope-letter model instead.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 05:17:44 +0000] rev 197
Sidebar-building controller, with a TODO remaining to implement marking the
current page as "selected".
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:46:52 +0000] rev 196
Make views.helpers.html_menu MenuItem classes and logic.menu MenuItem classes
more closely related. This is part of some refactoring in my working copy
to keep soc/logic/site/sidebar.py from having to deal with html_menu classes
(which is like having view code in the controller, which is bad).
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:36:47 +0000] rev 195
Classes that wrap soc.logic.menu.Menu and soc.logic.menu.MenuItem to produce
HTML renderings of such lists.
Todd Larsen <tlarsen@google.com> [Wed, 24 Sep 2008 02:27:01 +0000] rev 194
Change indentation level to 2 (from 4) and rename MCE_DEF_SETTINGS to
DEF_MCE_SETTINGS to match the "default constant" naming convention elsewhere
in the code.