Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 16:44:27 +0000] rev 627
Remove python-graph from thirdparty, remove check_includes script and graph folder from scripts. This functionality is (cyclic imports check) is supported by pylint automatically so we don't need that any more.
Patch by: Pawel Solyga
Review by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 16:39:18 +0000] rev 626
Fix too long lines in soc.views.models.request, remove unused imports and change pending requests list description. Remove unused imports from soc.logic.path_link_name module.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 16:36:17 +0000] rev 625
Add missing dots in soc.logic.lists module. Change method names to comply with Style Guide. Make class variable protected by adding "_" to the name of variable. Update lists templates respectively (methods name change).
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 16:32:23 +0000] rev 624
Remove unused imports in soc.views.models role, host and site modules. Add missing parameter in getDjangoURLPatters method.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 16:29:48 +0000] rev 623
Remove unused imports in soc.views.models.user and soc.views.models.sponsor modules.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 15:25:31 +0000] rev 622
Remove unused import in soc.models.task.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 30 Nov 2008 15:25:07 +0000] rev 621
Fix too long lines in soc.model.work.
Patch by: Pawel Solyga
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 29 Nov 2008 23:51:24 +0000] rev 620
Put the redirects in the views/helper/redirects.py module.
Changed the getCreateRequestRedirect to comply with the new signature. Also changed it's docstring to a more suitable one.
Fixed a useless merge in views/models/role.py in the process.
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 22:48:15 +0000] rev 619
Style fixes for previous commit
We also need to run pylint.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 29 Nov 2008 22:36:51 +0000] rev 618
Added invitation received message upon creating a new invite.
Moved the inviteAcceptedRedirect into the logic code. Added a TODO for further user notification upon creating a request.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 21:58:34 +0000] rev 617
Now invited users can create a new Host profile
Before the invited user had to be a developer for this to
work. Now, instead the default checkIsDeveloper check for
the 'edit Host', a custom checkIsInvite check is used.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 21:21:04 +0000] rev 616
Fixed requests not working anymore
We really need a test suite.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 21:04:09 +0000] rev 615
Fixed a bug in latest commit
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 19:45:19 +0000] rev 614
Moved getSidebarLinks to sitemap.sidebar
This is the fourth, and final patch, that attempts to
improve the cohesion in the base.View class.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 19:44:48 +0000] rev 613
Moved getDjangoURLPatterns to sitemap.sitemap
Third commit in a series that aims to improve the cohesion
in the base.View class.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 19:00:03 +0000] rev 612
Moved checkAccess and getCleanedFields into access and forms
A second patch in an effort to increase the cohesion in the
base.View class.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 18:30:58 +0000] rev 611
Move parameter construction into a seperate module
This is part of an effort to make base.py less bloated
and have it's methods be more cohesive.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 17:20:52 +0000] rev 610
Documented params usage in soc/views/models/base.py
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 29 Nov 2008 14:41:43 +0000] rev 609
Fixed AUTHORS to comply with the specified format
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 29 Nov 2008 13:44:02 +0000] rev 608
Added _onCreate _onUpdate and _onDelete methods to logic/models/base.py.
These methods can be overwritten by other logic/models/ modules to serve as a way to for instance send out an update message.
Patch by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 29 Nov 2008 11:26:04 +0000] rev 607
Fixed typo in docstring.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 00:12:47 +0000] rev 606
Make forms generic
Currently only Sponsor uses the new generic forms, as such this
makes the form code more complex. The other forms, however, can
be converted in a similar way, which will result in a lot of
code reduction.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 29 Nov 2008 00:12:16 +0000] rev 605
Made _logic a param
The _logic parameter is added in base.py to make this as small and
non-intrustive change.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 28 Nov 2008 23:08:14 +0000] rev 604
Added Lennard to the AUTHORS file
Long overdue patch, perhaps we should add a test to the test suite
to check if all authors are propertly credited in AUTHORS...
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 28 Nov 2008 22:49:26 +0000] rev 603
Make Sponsor use the new DynaForm module
Currently only a slight reduction in code, but hopefully some
(or all?) of the form's definition can move up into base.View.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 28 Nov 2008 22:49:03 +0000] rev 602
Added a DynaForm module
This allows GAE forms to be defined 'semi' dymamically, rather than
by having to explicitly create the new class.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 28 Nov 2008 22:48:41 +0000] rev 601
Added a cleaning module
This module is the start of a (hopefully more generic) set of
cleaning functions that can be used in the GAE forms.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 28 Nov 2008 08:24:57 +0000] rev 600
Apache license and __author__ added. Also added a todo for the __doc__ string.
Patch by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 27 Nov 2008 23:41:08 +0000] rev 599
Moved check_includes and graph from app to scripts
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 27 Nov 2008 23:40:30 +0000] rev 598
Change command parsing and do file walking manually
Also print warnings to stderr
Patch by: Sverre Rabbelier