Sun, 07 Dec 2008 17:01:44 +0000 Factor out sidebar entry construction
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 17:01:44 +0000] rev 704
Factor out sidebar entry construction This makes it possible to reuse this logic in other modules as well, preventing code duplication. While at it, move additional_sidebar merging before the other entries (additional entries should go first, since the other entries are mostly dev-only etc). Patch by: Sverre Rabbelier
Sun, 07 Dec 2008 15:29:37 +0000 Rename getSidebarLinks to getSidebarMenus
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 15:29:37 +0000] rev 703
Rename getSidebarLinks to getSidebarMenus Patch by: Sverre Rabbelier
Sun, 07 Dec 2008 15:29:10 +0000 Remove bogus scope from Site
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 15:29:10 +0000] rev 702
Remove bogus scope from Site This makes Site an unscoped entity (similar to how User and Sponsor do not have a scope). Patch by: Sverre Rabbelier
Sun, 07 Dec 2008 15:28:36 +0000 If an entity is unscoped, do not try to retrieve a scope
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 15:28:36 +0000] rev 701
If an entity is unscoped, do not try to retrieve a scope Patch by: Sverre Rabbelier
Sun, 07 Dec 2008 15:02:29 +0000 Dynamically add sidebar items for programs
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 15:02:29 +0000] rev 700
Dynamically add sidebar items for programs This adds sidebar items for programs as appropriate. From the docstring: A menu item is generated for each program that is currently running. The public page for each program is added as menu item, as well as all public documents for that program. Additionally, we allow access to a program's public page to everyone, even if the user is not logged in. Patch by: Sverre Rabbelier
Sun, 07 Dec 2008 15:02:03 +0000 Add and use a placeholder for checkIsDocumentPublic
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 15:02:03 +0000] rev 699
Add and use a placeholder for checkIsDocumentPublic We should somehow decide whether a document is publically viewable. This should of course be dependant on what the document is, e.g. the FAQ of a program should be allow(), whereas a student's application should be checkIsMentor(). Patch by: Sverre Rabbelier
Sun, 07 Dec 2008 15:01:31 +0000 Added a public redirect
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 15:01:31 +0000] rev 698
Added a public redirect Also some minor cleanups in the redirects code. Patch by: Sverre Rabbelier
Sun, 07 Dec 2008 13:49:22 +0000 Prepare for callbacks that return more than one menu
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 13:49:22 +0000] rev 697
Prepare for callbacks that return more than one menu This paves the way for callbacks that dynamically construct their menu based on in-db content, such as Programs and Documents. Patch by: Sverre Rabbelier
Sun, 07 Dec 2008 13:38:53 +0000 Make use of the 'sidebar' param for user_self
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 07 Dec 2008 13:38:53 +0000] rev 696
Make use of the 'sidebar' param for user_self Instead of overriding getSidebarLinks we use the sidebar param since user_self is now in it's own View. Patch by: Sverre Rabbelier
Sun, 07 Dec 2008 13:06:26 +0000 Fixed email adress in urls.py.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 07 Dec 2008 13:06:26 +0000] rev 695
Fixed email adress in urls.py. Patch by: Lennard de Rijk
Sun, 07 Dec 2008 12:41:28 +0000 Fixes 'module' object has no attribute 'handler500' and 404 on instances where debug is False.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 07 Dec 2008 12:41:28 +0000] rev 694
Fixes 'module' object has no attribute 'handler500' and 404 on instances where debug is False. Patch by: Lennard de Rijk
Sun, 07 Dec 2008 10:23:10 +0000 Fixed the header on the List Programs page.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 07 Dec 2008 10:23:10 +0000] rev 693
Fixed the header on the List Programs page. Patch by: Lennard de Rijk
Sat, 06 Dec 2008 22:34:25 +0000 Reset the RELEASE_TAG to None (unreleased) now that the 0.1a20081206 release candidate branch has been created.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 06 Dec 2008 22:34:25 +0000] rev 692
Reset the RELEASE_TAG to None (unreleased) now that the 0.1a20081206 release candidate branch has been created. Patch by: Pawel Solyga
Sat, 06 Dec 2008 22:18:21 +0000 Set RELEASE_TAG to 0.1a20081206rc for release candidate 06/12/2008.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 06 Dec 2008 22:18:21 +0000] rev 691
Set RELEASE_TAG to 0.1a20081206rc for release candidate 06/12/2008. Patch by: Pawel Solyga
Sat, 06 Dec 2008 21:32:36 +0000 Fix imports sorting in soc.views.models.organization.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 06 Dec 2008 21:32:36 +0000] rev 690
Fix imports sorting in soc.views.models.organization. Patch by: Pawel Solyga
Sat, 06 Dec 2008 21:27:47 +0000 Add missing dots in docstrings in modules.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 06 Dec 2008 21:27:47 +0000] rev 689
Add missing dots in docstrings in modules. Patch by: Pawel Solyga
Sat, 06 Dec 2008 21:05:17 +0000 Changed generic_name to group_label in models/program.py.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 06 Dec 2008 21:05:17 +0000] rev 688
Changed generic_name to group_label in models/program.py. Also I've updated the comments and help text to explain the meaning of this field. Patch by: Lennard de Rijk
Sat, 06 Dec 2008 19:25:01 +0000 Updated to the latest version of upload.py
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 19:25:01 +0000] rev 687
Updated to the latest version of upload.py Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 16:52:21 +0000 Load ../../google_appengine_1.1.7/ into
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 16:52:21 +0000] rev 686
Load ../../google_appengine_1.1.7/ into trunk/thirdparty/google_appengine.
Sat, 06 Dec 2008 14:50:45 +0000 Comment fixes for state in group and role model.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 06 Dec 2008 14:50:45 +0000] rev 685
Comment fixes for state in group and role model. Patch by: Lennard de Rijk
Sat, 06 Dec 2008 14:46:19 +0000 Fix for randomely ocurring bug
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 14:46:19 +0000] rev 684
Fix for randomely ocurring bug The bug and it's fix are described by the first comment from Guido in http://code.google.com/p/googleappengine/issues/detail?id=772. Patch by: Guido van Rossum
Sat, 06 Dec 2008 14:44:02 +0000 Changed state property for models/group.py to be optional as the description states.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 06 Dec 2008 14:44:02 +0000] rev 683
Changed state property for models/group.py to be optional as the description states. Patch by: Lennard de Rijk
Sat, 06 Dec 2008 14:25:24 +0000 Added organizations
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 14:25:24 +0000] rev 682
Added organizations Really basic for now, next stop is to have a proper document selector for the Presences. Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 14:24:50 +0000 Cleanups in group and program
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 14:24:50 +0000] rev 681
Cleanups in group and program The missing super call in group prevented the scope from being set as it should be. Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 14:24:26 +0000 Added a new create regexp in urls for just scope_path
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 14:24:26 +0000] rev 680
Added a new create regexp in urls for just scope_path Now that scope_path is properly defined we can add a url matching just the scope path. This allows some other custom create regexps to be removed/rewritten. Note: It needs to be -after- the full key_name regexp, since for arbitrarily nested scopes it would always match as just scope_path, even if there are other fields needed after the scope. Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 14:23:53 +0000 Introduce dynamic scope_path regexps
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 14:23:53 +0000] rev 679
Introduce dynamic scope_path regexps Instead of relying on scope_path's being "one slash deep", we should instead allow for either: 1. scope_paths that have a pre-defined depth 2. scope_paths that can be arbitrarily deep We achieve 1 by setting an entities scope_logic to another logic module. We then recursively call getScopeDepth until we get to the topmost entity (that is, an unscoped entity). A little different is the solution to 2, since some entities can have an arbitrarily deep scope (such as Documents), we need to have some way of signaling this to getScopePattern. A clean solution is to return None, rather than a number. If None is returned, the SCOPE_PATH_ARG_PATTERN is returned as regexp instead, which will match an arbitrarily deeply nested scope. The solution for 2 requires that we return None somewhere in the scope_logic chain, the most straight forward method to do so is to override getScopeDepth anywhere such a scope is needed and make it return None. A more elegant solution however, is to set the scope_logic to that module in all entities that require it. Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 14:23:25 +0000 Added a linkable logic module
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 14:23:25 +0000] rev 678
Added a linkable logic module The linkable logic module is used to signal the fact that the scope of an entity can be any linkable. Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 12:13:19 +0000 Fix scope lookup for unscoped entities
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 12:13:19 +0000] rev 677
Fix scope lookup for unscoped entities As scope_logic is now always set (since r1250), we need to check if it is None, rather than check if it exists. Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 12:12:58 +0000 Swap the order of request key fields
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 12:12:58 +0000] rev 676
Swap the order of request key fields This will make it easier to remove scope_path as explicit key field at some point by having it as inplicit key field for all entities. Patch by: Sverre Rabbelier
Sat, 06 Dec 2008 11:53:26 +0000 Use key().name() instead of link_id
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 06 Dec 2008 11:53:26 +0000] rev 675
Use key().name() instead of link_id This is now possible because key_name is constructed purely from the key fields of an entity. It is not sufficient to use just link_id, that works only for single-scoped entities (e.g., those that either do not have a scope, or that have a scope which itself does not have a scope). It would break if there was an entity that has a scoped scope (it would only include the scope's link_id in the url, which made it impossible to look up the scope as we missed the link_id of the scope's scope). Patch by: Sverre Rabbelier
(0) -300 -100 -50 -30 +30 +50 +100 +300 +1000 tip