Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 04:42:37 +0000] rev 277
Speed up average case by appending remainder of original choices list unchanged
(avoiding remaining str -> int type conversions) once the insertion point is
found.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 04:34:16 +0000] rev 276
Move helpers/html_menu.py to helper/html_menu.py, to clear out
soc/views/helpers for deletion.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 04:32:28 +0000] rev 275
A specialized SortedDict used by soc/logic/site/page.py.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 23:59:49 +0000] rev 274
Move helpers/forms_helpers.py to helper/forms.py.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 23:24:12 +0000] rev 273
Move helpers/templatetags to helper/templatetags.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 23:17:49 +0000] rev 272
Move helpers/response_helpers.py to helper/responses.py.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 23:08:28 +0000] rev 271
Replace helpers/custom_widgets.py with helper/widgets.py.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 23:01:49 +0000] rev 270
Move helpers/template_helpers.py to helper/templates.py.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 22:17:05 +0000] rev 269
Move helpers/request.py to helper/requests.py to avoid conflict with common
local variable name "request".
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 22:09:32 +0000] rev 268
Move helpers/list.py to helper/lists.py to avoid conflict with built-in type
name "list".
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 21:59:32 +0000] rev 267
Replace soc/views/helpers/request_helpers with soc/views/helpers/request.py
and replace uses of request_helpers. with helpers.request. instead.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 21:41:12 +0000] rev 266
Move soc/views/helpers/list_helpers.py to soc/views/helpers/list.py and change
uses from list_helpers. to helpers.list. instead.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 17:21:41 +0000] rev 265
List views should have a selectable pagination "page" length:
http://code.google.com/p/soc/issues/detail?id=59
Patch by: Chen Lunpeng and Todd Larsen
Review by: Augie Fackler
Review URL: http://codereviews.googleopensourceprograms.com/1201
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 07:03:11 +0000] rev 264
Change to imports to follow the style guide:
http://code.google.com/p/soc/wiki/PythonStyleGuide#Module_and_package_imports
Specifically:
"Use from x import y only when x is a package and y is a module."
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 01:32:34 +0000] rev 263
Make findNearestUsers() code in soc/logic/site/id_user.py more generic and
move it to soc/logic/model.py. Orginal findNearest...() functions in
id_user.py are now convenience wrappers.
Add typed-query string construction functions to model.py.
Move getFulLClassName() from key_name.py model.py, since it has more to do
with Model types than key names.
Swap 'offset' and 'limit' and make 'limit' arguments non-optional. Also,
stop adding 1 inside the ...ForLimitAndOffset() functions and make the
callers do it (since it was being added for a very UI-specific reason of
whether or not to display a "Next>" link).
Patch by: Todd Larsen
Review by: Pawel Solyga
Review URL: http://codereviews.googleopensourceprograms.com/1401
Todd Larsen <tlarsen@google.com> [Thu, 02 Oct 2008 20:22:15 +0000] rev 262
Factor out an isIdAvailable() function from EditForm.clean_id() in
soc/views/site/user/profile.py and add it to soc/logic/site/id_user.py.
Addresses some comments on r614.
Patch by: Todd Larsen
Review by: Pawel Solyga
Review URL: http://codereviews.googleopensourceprograms.com/1202
Todd Larsen <tlarsen@google.com> [Thu, 02 Oct 2008 15:37:18 +0000] rev 261
Add Allen (Chen Lunpeng) to trunk/AUTHORS, due to his several recent patches.
Todd Larsen <tlarsen@google.com> [Thu, 02 Oct 2008 15:36:08 +0000] rev 260
Fix typo in recent validate.py changes (r682).
Patch by: Chen Lunpeng
Review by: Todd Larsen
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 22:19:22 +0000] rev 259
Add basic Sponsors List, Create New Sponsor, Sponsor Public Profile views. Change all properties in Group model as required for now. Remaining TODO: write validation functions for Sponsor edit and create form fields that need additional validation (like address, phone number format).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 22:12:26 +0000] rev 258
Add Sponsor logic functions.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 22:10:52 +0000] rev 257
Add group templates that can be used by Sponsor, Organization, School, Club views. Right now only upcoming commit of Sponsor views is using it.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 22:02:50 +0000] rev 256
Remove excluded field inheritance_line, since the User model does not inherit
from PolyModel (at this time).
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 21:58:31 +0000] rev 255
Add colon at the of _readonly_field_as_table_row template tag label parameter. Replace hardcoded labels in User Public profile template with linkname_user.fields.<field_name>.label values.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 21:53:52 +0000] rev 254
Fix missing blank line to follow PythonStyleGuide in model.py.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 21:21:03 +0000] rev 253
Add links in sidebar for upcoming Sponsor views.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 21:19:32 +0000] rev 252
Change key_name module usage to path_linkname module (fix to previous commit). Add comments about urls. Add Sponsor views urls for upcoming Sponsor views modules.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 20:52:39 +0000] rev 251
Move path and link_name related functions and regex patterns to a new
soc/logic/path_linkname.py module, and fix all dependencies. path/link_name
functionality is becoming the generic way to identify entities in the Datastore
in a URL-compatible way.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 20:48:58 +0000] rev 250
Make form field components use a smaller font, without shrinking the font
of all text in the page body.