Remove Great Britain from country list. Great Britain was included as a country, although it has a country code (.gb) it's not a state. United Kingdom is correct and remains in the list. Patch by: Matthew Wilkes Review by: Pawel Solyga

Added programs Currently the programs are somewhat of empty, but due to the ease with which we can add new fields later, it is acceptable to commit it in it's current form. Patch by: Sverre Rabbelier

Allow for extra dynamic fields for the create form Also some minor cleanups, such as making base.Logic inherit from object, as per the style guide. Patch by: Sverre Rabbelier

Fixed a styling error. Patch by: Lennard de Rijk

Added User welcome message. Added templates/soc/mail/welcome.html as a template for the message. Also fixed a cyclic import that was about to happen in notifications.py.

Some docstring fixes in few modules (soc.views.helper soc.views.models.base). Patch by: Pawel Solyga

Add missing dot and correctly sort imports in soc.logic.helper.notifications module. Patch by: Pawel Solyga

Some docstring and missing blank lines fixes in soc.views.sitemap modules. Patch by: Pawel Solyga

Sponsor name now shows in List Hosts. Patch by: Lennard de Rijk

Moved sendInviteMessage to a new module in logic/helper/notifications.py. Renamed sendInviteMessage to sendInviteNotification. Removed the now obsolete imports in logic/models/request.py. This has been done to keep the models/logic modules clean.

Changed email address in logic/models/base.py. Patch by: Lennard de Rijk

Allow developers access to anything that does a checkIsInvited. Patch by: Lennard de Rijk

Remove unused imports from some modules. Patch by: Pawel Solyga

Fix typo and too long lines in soc.logic.models.request module. Patch by: Pawel Solyga

Add missing import, remove unused import and add missing parameters to methods in soc.views.models.user_self module. Patch by: Pawel Solyga

Add missing dots and fix too long line in soc.views.helper.dynaform module. Remove unused imports in soc.views.models.document module. Fix too long lines. Add missing docstring for Meta classes. Patch by: Pawel Solyga

Add module docstring and license for soc, soc.models, soc.views.helper.templatetags. Patch by: Pawel Solyga

Remove python-graph from thirdparty, remove check_includes script and graph folder from scripts. This functionality is (cyclic imports check) is supported by pylint automatically so we don't need that any more. Patch by: Pawel Solyga Review by: Sverre Rabbelier

Fix too long lines in soc.views.models.request, remove unused imports and change pending requests list description. Remove unused imports from soc.logic.path_link_name module. Patch by: Pawel Solyga

Add missing dots in soc.logic.lists module. Change method names to comply with Style Guide. Make class variable protected by adding "_" to the name of variable. Update lists templates respectively (methods name change). Patch by: Pawel Solyga

Remove unused imports in soc.views.models role, host and site modules. Add missing parameter in getDjangoURLPatters method. Patch by: Pawel Solyga

Remove unused imports in soc.views.models.user and soc.views.models.sponsor modules. Patch by: Pawel Solyga

Remove unused import in soc.models.task. Patch by: Pawel Solyga

Fix too long lines in soc.model.work. Patch by: Pawel Solyga

Put the redirects in the views/helper/redirects.py module. Changed the getCreateRequestRedirect to comply with the new signature. Also changed it's docstring to a more suitable one. Fixed a useless merge in views/models/role.py in the process.

Style fixes for previous commit We also need to run pylint. Patch by: Sverre Rabbelier

Added invitation received message upon creating a new invite. Moved the inviteAcceptedRedirect into the logic code. Added a TODO for further user notification upon creating a request. Patch by: Lennard de Rijk

Now invited users can create a new Host profile Before the invited user had to be a developer for this to work. Now, instead the default checkIsDeveloper check for the 'edit Host', a custom checkIsInvite check is used. Patch by: Sverre Rabbelier

Fixed requests not working anymore We really need a test suite. Patch by: Sverre Rabbelier

Fixed a bug in latest commit Patch by: Sverre Rabbelier

Moved getSidebarLinks to sitemap.sidebar This is the fourth, and final patch, that attempts to improve the cohesion in the base.View class. Patch by: Sverre Rabbelier

Moved getDjangoURLPatterns to sitemap.sitemap Third commit in a series that aims to improve the cohesion in the base.View class. Patch by: Sverre Rabbelier

Moved checkAccess and getCleanedFields into access and forms A second patch in an effort to increase the cohesion in the base.View class. Patch by: Sverre Rabbelier

Move parameter construction into a seperate module This is part of an effort to make base.py less bloated and have it's methods be more cohesive. Patch by: Sverre Rabbelier

Documented params usage in soc/views/models/base.py Patch by: Sverre Rabbelier

Fixed AUTHORS to comply with the specified format Patch by: Lennard de Rijk

Added _onCreate _onUpdate and _onDelete methods to logic/models/base.py. These methods can be overwritten by other logic/models/ modules to serve as a way to for instance send out an update message. Patch by: Lennard de Rijk

Fixed typo in docstring. Patch by: Lennard de Rijk

Make forms generic Currently only Sponsor uses the new generic forms, as such this makes the form code more complex. The other forms, however, can be converted in a similar way, which will result in a lot of code reduction. Patch by: Sverre Rabbelier

Made _logic a param The _logic parameter is added in base.py to make this as small and non-intrustive change. Patch by: Sverre Rabbelier

Added Lennard to the AUTHORS file Long overdue patch, perhaps we should add a test to the test suite to check if all authors are propertly credited in AUTHORS... Patch by: Sverre Rabbelier

Make Sponsor use the new DynaForm module Currently only a slight reduction in code, but hopefully some (or all?) of the form's definition can move up into base.View. Patch by: Sverre Rabbelier

Added a DynaForm module This allows GAE forms to be defined 'semi' dymamically, rather than by having to explicitly create the new class. Patch by: Sverre Rabbelier

Added a cleaning module This module is the start of a (hopefully more generic) set of cleaning functions that can be used in the GAE forms. Patch by: Sverre Rabbelier

Apache license and __author__ added. Also added a todo for the __doc__ string. Patch by: Lennard de Rijk

Moved check_includes and graph from app to scripts Patch by: Sverre Rabbelier

Change command parsing and do file walking manually Also print warnings to stderr Patch by: Sverre Rabbelier

Proper working implementation of a cycle detection algorithm, that returns the cycles (rather than printing them) by constructing the path between the two nodes that were found to be cyclic. Patch by: Sverre Rabbelier

Fix some typo in logic.models.base. Patch by: Pawel Solyga

Added rudementry include checker Patch by: Sverre Rabbelier

Added the python-graph module http://code.google.com/p/python-graph/ Patch by: Sverre Rabbelier

Removed cruft from the tests directory The current tests were outdated (they tested code that no longer exists), and were causing the test suite (insofar as it deserves that name) to fail for no reason. Patch by: Sverre Rabbelier

Fixed an outstanding TODO for tlarsen A nice side-effect is that accounts now does not depend on out_of_band, sadly that does not fix the cyclic dependency, but it is a nice side-effect nonetheless.

Lists now use plural_name instead of name in the description. Patch by: Lennard de Rijk

Created a seperate module for editSelf things This improves the coherency in the user module, while at the same time making it easier to set proper access control for the editSelf related pages. Patch by: Sverre Rabbelier

Fixes empty spaces appearing in the menu if a person is not allowed to see this menu or if no menu is defined. Patch by: Lennard de Rijk

Fixes an error that occurs when moving the document by setting another link ID or Scope path. This is due to the fact that author is a required property in the Work model. Patch by: Lennard de Rijk

Fixed some access related bugs These were not obvious previously, but with the sidebar not showing up when one does not have access, they stood out.

Make the sidebar dynamic depending on the user's rights This is done by doing the usual access checks that are also called when the user actually visits the page.

Have the sidebar be rebuilt on every request with callbacks This makes is possible for the sidebar constructing to take into account the current users privilidges etc.

Adds and uses a modified_by property in models/work.py This property is used to display the user who last edited the work in the document viewer. Fixes author being set on every edit. Also edited the style-sheet to fix issue i128. Patch by: Lennard de Rijk

Fills in the Founded By box in edit sponsor with the user's public name Fixes Founded By being overwritten on edit by another user. Patch by: Lennard de Rijk

Set trunk RELEASE_TAG back to None after creation of 0.0a20081123rc release candidate branch. Patch by: Todd Larsen

Attempt number two at a release process, with correct usage of /tags/ this time around. Patch by: Todd Larsen

Reset the RELEASE_TAG to None (unreleased) now that the 0.0a20081123 release tag has been created. Add some release instructions to the soc/release.py __doc__ string. Patch by: Todd Larsen

Display '(unreleased)' as a link to trunk/ when RELEASE_TAG is false. Patch by: Todd Larsen

Add release tag string, Melange "badge" image, and Google App Engine version to base.html template. Patch by: Todd Larsen

Provide a simple method in the Role Model class that aliases the existing 'display_name' Property to 'name'. Patch by: Todd Larsen

Fixed spurious 'Invite Host' button in 'create host' Patch by: Sverre Rabbelier

Fix Host invites This fixes the UI for Host invites by hiding the fields that are not used, and by auto-filling in the user and scope fields based on link_id and scope_path.

Fixed pages for missing home page (document) links Patch by: Sverre Rabbelier

Moved the custom error.html page for Site to it's proper place Also made the error template a proper parameter instead of re-using the edit/public template.

Made list pagination part of Lists This way the pagination for one list does not affect the pagination of a another one. Patch by: Sverre Rabbelier

Remove polymodel module from repository. Patch by: Pawel Solyga, Sverre Rabbelier

Remove polymodel folder from DEFAULT_APP_DIRS variable in make_release script. Patch by: Pawel Solyga, Sverre Rabbelier

Remove inheritance_line from Form meta class excludes in all currently used forms. Patch by: Pawel Solyga, Sverre Rabbelier

Remove inheritance from PolyModel in Answer and Linkable model. Replace PolyModel inheritance with base.ModelWithFieldAttributes. A little explanation why we are trying to get rid of PolyModel. We decided to use PolyModel in order to get support for model inheritance in App Engine, however as we know this was a hacky workaround which added inheritance_line property to each model. Recent commits which added Linkable model caused our data viewer in admin console to show only one model "Linkable" since all of the classes inherited from it. Basically datastore viewer was useless plus we had a really big mess in datastore since everything was of one kind (Linkable). It's almost like creating one huge table in SQL database. Upcoming commits will eliminate all usage of PolyModel and finally remove PolyModel from our repository. We are still using inheritance however this doesn't modify how models are saved in data store so basically it's like copy and paste of properties from parent models. Patch by: Pawel Solyga, Sverre Rabbelier

Add customized User Edit Developer view template with working listing of former accounts. Patch by: Pawel Solyga

Disabled 'Home Settings' menu until we have a use for it Also fixed a typo in the request row template that caused it to display the wrong value. Patch by: Sverre Rabbelier

Removed no-longer used code This code is no longer in use and has been replaced by getForFields and similar methods.

Hide the 'home' field until we have a proper document selector Rather than having a confusing 'home' field that lists all Linkables (in other words, everything in the database), we're better off hiding it for now.

Fixed redirects to work consistently Revision 1133 broke 'Edit Site Settings' by relying on the fact that the url for create pages is '<entity>/create', which it is not for 'Edit Site Settings'.

Made Request use the new link_id and scope_path This cleans a lot of weird user interface badness and demonstrates how Linkable can be used.

Added a requests overview using the new multi-list page. Renamed the roles page to Requests Overview. Patch by: Lennard de Rijk

Requests are almost working now You can accept a request by clicking on it in the roles view. Patch by: Sverre Rabbelier

Fix names of methods in soc.views.model.site. Patch by: Pawel Solyga

Fix wrong comment format in request.py. Patch by: Pawel Solyga

Added missing import Patch by: Lennard de Rijk

Refactor requestSelf to be make use of the new split Patch by: Sverre Rabbelier

Split the list view code up in three pieces 1. getListContents which returns the required contents dictionary 2. _list which returns the response for a specified list of contents 3. list which constructs just one content dict and passes it to _list This way it is easier to do step 1 and 2 in other code than list(), which makes it possible to display multiple list pages (by calling getListContents multiple times and passing the result to _list).

Renamed templates/soc/entity/list/entity_*.html to *.html This makes it possible to generalize list template positions. Patch by: Sverre Rabbelier

Make redirect generic using the new Lists object This makes it possible (and easier) to have the list view redirect to any page specially tailored to the current item. Patch by: Sverre Rabbelier

Fixed the description on the user's role page. This broke in r1111. The new lists also removed the need for instruction_text in models/base.py. Removed an obsolete assignment in models/request.py Patch by: Lennard de Rijk

Define a default for rights['public'] in views/models/base.py. Alter rights in views/models/site.py to allow anyone, even signed-out users, to view the site home page. Patch by: Todd Larsen

Hide the 'scope' property from forms for now, since this is really supposed to be set by "Role context" as determined by logic code in the controller. Patch by: Todd Larsen

Fix some broken help_text bubbles (they are truncated or not displayed if they contain " double quotation marks). Add notice text (sort of ugly at the moment, Dmitri? :) explaining the "Public name" and "Link ID" fields in great detail. This patch is in preparation for making "Link ID" immutable for Users in a subsequent patch. Patch by: Todd Larsen

Fix for 404 occuring when signing out during the creation of, for example, a new Document. This patch makes sure that the request.path is not altered when requesting the create page (alteration of which caused the 404). This also results in the seeds now being remembered when being forced to log in. The editPost method now correctly switches to the edit path after a successful edit. Patch by: Lennard de Rijk

Fixed former_accounts detection by supplying the missing error message. Patch by: Todd Larsen

Rename the User.public_name Property to simply 'name' (but leave the verbose name as "Public name"). This is to take advantage of standardizing on 'name' in the common edit template (and possibly other common templates). The Property was renamed because public_name was already a "name", unlike the recent change to the Work Model class, where 'title' was "aliases" using a tiny name() method instead. Patch by: Todd Larsen

Include name of entity in the text of the link to the read-only public view present in the common edit template. Provide a simple method in the Work Model class that aliases the existing 'title' Property to 'name'. Patch by: Todd Larsen

Fix broken Site settings form by uncommenting code that was inadvertently committed commented out. Patch by: Todd Larsen

Merge soc/logic/out_of_band.py into soc/views/out_of_band.py. Merge errorResponse() and requestLogin() from soc/views/simple.py into out_of_band.Error and out_of_band.LoginRequest exception classes, respectively. Remove no-longer-used soc/logic/out_of_band.py and soc/views/simple.py. Fix some problems where usage of out_of_band was broken. Patch by: Todd Larsen

Remove redundant dicts for URL patterns and sidebar menu text, and use the existing params dict instead. Add a sidebar_heading customization to params. Better differentiate the 'User (self)' and 'Users' sidebar menus. Remove the redundant Site settings menu items now that the Site entity is a singleton. Patch by: Todd Larsen

By default, exclude files that are likely to be binary files. Patch by: Todd Larsen

Add User.public_name help text, per discussions on melange-soc-dev. Patch by: Todd Larsen

Allow for multiple list objects At the moment there's not really a practical use for it, since there is no way to make soc.views.models.base.View.list() show more than one list, but it shouldn't be too hard to allow for that. Patch by: Sverre Rabbelier

Make it more obvious that a format string constant is a format string by appending _FMT. Patch by: Todd Larsen

Fix getKeyValues() method footprint mismatches in soc.logic.models.site.Logic after the recent refactoring. Remove 'Link scope' drop-down from Edit Site Settings form. Patch by: Todd Larsen

Add a page name for 'Edit Main Site Settings'

Refactor classes in soc/logic/models to make more use of inheritance. Add some missing classes, such as soc.logic.models.group.Logic, so that key name similarities between various Groups can be exploited via inheritance instead of repetition of code. Patch by: Todd Larsen

Replace HomeSettings with Presence Model class. Replace SiteSettings with Site Model class. Derive Group Model class from Presence, adding the "home page settings" properties in a Melange site presence to every Group. Patch by: Todd Larsen

Move LINK_ID and SCOPE_PATH regular expressions to soc/models/linkable.py. Fix some too-long lines. Change key names back to type:scope_path/link_id (instead of type:scope_path:link_id). Some minor __doc__ string updates. Patch by: Todd Larsen

Removed unnecesary lines according to comment on r1067 Patch by: Lennard de Rijk

Make editSelf() work by adding 'inheritance_line' to the list of excluded fields in the UserForm. Also, fix a few too-long lines and add some missing parentheses (the style guide says do not rely on operator precedence). Patch by: Todd Larsen

Remove imports of the soc.logic.key_name module, since it was deleted by r1071 (and wasn't referenced in these modules anyway). Patch by: Todd Larsen

Replace nick_name and its variants with public_name. Remove the soc/templates/soc/person/edit.html template, since it does not appear to be referenced anywhere (and contained a nick_name reference that would otherwise need to be remedied). Patch by: Todd Larsen

Some indention and too long lines fixes in soc.views.models. Patch by: Pawel Solyga

Delete some more not needed directories this time in soc/logic and soc/templates. Patch by: Pawel Solyga

Remove not needed directories in soc/views. Patch by: Pawel Solyga

Created a checkIsInvited method Patch by: Sverre Rabbelier

Small comment fix in Linkable model. Patch by: Pawel Solyga

Removed one more unneccesary module Last commit reminded me that this one is obsolete too.

OK, this one file was missing from r1061 for some reason. Patch by: Todd Larsen

Minor improvements to roles page Mainly not hard-coding the page name and showing all requests that are _accepted_, instead of the one's that aren't yet.

Split a too long line

Adds the user's role page. Currently this only has an overview of the user's unhandled requests. Patch by: Lennard de Rijk

Changes the list template to use an instruction_text property that sets the text above the list. This makes the create_invite template unneeded. The instruction_text comes in handy when defining special lists. Patch by: Lennard de Rijk

Deleted unused files and files

The list method in models/base.py can now use a filter to make a selection of entities to show. Patch by: Lennard de Rijk

Moved the last remnant of soc.views.user.profile to soc.views.models Sadly, it is non-trivial to port this code to be generic enough to work with soc.views.models.base.edit. On the other hand, this will make customizing the editSelf code a lot easier.

Move saved message to the base class This removes some duplicate code that was in all the child classes of soc.views.models.base.View.

Rename partial_path to scope_path, ignoring case, etc. (Similar to the recent link_name => link_id change). Also, fix two missed "Linkname" column headers in some templates. Patch by: Todd Larsen

Rename link_name to link_id everywhere, regardless of case (so LINK_NAME becomes LINK_ID, "link name" becomes "link id", etc.). Also, rename LINKNAME to LINK_ID. Patch by: Todd Larsen

Ignore "dot" directories like .hg and .svn by default. Patch by: Todd Larsen

id() is a built-in function in Python, so rename the property to link_id. Add a scope_path StringProperty to cache the string representation of the transitive closure of the nested scopes of an entity. Patch by: Todd Larsen

Adds the rights['edit'] to models/base.py wich was left out in r1049. Fixes two small typos in the comments in logic/mail_dispatcher.py

Add a access.deny and access.allow method Respectively always deny, and always allow access to view a part of the site.

Fold the _rights dictionary into params

Fix bug where script fails when it encounters a socket (which is not a regular file). Fix bug where exception is raised if error occurred before parser object was returned from _buildParser(). Add a --notext option, so that just the file paths will be output on matches (both find and find/replace); useful with xargs. Patch by: Todd Larsen

Fix user key stuff Key field for user is now link_name, instead of account, as such the method's used by 'create new user' should be updated.

Fix not working request creation. Patch by: Pawel Solyga

Derive Linkable Model class from PolyModel. Patch by: Todd Larsen

Add new parameters to views: url_name which is name used in urls (instead of using lower entity names) and module_name which is used for constructing django urls. Append changes to all affected files. Fix some title names. Change urls that included underscores like "site_settings" into urls with slash "site/settings". Plus some other minor fixes. Patch by: Pawel Solyga

Fix not working feed display for home settings public view. Modify blog javascript so that we can define how many feed entries we want to display. Change default number of entries to 3 as suggested by Leslie and Chris. Patch by: Pawel Solyga

Replace old page parameter doc string description with new one for page_name. Patch by: Pawel Solyga

Fix missing dots in doc strings and some other doc string corrections. Patch by: Pawel Solyga

Remove empty docs folder in soc/views. Patch by: Pawel Solyga

Added a default _editSeed method Also added the invite shortcut in the host view.

Temporary fix for creating a new user account This should probably be solved more elegantly, but edit_self is going to be used soon.

Added basic 'invite' functionality Currently the invite can only be created, existing ones can be listed and edited, or deleted if desired.

Refactored SiteMap to be generic With this mechanism (in combination with the new sidebar) in place adding a new entity to the site becomes very easy, rather than having to add a lot of code to 'map.py', one can simply register with the sitemap modules.

Refactor the sidebar to use Django templates With this change the html for the sidebar is no longer generated by Melange, instead it's delegated to Django (which is what it does best anyway). The downside is that it is no longer possible to have arbitrary deeply nested menu's.

Fixed redirection after creation to Just Work Accomplished by generating a link to the creation page instead of trying to deduct it from the current path.

Improved public page link text Instead of putting the name of the entity in the link text to the public page, a way better solution is to put static text there.

Allow pre-seeding a create form With this feature the Site Settings create form can be pre-seeded with it's "magic values", which allows those fields to be hidden from the user. At the same time, it allows 'Edit Main Site Settings' to either create or edit the Main Site Settings.

Fixed typo in soc.views.models.host redirects

Restored default Sponsor edit view

Fixed a typo in soc.logic.models.base

Added a filter method to dicts

Change id to account in base.html template (without this change we couldn't signout using top right links and also couldn't display currently logged in account information on the left side of links). This patch is related to commit in revision r1022. http://code.google.com/p/soc/source/detail?r=1022 Patch by: Pawel Solyga

Add an e-mail dispatcher that can be used to send messages via the website. Add base and invitation templates that can be used with email dispatcher to send invitation emails. Please read the module doc string for more information how to use it. Patch by: Lennard de Rijk, Pawel Solyga

Fix broken User link_name validations. Changes in r1014 still caused some problems so I came out with new idea to compare User accounts (previously called "id"). Patch by: Pawel Solyga

Factor out direct use of the page object Instead of directly using the page object in the html, pass around page_name. This will make it easier to remove Page in favor of a simpler implementation.

Attempt to rename User.id to User.account, in preparation for making User be derived from Linkable, which will have a property named 'id'. Patch by: Todd Larsen

For those times when sed isn't enough, but awk is too much, there's munge.py... Patch by: Todd Larsen

Make sure the user edit form has the complete mail adress in the user account field when opened. Replace confusing id field in form with email field. Editing the email adress of an existing user will still result in an error but that should be fixed soon. Patch by: Lennard de Rijk Review by: Pawel Solyga

upload.py (customized for use with codereviews.googleopensourceprograms.com) updated from latest Rietveld release. Patch by: Todd Larsen

Moved from docs -> document

Fixed typo in docstring

Copy the link_name regex patterns into linkable.py, in preparation for removing them from path_link_name.py (eventually). Patch by: Todd Larsen

Move all the properties from Person model to Role model. Update all the comments and docs according to the changes. Remove Person model. Patch by: Pawel Solyga

Fix broken User link name (it was possible to change link name to one that was already used, validation was not working correctly). Patch by: Pawel Solyga

Move "(required)" text to third column instead of second column in templatetags, it's much more user friendly that way. Add new version of as_table that support our current error messages format, information about required fields and tooltips. Patch by: Pawel Solyga

Remove stop parameter from home_settings and site_settings views. This is something Sverre didn't mean to commit :-) Add missing params description to the models Base class docs. Patch by: Pawel Solyga

In soc.views.models.user module fix too long line. Delete unused email variable, add missing doc and rename self method and global variable to editSelf and edit_self so it's not confused with "self" used in classes and there is no outerscope variable name overwriting anymore. Patch by: Pawel Solyga

Some name changes in soc.logic.site.map module for User self edit view. Patch by: Pawel Solyga

Fix typo in linkable model and add some missing comments. Patch by: Pawel Solyga

Initial thoughts on a Linkable Model class. Please comment. Patch by: Todd Larsen

Fix names typos in home_settings and site_settings modules. Patch by: Pawel Solyga

Change Google Maps property name from gm_api_key to gmaps_api_key. Patch by: Pawel Solyga

Change partial path and link name verbose names in home_settings.py. Some comments fixes in site_settings.py. Patch by: Pawel Solyga

Add jquery folder to make_release.sh script to fix not working jquery on deployed app. Patch by: Pawel Solyga

Adds a check to logic/valididate.py that checks the partial path format using a regexp. This regexp has been added to logic/path_link_name.py, therefore changing PATH_LINKNAME_REGEX to use the PARTIAL_PATH in building this regexp. Plus views/models/docs.py now uses the validation functions in the clean_ methods. Patch by: Lennard de Rijk Review by: Pawel Solyga

Partially use the new user code The 'edit self' is not working fully yet, the 'lookup' code is not working at all, as such, only 'create', 'edit', 'list', and 'delete' make use of the generic code.

Added a generic user page

Preparation for generic user views Added a getSuffixValues method that is meant to allow for having a non-public field as key_name. Also added support for a key-name field being embeded in the form so that if the key-fields change the old key_name is not lost.

Added support for providing a custom params dict This has been a long outstanding feature request for tlarsen, luckily it turned out to be very easy to implement with the dict.merge utility method. To have custom _rights one should instead to the required access checks before calling the view method.

Fixed a typo in id_user

Fix create redirect

Added support for providing a custom params dict This has been a long outstanding feature request for tlarsen, luckily it turned out to be very easy to implement with the dict.merge utility method. To have custom _rights one should instead to the required access checks before calling the view method.

Minor fix to sponsor missing from the site restructure

Add a Google Maps property to Site Settings Patch by: Lennard de Rijk <ljvderijk@gmail.com> Reviewed by: Sverre Rabbelier

Fixes to {Site,Home}Settings Also improved help text on HomeSettings partial_path and link_name.

Fixing the string for the default home page

Making the docs template prettier

Allowing + and - to be clicked in the menu

Fix not working former_ids. Add support for "Invalid accounts". Now when id from former_ids tries to create a profile "This account is invalid." error message is displayed. Compare emails in lower cases to prevent changing User email to the same email with different character casing (needs some more testing). Patch by: Pawel Solyga

Some indention fixes and remove not needed variable in soc.logic.models.base module. Patch by: Pawel Solyga

Refactoring of {site/home}_settings to make them use base.View This makes the way for deleting the key_name.py module

Major site restructuring, also deleting of many unused or obsolete documents The new structure is as follows: <entity>/list - list all <entitie>s <entity>/create - create a new <entity> <entity>/show/<key fields> - public page for <entity> <entity>/edit/<key fields> - edit a <entity> <entity>/delete/key fields> - delete a specific entity

Fix sponsor key field extraction When extracting key field there is no sponsor or user object, instead only their link names are known.

Implements base.Logic functions in home_settings, site_settings and work This patch implements the base.Logic funtions needed for making logic/key_name.py obsolete. This patch defines the needed functions in home_settings, site_settings and work. All modules in logic/models now have these functions defined. logic/models/site_settings.py now inherits from logic/models/home_settings.py because of their similar connection in the corresponding models. Please note that the self._keyName for these two modules still points to logic/key_name.py since entity_type is still used in views/home.py. A partial_path and link_name were added to HomeSettings as requested by SRabbelier.

Fix wrong redirect when changing partial path or link name. Remove an unnecessary assignment in logic/models/base.py that would generate an error when an entity did not exist. Patch by: Lennard de Rijk Review by: Pawel Solyga

Fix not working former ids feature of User Profile Developer Edit view. Add missing Error exception class to soc.logic.models.base module. Patch by: Pawel Solyga

Third-party Javascript that should have been part of r891. Same license as JQuery. Patch by: Todd Larsen

Minor fixes needed for generic key name We no longer try to retreive an entity when there are unset fields. This sort of makes 'getIfFields' obsolete, since we check if fields now anyway. This is needed because getKeyFieldsFromDict expects the fields to be set. Also a minor fix in a Django template so that the generic 'edit' page has a working delete button again.

Quick fix to fix user profile creation This change will be obsolete when User refactoring is finished, but it will fix the build untill then.

Django Fix according to code.djangoproject.com/attachement/ticket/9115/check_for_unlink_in_temp.patch

Add missing TODOs to soc.logic.models classes. Fix comments format in base.Logic class. Changes based on comments to r972. http://code.google.com/p/soc/source/detail?r=972 Patch by: Pawel Solyga

Refactor out the abundance of dictionary (un)packing Instead, keep the dict packed once packed, and only unpack it when needed.

Added key field definitions to the User logic This is the first part of making the User views generic.

Add a getForFields method It allows for generic queries with restrictions specified in a dictionary.

Add a generic method for getting a Keyname This patch will make logic/key_name.py obsolete in the future when everything is compliant with base.logic. This also makes the naming of already compliant logic modules generic and also fixes the _name field to be consistent with the naming in key_name.py. Note: This does not use Group/Sponsor, Group/School, Group/Organisation or Group/Club. Patch by: "Lennard de Rijk" <rijk0214@gmail.com> Reviewed by: Sverre Rabbelier

Added a missing 'pass' statement

Create a Site Settings sub-menu

Fixed typo in e-mail address Instead of 'sverre@rabbelier.nl' everything read 'sverer@rabbelier.nl'

Fixed typo in access check Instead of checking for 'public' the rights for 'edit' were checked.

The pretty blue triangles from Google Code! Patch by: Todd Larsen

Add tooltips style display of help_text, instead of widening the form with another (often ridiculously large) column. Also, version the .css and .js files so that browsers won't display the wrong cached one when we change something. Patch by: Dmitri Gaskin, Todd Larsen Review by: Todd Larsen

Change Site and User sub-menus so that the "header" entry for those sub-menus is not a clickable link, but instead just a placeholder. Patch by: Todd Larsen

Use nice "plus" and "minus" symbols from Google Code, instead of current triangles, for sidebar menu. Patch by: Todd Larsen

Add javascript expandable menus. Patch by: Dmitri Gaskin Review by: Augie Fackler

Add jQuery. Patch by: Dmitri Gaskin Review by: Augie Fackler

Remove bogus import from a previous iteration.

Remove newlines in sidebar

Start a test system for the webapp itself.

Always check if a user filled in a user profile Also, if there is no checks defined, still do the general checks.

Do not include attributes which are inherited. Also some extra comments. Review URL: http://codereviews.googleopensourceprograms.com/1603

Run with Python 2.5

Fix typo in models/public.html template. Changes in Host Public Profile template (new header title and deletion of some fields). Patch by: Pawel Solyga Review by: to-be-reviewed

Fix mistakes in Host List templates. Change Host List second row to Sponsor name instead of Sponsor link name. Patch by: Pawel Solyga Review by: to-be-reviewed

Rename Host list templates from group_<something> to host_<something> and move then to soc/host/list folder. Update affected files with new paths. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix Sponsor profile edit/create template. Don't show "View Sponsor Public Profile" link and Delete button in Create Sponsor view. Patch by: Pawel Solyga Review by: to-be-reviewed

Addresses comments to r866. http://code.google.com/p/soc/source/detail?r=866 Patch by: Pawel Solyga Review by: to-be-reviewed

Moved all key_name related things to the logic modules Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Addressed comments by Pawel and Todd Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Inherit from BaseForm in all forms instead of from DbModelForm. This change doesn't include changes to templates and usage of as_table everywhere (work in progress). Patch by: Pawel Solyga Review by: to-be-reviewed

Fix not working Create views (committed in r864). Check if entity exist in constructKeyNameSuffix funtion and apply changes to affected files. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix some wrong paths to templates (committed in r864). Patch by: Pawel Solyga Review by: to-be-reviewed

Add Google Analytics support to Site Settings. The reason I created additional SettingsValidationForm is because you cannot inherit from Form that has already defined Meta class, so it's sort of workaround for that. I didn't want to have same validation functions in both Form classes. Patch by: Pawel Solyga Review by: to-be-reviewed

Added a Host profile and generalized some views Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Some more improvements to the generic view code Namely getEmptyKeyFields and constructKeyNameSuffix, some whitespace issues, and a few extra fields in the context. Patch by: Sverre Rabbelier Reviewd by: to-be-reviewed

Incorperated suggestions by Todd Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Make use of the new generic views Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Added a generic version of the Document views Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Various improvements to the generic View code Among others: * Added the 'page' argument to the simple.errorResponse call * Pass the result of getEmptyKeyFields to edit() in create() * Fix typo's in error responses * Fixed a todo to properly redirect on create * Made editPost return something when the form is not valid * Added an _editGet hook Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Rename 'existing_doc' and 'document' to entity Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Remove the google search box and the google analytics page These are left over from the mockups (removed because they caused long wait times when no internet connection is available).

Improve the error message for getIfFields Patch by: Sverre Rabbelier Reviewed by: to-be-reviewed

Add documentation in response to Pawel's comments: http://code.google.com/p/soc/source/detail?r=832 Patch by: Todd Larsen Review by: to-be-reviewed

Add BaseForm class to soc.views.helper.forms module (work in progress). This changes the way as_table function displays the form (for more information have a look into doc string). BaseForm is going to be used for all forms in Melange in future. Right now it's still missing custom form errors labels and "required" text in 3rd column, but that's added as TODO and I'm working on it. Patch by: Pawel Solyga Review by: to-be-reviewed

Add colon after label in _field_as_table_row template for consistency reasons with form.as_table output. Patch by: Pawel Solyga Review by: to-be-reviewed

Add "View Sponsor Public Profile" to Sponsor Edit view template. Remove not needed <p> in home/public.html template. Add missing '$' at the end of some urls in site/map.py module. Patch by: Pawel Solyga Review by: to-be-reviewed

Address comments to r844 and r845. Patch by: Pawel Solyga Review by: to-be-reviewed

Remove unused imports, fix too long lines and indentions. Patch by: Pawel Solyga Review by: to-be-reviewed

Fix identions, too long lines, unused imports and some other mistakes. Patch by: Pawel Solyga Review by: to-be-reviewed