Lennard de Rijk <ljvderijk@gmail.com> [Mon, 10 Aug 2009 16:58:51 -0700] rev 2748
Updated several page titles to contain more information.
Fixes Issue 437.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 10 Aug 2009 16:35:01 -0700] rev 2747
Added hook for the edit view.
This hook is called on both GET and POST requests.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 10 Aug 2009 15:49:47 -0700] rev 2746
Redirect to the manage page for failed, completed and withdrawn projects.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 10 Aug 2009 15:37:12 -0700] rev 2745
Made the specific SurveyTakeForm used in a View part of params.
This fixes the Grade question not showing up on the preview and view record pages.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 10 Aug 2009 15:28:42 -0700] rev 2744
Removed the grade_choices keyword argument from GradeSurveyTakeForm.
This is because this class already assumes very specific things about the grade_choices keyword argument. Therefore it is now a constant inside this class.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 10 Aug 2009 15:14:29 -0700] rev 2743
Enable the project management page to be visited for project in other statusses.
This enables org admins to easily view Survey results for projects that have failed.
Sverre Rabbelier <sverre@rabbelier.nl> [Sun, 09 Aug 2009 21:00:32 -0700] rev 2742
Added tag v0-5-20090809 for changeset 107bec037dda
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 09 Aug 2009 20:59:15 -0700] rev 2741
Set new Melange version number to 0-5-20090809 in app.yaml.template.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 09 Aug 2009 13:42:31 -0700] rev 2740
Added project title and student name to the ProjectSurvey take page.
This required some reodering of the Survey take template and also a renamed setH
elpAndStatus to _setSurveyTakeContext.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 09 Aug 2009 13:03:47 -0700] rev 2739
Added capability to update a single GradingRecord on the edit page.
Mario Ferraro <fadinlight@gmail.com> [Sat, 08 Aug 2009 18:42:22 +0100] rev 2738
Upgrade to jQuery library to 1.3.2 version.
This will allow us to use also the new Event object (for example
for publish/subscribe pattern) along with some plugins
(like Colorbox) which work only with newer (>=1.3) jQuery versions.
Some further testing is suggested.
Daniel Hans <Daniel.M.Hans@gmail.com> [Fri, 07 Aug 2009 02:06:33 +0200] rev 2737
List of countries is actually alphabetically sorted.
Daniel Hans <Daniel.M.Hans@gmail.com> [Fri, 07 Aug 2009 01:27:24 +0200] rev 2736
Argument store added to updateEntityProperties.
This argument determines if an entity should be stored in the data model after its properties are updated.
It may be useful, for example, along with tasks (Task Queue API). One may want to make some modifications to an entity during execution of a task, but the developer is sure that at least one new task, which also wants to modify the entity, will be queued, so he or she can just update the entity without saving the changes to the data model, set the entity in memcache and the following task (which is to be executed very shortly) is to retrive the current entity from the memcache (without any expensive calls to the actual data model).
Daniel Hans <Daniel.M.Hans@gmail.com> [Fri, 07 Aug 2009 01:00:58 +0200] rev 2735
Each country has its continent assigned.
In order to retrive the continent, one has to use COUNTRIES_TO_CONTINENT dictionary.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 06 Aug 2009 10:48:44 +0200] rev 2734
Added and enabled new access check for viewing ProjectSurvey records.
Org Admins, project Mentors and project Students are now allowed to see their own ProjectSurveyRecords.
Note however that Students and Mentors have no interface yet to find the whereabouts of their records.
Fixes Issue 659.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 05 Aug 2009 22:00:08 +0200] rev 2733
Added and enabled access check for viewing SurveyRecords.
Note that viewing ProjectSurveys or ProjectGradingSurveys are still dev only.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 05 Aug 2009 16:52:08 +0200] rev 2732
Enabled Org Admins to take Surveys on behalf of their Mentors.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 05 Aug 2009 12:38:50 +0200] rev 2731
The Survey Results view now only list Records of interest to the current user.
Also added a hook that can be overwritten by subclasses to adjust the filter. THis will be useful when wanting to filter on ProjectSurveyRecords for a specific org.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 04 Aug 2009 21:46:03 +0200] rev 2730
Redone the list_info function for the Project's manage page.
This will reduce the overhead because Django calls the info method over and over again.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 04 Aug 2009 21:29:49 +0200] rev 2729
Added redirect to the StudentProject manage page for viewing SurveyRecords.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 04 Aug 2009 17:07:44 +0200] rev 2728
Whitespace fix in User model.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 04 Aug 2009 17:00:46 +0200] rev 2727
ViewResults for Surveys is now showing all SurveyRecords.
The redirect will redirect the user to the viewing of a single SurveyRecord.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 04 Aug 2009 16:57:27 +0200] rev 2726
Added redirect for viewing SurveyRecords and enabled links in the Record list.
Patch by: Lennard de Rijk and James Levy
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 04 Aug 2009 16:52:41 +0200] rev 2725
Removed TODO from ProjectSurvey and GradingProjectSurvey views.
James Levy <jamesalexanderlevy@gmail.com> [Tue, 04 Aug 2009 16:46:47 +0200] rev 2724
Added templates for listing SurveyRecords.
In the process results_heading and results_row got renamed to records_heading and records_row.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 04 Aug 2009 15:59:42 +0200] rev 2723
The Survey public view now uses the proper page name.
Also removed the pick view entry from the Survey View.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 04 Aug 2009 15:58:31 +0200] rev 2722
Added view for showing Survey Records.
The current access level is set to Developer only until this feature is complete
d.
A start has also been made on the viewResults method which will list the appropr
iate SurveyRecords for a given survey with a redirect to the viewRecord view.
Patch by: Lennard de Rijk and James Levy
James Levy <jamesalexanderlevy@gmail.com> [Tue, 04 Aug 2009 15:34:41 +0200] rev 2721
Added template for viewing Survey Records.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 04 Aug 2009 15:33:39 +0200] rev 2720
Use proper id for survey_description div.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 03 Aug 2009 17:33:58 +0200] rev 2719
Added link for students to resign their profile to the Program menu.
Fixes Issue 549.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 03 Aug 2009 17:32:34 +0200] rev 2718
Fixed access check for Student Manage/Resign page.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 03 Aug 2009 17:05:55 +0200] rev 2717
Fixed typo in access module comment and StudentProject list description.
Madhusudan C.S. <madhusudancs@gmail.com> [Mon, 03 Aug 2009 15:17:21 +0200] rev 2716
Added minimum age property to Program model.
This will allow hosts to specify a minium age requirement for Students wanting to participate in a program.
Reviewed and edited by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 02 Aug 2009 23:51:55 +0200] rev 2715
Added some helpful text to the Student Project Withdraw view.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 02 Aug 2009 23:45:42 +0200] rev 2714
Fixed Org home view map to only appear when projects have been announced.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 02 Aug 2009 22:39:47 +0200] rev 2713
Added tag v0-5-20090802 for changeset 2fb96db18711
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 02 Aug 2009 22:39:09 +0200] rev 2712
Set new Melange version number to 0-5-20090802 in app.yaml.template.
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 02 Aug 2009 02:57:20 -0700] rev 2711
addressed comments by Lennard
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 02 Aug 2009 02:52:48 -0700] rev 2710
add checkIsHostForStudentProject checker
Madhusudan.C.S <madhusudancs@gmail.com> [Sun, 02 Aug 2009 15:19:50 +0530] rev 2709
Add parent parameter to accommodate entity groups.
Madhusudan.C.S <madhusudancs@gmail.com> [Sun, 02 Aug 2009 15:20:00 +0530] rev 2708
Notification logic in main SoC is capable of getting constructor parameters.
Sverre Rabbelier <sverre@rabbelier.nl> [Sat, 01 Aug 2009 16:22:10 -0700] rev 2707
Fix for copy/paste fail
Sverre Rabbelier <sverre@rabbelier.nl> [Sat, 01 Aug 2009 15:55:33 -0700] rev 2706
Add link to withdraw student project page
Sverre Rabbelier <sverre@rabbelier.nl> [Sat, 01 Aug 2009 15:37:58 -0700] rev 2705
Allow hosts to withdraw student projects
Sverre Rabbelier <sverre@rabbelier.nl> [Sat, 01 Aug 2009 15:37:36 -0700] rev 2704
Add three new redirects
Madhusudan.C.S <madhusudancs@gmail.com> [Sat, 01 Aug 2009 19:27:20 +0530] rev 2703
Style fixes in the ghop task model module.
Pawel Solyga <pawel.solyga@gmail.com> [Sat, 01 Aug 2009 14:50:53 +0200] rev 2702
Added optional filters property to deepFetch.
Note that additional indexes are required whenever this is used.
Reviewed by: Lennard de Rijk
Mario Ferraro <fadinlight@gmail.com> [Sat, 01 Aug 2009 13:20:05 +0100] rev 2701
Organization home page map dimensions now fit the world.
Mario Ferraro <fadinlight@gmail.com> [Sat, 01 Aug 2009 12:31:05 +0100] rev 2700
Role name for mentors now correctly shown in map's infoWindows.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 01 Aug 2009 10:07:08 +0200] rev 2699
Enable the map that shows the connections between mentors and students.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 31 Jul 2009 18:29:09 +0200] rev 2698
Edited the role form to clarify the intention of the checkbox+marker.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 30 Jul 2009 14:02:23 +0200] rev 2697
Renamed main CSS and map JS file due to recent changes.
Mario Ferraro <fadinlight@gmail.com> [Thu, 30 Jul 2009 14:00:37 +0200] rev 2696
Moved the student<->mentor map on the org home page below the list.
Also fixed the wrong EOL in the home.html template.
Patch by: Mario Ferraro and Lennard de Rijk
Reviewed by: to-be-reviewed
Mario Ferraro <fadinlight@gmail.com> [Thu, 30 Jul 2009 13:56:21 +0200] rev 2695
Redone the student<-> mentor map JS to reflect recent datastructure changes.
Reviewed by: Lennard de Rijk (functional review)
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 30 Jul 2009 13:54:47 +0200] rev 2694
Redone the gathering of data for the student<->mentor map.
Note that the data is not actually being put in the template yet.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 30 Jul 2009 10:54:09 +0200] rev 2693
Style fixes in StudentProject View.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 30 Jul 2009 10:53:03 +0200] rev 2692
Factored out the "No Record Available" message.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 30 Jul 2009 10:49:19 +0200] rev 2691
Pre-storing the information for setStudentProjectSurveyInfo.
This is a rename from getStudentProjectSurveyInfo because it now sets the info directly in the list content.
This is done because Django queries the wrapper method every time the info is called in the template.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 30 Jul 2009 10:05:22 +0200] rev 2690
Added project information to the Project manage page.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 30 Jul 2009 10:01:57 +0200] rev 2689
Renamed hasAtLeastOneRecord to hasRecord.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 30 Jul 2009 09:53:22 +0200] rev 2688
Added list of Surveys to the Project's manage page.
This list will show wether or not a Survey has been taken and will also feature links to (re)take a Survey and in the near future to see the actual SurveyRecord.
Note that the take Survey link is working however Org Admins will receive an access denied message when following this link.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 30 Jul 2009 09:43:15 +0200] rev 2687
Added getProjectSurveyInfoForProject to list_info helper.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 30 Jul 2009 09:29:36 +0200] rev 2686
Added new table templates for showing Suryves on the Project manage page.
Note that a system for showing SurveyRecords still needs to be committed.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 28 Jul 2009 11:23:11 +0200] rev 2685
Added columns to the manage project page that show the amount of evaluations.
The total possible amount of evaluations that is shown is based on surveys which have at least one Record.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 28 Jul 2009 11:20:42 +0200] rev 2684
Added hasAtLeastOneRecord method to Survey Logic.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 27 Jul 2009 15:03:20 +0200] rev 2683
Two style fixes.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 27 Jul 2009 13:12:17 +0200] rev 2682
Added tag v0-5-20090727 for changeset 0b4358ef9983
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 27 Jul 2009 13:06:36 +0200] rev 2681
Set new Melange version number to 0-5-20090727 in app.yaml.template.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 25 Jul 2009 13:13:20 +0200] rev 2680
Every radio button is now properly shown on a new line.
Update issue 655
Owner: ljvderijk
Fixes Issue 655.
Madhusudan C.S <madhusudancs@gmail.com> [Sat, 25 Jul 2009 01:09:46 +0530] rev 2679
Adds to Melange a tags framework based on taggable-mixin.
The taggable-mixin allowed only tag per Datastore model. This is extended
framework allows any arbitrary number of tags per Datastore model. Also,
now one can define different models for different Tag types which are all
inherited from the base Tag model provided by taggable-mixin.
The GHOPTask model makes use of 2 tags per model, one for difficulty and the
other for task_type, both using the tags framework.
Reviewed by: Paweł Sołyga
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 24 Jul 2009 21:00:04 +0200] rev 2678
Send out a Notification upon creation of a new Request entity.
The receivers are specified by the corresponding Role logic this Role Request is for. Currently Organization and Club Administrators will receive "new request" messages about respectively Mentor and Club Membership requests.
Fixes Issue 442.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 24 Jul 2009 20:57:53 +0200] rev 2677
Use proper in-line import in Request helper.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 24 Jul 2009 20:56:08 +0200] rev 2676
Added sendNewRequestNotification to the Notifications helper.
This method will send out a notification upon arrival of a new Request to all users who have an active role for the Request's scope and the roles as specified by the getRoleLogicsToNotifyUponNewRequest.
Also renamed getRoleLogicsToNotifyUponeNewRequest to getRoleLogicsToNotifyUponNewRequest.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 24 Jul 2009 20:49:59 +0200] rev 2675
Added template for a notification upon arrival of a new Request.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 24 Jul 2009 20:17:35 +0200] rev 2674
Tables listing Requests now show the name of the Group the request is for/from.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 24 Jul 2009 20:13:40 +0200] rev 2673
Added missing role_name to org_admin Logic.
Also reordered keyword arguments in role Logics.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 24 Jul 2009 19:59:26 +0200] rev 2672
Added getRoleLogicsToNotifyUponeNewRequest for use with notifications.
This method returns a list of all the Role Logics that can be used to query who should receive a notification when a new Role Request arrives.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 24 Jul 2009 15:23:45 +0200] rev 2671
Use proper in-line imports where possible in the Notifications helper.
James Levy <jamesalexanderlevy@gmail.com> [Thu, 23 Jul 2009 18:28:49 -0700] rev 2670
fix for issue 653 by adding wrap=hard attr to textareas for surveys
JamesLevy <jamesalexanderlevy@gmail.com> [Thu, 23 Jul 2009 16:56:00 -0700] rev 2669
seed_db now creates fixture student project entities, and corresponding project surveys and grading surveys for debugging purposes.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 23 Jul 2009 14:55:29 +0200] rev 2668
Use role_name where needed for creating/handling requests.
Also added TODO to extend the redirect for further use with the new module system.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 23 Jul 2009 14:43:20 +0200] rev 2667
Use role_name to register the Role with the Group View.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 23 Jul 2009 14:41:53 +0200] rev 2666
Use role_name from Role Logic as key to store the different Role Views.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 23 Jul 2009 14:37:44 +0200] rev 2665
Style fixes in Group View.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 23 Jul 2009 14:36:45 +0200] rev 2664
Added registerRole to Role Logic where all roles are registered.
This is used to make the use of the role property in the Request Model more easily consistent.
Sverre Rabbelier <sverre@rabbelier.nl> [Sat, 18 Jul 2009 15:04:44 -0700] rev 2663
update Sidebar tests to use getCore
Sverre Rabbelier <sverre@rabbelier.nl> [Sat, 18 Jul 2009 14:58:12 -0700] rev 2662
register a core for the test modules to use
Mario Ferraro <fadinlight@gmail.com> [Wed, 15 Jul 2009 17:11:17 +0200] rev 2661
Fixed line length.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 15 Jul 2009 15:28:02 +0200] rev 2660
Another batch of style fixes for Surveys.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 15 Jul 2009 15:18:58 +0200] rev 2659
More style fixes due to code reviews for Surveys.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 15 Jul 2009 15:07:01 +0200] rev 2658
Several style fixes and code cleaning for surveys.
James Levy <jamesalexanderlevy@gmail.com> [Wed, 15 Jul 2009 12:20:48 +0200] rev 2657
Fixed wrong js being referenced by the public Survey template.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 15 Jul 2009 11:48:43 +0200] rev 2656
Added validation to email fields where needed.
Apparently Django did not generate an email field when it was required.
Fixes issue 623.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Jul 2009 22:33:37 +0200] rev 2655
Slow down mail tasks some more to ensure they actually complete.
ApplicationError 1 might occur when mails are being sent too fast.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Jul 2009 21:24:55 +0200] rev 2654
Added tag v0-5-20090714 for changeset 8846761b3a6c
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Jul 2009 21:24:24 +0200] rev 2653
Set new Melange version number to 0-5-20090714 in app.yaml.template.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Jul 2009 21:13:12 +0200] rev 2652
Made requested changes to GradingRecord results mail.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Jul 2009 21:09:18 +0200] rev 2651
Added the ability to update project + mail when editing a single GradingRecord
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Jul 2009 19:06:53 +0200] rev 2650
Fixed message on Records page for GradingSurveyGroups.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Jul 2009 18:44:33 +0200] rev 2649
Fixed issue where GradingSurveyRecords from another group could be edited.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Jul 2009 18:36:16 +0200] rev 2648
Added button to the GradingRecords overview to send mail when updating projects.
Note that this will mail all the projects for which a record is available.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Jul 2009 18:35:20 +0200] rev 2647
Added task to send out email for each processed GradingRecord.
If send_mail evaluates to True in the POST data for updateProjectsForSurveyGroup task then the results of every GradingRecord will be mailed to the Student. The Mentor and Org Admins will be cc'ed.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Jul 2009 18:28:33 +0200] rev 2646
Added mail template for when GradingRecords are proccessed.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Jul 2009 17:29:53 +0200] rev 2645
Made the reminder templates extend the mail base instead of notification.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Jul 2009 16:48:08 +0200] rev 2644
Added Task to process GradingRecords and update their StudentProjects.
An index for this operation is required and has been added to the index.yaml file.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Jul 2009 16:46:42 +0200] rev 2643
Added updateProjectsForGradingRecords to StudentProject Logic.
This method takes a list of record_entities, processes them and batch puts the update StudentProjects.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Jul 2009 15:17:10 +0200] rev 2642
Add new project status column to accepted students csv export.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Jul 2009 13:10:56 +0200] rev 2641
Added Student and Mentor link id to the GradingRecord list.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Jul 2009 00:55:05 +0200] rev 2640
Fixed an error occuring when assigning more then one secondary mentors.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 23:08:14 +0200] rev 2639
Withdrawn projects are removed from GradingRecord creation/update task.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 22:11:28 +0200] rev 2638
Changed tag for latest version to match the correct commit.
Sorry, somehow one file stayed behind :).
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 22:04:19 +0200] rev 2637
Excluded the new StudentProject failed_evaluations property from Forms.
(Something went wrong on my side this should have been in before the tag)
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 21:57:10 +0200] rev 2636
Added tag v0-5-20090713 for changeset 51d83d0572ec
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 21:56:53 +0200] rev 2635
Set new Melange version number to 0-5-20090713 in app.yaml.template.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 21:56:01 +0200] rev 2634
Added failed_evaluations property to StudentProject model.
This is used to store GradingRecords which state a fail for this project. It's a list because manual changes in GradingRecords might force multiple GradingRecords to state a fail. Also it needs to be clear which GradingRecords have been processed and with which grade_decision.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 18:04:10 +0200] rev 2633
Changed GradingRecord heading/row templates to give more useful info.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 12:52:54 +0200] rev 2632
Added view for editing GradingRecords.
This view shows a list of GradingRecords if the id param is not present in the GET data.
Also renamed grading_record to view_records and fixed the redirect for that page
to also point to the GradingRecord edit page.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 12:48:37 +0200] rev 2631
Fixed style error in GradingSurveyGroup Task model.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 12:48:05 +0200] rev 2630
Made the locked property non-required.
This makes it easier to generate a Form that can properly deal with GradingRecords. Since required boolean properties can only be set to true by such an automatically generated form.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 12:46:54 +0200] rev 2629
Added template for editing GradingRecords.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 11:12:42 +0200] rev 2628
Added getRecordLogic method to GradingSurveyGroup Logic.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 11:02:57 +0200] rev 2627
Added redirect for editing a GradingRecord.
The view for this will be added in a later commit.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 10:18:14 +0200] rev 2626
Fixed bug where grade_decision would not be properly set in 2 out of 4 cases.
Daniel Hans <Daniel.M.Hans@gmail.com> [Mon, 13 Jul 2009 11:43:40 +0200] rev 2625
Style fix in callback.py
dhans [Mon, 13 Jul 2009 11:19:55 +0200] rev 2624
Fixed issue with opening items on survey lists while pressing ctrl button
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 01:15:46 +0200] rev 2623
Added messages to the Records page when a task has been successfully started.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 01:07:18 +0200] rev 2622
Style fixes in GradingRecord Logic.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 01:07:03 +0200] rev 2621
Changed GradingRecord list templates to show more info.
They now show wether or not a Mentor/Student eval has been found.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 01:00:59 +0200] rev 2620
Added GradingSurveyGroup tasks to the core URL's.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 01:00:20 +0200] rev 2619
The buttons on the GradingSurveyGroup record page now enqueue Tasks.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 00:59:48 +0200] rev 2618
Added Tasks to update/create GradingRecords for a given GradingSurveyGroup.
Also added a stub to update StudentProjects for a given GradingSurveyGroup.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 00:59:11 +0200] rev 2617
Added methods to GradingRecord Logic to facilitate creating/updating them.
UpdateOrCreateRecordsFor will batch put GradingRecords for a given SurveyGroup and StudentProject.
getFieldsForGradingRecord will return the fields that need to be set for a single GradingRecord entity given a StudentProject, GradingSurveyGroup and if it is an update a GradingRecord entity.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 00:53:42 +0200] rev 2616
Added buttons to start tasks to GradingSurveyGroup Record view.
Also fixed an error in the GradingRecord row template.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 12 Jul 2009 22:25:43 +0200] rev 2615
Fixed errors in comments and docstring for the Surveys Task module.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 12 Jul 2009 22:00:12 +0200] rev 2614
Refactored logErrorAndReturnOK into separate module.
Augie Fackler <durin42@gmail.com> [Sun, 12 Jul 2009 11:46:36 -0500] rev 2613
buildout.cfg: We require nose as well for tests.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 12 Jul 2009 16:01:41 +0200] rev 2612
Added view to GradingSurveyGroup to list all records for a specified group.
This view will later be extended with options to start Tasks for collecting the data and processing it.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 12 Jul 2009 16:00:32 +0200] rev 2611
Added listing templates for GradingRecords.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 12 Jul 2009 14:03:35 +0200] rev 2610
Add scope view for GradingSurveyGroup and set access checks.
The access checks are now properly set for create, edit and show. To facilitate the scope view the access check have an extra check built in to ensure that a scope is actually present before cheking for an existing Program.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 12 Jul 2009 13:55:21 +0200] rev 2609
Fixed passing along empty params to scope selection view.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 12 Jul 2009 12:50:01 +0200] rev 2608
Renamed tag for latest version to match the app.yaml version entry.
Thanks to Madhusudan C.S. for noticing this.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 12 Jul 2009 00:45:45 +0200] rev 2607
Added tag 0-5-20090711p1 for changeset 03aa33e8600b
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 12 Jul 2009 00:45:01 +0200] rev 2606
Set new Melange version number to 0-5-20090711p1 in app.yaml.template.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 12 Jul 2009 00:40:24 +0200] rev 2605
Removed several sidebar entries for Surveys which where not properly working.
Sverre Rabbelier <sverre@rabbelier.nl> [Sat, 11 Jul 2009 15:05:02 -0700] rev 2604
Added tag v0-5-20090711 for changeset 4db295c3fbb3
Sverre Rabbelier <sverre@rabbelier.nl> [Sat, 11 Jul 2009 15:04:43 -0700] rev 2603
Set new Melange version number to 0-5-20090711 in app.yaml.template.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 12 Jul 2009 00:02:28 +0200] rev 2602
Fixed typo in ProjectSurvey reminder mail.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 11 Jul 2009 23:53:30 +0200] rev 2601
Fixed the redirect for Survey reminder emails.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 11 Jul 2009 23:38:37 +0200] rev 2600
Fixed typo in GradingProjectSurvey reminder email.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 11 Jul 2009 23:29:31 +0200] rev 2599
Add queue.yaml to build scripts.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 11 Jul 2009 23:29:22 +0200] rev 2598
Changed URL pattern for starting sending out survey reminders.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 11 Jul 2009 23:19:18 +0200] rev 2597
Added the Surveys Tasks to the registered URL patterns.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 11 Jul 2009 23:18:52 +0200] rev 2596
Added a view to start sending out a reminder.
Note that this view is currently developer-only.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 11 Jul 2009 23:18:14 +0200] rev 2595
Added Surveys Tasks module to send reminders.
All reminders are CC'ed to the org admins.
Also added an index property on StudentProjects which is required for the reminder Tasks.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 11 Jul 2009 23:15:22 +0200] rev 2594
Added empty Tasks package and queue.yaml.
Also reserved an admin only URL space for use by Tasks.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 11 Jul 2009 20:42:23 +0200] rev 2593
Edited help text to be more clear when a Survey has been submitted.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 11 Jul 2009 20:10:33 +0200] rev 2592
Add setOrganizationInSurveyRecords function to stats.py script.
setOrganizationInSurveyRecords will iterate thru all ProjectSurveyRecords and GradingProjectSurveyRecords and set the organization property in the record model.This will be useful later for showing Org admins their mentors and students surveys list and results.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 11 Jul 2009 19:54:23 +0200] rev 2591
Add Organization reference property to ProjectSurveyRecord.
Also update ProjectSurvey view _takePost method to set this property everytime survey is taken.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 11 Jul 2009 19:37:26 +0200] rev 2590
Fix indention and add missing dot in docstring in survey models.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 11 Jul 2009 17:25:19 +0200] rev 2589
GradingSurveyGroup now uses DynaForm for its forms.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 11 Jul 2009 13:56:55 +0200] rev 2588
Indention fixes and adding "reference_class=" in ReferenceProperty params.
Augie Fackler <durin42@gmail.com> [Tue, 07 Jul 2009 20:17:23 -0500] rev 2587
Start using buildout to bring in external dependencies.
This makes running tests easier in situations where dependencies are not always available, such as buildbot.
Thanks to Matthew Wilkes <matthew@matthewwilkes.co.uk> for help and moral support.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 10 Jul 2009 12:09:09 +0200] rev 2586
Added GradingSurveyGroup to the sitemap and sidebar.
Daniel Diniz <ajaksu@gmail.com> [Fri, 10 Jul 2009 12:06:29 +0200] rev 2585
Completed the Create and Edit view for GradingSurveyGroup.
Note that I've added a TODO to redo _editPost to give us kwargs. Would also get rid of hidden fields elsewhere.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 10 Jul 2009 11:59:00 +0200] rev 2584
Fixed GradingRecord and GradingSurveyRecord Logic to load the correct Model.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 10 Jul 2009 11:39:41 +0200] rev 2583
Added denySidebar to several access checks.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 09 Jul 2009 23:50:21 +0200] rev 2582
Added Surveys to sidebar menu.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 09 Jul 2009 14:00:59 +0200] rev 2581
Changed title entry in GradingSurveyGroup's public template to name.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 09 Jul 2009 11:52:35 +0200] rev 2580
Added skeleton view and templates for GradingSurveyGroup.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 09 Jul 2009 11:47:31 +0200] rev 2579
Added name property to GradingSurveyGroup.
This can be used (by humans :D) to easily identify different instances of this model.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 09 Jul 2009 11:00:17 +0200] rev 2578
Added missing blank line to GradingSurveyGroup logic.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 09 Jul 2009 10:52:19 +0200] rev 2577
Added logic for GradingRecord and GradingSurveyGroup.
Daniel Diniz <ajaksu@gmail.com> [Thu, 09 Jul 2009 10:39:30 +0200] rev 2576
Removed results list from Survey edit.
Some changes to the Survey Result page have also been made, however the results viewer and the CSV export are not working properly in that View.
Reviewd by: Lennard de Rijk
Mario Ferraro <fadinlight@gmail.com> [Thu, 09 Jul 2009 10:16:29 +0200] rev 2575
Extended tooltip timeout to 10 seconds for all fields.
This is because the tooltip currently timesout to fast for people to read the whole stories they can contain. Especially because Surveys can have custom tooltips.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 08 Jul 2009 15:45:53 +0200] rev 2574
Minor stylefix to StudentProject model.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 08 Jul 2009 15:44:54 +0200] rev 2573
Changed the StudentProject model to handle a dynamic amount of GradeRecords.
This allows for a dynamic amount of moments where a StudentProject can be evaluated.
Also included in this patch are changes to the status property that will help to enable PA's to withdraw StudentProjects from the program without the need for a developer to step in.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 08 Jul 2009 11:50:02 +0200] rev 2572
Renamed several files due to recent changes.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 08 Jul 2009 10:45:49 +0200] rev 2571
Style fixing in GradeRecord model
Daniel Diniz <ajaksu@gmail.com> [Wed, 08 Jul 2009 10:40:46 +0200] rev 2570
Several Survey UI fixes.
Fixes:
Too narrow fieldsets in new question/option dialogs.
Survey submit (on take view) and save/export/etc. buttons at weird places, instead of at bottom.
Weird placement of radio buttons in Opera.
Too narrow selects in IE.
Broken images in edit view in IE and Opera.
Reviewed by: Lennard de Rijk (Only on IE)
Madhusudan C.S. <madhusudancs@gmail.com> [Tue, 07 Jul 2009 21:16:57 +0200] rev 2569
Fixed base template URL to tagged version of the deployed source code.
The old link revered to SVN based projects.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 07 Jul 2009 20:02:27 +0200] rev 2568
Fixed imports for Survey logic.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 07 Jul 2009 18:46:47 +0200] rev 2567
Added skeleton models for GradingSurveyGroup and Records.
SurveyRecordGroup has been renamed to GradingRecord.
GradingSurveyGroup will hold which Surveys should be linked. While the acompanying GradingRecords (with their reference to a GradingSurveyGroup) will hold the Records for each StudentProject that can take these Surveys.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 06 Jul 2009 17:20:30 +0200] rev 2566
Added tag v0-5-20090706 for changeset c17b671e5657
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 06 Jul 2009 17:19:57 +0200] rev 2565
Set new Melange version number to 0-5-20090706 in app.yaml.template.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 06 Jul 2009 17:18:41 +0200] rev 2564
Ensure that the Grade field data stays in clean_data.
This prevents a bug that happens when you pick an invalid entry in the choice a grade field. If this bug was triggered the value of the survey_record.grade was used. Now however a proper ValidationError is raised.
Daniel Diniz <ajaksu@gmail.com> [Mon, 06 Jul 2009 17:03:19 +0200] rev 2563
Add missing import to Project Survey view.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 06 Jul 2009 16:32:14 +0200] rev 2562
Renamed several files due to recent changes.
Mario Ferraro <fadinlight@gmail.com> [Mon, 06 Jul 2009 16:21:51 +0200] rev 2561
Now properly escaping JS and converting new lines into br for Tooltips.
Patch by: Mario Ferraro, Lennard de Rijk
Daniel Diniz <ajaksu@gmail.com> [Mon, 06 Jul 2009 16:13:27 +0200] rev 2560
Added ability to add custom tooltips and UI improvements.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 06 Jul 2009 15:06:05 +0200] rev 2559
Public Survey template now resembles the take template more closely.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 06 Jul 2009 14:58:46 +0200] rev 2558
Added the possiblitity to add a description to the top of the Survey.
Thie uses the content property which has been inherited from the Work model.
James Levy <jamesalexanderlevy@gmail.com> [Mon, 06 Jul 2009 13:19:00 +0200] rev 2557
Use CSS instead of JS for Survey layout.
Reviewed by: Lennard de Rijk
Daniel Diniz <ajaksu@gmail.com> [Mon, 06 Jul 2009 12:06:28 +0200] rev 2556
Remove the custom propmpt inside textareas and input fields.
This will hopefully be replaced with custom tooltips. Two reasons for this are that the tooltips will still be readable once your start typing and this way we avoid a bug that caused a textarea to go into prompt mode on some form validation errors.
Reviewed by: Lennard de Rijk
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 06 Jul 2009 00:54:48 +0200] rev 2555
Fix HtmlSanitizer to return cleaned string in proper encoding.
This fix prevent HtmlSanitizer from throwing UnicodeDecodeError exception.
James Levy <jamesalexanderlevy@gmail.com [Mon, 06 Jul 2009 00:31:48 +0200] rev 2554
Added clear:right property to submit button in Survey take form.
Reviewed by: Lennard de Rijk
Mario Ferraro <fadinlight@gmail.com [Mon, 06 Jul 2009 00:29:30 +0200] rev 2553
Fix button layout on Safari 4.0 for Survey take page.
Reviewed by: Lennard de Rijk
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 06 Jul 2009 00:16:47 +0200] rev 2552
Fix comment indention in survey-take javascript file.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 05 Jul 2009 23:45:57 +0200] rev 2551
Renamed survey-take-090627.js to survey-take-090705.js.
James Levy <jamesalexanderlevy@gmail.com> [Sun, 05 Jul 2009 23:43:57 +0200] rev 2550
Increased bottom margin on comments for better grouping.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 05 Jul 2009 13:31:34 +0200] rev 2549
Changed the filter for getting a SurveyRecord for a ProjectSurvey
ProjectSurveyRecords are characterized by the Survey and a Project entity. The user property is just there to state who last submitted the Survey.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 05 Jul 2009 13:00:08 +0200] rev 2548
Added tag v0-5-20090705p1 for changeset c7726e3ab173
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 05 Jul 2009 12:59:33 +0200] rev 2547
Set new Melange version number to 0-5-20090705p1 in app.yaml.template.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 05 Jul 2009 12:57:09 +0200] rev 2546
Ensure that accessViolations for Survey menu items get captured.
(Also ensure that you think before committing something you broke yourself :()
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 05 Jul 2009 12:19:19 +0200] rev 2545
Added tag v0-5-20090705 for changeset 8f3a8e066111
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 05 Jul 2009 12:18:31 +0200] rev 2544
Set new Melange version number to 0-5-20090705 in app.yaml.template.
James Levy <jamesalexanderlevy@gmail.com> [Sun, 05 Jul 2009 11:32:26 +0200] rev 2543
Added Menu items for all three kinds of Surveys to the program menu.
The menu items turn red when the user has not taken the Survey yet.
Patch by: James Levy, Lennard de Rijk
Reviewed by: to-be-reviewed
Daniel Diniz <ajaksu@gmail.com> [Sun, 05 Jul 2009 00:57:03 +0200] rev 2542
POST data always overwrites survey_record data when used to populate form.
It also fixes validation errors on takeGet.
Patch by: Daniel Diniz, Lennard de Rijk
Reviewed by: to-be-reviewed
Mario Ferraro <fadinlight@gmail.com> [Sat, 04 Jul 2009 18:48:58 +0100] rev 2541
Fixes bug when option name contains double quotes.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 18:53:37 +0200] rev 2540
Several style fixes due to code reviews.
Daniel Diniz <ajaksu@gmail.com> [Sat, 04 Jul 2009 17:23:19 +0200] rev 2539
Ensure that long questions and comments are stored as db.Text.
This is done by adding the setCleaners methods which sets the appropriate cleaners for dynamic fields.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 17:16:16 +0200] rev 2538
Style fix in access module.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 17:02:51 +0200] rev 2537
Returned ProjectSurvey create to checkIsUser.
The access protection is properly done by the form validator.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 16:44:08 +0200] rev 2536
Added access checks for taking a Project(Grading)Survey.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 16:23:00 +0200] rev 2535
Brown paper bag fix for using non-existing logic in ProjectSurvey views.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 15:59:19 +0200] rev 2534
Fixed basic Survey access check.
Also enabled this check for all relevant Views. However ProjectSurveys and subclasses still need an additional check. A stub for this has been added to the access module.
Daniel Diniz <ajaksu@gmail.com> [Sat, 04 Jul 2009 15:30:08 +0200] rev 2533
Fixed broken selection questions from refactoring SurveyForm.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 15:16:54 +0200] rev 2532
Fixed showing the correct list of projects for taking a Grading Project Survey.
Note that when a user is a mentor for a lot of Organizations the amount of subqueries might exceed the allowed amount. A TODO has been added to fix this issue. However this will hopefully not be a problem that pops up soon.
Also some minor docstring addition to Project Survey view.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 15:08:28 +0200] rev 2531
Refactored filter construction to _constructFilterForProjectSelection.
This allows Grading Project Survey to overwrite this method and create its own filter.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 14:29:13 +0200] rev 2530
Make sure that radio button questions validate correctly and allow only one choice.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 14:22:02 +0200] rev 2529
Added Daniel Diniz and Zachary Voase to the AUTHORS file.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 14:19:39 +0200] rev 2528
Added Daniel Diniz to authors for Grading Project Survey View.
Daniel Diniz <ajaksu@gmail.com> [Sat, 04 Jul 2009 14:15:11 +0200] rev 2527
Add a grade field to the Grading Project Survey form.
This also takes care of validating and transforming the data into True(pass) or False(fail). GradingProjectSurveys are hereby working for developers.
Reviewed by: Lennard de Rijk
James Levy <jamesalexanderlevy@gmail.com> [Sat, 04 Jul 2009 13:53:17 +0200] rev 2526
Survey editing/taking Javascript and CSS fixes.
This patch adds some cosmetic changes and functional fixes:
- UI now removes all of the field content when a field is deleted,
- CSS tweaks, and jQuery hack to specialize comment CSS,
- fixed JS path in take.html.
Reviewed by: Pawel Solyga (with some small changes)
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 04 Jul 2009 12:07:27 +0200] rev 2525
Remove public role type from SURVEY_TAKING_ACCESS in Survey model.
Sverre Rabbelier <sverre@rabbelier.nl> [Fri, 03 Jul 2009 20:41:19 -0700] rev 2524
try to fix the surveys-have-no-scope issue
to-be-reviewed: also untested
Sverre Rabbelier <sverre@rabbelier.nl> [Fri, 03 Jul 2009 18:39:17 -0700] rev 2523
addressed comments to previous version
to-be-reviewed: still untested
Sverre Rabbelier <sverre@rabbelier.nl> [Fri, 03 Jul 2009 18:24:02 -0700] rev 2522
return found entity for activity checks
Sverre Rabbelier <sverre@rabbelier.nl> [Fri, 03 Jul 2009 18:23:12 -0700] rev 2521
survey access: stylefix and remove public role type
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 22:36:10 +0200] rev 2520
Style fixes in Survey helper.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 22:27:42 +0200] rev 2519
Added _getSurveyTakeForm to the Survey view.
Subclasses can overwrite this method to create their own form. ProjectGradingSurvey will likely be an example for this.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 21:59:10 +0200] rev 2518
Only initialize a SurveyTakeForm in take instead of in takeGet and takePost.
This will allow for other subclassed views to easily replace the form the view is using.
Also small style fix in Survey helper.
Daniel Diniz <ajaksu@gmail.com> [Fri, 03 Jul 2009 21:06:22 +0200] rev 2517
Split SurveyForm into SurveyTakeForm and SurveyEditForm.
This allows for a more cleaner implementation of the Form code. And this will make it easier to break free from the getFields method in the future.
Also the getRoleSpecifcFields method and the this_user and project variables have been removed. They are deemed obsolete.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 20:38:43 +0200] rev 2516
Do not call takeGet when SurveyForm ValidationError occurs.
Problems occured when a SurveyRecord was specified in the SurveyForm. The SurveyRecord data reset the erroneous POST data. Further code reduction might be possible soonish.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 19:15:09 +0200] rev 2515
Several stylefixes due to received reviews.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 18:39:30 +0200] rev 2514
Style fixes in Access module.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 18:34:18 +0200] rev 2513
Style fixes to the GradingProjectSurvey View module.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 18:23:34 +0200] rev 2512
Sub_merge params for GradingProjectSurvey View.
James Levy <jamesalexanderlevy@gmail.com> [Fri, 03 Jul 2009 18:23:02 +0200] rev 2511
Added rudimentary grade field to GradingProjectSurvey take View.
Patch by: James Levy, Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 18:20:33 +0200] rev 2510
Ensure that the params from subclasses get merged properly with ProjectSurvey view.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 18:09:48 +0200] rev 2509
Corrected the links to Grading Project Surveys in Program menu.