Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Jul 2009 19:06:53 +0200] rev 2650
Fixed message on Records page for GradingSurveyGroups.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Jul 2009 18:44:33 +0200] rev 2649
Fixed issue where GradingSurveyRecords from another group could be edited.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Jul 2009 18:36:16 +0200] rev 2648
Added button to the GradingRecords overview to send mail when updating projects.
Note that this will mail all the projects for which a record is available.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Jul 2009 18:35:20 +0200] rev 2647
Added task to send out email for each processed GradingRecord.
If send_mail evaluates to True in the POST data for updateProjectsForSurveyGroup task then the results of every GradingRecord will be mailed to the Student. The Mentor and Org Admins will be cc'ed.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Jul 2009 18:28:33 +0200] rev 2646
Added mail template for when GradingRecords are proccessed.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Jul 2009 17:29:53 +0200] rev 2645
Made the reminder templates extend the mail base instead of notification.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Jul 2009 16:48:08 +0200] rev 2644
Added Task to process GradingRecords and update their StudentProjects.
An index for this operation is required and has been added to the index.yaml file.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Jul 2009 16:46:42 +0200] rev 2643
Added updateProjectsForGradingRecords to StudentProject Logic.
This method takes a list of record_entities, processes them and batch puts the update StudentProjects.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Jul 2009 15:17:10 +0200] rev 2642
Add new project status column to accepted students csv export.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Jul 2009 13:10:56 +0200] rev 2641
Added Student and Mentor link id to the GradingRecord list.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Jul 2009 00:55:05 +0200] rev 2640
Fixed an error occuring when assigning more then one secondary mentors.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 23:08:14 +0200] rev 2639
Withdrawn projects are removed from GradingRecord creation/update task.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 22:11:28 +0200] rev 2638
Changed tag for latest version to match the correct commit.
Sorry, somehow one file stayed behind :).
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 22:04:19 +0200] rev 2637
Excluded the new StudentProject failed_evaluations property from Forms.
(Something went wrong on my side this should have been in before the tag)
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 21:57:10 +0200] rev 2636
Added tag v0-5-20090713 for changeset 51d83d0572ec
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 21:56:53 +0200] rev 2635
Set new Melange version number to 0-5-20090713 in app.yaml.template.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 21:56:01 +0200] rev 2634
Added failed_evaluations property to StudentProject model.
This is used to store GradingRecords which state a fail for this project. It's a list because manual changes in GradingRecords might force multiple GradingRecords to state a fail. Also it needs to be clear which GradingRecords have been processed and with which grade_decision.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 18:04:10 +0200] rev 2633
Changed GradingRecord heading/row templates to give more useful info.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 12:52:54 +0200] rev 2632
Added view for editing GradingRecords.
This view shows a list of GradingRecords if the id param is not present in the GET data.
Also renamed grading_record to view_records and fixed the redirect for that page
to also point to the GradingRecord edit page.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 12:48:37 +0200] rev 2631
Fixed style error in GradingSurveyGroup Task model.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 12:48:05 +0200] rev 2630
Made the locked property non-required.
This makes it easier to generate a Form that can properly deal with GradingRecords. Since required boolean properties can only be set to true by such an automatically generated form.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 12:46:54 +0200] rev 2629
Added template for editing GradingRecords.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 11:12:42 +0200] rev 2628
Added getRecordLogic method to GradingSurveyGroup Logic.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 11:02:57 +0200] rev 2627
Added redirect for editing a GradingRecord.
The view for this will be added in a later commit.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 10:18:14 +0200] rev 2626
Fixed bug where grade_decision would not be properly set in 2 out of 4 cases.
Daniel Hans <Daniel.M.Hans@gmail.com> [Mon, 13 Jul 2009 11:43:40 +0200] rev 2625
Style fix in callback.py
dhans [Mon, 13 Jul 2009 11:19:55 +0200] rev 2624
Fixed issue with opening items on survey lists while pressing ctrl button
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 01:15:46 +0200] rev 2623
Added messages to the Records page when a task has been successfully started.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 01:07:18 +0200] rev 2622
Style fixes in GradingRecord Logic.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 01:07:03 +0200] rev 2621
Changed GradingRecord list templates to show more info.
They now show wether or not a Mentor/Student eval has been found.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 01:00:59 +0200] rev 2620
Added GradingSurveyGroup tasks to the core URL's.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 01:00:20 +0200] rev 2619
The buttons on the GradingSurveyGroup record page now enqueue Tasks.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 00:59:48 +0200] rev 2618
Added Tasks to update/create GradingRecords for a given GradingSurveyGroup.
Also added a stub to update StudentProjects for a given GradingSurveyGroup.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 00:59:11 +0200] rev 2617
Added methods to GradingRecord Logic to facilitate creating/updating them.
UpdateOrCreateRecordsFor will batch put GradingRecords for a given SurveyGroup and StudentProject.
getFieldsForGradingRecord will return the fields that need to be set for a single GradingRecord entity given a StudentProject, GradingSurveyGroup and if it is an update a GradingRecord entity.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Jul 2009 00:53:42 +0200] rev 2616
Added buttons to start tasks to GradingSurveyGroup Record view.
Also fixed an error in the GradingRecord row template.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 12 Jul 2009 22:25:43 +0200] rev 2615
Fixed errors in comments and docstring for the Surveys Task module.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 12 Jul 2009 22:00:12 +0200] rev 2614
Refactored logErrorAndReturnOK into separate module.
Augie Fackler <durin42@gmail.com> [Sun, 12 Jul 2009 11:46:36 -0500] rev 2613
buildout.cfg: We require nose as well for tests.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 12 Jul 2009 16:01:41 +0200] rev 2612
Added view to GradingSurveyGroup to list all records for a specified group.
This view will later be extended with options to start Tasks for collecting the data and processing it.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 12 Jul 2009 16:00:32 +0200] rev 2611
Added listing templates for GradingRecords.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 12 Jul 2009 14:03:35 +0200] rev 2610
Add scope view for GradingSurveyGroup and set access checks.
The access checks are now properly set for create, edit and show. To facilitate the scope view the access check have an extra check built in to ensure that a scope is actually present before cheking for an existing Program.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 12 Jul 2009 13:55:21 +0200] rev 2609
Fixed passing along empty params to scope selection view.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 12 Jul 2009 12:50:01 +0200] rev 2608
Renamed tag for latest version to match the app.yaml version entry.
Thanks to Madhusudan C.S. for noticing this.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 12 Jul 2009 00:45:45 +0200] rev 2607
Added tag 0-5-20090711p1 for changeset 03aa33e8600b
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 12 Jul 2009 00:45:01 +0200] rev 2606
Set new Melange version number to 0-5-20090711p1 in app.yaml.template.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 12 Jul 2009 00:40:24 +0200] rev 2605
Removed several sidebar entries for Surveys which where not properly working.
Sverre Rabbelier <sverre@rabbelier.nl> [Sat, 11 Jul 2009 15:05:02 -0700] rev 2604
Added tag v0-5-20090711 for changeset 4db295c3fbb3
Sverre Rabbelier <sverre@rabbelier.nl> [Sat, 11 Jul 2009 15:04:43 -0700] rev 2603
Set new Melange version number to 0-5-20090711 in app.yaml.template.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 12 Jul 2009 00:02:28 +0200] rev 2602
Fixed typo in ProjectSurvey reminder mail.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 11 Jul 2009 23:53:30 +0200] rev 2601
Fixed the redirect for Survey reminder emails.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 11 Jul 2009 23:38:37 +0200] rev 2600
Fixed typo in GradingProjectSurvey reminder email.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 11 Jul 2009 23:29:31 +0200] rev 2599
Add queue.yaml to build scripts.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 11 Jul 2009 23:29:22 +0200] rev 2598
Changed URL pattern for starting sending out survey reminders.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 11 Jul 2009 23:19:18 +0200] rev 2597
Added the Surveys Tasks to the registered URL patterns.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 11 Jul 2009 23:18:52 +0200] rev 2596
Added a view to start sending out a reminder.
Note that this view is currently developer-only.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 11 Jul 2009 23:18:14 +0200] rev 2595
Added Surveys Tasks module to send reminders.
All reminders are CC'ed to the org admins.
Also added an index property on StudentProjects which is required for the reminder Tasks.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 11 Jul 2009 23:15:22 +0200] rev 2594
Added empty Tasks package and queue.yaml.
Also reserved an admin only URL space for use by Tasks.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 11 Jul 2009 20:42:23 +0200] rev 2593
Edited help text to be more clear when a Survey has been submitted.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 11 Jul 2009 20:10:33 +0200] rev 2592
Add setOrganizationInSurveyRecords function to stats.py script.
setOrganizationInSurveyRecords will iterate thru all ProjectSurveyRecords and GradingProjectSurveyRecords and set the organization property in the record model.This will be useful later for showing Org admins their mentors and students surveys list and results.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 11 Jul 2009 19:54:23 +0200] rev 2591
Add Organization reference property to ProjectSurveyRecord.
Also update ProjectSurvey view _takePost method to set this property everytime survey is taken.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 11 Jul 2009 19:37:26 +0200] rev 2590
Fix indention and add missing dot in docstring in survey models.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 11 Jul 2009 17:25:19 +0200] rev 2589
GradingSurveyGroup now uses DynaForm for its forms.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 11 Jul 2009 13:56:55 +0200] rev 2588
Indention fixes and adding "reference_class=" in ReferenceProperty params.
Augie Fackler <durin42@gmail.com> [Tue, 07 Jul 2009 20:17:23 -0500] rev 2587
Start using buildout to bring in external dependencies.
This makes running tests easier in situations where dependencies are not always available, such as buildbot.
Thanks to Matthew Wilkes <matthew@matthewwilkes.co.uk> for help and moral support.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 10 Jul 2009 12:09:09 +0200] rev 2586
Added GradingSurveyGroup to the sitemap and sidebar.
Daniel Diniz <ajaksu@gmail.com> [Fri, 10 Jul 2009 12:06:29 +0200] rev 2585
Completed the Create and Edit view for GradingSurveyGroup.
Note that I've added a TODO to redo _editPost to give us kwargs. Would also get rid of hidden fields elsewhere.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 10 Jul 2009 11:59:00 +0200] rev 2584
Fixed GradingRecord and GradingSurveyRecord Logic to load the correct Model.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 10 Jul 2009 11:39:41 +0200] rev 2583
Added denySidebar to several access checks.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 09 Jul 2009 23:50:21 +0200] rev 2582
Added Surveys to sidebar menu.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 09 Jul 2009 14:00:59 +0200] rev 2581
Changed title entry in GradingSurveyGroup's public template to name.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 09 Jul 2009 11:52:35 +0200] rev 2580
Added skeleton view and templates for GradingSurveyGroup.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 09 Jul 2009 11:47:31 +0200] rev 2579
Added name property to GradingSurveyGroup.
This can be used (by humans :D) to easily identify different instances of this model.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 09 Jul 2009 11:00:17 +0200] rev 2578
Added missing blank line to GradingSurveyGroup logic.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 09 Jul 2009 10:52:19 +0200] rev 2577
Added logic for GradingRecord and GradingSurveyGroup.
Daniel Diniz <ajaksu@gmail.com> [Thu, 09 Jul 2009 10:39:30 +0200] rev 2576
Removed results list from Survey edit.
Some changes to the Survey Result page have also been made, however the results viewer and the CSV export are not working properly in that View.
Reviewd by: Lennard de Rijk
Mario Ferraro <fadinlight@gmail.com> [Thu, 09 Jul 2009 10:16:29 +0200] rev 2575
Extended tooltip timeout to 10 seconds for all fields.
This is because the tooltip currently timesout to fast for people to read the whole stories they can contain. Especially because Surveys can have custom tooltips.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 08 Jul 2009 15:45:53 +0200] rev 2574
Minor stylefix to StudentProject model.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 08 Jul 2009 15:44:54 +0200] rev 2573
Changed the StudentProject model to handle a dynamic amount of GradeRecords.
This allows for a dynamic amount of moments where a StudentProject can be evaluated.
Also included in this patch are changes to the status property that will help to enable PA's to withdraw StudentProjects from the program without the need for a developer to step in.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 08 Jul 2009 11:50:02 +0200] rev 2572
Renamed several files due to recent changes.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 08 Jul 2009 10:45:49 +0200] rev 2571
Style fixing in GradeRecord model
Daniel Diniz <ajaksu@gmail.com> [Wed, 08 Jul 2009 10:40:46 +0200] rev 2570
Several Survey UI fixes.
Fixes:
Too narrow fieldsets in new question/option dialogs.
Survey submit (on take view) and save/export/etc. buttons at weird places, instead of at bottom.
Weird placement of radio buttons in Opera.
Too narrow selects in IE.
Broken images in edit view in IE and Opera.
Reviewed by: Lennard de Rijk (Only on IE)
Madhusudan C.S. <madhusudancs@gmail.com> [Tue, 07 Jul 2009 21:16:57 +0200] rev 2569
Fixed base template URL to tagged version of the deployed source code.
The old link revered to SVN based projects.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 07 Jul 2009 20:02:27 +0200] rev 2568
Fixed imports for Survey logic.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 07 Jul 2009 18:46:47 +0200] rev 2567
Added skeleton models for GradingSurveyGroup and Records.
SurveyRecordGroup has been renamed to GradingRecord.
GradingSurveyGroup will hold which Surveys should be linked. While the acompanying GradingRecords (with their reference to a GradingSurveyGroup) will hold the Records for each StudentProject that can take these Surveys.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 06 Jul 2009 17:20:30 +0200] rev 2566
Added tag v0-5-20090706 for changeset c17b671e5657
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 06 Jul 2009 17:19:57 +0200] rev 2565
Set new Melange version number to 0-5-20090706 in app.yaml.template.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 06 Jul 2009 17:18:41 +0200] rev 2564
Ensure that the Grade field data stays in clean_data.
This prevents a bug that happens when you pick an invalid entry in the choice a grade field. If this bug was triggered the value of the survey_record.grade was used. Now however a proper ValidationError is raised.
Daniel Diniz <ajaksu@gmail.com> [Mon, 06 Jul 2009 17:03:19 +0200] rev 2563
Add missing import to Project Survey view.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 06 Jul 2009 16:32:14 +0200] rev 2562
Renamed several files due to recent changes.
Mario Ferraro <fadinlight@gmail.com> [Mon, 06 Jul 2009 16:21:51 +0200] rev 2561
Now properly escaping JS and converting new lines into br for Tooltips.
Patch by: Mario Ferraro, Lennard de Rijk
Daniel Diniz <ajaksu@gmail.com> [Mon, 06 Jul 2009 16:13:27 +0200] rev 2560
Added ability to add custom tooltips and UI improvements.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 06 Jul 2009 15:06:05 +0200] rev 2559
Public Survey template now resembles the take template more closely.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 06 Jul 2009 14:58:46 +0200] rev 2558
Added the possiblitity to add a description to the top of the Survey.
Thie uses the content property which has been inherited from the Work model.
James Levy <jamesalexanderlevy@gmail.com> [Mon, 06 Jul 2009 13:19:00 +0200] rev 2557
Use CSS instead of JS for Survey layout.
Reviewed by: Lennard de Rijk
Daniel Diniz <ajaksu@gmail.com> [Mon, 06 Jul 2009 12:06:28 +0200] rev 2556
Remove the custom propmpt inside textareas and input fields.
This will hopefully be replaced with custom tooltips. Two reasons for this are that the tooltips will still be readable once your start typing and this way we avoid a bug that caused a textarea to go into prompt mode on some form validation errors.
Reviewed by: Lennard de Rijk
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 06 Jul 2009 00:54:48 +0200] rev 2555
Fix HtmlSanitizer to return cleaned string in proper encoding.
This fix prevent HtmlSanitizer from throwing UnicodeDecodeError exception.
James Levy <jamesalexanderlevy@gmail.com [Mon, 06 Jul 2009 00:31:48 +0200] rev 2554
Added clear:right property to submit button in Survey take form.
Reviewed by: Lennard de Rijk
Mario Ferraro <fadinlight@gmail.com [Mon, 06 Jul 2009 00:29:30 +0200] rev 2553
Fix button layout on Safari 4.0 for Survey take page.
Reviewed by: Lennard de Rijk
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 06 Jul 2009 00:16:47 +0200] rev 2552
Fix comment indention in survey-take javascript file.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 05 Jul 2009 23:45:57 +0200] rev 2551
Renamed survey-take-090627.js to survey-take-090705.js.
James Levy <jamesalexanderlevy@gmail.com> [Sun, 05 Jul 2009 23:43:57 +0200] rev 2550
Increased bottom margin on comments for better grouping.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 05 Jul 2009 13:31:34 +0200] rev 2549
Changed the filter for getting a SurveyRecord for a ProjectSurvey
ProjectSurveyRecords are characterized by the Survey and a Project entity. The user property is just there to state who last submitted the Survey.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 05 Jul 2009 13:00:08 +0200] rev 2548
Added tag v0-5-20090705p1 for changeset c7726e3ab173
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 05 Jul 2009 12:59:33 +0200] rev 2547
Set new Melange version number to 0-5-20090705p1 in app.yaml.template.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 05 Jul 2009 12:57:09 +0200] rev 2546
Ensure that accessViolations for Survey menu items get captured.
(Also ensure that you think before committing something you broke yourself :()
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 05 Jul 2009 12:19:19 +0200] rev 2545
Added tag v0-5-20090705 for changeset 8f3a8e066111
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 05 Jul 2009 12:18:31 +0200] rev 2544
Set new Melange version number to 0-5-20090705 in app.yaml.template.
James Levy <jamesalexanderlevy@gmail.com> [Sun, 05 Jul 2009 11:32:26 +0200] rev 2543
Added Menu items for all three kinds of Surveys to the program menu.
The menu items turn red when the user has not taken the Survey yet.
Patch by: James Levy, Lennard de Rijk
Reviewed by: to-be-reviewed
Daniel Diniz <ajaksu@gmail.com> [Sun, 05 Jul 2009 00:57:03 +0200] rev 2542
POST data always overwrites survey_record data when used to populate form.
It also fixes validation errors on takeGet.
Patch by: Daniel Diniz, Lennard de Rijk
Reviewed by: to-be-reviewed
Mario Ferraro <fadinlight@gmail.com> [Sat, 04 Jul 2009 18:48:58 +0100] rev 2541
Fixes bug when option name contains double quotes.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 18:53:37 +0200] rev 2540
Several style fixes due to code reviews.
Daniel Diniz <ajaksu@gmail.com> [Sat, 04 Jul 2009 17:23:19 +0200] rev 2539
Ensure that long questions and comments are stored as db.Text.
This is done by adding the setCleaners methods which sets the appropriate cleaners for dynamic fields.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 17:16:16 +0200] rev 2538
Style fix in access module.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 17:02:51 +0200] rev 2537
Returned ProjectSurvey create to checkIsUser.
The access protection is properly done by the form validator.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 16:44:08 +0200] rev 2536
Added access checks for taking a Project(Grading)Survey.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 16:23:00 +0200] rev 2535
Brown paper bag fix for using non-existing logic in ProjectSurvey views.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 15:59:19 +0200] rev 2534
Fixed basic Survey access check.
Also enabled this check for all relevant Views. However ProjectSurveys and subclasses still need an additional check. A stub for this has been added to the access module.
Daniel Diniz <ajaksu@gmail.com> [Sat, 04 Jul 2009 15:30:08 +0200] rev 2533
Fixed broken selection questions from refactoring SurveyForm.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 15:16:54 +0200] rev 2532
Fixed showing the correct list of projects for taking a Grading Project Survey.
Note that when a user is a mentor for a lot of Organizations the amount of subqueries might exceed the allowed amount. A TODO has been added to fix this issue. However this will hopefully not be a problem that pops up soon.
Also some minor docstring addition to Project Survey view.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 15:08:28 +0200] rev 2531
Refactored filter construction to _constructFilterForProjectSelection.
This allows Grading Project Survey to overwrite this method and create its own filter.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 14:29:13 +0200] rev 2530
Make sure that radio button questions validate correctly and allow only one choice.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 14:22:02 +0200] rev 2529
Added Daniel Diniz and Zachary Voase to the AUTHORS file.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 14:19:39 +0200] rev 2528
Added Daniel Diniz to authors for Grading Project Survey View.
Daniel Diniz <ajaksu@gmail.com> [Sat, 04 Jul 2009 14:15:11 +0200] rev 2527
Add a grade field to the Grading Project Survey form.
This also takes care of validating and transforming the data into True(pass) or False(fail). GradingProjectSurveys are hereby working for developers.
Reviewed by: Lennard de Rijk
James Levy <jamesalexanderlevy@gmail.com> [Sat, 04 Jul 2009 13:53:17 +0200] rev 2526
Survey editing/taking Javascript and CSS fixes.
This patch adds some cosmetic changes and functional fixes:
- UI now removes all of the field content when a field is deleted,
- CSS tweaks, and jQuery hack to specialize comment CSS,
- fixed JS path in take.html.
Reviewed by: Pawel Solyga (with some small changes)
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 04 Jul 2009 12:07:27 +0200] rev 2525
Remove public role type from SURVEY_TAKING_ACCESS in Survey model.
Sverre Rabbelier <sverre@rabbelier.nl> [Fri, 03 Jul 2009 20:41:19 -0700] rev 2524
try to fix the surveys-have-no-scope issue
to-be-reviewed: also untested
Sverre Rabbelier <sverre@rabbelier.nl> [Fri, 03 Jul 2009 18:39:17 -0700] rev 2523
addressed comments to previous version
to-be-reviewed: still untested
Sverre Rabbelier <sverre@rabbelier.nl> [Fri, 03 Jul 2009 18:24:02 -0700] rev 2522
return found entity for activity checks
Sverre Rabbelier <sverre@rabbelier.nl> [Fri, 03 Jul 2009 18:23:12 -0700] rev 2521
survey access: stylefix and remove public role type
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 22:36:10 +0200] rev 2520
Style fixes in Survey helper.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 22:27:42 +0200] rev 2519
Added _getSurveyTakeForm to the Survey view.
Subclasses can overwrite this method to create their own form. ProjectGradingSurvey will likely be an example for this.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 21:59:10 +0200] rev 2518
Only initialize a SurveyTakeForm in take instead of in takeGet and takePost.
This will allow for other subclassed views to easily replace the form the view is using.
Also small style fix in Survey helper.
Daniel Diniz <ajaksu@gmail.com> [Fri, 03 Jul 2009 21:06:22 +0200] rev 2517
Split SurveyForm into SurveyTakeForm and SurveyEditForm.
This allows for a more cleaner implementation of the Form code. And this will make it easier to break free from the getFields method in the future.
Also the getRoleSpecifcFields method and the this_user and project variables have been removed. They are deemed obsolete.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 20:38:43 +0200] rev 2516
Do not call takeGet when SurveyForm ValidationError occurs.
Problems occured when a SurveyRecord was specified in the SurveyForm. The SurveyRecord data reset the erroneous POST data. Further code reduction might be possible soonish.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 19:15:09 +0200] rev 2515
Several stylefixes due to received reviews.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 18:39:30 +0200] rev 2514
Style fixes in Access module.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 18:34:18 +0200] rev 2513
Style fixes to the GradingProjectSurvey View module.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 18:23:34 +0200] rev 2512
Sub_merge params for GradingProjectSurvey View.
James Levy <jamesalexanderlevy@gmail.com> [Fri, 03 Jul 2009 18:23:02 +0200] rev 2511
Added rudimentary grade field to GradingProjectSurvey take View.
Patch by: James Levy, Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 18:20:33 +0200] rev 2510
Ensure that the params from subclasses get merged properly with ProjectSurvey view.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 18:09:48 +0200] rev 2509
Corrected the links to Grading Project Surveys in Program menu.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 17:55:36 +0200] rev 2508
Added missing import to ProjectSurvey View.
Daniel Diniz <ajaksu@gmail.com> [Fri, 03 Jul 2009 15:21:44 +0200] rev 2507
Fix pick_multi only returning one answer as maximum.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 15:00:00 +0200] rev 2506
Removed getSurveyResponseFromPost from Surveys helper.
We will use the power of Django Forms instead of getting our own properties. This fits better into the rest of Melange which also uses this approach.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 14:53:26 +0200] rev 2505
Renamed survey-edit-090627.js due to recent changes.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 14:43:49 +0200] rev 2504
Form errors when taking a Survey now have the correct context.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 14:36:16 +0200] rev 2503
Fixed Survey Form error giving 505.
I failed when changing the system to work with collectCleanedFields.
Daniel Diniz <ajaksu@gmail.com> [Fri, 03 Jul 2009 14:35:03 +0200] rev 2502
Surveys can now have required questions and comments can be turned on/off.
Storing comments is now working. However some issues arise when form errors occur, like missing context and the errors also trigger before a form has been submitted.
Reviewed by: Lennard de Rijk
Daniel Diniz <ajaksu@gmail.com> [Fri, 03 Jul 2009 14:19:23 +0200] rev 2501
Added Survey From Field validation.
Also added the COMMENT_PREFIX in Survey model to ensure that comments are stored in the same way everwhere.
Reviewed by: Lennard de Rijk
Daniel Diniz <ajaksu@gmail.com> [Fri, 03 Jul 2009 12:10:24 +0200] rev 2500
Style fixes and a forgotten parameter in Survey(Record) logic.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 12:05:23 +0200] rev 2499
Removed unnecessary variable in ProjectSurvey take method.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 12:02:57 +0200] rev 2498
Overwrite _getSurveyRecordFor in ProjectSurvey view to take StudentProject into account.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 12:00:53 +0200] rev 2497
Added _getSurveyRecordFor method to Survey View.
This method is used by the Take view to get the right SurveyRecord for the current request. Subclassed Views that want to fetch their records in another way can override this method.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 02 Jul 2009 18:35:57 +0200] rev 2496
Added default Survey list templates for ProjectSurvey and GradingProjectSurvey.
Daniel Diniz <ajaksu@gmail.com> [Thu, 02 Jul 2009 18:33:13 +0200] rev 2495
Enable the ProjectSurvey and GradingProjectSurvey views in the core.
Also add menu items to the program menu for easy access to these options.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 02 Jul 2009 17:51:07 +0200] rev 2494
Implemented taking ProjectSurveys.
The user will first be served a list of all eligble StudentProjects for which the ProjectSurvey can be taken. After clicking on the list the key_name of the project is attached as a GET param and the code uses the normal take view with the hooks to let everything run smoothly.
An extra access check method is required which checks if the Project mentioned in the GET param is a valid project for the current user. This check will run together with the isSurveyTakable checker.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 02 Jul 2009 17:47:24 +0200] rev 2493
Edit SurveyRecord model to not make use of different Survey property for each subclass.
This does mean that a simple query needs to be constructed by hand whenever you want to query for every SurveyRecord for a specific Survey. However the naming is now the same over each SurveyRecord and it fits well into the rest of the design of Melange.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 02 Jul 2009 17:08:10 +0200] rev 2492
Made the CSV exporter for Survey not rely on the BackReferenceProperty in Survey.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 02 Jul 2009 16:53:13 +0200] rev 2491
Added getTakeProjectSurveyRedirect.
This redirect is used when taking a ProjectSurvey.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 02 Jul 2009 16:51:31 +0200] rev 2490
Added the possibility to change the action of the form on the Survey take page.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 02 Jul 2009 16:50:08 +0200] rev 2489
Small style fix in Surveys helper.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 02 Jul 2009 15:40:37 +0200] rev 2488
Set required is True for StudentProject reference in ProjectSurveyRecord.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 02 Jul 2009 15:38:33 +0200] rev 2487
Removed obsolete if tag form take template.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 02 Jul 2009 15:34:02 +0200] rev 2486
Added hook methods to takeGet and takePost.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 02 Jul 2009 14:48:10 +0200] rev 2485
Fixed typo in title of Survey Take page.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 02 Jul 2009 12:46:12 +0200] rev 2484
Add a base implementation of takePost.
Normal Surveys can now be taken, however comments are not stored yet.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 02 Jul 2009 12:45:06 +0200] rev 2483
Added getSurveyResponseFromPost method to Surveys Helper.
This method will be used to read the POST dictionary from a request. And will transform it into the fields that need to be set in a SurveyRecord for the questions specified by the given Survey.
A TODO has been added to handle the naming/handling of the comment fields.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 02 Jul 2009 12:43:06 +0200] rev 2482
Added updateOrCreateFromFields method to SurveyRecordLogic.
The reading of the fields from the POST request will not happen in this Logic anymore.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 02 Jul 2009 12:40:42 +0200] rev 2481
Added base class logic for Expando based models.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 02 Jul 2009 11:25:52 +0200] rev 2480
Removed two obsolete/outdated methods in Survey Logic.
The updateSurveyRecord can be found in the SurveyRecord logic.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 02 Jul 2009 10:46:39 +0200] rev 2479
Removed obsolote method call in Program View.
Daniel Diniz <ajaksu@gmail.com> [Thu, 02 Jul 2009 10:33:58 +0200] rev 2478
Clean up and other fixes for Survey modules.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 01 Jul 2009 21:53:20 +0200] rev 2477
Implemented the takeGet view for Surveys.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 01 Jul 2009 17:28:44 +0200] rev 2476
Fixed multiple typos in Survey tooltips strings.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 01 Jul 2009 17:25:54 +0200] rev 2475
Added skeleton for the take view and its template.
Also fixed the sorting of imports of the Survey View.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 01 Jul 2009 16:28:27 +0200] rev 2474
Move getMenusForScope to the end of the View class.
Adhering to our principle that we the methods we use for generating our menus can be usually found at the bottom of the View class.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 01 Jul 2009 16:22:35 +0200] rev 2473
Changed the Survey public view to give a preview of the Survey.
Also changed the access rights for deleting a Survey because of the possible invalid references problem.
Added two TODO's to the _public method. The first one involves enabling the SurveyForm to generate a form without passing along the Logic since it is only used to retrieve the Survey entity which we already have available. The second one involves a brief discussion about the getFields method's functionality and name.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 01 Jul 2009 14:49:54 +0200] rev 2472
Removed activate grade URL pattern from Survey View.
The remaining methods will be ported over in a patch from Ajaksu.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 01 Jul 2009 14:42:54 +0200] rev 2471
Brown paper bag "without tea" morning typo fix in Survey View.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 01 Jul 2009 14:28:51 +0200] rev 2470
Style fix in Survey views helper.
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 01 Jul 2009 08:29:49 +0200] rev 2469
Returned access checks in Survey View to the right state.
This got bugged in James's commt.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 30 Jun 2009 18:16:33 +0200] rev 2468
Fixed too long line in Surveys helper.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 30 Jun 2009 18:02:10 +0200] rev 2467
Solved some merging problems and use the getRecordLogic where needed.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 30 Jun 2009 17:55:43 +0200] rev 2466
Reverted some changes in SurveyLogic.
SurveyRecord logic is defined in its own module.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 30 Jun 2009 15:58:56 +0200] rev 2465
Use an existing logic for showing Survey Results.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 30 Jun 2009 14:56:48 +0200] rev 2464
Merge params from inheriting Survey views so functionality can be reused.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 30 Jun 2009 14:55:55 +0200] rev 2463
Add more flexibility to the Survey helper for use with the new Survey types.
This includes using the new SurveyLogic methods from an earlier commit. And passing on the Logic from the view where necessary.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 30 Jun 2009 14:45:11 +0200] rev 2462
Added getRecordLogic method to SurveyLogic.
This is used to retrieve the SurveyRecordLogic that belongs to a certain SurveyLogic.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 30 Jun 2009 08:54:39 +0200] rev 2461
Removed setting of the scope in the ProjectSurvey init.
This is because it is not possible to query for another entity outside your entity group in the __init__ fucntion.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 30 Jun 2009 08:50:56 +0200] rev 2460
Added getSurveyForContent method to SurveyLogic.
This method returns a Survey for a given content. The backreferenceproperty will not work because of inheritance.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 30 Jun 2009 08:49:34 +0200] rev 2459
Calling the correct super in Project and Grading Survey Logic.
james@jamess-macbook-air.local [Tue, 30 Jun 2009 03:03:46 -0700] rev 2458
merged upstream
Zachary Voase <disturbyte@googlemail.com> [Tue, 30 Jun 2009 10:59:05 +0200] rev 2457
Add paver script that will replace our current build.sh from scripts folder.
Until I update the wiki to describe how this new paver build script works I'm leaving the old one in the repository.
Reviewed by: Pawel Solyga
Sverre Rabbelier <sverre@rabbelier.nl> [Mon, 29 Jun 2009 23:19:49 -0700] rev 2456
Add checkHasSurveyAccess access check
To-be-reviewed, untested code
james@jamess-macbook-air.local [Tue, 30 Jun 2009 03:02:53 -0700] rev 2455
fixed critical errors related to survey subclassing and renaming of deadline and opening properties, and surveys in sidebar are now marked as such and have a red color if untaken
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 30 Jun 2009 00:06:53 +0200] rev 2454
Removed survey_kind from Survey model.
The inheritance structure should make this obsolete.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 29 Jun 2009 23:40:24 +0200] rev 2453
Set the correct base_model and scope_logic for extended Survey logic.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 29 Jun 2009 23:16:21 +0200] rev 2452
Added two missing imports to the Project and Grading Surveys views.
Daniel Diniz <ajaksu@gmail.com> [Mon, 29 Jun 2009 19:29:15 +0200] rev 2451
Added SurveyContentSchema to improve readability for the survey helper.
Reviewed by: Lennard de Rijk
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 29 Jun 2009 16:51:48 +0200] rev 2450
Added tag v0-5-20090629 for changeset 0dee663d6582
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 29 Jun 2009 16:50:38 +0200] rev 2449
et new Melange version number to 0-5-20090629 in app.yaml.template.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 29 Jun 2009 15:53:50 +0200] rev 2448
Added skeleton view for ProjectSurvey and GradingProjectSurvey.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 29 Jun 2009 15:44:33 +0200] rev 2447
Prepared Survey access controls to deal with multiple logics.
Also added a TODO to move a method to another view.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 29 Jun 2009 15:19:28 +0200] rev 2446
Extracted the ProjectSurvey and ProjectGradingSurvey records to a new module.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 29 Jun 2009 14:06:30 +0200] rev 2445
Removed unused import from Survey model.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 29 Jun 2009 14:01:24 +0200] rev 2444
Separated two survey types out of the main survey model.
These models are ProjectSurvey and GradingProjectSurvey.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 29 Jun 2009 13:50:03 +0200] rev 2443
Seperated Logic for ProjectSurvey and GradingProject surveys.
These changes also include their respective records.
Daniel Diniz <ajaksu@gmail.com> [Sun, 28 Jun 2009 23:58:03 +0200] rev 2442
Start on adding ProjectSurvey and GradingProjectSurvey.
New classes still need to be made for logic and views so the appropriate methods can be overwritten.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 28 Jun 2009 22:12:33 +0200] rev 2441
Added .settings to hgignore.
Eclipse IDE uses this map to store some settings. Since this is widely used I decided to add it to the ignore list.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 28 Jun 2009 17:53:58 +0200] rev 2440
Renamed opening to survey_start and deadline to survey_end.
Symmetry seems to be both pleasing and helpful when understanding the code.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 28 Jun 2009 17:44:44 +0200] rev 2439
Put ResultsLogic in its own Logic module named survey_record.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 28 Jun 2009 14:55:47 +0200] rev 2438
Removed non-existing import in Survey Logic.
James don't get ahead of yourself :D.
Daniel Diniz <ajaksu@gmail.com> [Sun, 28 Jun 2009 14:49:39 +0200] rev 2437
Added Survey menu items to the Program menu.
Patch by: Daniel Diniz
Reviewed by: Lennard de Rijk
Daniel Diniz <ajaksu@gmail.com> [Sun, 28 Jun 2009 14:48:19 +0200] rev 2436
Added Surveys to the sitemap.
Patch by: Daniel Diniz
Reviewed by: Lennard de Rijk
James Levy <jamesalexanderlevy@gmail.com> [Sun, 28 Jun 2009 14:46:31 +0200] rev 2435
Added View for Surveys.
Patch by: James Levy, Daniel Diniz
Reviewed by: to-be-reviewed
Daniel Diniz <ajaksu@gmail.com> [Sun, 28 Jun 2009 14:45:08 +0200] rev 2434
Added redirect for use in Surveys.
Also some minor style changes.
Patch by: Daniel Diniz
Reviewed by: Lennard de Rijk
Daniel Diniz <ajaksu@gmail.com> [Sun, 28 Jun 2009 14:40:55 +0200] rev 2433
Added Access checks for Surveys.
Patch by: Daniel Diniz, James Levy
Reviewed by: Lennard de Rijk
James Levy <jamesalexanderlevy@gmail.com> [Sun, 28 Jun 2009 14:32:21 +0200] rev 2432
Added Survey Views Helper for rendering several widgets.
Patch by: James Levy, Daniel Diniz, Lennard de Rijk
Reviewed by: Lennard de Rijk
James Levy <jamesalexanderlevy@gmail.com> [Sun, 28 Jun 2009 14:18:01 +0200] rev 2431
Added logic for Survey and SurveyRecord.
The logic for the SurveyRecord will be seperated within the upcoming days.
Patch by: James Levy, Daniel Diniz, Lennard de Rijk
Reviewed by: Lennard de Rijk
James Levy <jamesalexanderlevy@gmail.com> [Sun, 28 Jun 2009 13:18:56 +0200] rev 2430
Added SurveyRecordGroup for the use in evaluation surveys.
Patch by: James Levy, Daniel Diniz
Reviewed by: Lennard de Rijk
James Levy <jamesalexanderlevy@gmail.com> [Sun, 28 Jun 2009 13:13:58 +0200] rev 2429
Added SurveyRecordModel.
Lennard: On top of the orginial patch I've added several comments to the fields and two TODO's for further subclassing.
Patch by: James Levy, Daniel Diniz, Lennard de Rijk
Reviewed by: Lennard de Rijk
James Levy <jamesalexanderlevy@gmail.com> [Sun, 28 Jun 2009 13:07:18 +0200] rev 2428
Added Survey and SurveyContent model.
They are currently located in a single file this can be undone later on.
Patch by: James Levy, Daniel Diniz, Lennard de Rijk
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 27 Jun 2009 22:11:48 +0200] rev 2427
Fixed docstring in Document Logic.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 27 Jun 2009 09:42:32 +0200] rev 2426
Renamed css due to previous changes in previous commit.
Daniel Diniz <ajaksu@gmail.com> [Sat, 27 Jun 2009 09:39:01 +0200] rev 2425
Edited stylesheet for use in Surveys.
Patch by: Daniel Diniz, James Levy
Reviewed by: Mario Ferraro
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 27 Jun 2009 09:36:54 +0200] rev 2424
Renamed JavaScript files in templates to match the correct files using prefixes.
Daniel Diniz <ajaksu@gmail.com> [Sat, 27 Jun 2009 09:35:50 +0200] rev 2423
Adding JS files for use in Surveys.
Patch by: Daniel Diniz, James Levy
Reviewed by: Mario Ferraro
Daniel Diniz <ajaksu@gmail.com> [Fri, 26 Jun 2009 21:58:12 +0200] rev 2422
Added templates considering Surveys.
Patch by: Daniel Diniz, James Levy
Reviewed by: Lennard de Rijk
Daniel Diniz <ajaksu@gmail.com> [Fri, 26 Jun 2009 21:54:46 +0200] rev 2421
Renamed jquery.growfield.js to jquery-growfield.js.
Reviewed by: Lennard de Rijk
Daniel Diniz <ajaksu@gmail.com> [Tue, 23 Jun 2009 20:54:03 +0200] rev 2420
Patch that adds the JS and CSS files for surveys.
The only update is in app/jquery/jquery-ui.core.js, from a non-release
(added by Paweł for the date picker) to a slightly updated released
version.
Reviewed by: Lennard de Rijk, Mario Ferraro
Patch by: Daniel Diniz, James Levy
Daniel Diniz <ajaksu@gmail.com> [Tue, 23 Jun 2009 20:43:22 +0200] rev 2419
Patch that touches 'upstream' templates, for use in surveys.
Consists out of three changes.
1 - Move the </head> placement in base.hmtl to after the closing of
scripts_block, so templates that extend base.html can add scripts to
the <head>.
2 - Add tooltips for checkboxes inside fieldsets.
3 - Comment out an empty table row in templatetags/_as_table.html,
which probably has an arcane reason to stay empty :)
Reviewed by: Lennard de Rijk, Pawel Solyga
Patch by: Daniel Diniz, James Levy
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 22 Jun 2009 07:32:45 +0200] rev 2418
Fixes an issue where the organization home page would throw a 505 when no projects where accepted.
This only happens after the project announced deadline because only then would the project list be constructed.
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 21 Jun 2009 18:27:30 +0200] rev 2417
Added tag v0-5-20090621 for changeset 96ff51144dca
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 21 Jun 2009 18:22:02 +0200] rev 2416
Set new Melange version number to 0-5-20090621 in app.yaml.template
Mario Ferraro <fadinlight@gmail.com> [Fri, 19 Jun 2009 23:13:06 +0100] rev 2415
jQuery Spin plugin updated to version 1.1.1
Former version had a bug if max was not specified
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 19 Jun 2009 20:19:03 +0200] rev 2414
Use build-in django 1.0.x on deployed version of Melange.
Using SDK (Development server) right now we are still using django.zip when running from build folder and django folder when running from app folder. django.zip file is still uploaded when deploying the app but it's not used. We might totally get rid of django folder and django.zip soon (discussion needed).
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 19 Jun 2009 16:13:32 +0200] rev 2413
Update GAE to 1.2.3 in thirdparty folder.
Sverre Rabbelier <sverre@rabbelier.nl> [Mon, 08 Jun 2009 22:34:05 +0200] rev 2412
Added tag v0-5-20090608 for changeset 19e9fdde919e
Sverre Rabbelier <sverre@rabbelier.nl> [Mon, 08 Jun 2009 22:31:28 +0200] rev 2411
Set new Melange version number to 0-5-20090604 in app.yaml.template
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 08 Jun 2009 22:28:17 +0200] rev 2410
Temporary fix for Issue 636 by turning off the caching of the page's entities.
This also means that pagination is turned back on because querying all 1000 projects every time will take too long.
Sverre Rabbelier <sverre@rabbelier.nl> [Mon, 08 Jun 2009 21:57:12 +0200] rev 2409
fix copy/paste fail in homepage caching
Madhusudan C.S. <madhusudancs@gmail.com> [Mon, 08 Jun 2009 08:54:21 +0200] rev 2408
Added group attribute to each GHOPProgram property so it is grouped on edit/create forms.
Added 3 new groups, "Contest Rules" group, "Prize Information" group and
"Task Settings" group to organize the properties in a useful manner on the edit/create forms.
Reviewed by: Lennard de Rijk
Madhusudan C.S. <madhusudancs@gmail.com> [Mon, 08 Jun 2009 08:48:24 +0200] rev 2407
Changed GHOP module imports to be consistent with rest of Melange code.
The imports used the from <module-path> import <module> as <local_module_name>
syntax. These kinds of imports are changed to import <module_path.module_name>
syntax to be consistent with the Melange code base.
Reviewed by: Lennard de Rijk
Madhusudan C.S. <madhusudancs@gmail.com> [Mon, 08 Jun 2009 08:42:13 +0200] rev 2406
Changed the property that holds the minimum age required for Students to participate in a GHOP based program.
Added a new property student_min_age_as_of to hold the DateTime from when the minimum age should be reached. Changed student_min_age property to now store the student minimum age as an integer.
This all feel more user friendly then letting the program admin calculate the required DateTime. Storing the two properties is then still needed in this case since information might be lost otherwise when the program admin brings up the edit view.
Reviewed by: Lennard de Rijk
Sverre Rabbelier <sverre@rabbelier.nl> [Sat, 06 Jun 2009 20:40:08 +0200] rev 2405
Remove now unneeded getCallback from ghop.__init__
Sverre Rabbelier <sverre@rabbelier.nl> [Sat, 06 Jun 2009 20:29:09 +0200] rev 2404
Remove getCallback indirection in modules
Instead, assume that the imported module contains the Callback class
that was previously returned by getCallback. This is done to prevent
a circular import (caused by the __init__ importing a submodule).
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 06 Jun 2009 19:42:54 +0200] rev 2403
Removed authors from 'empty' __init__.py files.
Augie Fackler <durin42@gmail.com> [Sat, 06 Jun 2009 10:30:56 -0500] rev 2402
Add HTTP_HOST to environ variables mocked. Also add license headers to run.py.
Madhusudan C.S. <madhusudancs@gmail.com> [Sat, 06 Jun 2009 17:28:56 +0200] rev 2401
Added logic for every GHOP specific model.
Defined logic for every model defined for GHOP. These logics do nothing special
now. They are just inherited from their parent classes. Necessary GHOP specific
logic will be added later as necessary.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 06 Jun 2009 17:16:52 +0200] rev 2400
Added licenses and fixed the authors of __init__.py for the GHOP module.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 05 Jun 2009 22:54:19 +0200] rev 2399
Changed imports in models to comply with recent GHOP code move.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 05 Jun 2009 22:07:15 +0200] rev 2398
Removed unused import.
Madhusudan C.S. <madhusudancs@gmail.com> [Fri, 05 Jun 2009 21:27:03 +0200] rev 2397
Moved the GHOP module into the modules package.
This also includes moving the templates and content into their respective place inside the Soc folder. This is to avoid adding every folder to the app.yaml file.
Patch by: Madhusudan C.S. and Lennard de Rijk
Reviewed by: Lennard de Rijk
Sverre Rabbelier <sverre@rabbelier.nl> [Fri, 05 Jun 2009 08:24:32 +0200] rev 2396
also rename batch_size in cron.py
Sverre Rabbelier <sverre@rabbelier.nl> [Fri, 05 Jun 2009 00:03:09 +0200] rev 2395
Added tag v0-5-20090604 for changeset 1dc8d7f9458e
Sverre Rabbelier <sverre@rabbelier.nl> [Fri, 05 Jun 2009 00:00:30 +0200] rev 2394
Set new Melange version number to 0-5-20090604 in app.yaml.template
Sverre Rabbelier <sverre@rabbelier.nl> [Thu, 04 Jun 2009 23:21:33 +0200] rev 2393
Display caught errors on the page itself
Similar to the previous commit, show directly rather than redirect.
Sverre Rabbelier <sverre@rabbelier.nl> [Thu, 04 Jun 2009 22:26:24 +0200] rev 2392
Make the maintenance page a hardcoded response
Show the maintenance message on the requested page, instead of
redirecting to a specific url which then displays a page with the
maintenance notice.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 04 Jun 2009 22:08:11 +0200] rev 2391
Merge with Pawel's tip.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 04 Jun 2009 20:55:30 +0200] rev 2390
Partial fix for displaying mentors and students on Organization home page.
Connections between mentors and students are not yet displayed and also there is some probably with displaying markers in Safari for some reason, everything works fine in FF.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 04 Jun 2009 20:46:37 +0200] rev 2389
Comment out GMaps support in Organization home page template.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 04 Jun 2009 22:02:14 +0200] rev 2388
Small indentation fix.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 04 Jun 2009 20:38:32 +0200] rev 2387
Add missing if statement in organization list row template.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 04 Jun 2009 22:01:57 +0200] rev 2386
Fixed an issue where some access checks would fail due to missing arguments.
This happens when an org document is being checked for write access when trying to show the edit link on the document's show page.
Madhusudan.C.S <madhusudancs@gmail.com> [Wed, 03 Jun 2009 23:38:02 +0530] rev 2385
Introduced 'module_package' key in params dict to support modules in melange
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 04 Jun 2009 21:58:05 +0200] rev 2384
Now showing link to edit the home page document on the home page.
This will only show up if you have the right to edit the document.
Update issue 271
Now also working for home pages.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 02 Jun 2009 19:23:06 +0200] rev 2383
Temporary turn off GMaps support on Organization home pages until it's fixed.
Currently not all markers and polyline connections between students and mentors show up.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 04 Jun 2009 20:21:15 +0200] rev 2382
Added link to edit the Document on the Document's public page.
This link will only show if the user is allowed to edit the document.
Fixes issue 271.
Update issue 271
Owner: ljvderijk
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 02 Jun 2009 19:20:14 +0200] rev 2381
Rename soc-090421.css and update base.html template.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 04 Jun 2009 18:21:04 +0200] rev 2380
Clarified docstring for document read/write access check.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 02 Jun 2009 19:17:46 +0200] rev 2379
Small changes in #extra_left, #extra_right tags in css file.
Google Maps and Student Project List on Organization home page now doesn't lay on page footer if too high.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 04 Jun 2009 08:12:57 +0200] rev 2378
Added a link to the website where the user has registered to the welcome email.
Fixes Issue 630.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 01 Jun 2009 23:42:36 +0200] rev 2377
Add taggable-mixin and gviz to build script.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 01 Jun 2009 22:23:46 +0200] rev 2376
Extend taggable-mixin to support different Tag models.
Usage is pretty simple. Tag model is default in Taggable constructor but you
can call it with different model like GHOPTaskType that inherits from Tag model.
Both Taggable and Tag models have been updated and they don't use hardcoded Tag
model anymore and instead use cls of class methods or self.__class__. In case
of Taggable it's self.__tag_model.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 01 Jun 2009 22:17:38 +0200] rev 2375
Make taggable-mixin tests working by updating GAE path.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 01 Jun 2009 20:38:38 +0200] rev 2374
Merge with Pawel's head.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 01 Jun 2009 20:31:38 +0200] rev 2373
Add google-visualization-python project to Melange repository.
This python module will be used with our Statistics module to leverage Google Visualization API and python as a data source.
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 01 Jun 2009 20:03:22 +0200] rev 2372
Removed unecessary use of %.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 30 May 2009 09:19:10 +0200] rev 2371
Changed University Student expected graduation date to be a dynamic dropdown.
The range of choices is dynamically made by taking the current_year-1 to the current_year+20. It does not start at the current year because a Student might need to change it's profile during a Program that runs across multiple years.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 30 May 2009 01:03:20 +0200] rev 2370
Added GHOP specific Mentor and Org Admin Models.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 30 May 2009 00:50:39 +0200] rev 2369
Add missing __init__.py file in taggable-mixin module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 30 May 2009 00:36:52 +0200] rev 2368
Add taggable-mixin to Melange repository.
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 29 May 2009 20:56:39 +0200] rev 2367
Add some missing docstrings to Seeder classes in seed_db.py
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 27 May 2009 20:37:04 +0200] rev 2366
Style fixes and pylint: disable-msg comments in different modules.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 27 May 2009 03:31:58 +0200] rev 2365
Add pylint: disable-msg= where needed in Melange modules.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 27 May 2009 03:31:27 +0200] rev 2364
Rename bathSize variable to batch_size in soc.logic.models.base module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 27 May 2009 03:22:37 +0200] rev 2363
Style fixes and wrong function call fix in soc.views.helper.lists module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 27 May 2009 02:12:56 +0200] rev 2362
Remove unused variable from soc.view.models.cron module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 27 May 2009 02:09:38 +0200] rev 2361
Some more pylint fixes in different Melange modules.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 27 May 2009 01:47:38 +0200] rev 2360
Style and pylint fixes in Melange modules.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 27 May 2009 00:31:40 +0200] rev 2359
Style and variable names fixes in soc.modules.core module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 26 May 2009 22:18:04 +0200] rev 2358
Remove unused imports in Melange modules.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 26 May 2009 22:10:02 +0200] rev 2357
Remove unused imports from main.py.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 26 May 2009 22:04:52 +0200] rev 2356
Some small fixes to unique_user_id_adder module.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 26 May 2009 02:45:03 +0200] rev 2355
Fixed typo in org_prize_assignment model.
Sverre Rabbelier <sverre@rabbelier.nl> [Tue, 26 May 2009 02:37:39 +0200] rev 2354
remove accidental head
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 26 May 2009 02:03:53 +0200] rev 2353
Fixed the notification list to show a properly formatted date and time column.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 26 May 2009 01:58:56 +0200] rev 2352
Link id and key name fixes for Organization And OrgApplication in seed_db.
Dan Bentley <dbentley@google.com> [Mon, 25 May 2009 16:23:16 -0700] rev 2351
Add Organization Application seeding.
Fix the seeding in seed_db so that a consistent linkid for organization
applications is used.
Use the last entry in the split array instead of the 2nd.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 26 May 2009 00:51:33 +0200] rev 2350
Make user_id property in User model not required.
Sverre Rabbelier <sverre@rabbelier.nl> [Tue, 26 May 2009 00:19:09 +0200] rev 2349
Merged with Sverre
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 25 May 2009 23:45:20 +0200] rev 2348
Fixed model name and comment typo's in task model.
Also changed the corresponding reference properties.
Madhusudan C.S. <madhusudancs@gmail.com> [Mon, 25 May 2009 23:42:56 +0200] rev 2347
Added several models related to the GHOP workflow.
These models will form the base of the GHOP infrastructure together with the already commited task model.
Reviewed by: Lennard de Rijk
Sverre Rabbelier <sverre@rabbelier.nl> [Mon, 25 May 2009 23:40:07 +0200] rev 2346
Do not die on NeedIndexErrors
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 25 May 2009 22:59:56 +0200] rev 2345
Add helper functions, model update and jobs for unique user ids.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 25 May 2009 22:59:33 +0200] rev 2344
Add missing django.template import to shell.py.
Sverre Rabbelier <sverre@rabbelier.nl> [Mon, 25 May 2009 20:42:11 +0200] rev 2343
Revert "Add a supplemantal block to the edit form"
This reverts commit f50455c4cdcb.
Sverre Rabbelier <sverre@rabbelier.nl> [Mon, 25 May 2009 20:41:54 +0200] rev 2342
Revert "Add an EditForm id to the edit form"
This reverts commit f835e39b4dbc.
James Levy <jamesalexanderlevy@gmail.com> [Mon, 25 May 2009 02:25:44 +0200] rev 2341
Add a supplemantal block to the edit form
James Levy <jamesalexanderlevy@gmail.com> [Mon, 25 May 2009 02:23:42 +0200] rev 2340
Add an EditForm id to the edit form
Sverre Rabbelier <sverre@rabbelier.nl> [Mon, 25 May 2009 02:40:11 +0200] rev 2339
Remove executable bit from datatimepicker
Madhusudan C.S. <madhusudancs@gmail.com> [Mon, 25 May 2009 02:33:26 +0200] rev 2338
Added GHOP Task model.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 25 May 2009 01:56:09 +0200] rev 2337
Added __init__.py to ghop folder.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 24 May 2009 22:32:39 +0200] rev 2336
Merge with Sverre's recent module architecture commit.
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 24 May 2009 22:29:54 +0200] rev 2335
Add web based python shell to Melange.
It is accessible via http://host/admin/shell url and requires developer rights.
Shell project is part of google-app-engine-samples. This commit moves django configuration from main.py to separate gae_django.py module. Shell project has been modified in order to work correctly with django 1.0+. Build script has been updated and includes shell folder and gae_django.py file.
http://code.google.com/p/google-app-engine-samples/source/browse/trunk/shell/
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 22 May 2009 10:08:08 +0200] rev 2334
Comment style fix in soc.views.models.organization module.
Sverre Rabbelier <sverre@rabbelier.nl> [Sun, 24 May 2009 21:40:37 +0200] rev 2333
First step in the module design
The new module design allows modules to be registered by adding them
to settings.MODULES. Currently modules cannot do a lot (they can
register with the sidebar and the sitemap), but the structure is in
place.
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 22 May 2009 09:40:53 +0200] rev 2332
Add comment regarding Student Project sorting on Organization home page.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 21 May 2009 14:44:41 +0200] rev 2331
Add sorting of student projects on organization home page.
List of student projects on organization home page is now sorted in alphabetical order by student name. Fixes issue 613.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 21 May 2009 13:25:11 +0200] rev 2330
Now clicking cancel button returns user to previous page. Fixes issue 569.
If you don't want that behaviour you can define cancel_redirect and user will be redirected to given url on "Cancel" button click instead of redirecting to previous page.
Patch by: Daniel Hans & Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 20 May 2009 12:32:36 +0200] rev 2329
Add comment to clean_html_content function and update __authors__.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 18 May 2009 20:23:42 +0200] rev 2328
Invoke pylint from build script.
Using --skip-pylint build script command line parameter you can skip pylint invocation.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 18 May 2009 19:37:38 +0200] rev 2327
Replace usage of feedparser for sanitizing html with new HtmlSanitizer module.
HtmlSanitizer prevents from XSS attacks (Fixes issue 606).
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 18 May 2009 19:34:19 +0200] rev 2326
Add htmlsanitizer folder to build script.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 18 May 2009 19:33:47 +0200] rev 2325
Add missing __init__.py file to htmlsanitizer folder.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 18 May 2009 14:49:43 +0200] rev 2324
Add HtmlSanitizer python module to Melange repository.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 18 May 2009 14:48:47 +0200] rev 2323
Add BeautifulSoup Python HTML/XML parser to Melange repository.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 18 May 2009 14:05:38 +0200] rev 2322
Add acceptedStudentsCSVExport function to stats.py script.
This funtion is used to generate CSV with all accepted students. It still needs some work and I left TODOs there. I also added helper function for saving data to CSV, which can be reused for other kinds of reports.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 18 May 2009 14:23:29 +0200] rev 2321
Remove accidentaly committed file.
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 18 May 2009 14:22:45 +0200] rev 2320
Merge with Sverre's accidental head.
Sverre Rabbelier <sverre@rabbelier.nl> [Fri, 15 May 2009 23:05:13 +0200] rev 2319
Do not rely on notifiction module being imported
This has worked so far mostly by accident, but it turned out to be
brittle while writing tests. This makes sure that the notification
module is always imported before use.
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 15 May 2009 20:54:36 +0200] rev 2318
Style fixes in test_functional.py.
Matthew Wilkes <matthew@matthewwilkes.co.uk> [Fri, 15 May 2009 18:01:43 +0200] rev 2317
Add some example function tests that use gaeftest
Sverre Rabbelier <sverre@rabbelier.nl> [Mon, 25 May 2009 23:42:15 +0200] rev 2316
Use key_name instead of link_id
Some entities do not have a link_id, but all entities are guaranteed
to have a key_name (or an id).
Sverre Rabbelier <sverre@rabbelier.nl> [Tue, 26 May 2009 20:04:59 +0200] rev 2315
Use key_name instead of link_id
Some entities do not have a link_id, but all entities are guaranteed
to have a key_name (or an id).
Matthew Wilkes <matthew@matthewwilkes.co.uk> [Fri, 15 May 2009 15:29:41 +0200] rev 2314
Include required antl3 library and check if datastore is available
The datastore is checked for availability before requesting it to
be cleared. This is because gaeftest uses its own method for ensuring
no leakage of data by providing a temporary file as the backend.
Reviewed by: Sverre Rabbelier
Daniel Bentley <dbentley@google.com> [Sun, 12 Apr 2009 09:06:45 +0000] rev 2313
Use offset_linkid instead of offset to scan >1000 entities.
this is a first-cut. It works in all the ways I could make earlier
versions fail. It passes link_id as URL parameters. It also has a new
class LinkCreator which makes the main body of getListContents even easier
to write.
I wasn't sure if link_id's could have non alphanumeric characters; if so, they
need to be URL encoded/decoded.
I also need to go and remove any mention of raw offsets now, because we don't
use them.
I believe I've talked about this approach with a few of you and it sounded
reasonable. Feel free to roll-back/fix/amend/comment-for-me-to-fix. This is
my first big-logic-change to Melange.
Patch by: Dan Bentley
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 15 May 2009 12:37:01 +0200] rev 2312
Revert not finished 1000 limitation fix commit (ef7222d484).
We are going to put this into separate branch until it's finished.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 12 May 2009 15:52:53 +0200] rev 2311
Add vcs-load-dirs project to thirdparty directory.
vcs-load-dirs project contains load-dir scripts for different version control sysystems including git, hg, darcs, bazaar.
More information about the project:
http://software.complete.org/software/wiki/vcs-load-dirs/
http://software.complete.org/static/vcs-load-dirs/doc//hg_load_dirs.1.html
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 12 May 2009 15:48:36 +0200] rev 2310
Add .DS_Store Mac OS X specific files to .hgignore.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 12 May 2009 15:39:52 +0200] rev 2309
Update Google App Engine to 1.2.2 in thirdparty folder.
Sverre Rabbelier <sverre@rabbelier.nl> [Thu, 14 May 2009 22:40:39 +0200] rev 2308
added foo
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 12 May 2009 13:02:10 +0200] rev 2307
Fix ordering of names in AUTHORS file.
Sverre Rabbelier <sverre@rabbelier.nl> [Sun, 10 May 2009 02:38:57 +0200] rev 2306
Add .gitignore to .hgignore
We're all ignoring one another, pretending the other doesn't exist at
all, how rude!
Sverre Rabbelier <sverre@rabbelier.nl> [Sun, 10 May 2009 02:29:07 +0200] rev 2305
Add .git to the .hgignore file
Sverre Rabbelier <sverre@rabbelier.nl> [Sat, 09 May 2009 19:23:02 +0200] rev 2304
Remove __init__.py from project root as well
This is in line with the earlier patch to remove the __init__.py file
from the app/ directory.
---
0 files changed, 0 insertions(+), 0 deletions(-)
delete mode 100644 __init__.py
Sverre Rabbelier <sverre@rabbelier.nl> [Sat, 09 May 2009 15:28:26 +0200] rev 2303
[PATCH] Remove __init__.py from app, as app is not a module
From 6916391964ed3b48021351d3a9ea7a7bc836a373 Mon Sep 17 00:00:00 2001
Date: Sat, 9 May 2009 15:19:04 +0200
---
scripts/build.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
delete mode 100644 app/__init__.py
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 09 May 2009 01:37:21 +0200] rev 2302
Renamed duplicate slots because of recent changes.
Mario Ferraro <fadinlight@gmail.com> [Sat, 09 May 2009 01:36:22 +0200] rev 2301
Fixes Issue 625 where the Duplicate calculation would hang if no assigned slots where available.
Reviewed by: Lennard de Rijk
Mario Ferraro <fadinlight@gmail.com> [Sat, 09 May 2009 01:14:03 +0200] rev 2300
Fixed Issue 627 where multiple Purr boxes would show when using calendar widget.
Sverre Rabbelier <sverre@rabbelier.nl> [Fri, 08 May 2009 14:58:19 +0200] rev 2299
Add Marcelo to AUTHORS file and fix typo
Marcelo de Sena Lacerda <marceloslacerda@gmail.com> [Fri, 08 May 2009 14:55:36 +0200] rev 2298
Add coverage support to the test suite
This requires nose 0.11 to run.
Sverre Rabbelier <sverre@rabbelier.nl> [Fri, 08 May 2009 14:42:16 +0200] rev 2297
Added coverage output files to .hgignore
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 05 May 2009 21:48:46 +0200] rev 2296
Fixed typo in docstring as to comments on r3012 (svn repo).
Also now importing logic and using keyword arguments as to comply with the codebase standards
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 04 May 2009 19:23:44 +0200] rev 2295
Replace BeautyTips tooltips with purr info box for all form fields with help text.
Patch by: Mario Ferraro
Reviewed by: Pawel Solyga
Sverre Rabbelier <sverre@rabbelier.nl> [Fri, 01 May 2009 01:37:43 +0200] rev 2294
Use python2.5 in our unit tests
Patch by: Sverre Rabbelier
Sverre Rabbelier <sverre@rabbelier.nl> [Fri, 01 May 2009 00:56:29 +0200] rev 2293
Ignore .project and .pydevproject files
Patch by: Sverre Rabbelier
Sverre Rabbelier <sverre@rabbelier.nl> [Fri, 01 May 2009 00:35:06 +0200] rev 2292
Add full list of accepted students
Patch by: Daniel Hans
Sverre Rabbelier <sverre@rabbelier.nl> [Fri, 01 May 2009 00:32:18 +0200] rev 2291
Ignore backup files (*~)
Patch by: Sverre Rabbelier
Sverre Rabbelier <sverre@rabbelier.nl> [Fri, 01 May 2009 00:31:39 +0200] rev 2290
Ignore zip files and build directory
Patch by: Sverre Rabbelier
Sverre Rabbelier <sverre@rabbelier.nl> [Fri, 01 May 2009 00:25:11 +0200] rev 2289
Merged revert
Sverre Rabbelier <sverre@rabbelier.nl> [Fri, 01 May 2009 00:03:02 +0200] rev 2288
Backed out changeset 571f2de51138
Test commit that was not meant to be committed.
Patch by: Sverre Rabbelier
Sverre Rabbelier <sverre@rabbelier.nl> [Thu, 30 Apr 2009 23:33:04 +0200] rev 2287
Make dev_appserver error out when python version >2.5 is used
Patch by: Sverre Rabbelier
Sverre Rabbelier <sverre@rabbelier.nl> [Thu, 30 Apr 2009 17:13:09 +0200] rev 2286
Added file 'foo.txt'
Lennard de Rijk <ljvderijk@gmail.com> [Wed, 29 Apr 2009 22:24:14 +0200] rev 2285
Fixed StudentProposal apply view that broke during split of Create/Edit view.
Also included whitespace fixes.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 29 Apr 2009 18:51:58 +0200] rev 2284
Fix Issue 389 (Clicking list entry will not open new tab/window).
Patch by: Daniel Hans
Reviewed by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 29 Apr 2009 18:20:30 +0200] rev 2283
Fix too long line in soc.view.models.organization module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 28 Apr 2009 12:47:06 +0200] rev 2282
Remove E1103 and E1101 errors from ignore list in pylintrc file.
We are going to use "# pylint disable-msg=E1103" comments in the source file itself to ignore false-positives.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 27 Apr 2009 13:01:53 +0200] rev 2281
Style fixes in app.soc.views.models.student_project module.
Too long line and missing whitespace.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 25 Apr 2009 20:52:03 +0200] rev 2280
Show all Co-Mentors on the Student Project public page.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 25 Apr 2009 20:50:48 +0200] rev 2279
Changed Additional Mentors to Co-Mentors in the manage view.
Due to a conversation with Pawel.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk [Sat, 25 Apr 2009 20:24:00 +0200] rev 2278
Added functionality to set additional mentors for a Student Project.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk [Sat, 25 Apr 2009 20:22:13 +0200] rev 2277
Fixed missing value in context when a form with a different name then form was used.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 25 Apr 2009 10:13:06 +0200] rev 2276
Fix broken tests by renaming default app id from "your_app_id" to "test-app-run".
This fix is required due to changes in GAE 1.2.1.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 25 Apr 2009 10:09:24 +0200] rev 2275
Add .hgignore to repository and ignore all .pyc files and app.yaml file.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 24 Apr 2009 22:34:31 +0000] rev 2274
Add getStudentsProjects to context in stats.py script.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 24 Apr 2009 14:16:00 +0000] rev 2273
Load /Users/solydzajs/Desktop/google_appengine into
trunk/thirdparty/google_appengine.
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 21 Apr 2009 16:28:13 +0000] rev 2272
Renamed .css file due to recent changes.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 21 Apr 2009 16:24:32 +0000] rev 2271
Added map of accepted student proposals to mentors to the org home page.
Patch by: Madhusudan C.S
Reviewed by: Lennard de Rijk
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 21 Apr 2009 16:24:13 +0000] rev 2270
Fix missing dot in stats.py docstring.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 21 Apr 2009 14:36:47 +0000] rev 2269
Fixing the build now that emails have been tested.
Patch by: Augie Fackler
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 21 Apr 2009 14:25:57 +0000] rev 2268
Intentionally breaking the build so that we can verify BuildBot will send email.
Patch by: Augie Fackler
Augie Fackler <durin42@gmail.com> [Tue, 21 Apr 2009 01:45:12 +0000] rev 2267
Fixing the build now that emails have been tested.
Patch by: Augie Fackler
Augie Fackler <durin42@gmail.com> [Tue, 21 Apr 2009 01:38:04 +0000] rev 2266
Intentionally breaking the build so that we can verify BuildBot will send email.
Patch by: Augie Fackler
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 20 Apr 2009 22:52:51 +0000] rev 2265
Added reviveJobs and deidleJobs to stats.py
These can be used to mark jobs as 'waiting' (meaning they will be
executed again).
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 20 Apr 2009 22:52:38 +0000] rev 2264
Email address is actually private, not public, make this obvios
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 20 Apr 2009 22:52:21 +0000] rev 2263
Set the last_modified_on date to last change
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 20 Apr 2009 22:52:05 +0000] rev 2262
Set batch size to 10
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 20 Apr 2009 22:51:48 +0000] rev 2261
Added index needed to convert proposals
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 20 Apr 2009 22:31:25 +0000] rev 2260
Some minor style fixes.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 20 Apr 2009 20:57:59 +0000] rev 2259
Changed the accepted and rejected list to redirect to the review page in ListProposals view.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 20 Apr 2009 20:56:56 +0000] rev 2258
Allowing student project review page to be viewed in read-only mode after the deadline has passed.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 20 Apr 2009 19:08:47 +0000] rev 2257
Fixed typo in access module naming.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 20 Apr 2009 03:44:17 +0000] rev 2256
Set new Melange version number to 0-5-20090420 in app.yaml.template.
Patch by: Pawel Solyga
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 22:51:58 +0000] rev 2255
Some minor style fixes.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 22:50:30 +0000] rev 2254
Added listing of accepted and rejected proposals to the organization proposal page.
The link will redirect to the public page where comments can still be placed.
Patch by: Madhusudan.C.S
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 22:14:35 +0000] rev 2253
Added org_home_gmap function to the map JS for displaying the mentor-student map.
Patch by: Madhusudan.C.S and Merio Ferraro
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 22:07:20 +0000] rev 2252
Added mentor-marker.png to content\images.
This is for use on the organization home pages having the map displayed.
Patch by: Madhusudan.C.S
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 22:05:25 +0000] rev 2251
Renamed map JS to facilitate upcoming changes.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 21:50:04 +0000] rev 2250
Added the gathering of data required to display a map on the org home page.
Patch by: Madhusudan.C.S
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 21:37:14 +0000] rev 2249
Added ccTld property to role to retrieve the ccTld of the country of residence for a specific role entity.
Patch by: Madhusudan.C.S
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 21:26:38 +0000] rev 2248
Added dictionary mapping country names to their CCTLD in countries model.
Patch by: Madhusudan.C.S
Reviewed by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 19 Apr 2009 17:42:57 +0000] rev 2247
Don't run in a transaction if not needed
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 19 Apr 2009 17:42:44 +0000] rev 2246
Tweak the 'load balancing' algorithm
In order to reduce contention we randomly skipped jobs, but this
caused many jobs to end up stopping early. Now instead we keep on
going until we time out (also increased the chance of doing work).
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 19 Apr 2009 17:42:27 +0000] rev 2245
Added deleteEntities methods to stats.py
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 16:23:29 +0000] rev 2244
Fixed typo in cron.job module's timeOutJob docstring.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 19 Apr 2009 14:48:21 +0000] rev 2243
Use status codes in job.py
The previous behavior of being able go do 'if not handler.handle' is
still valid as the status code for 'timed out' is 0.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 14:45:22 +0000] rev 2242
getDefaultMailSender now properly handles users who are logged in but not registered.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 19 Apr 2009 14:35:31 +0000] rev 2241
Allow anyone to see student projects
The required rights['show'] exception was already made, but the
any_access check was preventing it from being effictive.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 10:46:20 +0000] rev 2240
Changed the type of Error occurring when no valid sender could be found to a FatalJobError in student_proposal_mailer.
This means that the job will be immediately aborted.
This patch is due to comments on r3000 by SRabbelier.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 10:37:10 +0000] rev 2239
Students can not list their own projects before the accepted students announced deadline.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 10:29:57 +0000] rev 2238
Student Proposal Mailer is now sending out real emails.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 10:28:35 +0000] rev 2237
Fixed a comment typo and possible bug in mail_dispatcher.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 10:26:11 +0000] rev 2236
Added email templates for accepted and rejected students in a GSoC like program.
These templates are specifically for GSoC2009 as per request in Issue 379.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 19 Apr 2009 00:07:46 +0000] rev 2235
Major brown paper bag fix
Filter was set to empty dict while it was passed in as a possibly
empty param.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 19 Apr 2009 00:07:29 +0000] rev 2234
Add a startSpam method to stats
This method creates the job responsible for sending out emails to
students.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 19 Apr 2009 00:07:17 +0000] rev 2233
Add job to the index
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 19 Apr 2009 00:07:05 +0000] rev 2232
Add a random chance to ignore a job to reduce contention
This should probably be solved better (perhaps with a binary
exponential backoff).
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 19 Apr 2009 00:06:46 +0000] rev 2231
Do not fetch all jobs with each poke
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 19 Apr 2009 00:06:29 +0000] rev 2230
Add entityIterator to base Logic
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 19 Apr 2009 00:06:12 +0000] rev 2229
Store how many times a job has timed out and abort if needed
Patch by: Sverre Rabblier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 21:34:41 +0000] rev 2228
Wrong usage of twoline_table_row caused weird layout in project
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 21:34:25 +0000] rev 2227
Add cron.yaml to the build script
Patch by: Sverre Rabbelier, Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 18 Apr 2009 21:30:58 +0000] rev 2226
Instead of text_data use key_data property to check for uniqueness.
Brown paper bag fix, querying for TextProperty is not smart ^_^.
Patch by: Lennard de Rijk, Sverre Rabbelier
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 18 Apr 2009 21:26:13 +0000] rev 2225
Style fix in Job model.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 18 Apr 2009 21:22:43 +0000] rev 2224
Hook up the Student Proposal Mailer in the cron/jobs module.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 18 Apr 2009 21:21:22 +0000] rev 2223
Added Student Proposal Mailer module for mailing students who are accepted/rejected into the program.
TODO has been added to actually sent out the emails.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 19:00:04 +0000] rev 2222
Various improvements to convertProposals
It should now be ready to convert proposals to projects and reject
all proposals that were not accepted.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 18:59:53 +0000] rev 2221
Add a silent option to updateOrCreateFromFields
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 18 Apr 2009 17:14:42 +0000] rev 2220
Fixed wrong import for list proposals view.
This seems to be working in the p3 release though.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 18 Apr 2009 15:06:36 +0000] rev 2219
Fixed typo and added myself to authors in the cron/job module.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 15:05:56 +0000] rev 2218
Add a script to convert proposals.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 18 Apr 2009 15:04:24 +0000] rev 2217
Added FatalJobError to the cron/job module.
This Error will lead to abortion of the raising job.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 18 Apr 2009 14:51:27 +0000] rev 2216
Fixed typo in documentation of the Job Model.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 18 Apr 2009 14:43:42 +0000] rev 2215
Changed the response message in the cron poke view.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 14:27:40 +0000] rev 2214
Remove debug url too
This should have been part of the previous commit.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 14:25:30 +0000] rev 2213
Remove testing method and update docstring for cron system
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 14:04:39 +0000] rev 2212
Removed unneeded imports and variables
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 14:04:11 +0000] rev 2211
Add cron, the core of the job system
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 14:03:49 +0000] rev 2210
Add priority groups and jobs to the sitemap
Also add an entry in the Site menu to list them.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 14:03:28 +0000] rev 2209
Add jobs (model, logic, and view)
Jobs are the core of the Job system, allowing distributed processing
of taks in an interuptable manner.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 14:02:56 +0000] rev 2208
Add priority groups (model, logic, and view)
Priority groups will be a key part of the Job system, allowing the
site admin to give a higher priority to certain job types on the fly.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 18 Apr 2009 14:00:30 +0000] rev 2207
The listing of accepted projects on the Organization's homepage is now timeline dependent.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 18 Apr 2009 13:59:24 +0000] rev 2206
White space fix in list_info module.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 12:49:37 +0000] rev 2205
Fix user_self calling editGet with a wrong parameter
Also fix wrong call to collectCleanedFields and stray seed
argument in user_self.
Patch by: Sverre Rabbelier, Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 12:37:12 +0000] rev 2204
Split edit and create into different methods
This makes removes unneeded responsibility from the edit view and
makes it possible to more tightly restrict the usage of the edit and
create views to only creating/editing.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 12:36:55 +0000] rev 2203
Add support for ID based entities
This allows entities that do not have a key name to be created and
edited without requiring the presence of a key_name.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 12:07:02 +0000] rev 2202
Use proposal key instead of raw proposal
Patch by: Sverre Rabbelier, Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 11:41:56 +0000] rev 2201
Show in green the proposals that would be accepted
Patch by: Sverre Rabbelier, Lennard de Rijk
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 17 Apr 2009 22:50:16 +0000] rev 2200
Add proper generation of Student entities and StudentProposal entities to seed_db module.
Add link for generating 200 Students to seed_db.html template.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 17 Apr 2009 21:36:49 +0000] rev 2199
Rename that should have been part of r2953.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 17 Apr 2009 21:14:43 +0000] rev 2198
Renamed stepsize to step_size in Student Proposal Logic.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 17 Apr 2009 20:26:37 +0000] rev 2197
Moved the code to retrieve all Proposal which should be accepted for one Organization to the Proposal Logic module.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 17 Apr 2009 19:54:27 +0000] rev 2196
Style fixes in soc.views.helper.lists module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 17 Apr 2009 19:53:54 +0000] rev 2195
Style fixes in soc.views.models.organization module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 17 Apr 2009 19:53:23 +0000] rev 2194
Fix too long line in soc.views.models.program module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 17 Apr 2009 19:52:57 +0000] rev 2193
Comment out unused variables in soc.views.models.base module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 17 Apr 2009 19:01:26 +0000] rev 2192
Fix too long line in soc.views.helper.templatetags.forms_helpers module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 17 Apr 2009 16:23:01 +0000] rev 2191
Proposal CSV export for students.
Patch by: Matthew Wilkes
Reviewed by: Pawel Solyga
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 15 Apr 2009 23:22:11 +0000] rev 2190
Readability fix in base logic
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 15 Apr 2009 23:21:40 +0000] rev 2189
Remove redundant if check
site_logic.getSingleton() is guaranteed to return an entity.
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Apr 2009 19:13:52 +0000] rev 2188
Comment out unused variables in soc.logic.allocations module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Apr 2009 19:13:16 +0000] rev 2187
Fix too long line in soc.cache.logic module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Apr 2009 16:05:29 +0000] rev 2186
Add missing responses import and replace usage of helper.responses with just responses in soc.views.models.student module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Apr 2009 15:56:17 +0000] rev 2185
Fix too long line and redefining variable 'review' from outer scope in soc.views.models.student_proposal module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Daniel Bentley <dbentley@google.com> [Wed, 15 Apr 2009 08:01:17 +0000] rev 2184
Step 2 of moving to new seeding model.
Create Seeder class, which abstracts some seeding.
Move user to Seeder class, and make new OrganizationSeeder class.
If people like this, I'll finish the rest soon.
Patch by: Dan Bentley
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Apr 2009 18:44:06 +0000] rev 2183
Added additional_mentors property to StudentProject.
As per request by Issue 588.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Apr 2009 18:42:27 +0000] rev 2182
Whitespace fix in sponsor model.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 13 Apr 2009 21:46:33 +0000] rev 2181
Place the getSingleton call in view decorator in the try
This way timeouts on the getSingleton() call are also catched.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 13 Apr 2009 21:32:29 +0000] rev 2180
Fix a bug in duplicate detection
This is caused by AppEngine's inability to sort a query when the
inequality or IN operator is used. See also [0].
[0] http://code.google.com/p/googleappengine/issues/detail?id=1100
Patch by: Sverre Rabbelier and Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 13 Apr 2009 21:32:12 +0000] rev 2179
Undid superfluas replacement of .name() with .name_or_id()
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Apr 2009 16:31:36 +0000] rev 2178
Fixes access check for manage view.
Added forgotten IsMyEntity check and fixed a bug introduced by a rename in r2816.
Addresses Issue 584.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 13 Apr 2009 15:31:39 +0000] rev 2177
Do not rely on dicts.merge to change target
Also make dicts.merge actually not touch target. This is much cleaner
than modifying in place, especially since we assign the result of the
dicts.merge call to target most of the time anyway.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 13 Apr 2009 15:30:48 +0000] rev 2176
Use key().id_or_name() instead of key().name()
These two cases were introduced after the previous refactoring was
done and did not follow the new behavior.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 13 Apr 2009 14:34:42 +0000] rev 2175
Fix a bug in seed_db
Using %(num)d with an int as argument doesn't work.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 12 Apr 2009 16:43:30 +0000] rev 2174
Added a warning message to alert the user that reviews are not editable.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 12 Apr 2009 16:09:00 +0000] rev 2173
Added overview of private reviews to the Student Proposal review page.
Addresses Issue 496.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 12 Apr 2009 13:22:43 +0000] rev 2172
Load /Users/solydzajs/Downloads/google_appengine into
trunk/thirdparty/google_appengine.
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Apr 2009 13:14:03 +0000] rev 2171
Do not rely on a backup_admin being set
Patch by: Sverre Rabbelier