Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 21:59:10 +0200] rev 2518
Only initialize a SurveyTakeForm in take instead of in takeGet and takePost.
This will allow for other subclassed views to easily replace the form the view is using.
Also small style fix in Survey helper.
Daniel Diniz <ajaksu@gmail.com> [Fri, 03 Jul 2009 21:06:22 +0200] rev 2517
Split SurveyForm into SurveyTakeForm and SurveyEditForm.
This allows for a more cleaner implementation of the Form code. And this will make it easier to break free from the getFields method in the future.
Also the getRoleSpecifcFields method and the this_user and project variables have been removed. They are deemed obsolete.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 20:38:43 +0200] rev 2516
Do not call takeGet when SurveyForm ValidationError occurs.
Problems occured when a SurveyRecord was specified in the SurveyForm. The SurveyRecord data reset the erroneous POST data. Further code reduction might be possible soonish.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 19:15:09 +0200] rev 2515
Several stylefixes due to received reviews.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 18:39:30 +0200] rev 2514
Style fixes in Access module.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 18:34:18 +0200] rev 2513
Style fixes to the GradingProjectSurvey View module.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 18:23:34 +0200] rev 2512
Sub_merge params for GradingProjectSurvey View.
James Levy <jamesalexanderlevy@gmail.com> [Fri, 03 Jul 2009 18:23:02 +0200] rev 2511
Added rudimentary grade field to GradingProjectSurvey take View.
Patch by: James Levy, Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 18:20:33 +0200] rev 2510
Ensure that the params from subclasses get merged properly with ProjectSurvey view.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 18:09:48 +0200] rev 2509
Corrected the links to Grading Project Surveys in Program menu.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 17:55:36 +0200] rev 2508
Added missing import to ProjectSurvey View.
Daniel Diniz <ajaksu@gmail.com> [Fri, 03 Jul 2009 15:21:44 +0200] rev 2507
Fix pick_multi only returning one answer as maximum.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 15:00:00 +0200] rev 2506
Removed getSurveyResponseFromPost from Surveys helper.
We will use the power of Django Forms instead of getting our own properties. This fits better into the rest of Melange which also uses this approach.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 14:53:26 +0200] rev 2505
Renamed survey-edit-090627.js due to recent changes.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 14:43:49 +0200] rev 2504
Form errors when taking a Survey now have the correct context.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 14:36:16 +0200] rev 2503
Fixed Survey Form error giving 505.
I failed when changing the system to work with collectCleanedFields.
Daniel Diniz <ajaksu@gmail.com> [Fri, 03 Jul 2009 14:35:03 +0200] rev 2502
Surveys can now have required questions and comments can be turned on/off.
Storing comments is now working. However some issues arise when form errors occur, like missing context and the errors also trigger before a form has been submitted.
Reviewed by: Lennard de Rijk
Daniel Diniz <ajaksu@gmail.com> [Fri, 03 Jul 2009 14:19:23 +0200] rev 2501
Added Survey From Field validation.
Also added the COMMENT_PREFIX in Survey model to ensure that comments are stored in the same way everwhere.
Reviewed by: Lennard de Rijk
Daniel Diniz <ajaksu@gmail.com> [Fri, 03 Jul 2009 12:10:24 +0200] rev 2500
Style fixes and a forgotten parameter in Survey(Record) logic.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 12:05:23 +0200] rev 2499
Removed unnecessary variable in ProjectSurvey take method.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 12:02:57 +0200] rev 2498
Overwrite _getSurveyRecordFor in ProjectSurvey view to take StudentProject into account.
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 03 Jul 2009 12:00:53 +0200] rev 2497
Added _getSurveyRecordFor method to Survey View.
This method is used by the Take view to get the right SurveyRecord for the current request. Subclassed Views that want to fetch their records in another way can override this method.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 02 Jul 2009 18:35:57 +0200] rev 2496
Added default Survey list templates for ProjectSurvey and GradingProjectSurvey.
Daniel Diniz <ajaksu@gmail.com> [Thu, 02 Jul 2009 18:33:13 +0200] rev 2495
Enable the ProjectSurvey and GradingProjectSurvey views in the core.
Also add menu items to the program menu for easy access to these options.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 02 Jul 2009 17:51:07 +0200] rev 2494
Implemented taking ProjectSurveys.
The user will first be served a list of all eligble StudentProjects for which the ProjectSurvey can be taken. After clicking on the list the key_name of the project is attached as a GET param and the code uses the normal take view with the hooks to let everything run smoothly.
An extra access check method is required which checks if the Project mentioned in the GET param is a valid project for the current user. This check will run together with the isSurveyTakable checker.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 02 Jul 2009 17:47:24 +0200] rev 2493
Edit SurveyRecord model to not make use of different Survey property for each subclass.
This does mean that a simple query needs to be constructed by hand whenever you want to query for every SurveyRecord for a specific Survey. However the naming is now the same over each SurveyRecord and it fits well into the rest of the design of Melange.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 02 Jul 2009 17:08:10 +0200] rev 2492
Made the CSV exporter for Survey not rely on the BackReferenceProperty in Survey.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 02 Jul 2009 16:53:13 +0200] rev 2491
Added getTakeProjectSurveyRedirect.
This redirect is used when taking a ProjectSurvey.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 02 Jul 2009 16:51:31 +0200] rev 2490
Added the possibility to change the action of the form on the Survey take page.
Lennard de Rijk <ljvderijk@gmail.com> [Thu, 02 Jul 2009 16:50:08 +0200] rev 2489
Small style fix in Surveys helper.