Todd Larsen <tlarsen@google.com> [Thu, 13 Nov 2008 19:41:16 +0000] rev 478
upload.py (customized for use with codereviews.googleopensourceprograms.com)
updated from latest Rietveld release.
Patch by: Todd Larsen
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 13 Nov 2008 16:40:05 +0000] rev 477
Moved from docs -> document
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 12 Nov 2008 21:43:15 +0000] rev 476
Fixed typo in docstring
Todd Larsen <tlarsen@google.com> [Wed, 12 Nov 2008 07:28:12 +0000] rev 475
Copy the link_name regex patterns into linkable.py, in preparation for
removing them from path_link_name.py (eventually).
Patch by: Todd Larsen
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 11 Nov 2008 21:07:38 +0000] rev 474
Move all the properties from Person model to Role model. Update all the comments and docs according to the changes. Remove Person model.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 11 Nov 2008 19:49:00 +0000] rev 473
Fix broken User link name (it was possible to change link name to one that was already used, validation was not working correctly).
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 11 Nov 2008 01:02:56 +0000] rev 472
Move "(required)" text to third column instead of second column in templatetags, it's much more user friendly that way. Add new version of as_table that support our current error messages format, information about required fields and tooltips.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 10 Nov 2008 23:18:06 +0000] rev 471
Remove stop parameter from home_settings and site_settings views. This is something Sverre didn't mean to commit :-) Add missing params description to the models Base class docs.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 10 Nov 2008 22:50:27 +0000] rev 470
In soc.views.models.user module fix too long line. Delete unused email variable, add missing doc and rename self method and global variable to editSelf and edit_self so it's not confused with "self" used in classes and there is no outerscope variable name overwriting anymore.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 10 Nov 2008 22:45:17 +0000] rev 469
Some name changes in soc.logic.site.map module for User self edit view.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 10 Nov 2008 22:38:20 +0000] rev 468
Fix typo in linkable model and add some missing comments.
Patch by: Pawel Solyga
Todd Larsen <tlarsen@google.com> [Mon, 10 Nov 2008 18:00:47 +0000] rev 467
Initial thoughts on a Linkable Model class. Please comment.
Patch by: Todd Larsen
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 10 Nov 2008 17:25:05 +0000] rev 466
Fix names typos in home_settings and site_settings modules.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 10 Nov 2008 16:46:16 +0000] rev 465
Change Google Maps property name from gm_api_key to gmaps_api_key.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 10 Nov 2008 16:40:51 +0000] rev 464
Change partial path and link name verbose names in home_settings.py. Some comments fixes in site_settings.py.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 10 Nov 2008 16:07:18 +0000] rev 463
Add jquery folder to make_release.sh script to fix not working jquery on deployed app.
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 10 Nov 2008 14:40:16 +0000] rev 462
Adds a check to logic/valididate.py that checks the partial path format using a regexp. This regexp has been added to logic/path_link_name.py, therefore changing PATH_LINKNAME_REGEX to use the PARTIAL_PATH in building this regexp. Plus views/models/docs.py now uses the validation functions in the clean_ methods.
Patch by: Lennard de Rijk
Review by: Pawel Solyga
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 10 Nov 2008 00:42:41 +0000] rev 461
Partially use the new user code
The 'edit self' is not working fully yet, the 'lookup' code is not
working at all, as such, only 'create', 'edit', 'list', and 'delete'
make use of the generic code.
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 10 Nov 2008 00:42:18 +0000] rev 460
Added a generic user page
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 10 Nov 2008 00:41:54 +0000] rev 459
Preparation for generic user views
Added a getSuffixValues method that is meant to allow for having a
non-public field as key_name.
Also added support for a key-name field being embeded in the form so
that if the key-fields change the old key_name is not lost.
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 10 Nov 2008 00:41:01 +0000] rev 458
Added support for providing a custom params dict
This has been a long outstanding feature request for tlarsen, luckily
it turned out to be very easy to implement with the dict.merge
utility method. To have custom _rights one should instead to the
required access checks before calling the view method.
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 10 Nov 2008 00:40:39 +0000] rev 457
Fixed a typo in id_user
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 10 Nov 2008 00:40:15 +0000] rev 456
Fix create redirect
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 10 Nov 2008 00:39:50 +0000] rev 455
Added support for providing a custom params dict
This has been a long outstanding feature request for tlarsen, luckily
it turned out to be very easy to implement with the dict.merge
utility method. To have custom _rights one should instead to the
required access checks before calling the view method.
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 10 Nov 2008 00:39:26 +0000] rev 454
Minor fix to sponsor missing from the site restructure
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 09 Nov 2008 21:40:28 +0000] rev 453
Add a Google Maps property to Site Settings
Patch by: Lennard de Rijk <ljvderijk@gmail.com>
Reviewed by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 09 Nov 2008 21:24:49 +0000] rev 452
Fixes to {Site,Home}Settings
Also improved help text on HomeSettings partial_path and link_name.
Dmitri Gaskin <dmitrig01@gmail.com> [Sat, 08 Nov 2008 18:35:46 +0000] rev 451
Fixing the string for the default home page
Dmitri Gaskin <dmitrig01@gmail.com> [Sat, 08 Nov 2008 17:40:12 +0000] rev 450
Making the docs template prettier
Dmitri Gaskin <dmitrig01@gmail.com> [Sat, 08 Nov 2008 17:06:35 +0000] rev 449
Allowing + and - to be clicked in the menu
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 07 Nov 2008 22:24:01 +0000] rev 448
Fix not working former_ids. Add support for "Invalid accounts". Now when id from former_ids tries to create a profile "This account is invalid." error message is displayed. Compare emails in lower cases to prevent changing User email to the same email with different character casing (needs some more testing).
Patch by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 07 Nov 2008 22:13:20 +0000] rev 447
Some indention fixes and remove not needed variable in soc.logic.models.base module.
Patch by: Pawel Solyga
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 05 Nov 2008 23:38:00 +0000] rev 446
Refactoring of {site/home}_settings to make them use base.View
This makes the way for deleting the key_name.py module
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 05 Nov 2008 23:36:28 +0000] rev 445
Major site restructuring, also deleting of many unused or obsolete documents
The new structure is as follows:
<entity>/list - list all <entitie>s
<entity>/create - create a new <entity>
<entity>/show/<key fields> - public page for <entity>
<entity>/edit/<key fields> - edit a <entity>
<entity>/delete/key fields> - delete a specific entity
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 05 Nov 2008 23:33:22 +0000] rev 444
Fix sponsor key field extraction
When extracting key field there is no sponsor or user object, instead
only their link names are known.
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 05 Nov 2008 23:32:59 +0000] rev 443
Implements base.Logic functions in home_settings, site_settings and work
This patch implements the base.Logic funtions needed for making
logic/key_name.py obsolete. This patch defines the needed functions
in home_settings, site_settings and work. All modules in logic/models
now have these functions defined.
logic/models/site_settings.py now inherits from
logic/models/home_settings.py because of their similar connection in
the corresponding models. Please note that the self._keyName for
these two modules still points to logic/key_name.py since entity_type
is still used in views/home.py.
A partial_path and link_name were added to HomeSettings as requested
by SRabbelier.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 04 Nov 2008 20:06:36 +0000] rev 442
Fix wrong redirect when changing partial path or link name. Remove an unnecessary assignment in logic/models/base.py that would generate an error when an entity did not exist.
Patch by: Lennard de Rijk
Review by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 04 Nov 2008 14:09:37 +0000] rev 441
Fix not working former ids feature of User Profile Developer Edit view. Add missing Error exception class to soc.logic.models.base module.
Patch by: Pawel Solyga
Todd Larsen <tlarsen@google.com> [Tue, 04 Nov 2008 02:50:55 +0000] rev 440
Third-party Javascript that should have been part of r891. Same license as
JQuery.
Patch by: Todd Larsen
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 03 Nov 2008 19:47:02 +0000] rev 439
Minor fixes needed for generic key name
We no longer try to retreive an entity when there are unset fields.
This sort of makes 'getIfFields' obsolete, since we check if fields
now anyway. This is needed because getKeyFieldsFromDict expects the
fields to be set.
Also a minor fix in a Django template so that the generic 'edit' page
has a working delete button again.
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 03 Nov 2008 19:04:04 +0000] rev 438
Quick fix to fix user profile creation
This change will be obsolete when User refactoring is finished, but
it will fix the build untill then.
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 03 Nov 2008 18:20:53 +0000] rev 437
Django Fix according to code.djangoproject.com/attachement/ticket/9115/check_for_unlink_in_temp.patch
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 03 Nov 2008 15:03:09 +0000] rev 436
Add missing TODOs to soc.logic.models classes. Fix comments format in base.Logic class. Changes based on comments to r972.
http://code.google.com/p/soc/source/detail?r=972
Patch by: Pawel Solyga
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 02 Nov 2008 22:57:46 +0000] rev 435
Refactor out the abundance of dictionary (un)packing
Instead, keep the dict packed once packed, and only unpack
it when needed.
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 02 Nov 2008 22:56:52 +0000] rev 434
Added key field definitions to the User logic
This is the first part of making the User views generic.
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 02 Nov 2008 22:56:28 +0000] rev 433
Add a getForFields method
It allows for generic queries with restrictions specified
in a dictionary.
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 02 Nov 2008 22:50:22 +0000] rev 432
Add a generic method for getting a Keyname
This patch will make logic/key_name.py obsolete in the future when
everything is compliant with base.logic.
This also makes the naming of already compliant logic modules generic
and also fixes the _name field to be consistent with the naming in
key_name.py.
Note: This does not use Group/Sponsor, Group/School,
Group/Organisation or Group/Club.
Patch by: "Lennard de Rijk" <rijk0214@gmail.com>
Reviewed by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 02 Nov 2008 18:25:07 +0000] rev 431
Added a missing 'pass' statement
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 02 Nov 2008 18:10:30 +0000] rev 430
Create a Site Settings sub-menu
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 02 Nov 2008 17:26:06 +0000] rev 429
Fixed typo in e-mail address
Instead of 'sverre@rabbelier.nl' everything read 'sverer@rabbelier.nl'
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 02 Nov 2008 17:25:10 +0000] rev 428
Fixed typo in access check
Instead of checking for 'public' the rights for 'edit' were checked.
Todd Larsen <tlarsen@google.com> [Mon, 27 Oct 2008 19:31:51 +0000] rev 427
The pretty blue triangles from Google Code!
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Mon, 27 Oct 2008 19:19:44 +0000] rev 426
Add tooltips style display of help_text, instead of widening the form with
another (often ridiculously large) column. Also, version the .css and .js
files so that browsers won't display the wrong cached one when we change
something.
Patch by: Dmitri Gaskin, Todd Larsen
Review by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Mon, 27 Oct 2008 18:54:53 +0000] rev 425
Change Site and User sub-menus so that the "header" entry for those sub-menus
is not a clickable link, but instead just a placeholder.
Patch by: Todd Larsen
Todd Larsen <tlarsen@google.com> [Mon, 27 Oct 2008 18:36:19 +0000] rev 424
Use nice "plus" and "minus" symbols from Google Code, instead of current
triangles, for sidebar menu.
Patch by: Todd Larsen
Augie Fackler <durin42@gmail.com> [Sun, 26 Oct 2008 21:36:29 +0000] rev 423
Add javascript expandable menus.
Patch by: Dmitri Gaskin
Review by: Augie Fackler
Augie Fackler <durin42@gmail.com> [Sun, 26 Oct 2008 21:26:35 +0000] rev 422
Add jQuery.
Patch by: Dmitri Gaskin
Review by: Augie Fackler
Augie Fackler <durin42@gmail.com> [Sun, 26 Oct 2008 00:57:33 +0000] rev 421
Remove bogus import from a previous iteration.
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 26 Oct 2008 00:52:23 +0000] rev 420
Remove newlines in sidebar
Augie Fackler <durin42@gmail.com> [Sun, 26 Oct 2008 00:27:17 +0000] rev 419
Start a test system for the webapp itself.
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 26 Oct 2008 00:13:26 +0000] rev 418
Always check if a user filled in a user profile
Also, if there is no checks defined, still do the general
checks.
Tim Ansell <mithro@gmail.com> [Sat, 25 Oct 2008 22:28:31 +0000] rev 417
Do not include attributes which are inherited.
Also some extra comments.
Review URL: http://codereviews.googleopensourceprograms.com/1603
Tim Ansell <mithro@gmail.com> [Sat, 25 Oct 2008 22:26:34 +0000] rev 416
Run with Python 2.5
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 23 Oct 2008 12:00:29 +0000] rev 415
Fix typo in models/public.html template. Changes in Host Public Profile template (new header title and deletion of some fields).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 23 Oct 2008 11:42:22 +0000] rev 414
Fix mistakes in Host List templates. Change Host List second row to Sponsor name instead of Sponsor link name.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 23 Oct 2008 11:20:35 +0000] rev 413
Rename Host list templates from group_<something> to host_<something> and move then to soc/host/list folder. Update affected files with new paths.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 23 Oct 2008 09:47:38 +0000] rev 412
Fix Sponsor profile edit/create template. Don't show "View Sponsor Public Profile" link and Delete button in Create Sponsor view.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 23 Oct 2008 09:08:02 +0000] rev 411
Addresses comments to r866.
http://code.google.com/p/soc/source/detail?r=866
Patch by: Pawel Solyga
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 23 Oct 2008 05:21:41 +0000] rev 410
Moved all key_name related things to the logic modules
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 23 Oct 2008 05:21:26 +0000] rev 409
Addressed comments by Pawel and Todd
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 22 Oct 2008 17:18:57 +0000] rev 408
Inherit from BaseForm in all forms instead of from DbModelForm. This change doesn't include changes to templates and usage of as_table everywhere (work in progress).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 22 Oct 2008 17:03:08 +0000] rev 407
Fix not working Create views (committed in r864). Check if entity exist in constructKeyNameSuffix funtion and apply changes to affected files.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 22 Oct 2008 16:55:35 +0000] rev 406
Fix some wrong paths to templates (committed in r864).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 22 Oct 2008 16:21:50 +0000] rev 405
Add Google Analytics support to Site Settings. The reason I created additional SettingsValidationForm is because you cannot inherit from Form that has already defined Meta class, so it's sort of workaround for that. I didn't want to have same validation functions in both Form classes.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 22 Oct 2008 06:20:02 +0000] rev 404
Added a Host profile and generalized some views
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 22 Oct 2008 06:19:12 +0000] rev 403
Some more improvements to the generic view code
Namely getEmptyKeyFields and constructKeyNameSuffix,
some whitespace issues, and a few extra fields in the
context.
Patch by: Sverre Rabbelier
Reviewd by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Tue, 21 Oct 2008 01:22:36 +0000] rev 402
Incorperated suggestions by Todd
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 20 Oct 2008 23:24:41 +0000] rev 401
Make use of the new generic views
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 20 Oct 2008 23:24:32 +0000] rev 400
Added a generic version of the Document views
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 20 Oct 2008 23:24:21 +0000] rev 399
Various improvements to the generic View code
Among others:
* Added the 'page' argument to the simple.errorResponse call
* Pass the result of getEmptyKeyFields to edit() in create()
* Fix typo's in error responses
* Fixed a todo to properly redirect on create
* Made editPost return something when the form is not valid
* Added an _editGet hook
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 20 Oct 2008 23:24:07 +0000] rev 398
Rename 'existing_doc' and 'document' to entity
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 20 Oct 2008 23:23:53 +0000] rev 397
Remove the google search box and the google analytics page
These are left over from the mockups (removed because they
caused long wait times when no internet connection is
available).
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 20 Oct 2008 23:23:43 +0000] rev 396
Improve the error message for getIfFields
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Mon, 20 Oct 2008 22:18:32 +0000] rev 395
Add documentation in response to Pawel's comments:
http://code.google.com/p/soc/source/detail?r=832
Patch by: Todd Larsen
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 19 Oct 2008 21:12:08 +0000] rev 394
Add BaseForm class to soc.views.helper.forms module (work in progress). This changes the way as_table function displays the form (for more information have a look into doc string). BaseForm is going to be used for all forms in Melange in future. Right now it's still missing custom form errors labels and "required" text in 3rd column, but that's added as TODO and I'm working on it.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 19 Oct 2008 21:08:08 +0000] rev 393
Add colon after label in _field_as_table_row template for consistency reasons with form.as_table output.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 19 Oct 2008 18:00:14 +0000] rev 392
Add "View Sponsor Public Profile" to Sponsor Edit view template. Remove not needed <p> in home/public.html template. Add missing '$' at the end of some urls in site/map.py module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 19 Oct 2008 17:33:44 +0000] rev 391
Address comments to r844 and r845.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 19 Oct 2008 16:17:32 +0000] rev 390
Remove unused imports, fix too long lines and indentions.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 19 Oct 2008 13:14:40 +0000] rev 389
Fix identions, too long lines, unused imports and some other mistakes.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 19 Oct 2008 13:06:20 +0000] rev 388
Add pylint configuration file (pylintrc) and do_pylint.sh script which runs pylint checkers on Melange code using pylintrc file as config. do_pylint.sh as default shows additional information like reports, TODOs, code similarities and unused imports, but you can run it in silent mode (--silent) which disables all of that. The only problem with unused imports in pylint right now is that it doesn't work in the situation described in last example at http://code.google.com/p/soc/wiki/PythonStyleGuide#Packages, so sometimes we get unused import soc when we actually shouldn't. However this can be fixed by writing pylint plugins (our own checkers) in future.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 19 Oct 2008 00:34:33 +0000] rev 387
Addressed comments by Todd on r822
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 18 Oct 2008 21:55:38 +0000] rev 386
Fix identions in reflistprop module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 18 Oct 2008 21:54:13 +0000] rev 385
Remove not used imports in models. Fix missing spaces in models when operator not preceded by a space. Add missing ugettext_lazy import to Proposal model.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 18 Oct 2008 17:49:46 +0000] rev 384
Add missing ugettext_lazy for string in soc.views.user.profile module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 18 Oct 2008 17:27:53 +0000] rev 383
Fix missing keyword argument in soc.views.user.profile.create() function when calling edit().
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sat, 18 Oct 2008 17:25:04 +0000] rev 382
Change Sponsor delete url from /site/sponsor/profile/<link_name>/delete to /site/sponsor/profile/delete/<link_name> to match convention used in Document delete url.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Chen Lunpeng <forever.clp@gmail.com> [Sat, 18 Oct 2008 05:59:04 +0000] rev 381
Fixed not working to edit a doc that selected from the docs list view. soc/templates/soc/docs/list/docs_row.html not full updated.
Patch by: Chen Lunpeng
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 18 Oct 2008 05:30:57 +0000] rev 380
Change the "Site home page Document is missing" default text to give
instructions similar to those in the Site Settings form.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 18 Oct 2008 05:26:53 +0000] rev 379
Remove another now-empty templates directory.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 18 Oct 2008 05:25:47 +0000] rev 378
Nothing left in this templates directory, so remove it.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 18 Oct 2008 05:11:37 +0000] rev 377
Refactor various site views into more generic locations, in preparation for
using access permissions to decide the fuctionality in the view, instead of
having lots of cut-and-paste copies of the same view functions.
site/home.py into more generic home.py
site/settings.py into more generic settings.py
site/docs/list.py into more generic docs/list.py
site/docs/edit.py into more generic docs/edit.py
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 18 Oct 2008 04:56:39 +0000] rev 376
Add a style that appears in form error lists produced by Django Forms and
make it match the style of the existing td.formfielderror used by the
field_as_table_row helper.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 18 Oct 2008 01:51:02 +0000] rev 375
Create package for soon-to-be-refactored group/home.py and group/settings.py
packages.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 18 Oct 2008 01:47:02 +0000] rev 374
Add the Page object to the context of each view. Update templates to make
use of the newly-available page.long_name and page.short_name.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 18 Oct 2008 01:35:08 +0000] rev 373
Add the Page object to the context of each view method. Also, add some missing
Arg: sections to __doc__ strings and fix the missing context issue in
editPost() and editGet().
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 18 Oct 2008 01:32:40 +0000] rev 372
Formalize the concept of a NonPage that can appear in the site-map, useful for
non-clickable sidebar menu divisions, for example. Convert "hacky" fake Pages
into NonPages in the site-map.
Also, pass page=self to every view as a keyword argument when generating the
Django urlpatterns.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 18 Oct 2008 01:00:10 +0000] rev 371
Add a relative symlink pointing at ../rietveld/upload.py in thirdparty/chromium
so that gcl.py can import the thirdparty/rietveld/upload.py module.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 17 Oct 2008 23:10:49 +0000] rev 370
Replace missing:
from google.appengine.api import users
that appears to have been removed by r824. Needed by call in the edit() view
to users.get_current_user().
Patch by: Todd Larsen
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 17 Oct 2008 13:57:54 +0000] rev 369
Replace GROUP_TYPE_PLURAL and GROUP_TYPE_SHORT constants in Group models with more generic TYPE_NAME, TYPE_NAME_SHORT, TYPE_NAME_PLURAL names and apply changes in affected files. Use ugettext_lazy for TYPE_NAME and TYPE_NAME_PLURAL constants. This approach is similar to the upcoming refactor of views.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 17 Oct 2008 13:04:51 +0000] rev 368
Move TODO about isDeletable Sponsor logic method to sponsor.py module and extend a little bit doc string.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 17 Oct 2008 12:52:02 +0000] rev 367
Remove not needed request argument in view decorator.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Chen Lunpeng <forever.clp@gmail.com> [Fri, 17 Oct 2008 02:43:39 +0000] rev 366
Fixed not working after click the "List Site Sponsors" in site menu bar. due to wrongly imported modules.
Patch by: Chen Lunpeng
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 23:31:57 +0000] rev 365
Create decorators module in view/helper and add view decorator that catches exceptions like DeadlineExceededError, MemoryError, AssertionError (this code is being moved from respond function). Add view decorator to all view functions. In addition remove not needed imports from all affected files and fix too long lines.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 16 Oct 2008 23:26:58 +0000] rev 364
Last commit missed the new __init__.py file
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 16 Oct 2008 23:23:16 +0000] rev 363
Add a framework for generic views
This commit does not enable the new code, as such there
should be no change in functionality. In order to use the
new code the maps.py file should be updated to point at the
new views/models/sponsor.py module.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 16 Oct 2008 18:08:35 +0000] rev 362
entity_type is not the same as entity_type_short
The previous commit wrongfully assumed this.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 17:34:10 +0000] rev 361
Make page argument required for errorResponse and requestLogin functions in simple.py and update affected files. Some keyword argument changes to in user/profile.py. All the changes are based on comments to r817.
http://code.google.com/p/soc/source/detail?r=817
Patch by: Pawel Solyga
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 16 Oct 2008 17:30:58 +0000] rev 360
Rename 'group' to 'entity' in the Django templates
This allows for generic use of these templates.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 16:05:08 +0000] rev 359
DeadlineExceededError in the recent version of AppEngine lives only in one place so there is no need to try import it from both runtime (deployed) and runtime.apiproxy_errors (dev server) modules anymore.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 15:22:41 +0000] rev 358
Add page=None parameter to all views. Information from page argument (which is soc.logic.site.page.Page object) is going to be used later in views code and for some context values. Fix some indentions in __doc__ strings. Add proper __doc__ string for all() function in sponsor/list.py module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 15:12:00 +0000] rev 357
Some indention fixes in access.py module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 13:18:59 +0000] rev 356
Change name of login_request variable in access.py module to login_response.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 13:16:46 +0000] rev 355
Change name of getUserFromLinkNameOrDie function to getUserFromLinkNameOr404 and apply changes to affected files.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 13:14:13 +0000] rev 354
Fix mistakes in docs and comments in logic/models/base.py.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Chen Lunpeng <forever.clp@gmail.com> [Thu, 16 Oct 2008 09:14:26 +0000] rev 353
Log Fix not working after click the "Site Settings" in home page. templete wasn't updated when soc/app/soc/logic/site/map.py was update.
Patch by: Chen Lunpeng
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 16 Oct 2008 09:05:02 +0000] rev 352
Remove #docsummary class from css file as it is not used anymore. Add #createdby class in css file. Fix typo in docs/profile.html template. Put document content in <div class='content'>.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 16 Oct 2008 04:37:13 +0000] rev 351
Eliminate the Work.abstract property and move the Document.content property
to Work.content instead. Update affected views, and re-base some classes
that were deriving from Document just to get Document.content to now be
derived from Work instead.
The Document class now has a "pass" body with no additional properties. It
is debatable whether Work should become Document, since I am not sure that
we plan to be able to generically display, say, a Quiz or a Question (which
are Works) on the home page (which can only specifically display a Document,
or now, the basic Work entity...).
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 16 Oct 2008 04:30:26 +0000] rev 350
"new" is a little bit redundant in the short_name of sidebar menu items that
already begin with "Create...", since that implies the result will be something
new.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Thu, 16 Oct 2008 04:27:07 +0000] rev 349
A quick-and-dirty way to create non-link sub-menu dividers, plus a TODO on
how this should be formalizes to not be so hacky.
This change was inspired by the ever-growing "Site" sidebar menu.
Patch by: Todd larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 15 Oct 2008 21:31:36 +0000] rev 348
Should have been part of recent r806.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 15 Oct 2008 21:27:47 +0000] rev 347
First phase of making the / (site/home) view generic enough to use it for
Sponsor "home" page, Program "home" page, Organization "home" page, etc. when
combined with HomeSettings.
First phase of addressing this issue:
http://code.google.com/p/soc/issues/detail?id=64
by factoring "Site Settings" apart from the site/home stuff.
Patch by: Todd Larsen
Review by: Pawel Solyga
Review URL: http://codereviews.googleopensourceprograms.com/1405
Todd Larsen <tlarsen@google.com> [Wed, 15 Oct 2008 21:23:29 +0000] rev 346
Add the empty directory where site/home/edit.html is moving, to see if this
fixes a problem with gcl.py.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Oct 2008 20:27:40 +0000] rev 345
Update TinyMCE wiget code according to r783. I hope I did it correctly this time.
http://code.google.com/p/soc/source/detail?r=783
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Oct 2008 20:24:02 +0000] rev 344
Change verbose_name of founder property in Group model from "Created by" to "Founded by". Add GROUP_TYPE_SHORT and GROUP_TYPE_PLURAL for all models that inherit from Group and use that values in templates and contexts. Assume that group_type, group_type_short and group_type_plural are defined in context and remove not needed ifs in templates. Rename "Linkname" to "Link name" in list/group_heading.html template.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Oct 2008 20:10:07 +0000] rev 343
Remov "founder" text from the first line of edit.py, this is fix to r799 commit.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 15 Oct 2008 19:33:50 +0000] rev 342
Remove the proposed WorksAuthors many:many relation and promote the "founder"
property from Document up to Work. Update all subclasses of Work and any
affected views accordingly. This addresses review comments here:
http://code.google.com/p/soc/source/detail?r=786
Patch by: Todd Larsen
Review by: to-be-reviewed
Tim Ansell <mithro@gmail.com> [Wed, 15 Oct 2008 18:06:07 +0000] rev 341
Fixed the evil black logo.
Tim Ansell <mithro@gmail.com> [Wed, 15 Oct 2008 18:03:21 +0000] rev 340
Make this file excutable by default.
Todd Larsen <tlarsen@google.com> [Wed, 15 Oct 2008 17:10:27 +0000] rev 339
Define the Models for implementing Quizzes (collections of Questions) and their
Responses (collections of Answers to those Questions). These Models would
form the basis of storage for such items as:
Terms of Service (Quiz)
Question ("I agree...")
Response -> Answer (answer to "I agree..." confirmation)
solution ("Yes" Answer to the "I agree..." Question)
Mentor and Student surveys (Quiz)
Questions (including "Pay this student?")
Response -> Answers
solution ("Yes" Answer to the "Pay this student?" Question)
Organization applications
Student Proposal review, comment, and scoring system
GHOP task tracking (a specific task list item would be a Quiz)
Patch by: Todd Larsen
Review by: Pawel Solyga, Sverre Rabbelier, Chen Lunpeng
Review URL: http://codereviews.googleopensourceprograms.com/1403
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Oct 2008 14:06:33 +0000] rev 338
Show "Created by" read-only field in Document Edit view. Update size of TinyMCE widget in Document Edit/Create views. Change user property name to founder in Document model and update files according to this change (now founder is used in Group and Document models). Remove not used variables and imports in views/site/docs/edit.py. Refactor EditForm and CreateForm in views/site/docs/edit.py so that EditForm inherits from CreateForm and just extends it.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Oct 2008 13:59:52 +0000] rev 337
Show "Created by" read-only field in Sponsor Edit view. Fix function keyword arguments in sponsor/list.py to follow our PythonStyleGuide. Sponsor founder property is not updated anymore when editing Sponsor profile, it's just saved once when creating Sponsor profile.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Oct 2008 13:54:00 +0000] rev 336
Fix not working docs show view. Document show view wasn't updated when the logic refactor was made.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Oct 2008 13:51:31 +0000] rev 335
Changes to TinyMCE widget that enable to pass mce_settings in the class constructor and that way update default settings if needed.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Oct 2008 13:49:17 +0000] rev 334
Add nameHomeSettings function to key_name module. Add HomeSettings logic.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Oct 2008 13:47:10 +0000] rev 333
Update comments in models/group.py (changed Optional to Required). Add verbose_name to founder property in Group model.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Oct 2008 22:57:52 +0000] rev 332
Fix bug that caused Lookup user by User Account not to work properly. Basically wrong parameter to models.user.logic.getFromFields().
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Oct 2008 22:35:46 +0000] rev 331
Add deleted in r732 (don't know why) functionality that displays custom Error page when linkname in Developer User Profile url doesn't exist (/site/user/profile/<not_existing_linkname>).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Oct 2008 22:20:55 +0000] rev 330
Add underscore in two word div class names in templates (nick_name, short_name, partial_path).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 14 Oct 2008 21:39:57 +0000] rev 329
Add is_featured boolean property to the Work model, so that Works can be
designated as "featured" items in various places in the UI. This will be
used to allow Sponsors, Programs, and Organizations to select Documents that
should be included in their sidebar menus.
Perhaps featured "site" Documents, such as site-wide Terms of Service,
should probably be listed below the "User (sign-out)" menu, since the User
will have to read and agree to these before being allowed to use the site.
A collapsable Javascript sidebar is probably going to be needed soon...
Patch by: Todd Larsen
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Oct 2008 21:33:57 +0000] rev 328
Add missing blank lines, clean up the doc string and remove white spaces at the end of the lines in reflistprop.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Oct 2008 21:06:23 +0000] rev 327
Move <div id='notice'> into notice block in base.html template. Change formatting of notice block to make it much easier to "parse" visually. This patch is based on comments to r722.
http://code.google.com/p/soc/source/detail?r=722
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Tue, 14 Oct 2008 21:02:28 +0000] rev 326
Add a third-party ReferenceListProperty class. This is going to be used to
contain the references to Questions that make up a Quiz.
Patch by: Todd Larsen
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Oct 2008 20:33:20 +0000] rev 325
Fix some defects for lookup user view. More information about the patch can be found under the link below.
http://groups.google.com/group/melange-soc-dev/browse_thread/thread/5d378c8d3679945f/d1e7cc3a53adda4e
Patch by: Chen Lunpeng
Review by: Pawel Solyga
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Oct 2008 16:10:07 +0000] rev 324
Add missing import in soc/views/site/sponsor/list.py which caused exception when app was deployed and first site you visited was "List Site Sponsors". Update files according to recent django update and django backwards incompatibility (for example newforms is changed to forms).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Oct 2008 16:00:59 +0000] rev 323
Load ../vendor/django into trunk/app/django.
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Oct 2008 12:36:55 +0000] rev 322
Fixed imports sorting based on comments for r751.
http://code.google.com/p/soc/source/detail?r=751
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Tue, 14 Oct 2008 12:02:42 +0000] rev 321
Some indentations fixes. Changed all the email=id function arguments to email=id.email().
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 13 Oct 2008 22:32:09 +0000] rev 320
Some indentations fixes and ugettext_lazy() wrap up for DEF_DEV_LOGOUT_LOGIN_MSG_FMT in access.py.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 13 Oct 2008 22:22:16 +0000] rev 319
Rename soc/logic/models/settings.py to model site_settings.py and apply import name change to soc/views/site/home.py
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 13 Oct 2008 22:18:54 +0000] rev 318
Fix typos in doc string in sponsor.py and settings.py
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 13 Oct 2008 22:04:42 +0000] rev 317
Remove spaces between dict key name and colon. Fix some typos based on comments http://code.google.com/p/soc/source/detail?r=739.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 13 Oct 2008 21:54:51 +0000] rev 316
Add missing blank lines between imports and sort all of the imports.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 13 Oct 2008 21:34:07 +0000] rev 315
Add missing blank lines between imports in access.py module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 13 Oct 2008 17:41:20 +0000] rev 314
Rearrange imports in home.py so they apply to new discussed format (separate "from ..." and "import ..." blocks). Add Delete Document functionality.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 13 Oct 2008 06:19:43 +0000] rev 313
Bugfixes to the latest revision
Some pages did not work due to missing imports, or wrongly
imported modules.
Patch by: Chen Lunpeng
Reviewd by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 13 Oct 2008 04:34:14 +0000] rev 312
Added missing models/__init__.py and removed empty logic/model directory
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 18:40:32 +0000] rev 311
Dictionaries need String values for keys
The cleanup patch earlier mistakenly used raw names as keys
to the dictionary (such as one would do in a function call).
This fixes that mistake.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 18:32:43 +0000] rev 310
Removed now-obsolete code from model.py and __init__.py
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 18:30:37 +0000] rev 309
Made the existing code use the new soc.logic.models
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 18:11:20 +0000] rev 308
Added invididual model logic files
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 16:50:28 +0000] rev 307
Also removed helper directory
Which somehow did not get removed with the last commit
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 16:47:39 +0000] rev 306
Removed obsolete logic directories and added one for model
The model/ directory will contain the Base logic classes.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 15:52:19 +0000] rev 305
Minor style and import fixes
Incorperated changes as suggested by Todd and Pawel.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 15:05:50 +0000] rev 304
Missing changes to soc.views.helper.access
Due to having to manually do the 'svn mv' of logic to helper,
the changes to access.py got lost, this commit fixes that.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 14:58:47 +0000] rev 303
Moved soc/logic/helper/access to soc/views/helper/access
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 12 Oct 2008 08:46:05 +0000] rev 302
Fix not working delete Sponsor functionality after recent commit. Add delete() method to Base class. Make soc.views.site.sponsor.delete() request handler use this method.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 12 Oct 2008 08:43:41 +0000] rev 301
Fix not working isIdDeveloper() function after recent commit. There is still confusion within getFormFields method (email is not id), but this change doesn't address that problem.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 12 Oct 2008 01:08:41 +0000] rev 300
Changed location of the svn command in svn_load_dirs.pl script from '/usr/bin/svn' to 'svn'. That makes the script more universal and it should work on Linux, Windows and Mac OS X if the svn is in the PATH.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 00:12:53 +0000] rev 299
Refactor nearly all the soc.logic code to use the Base class
Instead of having a lot of duplicate code, this patch aims
to reduce this duplication by introducing a Base abstraction.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Oct 2008 00:08:54 +0000] rev 298
Replace almost all occurences of linkname with link_name
In an attempt to have some atomicness in these commits
this patch does a rename for the sake of consistency.
Not all were changed, but the next commit will address that.
Patch by: Sverre Rabbelier
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 10 Oct 2008 13:14:24 +0000] rev 297
Load /Users/solydzajs/Downloads/google_appengine/ into
trunk/thirdparty/google_appengine.
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 10 Oct 2008 06:56:56 +0000] rev 296
Add missing __init__.py to soc/logic/helper folder (Caused home page not to work).
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 09 Oct 2008 23:50:00 +0000] rev 295
Removed now-obsolete getAltResponse* methods from simple.py
The getAltResponse* methods have been replaced by the check*
methods in soc.logic.helper.access.
Patch by: Sverre Rabbelier
Reviewed by: Pawel Solyga, Augie Fackler, Todd Larsen
Reviewed at: http://codereviews.googleopensourceprograms.com/1601
Review id: 1601
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 09 Oct 2008 23:48:20 +0000] rev 294
Refactor existing code to use the new access module
Instead of ending up with many different ways to do
access control, we end up having only one centralized
place wher access control is done.
Patch by: Sverre Rabbelier
Reviewed by: Pawel Solyga, Augie Fackler, Todd Larsen
Reviewed at: http://codereviews.googleopensourceprograms.com/1601
Review id: 1601
Sverre Rabbelier <srabbelier@gmail.com> [Thu, 09 Oct 2008 23:38:27 +0000] rev 293
Add an access control module
The module's purpose is to check access requirements,
(such as being logged in), and raise an exception
containing a authentication request when the requirement
is not met.
Patch by: Sverre Rabbelier
Reviewed by: Pawel Solyga, Augie Fackler, Todd Larsen
Reviewed at: http://codereviews.googleopensourceprograms.com/1601
Review id: 1601
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 18:11:37 +0000] rev 292
Enable recently commited delete Sponsor request handler (added to map.py) and Delete button in Sponsor edit view. Still missing "Are you sure ?" question box.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 18:06:50 +0000] rev 291
Create a submit_buttons blocks in all edit view templates and put submit buttons in separate html table (not as part of the fields table anymore).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 15:10:51 +0000] rev 290
Create a submit_buttons block in group edit profile template so that submit buttons can be customized. Replace submit_message usage with new notice block (still work in progress in Lookup User views). Add customized edit profile template for Sponsor with delete button (not used yet, upcoming commit). Add delete Sponsor request handler.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 13:56:42 +0000] rev 289
Add notification bar block in base.html template.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 13:50:44 +0000] rev 288
Add #notice class declaration in soc.css for upcoming notification bar.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 13:49:41 +0000] rev 287
Update indexes in index.yaml file.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 08 Oct 2008 21:22:50 +0000] rev 286
Fix typo in getSponsorFromLinkName (key_name variable name instead of sponsor_key_name). Add deleteSponsor function for deleting Sponsor entities from datastore.
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 05 Oct 2008 13:27:49 +0000] rev 285
Style fix, as requested by Todd to dict usage
Use "dict['key'] = value" instead of "dict.update({'key' : 'value'})"
when updating only one key.
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 07:22:43 +0000] rev 284
Call soc.logic.site.map.getDjangoUrlPatterns() to construct the urlpatterns
from the site map, rather than explicitly listing them in app/urls.py.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 07:20:48 +0000] rev 283
Update soc/logic/site/sidebar.py to use parts of the "site map" in
soc/logic/site/map.py to generate portions of the sidebar menu.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 07:17:00 +0000] rev 282
A site layout ("site map") of the web application, including URL regular
expression patterns, Django views, and metadata for constructing sidebar menus
and (eventually) breadcrumbs.
One function, soc.logic.site.map.getDjangoUrlPatterns(), converts these details
into urlpatterns for use by Django.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 07:14:11 +0000] rev 281
Url and Page classes used to encapsulate the "site map" information (URL
regular expressions, Django views, menu item names, etc.) and the relation
between pages in the site map.
There are still lots of TODOs in this first pass.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 06:25:07 +0000] rev 280
urllib.quote() is needed by the soc/logic/site/map.py work, so import it from
the Python 2.5.2 sources. The entire urllib.py is not supported by Google
App Engine (yet?), since it relies on 'import socket' (App Engine provides a
separate urlfetch module instead).
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 05:00:13 +0000] rev 279
Remove now-empty soc/views/helpers (everything has moved to soc/views/helper).
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 04:51:43 +0000] rev 278
Add create() wrapper views that simply call the existing edit() views, to
produce unique view names in preparation for the soc/logic/site/map.py code.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 04:42:37 +0000] rev 277
Speed up average case by appending remainder of original choices list unchanged
(avoiding remaining str -> int type conversions) once the insertion point is
found.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 04:34:16 +0000] rev 276
Move helpers/html_menu.py to helper/html_menu.py, to clear out
soc/views/helpers for deletion.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 04:32:28 +0000] rev 275
A specialized SortedDict used by soc/logic/site/page.py.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 23:59:49 +0000] rev 274
Move helpers/forms_helpers.py to helper/forms.py.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 23:24:12 +0000] rev 273
Move helpers/templatetags to helper/templatetags.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 23:17:49 +0000] rev 272
Move helpers/response_helpers.py to helper/responses.py.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 23:08:28 +0000] rev 271
Replace helpers/custom_widgets.py with helper/widgets.py.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 23:01:49 +0000] rev 270
Move helpers/template_helpers.py to helper/templates.py.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 22:17:05 +0000] rev 269
Move helpers/request.py to helper/requests.py to avoid conflict with common
local variable name "request".
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 22:09:32 +0000] rev 268
Move helpers/list.py to helper/lists.py to avoid conflict with built-in type
name "list".
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 21:59:32 +0000] rev 267
Replace soc/views/helpers/request_helpers with soc/views/helpers/request.py
and replace uses of request_helpers. with helpers.request. instead.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 21:41:12 +0000] rev 266
Move soc/views/helpers/list_helpers.py to soc/views/helpers/list.py and change
uses from list_helpers. to helpers.list. instead.
Patch by: Todd Larsen
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 17:21:41 +0000] rev 265
List views should have a selectable pagination "page" length:
http://code.google.com/p/soc/issues/detail?id=59
Patch by: Chen Lunpeng and Todd Larsen
Review by: Augie Fackler
Review URL: http://codereviews.googleopensourceprograms.com/1201
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 07:03:11 +0000] rev 264
Change to imports to follow the style guide:
http://code.google.com/p/soc/wiki/PythonStyleGuide#Module_and_package_imports
Specifically:
"Use from x import y only when x is a package and y is a module."
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 01:32:34 +0000] rev 263
Make findNearestUsers() code in soc/logic/site/id_user.py more generic and
move it to soc/logic/model.py. Orginal findNearest...() functions in
id_user.py are now convenience wrappers.
Add typed-query string construction functions to model.py.
Move getFulLClassName() from key_name.py model.py, since it has more to do
with Model types than key names.
Swap 'offset' and 'limit' and make 'limit' arguments non-optional. Also,
stop adding 1 inside the ...ForLimitAndOffset() functions and make the
callers do it (since it was being added for a very UI-specific reason of
whether or not to display a "Next>" link).
Patch by: Todd Larsen
Review by: Pawel Solyga
Review URL: http://codereviews.googleopensourceprograms.com/1401
Todd Larsen <tlarsen@google.com> [Thu, 02 Oct 2008 20:22:15 +0000] rev 262
Factor out an isIdAvailable() function from EditForm.clean_id() in
soc/views/site/user/profile.py and add it to soc/logic/site/id_user.py.
Addresses some comments on r614.
Patch by: Todd Larsen
Review by: Pawel Solyga
Review URL: http://codereviews.googleopensourceprograms.com/1202
Todd Larsen <tlarsen@google.com> [Thu, 02 Oct 2008 15:37:18 +0000] rev 261
Add Allen (Chen Lunpeng) to trunk/AUTHORS, due to his several recent patches.
Todd Larsen <tlarsen@google.com> [Thu, 02 Oct 2008 15:36:08 +0000] rev 260
Fix typo in recent validate.py changes (r682).
Patch by: Chen Lunpeng
Review by: Todd Larsen
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 22:19:22 +0000] rev 259
Add basic Sponsors List, Create New Sponsor, Sponsor Public Profile views. Change all properties in Group model as required for now. Remaining TODO: write validation functions for Sponsor edit and create form fields that need additional validation (like address, phone number format).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 22:12:26 +0000] rev 258
Add Sponsor logic functions.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 22:10:52 +0000] rev 257
Add group templates that can be used by Sponsor, Organization, School, Club views. Right now only upcoming commit of Sponsor views is using it.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 22:02:50 +0000] rev 256
Remove excluded field inheritance_line, since the User model does not inherit
from PolyModel (at this time).
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 21:58:31 +0000] rev 255
Add colon at the of _readonly_field_as_table_row template tag label parameter. Replace hardcoded labels in User Public profile template with linkname_user.fields.<field_name>.label values.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 21:53:52 +0000] rev 254
Fix missing blank line to follow PythonStyleGuide in model.py.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 21:21:03 +0000] rev 253
Add links in sidebar for upcoming Sponsor views.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 21:19:32 +0000] rev 252
Change key_name module usage to path_linkname module (fix to previous commit). Add comments about urls. Add Sponsor views urls for upcoming Sponsor views modules.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 20:52:39 +0000] rev 251
Move path and link_name related functions and regex patterns to a new
soc/logic/path_linkname.py module, and fix all dependencies. path/link_name
functionality is becoming the generic way to identify entities in the Datastore
in a URL-compatible way.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 20:48:58 +0000] rev 250
Make form field components use a smaller font, without shrinking the font
of all text in the page body.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 19:21:09 +0000] rev 249
Replace common module with validate module. Move validation function from feed module to validate module and remove feed.py. Correct any usage of validation functions from common and feed modules into validate module.
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 19:17:13 +0000] rev 248
Add missing blank line to follow PythonStyleGuide in document.py
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 19:15:20 +0000] rev 247
Fixed typo in DEF_CREATE_NEW_DOC_MSG.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 16:47:00 +0000] rev 246
Shrink the sidebar menu separately from the main body text.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 14:23:28 +0000] rev 245
Moved isLinkNameFormatValid function out of id_user module to new common module. This function is going to be used by other form validation functions that require to validate linkname (different kind of Groups, Programs etc).
Patch by: Pawel Solyga
Review by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 09:43:25 +0000] rev 244
Fixed models based on output from graph.py script and comments on
http://groups.google.com/group/melange-soc-dev/browse_thread/thread/fb532a7db1f19ea7
Tim Ansell <mithro@gmail.com> [Wed, 01 Oct 2008 07:26:45 +0000] rev 243
Tool to graph the data model.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 07:11:27 +0000] rev 242
Some TODOs on access control that I didn't want to forget.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 07:10:43 +0000] rev 241
Matching just /docs created a very small namespace, since any other path parts
would match the Document path. So, append /show after /docs for the display
view. This makes other views like /docs/edit possible later.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 07:01:06 +0000] rev 240
URL pattern changes that were missed by r671.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 07:00:26 +0000] rev 239
Some styles used by r671, the simplistic Document view.