Sverre Rabbelier <srabbelier@gmail.com> [Mon, 20 Apr 2009 22:52:05 +0000] rev 2262
Set batch size to 10
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 20 Apr 2009 22:51:48 +0000] rev 2261
Added index needed to convert proposals
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 20 Apr 2009 22:31:25 +0000] rev 2260
Some minor style fixes.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 20 Apr 2009 20:57:59 +0000] rev 2259
Changed the accepted and rejected list to redirect to the review page in ListProposals view.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 20 Apr 2009 20:56:56 +0000] rev 2258
Allowing student project review page to be viewed in read-only mode after the deadline has passed.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 20 Apr 2009 19:08:47 +0000] rev 2257
Fixed typo in access module naming.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Mon, 20 Apr 2009 03:44:17 +0000] rev 2256
Set new Melange version number to 0-5-20090420 in app.yaml.template.
Patch by: Pawel Solyga
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 22:51:58 +0000] rev 2255
Some minor style fixes.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 22:50:30 +0000] rev 2254
Added listing of accepted and rejected proposals to the organization proposal page.
The link will redirect to the public page where comments can still be placed.
Patch by: Madhusudan.C.S
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 22:14:35 +0000] rev 2253
Added org_home_gmap function to the map JS for displaying the mentor-student map.
Patch by: Madhusudan.C.S and Merio Ferraro
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 22:07:20 +0000] rev 2252
Added mentor-marker.png to content\images.
This is for use on the organization home pages having the map displayed.
Patch by: Madhusudan.C.S
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 22:05:25 +0000] rev 2251
Renamed map JS to facilitate upcoming changes.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 21:50:04 +0000] rev 2250
Added the gathering of data required to display a map on the org home page.
Patch by: Madhusudan.C.S
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 21:37:14 +0000] rev 2249
Added ccTld property to role to retrieve the ccTld of the country of residence for a specific role entity.
Patch by: Madhusudan.C.S
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 21:26:38 +0000] rev 2248
Added dictionary mapping country names to their CCTLD in countries model.
Patch by: Madhusudan.C.S
Reviewed by: Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 19 Apr 2009 17:42:57 +0000] rev 2247
Don't run in a transaction if not needed
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 19 Apr 2009 17:42:44 +0000] rev 2246
Tweak the 'load balancing' algorithm
In order to reduce contention we randomly skipped jobs, but this
caused many jobs to end up stopping early. Now instead we keep on
going until we time out (also increased the chance of doing work).
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 19 Apr 2009 17:42:27 +0000] rev 2245
Added deleteEntities methods to stats.py
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 16:23:29 +0000] rev 2244
Fixed typo in cron.job module's timeOutJob docstring.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 19 Apr 2009 14:48:21 +0000] rev 2243
Use status codes in job.py
The previous behavior of being able go do 'if not handler.handle' is
still valid as the status code for 'timed out' is 0.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 14:45:22 +0000] rev 2242
getDefaultMailSender now properly handles users who are logged in but not registered.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 19 Apr 2009 14:35:31 +0000] rev 2241
Allow anyone to see student projects
The required rights['show'] exception was already made, but the
any_access check was preventing it from being effictive.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 10:46:20 +0000] rev 2240
Changed the type of Error occurring when no valid sender could be found to a FatalJobError in student_proposal_mailer.
This means that the job will be immediately aborted.
This patch is due to comments on r3000 by SRabbelier.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 10:37:10 +0000] rev 2239
Students can not list their own projects before the accepted students announced deadline.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 10:29:57 +0000] rev 2238
Student Proposal Mailer is now sending out real emails.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 10:28:35 +0000] rev 2237
Fixed a comment typo and possible bug in mail_dispatcher.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 19 Apr 2009 10:26:11 +0000] rev 2236
Added email templates for accepted and rejected students in a GSoC like program.
These templates are specifically for GSoC2009 as per request in Issue 379.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 19 Apr 2009 00:07:46 +0000] rev 2235
Major brown paper bag fix
Filter was set to empty dict while it was passed in as a possibly
empty param.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 19 Apr 2009 00:07:29 +0000] rev 2234
Add a startSpam method to stats
This method creates the job responsible for sending out emails to
students.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 19 Apr 2009 00:07:17 +0000] rev 2233
Add job to the index
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 19 Apr 2009 00:07:05 +0000] rev 2232
Add a random chance to ignore a job to reduce contention
This should probably be solved better (perhaps with a binary
exponential backoff).
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 19 Apr 2009 00:06:46 +0000] rev 2231
Do not fetch all jobs with each poke
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 19 Apr 2009 00:06:29 +0000] rev 2230
Add entityIterator to base Logic
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 19 Apr 2009 00:06:12 +0000] rev 2229
Store how many times a job has timed out and abort if needed
Patch by: Sverre Rabblier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 21:34:41 +0000] rev 2228
Wrong usage of twoline_table_row caused weird layout in project
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 21:34:25 +0000] rev 2227
Add cron.yaml to the build script
Patch by: Sverre Rabbelier, Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 18 Apr 2009 21:30:58 +0000] rev 2226
Instead of text_data use key_data property to check for uniqueness.
Brown paper bag fix, querying for TextProperty is not smart ^_^.
Patch by: Lennard de Rijk, Sverre Rabbelier
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 18 Apr 2009 21:26:13 +0000] rev 2225
Style fix in Job model.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 18 Apr 2009 21:22:43 +0000] rev 2224
Hook up the Student Proposal Mailer in the cron/jobs module.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 18 Apr 2009 21:21:22 +0000] rev 2223
Added Student Proposal Mailer module for mailing students who are accepted/rejected into the program.
TODO has been added to actually sent out the emails.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 19:00:04 +0000] rev 2222
Various improvements to convertProposals
It should now be ready to convert proposals to projects and reject
all proposals that were not accepted.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 18:59:53 +0000] rev 2221
Add a silent option to updateOrCreateFromFields
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 18 Apr 2009 17:14:42 +0000] rev 2220
Fixed wrong import for list proposals view.
This seems to be working in the p3 release though.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 18 Apr 2009 15:06:36 +0000] rev 2219
Fixed typo and added myself to authors in the cron/job module.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 15:05:56 +0000] rev 2218
Add a script to convert proposals.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 18 Apr 2009 15:04:24 +0000] rev 2217
Added FatalJobError to the cron/job module.
This Error will lead to abortion of the raising job.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 18 Apr 2009 14:51:27 +0000] rev 2216
Fixed typo in documentation of the Job Model.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 18 Apr 2009 14:43:42 +0000] rev 2215
Changed the response message in the cron poke view.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 14:27:40 +0000] rev 2214
Remove debug url too
This should have been part of the previous commit.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 14:25:30 +0000] rev 2213
Remove testing method and update docstring for cron system
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 14:04:39 +0000] rev 2212
Removed unneeded imports and variables
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 14:04:11 +0000] rev 2211
Add cron, the core of the job system
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 14:03:49 +0000] rev 2210
Add priority groups and jobs to the sitemap
Also add an entry in the Site menu to list them.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 14:03:28 +0000] rev 2209
Add jobs (model, logic, and view)
Jobs are the core of the Job system, allowing distributed processing
of taks in an interuptable manner.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 14:02:56 +0000] rev 2208
Add priority groups (model, logic, and view)
Priority groups will be a key part of the Job system, allowing the
site admin to give a higher priority to certain job types on the fly.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 18 Apr 2009 14:00:30 +0000] rev 2207
The listing of accepted projects on the Organization's homepage is now timeline dependent.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 18 Apr 2009 13:59:24 +0000] rev 2206
White space fix in list_info module.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 12:49:37 +0000] rev 2205
Fix user_self calling editGet with a wrong parameter
Also fix wrong call to collectCleanedFields and stray seed
argument in user_self.
Patch by: Sverre Rabbelier, Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 12:37:12 +0000] rev 2204
Split edit and create into different methods
This makes removes unneeded responsibility from the edit view and
makes it possible to more tightly restrict the usage of the edit and
create views to only creating/editing.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 12:36:55 +0000] rev 2203
Add support for ID based entities
This allows entities that do not have a key name to be created and
edited without requiring the presence of a key_name.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 12:07:02 +0000] rev 2202
Use proposal key instead of raw proposal
Patch by: Sverre Rabbelier, Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 18 Apr 2009 11:41:56 +0000] rev 2201
Show in green the proposals that would be accepted
Patch by: Sverre Rabbelier, Lennard de Rijk
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 17 Apr 2009 22:50:16 +0000] rev 2200
Add proper generation of Student entities and StudentProposal entities to seed_db module.
Add link for generating 200 Students to seed_db.html template.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 17 Apr 2009 21:36:49 +0000] rev 2199
Rename that should have been part of r2953.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 17 Apr 2009 21:14:43 +0000] rev 2198
Renamed stepsize to step_size in Student Proposal Logic.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 17 Apr 2009 20:26:37 +0000] rev 2197
Moved the code to retrieve all Proposal which should be accepted for one Organization to the Proposal Logic module.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 17 Apr 2009 19:54:27 +0000] rev 2196
Style fixes in soc.views.helper.lists module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 17 Apr 2009 19:53:54 +0000] rev 2195
Style fixes in soc.views.models.organization module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 17 Apr 2009 19:53:23 +0000] rev 2194
Fix too long line in soc.views.models.program module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 17 Apr 2009 19:52:57 +0000] rev 2193
Comment out unused variables in soc.views.models.base module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 17 Apr 2009 19:01:26 +0000] rev 2192
Fix too long line in soc.views.helper.templatetags.forms_helpers module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Fri, 17 Apr 2009 16:23:01 +0000] rev 2191
Proposal CSV export for students.
Patch by: Matthew Wilkes
Reviewed by: Pawel Solyga
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 15 Apr 2009 23:22:11 +0000] rev 2190
Readability fix in base logic
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Wed, 15 Apr 2009 23:21:40 +0000] rev 2189
Remove redundant if check
site_logic.getSingleton() is guaranteed to return an entity.
Patch by: Sverre Rabbelier
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Apr 2009 19:13:52 +0000] rev 2188
Comment out unused variables in soc.logic.allocations module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Apr 2009 19:13:16 +0000] rev 2187
Fix too long line in soc.cache.logic module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Apr 2009 16:05:29 +0000] rev 2186
Add missing responses import and replace usage of helper.responses with just responses in soc.views.models.student module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 15 Apr 2009 15:56:17 +0000] rev 2185
Fix too long line and redefining variable 'review' from outer scope in soc.views.models.student_proposal module.
Patch by: Pawel Solyga
Reviewed by: to-be-reviewed
Daniel Bentley <dbentley@google.com> [Wed, 15 Apr 2009 08:01:17 +0000] rev 2184
Step 2 of moving to new seeding model.
Create Seeder class, which abstracts some seeding.
Move user to Seeder class, and make new OrganizationSeeder class.
If people like this, I'll finish the rest soon.
Patch by: Dan Bentley
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Apr 2009 18:44:06 +0000] rev 2183
Added additional_mentors property to StudentProject.
As per request by Issue 588.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Tue, 14 Apr 2009 18:42:27 +0000] rev 2182
Whitespace fix in sponsor model.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 13 Apr 2009 21:46:33 +0000] rev 2181
Place the getSingleton call in view decorator in the try
This way timeouts on the getSingleton() call are also catched.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 13 Apr 2009 21:32:29 +0000] rev 2180
Fix a bug in duplicate detection
This is caused by AppEngine's inability to sort a query when the
inequality or IN operator is used. See also [0].
[0] http://code.google.com/p/googleappengine/issues/detail?id=1100
Patch by: Sverre Rabbelier and Lennard de Rijk
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 13 Apr 2009 21:32:12 +0000] rev 2179
Undid superfluas replacement of .name() with .name_or_id()
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Mon, 13 Apr 2009 16:31:36 +0000] rev 2178
Fixes access check for manage view.
Added forgotten IsMyEntity check and fixed a bug introduced by a rename in r2816.
Addresses Issue 584.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 13 Apr 2009 15:31:39 +0000] rev 2177
Do not rely on dicts.merge to change target
Also make dicts.merge actually not touch target. This is much cleaner
than modifying in place, especially since we assign the result of the
dicts.merge call to target most of the time anyway.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 13 Apr 2009 15:30:48 +0000] rev 2176
Use key().id_or_name() instead of key().name()
These two cases were introduced after the previous refactoring was
done and did not follow the new behavior.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Mon, 13 Apr 2009 14:34:42 +0000] rev 2175
Fix a bug in seed_db
Using %(num)d with an int as argument doesn't work.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 12 Apr 2009 16:43:30 +0000] rev 2174
Added a warning message to alert the user that reviews are not editable.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sun, 12 Apr 2009 16:09:00 +0000] rev 2173
Added overview of private reviews to the Student Proposal review page.
Addresses Issue 496.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Pawel Solyga <Pawel.Solyga@gmail.com> [Sun, 12 Apr 2009 13:22:43 +0000] rev 2172
Load /Users/solydzajs/Downloads/google_appengine into
trunk/thirdparty/google_appengine.
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Apr 2009 13:14:03 +0000] rev 2171
Do not rely on a backup_admin being set
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Apr 2009 12:31:55 +0000] rev 2170
Send out notifications and emails to admin and backup admin
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Apr 2009 12:31:23 +0000] rev 2169
Allow the backup_admin to fill in the org application
Patch by: Sverre Rabbelier
Daniel Bentley <dbentley@google.com> [Sun, 12 Apr 2009 09:06:45 +0000] rev 2168
Use offset_linkid instead of offset to scan >1000 entities.
this is a first-cut. It works in all the ways I could make earlier
versions fail. It passes link_id as URL parameters. It also has a new
class LinkCreator which makes the main body of getListContents even easier
to write.
I wasn't sure if link_id's could have non alphanumeric characters; if so, they
need to be URL encoded/decoded.
I also need to go and remove any mention of raw offsets now, because we don't
use them.
I believe I've talked about this approach with a few of you and it sounded
reasonable. Feel free to roll-back/fix/amend/comment-for-me-to-fix. This is
my first big-logic-change to Melange.
Patch by: Dan Bentley
Daniel Bentley <dbentley@google.com> [Sun, 12 Apr 2009 06:24:14 +0000] rev 2167
Respond to comments on r2769.
Patch by: Dan Bentley
Daniel Bentley <dbentley@google.com> [Sun, 12 Apr 2009 06:21:15 +0000] rev 2166
Last step of refactoring before adding support for > 1000 entities.
Make helper functions. One extracts list parameters.
One creates links more simply. This is cleaning up the large
function body so I can move stuff around more radically.
Patch by: Dan Bentley
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Apr 2009 00:18:38 +0000] rev 2165
Add (better) help_text to publish_location and school_name
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 12 Apr 2009 00:18:19 +0000] rev 2164
Brown paper bag fix
Can't call .key() if there is no entity.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 11 Apr 2009 23:04:29 +0000] rev 2163
Added Joel Sherrill to the AUTHORS file
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 11 Apr 2009 22:59:30 +0000] rev 2162
Lower ASCII fix
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 11 Apr 2009 22:58:57 +0000] rev 2161
Remove getKeySuffix and it's usage
We can use .key().id_or_name() everywhere now.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 11 Apr 2009 22:58:19 +0000] rev 2160
Use key().id_or_name() instead of key().name()
This is to allow for the usage of auto-id's.
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 11 Apr 2009 22:57:23 +0000] rev 2159
Use key.id_or_name in templates rather than key.name
This is to allow for usage of auto-id's.
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 11 Apr 2009 17:40:41 +0000] rev 2158
Indentation fixes.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 11 Apr 2009 16:00:03 +0000] rev 2157
Indentation fixes.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 11 Apr 2009 13:42:12 +0000] rev 2156
Added two menu items to the program menu.
The first addition is a link to redirect to the Host's view for showing duplicates.
The second addition is a link for Students to an overview of all their projects in the current program.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 11 Apr 2009 13:37:31 +0000] rev 2155
Removed obsolete white line in soc/models/views/models/organization.py.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 11 Apr 2009 13:36:50 +0000] rev 2154
Added listing of Student Projects for Students themselves.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 11 Apr 2009 13:34:37 +0000] rev 2153
Added three new redirect methods.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 11 Apr 2009 13:32:35 +0000] rev 2152
Brown paper bag fix for Student Project Manage and Edit access check.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 11 Apr 2009 13:19:23 +0000] rev 2151
Style fix in function names in stats.py
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 11 Apr 2009 12:27:41 +0000] rev 2150
When ranking, put them at or above the given rank
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Sat, 11 Apr 2009 12:27:20 +0000] rev 2149
Remove slots_allocation from program view
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 10 Apr 2009 15:46:05 +0000] rev 2148
Make it possible to save any value with saveValues
Patch by: Sverre Rabbelier
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 10 Apr 2009 15:45:52 +0000] rev 2147
Allow loading a previously saved slot allocation
Patch by: Sverre Rabbelier
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 10 Apr 2009 15:32:11 +0000] rev 2146
Added Manage Student Projects item to the organization menu.
Only visible after the accepted students deadline has passed and the current user is an org admin.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 10 Apr 2009 15:24:43 +0000] rev 2145
Fixed typo in checkStudentProjectHasStatus docstring.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Lennard de Rijk <ljvderijk@gmail.com> [Fri, 10 Apr 2009 15:22:38 +0000] rev 2144
Removed TODO that has been completed in r2876.
Patch by: Lennard de Rijk
Reviewed by: to-be-reviewed
Sverre Rabbelier <srabbelier@gmail.com> [Fri, 10 Apr 2009 11:27:33 +0000] rev 2143
Fix bug exposed in previous commit
Patch by: Sverre Rabbelier