Thu, 09 Oct 2008 18:06:50 +0000 Create a submit_buttons blocks in all edit view templates and put submit buttons in separate html table (not as part of the fields table anymore).
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 18:06:50 +0000] rev 291
Create a submit_buttons blocks in all edit view templates and put submit buttons in separate html table (not as part of the fields table anymore). Patch by: Pawel Solyga Review by: to-be-reviewed
Thu, 09 Oct 2008 15:10:51 +0000 Create a submit_buttons block in group edit profile template so that submit buttons can be customized. Replace submit_message usage with new notice block (still work in progress in Lookup User views). Add customized edit profile template for Sponsor with delete button (not used yet, upcoming commit). Add delete Sponsor request handler.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 15:10:51 +0000] rev 290
Create a submit_buttons block in group edit profile template so that submit buttons can be customized. Replace submit_message usage with new notice block (still work in progress in Lookup User views). Add customized edit profile template for Sponsor with delete button (not used yet, upcoming commit). Add delete Sponsor request handler. Patch by: Pawel Solyga Review by: to-be-reviewed
Thu, 09 Oct 2008 13:56:42 +0000 Add notification bar block in base.html template.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 13:56:42 +0000] rev 289
Add notification bar block in base.html template. Patch by: Pawel Solyga Review by: to-be-reviewed
Thu, 09 Oct 2008 13:50:44 +0000 Add #notice class declaration in soc.css for upcoming notification bar.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 13:50:44 +0000] rev 288
Add #notice class declaration in soc.css for upcoming notification bar. Patch by: Pawel Solyga Review by: to-be-reviewed
Thu, 09 Oct 2008 13:49:41 +0000 Update indexes in index.yaml file.
Pawel Solyga <Pawel.Solyga@gmail.com> [Thu, 09 Oct 2008 13:49:41 +0000] rev 287
Update indexes in index.yaml file. Patch by: Pawel Solyga Review by: to-be-reviewed
Wed, 08 Oct 2008 21:22:50 +0000 Fix typo in getSponsorFromLinkName (key_name variable name instead of sponsor_key_name). Add deleteSponsor function for deleting Sponsor entities from datastore.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 08 Oct 2008 21:22:50 +0000] rev 286
Fix typo in getSponsorFromLinkName (key_name variable name instead of sponsor_key_name). Add deleteSponsor function for deleting Sponsor entities from datastore.
Sun, 05 Oct 2008 13:27:49 +0000 Style fix, as requested by Todd to dict usage
Sverre Rabbelier <srabbelier@gmail.com> [Sun, 05 Oct 2008 13:27:49 +0000] rev 285
Style fix, as requested by Todd to dict usage Use "dict['key'] = value" instead of "dict.update({'key' : 'value'})" when updating only one key.
Sat, 04 Oct 2008 07:22:43 +0000 Call soc.logic.site.map.getDjangoUrlPatterns() to construct the urlpatterns
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 07:22:43 +0000] rev 284
Call soc.logic.site.map.getDjangoUrlPatterns() to construct the urlpatterns from the site map, rather than explicitly listing them in app/urls.py. Patch by: Todd Larsen Review by: to-be-reviewed
Sat, 04 Oct 2008 07:20:48 +0000 Update soc/logic/site/sidebar.py to use parts of the "site map" in
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 07:20:48 +0000] rev 283
Update soc/logic/site/sidebar.py to use parts of the "site map" in soc/logic/site/map.py to generate portions of the sidebar menu. Patch by: Todd Larsen Review by: to-be-reviewed
Sat, 04 Oct 2008 07:17:00 +0000 A site layout ("site map") of the web application, including URL regular
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 07:17:00 +0000] rev 282
A site layout ("site map") of the web application, including URL regular expression patterns, Django views, and metadata for constructing sidebar menus and (eventually) breadcrumbs. One function, soc.logic.site.map.getDjangoUrlPatterns(), converts these details into urlpatterns for use by Django. Patch by: Todd Larsen Review by: to-be-reviewed
Sat, 04 Oct 2008 07:14:11 +0000 Url and Page classes used to encapsulate the "site map" information (URL
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 07:14:11 +0000] rev 281
Url and Page classes used to encapsulate the "site map" information (URL regular expressions, Django views, menu item names, etc.) and the relation between pages in the site map. There are still lots of TODOs in this first pass. Patch by: Todd Larsen Review by: to-be-reviewed
Sat, 04 Oct 2008 06:25:07 +0000 urllib.quote() is needed by the soc/logic/site/map.py work, so import it from
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 06:25:07 +0000] rev 280
urllib.quote() is needed by the soc/logic/site/map.py work, so import it from the Python 2.5.2 sources. The entire urllib.py is not supported by Google App Engine (yet?), since it relies on 'import socket' (App Engine provides a separate urlfetch module instead). Patch by: Todd Larsen Review by: to-be-reviewed
Sat, 04 Oct 2008 05:00:13 +0000 Remove now-empty soc/views/helpers (everything has moved to soc/views/helper).
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 05:00:13 +0000] rev 279
Remove now-empty soc/views/helpers (everything has moved to soc/views/helper). Patch by: Todd Larsen Review by: to-be-reviewed
Sat, 04 Oct 2008 04:51:43 +0000 Add create() wrapper views that simply call the existing edit() views, to
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 04:51:43 +0000] rev 278
Add create() wrapper views that simply call the existing edit() views, to produce unique view names in preparation for the soc/logic/site/map.py code. Patch by: Todd Larsen Review by: to-be-reviewed
Sat, 04 Oct 2008 04:42:37 +0000 Speed up average case by appending remainder of original choices list unchanged
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 04:42:37 +0000] rev 277
Speed up average case by appending remainder of original choices list unchanged (avoiding remaining str -> int type conversions) once the insertion point is found. Patch by: Todd Larsen Review by: to-be-reviewed
Sat, 04 Oct 2008 04:34:16 +0000 Move helpers/html_menu.py to helper/html_menu.py, to clear out
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 04:34:16 +0000] rev 276
Move helpers/html_menu.py to helper/html_menu.py, to clear out soc/views/helpers for deletion. Patch by: Todd Larsen Review by: to-be-reviewed
Sat, 04 Oct 2008 04:32:28 +0000 A specialized SortedDict used by soc/logic/site/page.py.
Todd Larsen <tlarsen@google.com> [Sat, 04 Oct 2008 04:32:28 +0000] rev 275
A specialized SortedDict used by soc/logic/site/page.py. Patch by: Todd Larsen Review by: to-be-reviewed
Fri, 03 Oct 2008 23:59:49 +0000 Move helpers/forms_helpers.py to helper/forms.py.
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 23:59:49 +0000] rev 274
Move helpers/forms_helpers.py to helper/forms.py. Patch by: Todd Larsen Review by: to-be-reviewed
Fri, 03 Oct 2008 23:24:12 +0000 Move helpers/templatetags to helper/templatetags.
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 23:24:12 +0000] rev 273
Move helpers/templatetags to helper/templatetags. Patch by: Todd Larsen Review by: to-be-reviewed
Fri, 03 Oct 2008 23:17:49 +0000 Move helpers/response_helpers.py to helper/responses.py.
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 23:17:49 +0000] rev 272
Move helpers/response_helpers.py to helper/responses.py. Patch by: Todd Larsen Review by: to-be-reviewed
Fri, 03 Oct 2008 23:08:28 +0000 Replace helpers/custom_widgets.py with helper/widgets.py.
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 23:08:28 +0000] rev 271
Replace helpers/custom_widgets.py with helper/widgets.py. Patch by: Todd Larsen Review by: to-be-reviewed
Fri, 03 Oct 2008 23:01:49 +0000 Move helpers/template_helpers.py to helper/templates.py.
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 23:01:49 +0000] rev 270
Move helpers/template_helpers.py to helper/templates.py. Patch by: Todd Larsen Review by: to-be-reviewed
Fri, 03 Oct 2008 22:17:05 +0000 Move helpers/request.py to helper/requests.py to avoid conflict with common
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 22:17:05 +0000] rev 269
Move helpers/request.py to helper/requests.py to avoid conflict with common local variable name "request". Patch by: Todd Larsen Review by: to-be-reviewed
Fri, 03 Oct 2008 22:09:32 +0000 Move helpers/list.py to helper/lists.py to avoid conflict with built-in type
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 22:09:32 +0000] rev 268
Move helpers/list.py to helper/lists.py to avoid conflict with built-in type name "list". Patch by: Todd Larsen Review by: to-be-reviewed
Fri, 03 Oct 2008 21:59:32 +0000 Replace soc/views/helpers/request_helpers with soc/views/helpers/request.py
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 21:59:32 +0000] rev 267
Replace soc/views/helpers/request_helpers with soc/views/helpers/request.py and replace uses of request_helpers. with helpers.request. instead. Patch by: Todd Larsen Review by: to-be-reviewed
Fri, 03 Oct 2008 21:41:12 +0000 Move soc/views/helpers/list_helpers.py to soc/views/helpers/list.py and change
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 21:41:12 +0000] rev 266
Move soc/views/helpers/list_helpers.py to soc/views/helpers/list.py and change uses from list_helpers. to helpers.list. instead. Patch by: Todd Larsen Review by: to-be-reviewed
Fri, 03 Oct 2008 17:21:41 +0000 List views should have a selectable pagination "page" length:
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 17:21:41 +0000] rev 265
List views should have a selectable pagination "page" length: http://code.google.com/p/soc/issues/detail?id=59 Patch by: Chen Lunpeng and Todd Larsen Review by: Augie Fackler Review URL: http://codereviews.googleopensourceprograms.com/1201
Fri, 03 Oct 2008 07:03:11 +0000 Change to imports to follow the style guide:
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 07:03:11 +0000] rev 264
Change to imports to follow the style guide: http://code.google.com/p/soc/wiki/PythonStyleGuide#Module_and_package_imports Specifically: "Use from x import y only when x is a package and y is a module."
Fri, 03 Oct 2008 01:32:34 +0000 Make findNearestUsers() code in soc/logic/site/id_user.py more generic and
Todd Larsen <tlarsen@google.com> [Fri, 03 Oct 2008 01:32:34 +0000] rev 263
Make findNearestUsers() code in soc/logic/site/id_user.py more generic and move it to soc/logic/model.py. Orginal findNearest...() functions in id_user.py are now convenience wrappers. Add typed-query string construction functions to model.py. Move getFulLClassName() from key_name.py model.py, since it has more to do with Model types than key names. Swap 'offset' and 'limit' and make 'limit' arguments non-optional. Also, stop adding 1 inside the ...ForLimitAndOffset() functions and make the callers do it (since it was being added for a very UI-specific reason of whether or not to display a "Next>" link). Patch by: Todd Larsen Review by: Pawel Solyga Review URL: http://codereviews.googleopensourceprograms.com/1401
Thu, 02 Oct 2008 20:22:15 +0000 Factor out an isIdAvailable() function from EditForm.clean_id() in
Todd Larsen <tlarsen@google.com> [Thu, 02 Oct 2008 20:22:15 +0000] rev 262
Factor out an isIdAvailable() function from EditForm.clean_id() in soc/views/site/user/profile.py and add it to soc/logic/site/id_user.py. Addresses some comments on r614. Patch by: Todd Larsen Review by: Pawel Solyga Review URL: http://codereviews.googleopensourceprograms.com/1202
Thu, 02 Oct 2008 15:37:18 +0000 Add Allen (Chen Lunpeng) to trunk/AUTHORS, due to his several recent patches.
Todd Larsen <tlarsen@google.com> [Thu, 02 Oct 2008 15:37:18 +0000] rev 261
Add Allen (Chen Lunpeng) to trunk/AUTHORS, due to his several recent patches.
Thu, 02 Oct 2008 15:36:08 +0000 Fix typo in recent validate.py changes (r682).
Todd Larsen <tlarsen@google.com> [Thu, 02 Oct 2008 15:36:08 +0000] rev 260
Fix typo in recent validate.py changes (r682). Patch by: Chen Lunpeng Review by: Todd Larsen
Wed, 01 Oct 2008 22:19:22 +0000 Add basic Sponsors List, Create New Sponsor, Sponsor Public Profile views. Change all properties in Group model as required for now. Remaining TODO: write validation functions for Sponsor edit and create form fields that need additional validation (like address, phone number format).
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 22:19:22 +0000] rev 259
Add basic Sponsors List, Create New Sponsor, Sponsor Public Profile views. Change all properties in Group model as required for now. Remaining TODO: write validation functions for Sponsor edit and create form fields that need additional validation (like address, phone number format). Patch by: Pawel Solyga Review by: to-be-reviewed
Wed, 01 Oct 2008 22:12:26 +0000 Add Sponsor logic functions.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 22:12:26 +0000] rev 258
Add Sponsor logic functions. Patch by: Pawel Solyga Review by: to-be-reviewed
Wed, 01 Oct 2008 22:10:52 +0000 Add group templates that can be used by Sponsor, Organization, School, Club views. Right now only upcoming commit of Sponsor views is using it.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 22:10:52 +0000] rev 257
Add group templates that can be used by Sponsor, Organization, School, Club views. Right now only upcoming commit of Sponsor views is using it. Patch by: Pawel Solyga Review by: to-be-reviewed
Wed, 01 Oct 2008 22:02:50 +0000 Remove excluded field inheritance_line, since the User model does not inherit
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 22:02:50 +0000] rev 256
Remove excluded field inheritance_line, since the User model does not inherit from PolyModel (at this time).
Wed, 01 Oct 2008 21:58:31 +0000 Add colon at the of _readonly_field_as_table_row template tag label parameter. Replace hardcoded labels in User Public profile template with linkname_user.fields.<field_name>.label values.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 21:58:31 +0000] rev 255
Add colon at the of _readonly_field_as_table_row template tag label parameter. Replace hardcoded labels in User Public profile template with linkname_user.fields.<field_name>.label values.
Wed, 01 Oct 2008 21:53:52 +0000 Fix missing blank line to follow PythonStyleGuide in model.py.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 21:53:52 +0000] rev 254
Fix missing blank line to follow PythonStyleGuide in model.py.
Wed, 01 Oct 2008 21:21:03 +0000 Add links in sidebar for upcoming Sponsor views.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 21:21:03 +0000] rev 253
Add links in sidebar for upcoming Sponsor views. Patch by: Pawel Solyga Review by: to-be-reviewed
Wed, 01 Oct 2008 21:19:32 +0000 Change key_name module usage to path_linkname module (fix to previous commit). Add comments about urls. Add Sponsor views urls for upcoming Sponsor views modules.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 21:19:32 +0000] rev 252
Change key_name module usage to path_linkname module (fix to previous commit). Add comments about urls. Add Sponsor views urls for upcoming Sponsor views modules. Patch by: Pawel Solyga Review by: to-be-reviewed
Wed, 01 Oct 2008 20:52:39 +0000 Move path and link_name related functions and regex patterns to a new
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 20:52:39 +0000] rev 251
Move path and link_name related functions and regex patterns to a new soc/logic/path_linkname.py module, and fix all dependencies. path/link_name functionality is becoming the generic way to identify entities in the Datastore in a URL-compatible way.
Wed, 01 Oct 2008 20:48:58 +0000 Make form field components use a smaller font, without shrinking the font
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 20:48:58 +0000] rev 250
Make form field components use a smaller font, without shrinking the font of all text in the page body.
Wed, 01 Oct 2008 19:21:09 +0000 Replace common module with validate module. Move validation function from feed module to validate module and remove feed.py. Correct any usage of validation functions from common and feed modules into validate module.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 19:21:09 +0000] rev 249
Replace common module with validate module. Move validation function from feed module to validate module and remove feed.py. Correct any usage of validation functions from common and feed modules into validate module. Patch by: Pawel Solyga Review by: to-be-reviewed
Wed, 01 Oct 2008 19:17:13 +0000 Add missing blank line to follow PythonStyleGuide in document.py
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 19:17:13 +0000] rev 248
Add missing blank line to follow PythonStyleGuide in document.py
Wed, 01 Oct 2008 19:15:20 +0000 Fixed typo in DEF_CREATE_NEW_DOC_MSG.
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 19:15:20 +0000] rev 247
Fixed typo in DEF_CREATE_NEW_DOC_MSG.
Wed, 01 Oct 2008 16:47:00 +0000 Shrink the sidebar menu separately from the main body text.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 16:47:00 +0000] rev 246
Shrink the sidebar menu separately from the main body text.
Wed, 01 Oct 2008 14:23:28 +0000 Moved isLinkNameFormatValid function out of id_user module to new common module. This function is going to be used by other form validation functions that require to validate linkname (different kind of Groups, Programs etc).
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 14:23:28 +0000] rev 245
Moved isLinkNameFormatValid function out of id_user module to new common module. This function is going to be used by other form validation functions that require to validate linkname (different kind of Groups, Programs etc). Patch by: Pawel Solyga Review by: to-be-reviewed
Wed, 01 Oct 2008 09:43:25 +0000 Fixed models based on output from graph.py script and comments on
Pawel Solyga <Pawel.Solyga@gmail.com> [Wed, 01 Oct 2008 09:43:25 +0000] rev 244
Fixed models based on output from graph.py script and comments on http://groups.google.com/group/melange-soc-dev/browse_thread/thread/fb532a7db1f19ea7
Wed, 01 Oct 2008 07:26:45 +0000 Tool to graph the data model.
Tim Ansell <mithro@gmail.com> [Wed, 01 Oct 2008 07:26:45 +0000] rev 243
Tool to graph the data model.
Wed, 01 Oct 2008 07:11:27 +0000 Some TODOs on access control that I didn't want to forget.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 07:11:27 +0000] rev 242
Some TODOs on access control that I didn't want to forget.
Wed, 01 Oct 2008 07:10:43 +0000 Matching just /docs created a very small namespace, since any other path parts
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 07:10:43 +0000] rev 241
Matching just /docs created a very small namespace, since any other path parts would match the Document path. So, append /show after /docs for the display view. This makes other views like /docs/edit possible later.
Wed, 01 Oct 2008 07:01:06 +0000 URL pattern changes that were missed by r671.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 07:01:06 +0000] rev 240
URL pattern changes that were missed by r671.
Wed, 01 Oct 2008 07:00:26 +0000 Some styles used by r671, the simplistic Document view.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 07:00:26 +0000] rev 239
Some styles used by r671, the simplistic Document view.
Wed, 01 Oct 2008 06:59:51 +0000 A very simplistic Document viewer.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 06:59:51 +0000] rev 238
A very simplistic Document viewer.
Wed, 01 Oct 2008 06:24:17 +0000 Implements a Site (Developer) generic Document editor form.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 06:24:17 +0000] rev 237
Implements a Site (Developer) generic Document editor form.
Wed, 01 Oct 2008 06:03:53 +0000 Changes to make breadcrumbs match page title. This is mostly to see how it
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 06:03:53 +0000] rev 236
Changes to make breadcrumbs match page title. This is mostly to see how it looks, since the new soc/logic/site/map.py code is going to implement the breadcrumbs and page title contents in a similar way.
Wed, 01 Oct 2008 05:17:15 +0000 Start using "Site" instead of "Developer" in the UI.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 05:17:15 +0000] rev 235
Start using "Site" instead of "Developer" in the UI.
Wed, 01 Oct 2008 05:15:29 +0000 Implement a Developer list view of all Documents.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 05:15:29 +0000] rev 234
Implement a Developer list view of all Documents. Patch by: Todd Larsen Review by: to-be-reviewed
Wed, 01 Oct 2008 05:10:41 +0000 Add missing all() __doc__ string comments: "Args:" and "Returns:" sections.
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 05:10:41 +0000] rev 233
Add missing all() __doc__ string comments: "Args:" and "Returns:" sections.
Wed, 01 Oct 2008 05:02:42 +0000 Fix some style guide issues: keyword arguments are supposed to always be
Todd Larsen <tlarsen@google.com> [Wed, 01 Oct 2008 05:02:42 +0000] rev 232
Fix some style guide issues: keyword arguments are supposed to always be supplied using the keyword argument name=value. http://code.google.com/p/soc/wiki/PythonStyleGuide#Default_Argument_Values
(0) -100 -60 +60 +100 +300 +1000 tip