James Levy <jamesalexanderlevy@gmail.com> [Sun, 05 Jul 2009 11:32:26 +0200] rev 2543
Added Menu items for all three kinds of Surveys to the program menu.
The menu items turn red when the user has not taken the Survey yet.
Patch by: James Levy, Lennard de Rijk
Reviewed by: to-be-reviewed
Daniel Diniz <ajaksu@gmail.com> [Sun, 05 Jul 2009 00:57:03 +0200] rev 2542
POST data always overwrites survey_record data when used to populate form.
It also fixes validation errors on takeGet.
Patch by: Daniel Diniz, Lennard de Rijk
Reviewed by: to-be-reviewed
Mario Ferraro <fadinlight@gmail.com> [Sat, 04 Jul 2009 18:48:58 +0100] rev 2541
Fixes bug when option name contains double quotes.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 18:53:37 +0200] rev 2540
Several style fixes due to code reviews.
Daniel Diniz <ajaksu@gmail.com> [Sat, 04 Jul 2009 17:23:19 +0200] rev 2539
Ensure that long questions and comments are stored as db.Text.
This is done by adding the setCleaners methods which sets the appropriate cleaners for dynamic fields.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 17:16:16 +0200] rev 2538
Style fix in access module.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 17:02:51 +0200] rev 2537
Returned ProjectSurvey create to checkIsUser.
The access protection is properly done by the form validator.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 16:44:08 +0200] rev 2536
Added access checks for taking a Project(Grading)Survey.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 16:23:00 +0200] rev 2535
Brown paper bag fix for using non-existing logic in ProjectSurvey views.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 15:59:19 +0200] rev 2534
Fixed basic Survey access check.
Also enabled this check for all relevant Views. However ProjectSurveys and subclasses still need an additional check. A stub for this has been added to the access module.
Daniel Diniz <ajaksu@gmail.com> [Sat, 04 Jul 2009 15:30:08 +0200] rev 2533
Fixed broken selection questions from refactoring SurveyForm.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 15:16:54 +0200] rev 2532
Fixed showing the correct list of projects for taking a Grading Project Survey.
Note that when a user is a mentor for a lot of Organizations the amount of subqueries might exceed the allowed amount. A TODO has been added to fix this issue. However this will hopefully not be a problem that pops up soon.
Also some minor docstring addition to Project Survey view.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 15:08:28 +0200] rev 2531
Refactored filter construction to _constructFilterForProjectSelection.
This allows Grading Project Survey to overwrite this method and create its own filter.
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 14:29:13 +0200] rev 2530
Make sure that radio button questions validate correctly and allow only one choice.
Reviewed by: Lennard de Rijk
Lennard de Rijk <ljvderijk@gmail.com> [Sat, 04 Jul 2009 14:22:02 +0200] rev 2529
Added Daniel Diniz and Zachary Voase to the AUTHORS file.